s4: torture: kernel oplocks. Add smb2.kernel-oplocks.kernel_oplocks8
authorJeremy Allison <jra@samba.org>
Thu, 9 Nov 2017 17:59:23 +0000 (09:59 -0800)
committerRalph Boehme <slow@samba.org>
Sat, 11 Nov 2017 19:12:26 +0000 (20:12 +0100)
Test if the server blocks whilst waiting on a kernel lease held by
a non-smbd process.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13121

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Ralph B√∂hme <slow@samba.org>
Autobuild-Date(master): Sat Nov 11 20:12:26 CET 2017 on sn-devel-144

source3/selftest/tests.py
source4/torture/smb2/oplock.c

index 186b22358751940c5eee010408355b028531be70..5b12355ac8e88faba68b2a9884477e00cdcdf70b 100755 (executable)
@@ -508,7 +508,7 @@ for t in tests:
         plansmbtorture4testsuite(t, "simpleserver", '//$SERVER/dosmode -U$USERNAME%$PASSWORD')
     elif t == "smb2.kernel-oplocks":
         if have_linux_kernel_oplocks:
-            plansmbtorture4testsuite(t, "nt4_dc", '//$SERVER/kernel_oplocks -U$USERNAME%$PASSWORD')
+            plansmbtorture4testsuite(t, "nt4_dc", '//$SERVER/kernel_oplocks -U$USERNAME%$PASSWORD --option=torture:localdir=$SELFTEST_PREFIX/nt4_dc/share')
     elif t == "smb2.notify-inotify":
         if have_inotify:
             plansmbtorture4testsuite(t, "fileserver", '//$SERVER_IP/tmp -U$USERNAME%$PASSWORD')
index 3290ed42d8c57b1b205c0cc9b06abc10e6ab935a..1830a017e8370601e25b72c27b1231fa42f8ca59 100644 (file)
@@ -36,6 +36,8 @@
 #include "torture/torture.h"
 #include "torture/smb2/proto.h"
 
+#include "lib/util/sys_rw.h"
+
 #define CHECK_RANGE(v, min, max) do { \
        if ((v) < (min) || (v) > (max)) { \
                torture_result(tctx, TORTURE_FAIL, "(%s): wrong value for %s " \
@@ -4790,6 +4792,239 @@ done:
        return ret;
 }
 
+#if HAVE_KERNEL_OPLOCKS_LINUX
+
+#ifndef F_SETLEASE
+#define F_SETLEASE      1024
+#endif
+
+#ifndef RT_SIGNAL_LEASE
+#define RT_SIGNAL_LEASE (SIGRTMIN+1)
+#endif
+
+#ifndef F_SETSIG
+#define F_SETSIG 10
+#endif
+
+static int got_break;
+
+/*
+ * Signal handler.
+ */
+
+static void got_rt_break(int sig)
+{
+       got_break = 1;
+}
+
+/*
+ * Child process function.
+ */
+
+static int do_child_process(int pipefd, const char *name)
+{
+       int ret = 0;
+       int fd = -1;
+       char c = 0;
+       struct sigaction act;
+
+       /* Set up a signal handler for RT_SIGNAL_LEASE. */
+       ZERO_STRUCT(act);
+       act.sa_handler = got_rt_break;
+       ret = sigaction(RT_SIGNAL_LEASE, &act, NULL);
+       if (ret == -1) {
+               return 1;
+       }
+       /* Open the passed in file and get a kernel oplock. */
+       fd = open(name, O_RDWR, 0666);
+       if (fd == -1) {
+               return 2;
+       }
+
+       ret = fcntl(fd, F_SETSIG, RT_SIGNAL_LEASE);
+       if (ret == -1) {
+               return 3;
+       }
+
+       ret = fcntl(fd, F_SETLEASE, F_WRLCK);
+       if (ret == -1) {
+               return 4;
+       }
+
+       /* Tell the parent we're ready. */
+       ret = sys_write(pipefd, &c, 1);
+       if (ret != 1) {
+               return 5;
+       }
+
+       /* Wait for RT_SIGNAL_LEASE. */
+       ret = pause();
+       if (ret != -1 || errno != EINTR) {
+               return 6;
+       }
+
+       if (got_break != 1) {
+               return 7;
+       }
+
+       /* Force the server to wait for 3 seconds. */
+       sleep(3);
+
+       /* Remove our lease. */
+       ret = fcntl(fd, F_SETLEASE, F_UNLCK);
+       if (ret == -1) {
+               return 8;
+       }
+
+       ret = close(fd);
+       if (ret == -1) {
+               return 9;
+       }
+
+       /* All is well. */
+       return 0;
+}
+
+static bool wait_for_child_oplock(struct torture_context *tctx,
+                               const char *localdir,
+                               const char *fname)
+{
+       int fds[2];
+       int ret;
+       pid_t pid;
+       char *name = talloc_asprintf(tctx,
+                               "%s/%s",
+                               localdir,
+                               fname);
+
+       torture_assert(tctx, name != NULL, "talloc failed");
+
+       ret = pipe(fds);
+       torture_assert(tctx, ret != -1, "pipe failed");
+
+       pid = fork();
+       torture_assert(tctx, pid != (pid_t)-1, "fork failed");
+
+       if (pid != (pid_t)0) {
+               char c;
+               /* Parent. */
+               TALLOC_FREE(name);
+               ret = sys_read(fds[0], &c, 1);
+               torture_assert(tctx, ret == 1, "read failed");
+               return true;
+       }
+
+       /* Child process. */
+       ret = do_child_process(fds[1], name);
+       _exit(ret);
+       /* Notreached. */
+}
+#else
+static bool wait_for_child_oplock(struct torture_context *tctx,
+                               const char *localdir,
+                               const char *fname)
+{
+       return false;
+}
+#endif
+
+/*
+ * Deal with a non-smbd process holding a kernel oplock.
+ */
+
+static bool test_smb2_kernel_oplocks8(struct torture_context *tctx,
+                                     struct smb2_tree *tree)
+{
+       const char *fname = "test_kernel_oplock8.dat";
+       const char *fname1 = "tmp_test_kernel_oplock8.dat";
+       NTSTATUS status;
+       bool ret = true;
+       struct smb2_create io;
+       struct smb2_request *req = NULL;
+       struct smb2_handle h1 = {{0}};
+       struct smb2_handle h2 = {{0}};
+       const char *localdir = torture_setting_string(tctx, "localdir", NULL);
+       time_t start;
+       time_t end;
+
+#ifndef HAVE_KERNEL_OPLOCKS_LINUX
+       torture_skip(tctx, "Need kernel oplocks for test");
+#endif
+
+       if (localdir == NULL) {
+               torture_skip(tctx, "Need localdir for test");
+       }
+
+       smb2_util_unlink(tree, fname);
+       smb2_util_unlink(tree, fname1);
+       status = torture_smb2_testfile(tree, fname, &h1);
+       torture_assert_ntstatus_ok_goto(tctx, status, ret, done,
+                                       "Error creating testfile\n");
+       smb2_util_close(tree, h1);
+       ZERO_STRUCT(h1);
+
+       /* Take the oplock locally in a sub-process. */
+       ret = wait_for_child_oplock(tctx, localdir, fname);
+       torture_assert_goto(tctx, ret = true, ret, done,
+               "Wait for child process failed.\n");
+
+       /*
+        * Now try and open. This should block for 3 seconds.
+        * while the child process is still alive.
+        */
+
+       ZERO_STRUCT(io);
+       io.in.desired_access = SEC_FLAG_MAXIMUM_ALLOWED;
+       io.in.file_attributes   = FILE_ATTRIBUTE_NORMAL;
+       io.in.create_disposition = NTCREATEX_DISP_OPEN;
+       io.in.share_access =
+               NTCREATEX_SHARE_ACCESS_DELETE|
+               NTCREATEX_SHARE_ACCESS_READ|
+               NTCREATEX_SHARE_ACCESS_WRITE;
+       io.in.create_options = 0;
+       io.in.fname = fname;
+
+       req = smb2_create_send(tree, &io);
+       torture_assert(tctx, req != NULL, "smb2_create_send");
+
+       /* Ensure while the open is blocked the smbd is
+          still serving other requests. */
+       io.in.fname = fname1;
+       io.in.create_disposition = NTCREATEX_DISP_CREATE;
+
+       /* Time the start -> end of the request. */
+       start = time(NULL);
+       status = smb2_create(tree, tctx, &io);
+       end = time(NULL);
+
+       /* Should succeed. */
+       torture_assert_ntstatus_ok_goto(tctx, status, ret, done,
+                       "Error opening the second file\n");
+       h1 = io.out.file.handle;
+
+       /* in less than 2 seconds. Otherwise the server blocks. */
+       torture_assert(tctx, end - start < 2, "server was blocked !");
+
+       /* Pick up the return for the initial blocking open. */
+       status = smb2_create_recv(req, tctx, &io);
+
+       /* Which should also have succeeded. */
+       torture_assert_ntstatus_ok_goto(tctx, status, ret, done,
+                       "Error opening the file\n");
+       h2 = io.out.file.handle;
+
+done:
+       if (!smb2_util_handle_empty(h1)) {
+               smb2_util_close(tree, h1);
+       }
+       if (!smb2_util_handle_empty(h2)) {
+               smb2_util_close(tree, h2);
+       }
+       smb2_util_unlink(tree, fname);
+       smb2_util_unlink(tree, fname1);
+       return ret;
+}
+
 struct torture_suite *torture_smb2_kernel_oplocks_init(TALLOC_CTX *ctx)
 {
        struct torture_suite *suite =
@@ -4802,6 +5037,7 @@ struct torture_suite *torture_smb2_kernel_oplocks_init(TALLOC_CTX *ctx)
        torture_suite_add_1smb2_test(suite, "kernel_oplocks5", test_smb2_kernel_oplocks5);
        torture_suite_add_2smb2_test(suite, "kernel_oplocks6", test_smb2_kernel_oplocks6);
        torture_suite_add_2smb2_test(suite, "kernel_oplocks7", test_smb2_kernel_oplocks7);
+       torture_suite_add_1smb2_test(suite, "kernel_oplocks8", test_smb2_kernel_oplocks8);
 
        suite->description = talloc_strdup(suite, "SMB2-KERNEL-OPLOCK tests");