s3: Fix Coverity ID 2231, REVERSE_INULL

No point in checking for !ctx after dereferencing it

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Mar 16 22:51:52 CET 2011 on sn-devel-104

diff --git a/source3/lib/netapi/cm.c b/source3/lib/netapi/cm.c
index 0e08c6d183df6aebcff04582af3337c3a217dab2..0b8220675daa2adf2d3365477ca53fdc178d7515 100644 (file)
--- a/source3/lib/netapi/cm.c
+++ b/source3/lib/netapi/cm.c
@@ -62,8 +62,7 @@ static WERROR libnetapi_open_ipc_connection(struct libnetapi_ctx *ctx,
                                            const char *server_name,
                                            struct client_ipc_connection **pp)
 {
-       struct libnetapi_private_ctx *priv_ctx =
-               (struct libnetapi_private_ctx *)ctx->private_data;
+       struct libnetapi_private_ctx *priv_ctx;
        struct user_auth_info *auth_info = NULL;
        struct cli_state *cli_ipc = NULL;
        struct client_ipc_connection *p;
@@ -72,6 +71,8 @@ static WERROR libnetapi_open_ipc_connection(struct libnetapi_ctx *ctx,
                return WERR_INVALID_PARAM;
        }
 
+       priv_ctx = (struct libnetapi_private_ctx *)ctx->private_data;
+
        p = ipc_cm_find(priv_ctx, server_name);
        if (p) {
                *pp = p;