pyldb: test return code before trying to talloc_steal

Otherwise you can have an error on the talloc_steal as the req can have
been not talloced yet

diff --git a/source4/lib/ldb/pyldb.c b/source4/lib/ldb/pyldb.c
index 57407ba0b649b4055c3eb173ade270491196585d..25f4661dce13e5132148532356d979de1f76048c 100644 (file)
--- a/source4/lib/ldb/pyldb.c
+++ b/source4/lib/ldb/pyldb.c
@@ -1212,14 +1212,14 @@ static PyObject *py_ldb_search(PyLdbObject *self, PyObject *args, PyObject *kwar
                                   ldb_search_default_callback,
                                   NULL);
 
-       talloc_steal(req, attrs);
-
        if (ret != LDB_SUCCESS) {
                talloc_free(mem_ctx);
                PyErr_LDB_ERROR_IS_ERR_RAISE(PyExc_LdbError, ret, ldb_ctx);
                return NULL;
        }
 
+       talloc_steal(req, attrs);
+
        ret = ldb_request(ldb_ctx, req);
 
        if (ret == LDB_SUCCESS) {