libsmb: Use async cli_smb2_mkdir in async cli_mkdir
authorVolker Lendecke <vl@samba.org>
Mon, 25 May 2020 16:23:31 +0000 (18:23 +0200)
committerJeremy Allison <jra@samba.org>
Thu, 28 May 2020 19:11:40 +0000 (19:11 +0000)
No need to call the sync wrapper in cli_mkdir()

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
source3/libsmb/clifile.c

index ac546c21f8bdc6b7dc7f4f4d73813cd8b68eb7e9..314893b4cf6a3c93ee72047d42c6c222fc06fb7d 100644 (file)
@@ -1982,6 +1982,7 @@ NTSTATUS cli_unlink(struct cli_state *cli, const char *fname, uint16_t mayhave_a
 ****************************************************************************/
 
 static void cli_mkdir_done(struct tevent_req *subreq);
+static void cli_mkdir_done2(struct tevent_req *subreq);
 
 struct cli_mkdir_state {
        int dummy;
@@ -2003,6 +2004,15 @@ struct tevent_req *cli_mkdir_send(TALLOC_CTX *mem_ctx,
                return NULL;
        }
 
+       if (smbXcli_conn_protocol(cli->conn) >= PROTOCOL_SMB2_02) {
+               subreq = cli_smb2_mkdir_send(state, ev, cli, dname);
+               if (tevent_req_nomem(subreq, req)) {
+                       return tevent_req_post(req, ev);
+               }
+               tevent_req_set_callback(subreq, cli_mkdir_done2, req);
+               return req;
+       }
+
        bytes = talloc_array(state, uint8_t, 1);
        if (tevent_req_nomem(bytes, req)) {
                return tevent_req_post(req, ev);
@@ -2043,6 +2053,12 @@ static void cli_mkdir_done(struct tevent_req *subreq)
        tevent_req_done(req);
 }
 
+static void cli_mkdir_done2(struct tevent_req *subreq)
+{
+       NTSTATUS status = cli_smb2_mkdir_recv(subreq);
+       tevent_req_simple_finish_ntstatus(subreq, status);
+}
+
 NTSTATUS cli_mkdir_recv(struct tevent_req *req)
 {
        return tevent_req_simple_recv_ntstatus(req);
@@ -2055,10 +2071,6 @@ NTSTATUS cli_mkdir(struct cli_state *cli, const char *dname)
        struct tevent_req *req;
        NTSTATUS status = NT_STATUS_OK;
 
-       if (smbXcli_conn_protocol(cli->conn) >= PROTOCOL_SMB2_02) {
-               return cli_smb2_mkdir(cli, dname);
-       }
-
        frame = talloc_stackframe();
 
        if (smbXcli_conn_has_async_calls(cli->conn)) {
@@ -2086,6 +2098,7 @@ NTSTATUS cli_mkdir(struct cli_state *cli, const char *dname)
        }
 
        status = cli_mkdir_recv(req);
+       cli->raw_status = status; /* cli_smb2_mkdir_recv doesn't set this */
 
  fail:
        TALLOC_FREE(frame);