ldb:tdb backend - be also here more careful with the result value
authorMatthias Dieter Wallnöfer <mwallnoefer@yahoo.de>
Tue, 27 Oct 2009 18:40:57 +0000 (19:40 +0100)
committerMatthias Dieter Wallnöfer <mwallnoefer@yahoo.de>
Tue, 27 Oct 2009 18:42:12 +0000 (19:42 +0100)
"msg_delete_attribute" doesn't return an LDB result constant.

source4/lib/ldb/ldb_tdb/ldb_tdb.c

index f1364d5875f5de71036007a31302c86214a7474c..0a77df75a713eba9394314866398bdabaf9a768b 100644 (file)
@@ -756,8 +756,8 @@ int ltdb_modify_internal(struct ldb_module *module,
                                }
                        
                                /* Delete the attribute if it exists in the DB */
-                               ret = msg_delete_attribute(module, ldb, msg2, el->name);
-                               if (ret != LDB_SUCCESS) {
+                               if (msg_delete_attribute(module, ldb, msg2, el->name) != 0) {
+                                       ret = LDB_ERR_OTHER;
                                        goto done;
                                }
                        }