s4-lsa: Fix use-after-free in LSA server
authorAndrew Bartlett <abartlet@samba.org>
Thu, 3 May 2018 04:22:19 +0000 (16:22 +1200)
committerAndrew Bartlett <abartlet@samba.org>
Thu, 3 May 2018 06:17:44 +0000 (08:17 +0200)
This is a regression introduced in ab7988aa2fd1a43f576a4b73a6893c61c7ef1957.

The state variable contains the data to be returned to the client
and packed into NDR after the function returned.

This memory needs to be kept (on mem_ctx as parent) until that is
pushed and freed by the caller.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13420

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
source4/rpc_server/lsa/lsa_lookup.c

index becbcfc..f7d367e 100644 (file)
@@ -805,7 +805,6 @@ NTSTATUS dcesrv_lsa_LookupSids(struct dcesrv_call_state *dce_call, TALLOC_CTX *m
 
        state->r.out.result = status;
        dcesrv_lsa_LookupSids_base_map(state);
-       TALLOC_FREE(state);
        return status;
 }
 
@@ -1284,7 +1283,6 @@ NTSTATUS dcesrv_lsa_LookupNames3(struct dcesrv_call_state *dce_call,
 
        state->r.out.result = status;
        dcesrv_lsa_LookupNames_base_map(state);
-       TALLOC_FREE(state);
        return status;
 }
 
@@ -1357,7 +1355,6 @@ NTSTATUS dcesrv_lsa_LookupNames4(struct dcesrv_call_state *dce_call, TALLOC_CTX
 
        state->r.out.result = status;
        dcesrv_lsa_LookupNames_base_map(state);
-       TALLOC_FREE(state);
        return status;
 }