FIXME about crash on failure case.
authorMartin Pool <mbp@samba.org>
Thu, 6 Mar 2003 07:36:08 +0000 (07:36 +0000)
committerMartin Pool <mbp@samba.org>
Thu, 6 Mar 2003 07:36:08 +0000 (07:36 +0000)
(This used to be commit a387c4209735f8e4c826cad7cb10c5349b2041ec)

source3/torture/torture.c

index 2f779b9c893bbe7e5d1b4935c2194a83ed60237a..60d7c2ba74fb91d101d3bdee89f99a1373388a6f 100644 (file)
@@ -2922,12 +2922,15 @@ static BOOL run_deletetest(int dummy)
        printf("finished delete test\n");
 
   fail:
-       
+       /* FIXME: This will crash if we aborted before cli2 got
+        * intialized, because these functions don't handle
+        * uninitialized connections. */
+               
        cli_close(&cli1, fnum1);
        cli_close(&cli1, fnum2);
        cli_setatr(&cli1, fname, 0, 0);
        cli_unlink(&cli1, fname);
-       
+
        if (!torture_close_connection(&cli1)) {
                correct = False;
        }