eventlog: Fix CID 1363194 Resource leak

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Thu Apr  5 19:11:57 CEST 2018 on sn-devel-144

diff --git a/source3/lib/eventlog/eventlog.c b/source3/lib/eventlog/eventlog.c
index cc4573c869ceb4edc80ce94ee8ba2fc9e045b622..9053fdd9a24508fa8b00f67d27726bc987f8c791 100644 (file)
--- a/source3/lib/eventlog/eventlog.c
+++ b/source3/lib/eventlog/eventlog.c
@@ -958,7 +958,7 @@ NTSTATUS evlog_tdb_entry_to_evt_entry(TALLOC_CTX *mem_ctx,
        NT_STATUS_HAVE_NO_MEMORY(e->Computername);
 
        if (t->sid_length > 0) {
-               const char *sid_str = NULL;
+               char *sid_str = NULL;
                size_t len;
                if (!convert_string_talloc(mem_ctx, CH_UTF16, CH_UNIX,
                                           t->sid.data, t->sid.length,
@@ -971,6 +971,7 @@ NTSTATUS evlog_tdb_entry_to_evt_entry(TALLOC_CTX *mem_ctx,
                                return NT_STATUS_INVALID_SID;
                        }
                }
+               TALLOC_FREE(sid_str);
        }
 
        e->Strings              = talloc_array(mem_ctx, const char *, t->num_of_strings);