ctdb/server: cppcheck: fix shiftTooManyBitsSigned error

Fixes

ctdb/server/ipalloc_lcp2.c:61: error: shiftTooManyBitsSigned: Shifting signed 32-bit value by 31 bits is undefined behaviour <--[cppcheck]

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andreas Schneider <asn@samba.org>

diff --git a/ctdb/server/ipalloc_lcp2.c b/ctdb/server/ipalloc_lcp2.c
index 565b58c9a0c6537554e66b4b8c8269cd78855566..1146bb60f16088bf58967fc532022d9ee447a6c7 100644 (file)
--- a/ctdb/server/ipalloc_lcp2.c
+++ b/ctdb/server/ipalloc_lcp2.c
@@ -58,7 +58,7 @@ static uint32_t ip_distance(ctdb_sock_addr *ip1, ctdb_sock_addr *ip2)
                        /* Count number of leading zeroes.
                         * FIXME? This could be optimised...
                         */
-                       while ((x & (1 << 31)) == 0) {
+                       while ((x & ((uint32_t)1 << 31)) == 0) {
                                x <<= 1;
                                distance += 1;
                        }