auth4: Reduce indentation level by an early error return
authorVolker Lendecke <vl@samba.org>
Thu, 23 Feb 2017 19:48:32 +0000 (20:48 +0100)
committerAndreas Schneider <asn@cryptomilk.org>
Tue, 28 Feb 2017 09:01:14 +0000 (10:01 +0100)
Just cosmetics for easier readability, no code change

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
source4/auth/ntlm/auth.c

index 656d4bc74d2afb779f8e2409aa834ee891ca7360..a1276dfcc035b2a5bd09de84d7e7aafe18ccdda1 100644 (file)
@@ -191,29 +191,33 @@ _PUBLIC_ NTSTATUS auth_check_password_wrapper(struct auth4_context *auth_ctx,
                                              DATA_BLOB *user_session_key, DATA_BLOB *lm_session_key)
 {
        struct auth_user_info_dc *user_info_dc;
-       NTSTATUS status = auth_check_password(auth_ctx, mem_ctx, user_info, &user_info_dc);
+       NTSTATUS status;
 
-       if (NT_STATUS_IS_OK(status)) {
-               *server_returned_info = user_info_dc;
+       status = auth_check_password(auth_ctx, mem_ctx, user_info,
+                                    &user_info_dc);
+       if (!NT_STATUS_IS_OK(status)) {
+               return status;
+       }
 
-               if (user_session_key) {
-                       DEBUG(10, ("Got NT session key of length %u\n",
-                                  (unsigned)user_info_dc->user_session_key.length));
-                       *user_session_key = user_info_dc->user_session_key;
-                       talloc_steal(mem_ctx, user_session_key->data);
-                       user_info_dc->user_session_key = data_blob_null;
-               }
+       *server_returned_info = user_info_dc;
 
-               if (lm_session_key) {
-                       DEBUG(10, ("Got LM session key of length %u\n",
-                                  (unsigned)user_info_dc->lm_session_key.length));
-                       *lm_session_key = user_info_dc->lm_session_key;
-                       talloc_steal(mem_ctx, lm_session_key->data);
-                       user_info_dc->lm_session_key = data_blob_null;
-               }
+       if (user_session_key) {
+               DEBUG(10, ("Got NT session key of length %u\n",
+                          (unsigned)user_info_dc->user_session_key.length));
+               *user_session_key = user_info_dc->user_session_key;
+               talloc_steal(mem_ctx, user_session_key->data);
+               user_info_dc->user_session_key = data_blob_null;
        }
 
-       return status;
+       if (lm_session_key) {
+               DEBUG(10, ("Got LM session key of length %u\n",
+                          (unsigned)user_info_dc->lm_session_key.length));
+               *lm_session_key = user_info_dc->lm_session_key;
+               talloc_steal(mem_ctx, lm_session_key->data);
+               user_info_dc->lm_session_key = data_blob_null;
+       }
+
+       return NT_STATUS_OK;
 }
 
 struct auth_check_password_state {