ldb_ldif: avoid NULL dereference with unexpected arguments (CID 1107195)
authorDouglas Bagnall <douglas.bagnall@catalyst.net.nz>
Wed, 8 May 2019 00:49:53 +0000 (12:49 +1200)
committerDouglas Bagnall <dbagnall@samba.org>
Thu, 9 May 2019 22:39:27 +0000 (22:39 +0000)
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
lib/ldb/common/ldb_ldif.c

index e69467891c90eb4a1d3b7681f26629ba8a91f9b5..2bd02663f098a07995d14041304ed99d7dec9e05 100644 (file)
@@ -728,7 +728,7 @@ int ldb_ldif_parse_modrdn(struct ldb_context *ldb,
        if (_deleteoldrdn) {
                *_deleteoldrdn = deleteoldrdn;
        }
-       if (_newsuperior) {
+       if (_newsuperior != NULL && _newrdn != NULL) {
                if (newsuperior_val) {
                        *_newrdn = talloc_move(mem_ctx, &newrdn);
                } else {