r20222: return status unsuccessful when null pointers are returned
authorRafal Szczesniak <mimir@samba.org>
Sun, 17 Dec 2006 13:01:35 +0000 (13:01 +0000)
committerGerald (Jerry) Carter <jerry@samba.org>
Wed, 10 Oct 2007 19:29:24 +0000 (14:29 -0500)
from lookup call.

rafal
(This used to be commit 0eb605cf423faee2111b3d70cef1c578564a0fb5)

source4/libnet/libnet_lookup.c

index c853885572c28f5241bea23f3492227a2667717e..e8bceb9218f64f5e35c42879b2ed1e76b5ef2a79 100644 (file)
@@ -418,7 +418,9 @@ NTSTATUS libnet_LookupName_recv(struct composite_context *c, TALLOC_CTX *mem_ctx
                        struct lsa_RefDomainList *domains = s->lookup.out.domains;
                        struct lsa_TransSidArray *sids = s->lookup.out.sids;
 
-                       /* TODO: verify if returned pointers are non-null */
+                       if (domains == NULL || sids == NULL) {
+                               composite_error(c, NT_STATUS_UNSUCCESSFUL);
+                       }
 
                        if (sids->count > 0) {
                                io->out.rid        = sids->sids[0].rid;