Revert "smbd: explain that/why we use the raw tevent_context for update_write_time_ha...
authorRalph Boehme <slow@samba.org>
Thu, 27 Dec 2018 14:26:03 +0000 (15:26 +0100)
committerStefan Metzmacher <metze@samba.org>
Fri, 11 Jan 2019 22:11:18 +0000 (23:11 +0100)
This reverts commit 7cfafaf190643eb28fc95d21a02a4e5e529e16d1.

See the discussion in

https://lists.samba.org/archive/samba-technical/2018-December/131731.html

for the reasoning behind this revert.

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
source3/smbd/fileio.c

index 1fe806e..cde6a05 100644 (file)
@@ -232,17 +232,9 @@ void trigger_write_time_update(struct files_struct *fsp)
        DEBUG(5, ("Update write time %d usec later on %s\n",
                  delay, fsp_str_dbg(fsp)));
 
-       /*
-        * trigger the update 2 seconds later
-        *
-        * Note that update_write_time_handler()
-        * => fsp_flush_write_time_update()
-        * won't do any SMB_VFS calls and don't
-        * need impersonation. So we use the
-        * raw event context for this.
-        */
+       /* trigger the update 2 seconds later */
        fsp->update_write_time_event =
-               tevent_add_timer(fsp->conn->sconn->raw_ev_ctx, NULL,
+               tevent_add_timer(fsp->conn->sconn->ev_ctx, NULL,
                                 timeval_current_ofs_usec(delay),
                                 update_write_time_handler, fsp);
 }