auth/credentials: py2/py3 credential key needs to return bytes

new_client_authenticator returns a dictionary. The key
'credential' needs to return bytes in Python3, without this
change the the code will attempt to convert the binary data to
a string (resulting sometimes in decode errors).

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

diff --git a/auth/credentials/pycredentials.c b/auth/credentials/pycredentials.c
index c626e3fa8a07c9e734e7542aedafb6fccc9b3f03..56174fefbb4f9002ba0255c32e9b24999377ab43 100644 (file)
--- a/auth/credentials/pycredentials.c
+++ b/auth/credentials/pycredentials.c
@@ -659,7 +659,7 @@ static PyObject *py_creds_new_client_authenticator(PyObject *self,
        netlogon_creds_client_authenticator(
                nc,
                &auth);
-       ret = Py_BuildValue("{ss#si}",
+       ret = Py_BuildValue("{s"PYARG_BYTES_LEN"si}",
                            "credential",
                            (const char *) &auth.cred, sizeof(auth.cred),
                            "timestamp", auth.timestamp);