ldb: Change pack format defines to enum
authorTim Beale <timbeale@catalyst.net.nz>
Tue, 30 Jul 2019 03:15:40 +0000 (15:15 +1200)
committerGarming Sam <garming@samba.org>
Tue, 20 Aug 2019 03:40:29 +0000 (03:40 +0000)
The main reason is so that any future pack formats will continue
incrementing this number in a sequential fashion.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14059

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
lib/ldb/include/ldb_module.h

index ab3d25c5c6ef069887bbc468656cb9ec610f7840..8c1e5ee7936c3a1b9af7d54369b5cfdc385244ab 100644 (file)
@@ -559,12 +559,15 @@ int ldb_unpack_get_format(const struct ldb_val *data,
 #define LDB_UNPACK_DATA_FLAG_NO_ATTRS        0x0008
 #define LDB_UNPACK_DATA_FLAG_READ_LOCKED     0x0010
 
-/* In-use packing formats */
-#define LDB_PACKING_FORMAT 0x26011967
-#define LDB_PACKING_FORMAT_V2 0x26011968
+enum ldb_pack_format {
 
-/* Old packing formats */
-#define LDB_PACKING_FORMAT_NODN 0x26011966
+       /* Old packing format (based on a somewhat arbitrary date) */
+       LDB_PACKING_FORMAT_NODN = 0x26011966,
+
+       /* In-use packing formats */
+       LDB_PACKING_FORMAT,
+       LDB_PACKING_FORMAT_V2
+};
 
 /**
  Forces a specific ldb handle to use the global event context.