tdb_chainlock_with_timeout: Add TODO: If we time out waiting for a
authorMartin Pool <mbp@samba.org>
Thu, 9 Jan 2003 07:23:23 +0000 (07:23 +0000)
committerMartin Pool <mbp@samba.org>
Thu, 9 Jan 2003 07:23:23 +0000 (07:23 +0000)
lock, it might be nice to use F_GETLK to get the pid of the process
currently holding the lock and print that as part of the debugging
message.

I'd like to have this in appliance_head, but the code is too different
so I won't worry for now.
(This used to be commit 575908cb06a653225a2fa79ecd025af0e3dafc05)

source3/tdb/tdbutil.c

index d7e4350ada90540cb347f767aae20d443da4c2e7..d66a0a4d735e1b6f8f3f091eb6855ad0173b384d 100644 (file)
@@ -62,6 +62,10 @@ static int tdb_chainlock_with_timeout( TDB_CONTEXT *tdb, TDB_DATA key, unsigned
                if (gotalarm) {
                        DEBUG(0,("tdb_chainlock_with_timeout: alarm (%u) timed out for key %s in tdb %s\n",
                                timeout, key.dptr, tdb->name ));
+                       /* TODO: If we time out waiting for a lock, it might
+                        * be nice to use F_GETLK to get the pid of the
+                        * process currently holding the lock and print that
+                        * as part of the debugging message. -- mbp */
                        return -1;
                }
        }