dsdb/modules/dirsync: avoid possible NULL dereference (CID 1034800)
authorDouglas Bagnall <douglas.bagnall@catalyst.net.nz>
Fri, 3 May 2019 05:21:49 +0000 (17:21 +1200)
committerDouglas Bagnall <dbagnall@samba.org>
Thu, 9 May 2019 22:39:27 +0000 (22:39 +0000)
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
source4/dsdb/samdb/ldb_modules/dirsync.c

index 291876e162b25daea640ce9e09d077267f91941d..6367661bd042b6d8c8d6d5de40f20222b213a969 100644 (file)
@@ -852,6 +852,9 @@ static int dirsync_search_callback(struct ldb_request *req, struct ldb_reply *ar
                }
 
                tmp = strchr(tmp, '/');
+               if (tmp == NULL) {
+                       return ldb_operr(ldb);
+               }
                tmp++;
 
                dn = ldb_dn_new(dsc, ldb, tmp);