s3:pylibsmb: Rename 'credentials' param to match s4
authorTim Beale <timbeale@catalyst.net.nz>
Wed, 12 Dec 2018 23:40:49 +0000 (12:40 +1300)
committerTim Beale <timbeale@samba.org>
Mon, 7 Jan 2019 21:48:28 +0000 (22:48 +0100)
s4 just calls it 'creds'. Renaming it will make it easier to convert
existing SMB connections over to use the new bindings.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13676

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
python/samba/tests/dcerpc/raw_testcase.py
source3/libsmb/pylibsmb.c

index ec299bf..4f3f999 100644 (file)
@@ -43,7 +43,7 @@ class smb_pipe_socket(object):
         lp3 = s3param.get_context()
         lp3.load(lp.configfile)
         self.smbconn = libsmb.Conn(target_hostname, 'IPC$', lp3,
-                                   credentials=creds, sign=True)
+                                   creds=creds, sign=True)
         self.smbfid = self.smbconn.create(pipename,
                                           DesiredAccess=0x12019f,
                                           ShareAccess=0x7,
index 21c8b4e..1c1216f 100644 (file)
@@ -440,7 +440,7 @@ static int py_cli_state_init(struct py_cli_state *self, PyObject *args,
        int flags = 0;
 
        static const char *kwlist[] = {
-               "host", "share", "lp", "credentials",
+               "host", "share", "lp", "creds",
                "multi_threaded", "sign", "force_smb1",
                NULL
        };