s4:dsdb/common: create a DSDB_SECRET_ATTRIBUTES define with all secret attributes

We should have them just in one place, so that we don't forget some of them.

metze

diff --git a/source4/dsdb/common/util.c b/source4/dsdb/common/util.c
index 79a4c143c79ca892b786cb28206889148145b79b..16d5011278f84d41449a42f99396320d8548bc66 100644 (file)
--- a/source4/dsdb/common/util.c
+++ b/source4/dsdb/common/util.c
@@ -4070,18 +4070,8 @@ int dsdb_validate_dsa_guid(struct ldb_context *ldb,
        return LDB_SUCCESS;
 }
 
-static const char *secret_attributes[] = {
-       "currentValue",
-       "dBCSPwd",
-       "initialAuthIncoming",
-       "initialAuthOutgoing",
-       "lmPwdHistory",
-       "ntPwdHistory",
-       "priorValue",
-       "supplementalCredentials",
-       "trustAuthIncoming",
-       "trustAuthOutgoing",
-       "unicodePwd",
+static const char * const secret_attributes[] = {
+       DSDB_SECRET_ATTRIBUTES,
        NULL
 };
 

diff --git a/source4/dsdb/common/util.h b/source4/dsdb/common/util.h
index fa876484cb9235e6c2d0bd56faa0554d52659d5d..a09392284dee412d6586d833c22956fad1cf2089 100644 (file)
--- a/source4/dsdb/common/util.h
+++ b/source4/dsdb/common/util.h
@@ -37,3 +37,16 @@
 #define DSDB_PROVISION                       0x0800
 
 bool is_attr_in_list(const char * const * attrs, const char *attr);
+
+#define DSDB_SECRET_ATTRIBUTES \
+       "currentValue", \
+       "dBCSPwd", \
+       "initialAuthIncoming", \
+       "initialAuthOutgoing", \
+       "lmPwdHistory", \
+       "ntPwdHistory", \
+       "priorValue", \
+       "supplementalCredentials", \
+       "trustAuthIncoming", \
+       "trustAuthOutgoing", \
+       "unicodePwd"