anders blomdell spotted an unititialised fstring causing strlen to go

awry (ascii_p16)

diff --git a/source/passdb/smbpass.c b/source/passdb/smbpass.c
index 0347df4ee9e13d8f6ef6208fac8bcab1a81b63e8..35de214425e2012e0b7bbeeff74c3f2041706d5e 100644 (file)
--- a/source/passdb/smbpass.c
+++ b/source/passdb/smbpass.c
@@ -868,6 +868,7 @@ static BOOL mod_smbfilepwd_entry(struct smb_passwd* pwd, BOOL override)
       fstrcpy(&ascii_p16[33], "XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX");
   }
   ascii_p16[65] = ':';
+  ascii_p16[66] = '\0'; /* null-terminate the string so that strlen works */
 
   /* Add on the account info bits and the time of last
      password change. */