s4/messaging: Fix undefined reference in linking libMESSAGING-samba4.so
authorAnoop C S <anoopcs@redhat.com>
Thu, 27 Dec 2018 12:49:42 +0000 (18:19 +0530)
committerAndrew Bartlett <abartlet@samba.org>
Sat, 19 Jan 2019 23:31:25 +0000 (00:31 +0100)
Early check for DEVELOPER or ENABLE_SELFTEST configure options inside
messaging_handlers.c leaves us with the following undefined reference
linkage error:

[1315/3712] Linking bin/default/source4/lib/messaging/libMESSAGING-samba4.so
/usr/bin/ld: source4/lib/messaging/messaging.c.4.o: in function
`imessaging_init_internal':
/root/samba.git/bin/default/../../source4/lib/messaging/messaging.c:472:
undefined reference to `imessaging_register_extra_handlers'
collect2: error: ld returned 1 exit status

This happened due to failure in including "includes.h" before checking
the above mentioned configure options.

Signed-off-by: Anoop C S <anoopcs@redhat.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
source4/lib/messaging/messaging_handlers.c

index aee7b66e306bbc71d088464a356f1c2c48736453..342157d5b4a080b842326e036d47157d6055e1d4 100644 (file)
    along with this program.  If not, see <http://www.gnu.org/licenses/>.
 */
 
-#if defined(DEVELOPER) || defined(ENABLE_SELFTEST)
-
 #include "includes.h"
 #include "lib/util/server_id.h"
 #include "messaging/messaging.h"
 #include "messaging/messaging_internal.h"
 
+#if defined(DEVELOPER) || defined(ENABLE_SELFTEST)
+
 /*
  * Inject a fault into the currently running process
  */