s3: VFS: vfs_full_audit. Remove readlink_fn(). No longer used.
authorJeremy Allison <jra@samba.org>
Thu, 22 Aug 2019 21:52:43 +0000 (14:52 -0700)
committerJeremy Allison <jra@samba.org>
Fri, 23 Aug 2019 18:49:37 +0000 (18:49 +0000)
NB, this will now fail smb_vfs_assert_all_fns()
until we remove the mknod_fn() from the VFS definitions.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Böhme <slow@samba.org>
source3/modules/vfs_full_audit.c

index 9773166d5d0bb6532fcb443f13dea583e7defabd..2f74c4ccc4aea7b88f6212c33ab3d688c3cbae11 100644 (file)
@@ -152,7 +152,6 @@ typedef enum _vfs_op_type {
        SMB_VFS_OP_LINUX_SETLEASE,
        SMB_VFS_OP_GETLOCK,
        SMB_VFS_OP_SYMLINK,
-       SMB_VFS_OP_READLINK,
        SMB_VFS_OP_READLINKAT,
        SMB_VFS_OP_LINKAT,
        SMB_VFS_OP_MKNODAT,
@@ -296,7 +295,6 @@ static struct {
        { SMB_VFS_OP_LINUX_SETLEASE, "linux_setlease" },
        { SMB_VFS_OP_GETLOCK,   "getlock" },
        { SMB_VFS_OP_SYMLINK,   "symlink" },
-       { SMB_VFS_OP_READLINK,  "readlink" },
        { SMB_VFS_OP_READLINKAT,"readlinkat" },
        { SMB_VFS_OP_LINKAT,    "linkat" },
        { SMB_VFS_OP_MKNODAT,   "mknodat" },
@@ -1741,21 +1739,6 @@ static int smb_full_audit_symlink(vfs_handle_struct *handle,
        return result;
 }
 
-static int smb_full_audit_readlink(vfs_handle_struct *handle,
-                       const struct smb_filename *smb_fname,
-                       char *buf,
-                       size_t bufsiz)
-{
-       int result;
-
-       result = SMB_VFS_NEXT_READLINK(handle, smb_fname, buf, bufsiz);
-
-       do_log(SMB_VFS_OP_READLINK, (result >= 0), handle, "%s",
-                       smb_fname->base_name);
-
-       return result;
-}
-
 static int smb_full_audit_readlinkat(vfs_handle_struct *handle,
                        files_struct *dirfsp,
                        const struct smb_filename *smb_fname,
@@ -2910,7 +2893,6 @@ static struct vfs_fn_pointers vfs_full_audit_fns = {
        .linux_setlease_fn = smb_full_audit_linux_setlease,
        .getlock_fn = smb_full_audit_getlock,
        .symlink_fn = smb_full_audit_symlink,
-       .readlink_fn = smb_full_audit_readlink,
        .readlinkat_fn = smb_full_audit_readlinkat,
        .linkat_fn = smb_full_audit_linkat,
        .mknodat_fn = smb_full_audit_mknodat,