git.samba.org / samba.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 01d9be2) | patch
libsmb: Fix CID 1438244 Unsigned compared against 0
authorVolker Lendecke <vl@samba.org>
Wed, 8 Aug 2018 08:08:38 +0000 (10:08 +0200)
committerJeremy Allison <jra@samba.org>
Wed, 8 Aug 2018 18:22:05 +0000 (20:22 +0200)
commitee3dd90a76f649b3bec5063cddf9293ed4d5a82c
tree0f0267f482286504ae07f99b5d48e8a8eff7fc6btree
parent01d9be278796e6ce73dd48939118ca492f08445ccommit | diff
libsmb: Fix CID 1438244 Unsigned compared against 0

ndr_size_dom_sid returns a size_t, so that can't be <0. Also, the only
case that ndr_size_dom_sid returns 0 is a NULL sid
pointer. ndr_size_dom_sid can reasonably be assumed to not overflow, the
number of sub-auths is a uint8. That times 4 plus 8 always fits into a
size_t.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
source3/libsmb/cli_smb2_fnum.c diff | blob | history
Samba Shared Repository