r6127: Eliminated all compiler warnings pertaining to mismatched "qualifiers". The
authorDerrell Lipman <derrell@samba.org>
Wed, 30 Mar 2005 04:40:24 +0000 (04:40 +0000)
committerGerald (Jerry) Carter <jerry@samba.org>
Wed, 10 Oct 2007 15:56:24 +0000 (10:56 -0500)
commit934d41d23956c663406ff9d68e5a8ba9d81b5096
tree5680eab3013a7e2f364d8ca8782bfb32d285ab99
parent7387dab585dadf710dbb72ddd211db1a1ba725c7
r6127: Eliminated all compiler warnings pertaining to mismatched "qualifiers".  The
whole of samba comiles warning-free with the default compiler flags.

Temporarily defined -Wall to locate other potential problems.  Found an
unused static function (#ifdefed out rather than deleted, in case it's
needed for something in progress).

There are also a number of uses of undeclared functions, mostly krb5_*.
Files with these problems need to have appropriate header files included,
but they are not fixed in this update.

oplock_linux.c.c has undefined functions capget() and capset(), which need
to have "#undef _POSIX_SOURCE" specified before including <sys/capability.h>,
but that could potentially have other side effects, so that remains uncorrected
as well.

The flag -Wall should be added permanently to CFLAGS, and all warnings then
generated should be eliminated.
(This used to be commit 5b19ede88ed80318e392f8017f4573fbb2ecbe0f)
14 files changed:
source3/include/smb_macros.h
source3/lib/smbldap.c
source3/libads/kerberos.c
source3/libsmb/spnego.c
source3/nsswitch/winbindd_acct.c
source3/nsswitch/winbindd_nss.h
source3/nsswitch/winbindd_rpc.c
source3/nsswitch/winbindd_util.c
source3/rpc_server/srv_svcctl_nt.c
source3/tdb/tdb.c
source3/tdb/tdbutil.c
source3/utils/net_ads.c
source3/utils/net_lookup.c
source3/utils/smbcontrol.c