s3: Fix bug 8334, do not fork the echo handler for smb2
authorVolker Lendecke <vl@samba.org>
Wed, 31 Aug 2011 13:06:35 +0000 (15:06 +0200)
committerVolker Lendecke <vlendec@samba.org>
Wed, 31 Aug 2011 15:58:48 +0000 (17:58 +0200)
commit781074664deecec5c0067fccf1baee602fd18a83
tree2ab567c9e450a8010c8290742c7af08457ff1fe8
parentda2347379e04caf5b7bbd3a6704b03e03c8bf30a
s3: Fix bug 8334, do not fork the echo handler for smb2

If a smb1 negprot negotiated smb2 we forked the echo responder. This will
eventually lead to a panic from

[2011/08/30 10:33:29.212578,  0, pid=3846917] smbd/smb2_server.c:243(smbd_smb2_request_create)
  Invalid SMB packet: first request: 0x0009

because from the echo responder we always read using the normal smb1 protocol
handling routine. If that is a bit down the smb2 stream, we get a non-negprot
packet and panic.

BTW, the echo responder is not required for smb2 anyway, Microsoft confirmed
that it probes the server liveness using TCP keepalives and not smb2 echo
requests.

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed Aug 31 17:58:48 CEST 2011 on sn-devel-104
source3/smbd/negprot.c