git.samba.org / samba.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 9b7d11b) | patch
KCC: use more efficient, less polluting dictionary operations
authorDouglas Bagnall <douglas.bagnall@catalyst.net.nz>
Fri, 1 May 2015 04:54:05 +0000 (16:54 +1200)
committerAndrew Bartlett <abartlet@samba.org>
Fri, 29 May 2015 04:58:27 +0000 (06:58 +0200)
commit73fe7ed8ecd9412df3bca2d7f510c607632fcfa0
tree1cf3b8cb9881db229bece675e09b965e9bef881dtree
parent9b7d11bf5873d8658c7d2671562628b3f867fb1acommit | diff
KCC: use more efficient, less polluting dictionary operations

`in d` is more efficient and idiomatic than `in d.keys()`.

`for v in d.values()` is better than `for k, v in d.items()` when `k`
is not used.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
python/samba/kcc_utils.py diff | blob | history
source4/scripting/bin/samba_kcc diff | blob | history
Samba Shared Repository