git.samba.org / samba.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: af5649d) | patch
idtree: fix overflow for v. large ids on allocation and removal
authorRusty Russell <rusty@rustcorp.com.au>
Mon, 6 Dec 2010 03:05:50 +0000 (13:35 +1030)
committerRusty Russell <rusty@rustcorp.com.au>
Mon, 6 Dec 2010 04:02:22 +0000 (05:02 +0100)
commit521e96ca751df072e5c71d3844ed5708b79ac69d
treed8fbcb3d84a1a50fb2d5e32cc10fbf6af7292428tree
parentaf5649d5f87e0c8b85eb950a253a4e65cca8ccd0commit | diff
idtree: fix overflow for v. large ids on allocation and removal

Chris Cowan tracked down a SEGV in sub_alloc: idp->level can actually
be equal to 7 (MAX_LEVEL) there, as it can be in sub_remove.

(We unfairly blamed a shift of a signed var for this crash in commit
 2db1987f5a3a).

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Autobuild-User: Rusty Russell <rusty@rustcorp.com.au>
Autobuild-Date: Mon Dec  6 05:02:22 CET 2010 on sn-devel-104
lib/util/idtree.c diff | blob | history
Samba Shared Repository