smbd: remove coupling between get_ea_names_from_file() and "ea support"
authorUri Simchoni <uri@samba.org>
Thu, 2 Mar 2017 06:39:56 +0000 (08:39 +0200)
committerRalph Boehme <slow@samba.org>
Thu, 2 Mar 2017 21:30:23 +0000 (22:30 +0100)
commit4bfd27b077f0932c82cfe702bd4ba6628f75a526
treeb5ae6766538cae3e7d4f7955033e012dedf9a751
parentfb95985a0325c660dd964b4132e292b9230ee097
smbd: remove coupling between get_ea_names_from_file() and "ea support"

The "ea support" configuration variable determines whether smbd
should attempt to manipulate extended attributes via SMB protocol.
It does not pertain to the underlying storage and its support for
extended attributes.

get_ea_names_from_file() is being used also by vfs_streams_xattr -
a module which has nothing to do with client-visible extended
attributes. As such, vfs_streams_xattr should be able to operate
irrespective of the value of "ea support".

This patch moves the check for ea support to the callers.

Signed-off-by: Uri Simchoni <uri@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
source3/smbd/nttrans.c
source3/smbd/trans2.c