CVE-2018-10919 security: Move object-specific access checks into separate function
authorTim Beale <timbeale@catalyst.net.nz>
Thu, 19 Jul 2018 04:03:36 +0000 (16:03 +1200)
committerKarolin Seeger <kseeger@samba.org>
Mon, 13 Aug 2018 07:13:35 +0000 (09:13 +0200)
commit2878c22070df797e633b8966bb9b129a18865d69
tree184a13cf16c9086db9d2f849c28c9eb01188138b
parent2711b6600ee3b8b51b0cbf5736a7c588390d5314
CVE-2018-10919 security: Move object-specific access checks into separate function

Object-specific access checks refer to a specific section of the
MS-ADTS, and the code closely matches the spec. We need to extend this
logic to properly handle the Control-Access Right (CR), so it makes
sense to split the logic out into its own function.

This patch just moves the code, and should not alter the logic (apart
from ading in the boolean grant_access return variable.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13434

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
libcli/security/access_check.c