smbd: reset dangling watch_req pointer in poll_open_done
authorRalph Boehme <slow@samba.org>
Wed, 17 Mar 2021 15:22:37 +0000 (16:22 +0100)
committerJeremy Allison <jra@samba.org>
Thu, 18 Mar 2021 16:52:37 +0000 (16:52 +0000)
commit065ed088b3d5710c288e46a5bf1e063f9a29c8cc
treed45314d7a3d52b9beb1d7b93941ed7279526e7f1
parent12b8dbd0bbd7ab3fef8a7e31346679bc24ea78d2
smbd: reset dangling watch_req pointer in poll_open_done

We just freed subreq and a pointer to subreq is stored in open_rec->watch_req,
so we must invalidate the pointer.

Otherwise if the poll open timer fires it will do a

  TALLOC_FREE(open_rec->watch_req);

on the dangling pointer which may crash or do something worse like freeing some
other random talloc memory.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14672
CI: https://gitlab.com/samba-team/samba/-/merge_requests/1843

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
source3/smbd/open.c