lib: Remove global xfile.h includes
[samba.git] / source4 / utils / ntlm_auth.c
index 9659541319e75ef222e6151950ae98a3a53dc5ca..a4a1c8be607ff7d56d3d7719ab8a1996cfeb9dd0 100644 (file)
 #include "includes.h"
 #include "system/filesys.h"
 #include "lib/cmdline/popt_common.h"
-#include "lib/ldb/include/ldb.h"
+#include <ldb.h>
 #include "auth/credentials/credentials.h"
 #include "auth/gensec/gensec.h"
+#include "auth/gensec/gensec_internal.h" /* TODO: remove this */
 #include "auth/auth.h"
 #include "librpc/gen_ndr/ndr_netlogon.h"
 #include "auth/auth_sam.h"
-#include "pstring.h"
 #include "libcli/auth/libcli_auth.h"
 #include "libcli/security/security.h"
 #include "lib/events/events.h"
 #include "lib/messaging/messaging.h"
 #include "lib/messaging/irpc.h"
 #include "auth/ntlmssp/ntlmssp.h"
+#include "param/param.h"
+#include "lib/util/base64.h"
+#include "lib/util/xfile.h"
 
 #define INITIAL_BUFFER_SIZE 300
 #define MAX_BUFFER_SIZE 63000
@@ -57,22 +60,27 @@ enum stdio_helper_mode {
 
 
 typedef void (*stdio_helper_function)(enum stdio_helper_mode stdio_helper_mode, 
-                                     char *buf, int length, void **private,
+                                     struct loadparm_context *lp_ctx,
+                                     char *buf, int length, void **private1,
                                      unsigned int mux_id, void **private2);
 
 static void manage_squid_basic_request (enum stdio_helper_mode stdio_helper_mode, 
-                                       char *buf, int length, void **private,
+                                       struct loadparm_context *lp_ctx,
+                                       char *buf, int length, void **private1,
                                        unsigned int mux_id, void **private2);
 
 static void manage_gensec_request (enum stdio_helper_mode stdio_helper_mode, 
-                                  char *buf, int length, void **private,
+                                  struct loadparm_context *lp_ctx,
+                                  char *buf, int length, void **private1,
                                   unsigned int mux_id, void **private2);
 
 static void manage_ntlm_server_1_request (enum stdio_helper_mode stdio_helper_mode, 
-                                         char *buf, int length, void **private,
+                                         struct loadparm_context *lp_ctx,
+                                         char *buf, int length, void **private1,
                                          unsigned int mux_id, void **private2);
 
-static void manage_squid_request(enum stdio_helper_mode helper_mode, 
+static void manage_squid_request(struct loadparm_context *lp_ctx,
+                                enum stdio_helper_mode helper_mode, 
                                 stdio_helper_function fn, void **private2);
 
 static const struct {
@@ -98,6 +106,7 @@ static const char *opt_workstation;
 static const char *opt_password;
 static int opt_multiplex;
 static int use_cached_creds;
+static int opt_allow_mschapv2;
 
 
 static void mux_printf(unsigned int mux_id, const char *format, ...) PRINTF_ATTRIBUTE(2, 3);
@@ -120,62 +129,36 @@ static void mux_printf(unsigned int mux_id, const char *format, ...)
 /* Copy of parse_domain_user from winbindd_util.c.  Parse a string of the
    form DOMAIN/user into a domain and a user */
 
-static bool parse_ntlm_auth_domain_user(const char *domuser, fstring domain, 
-                                       fstring user)
+static bool parse_ntlm_auth_domain_user(const char *domuser, char **domain, 
+                                                                               char **user, char winbind_separator)
 {
 
-       char *p = strchr(domuser,*lp_winbind_separator());
+       char *p = strchr(domuser, winbind_separator);
 
        if (!p) {
-               return False;
+               return false;
        }
         
-       fstrcpy(user, p+1);
-       fstrcpy(domain, domuser);
-       domain[PTR_DIFF(p, domuser)] = 0;
-
-       return True;
-}
-
-/**
- * Decode a base64 string into a DATA_BLOB - simple and slow algorithm
- **/
-static DATA_BLOB base64_decode_data_blob(TALLOC_CTX *mem_ctx, const char *s)
-{
-       DATA_BLOB ret = data_blob_talloc(mem_ctx, s, strlen(s)+1);
-       ret.length = ldb_base64_decode((char *)ret.data);
-       return ret;
-}
-
-/**
- * Encode a base64 string into a talloc()ed string caller to free.
- **/
-static char *base64_encode_data_blob(TALLOC_CTX *mem_ctx, DATA_BLOB data)
-{
-       return ldb_base64_encode(mem_ctx, (const char *)data.data, data.length);
-}
+       *user = smb_xstrdup(p+1);
+       *domain = smb_xstrdup(domuser);
+       (*domain)[PTR_DIFF(p, domuser)] = 0;
 
-/**
- * Decode a base64 string in-place - wrapper for the above
- **/
-static void base64_decode_inplace(char *s)
-{
-       ldb_base64_decode(s);
+       return true;
 }
 
 
-
 /* Authenticate a user with a plaintext password */
 
-static BOOL check_plaintext_auth(const char *user, const char *pass, 
-                                BOOL stdout_diagnostics)
+static bool check_plaintext_auth(const char *user, const char *pass, 
+                                bool stdout_diagnostics)
 {
         return (strcmp(pass, opt_password) == 0);
 }
 
 /* authenticate a user with an encrypted username/password */
 
-static NTSTATUS local_pw_check_specified(const char *username, 
+static NTSTATUS local_pw_check_specified(struct loadparm_context *lp_ctx,
+                                        const char *username, 
                                         const char *domain, 
                                         const char *workstation,
                                         const DATA_BLOB *challenge, 
@@ -194,6 +177,7 @@ static NTSTATUS local_pw_check_specified(const char *username,
        if (!mem_ctx) {
                nt_status = NT_STATUS_NO_MEMORY;
        } else {
+               uint32_t logon_parameters = 0;
                
                E_md4hash(opt_password, nt_pw.hash);
                if (E_deshash(opt_password, lm_pw.hash)) {
@@ -203,8 +187,14 @@ static NTSTATUS local_pw_check_specified(const char *username,
                }
                nt_pwd = &nt_pw;
                
+               if (opt_allow_mschapv2) {
+                       logon_parameters |= MSV1_0_ALLOW_MSVCHAPV2;
+               }
                
                nt_status = ntlm_password_check(mem_ctx, 
+                                               lpcfg_lanman_auth(lp_ctx),
+                                               lpcfg_ntlm_auth(lp_ctx),
+                                               logon_parameters |
                                                MSV1_0_ALLOW_SERVER_TRUST_ACCOUNT |
                                                MSV1_0_ALLOW_WORKSTATION_TRUST_ACCOUNT,
                                                challenge,
@@ -217,10 +207,11 @@ static NTSTATUS local_pw_check_specified(const char *username,
                
                if (NT_STATUS_IS_OK(nt_status)) {
                        if (unix_name) {
-                               asprintf(unix_name, 
-                                        "%s%c%s", domain,
-                                        *lp_winbind_separator(), 
-                                        username);
+                               if (asprintf(unix_name, "%s%c%s", domain,
+                                            *lpcfg_winbind_separator(lp_ctx),
+                                            username) < 0) {
+                                       nt_status = NT_STATUS_NO_MEMORY;
+                               }
                        }
                } else {
                        DEBUG(3, ("Login for user [%s]\\[%s]@[%s] failed due to [%s]\n", 
@@ -238,7 +229,8 @@ static NTSTATUS local_pw_check_specified(const char *username,
 }
 
 static void manage_squid_basic_request(enum stdio_helper_mode stdio_helper_mode, 
-                                      char *buf, int length, void **private,
+                                      struct loadparm_context *lp_ctx,
+                                      char *buf, int length, void **private1,
                                       unsigned int mux_id, void **private2) 
 {
        char *user, *pass;      
@@ -258,7 +250,7 @@ static void manage_squid_basic_request(enum stdio_helper_mode stdio_helper_mode,
                rfc1738_unescape(pass);
        }
        
-       if (check_plaintext_auth(user, pass, False)) {
+       if (check_plaintext_auth(user, pass, false)) {
                mux_printf(mux_id, "OK\n");
        } else {
                mux_printf(mux_id, "ERR\n");
@@ -269,30 +261,31 @@ static void manage_squid_basic_request(enum stdio_helper_mode stdio_helper_mode,
    to the calling application.  The callback comes from within gensec */
 
 static void manage_gensec_get_pw_request(enum stdio_helper_mode stdio_helper_mode, 
-                                        char *buf, int length, void **private,
+                                        struct loadparm_context *lp_ctx,
+                                        char *buf, int length, void **private1,
                                         unsigned int mux_id, void **password)  
 {
        DATA_BLOB in;
        if (strlen(buf) < 2) {
                DEBUG(1, ("query [%s] invalid", buf));
-               mux_printf(mux_id, "BH\n");
+               mux_printf(mux_id, "BH Query invalid\n");
                return;
        }
 
        if (strlen(buf) > 3) {
-               in = base64_decode_data_blob(NULL, buf + 3);
+               in = base64_decode_data_blob(buf + 3);
        } else {
                in = data_blob(NULL, 0);
        }
 
        if (strncmp(buf, "PW ", 3) == 0) {
 
-               *password = talloc_strndup(*private /* hopefully the right gensec context, useful to use for talloc */,
+               *password = talloc_strndup(*private1 /* hopefully the right gensec context, useful to use for talloc */,
                                           (const char *)in.data, in.length);
                
                if (*password == NULL) {
                        DEBUG(1, ("Out of memory\n"));
-                       mux_printf(mux_id, "BH\n");
+                       mux_printf(mux_id, "BH Out of memory\n");
                        data_blob_free(&in);
                        return;
                }
@@ -302,25 +295,26 @@ static void manage_gensec_get_pw_request(enum stdio_helper_mode stdio_helper_mod
                return;
        }
        DEBUG(1, ("Asked for (and expected) a password\n"));
-       mux_printf(mux_id, "BH\n");
+       mux_printf(mux_id, "BH Expected a password\n");
        data_blob_free(&in);
 }
 
 /** 
- * Callback for password credentails.  This is not async, and when
- * GENSEC and the credentails code is made async, it will look rather
+ * Callback for password credentials.  This is not async, and when
+ * GENSEC and the credentials code is made async, it will look rather
  * different.
  */
 
 static const char *get_password(struct cli_credentials *credentials) 
 {
        char *password = NULL;
-       
+       void *cb = cli_credentials_callback_data_void(credentials);
+
        /* Ask for a password */
-       mux_printf((unsigned int)credentials->priv_data, "PW\n");
-       credentials->priv_data = NULL;
+       mux_printf((unsigned int)(uintptr_t)cb, "PW\n");
+       cli_credentials_set_callback_data(credentials, NULL);
 
-       manage_squid_request(NUM_HELPER_MODES /* bogus */, manage_gensec_get_pw_request, (void **)&password);
+       manage_squid_request(cmdline_lp_ctx, NUM_HELPER_MODES /* bogus */, manage_gensec_get_pw_request, (void **)&password);
        return password;
 }
 
@@ -329,37 +323,47 @@ static const char *get_password(struct cli_credentials *credentials)
 **/
 static bool in_list(const char *s, const char *list, bool casesensitive)
 {
-       pstring tok;
+       char *tok;
+       size_t tok_len = 1024;
        const char *p=list;
 
        if (!list)
                return false;
 
-       while (next_token(&p, tok, LIST_SEP, sizeof(tok))) {
-               if ((casesensitive?strcmp:strcasecmp_m)(tok,s) == 0)
+       tok = (char *)malloc(tok_len);
+       if (!tok) {
+               return false;
+       }
+
+       while (next_token(&p, tok, LIST_SEP, tok_len)) {
+               if ((casesensitive?strcmp:strcasecmp_m)(tok,s) == 0) {
+                       free(tok);
                        return true;
+               }
        }
+       free(tok);
        return false;
 }
 
 static void gensec_want_feature_list(struct gensec_security *state, char* feature_list)
 {
-       if (in_list("NTLMSSP_FEATURE_SESSION_KEY", feature_list, True)) {
+       if (in_list("NTLMSSP_FEATURE_SESSION_KEY", feature_list, true)) {
                DEBUG(10, ("want GENSEC_FEATURE_SESSION_KEY\n"));
                gensec_want_feature(state, GENSEC_FEATURE_SESSION_KEY);
        }
-       if (in_list("NTLMSSP_FEATURE_SIGN", feature_list, True)) {
+       if (in_list("NTLMSSP_FEATURE_SIGN", feature_list, true)) {
                DEBUG(10, ("want GENSEC_FEATURE_SIGN\n"));
                gensec_want_feature(state, GENSEC_FEATURE_SIGN);
        }
-       if (in_list("NTLMSSP_FEATURE_SEAL", feature_list, True)) {
+       if (in_list("NTLMSSP_FEATURE_SEAL", feature_list, true)) {
                DEBUG(10, ("want GENSEC_FEATURE_SEAL\n"));
                gensec_want_feature(state, GENSEC_FEATURE_SEAL);
        }
 }
 
 static void manage_gensec_request(enum stdio_helper_mode stdio_helper_mode, 
-                                 char *buf, int length, void **private,
+                                 struct loadparm_context *lp_ctx,
+                                 char *buf, int length, void **private1,
                                  unsigned int mux_id, void **private2) 
 {
        DATA_BLOB in;
@@ -371,11 +375,11 @@ static void manage_gensec_request(enum stdio_helper_mode stdio_helper_mode,
                const char *set_password;
        };
        struct gensec_ntlm_state *state;
-       struct event_context *ev;
-       struct messaging_context *msg;
+       struct tevent_context *ev;
+       struct imessaging_context *msg;
 
        NTSTATUS nt_status;
-       BOOL first = False;
+       bool first = false;
        const char *reply_code;
        struct cli_credentials *creds;
 
@@ -384,15 +388,15 @@ static void manage_gensec_request(enum stdio_helper_mode stdio_helper_mode,
 
        TALLOC_CTX *mem_ctx;
 
-       if (*private) {
-               state = (struct gensec_ntlm_state *)*private;
+       if (*private1) {
+               state = (struct gensec_ntlm_state *)*private1;
        } else {
                state = talloc_zero(NULL, struct gensec_ntlm_state);
                if (!state) {
                        mux_printf(mux_id, "BH No Memory\n");
                        exit(1);
                }
-               *private = state;
+               *private1 = state;
                if (opt_password) {
                        state->set_password = opt_password;
                }
@@ -400,7 +404,7 @@ static void manage_gensec_request(enum stdio_helper_mode stdio_helper_mode,
        
        if (strlen(buf) < 2) {
                DEBUG(1, ("query [%s] invalid", buf));
-               mux_printf(mux_id, "BH\n");
+               mux_printf(mux_id, "BH Query invalid\n");
                return;
        }
 
@@ -412,7 +416,7 @@ static void manage_gensec_request(enum stdio_helper_mode stdio_helper_mode,
                        mux_printf(mux_id, "OK\n");
                        return;
                }
-               in = base64_decode_data_blob(NULL, buf + 3);
+               in = base64_decode_data_blob(buf + 3);
        } else {
                in = data_blob(NULL, 0);
        }
@@ -424,7 +428,7 @@ static void manage_gensec_request(enum stdio_helper_mode stdio_helper_mode,
                }
        } else if ( (strncmp(buf, "OK", 2) == 0)) {
                /* Just return BH, like ntlm_auth from Samba 3 does. */
-               mux_printf(mux_id, "BH\n");
+               mux_printf(mux_id, "BH Command expected\n");
                data_blob_free(&in);
                return;
        } else if ( (strncmp(buf, "TT ", 3) != 0) &&
@@ -436,11 +440,18 @@ static void manage_gensec_request(enum stdio_helper_mode stdio_helper_mode,
                    (strncmp(buf, "GK", 2) != 0) &&
                    (strncmp(buf, "GF", 2) != 0)) {
                DEBUG(1, ("SPNEGO request [%s] invalid\n", buf));
-               mux_printf(mux_id, "BH\n");
+               mux_printf(mux_id, "BH SPNEGO request invalid\n");
                data_blob_free(&in);
                return;
        }
 
+       ev = s4_event_context_init(state);
+       if (!ev) {
+               exit(1);
+       }
+
+       mem_ctx = talloc_named(NULL, 0, "manage_gensec_request internal mem_ctx");
+
        /* setup gensec */
        if (!(state->gensec_state)) {
                switch (stdio_helper_mode) {
@@ -448,32 +459,53 @@ static void manage_gensec_request(enum stdio_helper_mode stdio_helper_mode,
                case NTLMSSP_CLIENT_1:
                        /* setup the client side */
 
-                       nt_status = gensec_client_start(NULL, &state->gensec_state, NULL);
+                       nt_status = gensec_client_start(NULL, &state->gensec_state,
+                                                       lpcfg_gensec_settings(NULL, lp_ctx));
                        if (!NT_STATUS_IS_OK(nt_status)) {
+                               talloc_free(mem_ctx);
                                exit(1);
                        }
 
                        break;
                case GSS_SPNEGO_SERVER:
                case SQUID_2_5_NTLMSSP:
-                       ev = event_context_init(state);
-                       if (!ev) {
+               {
+                       const char *winbind_method[] = { "winbind", NULL };
+                       struct auth4_context *auth_context;
+
+                       msg = imessaging_client_init(state, lp_ctx, ev);
+                       if (!msg) {
+                               talloc_free(mem_ctx);
                                exit(1);
                        }
-                       msg = messaging_client_init(state, ev);
-                       if (!msg) {
+                       nt_status = auth_context_create_methods(mem_ctx, 
+                                                               winbind_method,
+                                                               ev, 
+                                                               msg, 
+                                                               lp_ctx,
+                                                               NULL,
+                                                               &auth_context);
+       
+                       if (!NT_STATUS_IS_OK(nt_status)) {
+                               talloc_free(mem_ctx);
                                exit(1);
                        }
-                       if (!NT_STATUS_IS_OK(gensec_server_start(state, ev, msg, &state->gensec_state))) {
+                       
+                       if (!NT_STATUS_IS_OK(gensec_server_start(state,
+                                                                lpcfg_gensec_settings(state, lp_ctx),
+                                                                auth_context, &state->gensec_state))) {
+                               talloc_free(mem_ctx);
                                exit(1);
                        }
                        break;
+               }
                default:
+                       talloc_free(mem_ctx);
                        abort();
                }
 
                creds = cli_credentials_init(state->gensec_state);
-               cli_credentials_set_conf(creds);
+               cli_credentials_set_conf(creds, lp_ctx);
                if (opt_username) {
                        cli_credentials_set_username(creds, opt_username, CRED_SPECIFIED);
                }
@@ -483,8 +515,9 @@ static void manage_gensec_request(enum stdio_helper_mode stdio_helper_mode,
                if (state->set_password) {
                        cli_credentials_set_password(creds, state->set_password, CRED_SPECIFIED);
                } else {
+                       void *cb = (void*)(uintptr_t)mux_id;
+                       cli_credentials_set_callback_data(creds, cb);
                        cli_credentials_set_password_callback(creds, get_password);
-                       creds->priv_data = (void*)mux_id;
                }
                if (opt_workstation) {
                        cli_credentials_set_workstation(creds, opt_workstation, CRED_SPECIFIED);
@@ -493,7 +526,7 @@ static void manage_gensec_request(enum stdio_helper_mode stdio_helper_mode,
                switch (stdio_helper_mode) {
                case GSS_SPNEGO_SERVER:
                case SQUID_2_5_NTLMSSP:
-                       cli_credentials_set_machine_account(creds);
+                       cli_credentials_set_machine_account(creds, lp_ctx);
                        break;
                default:
                        break;
@@ -507,32 +540,33 @@ static void manage_gensec_request(enum stdio_helper_mode stdio_helper_mode,
                case GSS_SPNEGO_SERVER:
                        nt_status = gensec_start_mech_by_oid(state->gensec_state, GENSEC_OID_SPNEGO);
                        if (!in.length) {
-                               first = True;
+                               first = true;
                        }
                        break;
                case NTLMSSP_CLIENT_1:
                        if (!in.length) {
-                               first = True;
+                               first = true;
                        }
                        /* fall through */
                case SQUID_2_5_NTLMSSP:
                        nt_status = gensec_start_mech_by_oid(state->gensec_state, GENSEC_OID_NTLMSSP);
                        break;
                default:
+                       talloc_free(mem_ctx);
                        abort();
                }
 
                if (!NT_STATUS_IS_OK(nt_status)) {
                        DEBUG(1, ("GENSEC mech failed to start: %s\n", nt_errstr(nt_status)));
-                       mux_printf(mux_id, "BH\n");
+                       mux_printf(mux_id, "BH GENSEC mech failed to start\n");
+                       talloc_free(mem_ctx);
                        return;
                }
 
        }
 
        /* update */
-       mem_ctx = talloc_named(NULL, 0, "manage_gensec_request internal mem_ctx");
-       
+
        if (strncmp(buf, "PW ", 3) == 0) {
                state->set_password = talloc_strndup(state,
                                                     (const char *)in.data, 
@@ -552,7 +586,7 @@ static void manage_gensec_request(enum stdio_helper_mode stdio_helper_mode,
                char *grouplist = NULL;
                struct auth_session_info *session_info;
 
-               nt_status = gensec_session_info(state->gensec_state, &session_info); 
+               nt_status = gensec_session_info(state->gensec_state, mem_ctx, &session_info);
                if (!NT_STATUS_IS_OK(nt_status)) {
                        DEBUG(1, ("gensec_session_info failed: %s\n", nt_errstr(nt_status)));
                        mux_printf(mux_id, "BH %s\n", nt_errstr(nt_status));
@@ -567,8 +601,8 @@ static void manage_gensec_request(enum stdio_helper_mode stdio_helper_mode,
                for (i=0; i<session_info->security_token->num_sids; i++) {
                        struct security_token *token = session_info->security_token; 
                        const char *sidstr = dom_sid_string(session_info, 
-                                                           token->sids[i]);
-                       grouplist = talloc_asprintf_append(grouplist, "%s,", sidstr);
+                                                           &token->sids[i]);
+                       grouplist = talloc_asprintf_append_buffer(grouplist, "%s,", sidstr);
                }
 
                mux_printf(mux_id, "GL %s\n", grouplist);
@@ -581,7 +615,7 @@ static void manage_gensec_request(enum stdio_helper_mode stdio_helper_mode,
        if (strncmp(buf, "GK", 2) == 0) {
                char *base64_key;
                DEBUG(10, ("Requested session key\n"));
-               nt_status = gensec_session_key(state->gensec_state, &session_key);
+               nt_status = gensec_session_key(state->gensec_state, mem_ctx, &session_key);
                if(!NT_STATUS_IS_OK(nt_status)) {
                        DEBUG(1, ("gensec_session_key failed: %s\n", nt_errstr(nt_status)));
                        mux_printf(mux_id, "BH No session key\n");
@@ -589,6 +623,7 @@ static void manage_gensec_request(enum stdio_helper_mode stdio_helper_mode,
                        return;
                } else {
                        base64_key = base64_encode_data_blob(state, session_key);
+                       SMB_ASSERT(base64_key != NULL);
                        mux_printf(mux_id, "GK %s\n", base64_key);
                        talloc_free(base64_key);
                }
@@ -597,25 +632,26 @@ static void manage_gensec_request(enum stdio_helper_mode stdio_helper_mode,
        }
 
        if (strncmp(buf, "GF", 2) == 0) {
-               struct gensec_ntlmssp_state *gensec_ntlmssp_state;
+               struct ntlmssp_state *ntlmssp_state;
                uint32_t neg_flags;
 
-               gensec_ntlmssp_state = talloc_get_type(state->gensec_state->private_data, 
-                               struct gensec_ntlmssp_state);
-               neg_flags = gensec_ntlmssp_state->neg_flags;
+               ntlmssp_state = talloc_get_type(state->gensec_state->private_data,
+                               struct ntlmssp_state);
+               neg_flags = ntlmssp_state->neg_flags;
 
                DEBUG(10, ("Requested negotiated feature flags\n"));
                mux_printf(mux_id, "GF 0x%08x\n", neg_flags);
                return;
        }
 
-       nt_status = gensec_update(state->gensec_state, mem_ctx, in, &out);
+       nt_status = gensec_update_ev(state->gensec_state, mem_ctx, ev, in, &out);
        
        /* don't leak 'bad password'/'no such user' info to the network client */
-       nt_status = auth_nt_status_squash(nt_status);
+       nt_status = nt_status_squash(nt_status);
 
        if (out.length) {
                out_base64 = base64_encode_data_blob(mem_ctx, out);
+               SMB_ASSERT(out_base64 != NULL);
        } else {
                out_base64 = NULL;
        }
@@ -634,11 +670,11 @@ static void manage_gensec_request(enum stdio_helper_mode stdio_helper_mode,
 
 
        } else if (NT_STATUS_EQUAL(nt_status, NT_STATUS_ACCESS_DENIED)) {
-               reply_code = "BH";
+               reply_code = "BH NT_STATUS_ACCESS_DENIED";
                reply_arg = nt_errstr(nt_status);
                DEBUG(1, ("GENSEC login failed: %s\n", nt_errstr(nt_status)));
        } else if (NT_STATUS_EQUAL(nt_status, NT_STATUS_UNSUCCESSFUL)) {
-               reply_code = "BH";
+               reply_code = "BH NT_STATUS_UNSUCCESSFUL";
                reply_arg = nt_errstr(nt_status);
                DEBUG(1, ("GENSEC login failed: %s\n", nt_errstr(nt_status)));
        } else if (!NT_STATUS_IS_OK(nt_status)) {
@@ -648,17 +684,17 @@ static void manage_gensec_request(enum stdio_helper_mode stdio_helper_mode,
        } else if /* OK */ (state->gensec_state->gensec_role == GENSEC_SERVER) {
                struct auth_session_info *session_info;
 
-               nt_status = gensec_session_info(state->gensec_state, &session_info);
+               nt_status = gensec_session_info(state->gensec_state, mem_ctx, &session_info);
                if (!NT_STATUS_IS_OK(nt_status)) {
-                       reply_code = "BH";
+                       reply_code = "BH Failed to retrive session info";
                        reply_arg = nt_errstr(nt_status);
-                       DEBUG(1, ("GENSEC failed to retreive the session info: %s\n", nt_errstr(nt_status)));
+                       DEBUG(1, ("GENSEC failed to retrieve the session info: %s\n", nt_errstr(nt_status)));
                } else {
 
                        reply_code = "AF";
                        reply_arg = talloc_asprintf(state->gensec_state, 
-                                                   "%s%s%s", session_info->server_info->domain_name, 
-                                                   lp_winbind_separator(), session_info->server_info->account_name);
+                                                   "%s%s%s", session_info->info->domain_name,
+                                                   lpcfg_winbind_separator(lp_ctx), session_info->info->account_name);
                        talloc_free(session_info);
                }
        } else if (state->gensec_state->gensec_role == GENSEC_CLIENT) {
@@ -689,7 +725,8 @@ static void manage_gensec_request(enum stdio_helper_mode stdio_helper_mode,
 }
 
 static void manage_ntlm_server_1_request(enum stdio_helper_mode stdio_helper_mode, 
-                                        char *buf, int length, void **private,
+                                        struct loadparm_context *lp_ctx,
+                                        char *buf, int length, void **private1,
                                         unsigned int mux_id, void **private2) 
 {
        char *request, *parameter;      
@@ -700,8 +737,8 @@ static void manage_ntlm_server_1_request(enum stdio_helper_mode stdio_helper_mod
        static char *username;
        static char *domain;
        static char *plaintext_password;
-       static BOOL ntlm_server_1_user_session_key;
-       static BOOL ntlm_server_1_lm_session_key;
+       static bool ntlm_server_1_user_session_key;
+       static bool ntlm_server_1_lm_session_key;
        
        if (strequal(buf, ".")) {
                if (!full_username && !username) {      
@@ -709,12 +746,12 @@ static void manage_ntlm_server_1_request(enum stdio_helper_mode stdio_helper_mod
                } else if (plaintext_password) {
                        /* handle this request as plaintext */
                        if (!full_username) {
-                               if (asprintf(&full_username, "%s%c%s", domain, *lp_winbind_separator(), username) == -1) {
+                               if (asprintf(&full_username, "%s%c%s", domain, *lpcfg_winbind_separator(lp_ctx), username) < 0) {
                                        mux_printf(mux_id, "Error: Out of memory in asprintf!\n.\n");
                                        return;
                                }
                        }
-                       if (check_plaintext_auth(full_username, plaintext_password, False)) {
+                       if (check_plaintext_auth(full_username, plaintext_password, false)) {
                                mux_printf(mux_id, "Authenticated: Yes\n");
                        } else {
                                mux_printf(mux_id, "Authenticated: No\n");
@@ -730,21 +767,18 @@ static void manage_ntlm_server_1_request(enum stdio_helper_mode stdio_helper_mod
                        uint32_t flags = 0;
 
                        if (full_username && !username) {
-                               fstring fstr_user;
-                               fstring fstr_domain;
-                               
-                               if (!parse_ntlm_auth_domain_user(full_username, fstr_user, fstr_domain)) {
+                               SAFE_FREE(username);
+                               SAFE_FREE(domain);
+                               if (!parse_ntlm_auth_domain_user(full_username, &username, 
+                                                                                                &domain, 
+                                                                                                *lpcfg_winbind_separator(lp_ctx))) {
                                        /* username might be 'tainted', don't print into our new-line deleimianted stream */
                                        mux_printf(mux_id, "Error: Could not parse into domain and username\n");
                                }
-                               SAFE_FREE(username);
-                               SAFE_FREE(domain);
-                               username = smb_xstrdup(fstr_user);
-                               domain = smb_xstrdup(fstr_domain);
                        }
 
                        if (!domain) {
-                               domain = smb_xstrdup(lp_workgroup());
+                               domain = smb_xstrdup(lpcfg_workgroup(lp_ctx));
                        }
 
                        if (ntlm_server_1_lm_session_key) 
@@ -754,9 +788,10 @@ static void manage_ntlm_server_1_request(enum stdio_helper_mode stdio_helper_mod
                                flags |= NTLM_AUTH_FLAG_USER_SESSION_KEY;
 
                        if (!NT_STATUS_IS_OK(
-                                   local_pw_check_specified(username, 
+                                   local_pw_check_specified(lp_ctx,
+                                                            username, 
                                                              domain, 
-                                                             lp_netbios_name(),
+                                                             lpcfg_netbios_name(lp_ctx),
                                                              &challenge, 
                                                              &lm_response, 
                                                              &nt_response, 
@@ -771,8 +806,6 @@ static void manage_ntlm_server_1_request(enum stdio_helper_mode stdio_helper_mod
                                SAFE_FREE(error_string);
                        } else {
                                static char zeros[16];
-                               char *hex_lm_key;
-                               char *hex_user_session_key;
 
                                mux_printf(mux_id, "Authenticated: Yes\n");
 
@@ -780,22 +813,22 @@ static void manage_ntlm_server_1_request(enum stdio_helper_mode stdio_helper_mod
                                    && lm_key.length 
                                    && (memcmp(zeros, lm_key.data, 
                                                                lm_key.length) != 0)) {
-                                       hex_encode(lm_key.data,
-                                                  lm_key.length,
-                                                  &hex_lm_key);
+                                       char hex_lm_key[lm_key.length*2+1];
+                                       hex_encode_buf(hex_lm_key, lm_key.data,
+                                                      lm_key.length);
                                        mux_printf(mux_id, "LANMAN-Session-Key: %s\n", hex_lm_key);
-                                       SAFE_FREE(hex_lm_key);
                                }
 
                                if (ntlm_server_1_user_session_key 
                                    && user_session_key.length 
                                    && (memcmp(zeros, user_session_key.data, 
                                               user_session_key.length) != 0)) {
-                                       hex_encode(user_session_key.data, 
-                                                  user_session_key.length, 
-                                                  &hex_user_session_key);
+                                       char hex_user_session_key[
+                                               user_session_key.length*2+1];
+                                       hex_encode_buf(hex_user_session_key,
+                                                      user_session_key.data,
+                                                      user_session_key.length);
                                        mux_printf(mux_id, "User-Session-Key: %s\n", hex_user_session_key);
-                                       SAFE_FREE(hex_user_session_key);
                                }
                        }
                }
@@ -807,8 +840,8 @@ static void manage_ntlm_server_1_request(enum stdio_helper_mode stdio_helper_mod
                SAFE_FREE(username);
                SAFE_FREE(domain);
                SAFE_FREE(plaintext_password);
-               ntlm_server_1_user_session_key = False;
-               ntlm_server_1_lm_session_key = False;
+               ntlm_server_1_user_session_key = false;
+               ntlm_server_1_lm_session_key = false;
                mux_printf(mux_id, ".\n");
 
                return;
@@ -844,7 +877,7 @@ static void manage_ntlm_server_1_request(enum stdio_helper_mode stdio_helper_mod
        }
 
        if (strequal(request, "LANMAN-Challenge")) {
-               challenge = strhex_to_data_blob(parameter);
+               challenge = strhex_to_data_blob(NULL, parameter);
                if (challenge.length != 8) {
                        mux_printf(mux_id, "Error: hex decode of %s failed! (got %d bytes, expected 8)\n.\n", 
                                  parameter,
@@ -852,7 +885,7 @@ static void manage_ntlm_server_1_request(enum stdio_helper_mode stdio_helper_mod
                        challenge = data_blob(NULL, 0);
                }
        } else if (strequal(request, "NT-Response")) {
-               nt_response = strhex_to_data_blob(parameter);
+               nt_response = strhex_to_data_blob(NULL, parameter);
                if (nt_response.length < 24) {
                        mux_printf(mux_id, "Error: hex decode of %s failed! (only got %d bytes, needed at least 24)\n.\n", 
                                  parameter,
@@ -860,7 +893,7 @@ static void manage_ntlm_server_1_request(enum stdio_helper_mode stdio_helper_mod
                        nt_response = data_blob(NULL, 0);
                }
        } else if (strequal(request, "LANMAN-Response")) {
-               lm_response = strhex_to_data_blob(parameter);
+               lm_response = strhex_to_data_blob(NULL, parameter);
                if (lm_response.length != 24) {
                        mux_printf(mux_id, "Error: hex decode of %s failed! (got %d bytes, expected 24)\n.\n", 
                                  parameter,
@@ -884,7 +917,7 @@ static void manage_ntlm_server_1_request(enum stdio_helper_mode stdio_helper_mod
        }
 }
 
-static void manage_squid_request(enum stdio_helper_mode helper_mode, 
+static void manage_squid_request(struct loadparm_context *lp_ctx, enum stdio_helper_mode helper_mode,
                                 stdio_helper_function fn, void **private2) 
 {
        char *buf;
@@ -899,10 +932,9 @@ static void manage_squid_request(enum stdio_helper_mode helper_mode,
 
        static struct mux_private *mux_private;
        static void *normal_private;
-       void **private;
+       void **private1;
 
-       buf = talloc(NULL, char);
-       buf[0] = '\0';
+       buf = talloc_strdup(NULL, "");
 
        if (buf == NULL) {
                DEBUG(0, ("Failed to allocate memory for reading the input "
@@ -925,7 +957,7 @@ static void manage_squid_request(enum stdio_helper_mode helper_mode,
                        exit(0);
                }
 
-               buf = talloc_append_string(buf, buf, tmp);
+               buf = talloc_strdup_append_buffer(buf, tmp);
                buf_size += INITIAL_BUFFER_SIZE;
 
                if (buf_size > MAX_BUFFER_SIZE) {
@@ -982,23 +1014,24 @@ static void manage_squid_request(enum stdio_helper_mode helper_mode,
                               (sizeof(*mux_private->private_pointers) * (mux_private->max_mux - prev_max))); 
                };
 
-               private = &mux_private->private_pointers[mux_id];
+               private1 = &mux_private->private_pointers[mux_id];
        } else {
                c = buf;
-               private = &normal_private;
+               private1 = &normal_private;
        }
 
-       fn(helper_mode, c, length, private, mux_id, private2);
+       fn(helper_mode, lp_ctx, c, length, private1, mux_id, private2);
        talloc_free(buf);
 }
 
-static void squid_stream(enum stdio_helper_mode stdio_mode, 
+static void squid_stream(struct loadparm_context *lp_ctx,
+                        enum stdio_helper_mode stdio_mode, 
                         stdio_helper_function fn) {
        /* initialize FDescs */
        x_setbuf(x_stdout, NULL);
        x_setbuf(x_stderr, NULL);
        while(1) {
-               manage_squid_request(stdio_mode, fn, NULL);
+               manage_squid_request(lp_ctx, stdio_mode, fn, NULL);
        }
 }
 
@@ -1020,6 +1053,7 @@ enum {
        OPT_REQUIRE_MEMBERSHIP,
        OPT_MULTIPLEX,
        OPT_USE_CACHED_CREDS,
+       OPT_ALLOW_MSCHAPV2,
 };
 
 int main(int argc, const char **argv)
@@ -1046,6 +1080,7 @@ int main(int argc, const char **argv)
                { "password", 0, POPT_ARG_STRING, &opt_password, OPT_PASSWORD, "User's plaintext password"},            
                { "multiplex", 0, POPT_ARG_NONE, &opt_multiplex, OPT_MULTIPLEX, "Multiplex Mode"},
                { "use-cached-creds", 0, POPT_ARG_NONE, &use_cached_creds, OPT_USE_CACHED_CREDS, "silently ignored for compatibility reasons"},
+               { "allow-mschapv2", 0, POPT_ARG_NONE, &opt_allow_mschapv2, OPT_ALLOW_MSCHAPV2, "Explicitly allow MSCHAPv2" },
                POPT_COMMON_SAMBA
                POPT_COMMON_VERSION
                { NULL }
@@ -1084,14 +1119,14 @@ int main(int argc, const char **argv)
        gensec_init();
 
        if (opt_domain == NULL) {
-               opt_domain = lp_workgroup();
+               opt_domain = lpcfg_workgroup(cmdline_lp_ctx);
        }
 
        if (helper_protocol) {
                int i;
                for (i=0; i<NUM_HELPER_MODES; i++) {
                        if (strcmp(helper_protocol, stdio_helper_protocols[i].name) == 0) {
-                               squid_stream(stdio_helper_protocols[i].mode, stdio_helper_protocols[i].fn);
+                               squid_stream(cmdline_lp_ctx, stdio_helper_protocols[i].mode, stdio_helper_protocols[i].fn);
                                exit(0);
                        }
                }
@@ -1111,18 +1146,28 @@ int main(int argc, const char **argv)
        }
 
        if (opt_workstation == NULL) {
-               opt_workstation = lp_netbios_name();
+               opt_workstation = lpcfg_netbios_name(cmdline_lp_ctx);
        }
 
        if (!opt_password) {
-               opt_password = getpass("password: ");
+               char pwd[256] = {0};
+               int rc;
+
+               rc = samba_getpass("Password: ", pwd, sizeof(pwd), false, false);
+               if (rc == 0) {
+                       opt_password = smb_xstrdup(pwd);
+               }
        }
 
        {
                char *user;
 
-               asprintf(&user, "%s%c%s", opt_domain, *lp_winbind_separator(), opt_username);
-               if (!check_plaintext_auth(user, opt_password, True)) {
+               if (asprintf(&user, "%s%c%s", opt_domain,
+                            *lpcfg_winbind_separator(cmdline_lp_ctx),
+                            opt_username) < 0) {
+                       return 1;
+               }
+               if (!check_plaintext_auth(user, opt_password, true)) {
                        return 1;
                }
        }