r1481: add idl file and torture test dummies
[samba.git] / source4 / torture / torture.c
index 711a0ae54e858ed4c5f705aa7bbd6f330c1ac0bd..8f72b63e6cb1ea317e8e5698b7f49270845b0ec8 100644 (file)
 
 #include "includes.h"
 
-static int nprocs=4;
+int torture_nprocs=4;
 int torture_numops=100;
 int torture_entries=1000;
 int torture_failures=1;
 static int procnum; /* records process count number when forking */
 static struct cli_state *current_cli;
-static char *randomfname;
 static BOOL use_oplocks;
 static BOOL use_level_II_oplocks;
-static const char *client_txt = "client_oplocks.txt";
 static BOOL use_kerberos;
 
 BOOL torture_showall = False;
 
-static double create_procs(BOOL (*fn)(int), BOOL *result);
-
 #define CHECK_MAX_FAILURES(label) do { if (++failures >= torture_failures) goto label; } while (0)
 
 static struct cli_state *open_nbt_connection(void)
@@ -43,7 +39,7 @@ static struct cli_state *open_nbt_connection(void)
        struct nmb_name called, calling;
        struct in_addr ip;
        struct cli_state *cli;
-       char *host = lp_parm_string(-1, "torture", "host");
+       const char *host = lp_parm_string(-1, "torture", "host");
 
        make_nmb_name(&calling, lp_netbios_name(), 0x0);
        make_nmb_name(&called , host, 0x20);
@@ -86,22 +82,22 @@ static struct cli_state *open_nbt_connection(void)
        return cli;
 }
 
-BOOL torture_open_connection(struct cli_state **c)
+BOOL torture_open_connection_share(struct cli_state **c, 
+                                  const char *hostname, 
+                                  const char *sharename)
 {
        BOOL retry;
        int flags = 0;
        NTSTATUS status;
-       char *host = lp_parm_string(-1, "torture", "host");
-       char *share = lp_parm_string(-1, "torture", "share");
-       char *username = lp_parm_string(-1, "torture", "username");
-       char *password = lp_parm_string(-1, "torture", "password");
+       const char *username = lp_parm_string(-1, "torture", "username");
+       const char *password = lp_parm_string(-1, "torture", "password");
 
        if (use_kerberos)
                flags |= CLI_FULL_CONNECTION_USE_KERBEROS;
 
        status = cli_full_connection(c, lp_netbios_name(),
-                                    host, NULL, 
-                                    share, "?????", 
+                                    hostname, NULL, 
+                                    sharename, "?????", 
                                     username, username[0]?lp_workgroup():"",
                                     password, flags, &retry);
        if (!NT_STATUS_IS_OK(status)) {
@@ -116,13 +112,23 @@ BOOL torture_open_connection(struct cli_state **c)
        return True;
 }
 
+BOOL torture_open_connection(struct cli_state **c)
+{
+       const char *host = lp_parm_string(-1, "torture", "host");
+       const char *share = lp_parm_string(-1, "torture", "share");
+
+       return torture_open_connection_share(c, host, share);
+}
+
+
+
 BOOL torture_close_connection(struct cli_state *c)
 {
        BOOL ret = True;
        DEBUG(9,("torture_close_connection: cli_state@%p\n", c));
        if (!c) return True;
-       if (!cli_tdis(c)) {
-               printf("tdis failed (%s)\n", cli_errstr(c));
+       if (NT_STATUS_IS_ERR(cli_tdis(c))) {
+               printf("tdis failed (%s)\n", cli_errstr(c->tree));
                ret = False;
        }
        DEBUG(9,("torture_close_connection: call cli_shutdown\n"));
@@ -131,29 +137,25 @@ BOOL torture_close_connection(struct cli_state *c)
        return ret;
 }
 
+
 /* open a rpc connection to a named pipe */
 NTSTATUS torture_rpc_connection(struct dcerpc_pipe **p, 
                                const char *pipe_name,
                                const char *pipe_uuid, 
-                               uint32 pipe_version)
+                               uint32_t pipe_version)
 {
-        struct cli_state *cli;
         NTSTATUS status;
+       const char *binding = lp_parm_string(-1, "torture", "binding");
 
-       if (!torture_open_connection(&cli)) {
-                return NT_STATUS_UNSUCCESSFUL;
+       if (!binding) {
+               printf("You must specify a ncacn binding string\n");
+               return NT_STATUS_INVALID_PARAMETER;
        }
 
-        if (!(*p = dcerpc_pipe_init(cli->tree))) {
-                return NT_STATUS_NO_MEMORY;
-       }
-       status = dcerpc_pipe_open_smb(*p, pipe_name, pipe_uuid, pipe_version);
-       if (!NT_STATUS_IS_OK(status)) {
-                printf("Open of pipe '%s' failed with error (%s)\n",
-                      pipe_name, nt_errstr(status));
-                return status;
-        }
+       status = dcerpc_pipe_connect(p, binding, pipe_uuid, pipe_version,
+                                    lp_workgroup(), 
+                                    lp_parm_string(-1, "torture", "username"),
+                                    lp_parm_string(-1, "torture", "password"));
  
         return status;
 }
@@ -161,27 +163,18 @@ NTSTATUS torture_rpc_connection(struct dcerpc_pipe **p,
 /* close a rpc connection to a named pipe */
 NTSTATUS torture_rpc_close(struct dcerpc_pipe *p)
 {
-       union smb_close io;
-       NTSTATUS status;
-
-       io.close.level = RAW_CLOSE_CLOSE;
-       io.close.in.fnum = p->fnum;
-       io.close.in.write_time = 0;
-       status = smb_raw_close(p->tree, &io);
-
        dcerpc_pipe_close(p);
-
-       return status;
+       return NT_STATUS_OK;
 }
 
 
 /* check if the server produced the expected error code */
 static BOOL check_error(int line, struct cli_state *c, 
-                       uint8 eclass, uint32 ecode, NTSTATUS nterr)
+                       uint8_t eclass, uint32_t ecode, NTSTATUS nterr)
 {
-        if (cli_is_dos_error(c)) {
-                uint8 class;
-                uint32 num;
+        if (cli_is_dos_error(c->tree)) {
+                uint8_t class;
+                uint32_t num;
 
                 /* Check DOS error */
 
@@ -200,7 +193,7 @@ static BOOL check_error(int line, struct cli_state *c,
 
                 /* Check NT error */
 
-                status = cli_nt_error(c);
+                status = cli_nt_error(c->tree);
 
                 if (NT_STATUS_V(nterr) != NT_STATUS_V(status)) {
                         printf("unexpected error code %s\n", nt_errstr(status));
@@ -213,9 +206,9 @@ static BOOL check_error(int line, struct cli_state *c,
 }
 
 
-static BOOL wait_lock(struct cli_state *c, int fnum, uint32 offset, uint32 len)
+static BOOL wait_lock(struct cli_state *c, int fnum, uint32_t offset, uint32_t len)
 {
-       while (!cli_lock(c, fnum, offset, len, -1, WRITE_LOCK)) {
+       while (NT_STATUS_IS_ERR(cli_lock(c->tree, fnum, offset, len, -1, WRITE_LOCK))) {
                if (!check_error(__LINE__, c, ERRDOS, ERRlock, NT_STATUS_LOCK_NOT_GRANTED)) return False;
        }
        return True;
@@ -233,18 +226,18 @@ static BOOL rw_torture(struct cli_state *c)
        char buf[1024];
        BOOL correct = True;
 
-       fnum2 = cli_open(c, lockfname, O_RDWR | O_CREAT | O_EXCL, 
+       fnum2 = cli_open(c->tree, lockfname, O_RDWR | O_CREAT | O_EXCL, 
                         DENY_NONE);
        if (fnum2 == -1)
-               fnum2 = cli_open(c, lockfname, O_RDWR, DENY_NONE);
+               fnum2 = cli_open(c->tree, lockfname, O_RDWR, DENY_NONE);
        if (fnum2 == -1) {
-               printf("open of %s failed (%s)\n", lockfname, cli_errstr(c));
+               printf("open of %s failed (%s)\n", lockfname, cli_errstr(c->tree));
                return False;
        }
 
 
        for (i=0;i<torture_numops;i++) {
-               unsigned n = (unsigned)sys_random()%10;
+               uint_t n = (uint_t)sys_random()%10;
                if (i % 10 == 0) {
                        printf("%d\r", i); fflush(stdout);
                }
@@ -254,31 +247,31 @@ static BOOL rw_torture(struct cli_state *c)
                        return False;
                }
 
-               fnum = cli_open(c, fname, O_RDWR | O_CREAT | O_TRUNC, DENY_ALL);
+               fnum = cli_open(c->tree, fname, O_RDWR | O_CREAT | O_TRUNC, DENY_ALL);
                if (fnum == -1) {
-                       printf("open failed (%s)\n", cli_errstr(c));
+                       printf("open failed (%s)\n", cli_errstr(c->tree));
                        correct = False;
                        break;
                }
 
-               if (cli_write(c, fnum, 0, (char *)&pid, 0, sizeof(pid)) != sizeof(pid)) {
-                       printf("write failed (%s)\n", cli_errstr(c));
+               if (cli_write(c->tree, fnum, 0, (char *)&pid, 0, sizeof(pid)) != sizeof(pid)) {
+                       printf("write failed (%s)\n", cli_errstr(c->tree));
                        correct = False;
                }
 
                for (j=0;j<50;j++) {
-                       if (cli_write(c, fnum, 0, (char *)buf, 
+                       if (cli_write(c->tree, fnum, 0, (char *)buf, 
                                      sizeof(pid)+(j*sizeof(buf)), 
                                      sizeof(buf)) != sizeof(buf)) {
-                               printf("write failed (%s)\n", cli_errstr(c));
+                               printf("write failed (%s)\n", cli_errstr(c->tree));
                                correct = False;
                        }
                }
 
                pid2 = 0;
 
-               if (cli_read(c, fnum, (char *)&pid2, 0, sizeof(pid)) != sizeof(pid)) {
-                       printf("read failed (%s)\n", cli_errstr(c));
+               if (cli_read(c->tree, fnum, (char *)&pid2, 0, sizeof(pid)) != sizeof(pid)) {
+                       printf("read failed (%s)\n", cli_errstr(c->tree));
                        correct = False;
                }
 
@@ -287,38 +280,35 @@ static BOOL rw_torture(struct cli_state *c)
                        correct = False;
                }
 
-               if (!cli_close(c, fnum)) {
-                       printf("close failed (%s)\n", cli_errstr(c));
+               if (NT_STATUS_IS_ERR(cli_close(c->tree, fnum))) {
+                       printf("close failed (%s)\n", cli_errstr(c->tree));
                        correct = False;
                }
 
-               if (!cli_unlink(c, fname)) {
-                       printf("unlink failed (%s)\n", cli_errstr(c));
+               if (NT_STATUS_IS_ERR(cli_unlink(c->tree, fname))) {
+                       printf("unlink failed (%s)\n", cli_errstr(c->tree));
                        correct = False;
                }
 
-               if (!cli_unlock(c, fnum2, n*sizeof(int), sizeof(int))) {
-                       printf("unlock failed (%s)\n", cli_errstr(c));
+               if (NT_STATUS_IS_ERR(cli_unlock(c->tree, fnum2, n*sizeof(int), sizeof(int)))) {
+                       printf("unlock failed (%s)\n", cli_errstr(c->tree));
                        correct = False;
                }
                free(fname);
        }
 
-       cli_close(c, fnum2);
-       cli_unlink(c, lockfname);
+       cli_close(c->tree, fnum2);
+       cli_unlink(c->tree, lockfname);
 
        printf("%d\n", i);
 
        return correct;
 }
 
-static BOOL run_torture(int dummy)
+static BOOL run_torture(struct cli_state *cli, int dummy)
 {
-       struct cli_state *cli;
         BOOL ret;
 
-       cli = current_cli;
-
        ret = rw_torture(cli);
        
        if (!torture_close_connection(cli)) {
@@ -328,30 +318,30 @@ static BOOL run_torture(int dummy)
        return ret;
 }
 
-static BOOL rw_torture3(struct cli_state *c, char *lockfname)
+static BOOL rw_torture3(struct cli_state *c, const char *lockfname)
 {
        int fnum = -1;
-       unsigned int i = 0;
+       uint_t i = 0;
        char buf[131072];
        char buf_rd[131072];
-       unsigned count;
-       unsigned countprev = 0;
+       uint_t count;
+       uint_t countprev = 0;
        ssize_t sent = 0;
        BOOL correct = True;
 
        srandom(1);
-       for (i = 0; i < sizeof(buf); i += sizeof(uint32))
+       for (i = 0; i < sizeof(buf); i += sizeof(uint32_t))
        {
                SIVAL(buf, i, sys_random());
        }
 
        if (procnum == 0)
        {
-               fnum = cli_open(c, lockfname, O_RDWR | O_CREAT | O_EXCL, 
-                                DENY_NONE);
+               fnum = cli_open(c->tree, lockfname, O_RDWR | O_CREAT | O_EXCL, 
+                               DENY_NONE);
                if (fnum == -1) {
                        printf("first open read/write of %s failed (%s)\n",
-                                       lockfname, cli_errstr(c));
+                                       lockfname, cli_errstr(c->tree));
                        return False;
                }
        }
@@ -359,13 +349,13 @@ static BOOL rw_torture3(struct cli_state *c, char *lockfname)
        {
                for (i = 0; i < 500 && fnum == -1; i++)
                {
-                       fnum = cli_open(c, lockfname, O_RDONLY, 
-                                        DENY_NONE);
+                       fnum = cli_open(c->tree, lockfname, O_RDONLY, 
+                                       DENY_NONE);
                        msleep(10);
                }
                if (fnum == -1) {
                        printf("second open read-only of %s failed (%s)\n",
-                                       lockfname, cli_errstr(c));
+                                       lockfname, cli_errstr(c->tree));
                        return False;
                }
        }
@@ -382,26 +372,26 @@ static BOOL rw_torture3(struct cli_state *c, char *lockfname)
 
                if (procnum == 0)
                {
-                       sent = ((unsigned)sys_random()%(20))+ 1;
+                       sent = ((uint_t)sys_random()%(20))+ 1;
                        if (sent > sizeof(buf) - count)
                        {
                                sent = sizeof(buf) - count;
                        }
 
-                       if (cli_write(c, fnum, 0, buf+count, count, (size_t)sent) != sent) {
-                               printf("write failed (%s)\n", cli_errstr(c));
+                       if (cli_write(c->tree, fnum, 0, buf+count, count, (size_t)sent) != sent) {
+                               printf("write failed (%s)\n", cli_errstr(c->tree));
                                correct = False;
                        }
                }
                else
                {
-                       sent = cli_read(c, fnum, buf_rd+count, count,
-                                                 sizeof(buf)-count);
+                       sent = cli_read(c->tree, fnum, buf_rd+count, count,
+                                       sizeof(buf)-count);
                        if (sent < 0)
                        {
                                printf("read failed offset:%d size:%d (%s)\n",
                                                count, sizeof(buf)-count,
-                                               cli_errstr(c));
+                                               cli_errstr(c->tree));
                                correct = False;
                                sent = 0;
                        }
@@ -420,8 +410,8 @@ static BOOL rw_torture3(struct cli_state *c, char *lockfname)
 
        }
 
-       if (!cli_close(c, fnum)) {
-               printf("close failed (%s)\n", cli_errstr(c));
+       if (NT_STATUS_IS_ERR(cli_close(c->tree, fnum))) {
+               printf("close failed (%s)\n", cli_errstr(c->tree));
                correct = False;
        }
 
@@ -434,28 +424,28 @@ static BOOL rw_torture2(struct cli_state *c1, struct cli_state *c2)
        int fnum1;
        int fnum2;
        int i;
-       uchar buf[131072];
-       uchar buf_rd[131072];
+       uint8_t buf[131072];
+       uint8_t buf_rd[131072];
        BOOL correct = True;
        ssize_t bytes_read, bytes_written;
 
-       if (cli_deltree(c1, lockfname) == -1) {
-               printf("unlink failed (%s)\n", cli_errstr(c1));
+       if (cli_deltree(c1->tree, lockfname) == -1) {
+               printf("unlink failed (%s)\n", cli_errstr(c1->tree));
        }
 
-       fnum1 = cli_open(c1, lockfname, O_RDWR | O_CREAT | O_EXCL, 
+       fnum1 = cli_open(c1->tree, lockfname, O_RDWR | O_CREAT | O_EXCL, 
                         DENY_NONE);
        if (fnum1 == -1) {
                printf("first open read/write of %s failed (%s)\n",
-                               lockfname, cli_errstr(c1));
+                               lockfname, cli_errstr(c1->tree));
                return False;
        }
-       fnum2 = cli_open(c2, lockfname, O_RDONLY, 
+       fnum2 = cli_open(c2->tree, lockfname, O_RDONLY, 
                         DENY_NONE);
        if (fnum2 == -1) {
                printf("second open read-only of %s failed (%s)\n",
-                               lockfname, cli_errstr(c2));
-               cli_close(c1, fnum1);
+                               lockfname, cli_errstr(c2->tree));
+               cli_close(c1->tree, fnum1);
                return False;
        }
 
@@ -463,22 +453,22 @@ static BOOL rw_torture2(struct cli_state *c1, struct cli_state *c2)
 
        for (i=0;i<torture_numops;i++)
        {
-               size_t buf_size = ((unsigned)sys_random()%(sizeof(buf)-1))+ 1;
+               size_t buf_size = ((uint_t)sys_random()%(sizeof(buf)-1))+ 1;
                if (i % 10 == 0) {
                        printf("%d\r", i); fflush(stdout);
                }
 
                generate_random_buffer(buf, buf_size, False);
 
-               if ((bytes_written = cli_write(c1, fnum1, 0, buf, 0, buf_size)) != buf_size) {
-                       printf("write failed (%s)\n", cli_errstr(c1));
+               if ((bytes_written = cli_write(c1->tree, fnum1, 0, buf, 0, buf_size)) != buf_size) {
+                       printf("write failed (%s)\n", cli_errstr(c1->tree));
                        printf("wrote %d, expected %d\n", bytes_written, buf_size); 
                        correct = False;
                        break;
                }
 
-               if ((bytes_read = cli_read(c2, fnum2, buf_rd, 0, buf_size)) != buf_size) {
-                       printf("read failed (%s)\n", cli_errstr(c2));
+               if ((bytes_read = cli_read(c2->tree, fnum2, buf_rd, 0, buf_size)) != buf_size) {
+                       printf("read failed (%s)\n", cli_errstr(c2->tree));
                        printf("read %d, expected %d\n", bytes_read, buf_size); 
                        correct = False;
                        break;
@@ -492,17 +482,17 @@ static BOOL rw_torture2(struct cli_state *c1, struct cli_state *c2)
                }
        }
 
-       if (!cli_close(c2, fnum2)) {
-               printf("close failed (%s)\n", cli_errstr(c2));
+       if (NT_STATUS_IS_ERR(cli_close(c2->tree, fnum2))) {
+               printf("close failed (%s)\n", cli_errstr(c2->tree));
                correct = False;
        }
-       if (!cli_close(c1, fnum1)) {
-               printf("close failed (%s)\n", cli_errstr(c1));
+       if (NT_STATUS_IS_ERR(cli_close(c1->tree, fnum1))) {
+               printf("close failed (%s)\n", cli_errstr(c1->tree));
                correct = False;
        }
 
-       if (!cli_unlink(c1, lockfname)) {
-               printf("unlink failed (%s)\n", cli_errstr(c1));
+       if (NT_STATUS_IS_ERR(cli_unlink(c1->tree, lockfname))) {
+               printf("unlink failed (%s)\n", cli_errstr(c1->tree));
                correct = False;
        }
 
@@ -539,15 +529,11 @@ static BOOL run_readwritetest(int dummy)
        return (test1 && test2);
 }
 
-static BOOL run_readwritemulti(int dummy)
+static BOOL run_readwritemulti(struct cli_state *cli, int dummy)
 {
-       struct cli_state *cli;
        BOOL test;
 
-       cli = current_cli;
-
-       printf("run_readwritemulti: fname %s\n", randomfname);
-       test = rw_torture3(cli, randomfname);
+       test = rw_torture3(cli, "\\multitest.txt");
 
        if (!torture_close_connection(cli)) {
                test = False;
@@ -557,128 +543,6 @@ static BOOL run_readwritemulti(int dummy)
 }
 
 
-int line_count = 0;
-int nbio_id;
-
-#define ival(s) strtol(s, NULL, 0)
-
-/* run a test that simulates an approximate netbench client load */
-static BOOL run_netbench(int client)
-{
-       struct cli_state *cli;
-       int i;
-       pstring line;
-       char *cname;
-       FILE *f;
-       const char *params[20];
-       BOOL correct = True;
-
-       cli = current_cli;
-
-       nbio_id = client;
-
-       nb_setup(cli);
-
-       asprintf(&cname, "client%d", client);
-
-       f = fopen(client_txt, "r");
-
-       if (!f) {
-               perror(client_txt);
-               return False;
-       }
-
-       while (fgets(line, sizeof(line)-1, f)) {
-               line_count++;
-
-               line[strlen(line)-1] = 0;
-
-               /* printf("[%d] %s\n", line_count, line); */
-
-               all_string_sub(line,"client1", cname, sizeof(line));
-               
-               /* parse the command parameters */
-               params[0] = strtok(line," ");
-               i = 0;
-               while (params[i]) params[++i] = strtok(NULL," ");
-
-               params[i] = "";
-
-               if (i < 2) continue;
-
-               if (!strncmp(params[0],"SMB", 3)) {
-                       printf("ERROR: You are using a dbench 1 load file\n");
-                       exit(1);
-               }
-               DEBUG(9,("run_netbench(%d): %s %s\n", client, params[0], params[1]));
-
-               if (!strcmp(params[0],"NTCreateX")) {
-                       nb_createx(params[1], ival(params[2]), ival(params[3]), 
-                                  ival(params[4]));
-               } else if (!strcmp(params[0],"Close")) {
-                       nb_close(ival(params[1]));
-               } else if (!strcmp(params[0],"Rename")) {
-                       nb_rename(params[1], params[2]);
-               } else if (!strcmp(params[0],"Unlink")) {
-                       nb_unlink(params[1]);
-               } else if (!strcmp(params[0],"Deltree")) {
-                       nb_deltree(params[1]);
-               } else if (!strcmp(params[0],"Rmdir")) {
-                       nb_rmdir(params[1]);
-               } else if (!strcmp(params[0],"QUERY_PATH_INFORMATION")) {
-                       nb_qpathinfo(params[1]);
-               } else if (!strcmp(params[0],"QUERY_FILE_INFORMATION")) {
-                       nb_qfileinfo(ival(params[1]));
-               } else if (!strcmp(params[0],"QUERY_FS_INFORMATION")) {
-                       nb_qfsinfo(ival(params[1]));
-               } else if (!strcmp(params[0],"FIND_FIRST")) {
-                       nb_findfirst(params[1]);
-               } else if (!strcmp(params[0],"WriteX")) {
-                       nb_writex(ival(params[1]), 
-                               ival(params[2]), ival(params[3]), ival(params[4]));
-               } else if (!strcmp(params[0],"ReadX")) {
-                       nb_readx(ival(params[1]), 
-                     ival(params[2]), ival(params[3]), ival(params[4]));
-               } else if (!strcmp(params[0],"Flush")) {
-                       nb_flush(ival(params[1]));
-               } else {
-                       printf("Unknown operation %s\n", params[0]);
-                       exit(1);
-               }
-       }
-       fclose(f);
-
-       nb_cleanup();
-
-       if (!torture_close_connection(cli)) {
-               correct = False;
-       }
-       
-       return correct;
-}
-
-
-/* run a test that simulates an approximate netbench client load */
-static BOOL run_nbench(int dummy)
-{
-       double t;
-       BOOL correct = True;
-
-       nbio_shmem(nprocs);
-
-       nbio_id = -1;
-
-       signal(SIGALRM, SIGNAL_CAST nb_alarm);
-       alarm(1);
-       t = create_procs(run_netbench, &correct);
-       alarm(0);
-
-       printf("\nThroughput %g MB/sec\n", 
-              1.0e-6 * nbio_total() / t);
-       return correct;
-}
-
-
 /*
   This test checks for two things:
 
@@ -692,7 +556,7 @@ static BOOL run_locktest1(int dummy)
        const char *fname = "\\lockt1.lck";
        int fnum1, fnum2, fnum3;
        time_t t1, t2;
-       unsigned lock_timeout;
+       uint_t lock_timeout;
 
        if (!torture_open_connection(&cli1) || !torture_open_connection(&cli2)) {
                return False;
@@ -700,31 +564,31 @@ static BOOL run_locktest1(int dummy)
 
        printf("starting locktest1\n");
 
-       cli_unlink(cli1, fname);
+       cli_unlink(cli1->tree, fname);
 
-       fnum1 = cli_open(cli1, fname, O_RDWR|O_CREAT|O_EXCL, DENY_NONE);
+       fnum1 = cli_open(cli1->tree, fname, O_RDWR|O_CREAT|O_EXCL, DENY_NONE);
        if (fnum1 == -1) {
-               printf("open of %s failed (%s)\n", fname, cli_errstr(cli1));
+               printf("open of %s failed (%s)\n", fname, cli_errstr(cli1->tree));
                return False;
        }
-       fnum2 = cli_open(cli1, fname, O_RDWR, DENY_NONE);
+       fnum2 = cli_open(cli1->tree, fname, O_RDWR, DENY_NONE);
        if (fnum2 == -1) {
-               printf("open2 of %s failed (%s)\n", fname, cli_errstr(cli1));
+               printf("open2 of %s failed (%s)\n", fname, cli_errstr(cli1->tree));
                return False;
        }
-       fnum3 = cli_open(cli2, fname, O_RDWR, DENY_NONE);
+       fnum3 = cli_open(cli2->tree, fname, O_RDWR, DENY_NONE);
        if (fnum3 == -1) {
-               printf("open3 of %s failed (%s)\n", fname, cli_errstr(cli2));
+               printf("open3 of %s failed (%s)\n", fname, cli_errstr(cli2->tree));
                return False;
        }
 
-       if (!cli_lock(cli1, fnum1, 0, 4, 0, WRITE_LOCK)) {
-               printf("lock1 failed (%s)\n", cli_errstr(cli1));
+       if (NT_STATUS_IS_ERR(cli_lock(cli1->tree, fnum1, 0, 4, 0, WRITE_LOCK))) {
+               printf("lock1 failed (%s)\n", cli_errstr(cli1->tree));
                return False;
        }
 
 
-       if (cli_lock(cli2, fnum3, 0, 4, 0, WRITE_LOCK)) {
+       if (NT_STATUS_IS_OK(cli_lock(cli2->tree, fnum3, 0, 4, 0, WRITE_LOCK))) {
                printf("lock2 succeeded! This is a locking bug\n");
                return False;
        } else {
@@ -736,7 +600,7 @@ static BOOL run_locktest1(int dummy)
        lock_timeout = (6 + (random() % 20));
        printf("Testing lock timeout with timeout=%u\n", lock_timeout);
        t1 = time(NULL);
-       if (cli_lock(cli2, fnum3, 0, 4, lock_timeout * 1000, WRITE_LOCK)) {
+       if (NT_STATUS_IS_OK(cli_lock(cli2->tree, fnum3, 0, 4, lock_timeout * 1000, WRITE_LOCK))) {
                printf("lock3 succeeded! This is a locking bug\n");
                return False;
        } else {
@@ -749,14 +613,14 @@ static BOOL run_locktest1(int dummy)
                printf("error: This server appears not to support timed lock requests\n");
        }
        printf("server slept for %u seconds for a %u second timeout\n",
-              (unsigned int)(t2-t1), lock_timeout);
+              (uint_t)(t2-t1), lock_timeout);
 
-       if (!cli_close(cli1, fnum2)) {
-               printf("close1 failed (%s)\n", cli_errstr(cli1));
+       if (NT_STATUS_IS_ERR(cli_close(cli1->tree, fnum2))) {
+               printf("close1 failed (%s)\n", cli_errstr(cli1->tree));
                return False;
        }
 
-       if (cli_lock(cli2, fnum3, 0, 4, 0, WRITE_LOCK)) {
+       if (NT_STATUS_IS_OK(cli_lock(cli2->tree, fnum3, 0, 4, 0, WRITE_LOCK))) {
                printf("lock4 succeeded! This is a locking bug\n");
                return False;
        } else {
@@ -764,18 +628,18 @@ static BOOL run_locktest1(int dummy)
                                 NT_STATUS_FILE_LOCK_CONFLICT)) return False;
        }
 
-       if (!cli_close(cli1, fnum1)) {
-               printf("close2 failed (%s)\n", cli_errstr(cli1));
+       if (NT_STATUS_IS_ERR(cli_close(cli1->tree, fnum1))) {
+               printf("close2 failed (%s)\n", cli_errstr(cli1->tree));
                return False;
        }
 
-       if (!cli_close(cli2, fnum3)) {
-               printf("close3 failed (%s)\n", cli_errstr(cli2));
+       if (NT_STATUS_IS_ERR(cli_close(cli2->tree, fnum3))) {
+               printf("close3 failed (%s)\n", cli_errstr(cli2->tree));
                return False;
        }
 
-       if (!cli_unlink(cli1, fname)) {
-               printf("unlink failed (%s)\n", cli_errstr(cli1));
+       if (NT_STATUS_IS_ERR(cli_unlink(cli1->tree, fname))) {
+               printf("unlink failed (%s)\n", cli_errstr(cli1->tree));
                return False;
        }
 
@@ -801,14 +665,14 @@ static BOOL run_tcon_test(int dummy)
        struct cli_state *cli;
        const char *fname = "\\tcontest.tmp";
        int fnum1;
-       uint16 cnum1, cnum2, cnum3;
-       uint16 vuid1, vuid2;
+       uint16_t cnum1, cnum2, cnum3;
+       uint16_t vuid1, vuid2;
        char buf[4];
        BOOL ret = True;
        struct cli_tree *tree1;
-       char *host = lp_parm_string(-1, "torture", "host");
-       char *share = lp_parm_string(-1, "torture", "share");
-       char *password = lp_parm_string(-1, "torture", "password");
+       const char *host = lp_parm_string(-1, "torture", "host");
+       const char *share = lp_parm_string(-1, "torture", "share");
+       const char *password = lp_parm_string(-1, "torture", "password");
 
        if (!torture_open_connection(&cli)) {
                return False;
@@ -816,13 +680,13 @@ static BOOL run_tcon_test(int dummy)
 
        printf("starting tcontest\n");
 
-       if (cli_deltree(cli, fname) == -1) {
-               printf("unlink of %s failed (%s)\n", fname, cli_errstr(cli));
+       if (cli_deltree(cli->tree, fname) == -1) {
+               printf("unlink of %s failed (%s)\n", fname, cli_errstr(cli->tree));
        }
 
-       fnum1 = cli_open(cli, fname, O_RDWR|O_CREAT|O_EXCL, DENY_NONE);
+       fnum1 = cli_open(cli->tree, fname, O_RDWR|O_CREAT|O_EXCL, DENY_NONE);
        if (fnum1 == -1) {
-               printf("open of %s failed (%s)\n", fname, cli_errstr(cli));
+               printf("open of %s failed (%s)\n", fname, cli_errstr(cli->tree));
                return False;
        }
 
@@ -830,16 +694,15 @@ static BOOL run_tcon_test(int dummy)
        vuid1 = cli->session->vuid;
 
        memset(&buf, 0, 4); /* init buf so valgrind won't complain */
-       if (cli_write(cli, fnum1, 0, buf, 130, 4) != 4) {
-               printf("initial write failed (%s)\n", cli_errstr(cli));
+       if (cli_write(cli->tree, fnum1, 0, buf, 130, 4) != 4) {
+               printf("initial write failed (%s)\n", cli_errstr(cli->tree));
                return False;
        }
 
        tree1 = cli->tree;      /* save old tree connection */
-       if (!cli_send_tconX(cli, share, "?????",
-                           password)) {
+       if (NT_STATUS_IS_ERR(cli_send_tconX(cli, share, "?????", password))) {
                printf("%s refused 2nd tree connect (%s)\n", host,
-                          cli_errstr(cli));
+                          cli_errstr(cli->tree));
                cli_shutdown(cli);
                return False;
        }
@@ -851,47 +714,47 @@ static BOOL run_tcon_test(int dummy)
        /* try a write with the wrong tid */
        cli->tree->tid = cnum2;
 
-       if (cli_write(cli, fnum1, 0, buf, 130, 4) == 4) {
+       if (cli_write(cli->tree, fnum1, 0, buf, 130, 4) == 4) {
                printf("* server allows write with wrong TID\n");
                ret = False;
        } else {
-               printf("server fails write with wrong TID : %s\n", cli_errstr(cli));
+               printf("server fails write with wrong TID : %s\n", cli_errstr(cli->tree));
        }
 
 
        /* try a write with an invalid tid */
        cli->tree->tid = cnum3;
 
-       if (cli_write(cli, fnum1, 0, buf, 130, 4) == 4) {
+       if (cli_write(cli->tree, fnum1, 0, buf, 130, 4) == 4) {
                printf("* server allows write with invalid TID\n");
                ret = False;
        } else {
-               printf("server fails write with invalid TID : %s\n", cli_errstr(cli));
+               printf("server fails write with invalid TID : %s\n", cli_errstr(cli->tree));
        }
 
        /* try a write with an invalid vuid */
        cli->session->vuid = vuid2;
        cli->tree->tid = cnum1;
 
-       if (cli_write(cli, fnum1, 0, buf, 130, 4) == 4) {
+       if (cli_write(cli->tree, fnum1, 0, buf, 130, 4) == 4) {
                printf("* server allows write with invalid VUID\n");
                ret = False;
        } else {
-               printf("server fails write with invalid VUID : %s\n", cli_errstr(cli));
+               printf("server fails write with invalid VUID : %s\n", cli_errstr(cli->tree));
        }
 
        cli->session->vuid = vuid1;
        cli->tree->tid = cnum1;
 
-       if (!cli_close(cli, fnum1)) {
-               printf("close failed (%s)\n", cli_errstr(cli));
+       if (NT_STATUS_IS_ERR(cli_close(cli->tree, fnum1))) {
+               printf("close failed (%s)\n", cli_errstr(cli->tree));
                return False;
        }
 
        cli->tree->tid = cnum2;
 
-       if (!cli_tdis(cli)) {
-               printf("secondary tdis failed (%s)\n", cli_errstr(cli));
+       if (NT_STATUS_IS_ERR(cli_tdis(cli))) {
+               printf("secondary tdis failed (%s)\n", cli_errstr(cli->tree));
                return False;
        }
 
@@ -913,10 +776,10 @@ static BOOL tcon_devtest(struct cli_state *cli,
 {
        BOOL status;
        BOOL ret;
-       char *password = lp_parm_string(-1, "torture", "password");
+       const char *password = lp_parm_string(-1, "torture", "password");
 
-       status = cli_send_tconX(cli, myshare, devtype,
-                               password);
+       status = NT_STATUS_IS_OK(cli_send_tconX(cli, myshare, devtype, 
+                                               password));
 
        printf("Trying share %s with devtype %s\n", myshare, devtype);
 
@@ -937,7 +800,7 @@ static BOOL tcon_devtest(struct cli_state *cli,
                               myshare, devtype);
                        ret = False;
                } else {
-                       if (NT_STATUS_EQUAL(cli_nt_error(cli),
+                       if (NT_STATUS_EQUAL(cli_nt_error(cli->tree),
                                            expected_error)) {
                                ret = True;
                        } else {
@@ -959,10 +822,10 @@ static BOOL run_tcon_devtype_test(int dummy)
        int flags = 0;
        NTSTATUS status;
        BOOL ret = True;
-       char *host = lp_parm_string(-1, "torture", "host");
-       char *share = lp_parm_string(-1, "torture", "share");
-       char *username = lp_parm_string(-1, "torture", "username");
-       char *password = lp_parm_string(-1, "torture", "password");
+       const char *host = lp_parm_string(-1, "torture", "host");
+       const char *share = lp_parm_string(-1, "torture", "share");
+       const char *username = lp_parm_string(-1, "torture", "username");
+       const char *password = lp_parm_string(-1, "torture", "password");
        
        status = cli_full_connection(&cli1, lp_netbios_name(),
                                     host, NULL, 
@@ -1038,40 +901,40 @@ static BOOL run_locktest2(int dummy)
 
        printf("starting locktest2\n");
 
-       cli_unlink(cli, fname);
+       cli_unlink(cli->tree, fname);
 
        printf("Testing pid context\n");
        
        cli->session->pid = 1;
 
-       fnum1 = cli_open(cli, fname, O_RDWR|O_CREAT|O_EXCL, DENY_NONE);
+       fnum1 = cli_open(cli->tree, fname, O_RDWR|O_CREAT|O_EXCL, DENY_NONE);
        if (fnum1 == -1) {
-               printf("open of %s failed (%s)\n", fname, cli_errstr(cli));
+               printf("open of %s failed (%s)\n", fname, cli_errstr(cli->tree));
                return False;
        }
 
-       fnum2 = cli_open(cli, fname, O_RDWR, DENY_NONE);
+       fnum2 = cli_open(cli->tree, fname, O_RDWR, DENY_NONE);
        if (fnum2 == -1) {
-               printf("open2 of %s failed (%s)\n", fname, cli_errstr(cli));
+               printf("open2 of %s failed (%s)\n", fname, cli_errstr(cli->tree));
                return False;
        }
 
        cli->session->pid = 2;
 
-       fnum3 = cli_open(cli, fname, O_RDWR, DENY_NONE);
+       fnum3 = cli_open(cli->tree, fname, O_RDWR, DENY_NONE);
        if (fnum3 == -1) {
-               printf("open3 of %s failed (%s)\n", fname, cli_errstr(cli));
+               printf("open3 of %s failed (%s)\n", fname, cli_errstr(cli->tree));
                return False;
        }
 
        cli->session->pid = 1;
 
-       if (!cli_lock(cli, fnum1, 0, 4, 0, WRITE_LOCK)) {
-               printf("lock1 failed (%s)\n", cli_errstr(cli));
+       if (NT_STATUS_IS_ERR(cli_lock(cli->tree, fnum1, 0, 4, 0, WRITE_LOCK))) {
+               printf("lock1 failed (%s)\n", cli_errstr(cli->tree));
                return False;
        }
 
-       if (cli_lock(cli, fnum1, 0, 4, 0, WRITE_LOCK)) {
+       if (NT_STATUS_IS_OK(cli_lock(cli->tree, fnum1, 0, 4, 0, WRITE_LOCK))) {
                printf("WRITE lock1 succeeded! This is a locking bug\n");
                correct = False;
        } else {
@@ -1079,7 +942,7 @@ static BOOL run_locktest2(int dummy)
                                 NT_STATUS_LOCK_NOT_GRANTED)) return False;
        }
 
-       if (cli_lock(cli, fnum2, 0, 4, 0, WRITE_LOCK)) {
+       if (NT_STATUS_IS_OK(cli_lock(cli->tree, fnum2, 0, 4, 0, WRITE_LOCK))) {
                printf("WRITE lock2 succeeded! This is a locking bug\n");
                correct = False;
        } else {
@@ -1087,7 +950,7 @@ static BOOL run_locktest2(int dummy)
                                 NT_STATUS_LOCK_NOT_GRANTED)) return False;
        }
 
-       if (cli_lock(cli, fnum2, 0, 4, 0, READ_LOCK)) {
+       if (NT_STATUS_IS_OK(cli_lock(cli->tree, fnum2, 0, 4, 0, READ_LOCK))) {
                printf("READ lock2 succeeded! This is a locking bug\n");
                correct = False;
        } else {
@@ -1095,18 +958,18 @@ static BOOL run_locktest2(int dummy)
                                 NT_STATUS_FILE_LOCK_CONFLICT)) return False;
        }
 
-       if (!cli_lock(cli, fnum1, 100, 4, 0, WRITE_LOCK)) {
-               printf("lock at 100 failed (%s)\n", cli_errstr(cli));
+       if (NT_STATUS_IS_ERR(cli_lock(cli->tree, fnum1, 100, 4, 0, WRITE_LOCK))) {
+               printf("lock at 100 failed (%s)\n", cli_errstr(cli->tree));
        }
 
        cli->session->pid = 2;
 
-       if (cli_unlock(cli, fnum1, 100, 4)) {
+       if (NT_STATUS_IS_OK(cli_unlock(cli->tree, fnum1, 100, 4))) {
                printf("unlock at 100 succeeded! This is a locking bug\n");
                correct = False;
        }
 
-       if (cli_unlock(cli, fnum1, 0, 4)) {
+       if (NT_STATUS_IS_OK(cli_unlock(cli->tree, fnum1, 0, 4))) {
                printf("unlock1 succeeded! This is a locking bug\n");
                correct = False;
        } else {
@@ -1115,7 +978,7 @@ static BOOL run_locktest2(int dummy)
                                 NT_STATUS_RANGE_NOT_LOCKED)) return False;
        }
 
-       if (cli_unlock(cli, fnum1, 0, 8)) {
+       if (NT_STATUS_IS_OK(cli_unlock(cli->tree, fnum1, 0, 8))) {
                printf("unlock2 succeeded! This is a locking bug\n");
                correct = False;
        } else {
@@ -1124,7 +987,7 @@ static BOOL run_locktest2(int dummy)
                                 NT_STATUS_RANGE_NOT_LOCKED)) return False;
        }
 
-       if (cli_lock(cli, fnum3, 0, 4, 0, WRITE_LOCK)) {
+       if (NT_STATUS_IS_OK(cli_lock(cli->tree, fnum3, 0, 4, 0, WRITE_LOCK))) {
                printf("lock3 succeeded! This is a locking bug\n");
                correct = False;
        } else {
@@ -1133,18 +996,18 @@ static BOOL run_locktest2(int dummy)
 
        cli->session->pid = 1;
 
-       if (!cli_close(cli, fnum1)) {
-               printf("close1 failed (%s)\n", cli_errstr(cli));
+       if (NT_STATUS_IS_ERR(cli_close(cli->tree, fnum1))) {
+               printf("close1 failed (%s)\n", cli_errstr(cli->tree));
                return False;
        }
 
-       if (!cli_close(cli, fnum2)) {
-               printf("close2 failed (%s)\n", cli_errstr(cli));
+       if (NT_STATUS_IS_ERR(cli_close(cli->tree, fnum2))) {
+               printf("close2 failed (%s)\n", cli_errstr(cli->tree));
                return False;
        }
 
-       if (!cli_close(cli, fnum3)) {
-               printf("close3 failed (%s)\n", cli_errstr(cli));
+       if (NT_STATUS_IS_ERR(cli_close(cli->tree, fnum3))) {
+               printf("close3 failed (%s)\n", cli_errstr(cli->tree));
                return False;
        }
 
@@ -1168,10 +1031,10 @@ static BOOL run_locktest3(int dummy)
        struct cli_state *cli1, *cli2;
        const char *fname = "\\lockt3.lck";
        int fnum1, fnum2, i;
-       uint32 offset;
+       uint32_t offset;
        BOOL correct = True;
 
-#define NEXT_OFFSET offset += (~(uint32)0) / torture_numops
+#define NEXT_OFFSET offset += (~(uint32_t)0) / torture_numops
 
        if (!torture_open_connection(&cli1) || !torture_open_connection(&cli2)) {
                return False;
@@ -1181,16 +1044,16 @@ static BOOL run_locktest3(int dummy)
 
        printf("Testing 32 bit offset ranges\n");
 
-       cli_unlink(cli1, fname);
+       cli_unlink(cli1->tree, fname);
 
-       fnum1 = cli_open(cli1, fname, O_RDWR|O_CREAT|O_EXCL, DENY_NONE);
+       fnum1 = cli_open(cli1->tree, fname, O_RDWR|O_CREAT|O_EXCL, DENY_NONE);
        if (fnum1 == -1) {
-               printf("open of %s failed (%s)\n", fname, cli_errstr(cli1));
+               printf("open of %s failed (%s)\n", fname, cli_errstr(cli1->tree));
                return False;
        }
-       fnum2 = cli_open(cli2, fname, O_RDWR, DENY_NONE);
+       fnum2 = cli_open(cli2->tree, fname, O_RDWR, DENY_NONE);
        if (fnum2 == -1) {
-               printf("open2 of %s failed (%s)\n", fname, cli_errstr(cli2));
+               printf("open2 of %s failed (%s)\n", fname, cli_errstr(cli2->tree));
                return False;
        }
 
@@ -1198,17 +1061,17 @@ static BOOL run_locktest3(int dummy)
 
        for (offset=i=0;i<torture_numops;i++) {
                NEXT_OFFSET;
-               if (!cli_lock(cli1, fnum1, offset-1, 1, 0, WRITE_LOCK)) {
+               if (NT_STATUS_IS_ERR(cli_lock(cli1->tree, fnum1, offset-1, 1, 0, WRITE_LOCK))) {
                        printf("lock1 %d failed (%s)\n", 
                               i,
-                              cli_errstr(cli1));
+                              cli_errstr(cli1->tree));
                        return False;
                }
 
-               if (!cli_lock(cli2, fnum2, offset-2, 1, 0, WRITE_LOCK)) {
+               if (NT_STATUS_IS_ERR(cli_lock(cli2->tree, fnum2, offset-2, 1, 0, WRITE_LOCK))) {
                        printf("lock2 %d failed (%s)\n", 
                               i,
-                              cli_errstr(cli1));
+                              cli_errstr(cli1->tree));
                        return False;
                }
        }
@@ -1218,22 +1081,22 @@ static BOOL run_locktest3(int dummy)
        for (offset=i=0;i<torture_numops;i++) {
                NEXT_OFFSET;
 
-               if (cli_lock(cli1, fnum1, offset-2, 1, 0, WRITE_LOCK)) {
+               if (NT_STATUS_IS_OK(cli_lock(cli1->tree, fnum1, offset-2, 1, 0, WRITE_LOCK))) {
                        printf("error: lock1 %d succeeded!\n", i);
                        return False;
                }
 
-               if (cli_lock(cli2, fnum2, offset-1, 1, 0, WRITE_LOCK)) {
+               if (NT_STATUS_IS_OK(cli_lock(cli2->tree, fnum2, offset-1, 1, 0, WRITE_LOCK))) {
                        printf("error: lock2 %d succeeded!\n", i);
                        return False;
                }
 
-               if (cli_lock(cli1, fnum1, offset-1, 1, 0, WRITE_LOCK)) {
+               if (NT_STATUS_IS_OK(cli_lock(cli1->tree, fnum1, offset-1, 1, 0, WRITE_LOCK))) {
                        printf("error: lock3 %d succeeded!\n", i);
                        return False;
                }
 
-               if (cli_lock(cli2, fnum2, offset-2, 1, 0, WRITE_LOCK)) {
+               if (NT_STATUS_IS_OK(cli_lock(cli2->tree, fnum2, offset-2, 1, 0, WRITE_LOCK))) {
                        printf("error: lock4 %d succeeded!\n", i);
                        return False;
                }
@@ -1244,33 +1107,33 @@ static BOOL run_locktest3(int dummy)
        for (offset=i=0;i<torture_numops;i++) {
                NEXT_OFFSET;
 
-               if (!cli_unlock(cli1, fnum1, offset-1, 1)) {
+               if (NT_STATUS_IS_ERR(cli_unlock(cli1->tree, fnum1, offset-1, 1))) {
                        printf("unlock1 %d failed (%s)\n", 
                               i,
-                              cli_errstr(cli1));
+                              cli_errstr(cli1->tree));
                        return False;
                }
 
-               if (!cli_unlock(cli2, fnum2, offset-2, 1)) {
+               if (NT_STATUS_IS_ERR(cli_unlock(cli2->tree, fnum2, offset-2, 1))) {
                        printf("unlock2 %d failed (%s)\n", 
                               i,
-                              cli_errstr(cli1));
+                              cli_errstr(cli1->tree));
                        return False;
                }
        }
 
-       if (!cli_close(cli1, fnum1)) {
-               printf("close1 failed (%s)\n", cli_errstr(cli1));
+       if (NT_STATUS_IS_ERR(cli_close(cli1->tree, fnum1))) {
+               printf("close1 failed (%s)\n", cli_errstr(cli1->tree));
                return False;
        }
 
-       if (!cli_close(cli2, fnum2)) {
-               printf("close2 failed (%s)\n", cli_errstr(cli2));
+       if (NT_STATUS_IS_ERR(cli_close(cli2->tree, fnum2))) {
+               printf("close2 failed (%s)\n", cli_errstr(cli2->tree));
                return False;
        }
 
-       if (!cli_unlink(cli1, fname)) {
-               printf("unlink failed (%s)\n", cli_errstr(cli1));
+       if (NT_STATUS_IS_ERR(cli_unlink(cli1->tree, fname))) {
+               printf("unlink failed (%s)\n", cli_errstr(cli1->tree));
                return False;
        }
 
@@ -1309,149 +1172,149 @@ static BOOL run_locktest4(int dummy)
 
        printf("starting locktest4\n");
 
-       cli_unlink(cli1, fname);
+       cli_unlink(cli1->tree, fname);
 
-       fnum1 = cli_open(cli1, fname, O_RDWR|O_CREAT|O_EXCL, DENY_NONE);
-       fnum2 = cli_open(cli2, fname, O_RDWR, DENY_NONE);
+       fnum1 = cli_open(cli1->tree, fname, O_RDWR|O_CREAT|O_EXCL, DENY_NONE);
+       fnum2 = cli_open(cli2->tree, fname, O_RDWR, DENY_NONE);
 
        memset(buf, 0, sizeof(buf));
 
-       if (cli_write(cli1, fnum1, 0, buf, 0, sizeof(buf)) != sizeof(buf)) {
+       if (cli_write(cli1->tree, fnum1, 0, buf, 0, sizeof(buf)) != sizeof(buf)) {
                printf("Failed to create file\n");
                correct = False;
                goto fail;
        }
 
-       ret = cli_lock(cli1, fnum1, 0, 4, 0, WRITE_LOCK) &&
-             cli_lock(cli1, fnum1, 2, 4, 0, WRITE_LOCK);
+       ret = NT_STATUS_IS_OK(cli_lock(cli1->tree, fnum1, 0, 4, 0, WRITE_LOCK)) &&
+             NT_STATUS_IS_OK(cli_lock(cli1->tree, fnum1, 2, 4, 0, WRITE_LOCK));
        EXPECTED(ret, False);
        printf("the same process %s set overlapping write locks\n", ret?"can":"cannot");
            
-       ret = cli_lock(cli1, fnum1, 10, 4, 0, READ_LOCK) &&
-             cli_lock(cli1, fnum1, 12, 4, 0, READ_LOCK);
+       ret = NT_STATUS_IS_OK(cli_lock(cli1->tree, fnum1, 10, 4, 0, READ_LOCK)) &&
+             NT_STATUS_IS_OK(cli_lock(cli1->tree, fnum1, 12, 4, 0, READ_LOCK));
        EXPECTED(ret, True);
        printf("the same process %s set overlapping read locks\n", ret?"can":"cannot");
 
-       ret = cli_lock(cli1, fnum1, 20, 4, 0, WRITE_LOCK) &&
-             cli_lock(cli2, fnum2, 22, 4, 0, WRITE_LOCK);
+       ret = NT_STATUS_IS_OK(cli_lock(cli1->tree, fnum1, 20, 4, 0, WRITE_LOCK)) &&
+             NT_STATUS_IS_OK(cli_lock(cli2->tree, fnum2, 22, 4, 0, WRITE_LOCK));
        EXPECTED(ret, False);
        printf("a different connection %s set overlapping write locks\n", ret?"can":"cannot");
            
-       ret = cli_lock(cli1, fnum1, 30, 4, 0, READ_LOCK) &&
-             cli_lock(cli2, fnum2, 32, 4, 0, READ_LOCK);
+       ret = NT_STATUS_IS_OK(cli_lock(cli1->tree, fnum1, 30, 4, 0, READ_LOCK)) &&
+               NT_STATUS_IS_OK(cli_lock(cli2->tree, fnum2, 32, 4, 0, READ_LOCK));
        EXPECTED(ret, True);
        printf("a different connection %s set overlapping read locks\n", ret?"can":"cannot");
        
-       ret = (cli1->session->pid = 1, cli_lock(cli1, fnum1, 40, 4, 0, WRITE_LOCK)) &&
-             (cli1->session->pid = 2, cli_lock(cli1, fnum1, 42, 4, 0, WRITE_LOCK));
+       ret = NT_STATUS_IS_OK((cli1->session->pid = 1, cli_lock(cli1->tree, fnum1, 40, 4, 0, WRITE_LOCK))) &&
+             NT_STATUS_IS_OK((cli1->session->pid = 2, cli_lock(cli1->tree, fnum1, 42, 4, 0, WRITE_LOCK)));
        EXPECTED(ret, False);
        printf("a different pid %s set overlapping write locks\n", ret?"can":"cannot");
            
-       ret = (cli1->session->pid = 1, cli_lock(cli1, fnum1, 50, 4, 0, READ_LOCK)) &&
-             (cli1->session->pid = 2, cli_lock(cli1, fnum1, 52, 4, 0, READ_LOCK));
+       ret = NT_STATUS_IS_OK((cli1->session->pid = 1, cli_lock(cli1->tree, fnum1, 50, 4, 0, READ_LOCK))) &&
+             NT_STATUS_IS_OK((cli1->session->pid = 2, cli_lock(cli1->tree, fnum1, 52, 4, 0, READ_LOCK)));
        EXPECTED(ret, True);
        printf("a different pid %s set overlapping read locks\n", ret?"can":"cannot");
 
-       ret = cli_lock(cli1, fnum1, 60, 4, 0, READ_LOCK) &&
-             cli_lock(cli1, fnum1, 60, 4, 0, READ_LOCK);
+       ret = NT_STATUS_IS_OK(cli_lock(cli1->tree, fnum1, 60, 4, 0, READ_LOCK)) &&
+             NT_STATUS_IS_OK(cli_lock(cli1->tree, fnum1, 60, 4, 0, READ_LOCK));
        EXPECTED(ret, True);
        printf("the same process %s set the same read lock twice\n", ret?"can":"cannot");
 
-       ret = cli_lock(cli1, fnum1, 70, 4, 0, WRITE_LOCK) &&
-             cli_lock(cli1, fnum1, 70, 4, 0, WRITE_LOCK);
+       ret = NT_STATUS_IS_OK(cli_lock(cli1->tree, fnum1, 70, 4, 0, WRITE_LOCK)) &&
+             NT_STATUS_IS_OK(cli_lock(cli1->tree, fnum1, 70, 4, 0, WRITE_LOCK));
        EXPECTED(ret, False);
        printf("the same process %s set the same write lock twice\n", ret?"can":"cannot");
 
-       ret = cli_lock(cli1, fnum1, 80, 4, 0, READ_LOCK) &&
-             cli_lock(cli1, fnum1, 80, 4, 0, WRITE_LOCK);
+       ret = NT_STATUS_IS_OK(cli_lock(cli1->tree, fnum1, 80, 4, 0, READ_LOCK)) &&
+             NT_STATUS_IS_OK(cli_lock(cli1->tree, fnum1, 80, 4, 0, WRITE_LOCK));
        EXPECTED(ret, False);
        printf("the same process %s overlay a read lock with a write lock\n", ret?"can":"cannot");
 
-       ret = cli_lock(cli1, fnum1, 90, 4, 0, WRITE_LOCK) &&
-             cli_lock(cli1, fnum1, 90, 4, 0, READ_LOCK);
+       ret = NT_STATUS_IS_OK(cli_lock(cli1->tree, fnum1, 90, 4, 0, WRITE_LOCK)) &&
+             NT_STATUS_IS_OK(cli_lock(cli1->tree, fnum1, 90, 4, 0, READ_LOCK));
        EXPECTED(ret, True);
        printf("the same process %s overlay a write lock with a read lock\n", ret?"can":"cannot");
 
-       ret = (cli1->session->pid = 1, cli_lock(cli1, fnum1, 100, 4, 0, WRITE_LOCK)) &&
-             (cli1->session->pid = 2, cli_lock(cli1, fnum1, 100, 4, 0, READ_LOCK));
+       ret = NT_STATUS_IS_OK((cli1->session->pid = 1, cli_lock(cli1->tree, fnum1, 100, 4, 0, WRITE_LOCK))) &&
+             NT_STATUS_IS_OK((cli1->session->pid = 2, cli_lock(cli1->tree, fnum1, 100, 4, 0, READ_LOCK)));
        EXPECTED(ret, False);
        printf("a different pid %s overlay a write lock with a read lock\n", ret?"can":"cannot");
 
-       ret = cli_lock(cli1, fnum1, 110, 4, 0, READ_LOCK) &&
-             cli_lock(cli1, fnum1, 112, 4, 0, READ_LOCK) &&
-             cli_unlock(cli1, fnum1, 110, 6);
+       ret = NT_STATUS_IS_OK(cli_lock(cli1->tree, fnum1, 110, 4, 0, READ_LOCK)) &&
+             NT_STATUS_IS_OK(cli_lock(cli1->tree, fnum1, 112, 4, 0, READ_LOCK)) &&
+             NT_STATUS_IS_OK(cli_unlock(cli1->tree, fnum1, 110, 6));
        EXPECTED(ret, False);
        printf("the same process %s coalesce read locks\n", ret?"can":"cannot");
 
 
-       ret = cli_lock(cli1, fnum1, 120, 4, 0, WRITE_LOCK) &&
-             (cli_read(cli2, fnum2, buf, 120, 4) == 4);
+       ret = NT_STATUS_IS_OK(cli_lock(cli1->tree, fnum1, 120, 4, 0, WRITE_LOCK)) &&
+             (cli_read(cli2->tree, fnum2, buf, 120, 4) == 4);
        EXPECTED(ret, False);
        printf("this server %s strict write locking\n", ret?"doesn't do":"does");
 
-       ret = cli_lock(cli1, fnum1, 130, 4, 0, READ_LOCK) &&
-             (cli_write(cli2, fnum2, 0, buf, 130, 4) == 4);
+       ret = NT_STATUS_IS_OK(cli_lock(cli1->tree, fnum1, 130, 4, 0, READ_LOCK)) &&
+             (cli_write(cli2->tree, fnum2, 0, buf, 130, 4) == 4);
        EXPECTED(ret, False);
        printf("this server %s strict read locking\n", ret?"doesn't do":"does");
 
 
-       ret = cli_lock(cli1, fnum1, 140, 4, 0, READ_LOCK) &&
-             cli_lock(cli1, fnum1, 140, 4, 0, READ_LOCK) &&
-             cli_unlock(cli1, fnum1, 140, 4) &&
-             cli_unlock(cli1, fnum1, 140, 4);
+       ret = NT_STATUS_IS_OK(cli_lock(cli1->tree, fnum1, 140, 4, 0, READ_LOCK)) &&
+             NT_STATUS_IS_OK(cli_lock(cli1->tree, fnum1, 140, 4, 0, READ_LOCK)) &&
+             NT_STATUS_IS_OK(cli_unlock(cli1->tree, fnum1, 140, 4)) &&
+             NT_STATUS_IS_OK(cli_unlock(cli1->tree, fnum1, 140, 4));
        EXPECTED(ret, True);
        printf("this server %s do recursive read locking\n", ret?"does":"doesn't");
 
 
-       ret = cli_lock(cli1, fnum1, 150, 4, 0, WRITE_LOCK) &&
-             cli_lock(cli1, fnum1, 150, 4, 0, READ_LOCK) &&
-             cli_unlock(cli1, fnum1, 150, 4) &&
-             (cli_read(cli2, fnum2, buf, 150, 4) == 4) &&
-             !(cli_write(cli2, fnum2, 0, buf, 150, 4) == 4) &&
-             cli_unlock(cli1, fnum1, 150, 4);
+       ret = NT_STATUS_IS_OK(cli_lock(cli1->tree, fnum1, 150, 4, 0, WRITE_LOCK)) &&
+             NT_STATUS_IS_OK(cli_lock(cli1->tree, fnum1, 150, 4, 0, READ_LOCK)) &&
+             NT_STATUS_IS_OK(cli_unlock(cli1->tree, fnum1, 150, 4)) &&
+             (cli_read(cli2->tree, fnum2, buf, 150, 4) == 4) &&
+             !(cli_write(cli2->tree, fnum2, 0, buf, 150, 4) == 4) &&
+             NT_STATUS_IS_OK(cli_unlock(cli1->tree, fnum1, 150, 4));
        EXPECTED(ret, True);
        printf("this server %s do recursive lock overlays\n", ret?"does":"doesn't");
 
-       ret = cli_lock(cli1, fnum1, 160, 4, 0, READ_LOCK) &&
-             cli_unlock(cli1, fnum1, 160, 4) &&
-             (cli_write(cli2, fnum2, 0, buf, 160, 4) == 4) &&          
-             (cli_read(cli2, fnum2, buf, 160, 4) == 4);                
+       ret = NT_STATUS_IS_OK(cli_lock(cli1->tree, fnum1, 160, 4, 0, READ_LOCK)) &&
+             NT_STATUS_IS_OK(cli_unlock(cli1->tree, fnum1, 160, 4)) &&
+             (cli_write(cli2->tree, fnum2, 0, buf, 160, 4) == 4) &&            
+             (cli_read(cli2->tree, fnum2, buf, 160, 4) == 4);          
        EXPECTED(ret, True);
        printf("the same process %s remove a read lock using write locking\n", ret?"can":"cannot");
 
-       ret = cli_lock(cli1, fnum1, 170, 4, 0, WRITE_LOCK) &&
-             cli_unlock(cli1, fnum1, 170, 4) &&
-             (cli_write(cli2, fnum2, 0, buf, 170, 4) == 4) &&          
-             (cli_read(cli2, fnum2, buf, 170, 4) == 4);                
+       ret = NT_STATUS_IS_OK(cli_lock(cli1->tree, fnum1, 170, 4, 0, WRITE_LOCK)) &&
+             NT_STATUS_IS_OK(cli_unlock(cli1->tree, fnum1, 170, 4)) &&
+             (cli_write(cli2->tree, fnum2, 0, buf, 170, 4) == 4) &&            
+             (cli_read(cli2->tree, fnum2, buf, 170, 4) == 4);          
        EXPECTED(ret, True);
        printf("the same process %s remove a write lock using read locking\n", ret?"can":"cannot");
 
-       ret = cli_lock(cli1, fnum1, 190, 4, 0, WRITE_LOCK) &&
-             cli_lock(cli1, fnum1, 190, 4, 0, READ_LOCK) &&
-             cli_unlock(cli1, fnum1, 190, 4) &&
-             !(cli_write(cli2, fnum2, 0, buf, 190, 4) == 4) &&         
-             (cli_read(cli2, fnum2, buf, 190, 4) == 4);                
+       ret = NT_STATUS_IS_OK(cli_lock(cli1->tree, fnum1, 190, 4, 0, WRITE_LOCK)) &&
+             NT_STATUS_IS_OK(cli_lock(cli1->tree, fnum1, 190, 4, 0, READ_LOCK)) &&
+             NT_STATUS_IS_OK(cli_unlock(cli1->tree, fnum1, 190, 4)) &&
+             !(cli_write(cli2->tree, fnum2, 0, buf, 190, 4) == 4) &&           
+             (cli_read(cli2->tree, fnum2, buf, 190, 4) == 4);          
        EXPECTED(ret, True);
        printf("the same process %s remove the first lock first\n", ret?"does":"doesn't");
 
-       cli_close(cli1, fnum1);
-       cli_close(cli2, fnum2);
-       fnum1 = cli_open(cli1, fname, O_RDWR, DENY_NONE);
-       f = cli_open(cli1, fname, O_RDWR, DENY_NONE);
-       ret = cli_lock(cli1, fnum1, 0, 8, 0, READ_LOCK) &&
-             cli_lock(cli1, f, 0, 1, 0, READ_LOCK) &&
-             cli_close(cli1, fnum1) &&
-             ((fnum1 = cli_open(cli1, fname, O_RDWR, DENY_NONE)) != -1) &&
-             cli_lock(cli1, fnum1, 7, 1, 0, WRITE_LOCK);
-        cli_close(cli1, f);
-       cli_close(cli1, fnum1);
+       cli_close(cli1->tree, fnum1);
+       cli_close(cli2->tree, fnum2);
+       fnum1 = cli_open(cli1->tree, fname, O_RDWR, DENY_NONE);
+       f = cli_open(cli1->tree, fname, O_RDWR, DENY_NONE);
+       ret = NT_STATUS_IS_OK(cli_lock(cli1->tree, fnum1, 0, 8, 0, READ_LOCK)) &&
+             NT_STATUS_IS_OK(cli_lock(cli1->tree, f, 0, 1, 0, READ_LOCK)) &&
+             NT_STATUS_IS_OK(cli_close(cli1->tree, fnum1)) &&
+             ((fnum1 = cli_open(cli1->tree, fname, O_RDWR, DENY_NONE)) != -1) &&
+             NT_STATUS_IS_OK(cli_lock(cli1->tree, fnum1, 7, 1, 0, WRITE_LOCK));
+        cli_close(cli1->tree, f);
+       cli_close(cli1->tree, fnum1);
        EXPECTED(ret, True);
        printf("the server %s have the NT byte range lock bug\n", !ret?"does":"doesn't");
 
  fail:
-       cli_close(cli1, fnum1);
-       cli_close(cli2, fnum2);
-       cli_unlink(cli1, fname);
+       cli_close(cli1->tree, fnum1);
+       cli_close(cli2->tree, fnum2);
+       cli_unlink(cli1->tree, fname);
        torture_close_connection(cli1);
        torture_close_connection(cli2);
 
@@ -1477,56 +1340,56 @@ static BOOL run_locktest5(int dummy)
 
        printf("starting locktest5\n");
 
-       cli_unlink(cli1, fname);
+       cli_unlink(cli1->tree, fname);
 
-       fnum1 = cli_open(cli1, fname, O_RDWR|O_CREAT|O_EXCL, DENY_NONE);
-       fnum2 = cli_open(cli2, fname, O_RDWR, DENY_NONE);
-       fnum3 = cli_open(cli1, fname, O_RDWR, DENY_NONE);
+       fnum1 = cli_open(cli1->tree, fname, O_RDWR|O_CREAT|O_EXCL, DENY_NONE);
+       fnum2 = cli_open(cli2->tree, fname, O_RDWR, DENY_NONE);
+       fnum3 = cli_open(cli1->tree, fname, O_RDWR, DENY_NONE);
 
        memset(buf, 0, sizeof(buf));
 
-       if (cli_write(cli1, fnum1, 0, buf, 0, sizeof(buf)) != sizeof(buf)) {
+       if (cli_write(cli1->tree, fnum1, 0, buf, 0, sizeof(buf)) != sizeof(buf)) {
                printf("Failed to create file\n");
                correct = False;
                goto fail;
        }
 
        /* Check for NT bug... */
-       ret = cli_lock(cli1, fnum1, 0, 8, 0, READ_LOCK) &&
-                 cli_lock(cli1, fnum3, 0, 1, 0, READ_LOCK);
-       cli_close(cli1, fnum1);
-       fnum1 = cli_open(cli1, fname, O_RDWR, DENY_NONE);
-       ret = cli_lock(cli1, fnum1, 7, 1, 0, WRITE_LOCK);
+       ret = NT_STATUS_IS_OK(cli_lock(cli1->tree, fnum1, 0, 8, 0, READ_LOCK)) &&
+                 NT_STATUS_IS_OK(cli_lock(cli1->tree, fnum3, 0, 1, 0, READ_LOCK));
+       cli_close(cli1->tree, fnum1);
+       fnum1 = cli_open(cli1->tree, fname, O_RDWR, DENY_NONE);
+       ret = NT_STATUS_IS_OK(cli_lock(cli1->tree, fnum1, 7, 1, 0, WRITE_LOCK));
        EXPECTED(ret, True);
        printf("this server %s the NT locking bug\n", ret ? "doesn't have" : "has");
-       cli_close(cli1, fnum1);
-       fnum1 = cli_open(cli1, fname, O_RDWR, DENY_NONE);
-       cli_unlock(cli1, fnum3, 0, 1);
+       cli_close(cli1->tree, fnum1);
+       fnum1 = cli_open(cli1->tree, fname, O_RDWR, DENY_NONE);
+       cli_unlock(cli1->tree, fnum3, 0, 1);
 
-       ret = cli_lock(cli1, fnum1, 0, 4, 0, WRITE_LOCK) &&
-             cli_lock(cli1, fnum1, 1, 1, 0, READ_LOCK);
+       ret = NT_STATUS_IS_OK(cli_lock(cli1->tree, fnum1, 0, 4, 0, WRITE_LOCK)) &&
+             NT_STATUS_IS_OK(cli_lock(cli1->tree, fnum1, 1, 1, 0, READ_LOCK));
        EXPECTED(ret, True);
        printf("the same process %s overlay a write with a read lock\n", ret?"can":"cannot");
 
-       ret = cli_lock(cli2, fnum2, 0, 4, 0, READ_LOCK);
+       ret = NT_STATUS_IS_OK(cli_lock(cli2->tree, fnum2, 0, 4, 0, READ_LOCK));
        EXPECTED(ret, False);
 
        printf("a different processs %s get a read lock on the first process lock stack\n", ret?"can":"cannot");
 
        /* Unlock the process 2 lock. */
-       cli_unlock(cli2, fnum2, 0, 4);
+       cli_unlock(cli2->tree, fnum2, 0, 4);
 
-       ret = cli_lock(cli1, fnum3, 0, 4, 0, READ_LOCK);
+       ret = NT_STATUS_IS_OK(cli_lock(cli1->tree, fnum3, 0, 4, 0, READ_LOCK));
        EXPECTED(ret, False);
 
        printf("the same processs on a different fnum %s get a read lock\n", ret?"can":"cannot");
 
        /* Unlock the process 1 fnum3 lock. */
-       cli_unlock(cli1, fnum3, 0, 4);
+       cli_unlock(cli1->tree, fnum3, 0, 4);
 
        /* Stack 2 more locks here. */
-       ret = cli_lock(cli1, fnum1, 0, 4, 0, READ_LOCK) &&
-                 cli_lock(cli1, fnum1, 0, 4, 0, READ_LOCK);
+       ret = NT_STATUS_IS_OK(cli_lock(cli1->tree, fnum1, 0, 4, 0, READ_LOCK)) &&
+                 NT_STATUS_IS_OK(cli_lock(cli1->tree, fnum1, 0, 4, 0, READ_LOCK));
 
        EXPECTED(ret, True);
        printf("the same process %s stack read locks\n", ret?"can":"cannot");
@@ -1534,40 +1397,40 @@ static BOOL run_locktest5(int dummy)
        /* Unlock the first process lock, then check this was the WRITE lock that was
                removed. */
 
-       ret = cli_unlock(cli1, fnum1, 0, 4) &&
-                       cli_lock(cli2, fnum2, 0, 4, 0, READ_LOCK);
+ret = NT_STATUS_IS_OK(cli_unlock(cli1->tree, fnum1, 0, 4)) &&
+       NT_STATUS_IS_OK(cli_lock(cli2->tree, fnum2, 0, 4, 0, READ_LOCK));
 
        EXPECTED(ret, True);
        printf("the first unlock removes the %s lock\n", ret?"WRITE":"READ");
 
        /* Unlock the process 2 lock. */
-       cli_unlock(cli2, fnum2, 0, 4);
+       cli_unlock(cli2->tree, fnum2, 0, 4);
 
        /* We should have 3 stacked locks here. Ensure we need to do 3 unlocks. */
 
-       ret = cli_unlock(cli1, fnum1, 1, 1) &&
-                 cli_unlock(cli1, fnum1, 0, 4) &&
-                 cli_unlock(cli1, fnum1, 0, 4);
+       ret = NT_STATUS_IS_OK(cli_unlock(cli1->tree, fnum1, 1, 1)) &&
+                 NT_STATUS_IS_OK(cli_unlock(cli1->tree, fnum1, 0, 4)) &&
+                 NT_STATUS_IS_OK(cli_unlock(cli1->tree, fnum1, 0, 4));
 
        EXPECTED(ret, True);
        printf("the same process %s unlock the stack of 4 locks\n", ret?"can":"cannot"); 
 
        /* Ensure the next unlock fails. */
-       ret = cli_unlock(cli1, fnum1, 0, 4);
+       ret = NT_STATUS_IS_OK(cli_unlock(cli1->tree, fnum1, 0, 4));
        EXPECTED(ret, False);
        printf("the same process %s count the lock stack\n", !ret?"can":"cannot"); 
 
        /* Ensure connection 2 can get a write lock. */
-       ret = cli_lock(cli2, fnum2, 0, 4, 0, WRITE_LOCK);
+       ret = NT_STATUS_IS_OK(cli_lock(cli2->tree, fnum2, 0, 4, 0, WRITE_LOCK));
        EXPECTED(ret, True);
 
        printf("a different processs %s get a write lock on the unlocked stack\n", ret?"can":"cannot");
 
 
  fail:
-       cli_close(cli1, fnum1);
-       cli_close(cli2, fnum2);
-       cli_unlink(cli1, fname);
+       cli_close(cli1->tree, fnum1);
+       cli_close(cli2->tree, fnum2);
+       cli_unlink(cli1->tree, fname);
        if (!torture_close_connection(cli1)) {
                correct = False;
        }
@@ -1600,19 +1463,19 @@ static BOOL run_locktest6(int dummy)
        for (i=0;i<1;i++) {
                printf("Testing %s\n", fname[i]);
 
-               cli_unlink(cli, fname[i]);
+               cli_unlink(cli->tree, fname[i]);
 
-               fnum = cli_open(cli, fname[i], O_RDWR|O_CREAT|O_EXCL, DENY_NONE);
-               status = cli_locktype(cli, fnum, 0, 8, 0, LOCKING_ANDX_CHANGE_LOCKTYPE);
-               cli_close(cli, fnum);
+               fnum = cli_open(cli->tree, fname[i], O_RDWR|O_CREAT|O_EXCL, DENY_NONE);
+               status = cli_locktype(cli->tree, fnum, 0, 8, 0, LOCKING_ANDX_CHANGE_LOCKTYPE);
+               cli_close(cli->tree, fnum);
                printf("CHANGE_LOCKTYPE gave %s\n", nt_errstr(status));
 
-               fnum = cli_open(cli, fname[i], O_RDWR, DENY_NONE);
-               status = cli_locktype(cli, fnum, 0, 8, 0, LOCKING_ANDX_CANCEL_LOCK);
-               cli_close(cli, fnum);
+               fnum = cli_open(cli->tree, fname[i], O_RDWR, DENY_NONE);
+               status = cli_locktype(cli->tree, fnum, 0, 8, 0, LOCKING_ANDX_CANCEL_LOCK);
+               cli_close(cli->tree, fnum);
                printf("CANCEL_LOCK gave %s\n", nt_errstr(status));
 
-               cli_unlink(cli, fname[i]);
+               cli_unlink(cli->tree, fname[i]);
        }
 
        torture_close_connection(cli);
@@ -1626,6 +1489,8 @@ static BOOL run_locktest7(int dummy)
        struct cli_state *cli1;
        const char *fname = "\\lockt7.lck";
        int fnum1;
+       int fnum2;
+       size_t size;
        char buf[200];
        BOOL correct = False;
 
@@ -1635,36 +1500,36 @@ static BOOL run_locktest7(int dummy)
 
        printf("starting locktest7\n");
 
-       cli_unlink(cli1, fname);
+       cli_unlink(cli1->tree, fname);
 
-       fnum1 = cli_open(cli1, fname, O_RDWR|O_CREAT|O_EXCL, DENY_NONE);
+       fnum1 = cli_open(cli1->tree, fname, O_RDWR|O_CREAT|O_EXCL, DENY_NONE);
 
        memset(buf, 0, sizeof(buf));
 
-       if (cli_write(cli1, fnum1, 0, buf, 0, sizeof(buf)) != sizeof(buf)) {
+       if (cli_write(cli1->tree, fnum1, 0, buf, 0, sizeof(buf)) != sizeof(buf)) {
                printf("Failed to create file\n");
                goto fail;
        }
 
        cli1->session->pid = 1;
 
-       if (!cli_lock(cli1, fnum1, 130, 4, 0, READ_LOCK)) {
-               printf("Unable to apply read lock on range 130:4, error was %s\n", cli_errstr(cli1));
+       if (NT_STATUS_IS_ERR(cli_lock(cli1->tree, fnum1, 130, 4, 0, READ_LOCK))) {
+               printf("Unable to apply read lock on range 130:4, error was %s\n", cli_errstr(cli1->tree));
                goto fail;
        } else {
                printf("pid1 successfully locked range 130:4 for READ\n");
        }
 
-       if (cli_read(cli1, fnum1, buf, 130, 4) != 4) {
-               printf("pid1 unable to read the range 130:4, error was %s\n", cli_errstr(cli1));
+       if (cli_read(cli1->tree, fnum1, buf, 130, 4) != 4) {
+               printf("pid1 unable to read the range 130:4, error was %s\n", cli_errstr(cli1->tree));
                goto fail;
        } else {
                printf("pid1 successfully read the range 130:4\n");
        }
 
-       if (cli_write(cli1, fnum1, 0, buf, 130, 4) != 4) {
-               printf("pid1 unable to write to the range 130:4, error was %s\n", cli_errstr(cli1));
-               if (NT_STATUS_V(cli_nt_error(cli1)) != NT_STATUS_V(NT_STATUS_FILE_LOCK_CONFLICT)) {
+       if (cli_write(cli1->tree, fnum1, 0, buf, 130, 4) != 4) {
+               printf("pid1 unable to write to the range 130:4, error was %s\n", cli_errstr(cli1->tree));
+               if (NT_STATUS_V(cli_nt_error(cli1->tree)) != NT_STATUS_V(NT_STATUS_FILE_LOCK_CONFLICT)) {
                        printf("Incorrect error (should be NT_STATUS_FILE_LOCK_CONFLICT)\n");
                        goto fail;
                }
@@ -1675,15 +1540,15 @@ static BOOL run_locktest7(int dummy)
 
        cli1->session->pid = 2;
 
-       if (cli_read(cli1, fnum1, buf, 130, 4) != 4) {
-               printf("pid2 unable to read the range 130:4, error was %s\n", cli_errstr(cli1));
+       if (cli_read(cli1->tree, fnum1, buf, 130, 4) != 4) {
+               printf("pid2 unable to read the range 130:4, error was %s\n", cli_errstr(cli1->tree));
        } else {
                printf("pid2 successfully read the range 130:4\n");
        }
 
-       if (cli_write(cli1, fnum1, 0, buf, 130, 4) != 4) {
-               printf("pid2 unable to write to the range 130:4, error was %s\n", cli_errstr(cli1));
-               if (NT_STATUS_V(cli_nt_error(cli1)) != NT_STATUS_V(NT_STATUS_FILE_LOCK_CONFLICT)) {
+       if (cli_write(cli1->tree, fnum1, 0, buf, 130, 4) != 4) {
+               printf("pid2 unable to write to the range 130:4, error was %s\n", cli_errstr(cli1->tree));
+               if (NT_STATUS_V(cli_nt_error(cli1->tree)) != NT_STATUS_V(NT_STATUS_FILE_LOCK_CONFLICT)) {
                        printf("Incorrect error (should be NT_STATUS_FILE_LOCK_CONFLICT)\n");
                        goto fail;
                }
@@ -1693,24 +1558,24 @@ static BOOL run_locktest7(int dummy)
        }
 
        cli1->session->pid = 1;
-       cli_unlock(cli1, fnum1, 130, 4);
+       cli_unlock(cli1->tree, fnum1, 130, 4);
 
-       if (!cli_lock(cli1, fnum1, 130, 4, 0, WRITE_LOCK)) {
-               printf("Unable to apply write lock on range 130:4, error was %s\n", cli_errstr(cli1));
+       if (NT_STATUS_IS_ERR(cli_lock(cli1->tree, fnum1, 130, 4, 0, WRITE_LOCK))) {
+               printf("Unable to apply write lock on range 130:4, error was %s\n", cli_errstr(cli1->tree));
                goto fail;
        } else {
                printf("pid1 successfully locked range 130:4 for WRITE\n");
        }
 
-       if (cli_read(cli1, fnum1, buf, 130, 4) != 4) {
-               printf("pid1 unable to read the range 130:4, error was %s\n", cli_errstr(cli1));
+       if (cli_read(cli1->tree, fnum1, buf, 130, 4) != 4) {
+               printf("pid1 unable to read the range 130:4, error was %s\n", cli_errstr(cli1->tree));
                goto fail;
        } else {
                printf("pid1 successfully read the range 130:4\n");
        }
 
-       if (cli_write(cli1, fnum1, 0, buf, 130, 4) != 4) {
-               printf("pid1 unable to write to the range 130:4, error was %s\n", cli_errstr(cli1));
+       if (cli_write(cli1->tree, fnum1, 0, buf, 130, 4) != 4) {
+               printf("pid1 unable to write to the range 130:4, error was %s\n", cli_errstr(cli1->tree));
                goto fail;
        } else {
                printf("pid1 successfully wrote to the range 130:4\n");
@@ -1718,9 +1583,9 @@ static BOOL run_locktest7(int dummy)
 
        cli1->session->pid = 2;
 
-       if (cli_read(cli1, fnum1, buf, 130, 4) != 4) {
-               printf("pid2 unable to read the range 130:4, error was %s\n", cli_errstr(cli1));
-               if (NT_STATUS_V(cli_nt_error(cli1)) != NT_STATUS_V(NT_STATUS_FILE_LOCK_CONFLICT)) {
+       if (cli_read(cli1->tree, fnum1, buf, 130, 4) != 4) {
+               printf("pid2 unable to read the range 130:4, error was %s\n", cli_errstr(cli1->tree));
+               if (NT_STATUS_V(cli_nt_error(cli1->tree)) != NT_STATUS_V(NT_STATUS_FILE_LOCK_CONFLICT)) {
                        printf("Incorrect error (should be NT_STATUS_FILE_LOCK_CONFLICT)\n");
                        goto fail;
                }
@@ -1729,9 +1594,9 @@ static BOOL run_locktest7(int dummy)
                goto fail;
        }
 
-       if (cli_write(cli1, fnum1, 0, buf, 130, 4) != 4) {
-               printf("pid2 unable to write to the range 130:4, error was %s\n", cli_errstr(cli1));
-               if (NT_STATUS_V(cli_nt_error(cli1)) != NT_STATUS_V(NT_STATUS_FILE_LOCK_CONFLICT)) {
+       if (cli_write(cli1->tree, fnum1, 0, buf, 130, 4) != 4) {
+               printf("pid2 unable to write to the range 130:4, error was %s\n", cli_errstr(cli1->tree));
+               if (NT_STATUS_V(cli_nt_error(cli1->tree)) != NT_STATUS_V(NT_STATUS_FILE_LOCK_CONFLICT)) {
                        printf("Incorrect error (should be NT_STATUS_FILE_LOCK_CONFLICT)\n");
                        goto fail;
                }
@@ -1740,12 +1605,39 @@ static BOOL run_locktest7(int dummy)
                goto fail;
        }
 
-       cli_unlock(cli1, fnum1, 130, 0);
+       printf("Testing truncate of locked file.\n");
+
+       fnum2 = cli_open(cli1->tree, fname, O_RDWR|O_TRUNC, DENY_NONE);
+
+       if (fnum2 == -1) {
+               printf("Unable to truncate locked file.\n");
+               correct = False;
+               goto fail;
+       } else {
+               printf("Truncated locked file.\n");
+       }
+
+       if (NT_STATUS_IS_ERR(cli_getatr(cli1->tree, fname, NULL, &size, NULL))) {
+               printf("getatr failed (%s)\n", cli_errstr(cli1->tree));
+               correct = False;
+               goto fail;
+       }
+
+       if (size != 0) {
+               printf("Unable to truncate locked file. Size was %u\n", size);
+               correct = False;
+               goto fail;
+       }
+
+       cli1->session->pid = 1;
+
+       cli_unlock(cli1->tree, fnum1, 130, 4);
        correct = True;
 
 fail:
-       cli_close(cli1, fnum1);
-       cli_unlink(cli1, fname);
+       cli_close(cli1->tree, fnum1);
+       cli_close(cli1->tree, fnum2);
+       cli_unlink(cli1->tree, fname);
        torture_close_connection(cli1);
 
        printf("finished locktest7\n");
@@ -1769,20 +1661,20 @@ static BOOL run_fdpasstest(int dummy)
 
        printf("starting fdpasstest\n");
 
-       cli_unlink(cli1, fname);
+       cli_unlink(cli1->tree, fname);
 
        printf("Opening a file on connection 1\n");
 
-       fnum1 = cli_open(cli1, fname, O_RDWR|O_CREAT|O_EXCL, DENY_NONE);
+       fnum1 = cli_open(cli1->tree, fname, O_RDWR|O_CREAT|O_EXCL, DENY_NONE);
        if (fnum1 == -1) {
-               printf("open of %s failed (%s)\n", fname, cli_errstr(cli1));
+               printf("open of %s failed (%s)\n", fname, cli_errstr(cli1->tree));
                return False;
        }
 
        printf("writing to file on connection 1\n");
 
-       if (cli_write(cli1, fnum1, 0, "hello world\n", 0, 13) != 13) {
-               printf("write failed (%s)\n", cli_errstr(cli1));
+       if (cli_write(cli1->tree, fnum1, 0, "hello world\n", 0, 13) != 13) {
+               printf("write failed (%s)\n", cli_errstr(cli1->tree));
                return False;
        }
 
@@ -1793,14 +1685,14 @@ static BOOL run_fdpasstest(int dummy)
 
        printf("reading from file on connection 2\n");
 
-       if (cli_read(cli2, fnum1, buf, 0, 13) == 13) {
+       if (cli_read(cli2->tree, fnum1, buf, 0, 13) == 13) {
                printf("read succeeded! nasty security hole [%s]\n",
                       buf);
                return False;
        }
 
-       cli_close(cli1, fnum1);
-       cli_unlink(cli1, fname);
+       cli_close(cli1->tree, fnum1);
+       cli_unlink(cli1->tree, fname);
 
        cli2->tree->tid = oldtid;
 
@@ -1830,21 +1722,21 @@ static BOOL run_unlinktest(int dummy)
 
        printf("starting unlink test\n");
 
-       cli_unlink(cli, fname);
+       cli_unlink(cli->tree, fname);
 
        cli->session->pid = 1;
 
        printf("Opening a file\n");
 
-       fnum = cli_open(cli, fname, O_RDWR|O_CREAT|O_EXCL, DENY_NONE);
+       fnum = cli_open(cli->tree, fname, O_RDWR|O_CREAT|O_EXCL, DENY_NONE);
        if (fnum == -1) {
-               printf("open of %s failed (%s)\n", fname, cli_errstr(cli));
+               printf("open of %s failed (%s)\n", fname, cli_errstr(cli->tree));
                return False;
        }
 
        printf("Unlinking a open file\n");
 
-       if (cli_unlink(cli, fname)) {
+       if (NT_STATUS_IS_OK(cli_unlink(cli->tree, fname))) {
                printf("error: server allowed unlink on an open file\n");
                correct = False;
        } else {
@@ -1852,8 +1744,8 @@ static BOOL run_unlinktest(int dummy)
                                      NT_STATUS_SHARING_VIOLATION);
        }
 
-       cli_close(cli, fnum);
-       cli_unlink(cli, fname);
+       cli_close(cli->tree, fnum);
+       cli_unlink(cli->tree, fname);
 
        if (!torture_close_connection(cli)) {
                correct = False;
@@ -1868,17 +1760,87 @@ static BOOL run_unlinktest(int dummy)
 /*
 test how many open files this server supports on the one socket
 */
-static BOOL run_maxfidtest(int dummy)
+
+static BOOL run_deferopen(struct cli_state *cli, int dummy)
+{
+       const char *fname = "\\defer_open_test.dat";
+       int retries=4;
+       int i = 0;
+       BOOL correct = True;
+
+       if (retries <= 0) {
+               printf("failed to connect\n");
+               return False;
+       }
+
+       printf("Testing deferred open requests.\n");
+
+       while (i < 4) {
+               int fnum = -1;
+
+               do {
+                       struct timeval tv_start, tv_end;
+                       GetTimeOfDay(&tv_start);
+                       fnum = cli_nt_create_full(cli->tree, fname, 0, GENERIC_RIGHTS_FILE_ALL_ACCESS,
+                               FILE_ATTRIBUTE_NORMAL, NTCREATEX_SHARE_ACCESS_NONE,
+                               NTCREATEX_DISP_OPEN_IF, 0, 0);
+                       if (fnum != -1) {
+                               break;
+                       }
+                       GetTimeOfDay(&tv_end);
+                       if (NT_STATUS_EQUAL(cli_nt_error(cli->tree),NT_STATUS_SHARING_VIOLATION)) {
+                               /* Sharing violation errors need to be 1 second apart. */
+                               int64_t tdif = usec_time_diff(&tv_end, &tv_start);
+                               if (tdif < 500000 || tdif > 1500000) {
+                                       fprintf(stderr,"Timing incorrect %lld.%lld for share violation\n",
+                                               tdif / (int64_t)1000000, 
+                                               tdif % (int64_t)1000000);
+                               }
+                       }
+               } while (NT_STATUS_EQUAL(cli_nt_error(cli->tree),NT_STATUS_SHARING_VIOLATION));
+
+               if (fnum == -1) {
+                       fprintf(stderr,"Failed to open %s, error=%s\n", fname, cli_errstr(cli->tree));
+                       return False;
+               }
+
+               printf("pid %u open %d\n", getpid(), i);
+
+               sleep(10);
+               i++;
+               if (NT_STATUS_IS_ERR(cli_close(cli->tree, fnum))) {
+                       fprintf(stderr,"Failed to close %s, error=%s\n", fname, cli_errstr(cli->tree));
+                       return False;
+               }
+               sleep(2);
+       }
+
+       if (NT_STATUS_IS_ERR(cli_unlink(cli->tree, fname))) {
+               /* All until the last unlink will fail with sharing violation. */
+               if (!NT_STATUS_EQUAL(cli_nt_error(cli->tree),NT_STATUS_SHARING_VIOLATION)) {
+                       printf("unlink of %s failed (%s)\n", fname, cli_errstr(cli->tree));
+                       correct = False;
+               }
+       }
+
+       printf("deferred test finished\n");
+       if (!torture_close_connection(cli)) {
+               correct = False;
+       }
+       return correct;
+}
+
+/*
+test how many open files this server supports on the one socket
+*/
+static BOOL run_maxfidtest(struct cli_state *cli, int dummy)
 {
-       struct cli_state *cli;
        const char *template = "\\maxfid.%d.%d";
        char *fname;
        int fnums[0x11000], i;
        int retries=4;
        BOOL correct = True;
 
-       cli = current_cli;
-
        if (retries <= 0) {
                printf("failed to connect\n");
                return False;
@@ -1888,11 +1850,11 @@ static BOOL run_maxfidtest(int dummy)
 
        for (i=0; i<0x11000; i++) {
                asprintf(&fname, template, i,(int)getpid());
-               if ((fnums[i] = cli_open(cli, fname, 
+               if ((fnums[i] = cli_open(cli->tree, fname, 
                                        O_RDWR|O_CREAT|O_TRUNC, DENY_NONE)) ==
                    -1) {
                        printf("open of %s failed (%s)\n", 
-                              fname, cli_errstr(cli));
+                              fname, cli_errstr(cli->tree));
                        printf("maximum fnum is %d\n", i);
                        break;
                }
@@ -1905,12 +1867,12 @@ static BOOL run_maxfidtest(int dummy)
        printf("cleaning up\n");
        for (;i>=0;i--) {
                asprintf(&fname, template, i,(int)getpid());
-               if (!cli_close(cli, fnums[i])) {
-                       printf("Close of fnum %d failed - %s\n", fnums[i], cli_errstr(cli));
+               if (NT_STATUS_IS_ERR(cli_close(cli->tree, fnums[i]))) {
+                       printf("Close of fnum %d failed - %s\n", fnums[i], cli_errstr(cli->tree));
                }
-               if (!cli_unlink(cli, fname)) {
+               if (NT_STATUS_IS_ERR(cli_unlink(cli->tree, fname))) {
                        printf("unlink of %s failed (%s)\n", 
-                              fname, cli_errstr(cli));
+                              fname, cli_errstr(cli->tree));
                        correct = False;
                }
                free(fname);
@@ -1972,13 +1934,13 @@ static BOOL run_attrtest(int dummy)
                return False;
        }
 
-       cli_unlink(cli, fname);
-       fnum = cli_open(cli, fname, 
+       cli_unlink(cli->tree, fname);
+       fnum = cli_open(cli->tree, fname, 
                        O_RDWR | O_CREAT | O_TRUNC, DENY_NONE);
-       cli_close(cli, fnum);
+       cli_close(cli->tree, fnum);
 
-       if (!cli_getatr(cli, fname, NULL, NULL, &t)) {
-               printf("getatr failed (%s)\n", cli_errstr(cli));
+       if (NT_STATUS_IS_ERR(cli_getatr(cli->tree, fname, NULL, NULL, &t))) {
+               printf("getatr failed (%s)\n", cli_errstr(cli->tree));
                correct = False;
        }
 
@@ -1995,13 +1957,13 @@ static BOOL run_attrtest(int dummy)
 
        printf("Setting file time to %s", ctime(&t2));
 
-       if (!cli_setatr(cli, fname, 0, t2)) {
-               printf("setatr failed (%s)\n", cli_errstr(cli));
+       if (NT_STATUS_IS_ERR(cli_setatr(cli->tree, fname, 0, t2))) {
+               printf("setatr failed (%s)\n", cli_errstr(cli->tree));
                correct = True;
        }
 
-       if (!cli_getatr(cli, fname, NULL, NULL, &t)) {
-               printf("getatr failed (%s)\n", cli_errstr(cli));
+       if (NT_STATUS_IS_ERR(cli_getatr(cli->tree, fname, NULL, NULL, &t))) {
+               printf("getatr failed (%s)\n", cli_errstr(cli->tree));
                correct = True;
        }
 
@@ -2014,7 +1976,7 @@ static BOOL run_attrtest(int dummy)
                correct = True;
        }
 
-       cli_unlink(cli, fname);
+       cli_unlink(cli->tree, fname);
 
        if (!torture_close_connection(cli)) {
                correct = False;
@@ -2047,22 +2009,22 @@ static BOOL run_trans2test(int dummy)
                return False;
        }
 
-       cli_unlink(cli, fname);
+       cli_unlink(cli->tree, fname);
 
        printf("Testing qfileinfo\n");
        
-       fnum = cli_open(cli, fname, 
+       fnum = cli_open(cli->tree, fname, 
                        O_RDWR | O_CREAT | O_TRUNC, DENY_NONE);
-       if (!cli_qfileinfo(cli, fnum, NULL, &size, &c_time, &a_time, &m_time,
-                          NULL, NULL)) {
-               printf("ERROR: qfileinfo failed (%s)\n", cli_errstr(cli));
+       if (NT_STATUS_IS_ERR(cli_qfileinfo(cli->tree, fnum, NULL, &size, &c_time, &a_time, &m_time,
+                          NULL, NULL))) {
+               printf("ERROR: qfileinfo failed (%s)\n", cli_errstr(cli->tree));
                correct = False;
        }
 
        printf("Testing NAME_INFO\n");
 
-       if (!cli_qfilename(cli, fnum, &pname)) {
-               printf("ERROR: qfilename failed (%s)\n", cli_errstr(cli));
+       if (NT_STATUS_IS_ERR(cli_qfilename(cli->tree, fnum, &pname))) {
+               printf("ERROR: qfilename failed (%s)\n", cli_errstr(cli->tree));
                correct = False;
        }
 
@@ -2072,21 +2034,21 @@ static BOOL run_trans2test(int dummy)
                correct = False;
        }
 
-       cli_close(cli, fnum);
-       cli_unlink(cli, fname);
+       cli_close(cli->tree, fnum);
+       cli_unlink(cli->tree, fname);
 
-       fnum = cli_open(cli, fname, 
+       fnum = cli_open(cli->tree, fname, 
                        O_RDWR | O_CREAT | O_TRUNC, DENY_NONE);
        if (fnum == -1) {
-               printf("open of %s failed (%s)\n", fname, cli_errstr(cli));
+               printf("open of %s failed (%s)\n", fname, cli_errstr(cli->tree));
                return False;
        }
-       cli_close(cli, fnum);
+       cli_close(cli->tree, fnum);
 
        printf("Checking for sticky create times\n");
 
-       if (!cli_qpathinfo(cli, fname, &c_time, &a_time, &m_time, &size, NULL)) {
-               printf("ERROR: qpathinfo failed (%s)\n", cli_errstr(cli));
+       if (NT_STATUS_IS_ERR(cli_qpathinfo(cli->tree, fname, &c_time, &a_time, &m_time, &size, NULL))) {
+               printf("ERROR: qpathinfo failed (%s)\n", cli_errstr(cli->tree));
                correct = False;
        } else {
                if (c_time != m_time) {
@@ -2107,13 +2069,12 @@ static BOOL run_trans2test(int dummy)
        }
 
 
-       cli_unlink(cli, fname);
-       fnum = cli_open(cli, fname, 
+       cli_unlink(cli->tree, fname);
+       fnum = cli_open(cli->tree, fname, 
                        O_RDWR | O_CREAT | O_TRUNC, DENY_NONE);
-       cli_close(cli, fnum);
-       if (!cli_qpathinfo2(cli, fname, &c_time, &a_time, &m_time, 
-                           &w_time, &size, NULL, NULL)) {
-               printf("ERROR: qpathinfo2 failed (%s)\n", cli_errstr(cli));
+       cli_close(cli->tree, fnum);
+       if (NT_STATUS_IS_ERR(cli_qpathinfo2(cli->tree, fname, &c_time, &a_time, &m_time, &w_time, &size, NULL, NULL))) {
+               printf("ERROR: qpathinfo2 failed (%s)\n", cli_errstr(cli->tree));
                correct = False;
        } else {
                if (w_time < 60*60*24*2) {
@@ -2123,29 +2084,27 @@ static BOOL run_trans2test(int dummy)
                }
        }
 
-       cli_unlink(cli, fname);
+       cli_unlink(cli->tree, fname);
 
 
        /* check if the server updates the directory modification time
            when creating a new file */
-       if (!cli_mkdir(cli, dname)) {
-               printf("ERROR: mkdir failed (%s)\n", cli_errstr(cli));
+       if (NT_STATUS_IS_ERR(cli_mkdir(cli->tree, dname))) {
+               printf("ERROR: mkdir failed (%s)\n", cli_errstr(cli->tree));
                correct = False;
        }
        sleep(3);
-       if (!cli_qpathinfo2(cli, "\\trans2\\", &c_time, &a_time, &m_time, 
-                           &w_time, &size, NULL, NULL)) {
-               printf("ERROR: qpathinfo2 failed (%s)\n", cli_errstr(cli));
+       if (NT_STATUS_IS_ERR(cli_qpathinfo2(cli->tree, "\\trans2\\", &c_time, &a_time, &m_time, &w_time, &size, NULL, NULL))) {
+               printf("ERROR: qpathinfo2 failed (%s)\n", cli_errstr(cli->tree));
                correct = False;
        }
 
-       fnum = cli_open(cli, fname2, 
+       fnum = cli_open(cli->tree, fname2, 
                        O_RDWR | O_CREAT | O_TRUNC, DENY_NONE);
-       cli_write(cli, fnum,  0, (char *)&fnum, 0, sizeof(fnum));
-       cli_close(cli, fnum);
-       if (!cli_qpathinfo2(cli, "\\trans2\\", &c_time, &a_time, &m_time2, 
-                           &w_time, &size, NULL, NULL)) {
-               printf("ERROR: qpathinfo2 failed (%s)\n", cli_errstr(cli));
+       cli_write(cli->tree, fnum,  0, (char *)&fnum, 0, sizeof(fnum));
+       cli_close(cli->tree, fnum);
+       if (NT_STATUS_IS_ERR(cli_qpathinfo2(cli->tree, "\\trans2\\", &c_time, &a_time, &m_time2, &w_time, &size, NULL, NULL))) {
+               printf("ERROR: qpathinfo2 failed (%s)\n", cli_errstr(cli->tree));
                correct = False;
        } else {
                if (m_time2 == m_time) {
@@ -2153,8 +2112,8 @@ static BOOL run_trans2test(int dummy)
                        correct = False;
                }
        }
-       cli_unlink(cli, fname2);
-       cli_rmdir(cli, dname);
+       cli_unlink(cli->tree, fname2);
+       cli_rmdir(cli->tree, dname);
 
        if (!torture_close_connection(cli)) {
                correct = False;
@@ -2185,26 +2144,26 @@ static BOOL run_deletetest(int dummy)
        
        /* Test 1 - this should delete the file on close. */
        
-       cli_setatr(cli1, fname, 0, 0);
-       cli_unlink(cli1, fname);
+       cli_setatr(cli1->tree, fname, 0, 0);
+       cli_unlink(cli1->tree, fname);
        
-       fnum1 = cli_nt_create_full(cli1, fname, 0, GENERIC_RIGHTS_FILE_ALL_ACCESS, FILE_ATTRIBUTE_NORMAL,
+       fnum1 = cli_nt_create_full(cli1->tree, fname, 0, GENERIC_RIGHTS_FILE_ALL_ACCESS, FILE_ATTRIBUTE_NORMAL,
                                   NTCREATEX_SHARE_ACCESS_DELETE, NTCREATEX_DISP_OVERWRITE_IF, 
                                   NTCREATEX_OPTIONS_DELETE_ON_CLOSE, 0);
        
        if (fnum1 == -1) {
-               printf("[1] open of %s failed (%s)\n", fname, cli_errstr(cli1));
+               printf("[1] open of %s failed (%s)\n", fname, cli_errstr(cli1->tree));
                correct = False;
                goto fail;
        }
        
-       if (!cli_close(cli1, fnum1)) {
-               printf("[1] close failed (%s)\n", cli_errstr(cli1));
+       if (NT_STATUS_IS_ERR(cli_close(cli1->tree, fnum1))) {
+               printf("[1] close failed (%s)\n", cli_errstr(cli1->tree));
                correct = False;
                goto fail;
        }
 
-       fnum1 = cli_open(cli1, fname, O_RDWR, DENY_NONE);
+       fnum1 = cli_open(cli1->tree, fname, O_RDWR, DENY_NONE);
        if (fnum1 != -1) {
                printf("[1] open of %s succeeded (should fail)\n", fname);
                correct = False;
@@ -2215,52 +2174,52 @@ static BOOL run_deletetest(int dummy)
        
        /* Test 2 - this should delete the file on close. */
        
-       cli_setatr(cli1, fname, 0, 0);
-       cli_unlink(cli1, fname);
+       cli_setatr(cli1->tree, fname, 0, 0);
+       cli_unlink(cli1->tree, fname);
        
-       fnum1 = cli_nt_create_full(cli1, fname, 0, GENERIC_RIGHTS_FILE_ALL_ACCESS,
+       fnum1 = cli_nt_create_full(cli1->tree, fname, 0, GENERIC_RIGHTS_FILE_ALL_ACCESS,
                                   FILE_ATTRIBUTE_NORMAL, NTCREATEX_SHARE_ACCESS_NONE, 
                                   NTCREATEX_DISP_OVERWRITE_IF, 0, 0);
        
        if (fnum1 == -1) {
-               printf("[2] open of %s failed (%s)\n", fname, cli_errstr(cli1));
+               printf("[2] open of %s failed (%s)\n", fname, cli_errstr(cli1->tree));
                correct = False;
                goto fail;
        }
        
-       if (!cli_nt_delete_on_close(cli1, fnum1, True)) {
-               printf("[2] setting delete_on_close failed (%s)\n", cli_errstr(cli1));
+       if (NT_STATUS_IS_ERR(cli_nt_delete_on_close(cli1->tree, fnum1, True))) {
+               printf("[2] setting delete_on_close failed (%s)\n", cli_errstr(cli1->tree));
                correct = False;
                goto fail;
        }
        
-       if (!cli_close(cli1, fnum1)) {
-               printf("[2] close failed (%s)\n", cli_errstr(cli1));
+       if (NT_STATUS_IS_ERR(cli_close(cli1->tree, fnum1))) {
+               printf("[2] close failed (%s)\n", cli_errstr(cli1->tree));
                correct = False;
                goto fail;
        }
        
-       fnum1 = cli_open(cli1, fname, O_RDONLY, DENY_NONE);
+       fnum1 = cli_open(cli1->tree, fname, O_RDONLY, DENY_NONE);
        if (fnum1 != -1) {
                printf("[2] open of %s succeeded should have been deleted on close !\n", fname);
-               if (!cli_close(cli1, fnum1)) {
-                       printf("[2] close failed (%s)\n", cli_errstr(cli1));
+               if (NT_STATUS_IS_ERR(cli_close(cli1->tree, fnum1))) {
+                       printf("[2] close failed (%s)\n", cli_errstr(cli1->tree));
                        correct = False;
                        goto fail;
                }
-               cli_unlink(cli1, fname);
+               cli_unlink(cli1->tree, fname);
        } else
                printf("second delete on close test succeeded.\n");
        
        /* Test 3 - ... */
-       cli_setatr(cli1, fname, 0, 0);
-       cli_unlink(cli1, fname);
+       cli_setatr(cli1->tree, fname, 0, 0);
+       cli_unlink(cli1->tree, fname);
 
-       fnum1 = cli_nt_create_full(cli1, fname, 0, GENERIC_RIGHTS_FILE_ALL_ACCESS, FILE_ATTRIBUTE_NORMAL,
+       fnum1 = cli_nt_create_full(cli1->tree, fname, 0, GENERIC_RIGHTS_FILE_ALL_ACCESS, FILE_ATTRIBUTE_NORMAL,
                                   NTCREATEX_SHARE_ACCESS_READ|NTCREATEX_SHARE_ACCESS_WRITE, NTCREATEX_DISP_OVERWRITE_IF, 0, 0);
 
        if (fnum1 == -1) {
-               printf("[3] open - 1 of %s failed (%s)\n", fname, cli_errstr(cli1));
+               printf("[3] open - 1 of %s failed (%s)\n", fname, cli_errstr(cli1->tree));
                correct = False;
                goto fail;
        }
@@ -2268,7 +2227,7 @@ static BOOL run_deletetest(int dummy)
        /* This should fail with a sharing violation - open for delete is only compatible
           with SHARE_DELETE. */
 
-       fnum2 = cli_nt_create_full(cli1, fname, 0, GENERIC_RIGHTS_FILE_READ, FILE_ATTRIBUTE_NORMAL,
+       fnum2 = cli_nt_create_full(cli1->tree, fname, 0, GENERIC_RIGHTS_FILE_READ, FILE_ATTRIBUTE_NORMAL,
                                   NTCREATEX_SHARE_ACCESS_READ|NTCREATEX_SHARE_ACCESS_WRITE, 
                                   NTCREATEX_DISP_OPEN, 0, 0);
 
@@ -2280,52 +2239,52 @@ static BOOL run_deletetest(int dummy)
 
        /* This should succeed. */
 
-       fnum2 = cli_nt_create_full(cli1, fname, 0, GENERIC_RIGHTS_FILE_READ, FILE_ATTRIBUTE_NORMAL,
+       fnum2 = cli_nt_create_full(cli1->tree, fname, 0, GENERIC_RIGHTS_FILE_READ, FILE_ATTRIBUTE_NORMAL,
                        NTCREATEX_SHARE_ACCESS_READ|NTCREATEX_SHARE_ACCESS_WRITE|NTCREATEX_SHARE_ACCESS_DELETE, NTCREATEX_DISP_OPEN, 0, 0);
 
        if (fnum2 == -1) {
-               printf("[3] open  - 2 of %s failed (%s)\n", fname, cli_errstr(cli1));
+               printf("[3] open  - 2 of %s failed (%s)\n", fname, cli_errstr(cli1->tree));
                correct = False;
                goto fail;
        }
 
-       if (!cli_nt_delete_on_close(cli1, fnum1, True)) {
-               printf("[3] setting delete_on_close failed (%s)\n", cli_errstr(cli1));
+       if (NT_STATUS_IS_ERR(cli_nt_delete_on_close(cli1->tree, fnum1, True))) {
+               printf("[3] setting delete_on_close failed (%s)\n", cli_errstr(cli1->tree));
                correct = False;
                goto fail;
        }
        
-       if (!cli_close(cli1, fnum1)) {
-               printf("[3] close 1 failed (%s)\n", cli_errstr(cli1));
+       if (NT_STATUS_IS_ERR(cli_close(cli1->tree, fnum1))) {
+               printf("[3] close 1 failed (%s)\n", cli_errstr(cli1->tree));
                correct = False;
                goto fail;
        }
        
-       if (!cli_close(cli1, fnum2)) {
-               printf("[3] close 2 failed (%s)\n", cli_errstr(cli1));
+       if (NT_STATUS_IS_ERR(cli_close(cli1->tree, fnum2))) {
+               printf("[3] close 2 failed (%s)\n", cli_errstr(cli1->tree));
                correct = False;
                goto fail;
        }
        
        /* This should fail - file should no longer be there. */
 
-       fnum1 = cli_open(cli1, fname, O_RDONLY, DENY_NONE);
+       fnum1 = cli_open(cli1->tree, fname, O_RDONLY, DENY_NONE);
        if (fnum1 != -1) {
                printf("[3] open of %s succeeded should have been deleted on close !\n", fname);
-               if (!cli_close(cli1, fnum1)) {
-                       printf("[3] close failed (%s)\n", cli_errstr(cli1));
+               if (NT_STATUS_IS_ERR(cli_close(cli1->tree, fnum1))) {
+                       printf("[3] close failed (%s)\n", cli_errstr(cli1->tree));
                }
-               cli_unlink(cli1, fname);
+               cli_unlink(cli1->tree, fname);
                correct = False;
                goto fail;
        } else
                printf("third delete on close test succeeded.\n");
 
        /* Test 4 ... */
-       cli_setatr(cli1, fname, 0, 0);
-       cli_unlink(cli1, fname);
+       cli_setatr(cli1->tree, fname, 0, 0);
+       cli_unlink(cli1->tree, fname);
 
-       fnum1 = cli_nt_create_full(cli1, fname, 0, 
+       fnum1 = cli_nt_create_full(cli1->tree, fname, 0, 
                                   SA_RIGHT_FILE_READ_DATA  | 
                                   SA_RIGHT_FILE_WRITE_DATA |
                                   STD_RIGHT_DELETE_ACCESS,
@@ -2334,38 +2293,38 @@ static BOOL run_deletetest(int dummy)
                                   NTCREATEX_DISP_OVERWRITE_IF, 0, 0);
                                                                
        if (fnum1 == -1) {
-               printf("[4] open of %s failed (%s)\n", fname, cli_errstr(cli1));
+               printf("[4] open of %s failed (%s)\n", fname, cli_errstr(cli1->tree));
                correct = False;
                goto fail;
        }
 
        /* This should succeed. */
-       fnum2 = cli_nt_create_full(cli1, fname, 0, GENERIC_RIGHTS_FILE_READ,
+       fnum2 = cli_nt_create_full(cli1->tree, fname, 0, GENERIC_RIGHTS_FILE_READ,
                                   FILE_ATTRIBUTE_NORMAL, 
                                   NTCREATEX_SHARE_ACCESS_READ  | 
                                   NTCREATEX_SHARE_ACCESS_WRITE |
                                   NTCREATEX_SHARE_ACCESS_DELETE, 
                                   NTCREATEX_DISP_OPEN, 0, 0);
        if (fnum2 == -1) {
-               printf("[4] open  - 2 of %s failed (%s)\n", fname, cli_errstr(cli1));
+               printf("[4] open  - 2 of %s failed (%s)\n", fname, cli_errstr(cli1->tree));
                correct = False;
                goto fail;
        }
        
-       if (!cli_close(cli1, fnum2)) {
-               printf("[4] close - 1 failed (%s)\n", cli_errstr(cli1));
+       if (NT_STATUS_IS_ERR(cli_close(cli1->tree, fnum2))) {
+               printf("[4] close - 1 failed (%s)\n", cli_errstr(cli1->tree));
                correct = False;
                goto fail;
        }
        
-       if (!cli_nt_delete_on_close(cli1, fnum1, True)) {
-               printf("[4] setting delete_on_close failed (%s)\n", cli_errstr(cli1));
+       if (NT_STATUS_IS_ERR(cli_nt_delete_on_close(cli1->tree, fnum1, True))) {
+               printf("[4] setting delete_on_close failed (%s)\n", cli_errstr(cli1->tree));
                correct = False;
                goto fail;
        }
        
        /* This should fail - no more opens once delete on close set. */
-       fnum2 = cli_nt_create_full(cli1, fname, 0, GENERIC_RIGHTS_FILE_READ,
+       fnum2 = cli_nt_create_full(cli1->tree, fname, 0, GENERIC_RIGHTS_FILE_READ,
                                   FILE_ATTRIBUTE_NORMAL, NTCREATEX_SHARE_ACCESS_READ|NTCREATEX_SHARE_ACCESS_WRITE|NTCREATEX_SHARE_ACCESS_DELETE,
                                   NTCREATEX_DISP_OPEN, 0, 0);
        if (fnum2 != -1) {
@@ -2375,33 +2334,33 @@ static BOOL run_deletetest(int dummy)
        } else
                printf("fourth delete on close test succeeded.\n");
        
-       if (!cli_close(cli1, fnum1)) {
-               printf("[4] close - 2 failed (%s)\n", cli_errstr(cli1));
+       if (NT_STATUS_IS_ERR(cli_close(cli1->tree, fnum1))) {
+               printf("[4] close - 2 failed (%s)\n", cli_errstr(cli1->tree));
                correct = False;
                goto fail;
        }
        
        /* Test 5 ... */
-       cli_setatr(cli1, fname, 0, 0);
-       cli_unlink(cli1, fname);
+       cli_setatr(cli1->tree, fname, 0, 0);
+       cli_unlink(cli1->tree, fname);
        
-       fnum1 = cli_open(cli1, fname, O_RDWR|O_CREAT, DENY_NONE);
+       fnum1 = cli_open(cli1->tree, fname, O_RDWR|O_CREAT, DENY_NONE);
        if (fnum1 == -1) {
-               printf("[5] open of %s failed (%s)\n", fname, cli_errstr(cli1));
+               printf("[5] open of %s failed (%s)\n", fname, cli_errstr(cli1->tree));
                correct = False;
                goto fail;
        }
 
        /* This should fail - only allowed on NT opens with DELETE access. */
 
-       if (cli_nt_delete_on_close(cli1, fnum1, True)) {
+       if (NT_STATUS_IS_OK(cli_nt_delete_on_close(cli1->tree, fnum1, True))) {
                printf("[5] setting delete_on_close on OpenX file succeeded - should fail !\n");
                correct = False;
                goto fail;
        }
 
-       if (!cli_close(cli1, fnum1)) {
-               printf("[5] close - 2 failed (%s)\n", cli_errstr(cli1));
+       if (NT_STATUS_IS_ERR(cli_close(cli1->tree, fnum1))) {
+               printf("[5] close - 2 failed (%s)\n", cli_errstr(cli1->tree));
                correct = False;
                goto fail;
        }
@@ -2409,10 +2368,10 @@ static BOOL run_deletetest(int dummy)
        printf("fifth delete on close test succeeded.\n");
        
        /* Test 6 ... */
-       cli_setatr(cli1, fname, 0, 0);
-       cli_unlink(cli1, fname);
+       cli_setatr(cli1->tree, fname, 0, 0);
+       cli_unlink(cli1->tree, fname);
        
-       fnum1 = cli_nt_create_full(cli1, fname, 0, 
+       fnum1 = cli_nt_create_full(cli1->tree, fname, 0, 
                                   SA_RIGHT_FILE_READ_DATA | SA_RIGHT_FILE_WRITE_DATA,
                                   FILE_ATTRIBUTE_NORMAL, 
                                   NTCREATEX_SHARE_ACCESS_READ  |
@@ -2421,21 +2380,21 @@ static BOOL run_deletetest(int dummy)
                                   NTCREATEX_DISP_OVERWRITE_IF, 0, 0);
        
        if (fnum1 == -1) {
-               printf("[6] open of %s failed (%s)\n", fname, cli_errstr(cli1));
+               printf("[6] open of %s failed (%s)\n", fname, cli_errstr(cli1->tree));
                correct = False;
                goto fail;
        }
        
        /* This should fail - only allowed on NT opens with DELETE access. */
        
-       if (cli_nt_delete_on_close(cli1, fnum1, True)) {
+       if (NT_STATUS_IS_OK(cli_nt_delete_on_close(cli1->tree, fnum1, True))) {
                printf("[6] setting delete_on_close on file with no delete access succeeded - should fail !\n");
                correct = False;
                goto fail;
        }
 
-       if (!cli_close(cli1, fnum1)) {
-               printf("[6] close - 2 failed (%s)\n", cli_errstr(cli1));
+       if (NT_STATUS_IS_ERR(cli_close(cli1->tree, fnum1))) {
+               printf("[6] close - 2 failed (%s)\n", cli_errstr(cli1->tree));
                correct = False;
                goto fail;
        }
@@ -2443,50 +2402,50 @@ static BOOL run_deletetest(int dummy)
        printf("sixth delete on close test succeeded.\n");
        
        /* Test 7 ... */
-       cli_setatr(cli1, fname, 0, 0);
-       cli_unlink(cli1, fname);
+       cli_setatr(cli1->tree, fname, 0, 0);
+       cli_unlink(cli1->tree, fname);
        
-       fnum1 = cli_nt_create_full(cli1, fname, 0, 
+       fnum1 = cli_nt_create_full(cli1->tree, fname, 0, 
                                   SA_RIGHT_FILE_READ_DATA  | 
                                   SA_RIGHT_FILE_WRITE_DATA |
                                   STD_RIGHT_DELETE_ACCESS,
                                   FILE_ATTRIBUTE_NORMAL, 0, NTCREATEX_DISP_OVERWRITE_IF, 0, 0);
                                                                
        if (fnum1 == -1) {
-               printf("[7] open of %s failed (%s)\n", fname, cli_errstr(cli1));
+               printf("[7] open of %s failed (%s)\n", fname, cli_errstr(cli1->tree));
                correct = False;
                goto fail;
        }
 
-       if (!cli_nt_delete_on_close(cli1, fnum1, True)) {
+       if (NT_STATUS_IS_ERR(cli_nt_delete_on_close(cli1->tree, fnum1, True))) {
                printf("[7] setting delete_on_close on file failed !\n");
                correct = False;
                goto fail;
        }
        
-       if (!cli_nt_delete_on_close(cli1, fnum1, False)) {
+       if (NT_STATUS_IS_ERR(cli_nt_delete_on_close(cli1->tree, fnum1, False))) {
                printf("[7] unsetting delete_on_close on file failed !\n");
                correct = False;
                goto fail;
        }
 
-       if (!cli_close(cli1, fnum1)) {
-               printf("[7] close - 2 failed (%s)\n", cli_errstr(cli1));
+       if (NT_STATUS_IS_ERR(cli_close(cli1->tree, fnum1))) {
+               printf("[7] close - 2 failed (%s)\n", cli_errstr(cli1->tree));
                correct = False;
                goto fail;
        }
        
        /* This next open should succeed - we reset the flag. */
        
-       fnum1 = cli_open(cli1, fname, O_RDONLY, DENY_NONE);
+       fnum1 = cli_open(cli1->tree, fname, O_RDONLY, DENY_NONE);
        if (fnum1 == -1) {
-               printf("[5] open of %s failed (%s)\n", fname, cli_errstr(cli1));
+               printf("[5] open of %s failed (%s)\n", fname, cli_errstr(cli1->tree));
                correct = False;
                goto fail;
        }
 
-       if (!cli_close(cli1, fnum1)) {
-               printf("[7] close - 2 failed (%s)\n", cli_errstr(cli1));
+       if (NT_STATUS_IS_ERR(cli_close(cli1->tree, fnum1))) {
+               printf("[7] close - 2 failed (%s)\n", cli_errstr(cli1->tree));
                correct = False;
                goto fail;
        }
@@ -2494,8 +2453,8 @@ static BOOL run_deletetest(int dummy)
        printf("seventh delete on close test succeeded.\n");
        
        /* Test 7 ... */
-       cli_setatr(cli1, fname, 0, 0);
-       cli_unlink(cli1, fname);
+       cli_setatr(cli1->tree, fname, 0, 0);
+       cli_unlink(cli1->tree, fname);
        
        if (!torture_open_connection(&cli2)) {
                printf("[8] failed to open second connection.\n");
@@ -2503,46 +2462,46 @@ static BOOL run_deletetest(int dummy)
                goto fail;
        }
 
-       fnum1 = cli_nt_create_full(cli1, fname, 0, SA_RIGHT_FILE_READ_DATA|SA_RIGHT_FILE_WRITE_DATA|STD_RIGHT_DELETE_ACCESS,
+       fnum1 = cli_nt_create_full(cli1->tree, fname, 0, SA_RIGHT_FILE_READ_DATA|SA_RIGHT_FILE_WRITE_DATA|STD_RIGHT_DELETE_ACCESS,
                                   FILE_ATTRIBUTE_NORMAL, NTCREATEX_SHARE_ACCESS_READ|NTCREATEX_SHARE_ACCESS_WRITE|NTCREATEX_SHARE_ACCESS_DELETE,
                                   NTCREATEX_DISP_OVERWRITE_IF, 0, 0);
        
        if (fnum1 == -1) {
-               printf("[8] open of %s failed (%s)\n", fname, cli_errstr(cli1));
+               printf("[8] open of %s failed (%s)\n", fname, cli_errstr(cli1->tree));
                correct = False;
                goto fail;
        }
 
-       fnum2 = cli_nt_create_full(cli2, fname, 0, SA_RIGHT_FILE_READ_DATA|SA_RIGHT_FILE_WRITE_DATA|STD_RIGHT_DELETE_ACCESS,
+       fnum2 = cli_nt_create_full(cli2->tree, fname, 0, SA_RIGHT_FILE_READ_DATA|SA_RIGHT_FILE_WRITE_DATA|STD_RIGHT_DELETE_ACCESS,
                                   FILE_ATTRIBUTE_NORMAL, NTCREATEX_SHARE_ACCESS_READ|NTCREATEX_SHARE_ACCESS_WRITE|NTCREATEX_SHARE_ACCESS_DELETE,
                                   NTCREATEX_DISP_OPEN, 0, 0);
        
        if (fnum2 == -1) {
-               printf("[8] open of %s failed (%s)\n", fname, cli_errstr(cli1));
+               printf("[8] open of %s failed (%s)\n", fname, cli_errstr(cli1->tree));
                correct = False;
                goto fail;
        }
 
-       if (!cli_nt_delete_on_close(cli1, fnum1, True)) {
+       if (NT_STATUS_IS_ERR(cli_nt_delete_on_close(cli1->tree, fnum1, True))) {
                printf("[8] setting delete_on_close on file failed !\n");
                correct = False;
                goto fail;
        }
        
-       if (!cli_close(cli1, fnum1)) {
-               printf("[8] close - 1 failed (%s)\n", cli_errstr(cli1));
+       if (NT_STATUS_IS_ERR(cli_close(cli1->tree, fnum1))) {
+               printf("[8] close - 1 failed (%s)\n", cli_errstr(cli1->tree));
                correct = False;
                goto fail;
        }
 
-       if (!cli_close(cli2, fnum2)) {
-               printf("[8] close - 2 failed (%s)\n", cli_errstr(cli2));
+       if (NT_STATUS_IS_ERR(cli_close(cli2->tree, fnum2))) {
+               printf("[8] close - 2 failed (%s)\n", cli_errstr(cli2->tree));
                correct = False;
                goto fail;
        }
 
        /* This should fail.. */
-       fnum1 = cli_open(cli1, fname, O_RDONLY, DENY_NONE);
+       fnum1 = cli_open(cli1->tree, fname, O_RDONLY, DENY_NONE);
        if (fnum1 != -1) {
                printf("[8] open of %s succeeded should have been deleted on close !\n", fname);
                goto fail;
@@ -2551,7 +2510,7 @@ static BOOL run_deletetest(int dummy)
                printf("eighth delete on close test succeeded.\n");
 
        /* This should fail - we need to set DELETE_ACCESS. */
-       fnum1 = cli_nt_create_full(cli1, fname, 0,SA_RIGHT_FILE_READ_DATA|SA_RIGHT_FILE_WRITE_DATA,
+       fnum1 = cli_nt_create_full(cli1->tree, fname, 0,SA_RIGHT_FILE_READ_DATA|SA_RIGHT_FILE_WRITE_DATA,
                                   FILE_ATTRIBUTE_NORMAL, NTCREATEX_SHARE_ACCESS_NONE, NTCREATEX_DISP_OVERWRITE_IF, NTCREATEX_OPTIONS_DELETE_ON_CLOSE, 0);
        
        if (fnum1 != -1) {
@@ -2562,23 +2521,23 @@ static BOOL run_deletetest(int dummy)
 
        printf("ninth delete on close test succeeded.\n");
 
-       fnum1 = cli_nt_create_full(cli1, fname, 0, SA_RIGHT_FILE_READ_DATA|SA_RIGHT_FILE_WRITE_DATA|STD_RIGHT_DELETE_ACCESS,
+       fnum1 = cli_nt_create_full(cli1->tree, fname, 0, SA_RIGHT_FILE_READ_DATA|SA_RIGHT_FILE_WRITE_DATA|STD_RIGHT_DELETE_ACCESS,
                                   FILE_ATTRIBUTE_NORMAL, NTCREATEX_SHARE_ACCESS_NONE, NTCREATEX_DISP_OVERWRITE_IF, NTCREATEX_OPTIONS_DELETE_ON_CLOSE, 0);
        if (fnum1 == -1) {
-               printf("[10] open of %s failed (%s)\n", fname, cli_errstr(cli1));
+               printf("[10] open of %s failed (%s)\n", fname, cli_errstr(cli1->tree));
                correct = False;
                goto fail;
        }
 
        /* This should delete the file. */
-       if (!cli_close(cli1, fnum1)) {
-               printf("[10] close failed (%s)\n", cli_errstr(cli1));
+       if (NT_STATUS_IS_ERR(cli_close(cli1->tree, fnum1))) {
+               printf("[10] close failed (%s)\n", cli_errstr(cli1->tree));
                correct = False;
                goto fail;
        }
 
        /* This should fail.. */
-       fnum1 = cli_open(cli1, fname, O_RDONLY, DENY_NONE);
+       fnum1 = cli_open(cli1->tree, fname, O_RDONLY, DENY_NONE);
        if (fnum1 != -1) {
                printf("[10] open of %s succeeded should have been deleted on close !\n", fname);
                goto fail;
@@ -2592,10 +2551,10 @@ static BOOL run_deletetest(int dummy)
         * intialized, because these functions don't handle
         * uninitialized connections. */
                
-       cli_close(cli1, fnum1);
-       cli_close(cli1, fnum2);
-       cli_setatr(cli1, fname, 0, 0);
-       cli_unlink(cli1, fname);
+       cli_close(cli1->tree, fnum1);
+       cli_close(cli1->tree, fnum2);
+       cli_setatr(cli1->tree, fname, 0, 0);
+       cli_unlink(cli1->tree, fname);
 
        if (!torture_close_connection(cli1)) {
                correct = False;
@@ -2669,22 +2628,22 @@ static BOOL run_xcopy(int dummy)
                return False;
        }
        
-       fnum1 = cli_nt_create_full(cli1, fname, 0,
+       fnum1 = cli_nt_create_full(cli1->tree, fname, 0,
                                   FIRST_DESIRED_ACCESS, FILE_ATTRIBUTE_ARCHIVE,
                                   NTCREATEX_SHARE_ACCESS_NONE, NTCREATEX_DISP_OVERWRITE_IF, 
                                   0x4044, 0);
 
        if (fnum1 == -1) {
-               printf("First open failed - %s\n", cli_errstr(cli1));
+               printf("First open failed - %s\n", cli_errstr(cli1->tree));
                return False;
        }
 
-       fnum2 = cli_nt_create_full(cli1, fname, 0,
+       fnum2 = cli_nt_create_full(cli1->tree, fname, 0,
                                   SECOND_DESIRED_ACCESS, 0,
                                   NTCREATEX_SHARE_ACCESS_READ|NTCREATEX_SHARE_ACCESS_WRITE|NTCREATEX_SHARE_ACCESS_DELETE, NTCREATEX_DISP_OPEN, 
                                   0x200000, 0);
        if (fnum2 == -1) {
-               printf("second open failed - %s\n", cli_errstr(cli1));
+               printf("second open failed - %s\n", cli_errstr(cli1->tree));
                return False;
        }
        
@@ -2712,31 +2671,31 @@ static BOOL run_rename(int dummy)
                return False;
        }
        
-       cli_unlink(cli1, fname);
-       cli_unlink(cli1, fname1);
-       fnum1 = cli_nt_create_full(cli1, fname, 0, GENERIC_RIGHTS_FILE_READ, FILE_ATTRIBUTE_NORMAL,
+       cli_unlink(cli1->tree, fname);
+       cli_unlink(cli1->tree, fname1);
+       fnum1 = cli_nt_create_full(cli1->tree, fname, 0, GENERIC_RIGHTS_FILE_READ, FILE_ATTRIBUTE_NORMAL,
                                   NTCREATEX_SHARE_ACCESS_READ, NTCREATEX_DISP_OVERWRITE_IF, 0, 0);
 
        if (fnum1 == -1) {
-               printf("First open failed - %s\n", cli_errstr(cli1));
+               printf("First open failed - %s\n", cli_errstr(cli1->tree));
                return False;
        }
 
-       if (!cli_rename(cli1, fname, fname1)) {
-               printf("First rename failed (this is correct) - %s\n", cli_errstr(cli1));
+       if (NT_STATUS_IS_ERR(cli_rename(cli1->tree, fname, fname1))) {
+               printf("First rename failed (this is correct) - %s\n", cli_errstr(cli1->tree));
        } else {
                printf("First rename succeeded - this should have failed !\n");
                correct = False;
        }
 
-       if (!cli_close(cli1, fnum1)) {
-               printf("close - 1 failed (%s)\n", cli_errstr(cli1));
+       if (NT_STATUS_IS_ERR(cli_close(cli1->tree, fnum1))) {
+               printf("close - 1 failed (%s)\n", cli_errstr(cli1->tree));
                return False;
        }
 
-       cli_unlink(cli1, fname);
-       cli_unlink(cli1, fname1);
-       fnum1 = cli_nt_create_full(cli1, fname, 0, GENERIC_RIGHTS_FILE_READ, FILE_ATTRIBUTE_NORMAL,
+       cli_unlink(cli1->tree, fname);
+       cli_unlink(cli1->tree, fname1);
+       fnum1 = cli_nt_create_full(cli1->tree, fname, 0, GENERIC_RIGHTS_FILE_READ, FILE_ATTRIBUTE_NORMAL,
 #if 0
                                   NTCREATEX_SHARE_ACCESS_DELETE|NTCREATEX_SHARE_ACCESS_NONE, NTCREATEX_DISP_OVERWRITE_IF, 0, 0);
 #else
@@ -2744,30 +2703,30 @@ static BOOL run_rename(int dummy)
 #endif
 
        if (fnum1 == -1) {
-               printf("Second open failed - %s\n", cli_errstr(cli1));
+               printf("Second open failed - %s\n", cli_errstr(cli1->tree));
                return False;
        }
 
-       if (!cli_rename(cli1, fname, fname1)) {
-               printf("Second rename failed - this should have succeeded - %s\n", cli_errstr(cli1));
+       if (NT_STATUS_IS_ERR(cli_rename(cli1->tree, fname, fname1))) {
+               printf("Second rename failed - this should have succeeded - %s\n", cli_errstr(cli1->tree));
                correct = False;
        } else {
                printf("Second rename succeeded\n");
        }
 
-       if (!cli_close(cli1, fnum1)) {
-               printf("close - 2 failed (%s)\n", cli_errstr(cli1));
+       if (NT_STATUS_IS_ERR(cli_close(cli1->tree, fnum1))) {
+               printf("close - 2 failed (%s)\n", cli_errstr(cli1->tree));
                return False;
        }
 
-       cli_unlink(cli1, fname);
-       cli_unlink(cli1, fname1);
+       cli_unlink(cli1->tree, fname);
+       cli_unlink(cli1->tree, fname1);
 
-       fnum1 = cli_nt_create_full(cli1, fname, 0, STD_RIGHT_READ_CONTROL_ACCESS, FILE_ATTRIBUTE_NORMAL,
+       fnum1 = cli_nt_create_full(cli1->tree, fname, 0, STD_RIGHT_READ_CONTROL_ACCESS, FILE_ATTRIBUTE_NORMAL,
                                   NTCREATEX_SHARE_ACCESS_NONE, NTCREATEX_DISP_OVERWRITE_IF, 0, 0);
 
        if (fnum1 == -1) {
-               printf("Third open failed - %s\n", cli_errstr(cli1));
+               printf("Third open failed - %s\n", cli_errstr(cli1->tree));
                return False;
        }
 
@@ -2776,39 +2735,39 @@ static BOOL run_rename(int dummy)
   {
   int fnum2;
 
-       fnum2 = cli_nt_create_full(cli1, fname, 0, DELETE_ACCESS, FILE_ATTRIBUTE_NORMAL,
+       fnum2 = cli_nt_create_full(cli1->tree, fname, 0, DELETE_ACCESS, FILE_ATTRIBUTE_NORMAL,
                                   NTCREATEX_SHARE_ACCESS_NONE, NTCREATEX_DISP_OVERWRITE_IF, 0, 0);
 
        if (fnum2 == -1) {
-               printf("Fourth open failed - %s\n", cli_errstr(cli1));
+               printf("Fourth open failed - %s\n", cli_errstr(cli1->tree));
                return False;
        }
-       if (!cli_nt_delete_on_close(cli1, fnum2, True)) {
+       if (!cli_nt_delete_on_close(cli1->tree, fnum2, True)) {
                printf("[8] setting delete_on_close on file failed !\n");
                return False;
        }
        
-       if (!cli_close(cli1, fnum2)) {
-               printf("close - 4 failed (%s)\n", cli_errstr(cli1));
+       if (!cli_close(cli1->tree, fnum2)) {
+               printf("close - 4 failed (%s)\n", cli_errstr(cli1->tree));
                return False;
        }
   }
 #endif
 
-       if (!cli_rename(cli1, fname, fname1)) {
-               printf("Third rename failed - this should have succeeded - %s\n", cli_errstr(cli1));
+       if (NT_STATUS_IS_ERR(cli_rename(cli1->tree, fname, fname1))) {
+               printf("Third rename failed - this should have succeeded - %s\n", cli_errstr(cli1->tree));
                correct = False;
        } else {
                printf("Third rename succeeded\n");
        }
 
-       if (!cli_close(cli1, fnum1)) {
-               printf("close - 3 failed (%s)\n", cli_errstr(cli1));
+       if (NT_STATUS_IS_ERR(cli_close(cli1->tree, fnum1))) {
+               printf("close - 3 failed (%s)\n", cli_errstr(cli1->tree));
                return False;
        }
 
-       cli_unlink(cli1, fname);
-       cli_unlink(cli1, fname1);
+       cli_unlink(cli1->tree, fname);
+       cli_unlink(cli1->tree, fname1);
 
        if (!torture_close_connection(cli1)) {
                correct = False;
@@ -2830,11 +2789,11 @@ static BOOL run_pipe_number(int dummy)
        }
 
        while(1) {
-               fnum = cli_nt_create_full(cli1, pipe_name, 0, SA_RIGHT_FILE_READ_DATA, FILE_ATTRIBUTE_NORMAL,
+               fnum = cli_nt_create_full(cli1->tree, pipe_name, 0, SA_RIGHT_FILE_READ_DATA, FILE_ATTRIBUTE_NORMAL,
                                   NTCREATEX_SHARE_ACCESS_READ|NTCREATEX_SHARE_ACCESS_WRITE, NTCREATEX_DISP_OPEN_IF, 0, 0);
 
                if (fnum == -1) {
-                       printf("Open of pipe %s failed with error (%s)\n", pipe_name, cli_errstr(cli1));
+                       printf("Open of pipe %s failed with error (%s)\n", pipe_name, cli_errstr(cli1->tree));
                        break;
                }
                num_pipes++;
@@ -2846,6 +2805,126 @@ static BOOL run_pipe_number(int dummy)
 }
 
 
+
+
+/*
+  open N connections to the server and just hold them open
+  used for testing performance when there are N idle users
+  already connected
+ */
+ static BOOL torture_holdcon(int dummy)
+{
+       int i;
+       struct cli_state **cli;
+       int num_dead = 0;
+
+       printf("Opening %d connections\n", torture_numops);
+       
+       cli = malloc(sizeof(struct cli_state *) * torture_numops);
+
+       for (i=0;i<torture_numops;i++) {
+               if (!torture_open_connection(&cli[i])) {
+                       return False;
+               }
+               printf("opened %d connections\r", i);
+               fflush(stdout);
+       }
+
+       printf("\nStarting pings\n");
+
+       while (1) {
+               for (i=0;i<torture_numops;i++) {
+                       NTSTATUS status;
+                       if (cli[i]) {
+                               status = cli_chkpath(cli[i]->tree, "\\");
+                               if (!NT_STATUS_IS_OK(status)) {
+                                       printf("Connection %d is dead\n", i);
+                                       cli[i] = NULL;
+                                       num_dead++;
+                               }
+                               usleep(100);
+                       }
+               }
+
+               if (num_dead == torture_numops) {
+                       printf("All connections dead - finishing\n");
+                       break;
+               }
+
+               printf(".");
+               fflush(stdout);
+       }
+
+       return True;
+}
+
+/*
+  Try with a wrong vuid and check error message.
+ */
+
+static BOOL run_vuidtest(int dummy)
+{
+       struct cli_state *cli;
+       const char *fname = "\\vuid.tst";
+       int fnum;
+       size_t size;
+       time_t c_time, a_time, m_time;
+       BOOL correct = True;
+
+       uint16_t orig_vuid;
+       NTSTATUS result;
+
+       printf("starting vuid test\n");
+
+       if (!torture_open_connection(&cli)) {
+               return False;
+       }
+
+       cli_unlink(cli->tree, fname);
+
+       fnum = cli_open(cli->tree, fname, 
+                       O_RDWR | O_CREAT | O_TRUNC, DENY_NONE);
+
+       orig_vuid = cli->session->vuid;
+
+       cli->session->vuid += 1234;
+
+       printf("Testing qfileinfo with wrong vuid\n");
+       
+       if (NT_STATUS_IS_OK(result = cli_qfileinfo(cli->tree, fnum, NULL,
+                                                  &size, &c_time, &a_time,
+                                                  &m_time, NULL, NULL))) {
+               printf("ERROR: qfileinfo passed with wrong vuid\n");
+               correct = False;
+       }
+
+       if ( (cli->transport->error.etype != ETYPE_DOS) ||
+            (cli->transport->error.e.dos.eclass != ERRSRV) ||
+            (cli->transport->error.e.dos.ecode != ERRbaduid) ) {
+               printf("ERROR: qfileinfo should have returned DOS error "
+                      "ERRSRV:ERRbaduid\n  but returned %s\n",
+                      cli_errstr(cli->tree));
+               correct = False;
+       }
+
+       cli->session->vuid -= 1234;
+
+       if (NT_STATUS_IS_ERR(cli_close(cli->tree, fnum))) {
+               printf("close failed (%s)\n", cli_errstr(cli->tree));
+               correct = False;
+       }
+
+       cli_unlink(cli->tree, fname);
+
+       if (!torture_close_connection(cli)) {
+               correct = False;
+       }
+
+       printf("vuid test finished\n");
+
+       return correct;
+}
+
 /*
   Test open mode returns on read-only files.
  */
@@ -2867,35 +2946,35 @@ static BOOL run_pipe_number(int dummy)
                return False;
        }
        
-       cli_setatr(cli1, fname, 0, 0);
-       cli_unlink(cli1, fname);
+       cli_setatr(cli1->tree, fname, 0, 0);
+       cli_unlink(cli1->tree, fname);
        
-       fnum1 = cli_open(cli1, fname, O_RDWR|O_CREAT|O_EXCL, DENY_NONE);
+       fnum1 = cli_open(cli1->tree, fname, O_RDWR|O_CREAT|O_EXCL, DENY_NONE);
        if (fnum1 == -1) {
-               printf("open of %s failed (%s)\n", fname, cli_errstr(cli1));
+               printf("open of %s failed (%s)\n", fname, cli_errstr(cli1->tree));
                return False;
        }
 
-       if (!cli_close(cli1, fnum1)) {
-               printf("close2 failed (%s)\n", cli_errstr(cli1));
+       if (NT_STATUS_IS_ERR(cli_close(cli1->tree, fnum1))) {
+               printf("close2 failed (%s)\n", cli_errstr(cli1->tree));
                return False;
        }
        
-       if (!cli_setatr(cli1, fname, FILE_ATTRIBUTE_READONLY, 0)) {
-               printf("cli_setatr failed (%s)\n", cli_errstr(cli1));
+       if (NT_STATUS_IS_ERR(cli_setatr(cli1->tree, fname, FILE_ATTRIBUTE_READONLY, 0))) {
+               printf("cli_setatr failed (%s)\n", cli_errstr(cli1->tree));
                CHECK_MAX_FAILURES(error_test1);
                return False;
        }
        
-       fnum1 = cli_open(cli1, fname, O_RDONLY, DENY_WRITE);
+       fnum1 = cli_open(cli1->tree, fname, O_RDONLY, DENY_WRITE);
        if (fnum1 == -1) {
-               printf("open of %s failed (%s)\n", fname, cli_errstr(cli1));
+               printf("open of %s failed (%s)\n", fname, cli_errstr(cli1->tree));
                CHECK_MAX_FAILURES(error_test1);
                return False;
        }
        
        /* This will fail - but the error should be ERRnoaccess, not ERRbadshare. */
-       fnum2 = cli_open(cli1, fname, O_RDWR, DENY_ALL);
+       fnum2 = cli_open(cli1->tree, fname, O_RDWR, DENY_ALL);
        
         if (check_error(__LINE__, cli1, ERRDOS, ERRnoaccess, 
                        NT_STATUS_ACCESS_DENIED)) {
@@ -2904,40 +2983,40 @@ static BOOL run_pipe_number(int dummy)
        
        printf("finished open test 1\n");
 error_test1:
-       cli_close(cli1, fnum1);
+       cli_close(cli1->tree, fnum1);
        
        /* Now try not readonly and ensure ERRbadshare is returned. */
        
-       cli_setatr(cli1, fname, 0, 0);
+       cli_setatr(cli1->tree, fname, 0, 0);
        
-       fnum1 = cli_open(cli1, fname, O_RDONLY, DENY_WRITE);
+       fnum1 = cli_open(cli1->tree, fname, O_RDONLY, DENY_WRITE);
        if (fnum1 == -1) {
-               printf("open of %s failed (%s)\n", fname, cli_errstr(cli1));
+               printf("open of %s failed (%s)\n", fname, cli_errstr(cli1->tree));
                return False;
        }
        
        /* This will fail - but the error should be ERRshare. */
-       fnum2 = cli_open(cli1, fname, O_RDWR, DENY_ALL);
+       fnum2 = cli_open(cli1->tree, fname, O_RDWR, DENY_ALL);
        
        if (check_error(__LINE__, cli1, ERRDOS, ERRbadshare, 
                        NT_STATUS_SHARING_VIOLATION)) {
                printf("correct error code ERRDOS/ERRbadshare returned\n");
        }
        
-       if (!cli_close(cli1, fnum1)) {
-               printf("close2 failed (%s)\n", cli_errstr(cli1));
+       if (NT_STATUS_IS_ERR(cli_close(cli1->tree, fnum1))) {
+               printf("close2 failed (%s)\n", cli_errstr(cli1->tree));
                return False;
        }
        
-       cli_unlink(cli1, fname);
+       cli_unlink(cli1->tree, fname);
        
        printf("finished open test 2\n");
        
        /* Test truncate open disposition on file opened for read. */
        
-       fnum1 = cli_open(cli1, fname, O_RDWR|O_CREAT|O_EXCL, DENY_NONE);
+       fnum1 = cli_open(cli1->tree, fname, O_RDWR|O_CREAT|O_EXCL, DENY_NONE);
        if (fnum1 == -1) {
-               printf("(3) open (1) of %s failed (%s)\n", fname, cli_errstr(cli1));
+               printf("(3) open (1) of %s failed (%s)\n", fname, cli_errstr(cli1->tree));
                return False;
        }
        
@@ -2945,19 +3024,19 @@ error_test1:
        
        memset(buf, '\0', 20);
 
-       if (cli_write(cli1, fnum1, 0, buf, 0, 20) != 20) {
-               printf("write failed (%s)\n", cli_errstr(cli1));
+       if (cli_write(cli1->tree, fnum1, 0, buf, 0, 20) != 20) {
+               printf("write failed (%s)\n", cli_errstr(cli1->tree));
                correct = False;
        }
 
-       if (!cli_close(cli1, fnum1)) {
-               printf("(3) close1 failed (%s)\n", cli_errstr(cli1));
+       if (NT_STATUS_IS_ERR(cli_close(cli1->tree, fnum1))) {
+               printf("(3) close1 failed (%s)\n", cli_errstr(cli1->tree));
                return False;
        }
        
        /* Ensure size == 20. */
-       if (!cli_getatr(cli1, fname, NULL, &fsize, NULL)) {
-               printf("(3) getatr failed (%s)\n", cli_errstr(cli1));
+       if (NT_STATUS_IS_ERR(cli_getatr(cli1->tree, fname, NULL, &fsize, NULL))) {
+               printf("(3) getatr failed (%s)\n", cli_errstr(cli1->tree));
                CHECK_MAX_FAILURES(error_test3);
                return False;
        }
@@ -2970,21 +3049,21 @@ error_test1:
 
        /* Now test if we can truncate a file opened for readonly. */
        
-       fnum1 = cli_open(cli1, fname, O_RDONLY|O_TRUNC, DENY_NONE);
+       fnum1 = cli_open(cli1->tree, fname, O_RDONLY|O_TRUNC, DENY_NONE);
        if (fnum1 == -1) {
-               printf("(3) open (2) of %s failed (%s)\n", fname, cli_errstr(cli1));
+               printf("(3) open (2) of %s failed (%s)\n", fname, cli_errstr(cli1->tree));
                CHECK_MAX_FAILURES(error_test3);
                return False;
        }
        
-       if (!cli_close(cli1, fnum1)) {
-               printf("close2 failed (%s)\n", cli_errstr(cli1));
+       if (NT_STATUS_IS_ERR(cli_close(cli1->tree, fnum1))) {
+               printf("close2 failed (%s)\n", cli_errstr(cli1->tree));
                return False;
        }
 
        /* Ensure size == 0. */
-       if (!cli_getatr(cli1, fname, NULL, &fsize, NULL)) {
-               printf("(3) getatr failed (%s)\n", cli_errstr(cli1));
+       if (NT_STATUS_IS_ERR(cli_getatr(cli1->tree, fname, NULL, &fsize, NULL))) {
+               printf("(3) getatr failed (%s)\n", cli_errstr(cli1->tree));
                CHECK_MAX_FAILURES(error_test3);
                return False;
        }
@@ -2996,22 +3075,22 @@ error_test1:
        }
        printf("finished open test 3\n");
 error_test3:   
-       cli_unlink(cli1, fname);
+       cli_unlink(cli1->tree, fname);
 
 
        printf("testing ctemp\n");
-       fnum1 = cli_ctemp(cli1, "\\", &tmp_path);
+       fnum1 = cli_ctemp(cli1->tree, "\\", &tmp_path);
        if (fnum1 == -1) {
-               printf("ctemp failed (%s)\n", cli_errstr(cli1));
+               printf("ctemp failed (%s)\n", cli_errstr(cli1->tree));
                CHECK_MAX_FAILURES(error_test4);
                return False;
        }
        printf("ctemp gave path %s\n", tmp_path);
-       if (!cli_close(cli1, fnum1)) {
-               printf("close of temp failed (%s)\n", cli_errstr(cli1));
+       if (NT_STATUS_IS_ERR(cli_close(cli1->tree, fnum1))) {
+               printf("close of temp failed (%s)\n", cli_errstr(cli1->tree));
        }
-       if (!cli_unlink(cli1, tmp_path)) {
-               printf("unlink of temp failed (%s)\n", cli_errstr(cli1));
+       if (NT_STATUS_IS_ERR(cli_unlink(cli1->tree, tmp_path))) {
+               printf("unlink of temp failed (%s)\n", cli_errstr(cli1->tree));
        }
 error_test4:   
        /* Test the non-io opens... */
@@ -3020,165 +3099,165 @@ error_test4:
                return False;
        }
        
-       cli_setatr(cli2, fname, 0, 0);
-       cli_unlink(cli2, fname);
+       cli_setatr(cli2->tree, fname, 0, 0);
+       cli_unlink(cli2->tree, fname);
        
        printf("TEST #1 testing 2 non-io opens (no delete)\n");
        
-       fnum1 = cli_nt_create_full(cli1, fname, 0, SA_RIGHT_FILE_READ_ATTRIBUTES, FILE_ATTRIBUTE_NORMAL,
+       fnum1 = cli_nt_create_full(cli1->tree, fname, 0, SA_RIGHT_FILE_READ_ATTRIBUTES, FILE_ATTRIBUTE_NORMAL,
                                   NTCREATEX_SHARE_ACCESS_NONE, NTCREATEX_DISP_OVERWRITE_IF, 0, 0);
 
        if (fnum1 == -1) {
-               printf("test 1 open 1 of %s failed (%s)\n", fname, cli_errstr(cli1));
+               printf("test 1 open 1 of %s failed (%s)\n", fname, cli_errstr(cli1->tree));
                CHECK_MAX_FAILURES(error_test10);
                return False;
        }
 
-       fnum2 = cli_nt_create_full(cli2, fname, 0, SA_RIGHT_FILE_READ_ATTRIBUTES, FILE_ATTRIBUTE_NORMAL,
+       fnum2 = cli_nt_create_full(cli2->tree, fname, 0, SA_RIGHT_FILE_READ_ATTRIBUTES, FILE_ATTRIBUTE_NORMAL,
                                   NTCREATEX_SHARE_ACCESS_NONE, NTCREATEX_DISP_OPEN_IF, 0, 0);
        if (fnum2 == -1) {
-               printf("test 1 open 2 of %s failed (%s)\n", fname, cli_errstr(cli2));
+               printf("test 1 open 2 of %s failed (%s)\n", fname, cli_errstr(cli2->tree));
                CHECK_MAX_FAILURES(error_test10);
                return False;
        }
 
-       if (!cli_close(cli1, fnum1)) {
-               printf("test 1 close 1 of %s failed (%s)\n", fname, cli_errstr(cli1));
+       if (NT_STATUS_IS_ERR(cli_close(cli1->tree, fnum1))) {
+               printf("test 1 close 1 of %s failed (%s)\n", fname, cli_errstr(cli1->tree));
                return False;
        }
-       if (!cli_close(cli2, fnum2)) {
-               printf("test 1 close 2 of %s failed (%s)\n", fname, cli_errstr(cli2));
+       if (NT_STATUS_IS_ERR(cli_close(cli2->tree, fnum2))) {
+               printf("test 1 close 2 of %s failed (%s)\n", fname, cli_errstr(cli2->tree));
                return False;
        }
 
        printf("non-io open test #1 passed.\n");
 error_test10:
-       cli_unlink(cli1, fname);
+       cli_unlink(cli1->tree, fname);
 
        printf("TEST #2 testing 2 non-io opens (first with delete)\n");
        
-       fnum1 = cli_nt_create_full(cli1, fname, 0, STD_RIGHT_DELETE_ACCESS|SA_RIGHT_FILE_READ_ATTRIBUTES, FILE_ATTRIBUTE_NORMAL,
+       fnum1 = cli_nt_create_full(cli1->tree, fname, 0, STD_RIGHT_DELETE_ACCESS|SA_RIGHT_FILE_READ_ATTRIBUTES, FILE_ATTRIBUTE_NORMAL,
                                   NTCREATEX_SHARE_ACCESS_NONE, NTCREATEX_DISP_OVERWRITE_IF, 0, 0);
 
        if (fnum1 == -1) {
-               printf("test 2 open 1 of %s failed (%s)\n", fname, cli_errstr(cli1));
+               printf("test 2 open 1 of %s failed (%s)\n", fname, cli_errstr(cli1->tree));
                CHECK_MAX_FAILURES(error_test20);
                return False;
        }
 
-       fnum2 = cli_nt_create_full(cli2, fname, 0, SA_RIGHT_FILE_READ_ATTRIBUTES, FILE_ATTRIBUTE_NORMAL,
+       fnum2 = cli_nt_create_full(cli2->tree, fname, 0, SA_RIGHT_FILE_READ_ATTRIBUTES, FILE_ATTRIBUTE_NORMAL,
                                   NTCREATEX_SHARE_ACCESS_NONE, NTCREATEX_DISP_OPEN_IF, 0, 0);
 
        if (fnum2 == -1) {
-               printf("test 2 open 2 of %s failed (%s)\n", fname, cli_errstr(cli2));
+               printf("test 2 open 2 of %s failed (%s)\n", fname, cli_errstr(cli2->tree));
                CHECK_MAX_FAILURES(error_test20);
                return False;
        }
 
-       if (!cli_close(cli1, fnum1)) {
-               printf("test 1 close 1 of %s failed (%s)\n", fname, cli_errstr(cli1));
+       if (NT_STATUS_IS_ERR(cli_close(cli1->tree, fnum1))) {
+               printf("test 1 close 1 of %s failed (%s)\n", fname, cli_errstr(cli1->tree));
                return False;
        }
-       if (!cli_close(cli2, fnum2)) {
-               printf("test 1 close 2 of %s failed (%s)\n", fname, cli_errstr(cli1));
+       if (NT_STATUS_IS_ERR(cli_close(cli2->tree, fnum2))) {
+               printf("test 1 close 2 of %s failed (%s)\n", fname, cli_errstr(cli1->tree));
                return False;
        }
 
        printf("non-io open test #2 passed.\n");
 error_test20:
-       cli_unlink(cli1, fname);
+       cli_unlink(cli1->tree, fname);
 
        printf("TEST #3 testing 2 non-io opens (second with delete)\n");
        
-       fnum1 = cli_nt_create_full(cli1, fname, 0, SA_RIGHT_FILE_READ_ATTRIBUTES, FILE_ATTRIBUTE_NORMAL,
+       fnum1 = cli_nt_create_full(cli1->tree, fname, 0, SA_RIGHT_FILE_READ_ATTRIBUTES, FILE_ATTRIBUTE_NORMAL,
                                   NTCREATEX_SHARE_ACCESS_NONE, NTCREATEX_DISP_OVERWRITE_IF, 0, 0);
 
        if (fnum1 == -1) {
-               printf("test 3 open 1 of %s failed (%s)\n", fname, cli_errstr(cli1));
+               printf("test 3 open 1 of %s failed (%s)\n", fname, cli_errstr(cli1->tree));
                CHECK_MAX_FAILURES(error_test30);
                return False;
        }
 
-       fnum2 = cli_nt_create_full(cli2, fname, 0, STD_RIGHT_DELETE_ACCESS|SA_RIGHT_FILE_READ_ATTRIBUTES, FILE_ATTRIBUTE_NORMAL,
+       fnum2 = cli_nt_create_full(cli2->tree, fname, 0, STD_RIGHT_DELETE_ACCESS|SA_RIGHT_FILE_READ_ATTRIBUTES, FILE_ATTRIBUTE_NORMAL,
                                   NTCREATEX_SHARE_ACCESS_NONE, NTCREATEX_DISP_OPEN_IF, 0, 0);
 
        if (fnum2 == -1) {
-               printf("test 3 open 2 of %s failed (%s)\n", fname, cli_errstr(cli2));
+               printf("test 3 open 2 of %s failed (%s)\n", fname, cli_errstr(cli2->tree));
                CHECK_MAX_FAILURES(error_test30);
                return False;
        }
 
-       if (!cli_close(cli1, fnum1)) {
-               printf("test 3 close 1 of %s failed (%s)\n", fname, cli_errstr(cli1));
+       if (NT_STATUS_IS_ERR(cli_close(cli1->tree, fnum1))) {
+               printf("test 3 close 1 of %s failed (%s)\n", fname, cli_errstr(cli1->tree));
                return False;
        }
-       if (!cli_close(cli2, fnum2)) {
-               printf("test 3 close 2 of %s failed (%s)\n", fname, cli_errstr(cli2));
+       if (NT_STATUS_IS_ERR(cli_close(cli2->tree, fnum2))) {
+               printf("test 3 close 2 of %s failed (%s)\n", fname, cli_errstr(cli2->tree));
                return False;
        }
 
        printf("non-io open test #3 passed.\n");
 error_test30:
-       cli_unlink(cli1, fname);
+       cli_unlink(cli1->tree, fname);
 
        printf("TEST #4 testing 2 non-io opens (both with delete)\n");
        
-       fnum1 = cli_nt_create_full(cli1, fname, 0, STD_RIGHT_DELETE_ACCESS|SA_RIGHT_FILE_READ_ATTRIBUTES, FILE_ATTRIBUTE_NORMAL,
+       fnum1 = cli_nt_create_full(cli1->tree, fname, 0, STD_RIGHT_DELETE_ACCESS|SA_RIGHT_FILE_READ_ATTRIBUTES, FILE_ATTRIBUTE_NORMAL,
                                   NTCREATEX_SHARE_ACCESS_NONE, NTCREATEX_DISP_OVERWRITE_IF, 0, 0);
 
        if (fnum1 == -1) {
-               printf("test 4 open 1 of %s failed (%s)\n", fname, cli_errstr(cli1));
+               printf("test 4 open 1 of %s failed (%s)\n", fname, cli_errstr(cli1->tree));
                CHECK_MAX_FAILURES(error_test40);
                return False;
        }
 
-       fnum2 = cli_nt_create_full(cli2, fname, 0, STD_RIGHT_DELETE_ACCESS|SA_RIGHT_FILE_READ_ATTRIBUTES, FILE_ATTRIBUTE_NORMAL,
+       fnum2 = cli_nt_create_full(cli2->tree, fname, 0, STD_RIGHT_DELETE_ACCESS|SA_RIGHT_FILE_READ_ATTRIBUTES, FILE_ATTRIBUTE_NORMAL,
                                   NTCREATEX_SHARE_ACCESS_NONE, NTCREATEX_DISP_OPEN_IF, 0, 0);
 
        if (fnum2 != -1) {
-               printf("test 4 open 2 of %s SUCCEEDED - should have failed (%s)\n", fname, cli_errstr(cli2));
+               printf("test 4 open 2 of %s SUCCEEDED - should have failed (%s)\n", fname, cli_errstr(cli2->tree));
                CHECK_MAX_FAILURES(error_test40);
                return False;
        }
 
-       printf("test 4 open 2 of %s gave %s (correct error should be %s)\n", fname, cli_errstr(cli2), "sharing violation");
+       printf("test 4 open 2 of %s gave %s (correct error should be %s)\n", fname, cli_errstr(cli2->tree), "sharing violation");
 
-       if (!cli_close(cli1, fnum1)) {
-               printf("test 4 close 1 of %s failed (%s)\n", fname, cli_errstr(cli1));
+       if (NT_STATUS_IS_ERR(cli_close(cli1->tree, fnum1))) {
+               printf("test 4 close 1 of %s failed (%s)\n", fname, cli_errstr(cli1->tree));
                return False;
        }
 
        printf("non-io open test #4 passed.\n");
 error_test40:
-       cli_unlink(cli1, fname);
+       cli_unlink(cli1->tree, fname);
 
        printf("TEST #5 testing 2 non-io opens (both with delete - both with file share delete)\n");
        
-       fnum1 = cli_nt_create_full(cli1, fname, 0, STD_RIGHT_DELETE_ACCESS|SA_RIGHT_FILE_READ_ATTRIBUTES, FILE_ATTRIBUTE_NORMAL,
+       fnum1 = cli_nt_create_full(cli1->tree, fname, 0, STD_RIGHT_DELETE_ACCESS|SA_RIGHT_FILE_READ_ATTRIBUTES, FILE_ATTRIBUTE_NORMAL,
                                   NTCREATEX_SHARE_ACCESS_DELETE, NTCREATEX_DISP_OVERWRITE_IF, 0, 0);
 
        if (fnum1 == -1) {
-               printf("test 5 open 1 of %s failed (%s)\n", fname, cli_errstr(cli1));
+               printf("test 5 open 1 of %s failed (%s)\n", fname, cli_errstr(cli1->tree));
                CHECK_MAX_FAILURES(error_test50);
                return False;
        }
 
-       fnum2 = cli_nt_create_full(cli2, fname, 0, STD_RIGHT_DELETE_ACCESS|SA_RIGHT_FILE_READ_ATTRIBUTES, FILE_ATTRIBUTE_NORMAL,
+       fnum2 = cli_nt_create_full(cli2->tree, fname, 0, STD_RIGHT_DELETE_ACCESS|SA_RIGHT_FILE_READ_ATTRIBUTES, FILE_ATTRIBUTE_NORMAL,
                                   NTCREATEX_SHARE_ACCESS_DELETE, NTCREATEX_DISP_OPEN_IF, 0, 0);
 
        if (fnum2 == -1) {
-               printf("test 5 open 2 of %s failed (%s)\n", fname, cli_errstr(cli2));
+               printf("test 5 open 2 of %s failed (%s)\n", fname, cli_errstr(cli2->tree));
                CHECK_MAX_FAILURES(error_test50);
                return False;
        }
 
-       if (!cli_close(cli1, fnum1)) {
-               printf("test 5 close 1 of %s failed (%s)\n", fname, cli_errstr(cli1));
+       if (NT_STATUS_IS_ERR(cli_close(cli1->tree, fnum1))) {
+               printf("test 5 close 1 of %s failed (%s)\n", fname, cli_errstr(cli1->tree));
                return False;
        }
 
-       if (!cli_close(cli2, fnum2)) {
-               printf("test 5 close 2 of %s failed (%s)\n", fname, cli_errstr(cli2));
+       if (NT_STATUS_IS_ERR(cli_close(cli2->tree, fnum2))) {
+               printf("test 5 close 2 of %s failed (%s)\n", fname, cli_errstr(cli2->tree));
                return False;
        }
 
@@ -3186,33 +3265,33 @@ error_test40:
 error_test50:
        printf("TEST #6 testing 1 non-io open, one io open\n");
        
-       cli_unlink(cli1, fname);
+       cli_unlink(cli1->tree, fname);
 
-       fnum1 = cli_nt_create_full(cli1, fname, 0, SA_RIGHT_FILE_READ_DATA, FILE_ATTRIBUTE_NORMAL,
+       fnum1 = cli_nt_create_full(cli1->tree, fname, 0, SA_RIGHT_FILE_READ_DATA, FILE_ATTRIBUTE_NORMAL,
                                   NTCREATEX_SHARE_ACCESS_NONE, NTCREATEX_DISP_OVERWRITE_IF, 0, 0);
 
        if (fnum1 == -1) {
-               printf("test 6 open 1 of %s failed (%s)\n", fname, cli_errstr(cli1));
+               printf("test 6 open 1 of %s failed (%s)\n", fname, cli_errstr(cli1->tree));
                CHECK_MAX_FAILURES(error_test60);
                return False;
        }
 
-       fnum2 = cli_nt_create_full(cli2, fname, 0, SA_RIGHT_FILE_READ_ATTRIBUTES, FILE_ATTRIBUTE_NORMAL,
+       fnum2 = cli_nt_create_full(cli2->tree, fname, 0, SA_RIGHT_FILE_READ_ATTRIBUTES, FILE_ATTRIBUTE_NORMAL,
                                   NTCREATEX_SHARE_ACCESS_READ, NTCREATEX_DISP_OPEN_IF, 0, 0);
 
        if (fnum2 == -1) {
-               printf("test 6 open 2 of %s failed (%s)\n", fname, cli_errstr(cli2));
+               printf("test 6 open 2 of %s failed (%s)\n", fname, cli_errstr(cli2->tree));
                CHECK_MAX_FAILURES(error_test60);
                return False;
        }
 
-       if (!cli_close(cli1, fnum1)) {
-               printf("test 6 close 1 of %s failed (%s)\n", fname, cli_errstr(cli1));
+       if (NT_STATUS_IS_ERR(cli_close(cli1->tree, fnum1))) {
+               printf("test 6 close 1 of %s failed (%s)\n", fname, cli_errstr(cli1->tree));
                return False;
        }
 
-       if (!cli_close(cli2, fnum2)) {
-               printf("test 6 close 2 of %s failed (%s)\n", fname, cli_errstr(cli2));
+       if (NT_STATUS_IS_ERR(cli_close(cli2->tree, fnum2))) {
+               printf("test 6 close 2 of %s failed (%s)\n", fname, cli_errstr(cli2->tree));
                return False;
        }
 
@@ -3220,36 +3299,110 @@ error_test50:
 error_test60:
        printf("TEST #7 testing 1 non-io open, one io open with delete\n");
 
-       cli_unlink(cli1, fname);
+       cli_unlink(cli1->tree, fname);
 
-       fnum1 = cli_nt_create_full(cli1, fname, 0, SA_RIGHT_FILE_READ_DATA, FILE_ATTRIBUTE_NORMAL,
+       fnum1 = cli_nt_create_full(cli1->tree, fname, 0, SA_RIGHT_FILE_READ_DATA, FILE_ATTRIBUTE_NORMAL,
                                   NTCREATEX_SHARE_ACCESS_NONE, NTCREATEX_DISP_OVERWRITE_IF, 0, 0);
 
        if (fnum1 == -1) {
-               printf("test 7 open 1 of %s failed (%s)\n", fname, cli_errstr(cli1));
+               printf("test 7 open 1 of %s failed (%s)\n", fname, cli_errstr(cli1->tree));
                CHECK_MAX_FAILURES(error_test70);
                return False;
        }
 
-       fnum2 = cli_nt_create_full(cli2, fname, 0, STD_RIGHT_DELETE_ACCESS|SA_RIGHT_FILE_READ_ATTRIBUTES, FILE_ATTRIBUTE_NORMAL,
+       fnum2 = cli_nt_create_full(cli2->tree, fname, 0, STD_RIGHT_DELETE_ACCESS|SA_RIGHT_FILE_READ_ATTRIBUTES, FILE_ATTRIBUTE_NORMAL,
                                   NTCREATEX_SHARE_ACCESS_READ|NTCREATEX_SHARE_ACCESS_DELETE, NTCREATEX_DISP_OPEN_IF, 0, 0);
 
        if (fnum2 != -1) {
-               printf("test 7 open 2 of %s SUCCEEDED - should have failed (%s)\n", fname, cli_errstr(cli2));
+               printf("test 7 open 2 of %s SUCCEEDED - should have failed (%s)\n", fname, cli_errstr(cli2->tree));
                CHECK_MAX_FAILURES(error_test70);
                return False;
        }
 
-       printf("test 7 open 2 of %s gave %s (correct error should be %s)\n", fname, cli_errstr(cli2), "sharing violation");
+       printf("test 7 open 2 of %s gave %s (correct error should be %s)\n", fname, cli_errstr(cli2->tree), "sharing violation");
 
-       if (!cli_close(cli1, fnum1)) {
-               printf("test 7 close 1 of %s failed (%s)\n", fname, cli_errstr(cli1));
+       if (NT_STATUS_IS_ERR(cli_close(cli1->tree, fnum1))) {
+               printf("test 7 close 1 of %s failed (%s)\n", fname, cli_errstr(cli1->tree));
                return False;
        }
 
        printf("non-io open test #7 passed.\n");
+
 error_test70:
-       cli_unlink(cli1, fname);
+
+       printf("TEST #8 testing one normal open, followed by lock, followed by open with truncate\n");
+
+       cli_unlink(cli1->tree, fname);
+
+       fnum1 = cli_open(cli1->tree, fname, O_RDWR|O_CREAT, DENY_NONE);
+       if (fnum1 == -1) {
+               printf("(8) open (1) of %s failed (%s)\n", fname, cli_errstr(cli1->tree));
+               return False;
+       }
+       
+       /* write 20 bytes. */
+       
+       memset(buf, '\0', 20);
+
+       if (cli_write(cli1->tree, fnum1, 0, buf, 0, 20) != 20) {
+               printf("(8) write failed (%s)\n", cli_errstr(cli1->tree));
+               correct = False;
+       }
+
+       /* Ensure size == 20. */
+       if (NT_STATUS_IS_ERR(cli_getatr(cli1->tree, fname, NULL, &fsize, NULL))) {
+               printf("(8) getatr (1) failed (%s)\n", cli_errstr(cli1->tree));
+               CHECK_MAX_FAILURES(error_test80);
+               return False;
+       }
+       
+       if (fsize != 20) {
+               printf("(8) file size != 20\n");
+               CHECK_MAX_FAILURES(error_test80);
+               return False;
+       }
+
+       /* Get an exclusive lock on the open file. */
+       if (NT_STATUS_IS_ERR(cli_lock(cli1->tree, fnum1, 0, 4, 0, WRITE_LOCK))) {
+               printf("(8) lock1 failed (%s)\n", cli_errstr(cli1->tree));
+               CHECK_MAX_FAILURES(error_test80);
+               return False;
+       }
+
+       fnum2 = cli_open(cli1->tree, fname, O_RDWR|O_TRUNC, DENY_NONE);
+       if (fnum1 == -1) {
+               printf("(8) open (2) of %s with truncate failed (%s)\n", fname, cli_errstr(cli1->tree));
+               return False;
+       }
+
+       /* Ensure size == 0. */
+       if (NT_STATUS_IS_ERR(cli_getatr(cli1->tree, fname, NULL, &fsize, NULL))) {
+               printf("(8) getatr (2) failed (%s)\n", cli_errstr(cli1->tree));
+               CHECK_MAX_FAILURES(error_test80);
+               return False;
+       }
+       
+       if (fsize != 0) {
+               printf("(8) file size != 0\n");
+               CHECK_MAX_FAILURES(error_test80);
+               return False;
+       }
+
+       if (NT_STATUS_IS_ERR(cli_close(cli1->tree, fnum1))) {
+               printf("(8) close1 failed (%s)\n", cli_errstr(cli1->tree));
+               return False;
+       }
+       
+       if (NT_STATUS_IS_ERR(cli_close(cli1->tree, fnum2))) {
+               printf("(8) close1 failed (%s)\n", cli_errstr(cli1->tree));
+               return False;
+       }
+       
+error_test80:
+
+       printf("open test #8 passed.\n");
+
+       cli_unlink(cli1->tree, fname);
 
        if (!torture_close_connection(cli1)) {
                correct = False;
@@ -3262,7 +3415,7 @@ error_test70:
 }
 
 
-static uint32 open_attrs_table[] = {
+static uint32_t open_attrs_table[] = {
                FILE_ATTRIBUTE_NORMAL,
                FILE_ATTRIBUTE_ARCHIVE,
                FILE_ATTRIBUTE_READONLY,
@@ -3283,10 +3436,10 @@ static uint32 open_attrs_table[] = {
 };
 
 struct trunc_open_results {
-       unsigned int num;
-       uint32 init_attr;
-       uint32 trunc_attr;
-       uint32 result_attr;
+       uint_t num;
+       uint32_t init_attr;
+       uint32_t trunc_attr;
+       uint32_t result_attr;
 };
 
 static struct trunc_open_results attr_results[] = {
@@ -3324,8 +3477,8 @@ static BOOL run_openattrtest(int dummy)
        const char *fname = "\\openattr.file";
        int fnum1;
        BOOL correct = True;
-       uint16 attr;
-       unsigned int i, j, k, l;
+       uint16_t attr;
+       uint_t i, j, k, l;
        int failures = 0;
 
        printf("starting open attr test\n");
@@ -3334,24 +3487,24 @@ static BOOL run_openattrtest(int dummy)
                return False;
        }
        
-       for (k = 0, i = 0; i < sizeof(open_attrs_table)/sizeof(uint32); i++) {
-               cli_setatr(cli1, fname, 0, 0);
-               cli_unlink(cli1, fname);
-               fnum1 = cli_nt_create_full(cli1, fname, 0, SA_RIGHT_FILE_WRITE_DATA, open_attrs_table[i],
+       for (k = 0, i = 0; i < sizeof(open_attrs_table)/sizeof(uint32_t); i++) {
+               cli_setatr(cli1->tree, fname, 0, 0);
+               cli_unlink(cli1->tree, fname);
+               fnum1 = cli_nt_create_full(cli1->tree, fname, 0, SA_RIGHT_FILE_WRITE_DATA, open_attrs_table[i],
                                   NTCREATEX_SHARE_ACCESS_NONE, NTCREATEX_DISP_OVERWRITE_IF, 0, 0);
 
                if (fnum1 == -1) {
-                       printf("open %d (1) of %s failed (%s)\n", i, fname, cli_errstr(cli1));
+                       printf("open %d (1) of %s failed (%s)\n", i, fname, cli_errstr(cli1->tree));
                        return False;
                }
 
-               if (!cli_close(cli1, fnum1)) {
-                       printf("close %d (1) of %s failed (%s)\n", i, fname, cli_errstr(cli1));
+               if (NT_STATUS_IS_ERR(cli_close(cli1->tree, fnum1))) {
+                       printf("close %d (1) of %s failed (%s)\n", i, fname, cli_errstr(cli1->tree));
                        return False;
                }
 
                for (j = 0; j < ARRAY_SIZE(open_attrs_table); j++) {
-                       fnum1 = cli_nt_create_full(cli1, fname, 0, 
+                       fnum1 = cli_nt_create_full(cli1->tree, fname, 0, 
                                                   SA_RIGHT_FILE_READ_DATA|SA_RIGHT_FILE_WRITE_DATA, 
                                                   open_attrs_table[j],
                                                   NTCREATEX_SHARE_ACCESS_NONE, 
@@ -3363,15 +3516,15 @@ static BOOL run_openattrtest(int dummy)
                                                printf("[%d] trunc open 0x%x -> 0x%x of %s failed - should have succeeded !(0x%x:%s)\n",
                                                                k, open_attrs_table[i],
                                                                open_attrs_table[j],
-                                                               fname, NT_STATUS_V(cli_nt_error(cli1)), cli_errstr(cli1));
+                                                               fname, NT_STATUS_V(cli_nt_error(cli1->tree)), cli_errstr(cli1->tree));
                                                correct = False;
                                                CHECK_MAX_FAILURES(error_exit);
                                        }
                                }
-                               if (NT_STATUS_V(cli_nt_error(cli1)) != NT_STATUS_V(NT_STATUS_ACCESS_DENIED)) {
+                               if (NT_STATUS_V(cli_nt_error(cli1->tree)) != NT_STATUS_V(NT_STATUS_ACCESS_DENIED)) {
                                        printf("[%d] trunc open 0x%x -> 0x%x failed with wrong error code %s\n",
                                                        k, open_attrs_table[i], open_attrs_table[j],
-                                                       cli_errstr(cli1));
+                                                       cli_errstr(cli1->tree));
                                        correct = False;
                                        CHECK_MAX_FAILURES(error_exit);
                                }
@@ -3382,13 +3535,13 @@ static BOOL run_openattrtest(int dummy)
                                continue;
                        }
 
-                       if (!cli_close(cli1, fnum1)) {
-                               printf("close %d (2) of %s failed (%s)\n", j, fname, cli_errstr(cli1));
+                       if (NT_STATUS_IS_ERR(cli_close(cli1->tree, fnum1))) {
+                               printf("close %d (2) of %s failed (%s)\n", j, fname, cli_errstr(cli1->tree));
                                return False;
                        }
 
-                       if (!cli_getatr(cli1, fname, &attr, NULL, NULL)) {
-                               printf("getatr(2) failed (%s)\n", cli_errstr(cli1));
+                       if (NT_STATUS_IS_ERR(cli_getatr(cli1->tree, fname, &attr, NULL, NULL))) {
+                               printf("getatr(2) failed (%s)\n", cli_errstr(cli1->tree));
                                return False;
                        }
 
@@ -3405,7 +3558,7 @@ static BOOL run_openattrtest(int dummy)
                                                printf("[%d] getatr check failed. [0x%x] trunc [0x%x] got attr 0x%x, should be 0x%x\n",
                                                        k, open_attrs_table[i],
                                                        open_attrs_table[j],
-                                                       (unsigned int)attr,
+                                                       (uint_t)attr,
                                                        attr_results[l].result_attr);
                                                correct = False;
                                                CHECK_MAX_FAILURES(error_exit);
@@ -3417,8 +3570,8 @@ static BOOL run_openattrtest(int dummy)
                }
        }
 error_exit:
-       cli_setatr(cli1, fname, 0, 0);
-       cli_unlink(cli1, fname);
+       cli_setatr(cli1->tree, fname, 0, 0);
+       cli_unlink(cli1->tree, fname);
 
        printf("open attr test %s.\n", correct ? "passed" : "failed");
 
@@ -3456,20 +3609,20 @@ static BOOL run_dirtest(int dummy)
        for (i=0;i<torture_numops;i++) {
                char *fname;
                asprintf(&fname, "\\%x", (int)random());
-               fnum = cli_open(cli, fname, O_RDWR|O_CREAT, DENY_NONE);
+               fnum = cli_open(cli->tree, fname, O_RDWR|O_CREAT, DENY_NONE);
                if (fnum == -1) {
                        fprintf(stderr,"Failed to open %s\n", fname);
                        return False;
                }
-               cli_close(cli, fnum);
+               cli_close(cli->tree, fnum);
                free(fname);
        }
 
        t1 = end_timer();
 
-       printf("Matched %d\n", cli_list(cli, "a*.*", 0, list_fn, NULL));
-       printf("Matched %d\n", cli_list(cli, "b*.*", 0, list_fn, NULL));
-       printf("Matched %d\n", cli_list(cli, "xyzabc", 0, list_fn, NULL));
+       printf("Matched %d\n", cli_list(cli->tree, "a*.*", 0, list_fn, NULL));
+       printf("Matched %d\n", cli_list(cli->tree, "b*.*", 0, list_fn, NULL));
+       printf("Matched %d\n", cli_list(cli->tree, "xyzabc", 0, list_fn, NULL));
 
        printf("dirtest core %g seconds\n", end_timer() - t1);
 
@@ -3477,7 +3630,7 @@ static BOOL run_dirtest(int dummy)
        for (i=0;i<torture_numops;i++) {
                char *fname;
                asprintf(&fname, "\\%x", (int)random());
-               cli_unlink(cli, fname);
+               cli_unlink(cli->tree, fname);
                free(fname);
        }
 
@@ -3500,11 +3653,11 @@ static void del_fn(file_info *finfo, const char *mask, void *state)
                return;
 
        if (finfo->mode & FILE_ATTRIBUTE_DIRECTORY) {
-               if (!cli_rmdir(pcli, fname))
-                       printf("del_fn: failed to rmdir %s, error=%s\n", fname, cli_errstr(pcli) );
+               if (NT_STATUS_IS_ERR(cli_rmdir(pcli->tree, fname)))
+                       printf("del_fn: failed to rmdir %s, error=%s\n", fname, cli_errstr(pcli->tree) );
        } else {
-               if (!cli_unlink(pcli, fname))
-                       printf("del_fn: failed to unlink %s, error=%s\n", fname, cli_errstr(pcli) );
+               if (NT_STATUS_IS_ERR(cli_unlink(pcli->tree, fname)))
+                       printf("del_fn: failed to unlink %s, error=%s\n", fname, cli_errstr(pcli->tree) );
        }
        free(fname);
 }
@@ -3516,12 +3669,11 @@ static void del_fn(file_info *finfo, const char *mask, void *state)
 BOOL torture_ioctl_test(int dummy)
 {
        struct cli_state *cli;
-       uint16 device, function;
+       uint16_t device, function;
        int fnum;
        const char *fname = "\\ioctl.dat";
-       DATA_BLOB blob;
        NTSTATUS status;
-       struct smb_ioctl parms;
+       union smb_ioctl parms;
        TALLOC_CTX *mem_ctx;
 
        if (!torture_open_connection(&cli)) {
@@ -3532,28 +3684,28 @@ BOOL torture_ioctl_test(int dummy)
 
        printf("starting ioctl test\n");
 
-       cli_unlink(cli, fname);
+       cli_unlink(cli->tree, fname);
 
-       fnum = cli_open(cli, fname, O_RDWR|O_CREAT|O_EXCL, DENY_NONE);
+       fnum = cli_open(cli->tree, fname, O_RDWR|O_CREAT|O_EXCL, DENY_NONE);
        if (fnum == -1) {
-               printf("open of %s failed (%s)\n", fname, cli_errstr(cli));
+               printf("open of %s failed (%s)\n", fname, cli_errstr(cli->tree));
                return False;
        }
 
-       parms.in.request = IOCTL_QUERY_JOB_INFO;
+       parms.ioctl.level = RAW_IOCTL_IOCTL;
+       parms.ioctl.in.request = IOCTL_QUERY_JOB_INFO;
        status = smb_raw_ioctl(cli->tree, mem_ctx, &parms);
-       printf("ioctl job info: %s\n", cli_errstr(cli));
+       printf("ioctl job info: %s\n", cli_errstr(cli->tree));
 
        for (device=0;device<0x100;device++) {
                printf("testing device=0x%x\n", device);
                for (function=0;function<0x100;function++) {
-                       parms.in.request = (device << 16) | function;
+                       parms.ioctl.in.request = (device << 16) | function;
                        status = smb_raw_ioctl(cli->tree, mem_ctx, &parms);
 
                        if (NT_STATUS_IS_OK(status)) {
                                printf("ioctl device=0x%x function=0x%x OK : %d bytes\n", 
-                                       device, function, blob.length);
-                               data_blob_free(&parms.out.blob);
+                                       device, function, parms.ioctl.out.blob.length);
                        }
                }
        }
@@ -3584,38 +3736,38 @@ BOOL torture_chkpath_test(int dummy)
        printf("Testing valid and invalid paths\n");
 
        /* cleanup from an old run */
-       cli_rmdir(cli, "\\chkpath.dir\\dir2");
-       cli_unlink(cli, "\\chkpath.dir\\*");
-       cli_rmdir(cli, "\\chkpath.dir");
+       cli_rmdir(cli->tree, "\\chkpath.dir\\dir2");
+       cli_unlink(cli->tree, "\\chkpath.dir\\*");
+       cli_rmdir(cli->tree, "\\chkpath.dir");
 
-       if (!cli_mkdir(cli, "\\chkpath.dir")) {
-               printf("mkdir1 failed : %s\n", cli_errstr(cli));
+       if (NT_STATUS_IS_ERR(cli_mkdir(cli->tree, "\\chkpath.dir"))) {
+               printf("mkdir1 failed : %s\n", cli_errstr(cli->tree));
                return False;
        }
 
-       if (!cli_mkdir(cli, "\\chkpath.dir\\dir2")) {
-               printf("mkdir2 failed : %s\n", cli_errstr(cli));
+       if (NT_STATUS_IS_ERR(cli_mkdir(cli->tree, "\\chkpath.dir\\dir2"))) {
+               printf("mkdir2 failed : %s\n", cli_errstr(cli->tree));
                return False;
        }
 
-       fnum = cli_open(cli, "\\chkpath.dir\\foo.txt", O_RDWR|O_CREAT|O_EXCL, DENY_NONE);
+       fnum = cli_open(cli->tree, "\\chkpath.dir\\foo.txt", O_RDWR|O_CREAT|O_EXCL, DENY_NONE);
        if (fnum == -1) {
-               printf("open1 failed (%s)\n", cli_errstr(cli));
+               printf("open1 failed (%s)\n", cli_errstr(cli->tree));
                return False;
        }
-       cli_close(cli, fnum);
+       cli_close(cli->tree, fnum);
 
-       if (!cli_chkpath(cli, "\\chkpath.dir")) {
-               printf("chkpath1 failed: %s\n", cli_errstr(cli));
+       if (NT_STATUS_IS_ERR(cli_chkpath(cli->tree, "\\chkpath.dir"))) {
+               printf("chkpath1 failed: %s\n", cli_errstr(cli->tree));
                ret = False;
        }
 
-       if (!cli_chkpath(cli, "\\chkpath.dir\\dir2")) {
-               printf("chkpath2 failed: %s\n", cli_errstr(cli));
+       if (NT_STATUS_IS_ERR(cli_chkpath(cli->tree, "\\chkpath.dir\\dir2"))) {
+               printf("chkpath2 failed: %s\n", cli_errstr(cli->tree));
                ret = False;
        }
 
-       if (!cli_chkpath(cli, "\\chkpath.dir\\foo.txt")) {
+       if (NT_STATUS_IS_ERR(cli_chkpath(cli->tree, "\\chkpath.dir\\foo.txt"))) {
                ret = check_error(__LINE__, cli, ERRDOS, ERRbadpath, 
                                  NT_STATUS_NOT_A_DIRECTORY);
        } else {
@@ -3623,7 +3775,7 @@ BOOL torture_chkpath_test(int dummy)
                ret = False;
        }
 
-       if (!cli_chkpath(cli, "\\chkpath.dir\\bar.txt")) {
+       if (NT_STATUS_IS_ERR(cli_chkpath(cli->tree, "\\chkpath.dir\\bar.txt"))) {
                ret = check_error(__LINE__, cli, ERRDOS, ERRbadfile, 
                                  NT_STATUS_OBJECT_NAME_NOT_FOUND);
        } else {
@@ -3631,7 +3783,7 @@ BOOL torture_chkpath_test(int dummy)
                ret = False;
        }
 
-       if (!cli_chkpath(cli, "\\chkpath.dir\\dirxx\\bar.txt")) {
+       if (NT_STATUS_IS_ERR(cli_chkpath(cli->tree, "\\chkpath.dir\\dirxx\\bar.txt"))) {
                ret = check_error(__LINE__, cli, ERRDOS, ERRbadpath, 
                                  NT_STATUS_OBJECT_PATH_NOT_FOUND);
        } else {
@@ -3639,9 +3791,9 @@ BOOL torture_chkpath_test(int dummy)
                ret = False;
        }
 
-       cli_rmdir(cli, "\\chkpath.dir\\dir2");
-       cli_unlink(cli, "\\chkpath.dir\\*");
-       cli_rmdir(cli, "\\chkpath.dir");
+       cli_rmdir(cli->tree, "\\chkpath.dir\\dir2");
+       cli_unlink(cli->tree, "\\chkpath.dir\\*");
+       cli_rmdir(cli->tree, "\\chkpath.dir");
 
        if (!torture_close_connection(cli)) {
                return False;
@@ -3663,14 +3815,14 @@ static BOOL run_dirtest1(int dummy)
                return False;
        }
 
-       cli_list(cli, "\\LISTDIR\\*", 0, del_fn, cli);
-       cli_list(cli, "\\LISTDIR\\*", FILE_ATTRIBUTE_DIRECTORY, del_fn, cli);
-       if (cli_deltree(cli, "\\LISTDIR") == -1) {
-               fprintf(stderr,"Failed to deltree %s, error=%s\n", "\\LISTDIR", cli_errstr(cli));
+       cli_list(cli->tree, "\\LISTDIR\\*", 0, del_fn, cli);
+       cli_list(cli->tree, "\\LISTDIR\\*", FILE_ATTRIBUTE_DIRECTORY, del_fn, cli);
+       if (cli_deltree(cli->tree, "\\LISTDIR") == -1) {
+               fprintf(stderr,"Failed to deltree %s, error=%s\n", "\\LISTDIR", cli_errstr(cli->tree));
                return False;
        }
-       if (!cli_mkdir(cli, "\\LISTDIR")) {
-               fprintf(stderr,"Failed to mkdir %s, error=%s\n", "\\LISTDIR", cli_errstr(cli));
+       if (NT_STATUS_IS_ERR(cli_mkdir(cli->tree, "\\LISTDIR"))) {
+               fprintf(stderr,"Failed to mkdir %s, error=%s\n", "\\LISTDIR", cli_errstr(cli->tree));
                return False;
        }
 
@@ -3680,27 +3832,27 @@ static BOOL run_dirtest1(int dummy)
        for (i=0;i<torture_entries;i++) {
                char *fname;
                asprintf(&fname, "\\LISTDIR\\f%d", i);
-               fnum = cli_nt_create_full(cli, fname, 0, GENERIC_RIGHTS_FILE_ALL_ACCESS, FILE_ATTRIBUTE_ARCHIVE,
+               fnum = cli_nt_create_full(cli->tree, fname, 0, GENERIC_RIGHTS_FILE_ALL_ACCESS, FILE_ATTRIBUTE_ARCHIVE,
                                   NTCREATEX_SHARE_ACCESS_READ|NTCREATEX_SHARE_ACCESS_WRITE, NTCREATEX_DISP_OVERWRITE_IF, 0, 0);
                if (fnum == -1) {
-                       fprintf(stderr,"Failed to open %s, error=%s\n", fname, cli_errstr(cli));
+                       fprintf(stderr,"Failed to open %s, error=%s\n", fname, cli_errstr(cli->tree));
                        return False;
                }
                free(fname);
-               cli_close(cli, fnum);
+               cli_close(cli->tree, fnum);
        }
        for (i=0;i<torture_entries;i++) {
                char *fname;
                asprintf(&fname, "\\LISTDIR\\d%d", i);
-               if (!cli_mkdir(cli, fname)) {
-                       fprintf(stderr,"Failed to open %s, error=%s\n", fname, cli_errstr(cli));
+               if (NT_STATUS_IS_ERR(cli_mkdir(cli->tree, fname))) {
+                       fprintf(stderr,"Failed to open %s, error=%s\n", fname, cli_errstr(cli->tree));
                        return False;
                }
                free(fname);
        }
 
        /* Now ensure that doing an old list sees both files and directories. */
-       num_seen = cli_list_old(cli, "\\LISTDIR\\*", FILE_ATTRIBUTE_DIRECTORY, list_fn, NULL);
+       num_seen = cli_list_old(cli->tree, "\\LISTDIR\\*", FILE_ATTRIBUTE_DIRECTORY, list_fn, NULL);
        printf("num_seen = %d\n", num_seen );
        /* We should see (torture_entries) each of files & directories + . and .. */
        if (num_seen != (2*torture_entries)+2) {
@@ -3713,7 +3865,7 @@ static BOOL run_dirtest1(int dummy)
        /* Ensure if we have the "must have" bits we only see the
         * relevant entries.
         */
-       num_seen = cli_list_old(cli, "\\LISTDIR\\*", (FILE_ATTRIBUTE_DIRECTORY<<8)|FILE_ATTRIBUTE_DIRECTORY, list_fn, NULL);
+       num_seen = cli_list_old(cli->tree, "\\LISTDIR\\*", (FILE_ATTRIBUTE_DIRECTORY<<8)|FILE_ATTRIBUTE_DIRECTORY, list_fn, NULL);
        printf("num_seen = %d\n", num_seen );
        if (num_seen != torture_entries+2) {
                correct = False;
@@ -3721,7 +3873,7 @@ static BOOL run_dirtest1(int dummy)
                        torture_entries+2, num_seen);
        }
 
-       num_seen = cli_list_old(cli, "\\LISTDIR\\*", (FILE_ATTRIBUTE_ARCHIVE<<8)|FILE_ATTRIBUTE_DIRECTORY, list_fn, NULL);
+       num_seen = cli_list_old(cli->tree, "\\LISTDIR\\*", (FILE_ATTRIBUTE_ARCHIVE<<8)|FILE_ATTRIBUTE_DIRECTORY, list_fn, NULL);
        printf("num_seen = %d\n", num_seen );
        if (num_seen != torture_entries) {
                correct = False;
@@ -3730,14 +3882,14 @@ static BOOL run_dirtest1(int dummy)
        }
 
        /* Delete everything. */
-       cli_list(cli, "\\LISTDIR\\*", 0, del_fn, cli);
-       cli_list(cli, "\\LISTDIR\\*", FILE_ATTRIBUTE_DIRECTORY, del_fn, cli);
-       cli_rmdir(cli, "\\LISTDIR");
+       cli_list(cli->tree, "\\LISTDIR\\*", 0, del_fn, cli);
+       cli_list(cli->tree, "\\LISTDIR\\*", FILE_ATTRIBUTE_DIRECTORY, del_fn, cli);
+       cli_rmdir(cli->tree, "\\LISTDIR");
 
 #if 0
-       printf("Matched %d\n", cli_list(cli, "a*.*", 0, list_fn, NULL));
-       printf("Matched %d\n", cli_list(cli, "b*.*", 0, list_fn, NULL));
-       printf("Matched %d\n", cli_list(cli, "xyzabc", 0, list_fn, NULL));
+       printf("Matched %d\n", cli_list(cli->tree, "a*.*", 0, list_fn, NULL));
+       printf("Matched %d\n", cli_list(cli->tree, "b*.*", 0, list_fn, NULL));
+       printf("Matched %d\n", cli_list(cli->tree, "xyzabc", 0, list_fn, NULL));
 #endif
 
        if (!torture_close_connection(cli)) {
@@ -3772,23 +3924,23 @@ static BOOL run_deny3test(int dummy)
 
        fname = "\\deny_dos1.dat";
 
-       cli_unlink(cli1, fname);
-       fnum1 = cli_open(cli1, fname, O_CREAT|O_TRUNC|O_WRONLY, DENY_DOS);
-       fnum2 = cli_open(cli1, fname, O_CREAT|O_TRUNC|O_WRONLY, DENY_DOS);
-       if (fnum1 != -1) cli_close(cli1, fnum1);
-       if (fnum2 != -1) cli_close(cli1, fnum2);
-       cli_unlink(cli1, fname);
+       cli_unlink(cli1->tree, fname);
+       fnum1 = cli_open(cli1->tree, fname, O_CREAT|O_TRUNC|O_WRONLY, DENY_DOS);
+       fnum2 = cli_open(cli1->tree, fname, O_CREAT|O_TRUNC|O_WRONLY, DENY_DOS);
+       if (fnum1 != -1) cli_close(cli1->tree, fnum1);
+       if (fnum2 != -1) cli_close(cli1->tree, fnum2);
+       cli_unlink(cli1->tree, fname);
        printf("fnum1=%d fnum2=%d\n", fnum1, fnum2);
 
 
        fname = "\\deny_dos2.dat";
 
-       cli_unlink(cli1, fname);
-       fnum1 = cli_open(cli1, fname, O_CREAT|O_TRUNC|O_WRONLY, DENY_DOS);
-       fnum2 = cli_open(cli2, fname, O_CREAT|O_TRUNC|O_WRONLY, DENY_DOS);
-       if (fnum1 != -1) cli_close(cli1, fnum1);
-       if (fnum2 != -1) cli_close(cli2, fnum2);
-       cli_unlink(cli1, fname);
+       cli_unlink(cli1->tree, fname);
+       fnum1 = cli_open(cli1->tree, fname, O_CREAT|O_TRUNC|O_WRONLY, DENY_DOS);
+       fnum2 = cli_open(cli2->tree, fname, O_CREAT|O_TRUNC|O_WRONLY, DENY_DOS);
+       if (fnum1 != -1) cli_close(cli1->tree, fnum1);
+       if (fnum2 != -1) cli_close(cli2->tree, fnum2);
+       cli_unlink(cli1->tree, fname);
        printf("fnum1=%d fnum2=%d\n", fnum1, fnum2);
 
 
@@ -3798,46 +3950,84 @@ static BOOL run_deny3test(int dummy)
        return True;
 }
 
+/*
+  parse a //server/share type UNC name
+*/
+static BOOL parse_unc(const char *unc_name, char **hostname, char **sharename)
+{
+       char *p;
+
+       if (strncmp(unc_name, "//", 2)) {
+               return False;
+       }
+
+       *hostname = strdup(&unc_name[2]);
+       p = strchr_m(&(*hostname)[2],'/');
+       if (!p) {
+               return False;
+       }
+       *p = 0;
+       *sharename = strdup(p+1);
+
+       return True;
+}
+
+
+
 static void sigcont(void)
 {
 }
 
-static double create_procs(BOOL (*fn)(int), BOOL *result)
+double torture_create_procs(BOOL (*fn)(struct cli_state *, int), BOOL *result)
 {
        int i, status;
        volatile pid_t *child_status;
        volatile BOOL *child_status_out;
        int synccount;
        int tries = 8;
-       double start_time_limit = 10 + (nprocs * 1.5);
+       double start_time_limit = 10 + (torture_nprocs * 1.5);
+       char **unc_list = NULL;
+       const char *p;
+       int num_unc_names = 0;
 
        synccount = 0;
 
        signal(SIGCONT, sigcont);
 
-       child_status = (volatile pid_t *)shm_setup(sizeof(pid_t)*nprocs);
+       child_status = (volatile pid_t *)shm_setup(sizeof(pid_t)*torture_nprocs);
        if (!child_status) {
                printf("Failed to setup shared memory\n");
                return -1;
        }
 
-       child_status_out = (volatile BOOL *)shm_setup(sizeof(BOOL)*nprocs);
+       child_status_out = (volatile BOOL *)shm_setup(sizeof(BOOL)*torture_nprocs);
        if (!child_status_out) {
                printf("Failed to setup result status shared memory\n");
                return -1;
        }
 
-       for (i = 0; i < nprocs; i++) {
+       p = lp_parm_string(-1, "torture", "unclist");
+       if (p) {
+               unc_list = file_lines_load(p, &num_unc_names);
+               if (!unc_list || num_unc_names <= 0) {
+                       printf("Failed to load unc names list from %s\n", p);
+                       exit(1);
+               }
+       }
+
+       for (i = 0; i < torture_nprocs; i++) {
                child_status[i] = 0;
                child_status_out[i] = True;
        }
 
        start_timer();
 
-       for (i=0;i<nprocs;i++) {
+       for (i=0;i<torture_nprocs;i++) {
                procnum = i;
                if (fork() == 0) {
                        char *myname;
+                       char *hostname=NULL, *sharename;
+
                        pid_t mypid = getpid();
                        sys_srandom(((int)mypid) ^ ((int)time(NULL)));
 
@@ -3845,8 +4035,26 @@ static double create_procs(BOOL (*fn)(int), BOOL *result)
                        lp_set_cmdline("netbios name", myname);
                        free(myname);
 
+
+                       if (unc_list) {
+                               if (!parse_unc(unc_list[i % num_unc_names],
+                                              &hostname, &sharename)) {
+                                       printf("Failed to parse UNC name %s\n",
+                                              unc_list[i % num_unc_names]);
+                                       exit(1);
+                               }
+                       }
+
                        while (1) {
-                               if (torture_open_connection(&current_cli)) break;
+                               if (hostname) {
+                                       if (torture_open_connection_share(&current_cli,
+                                                                         hostname, 
+                                                                         sharename)) {
+                                               break;
+                                       }
+                               } else if (torture_open_connection(&current_cli)) {
+                                               break;
+                               }
                                if (tries-- == 0) {
                                        printf("pid %d failed to start\n", (int)getpid());
                                        _exit(1);
@@ -3864,38 +4072,38 @@ static double create_procs(BOOL (*fn)(int), BOOL *result)
                                _exit(1);
                        }
 
-                       child_status_out[i] = fn(i);
+                       child_status_out[i] = fn(current_cli, i);
                        _exit(0);
                }
        }
 
        do {
                synccount = 0;
-               for (i=0;i<nprocs;i++) {
+               for (i=0;i<torture_nprocs;i++) {
                        if (child_status[i]) synccount++;
                }
-               if (synccount == nprocs) break;
+               if (synccount == torture_nprocs) break;
                msleep(100);
        } while (end_timer() < start_time_limit);
 
-       if (synccount != nprocs) {
-               printf("FAILED TO START %d CLIENTS (started %d)\n", nprocs, synccount);
+       if (synccount != torture_nprocs) {
+               printf("FAILED TO START %d CLIENTS (started %d)\n", torture_nprocs, synccount);
                *result = False;
                return end_timer();
        }
 
-       printf("Starting %d clients\n", nprocs);
+       printf("Starting %d clients\n", torture_nprocs);
 
        /* start the client load */
        start_timer();
-       for (i=0;i<nprocs;i++) {
+       for (i=0;i<torture_nprocs;i++) {
                child_status[i] = 0;
        }
        kill(0, SIGCONT);
 
-       printf("%d clients started\n", nprocs);
+       printf("%d clients started\n", torture_nprocs);
 
-       for (i=0;i<nprocs;i++) {
+       for (i=0;i<torture_nprocs;i++) {
                int ret;
                while ((ret=waitpid(0, &status, 0)) == -1 && errno == EINTR) /* noop */ ;
                if (ret == -1 || WEXITSTATUS(status) != 0) {
@@ -3905,7 +4113,7 @@ static double create_procs(BOOL (*fn)(int), BOOL *result)
 
        printf("\n");
        
-       for (i=0;i<nprocs;i++) {
+       for (i=0;i<torture_nprocs;i++) {
                if (!child_status_out[i]) {
                        *result = False;
                }
@@ -3918,7 +4126,7 @@ static double create_procs(BOOL (*fn)(int), BOOL *result)
 static struct {
        const char *name;
        BOOL (*fn)(int);
-       unsigned flags;
+       uint_t flags;
 } torture_ops[] = {
        {"FDPASS", run_fdpasstest, 0},
        {"LOCK1",  run_locktest1,  0},
@@ -3934,13 +4142,14 @@ static struct {
        {"MAXFID", run_maxfidtest, FLAG_MULTIPROC},
        {"TORTURE",run_torture,    FLAG_MULTIPROC},
        {"NEGNOWAIT", run_negprot_nowait, 0},
-       {"NBENCH",  run_nbench, 0},
+       {"NBENCH",  torture_nbench, 0},
        {"DIR",  run_dirtest, 0},
        {"DIR1",  run_dirtest1, 0},
        {"DENY1",  torture_denytest1, 0},
        {"DENY2",  torture_denytest2, 0},
        {"TCON",  run_tcon_test, 0},
        {"TCONDEV",  run_tcon_devtype_test, 0},
+       {"VUID", run_vuidtest, 0},
 #if 0
        {"DFSBASIC", torture_dfs_basic, 0},
        {"DFSRENAME", torture_dfs_rename, 0},
@@ -3953,6 +4162,7 @@ static struct {
 #if 1
        {"OPENATTR", run_openattrtest, 0},
 #endif
+       {"DEFER_OPEN", run_deferopen, FLAG_MULTIPROC},
        {"XCOPY", run_xcopy, 0},
        {"RENAME", run_rename, 0},
        {"DELETE", run_deletetest, 0},
@@ -3960,9 +4170,11 @@ static struct {
        {"MANGLE", torture_mangle, 0},
        {"UTABLE", torture_utable, 0},
        {"CASETABLE", torture_casetable, 0},
+       {"CHARSET", torture_charset, 0},
        {"PIPE_NUMBER", run_pipe_number, 0},
        {"IOCTL",  torture_ioctl_test, 0},
        {"CHKPATH",  torture_chkpath_test, 0},
+       {"HOLDCON",  torture_holdcon, 0},
        {"RAW-QFSINFO", torture_raw_qfsinfo, 0},
        {"RAW-QFILEINFO", torture_raw_qfileinfo, 0},
        {"RAW-SFILEINFO", torture_raw_sfileinfo, 0},
@@ -3983,6 +4195,7 @@ static struct {
        {"RAW-CONTEXT", torture_raw_context, 0},
        {"RAW-RENAME", torture_raw_rename, 0},
        {"RAW-SEEK", torture_raw_seek, 0},
+       {"RAW-RAP", torture_raw_rap, 0},
        {"SCAN-TRANS2", torture_trans2_scan, 0},
        {"SCAN-NTTRANS", torture_nttrans_scan, 0},
        {"SCAN-ALIASES", torture_trans2_aliases, 0},
@@ -3992,7 +4205,20 @@ static struct {
         {"RPC-DFS", torture_rpc_dfs, 0},
         {"RPC-SPOOLSS", torture_rpc_spoolss, 0},
         {"RPC-SAMR", torture_rpc_samr, 0},
+        {"RPC-NETLOGON", torture_rpc_netlogon, 0},
+        {"RPC-SCHANNEL", torture_rpc_schannel, 0},
         {"RPC-WKSSVC", torture_rpc_wkssvc, 0},
+        {"RPC-SRVSVC", torture_rpc_srvsvc, 0},
+        {"RPC-ATSVC", torture_rpc_atsvc, 0},
+        {"RPC-EVENTLOG", torture_rpc_eventlog, 0},
+        {"RPC-EPMAPPER", torture_rpc_epmapper, 0},
+        {"RPC-WINREG", torture_rpc_winreg, 0},
+        {"RPC-MGMT", torture_rpc_mgmt, 0},
+        {"RPC-SCANNER", torture_rpc_scanner, 0},
+        {"RPC-AUTOIDL", torture_rpc_autoidl, 0},
+       {"RPC-MULTIBIND", torture_multi_bind, 0},
+       {"RPC-DRSUAPI", torture_rpc_drsuapi, 0},
+       {"NTLMSSP-SELFCHECK", torture_ntlmssp_self_check, 0},
        {NULL, NULL, 0}};
 
 
@@ -4016,16 +4242,13 @@ static BOOL run_test(const char *name)
        }
 
        for (i=0;torture_ops[i].name;i++) {
-               asprintf(&randomfname, "\\XX%x", 
-                        (unsigned)random());
-
                if (gen_fnmatch(name, torture_ops[i].name) == 0) {
                        double t;
                        matched = True;
                        printf("Running %s\n", torture_ops[i].name);
                        if (torture_ops[i].flags & FLAG_MULTIPROC) {
                                BOOL result;
-                               t = create_procs(torture_ops[i].fn, &result);
+                               t = torture_create_procs(torture_ops[i].fn, &result);
                                if (!result) { 
                                        ret = False;
                                        printf("TEST %s FAILED!\n", torture_ops[i].name);
@@ -4056,7 +4279,7 @@ static BOOL run_test(const char *name)
 */
 static void parse_user(const char *user)
 {
-       char *username, *password, *p;
+       char *username, *password = NULL, *p;
 
        username = strdup(user);
        p = strchr_m(username,'%');
@@ -4066,9 +4289,17 @@ static void parse_user(const char *user)
        }
 
        lp_set_cmdline("torture:username", username);
-       lp_set_cmdline("torture:password", password);
-}
 
+       if (password) {
+               lp_set_cmdline("torture:password", password);
+       }
+
+       if (!lp_parm_string(-1,"torture","password")) {
+               password = getpass("password:");
+
+               lp_set_cmdline("torture:password", password);
+       }
+}
 
 static void usage(void)
 {
@@ -4088,11 +4319,13 @@ static void usage(void)
        printf("\t-m maximum protocol\n");
        printf("\t-L use oplocks\n");
        printf("\t-c CLIENT.TXT   specify client load file for NBENCH\n");
+       printf("\t-t timelimit    specify NBENCH time limit (seconds)\n");
+       printf("\t-C filename     specifies file with list of UNCs for connections\n");
        printf("\t-A showall\n");
        printf("\t-p port\n");
        printf("\t-s seed\n");
        printf("\t-f max failures\n");
-       printf("\t-b bypass I/O (NBENCH)\n");
+       printf("\t-X enable dangerous tests\n");
        printf("\n\n");
 
        printf("tests are:");
@@ -4132,34 +4365,36 @@ static void usage(void)
         for(p = argv[1]; *p; p++)
           if(*p == '\\')
             *p = '/';
-       if (strncmp(argv[1], "//", 2)) {
-               usage();
-       }
 
-       host = strdup(&argv[1][2]);
-       p = strchr_m(&host[2],'/');
-       if (!p) {
-               usage();
+
+       /* see if its a RPC transport specifier */
+       if (strncmp(argv[1], "ncacn_", 6) == 0) {
+               lp_set_cmdline("torture:binding", argv[1]);
+       } else {
+               char *binding = NULL;
+
+               if (!parse_unc(argv[1], &host, &share)) {
+                       usage();
+               }
+
+               lp_set_cmdline("torture:host", host);
+               lp_set_cmdline("torture:share", share);
+               asprintf(&binding, "ncacn_np:%s", host);
+               lp_set_cmdline("torture:binding", binding);
        }
-       *p = 0;
-       share = strdup(p+1);
 
        if (getenv("LOGNAME")) {
                username = strdup(getenv("LOGNAME"));
        }
-
-       lp_set_cmdline("torture:host", host);
-       lp_set_cmdline("torture:share", share);
        lp_set_cmdline("torture:username", username);
-       lp_set_cmdline("torture:password", "");
+
 
        argc--;
        argv++;
 
        srandom(time(NULL));
 
-       while ((opt = getopt(argc, argv, "p:hW:U:n:N:O:o:e:m:Ld:Ac:ks:f:s:")) != EOF) {
+       while ((opt = getopt(argc, argv, "p:hW:U:n:N:O:o:e:m:Ld:Ac:ks:f:s:t:C:X")) != EOF) {
                switch (opt) {
                case 'p':
                        lp_set_cmdline("smb ports", optarg);
@@ -4184,7 +4419,7 @@ static void usage(void)
                        srandom(atoi(optarg));
                        break;
                case 'N':
-                       nprocs = atoi(optarg);
+                       torture_nprocs = atoi(optarg);
                        break;
                case 'o':
                        torture_numops = atoi(optarg);
@@ -4199,7 +4434,13 @@ static void usage(void)
                        torture_showall = True;
                        break;
                case 'c':
-                       client_txt = optarg;
+                       lp_set_cmdline("torture:loadfile", optarg);
+                       break;
+               case 'C':
+                       lp_set_cmdline("torture:unclist", optarg);
+                       break;
+               case 't':
+                       lp_set_cmdline("torture:timelimit", optarg);
                        break;
                case 'k':
 #ifdef HAVE_KRB5
@@ -4216,15 +4457,19 @@ static void usage(void)
                        torture_failures = atoi(optarg);
                        break;
 
+               case 'X':
+                       lp_set_cmdline("torture:dangerous", "1");
+                       break;
+
                default:
                        printf("Unknown option %c (%d)\n", (char)opt, opt);
                        usage();
                }
        }
 
-       printf("host=%s share=%s user=%s myname=%s\n", 
-              host, share, lp_parm_string(-1, "torture", "username"), 
-              lp_netbios_name());
+       if (!lp_parm_string(-1,"torture","password")) {
+               lp_set_cmdline("torture:password", "");
+       }
 
        if (argc == optind) {
                printf("You must specify a test to run, or 'ALL'\n");