gensec: clarify memory ownership for gensec_session_info() and gensec_session_key()
[samba.git] / source4 / torture / rpc / remote_pac.c
index 33034e0190ae9f71f2201f6cce9ee4e51ac97cc8..88a40b4fe4d8ff3f9014a504b5f07632865b3f97 100644 (file)
@@ -32,6 +32,7 @@
 #include "libcli/auth/libcli_auth.h"
 #include "libcli/security/security.h"
 #include "librpc/gen_ndr/ndr_netlogon_c.h"
+#include "librpc/gen_ndr/ndr_krb5pac.h"
 #include "librpc/gen_ndr/ndr_samr_c.h"
 #include "param/param.h"
 
@@ -74,7 +75,6 @@ static bool test_PACVerify(struct torture_context *tctx,
 
        struct auth_session_info *session_info;
 
-       char *tmp_dir;
        struct dcerpc_binding_handle *b = p->binding_handle;
        TALLOC_CTX *tmp_ctx = talloc_new(tctx);
        torture_assert(tctx, tmp_ctx != NULL, "talloc_new() failed");
@@ -85,9 +85,6 @@ static bool test_PACVerify(struct torture_context *tctx,
                return false;
        }
 
-       status = torture_temp_dir(tctx, "PACVerify", &tmp_dir);
-       torture_assert_ntstatus_ok(tctx, status, "torture_temp_dir failed");
-
        status = gensec_client_start(tctx, &gensec_client_context, tctx->ev, 
                                     lpcfg_gensec_settings(tctx, tctx->lp_ctx));
        torture_assert_ntstatus_ok(tctx, status, "gensec_client_start (client) failed");
@@ -132,21 +129,24 @@ static bool test_PACVerify(struct torture_context *tctx,
 
        /* Extract the PAC using Samba's code */
 
-       status = gensec_session_info(gensec_server_context, &session_info);
+       status = gensec_session_info(gensec_server_context, gensec_server_context, &session_info);
        torture_assert_ntstatus_ok(tctx, status, "gensec_session_info failed");
-       
-       pac_wrapped_struct.ChecksumLength = session_info->server_info->pac_srv_sig.signature.length;
-       pac_wrapped_struct.SignatureType = session_info->server_info->pac_kdc_sig.type;
-       pac_wrapped_struct.SignatureLength = session_info->server_info->pac_kdc_sig.signature.length;
+       torture_assert(tctx, session_info->torture != NULL, "gensec_session_info failed to fill in torture sub struct");
+       torture_assert(tctx, session_info->torture->pac_srv_sig != NULL, "pac_srv_sig not present");
+       torture_assert(tctx, session_info->torture->pac_kdc_sig != NULL, "pac_kdc_sig not present");
+
+       pac_wrapped_struct.ChecksumLength = session_info->torture->pac_srv_sig->signature.length;
+       pac_wrapped_struct.SignatureType = session_info->torture->pac_kdc_sig->type;
+       pac_wrapped_struct.SignatureLength = session_info->torture->pac_kdc_sig->signature.length;
        pac_wrapped_struct.ChecksumAndSignature = payload
                = data_blob_talloc(tmp_ctx, NULL, 
                                   pac_wrapped_struct.ChecksumLength
                                   + pac_wrapped_struct.SignatureLength);
        memcpy(&payload.data[0], 
-              session_info->server_info->pac_srv_sig.signature.data, 
+              session_info->torture->pac_srv_sig->signature.data,
               pac_wrapped_struct.ChecksumLength);
        memcpy(&payload.data[pac_wrapped_struct.ChecksumLength], 
-              session_info->server_info->pac_kdc_sig.signature.data, 
+              session_info->torture->pac_kdc_sig->signature.data,
               pac_wrapped_struct.SignatureLength);
 
        ndr_err = ndr_push_struct_blob(&pac_wrapped, tmp_ctx, &pac_wrapped_struct,
@@ -164,8 +164,8 @@ static bool test_PACVerify(struct torture_context *tctx,
        generic.identity_info.parameter_control = 0;
        generic.identity_info.logon_id_high = 0;
        generic.identity_info.logon_id_low = 0;
-       generic.identity_info.domain_name.string = session_info->server_info->domain_name;
-       generic.identity_info.account_name.string = session_info->server_info->account_name;
+       generic.identity_info.domain_name.string = session_info->info->domain_name;
+       generic.identity_info.account_name.string = session_info->info->account_name;
        generic.identity_info.workstation.string = test_machine_name;
 
        generic.package_name.string = "Kerberos";
@@ -237,22 +237,22 @@ static bool test_PACVerify(struct torture_context *tctx,
                                                         &r.out.return_authenticator->cred), 
                       "Credential chaining failed");
 
-       pac_wrapped_struct.ChecksumLength = session_info->server_info->pac_srv_sig.signature.length;
-       pac_wrapped_struct.SignatureType = session_info->server_info->pac_kdc_sig.type;
+       pac_wrapped_struct.ChecksumLength = session_info->torture->pac_srv_sig->signature.length;
+       pac_wrapped_struct.SignatureType = session_info->torture->pac_kdc_sig->type;
        
        /* Break the SignatureType */
        pac_wrapped_struct.SignatureType++;
 
-       pac_wrapped_struct.SignatureLength = session_info->server_info->pac_kdc_sig.signature.length;
+       pac_wrapped_struct.SignatureLength = session_info->torture->pac_kdc_sig->signature.length;
        pac_wrapped_struct.ChecksumAndSignature = payload
                = data_blob_talloc(tmp_ctx, NULL, 
                                   pac_wrapped_struct.ChecksumLength
                                   + pac_wrapped_struct.SignatureLength);
        memcpy(&payload.data[0], 
-              session_info->server_info->pac_srv_sig.signature.data, 
+              session_info->torture->pac_srv_sig->signature.data,
               pac_wrapped_struct.ChecksumLength);
        memcpy(&payload.data[pac_wrapped_struct.ChecksumLength], 
-              session_info->server_info->pac_kdc_sig.signature.data, 
+              session_info->torture->pac_kdc_sig->signature.data,
               pac_wrapped_struct.SignatureLength);
        
        ndr_err = ndr_push_struct_blob(&pac_wrapped, tmp_ctx, &pac_wrapped_struct,
@@ -285,19 +285,19 @@ static bool test_PACVerify(struct torture_context *tctx,
        torture_assert(tctx, netlogon_creds_client_check(creds, &r.out.return_authenticator->cred), 
                       "Credential chaining failed");
 
-       pac_wrapped_struct.ChecksumLength = session_info->server_info->pac_srv_sig.signature.length;
-       pac_wrapped_struct.SignatureType = session_info->server_info->pac_kdc_sig.type;
-       pac_wrapped_struct.SignatureLength = session_info->server_info->pac_kdc_sig.signature.length;
+       pac_wrapped_struct.ChecksumLength = session_info->torture->pac_srv_sig->signature.length;
+       pac_wrapped_struct.SignatureType = session_info->torture->pac_kdc_sig->type;
+       pac_wrapped_struct.SignatureLength = session_info->torture->pac_kdc_sig->signature.length;
 
        pac_wrapped_struct.ChecksumAndSignature = payload
                = data_blob_talloc(tmp_ctx, NULL, 
                                   pac_wrapped_struct.ChecksumLength
                                   + pac_wrapped_struct.SignatureLength);
        memcpy(&payload.data[0], 
-              session_info->server_info->pac_srv_sig.signature.data, 
+              session_info->torture->pac_srv_sig->signature.data,
               pac_wrapped_struct.ChecksumLength);
        memcpy(&payload.data[pac_wrapped_struct.ChecksumLength], 
-              session_info->server_info->pac_kdc_sig.signature.data, 
+              session_info->torture->pac_kdc_sig->signature.data,
               pac_wrapped_struct.SignatureLength);
        
        /* Break the signature length */
@@ -409,7 +409,7 @@ static bool test_S2U4Self(struct torture_context *tctx,
 
        struct auth_session_info *kinit_session_info;
        struct auth_session_info *s2u4self_session_info;
-       struct auth_serversupplied_info *netlogon_server_info;
+       struct auth_user_info_dc *netlogon_user_info_dc;
 
        struct netr_NetworkInfo ninfo;
        DATA_BLOB names_blob, chal, lm_resp, nt_resp;
@@ -418,17 +418,12 @@ static bool test_S2U4Self(struct torture_context *tctx,
 
        struct dom_sid *builtin_domain;
 
-       char *tmp_dir;
-
        TALLOC_CTX *tmp_ctx = talloc_new(tctx);
 
        torture_assert(tctx, tmp_ctx != NULL, "talloc_new() failed");
 
        /* First, do a normal Kerberos connection */
 
-       status = torture_temp_dir(tctx, "S2U4Self", &tmp_dir);
-       torture_assert_ntstatus_ok(tctx, status, "torture_temp_dir failed");
-
        status = gensec_client_start(tctx, &gensec_client_context, tctx->ev,
                                     lpcfg_gensec_settings(tctx, tctx->lp_ctx));
        torture_assert_ntstatus_ok(tctx, status, "gensec_client_start (client) failed");
@@ -473,7 +468,7 @@ static bool test_S2U4Self(struct torture_context *tctx,
 
        /* Extract the PAC using Samba's code */
 
-       status = gensec_session_info(gensec_server_context, &kinit_session_info);
+       status = gensec_session_info(gensec_server_context, gensec_server_context, &kinit_session_info);
        torture_assert_ntstatus_ok(tctx, status, "gensec_session_info failed");
 
 
@@ -481,8 +476,9 @@ static bool test_S2U4Self(struct torture_context *tctx,
 
        /* Wipe out any existing ccache */
        cli_credentials_invalidate_ccache(credentials, CRED_SPECIFIED);
-       cli_credentials_set_target_service(credentials, talloc_asprintf(tmp_ctx, "host/%s", test_machine_name));
-       cli_credentials_set_impersonate_principal(credentials, cli_credentials_get_principal(cmdline_credentials, tmp_ctx));
+       cli_credentials_set_impersonate_principal(credentials,
+                       cli_credentials_get_principal(cmdline_credentials, tmp_ctx),
+                       talloc_asprintf(tmp_ctx, "host/%s", test_machine_name));
 
        status = gensec_client_start(tctx, &gensec_client_context, tctx->ev,
                                     lpcfg_gensec_settings(tctx, tctx->lp_ctx));
@@ -530,11 +526,11 @@ static bool test_S2U4Self(struct torture_context *tctx,
        /* Don't pollute the remaining tests with the changed credentials */
        cli_credentials_invalidate_ccache(credentials, CRED_SPECIFIED);
        cli_credentials_set_target_service(credentials, NULL);
-       cli_credentials_set_impersonate_principal(credentials, NULL);
+       cli_credentials_set_impersonate_principal(credentials, NULL, NULL);
 
        /* Extract the PAC using Samba's code */
 
-       status = gensec_session_info(gensec_server_context, &s2u4self_session_info);
+       status = gensec_session_info(gensec_server_context, gensec_server_context, &s2u4self_session_info);
        torture_assert_ntstatus_ok(tctx, status, "gensec_session_info failed");
 
        cli_credentials_get_ntlm_username_domain(cmdline_credentials, tctx,
@@ -598,35 +594,32 @@ static bool test_S2U4Self(struct torture_context *tctx,
                                                         &r.out.return_authenticator->cred),
                       "Credential chaining failed");
 
-       status = make_server_info_netlogon_validation(tmp_ctx,
+       status = make_user_info_dc_netlogon_validation(tmp_ctx,
                                                      ninfo.identity_info.account_name.string,
                                                      r.in.validation_level,
                                                      r.out.validation,
-                                                     &netlogon_server_info);
-
-       torture_assert_ntstatus_ok(tctx, status, "make_server_info_netlogon_validation failed");
-
-       torture_assert_str_equal(tctx, netlogon_server_info->account_name == NULL ? "" : netlogon_server_info->account_name,
-                                kinit_session_info->server_info->account_name, "Account name differs for kinit-based PAC");
-       torture_assert_str_equal(tctx,netlogon_server_info->account_name == NULL ? "" : netlogon_server_info->account_name,
-                                s2u4self_session_info->server_info->account_name, "Account name differs for S2U4Self");
-       torture_assert_str_equal(tctx, netlogon_server_info->full_name == NULL ? "" : netlogon_server_info->full_name, kinit_session_info->server_info->full_name, "Full name differs for kinit-based PAC");
-       torture_assert_str_equal(tctx, netlogon_server_info->full_name == NULL ? "" : netlogon_server_info->full_name, s2u4self_session_info->server_info->full_name, "Full name differs for S2U4Self");
-       torture_assert(tctx, dom_sid_equal(netlogon_server_info->account_sid, kinit_session_info->server_info->account_sid), "Account SID differs for kinit-based PAC");
-       torture_assert(tctx, dom_sid_equal(netlogon_server_info->primary_group_sid, kinit_session_info->server_info->primary_group_sid), "Primary Group SID differs for kinit-based PAC");
-       torture_assert(tctx, dom_sid_equal(netlogon_server_info->account_sid, s2u4self_session_info->server_info->account_sid), "Account SID differs for S2U4Self");
-       torture_assert(tctx, dom_sid_equal(netlogon_server_info->primary_group_sid, s2u4self_session_info->server_info->primary_group_sid), "Primary Group SID differs for S2U4Self");
-       torture_assert_int_equal(tctx, netlogon_server_info->n_domain_groups, kinit_session_info->server_info->n_domain_groups, "Different numbers of domain groups for kinit-based PAC");
-       torture_assert_int_equal(tctx, netlogon_server_info->n_domain_groups, s2u4self_session_info->server_info->n_domain_groups, "Different numbers of domain groups for S2U4Self");
+                                                         true, /* This user was authenticated */
+                                                     &netlogon_user_info_dc);
+
+       torture_assert_ntstatus_ok(tctx, status, "make_user_info_dc_netlogon_validation failed");
+
+       torture_assert_str_equal(tctx, netlogon_user_info_dc->info->account_name == NULL ? "" : netlogon_user_info_dc->info->account_name,
+                                kinit_session_info->info->account_name, "Account name differs for kinit-based PAC");
+       torture_assert_str_equal(tctx,netlogon_user_info_dc->info->account_name == NULL ? "" : netlogon_user_info_dc->info->account_name,
+                                s2u4self_session_info->info->account_name, "Account name differs for S2U4Self");
+       torture_assert_str_equal(tctx, netlogon_user_info_dc->info->full_name == NULL ? "" : netlogon_user_info_dc->info->full_name, kinit_session_info->info->full_name, "Full name differs for kinit-based PAC");
+       torture_assert_str_equal(tctx, netlogon_user_info_dc->info->full_name == NULL ? "" : netlogon_user_info_dc->info->full_name, s2u4self_session_info->info->full_name, "Full name differs for S2U4Self");
+       torture_assert_int_equal(tctx, netlogon_user_info_dc->num_sids, kinit_session_info->torture->num_dc_sids, "Different numbers of domain groups for kinit-based PAC");
+       torture_assert_int_equal(tctx, netlogon_user_info_dc->num_sids, s2u4self_session_info->torture->num_dc_sids, "Different numbers of domain groups for S2U4Self");
 
        builtin_domain = dom_sid_parse_talloc(tmp_ctx, SID_BUILTIN);
 
-       for (i = 0; i < kinit_session_info->server_info->n_domain_groups; i++) {
-               torture_assert(tctx, dom_sid_equal(netlogon_server_info->domain_groups[i], kinit_session_info->server_info->domain_groups[i]), "Different domain groups for kinit-based PAC");
-               torture_assert(tctx, dom_sid_equal(netlogon_server_info->domain_groups[i], s2u4self_session_info->server_info->domain_groups[i]), "Different domain groups for S2U4Self");
-               torture_assert(tctx, !dom_sid_in_domain(builtin_domain, s2u4self_session_info->server_info->domain_groups[i]), "Returned BUILTIN domain in groups for S2U4Self");
-               torture_assert(tctx, !dom_sid_in_domain(builtin_domain, kinit_session_info->server_info->domain_groups[i]), "Returned BUILTIN domain in groups kinit-based PAC");
-               torture_assert(tctx, !dom_sid_in_domain(builtin_domain, netlogon_server_info->domain_groups[i]), "Returned BUILTIN domian in groups from NETLOGON SamLogon reply");
+       for (i = 0; i < kinit_session_info->torture->num_dc_sids; i++) {
+               torture_assert(tctx, dom_sid_equal(&netlogon_user_info_dc->sids[i], &kinit_session_info->torture->dc_sids[i]), "Different domain groups for kinit-based PAC");
+               torture_assert(tctx, dom_sid_equal(&netlogon_user_info_dc->sids[i], &s2u4self_session_info->torture->dc_sids[i]), "Different domain groups for S2U4Self");
+               torture_assert(tctx, !dom_sid_in_domain(builtin_domain, &s2u4self_session_info->torture->dc_sids[i]), "Returned BUILTIN domain in groups for S2U4Self");
+               torture_assert(tctx, !dom_sid_in_domain(builtin_domain, &kinit_session_info->torture->dc_sids[i]), "Returned BUILTIN domain in groups kinit-based PAC");
+               torture_assert(tctx, !dom_sid_in_domain(builtin_domain, &netlogon_user_info_dc->sids[i]), "Returned BUILTIN domian in groups from NETLOGON SamLogon reply");
        }
 
        return true;