don't force debug in the RPC-MGMT test

[samba.git] / source4 / torture / rpc / mgmt.c

diff --git a/source4/torture/rpc/mgmt.c b/source4/torture/rpc/mgmt.c
index 693703eb828af5dd1d9336fb9560cb490dc57aa3..2c4863be9052cad037fbbeba4d34c7d1f60f839d 100644 (file)
--- a/source4/torture/rpc/mgmt.c
+++ b/source4/torture/rpc/mgmt.c
@@ -22,6 +22,9 @@
 #include "includes.h"
 
 
+/*
+  ask the server what interface IDs are available on this endpoint
+*/
 static BOOL test_inq_if_ids(struct dcerpc_pipe *p, 
                            TALLOC_CTX *mem_ctx)
 {
@@ -35,8 +38,8 @@ static BOOL test_inq_if_ids(struct dcerpc_pipe *p,
                return False;
        }
 
-       if (r.out.status != 0) {
-               printf("inq_if_ids gave error code 0x%x\n", r.out.status);
+       if (!W_ERROR_IS_OK(r.out.result)) {
+               printf("inq_if_ids gave error code %s\n", win_errstr(r.out.result));
                return False;
        }
 
@@ -46,11 +49,15 @@ static BOOL test_inq_if_ids(struct dcerpc_pipe *p,
        }
 
        for (i=0;i<r.out.if_id_vector->count;i++) {
+               const char *uuid;
                struct dcerpc_syntax_id *id = r.out.if_id_vector->if_id[i].id;
                if (!id) continue;
-               printf("\tuuid %s  version 0x%04x:0x%04x\n",
-                      GUID_string(mem_ctx, &id->uuid),
-                      id->major_version, id->minor_version);
+
+               uuid = GUID_string(mem_ctx, &id->uuid);
+
+               printf("\tuuid %s  version 0x%08x  '%s'\n",
+                      uuid,
+                      id->if_version, idl_pipe_name(uuid, id->if_version));
        }
 
        return True;
@@ -62,7 +69,7 @@ static BOOL test_inq_stats(struct dcerpc_pipe *p,
        NTSTATUS status;
        struct mgmt_inq_stats r;
 
-       r.in.max_count = mgmt_stats_array_max_size;
+       r.in.max_count = MGMT_STATS_ARRAY_MAX_SIZE;
        r.in.unknown = 0;
 
        status = dcerpc_mgmt_inq_stats(p, mem_ctx, &r);
@@ -71,16 +78,16 @@ static BOOL test_inq_stats(struct dcerpc_pipe *p,
                return False;
        }
 
-       if (r.out.statistics.count != mgmt_stats_array_max_size) {
+       if (r.out.statistics.count != MGMT_STATS_ARRAY_MAX_SIZE) {
                printf("Unexpected array size %d\n", r.out.statistics.count);
                return False;
        }
 
        printf("\tcalls_in %6d  calls_out %6d\n\tpkts_in  %6d  pkts_out  %6d\n",
-              r.out.statistics.statistics[mgmt_stats_calls_in],
-              r.out.statistics.statistics[mgmt_stats_calls_out],
-              r.out.statistics.statistics[mgmt_stats_pkts_in],
-              r.out.statistics.statistics[mgmt_stats_pkts_out]);
+              r.out.statistics.statistics[MGMT_STATS_CALLS_IN],
+              r.out.statistics.statistics[MGMT_STATS_CALLS_OUT],
+              r.out.statistics.statistics[MGMT_STATS_PKTS_IN],
+              r.out.statistics.statistics[MGMT_STATS_PKTS_OUT]);
 
        return True;
 }
@@ -88,25 +95,31 @@ static BOOL test_inq_stats(struct dcerpc_pipe *p,
 static BOOL test_inq_princ_name(struct dcerpc_pipe *p, 
                                TALLOC_CTX *mem_ctx)
 {
-#if 0
        NTSTATUS status;
        struct mgmt_inq_princ_name r;
+       int i;
+       BOOL ret = False;
 
-       r.in.authn_proto = 1;
-       r.in.princ_name_size = 1000;
+       for (i=0;i<100;i++) {
+               r.in.authn_proto = i;  /* DCERPC_AUTH_TYPE_* */
+               r.in.princ_name_size = 100;
 
-       status = dcerpc_mgmt_inq_princ_name(p, mem_ctx, &r);
-       if (!NT_STATUS_IS_OK(status)) {
-               printf("inq_princ_name failed - %s\n", nt_errstr(status));
-               return False;
+               status = dcerpc_mgmt_inq_princ_name(p, mem_ctx, &r);
+               if (!NT_STATUS_IS_OK(status)) {
+                       continue;
+               }
+               if (W_ERROR_IS_OK(r.out.result)) {
+                       ret = True;
+                       printf("\tprinciple name for proto %u is '%s'\n", 
+                              i, r.out.princ_name);
+               }
+       }
+
+       if (!ret) {
+               printf("\tno principle names?\n");
        }
 
        return True;
-#else
-       /* this is broken */
-       printf("\tnot doing inq_princ_name\n");
-       return True;
-#endif
 }
 
 static BOOL test_is_server_listening(struct dcerpc_pipe *p, 
@@ -142,8 +155,8 @@ static BOOL test_stop_server_listening(struct dcerpc_pipe *p,
                return False;
        }
 
-       if (r.out.status != 0) {
-               printf("\tserver refused to stop listening\n");
+       if (!W_ERROR_IS_OK(r.out.result)) {
+               printf("\tserver refused to stop listening - %s\n", win_errstr(r.out.result));
        } else {
                printf("\tserver allowed a stop_server_listening request\n");
                return False;
@@ -160,11 +173,29 @@ BOOL torture_rpc_mgmt(int dummy)
        TALLOC_CTX *mem_ctx;
        BOOL ret = True;
        int i;
+       char *binding = lp_parm_string(-1, "torture", "binding");
+       struct dcerpc_binding b;
 
        mem_ctx = talloc_init("torture_rpc_mgmt");
 
-       for (i=0;dcerpc_pipes[i];i++) {
-               
+       if (!binding) {
+               printf("You must supply a ncacn binding string\n");
+               return False;
+       }
+       
+       status = dcerpc_parse_binding(mem_ctx, binding, &b);
+       if (!NT_STATUS_IS_OK(status)) {
+               printf("Failed to parse binding '%s'\n", binding);
+               return False;
+       }
+
+       b.options = talloc_array_p(mem_ctx, const char *, 2);
+       if (!b.options) {
+               return False;
+       }
+
+
+       for (i=0;dcerpc_pipes[i];i++) {         
                /* some interfaces are not mappable */
                if (dcerpc_pipes[i]->num_calls == 0 ||
                    strcmp(dcerpc_pipes[i]->name, "mgmt") == 0) {
@@ -173,6 +204,24 @@ BOOL torture_rpc_mgmt(int dummy)
 
                printf("\nTesting pipe '%s'\n", dcerpc_pipes[i]->name);
 
+               if (b.transport == NCACN_IP_TCP) {
+                       uint32 port;
+                       status = dcerpc_epm_map_tcp_port(b.host, 
+                                                        dcerpc_pipes[i]->uuid,
+                                                        dcerpc_pipes[i]->if_version,
+                                                        &port);
+                       if (!NT_STATUS_IS_OK(status)) {
+                               printf("Failed to map port for uuid %s\n", dcerpc_pipes[i]->uuid);
+                               continue;
+                       }
+                       b.options[0] = talloc_asprintf(mem_ctx, "%u", port);
+               } else {
+                       b.options[0] = dcerpc_pipes[i]->name;
+               }
+               b.options[1] = NULL;
+
+               lp_set_cmdline("torture:binding", dcerpc_binding_string(mem_ctx, &b));
+
                status = torture_rpc_connection(&p, 
                                                dcerpc_pipes[i]->name,
                                                DCERPC_MGMT_UUID,
@@ -182,8 +231,6 @@ BOOL torture_rpc_mgmt(int dummy)
                        continue;
                }
        
-               p->flags |= DCERPC_DEBUG_PRINT_BOTH;
-
                if (!test_is_server_listening(p, mem_ctx)) {
                        ret = False;
                }