CVE-2016-2115: s4:libcli/raw: pass the minprotocol to smb_raw_negotiate*()
[samba.git] / source4 / torture / basic / base.c
index ea7b6c08fd31b88faee03f01e949d901a425da45..8f51253db77536c08f88d6de0d476549a1d78f3a 100644 (file)
@@ -27,9 +27,7 @@
 #include "system/filesys.h"
 #include "system/time.h"
 #include "libcli/resolve/resolve.h"
-#include "librpc/gen_ndr/ndr_nbt.h"
 #include "lib/events/events.h"
-#include "lib/cmdline/popt_common.h"
 #include "param/param.h"
 
 
@@ -42,29 +40,36 @@ static struct smbcli_state *open_nbt_connection(struct torture_context *tctx)
        struct smbcli_state *cli;
        const char *host = torture_setting_string(tctx, "host", NULL);
        struct smbcli_options options;
+       bool ok;
 
-       make_nbt_name_client(&calling, lp_netbios_name(tctx->lp_ctx));
+       make_nbt_name_client(&calling, lpcfg_netbios_name(tctx->lp_ctx));
 
        nbt_choose_called_name(NULL, &called, host, NBT_NAME_SERVER);
 
        cli = smbcli_state_init(NULL);
        if (!cli) {
-               torture_comment(tctx, "Failed initialize smbcli_struct to connect with %s\n", host);
+               torture_result(tctx, TORTURE_FAIL, "Failed initialize smbcli_struct to connect with %s\n", host);
                goto failed;
        }
 
-       lp_smbcli_options(tctx->lp_ctx, &options);
+       lpcfg_smbcli_options(tctx->lp_ctx, &options);
 
-       if (!smbcli_socket_connect(cli, host, lp_smb_ports(tctx->lp_ctx), tctx->ev,
-                                  lp_resolve_context(tctx->lp_ctx), &options, 
-                                  lp_iconv_convenience(tctx->lp_ctx),
-                   lp_socket_options(tctx->lp_ctx))) {
-               torture_comment(tctx, "Failed to connect with %s\n", host);
+       ok = smbcli_socket_connect(cli, host, lpcfg_smb_ports(tctx->lp_ctx),
+                                  tctx->ev,
+                                  lpcfg_resolve_context(tctx->lp_ctx),
+                                  &options,
+                                  lpcfg_socket_options(tctx->lp_ctx),
+                                  &calling, &called);
+       if (!ok) {
+               torture_result(tctx, TORTURE_FAIL, "Failed to connect with %s\n", host);
                goto failed;
        }
 
-       if (!smbcli_transport_establish(cli, &calling, &called)) {
-               torture_comment(tctx, "%s rejected the session\n",host);
+       cli->transport = smbcli_transport_init(cli->sock, cli,
+                                              true, &cli->options);
+       cli->sock = NULL;
+       if (!cli->transport) {
+               torture_result(tctx, TORTURE_FAIL, "smbcli_transport_init failed\n");
                goto failed;
        }
 
@@ -179,14 +184,14 @@ static bool run_attrtest(struct torture_context *tctx,
        smbcli_close(cli->tree, fnum);
 
        if (NT_STATUS_IS_ERR(smbcli_getatr(cli->tree, fname, NULL, NULL, &t))) {
-               torture_comment(tctx, "getatr failed (%s)\n", smbcli_errstr(cli->tree));
+               torture_result(tctx, TORTURE_FAIL, "getatr failed (%s)\n", smbcli_errstr(cli->tree));
                correct = false;
        }
 
        torture_comment(tctx, "New file time is %s", ctime(&t));
 
        if (abs(t - time(NULL)) > 60*60*24*10) {
-               torture_comment(tctx, "ERROR: SMBgetatr bug. time is %s",
+               torture_result(tctx, TORTURE_FAIL, "ERROR: SMBgetatr bug. time is %s",
                       ctime(&t));
                t = time(NULL);
                correct = false;
@@ -243,19 +248,19 @@ static bool run_trans2test(struct torture_context *tctx,
                        O_RDWR | O_CREAT | O_TRUNC, DENY_NONE);
        if (NT_STATUS_IS_ERR(smbcli_qfileinfo(cli->tree, fnum, NULL, &size, &c_time, &a_time, &m_time,
                           NULL, NULL))) {
-               torture_comment(tctx, "ERROR: qfileinfo failed (%s)\n", smbcli_errstr(cli->tree));
+               torture_result(tctx, TORTURE_FAIL, "ERROR: qfileinfo failed (%s)\n", smbcli_errstr(cli->tree));
                correct = false;
        }
 
        torture_comment(tctx, "Testing NAME_INFO\n");
 
        if (NT_STATUS_IS_ERR(smbcli_qfilename(cli->tree, fnum, &pname))) {
-               torture_comment(tctx, "ERROR: qfilename failed (%s)\n", smbcli_errstr(cli->tree));
+               torture_result(tctx, TORTURE_FAIL, "ERROR: qfilename failed (%s)\n", smbcli_errstr(cli->tree));
                correct = false;
        }
 
        if (!pname || strcmp(pname, fname)) {
-               torture_comment(tctx, "qfilename gave different name? [%s] [%s]\n",
+               torture_result(tctx, TORTURE_FAIL, "qfilename gave different name? [%s] [%s]\n",
                       fname, pname);
                correct = false;
        }
@@ -266,7 +271,7 @@ static bool run_trans2test(struct torture_context *tctx,
        fnum = smbcli_open(cli->tree, fname, 
                        O_RDWR | O_CREAT | O_TRUNC, DENY_NONE);
        if (fnum == -1) {
-               torture_comment(tctx, "open of %s failed (%s)\n", fname, smbcli_errstr(cli->tree));
+               torture_result(tctx, TORTURE_FAIL, "open of %s failed (%s)\n", fname, smbcli_errstr(cli->tree));
                return false;
        }
        smbcli_close(cli->tree, fnum);
@@ -274,22 +279,24 @@ static bool run_trans2test(struct torture_context *tctx,
        torture_comment(tctx, "Checking for sticky create times\n");
 
        if (NT_STATUS_IS_ERR(smbcli_qpathinfo(cli->tree, fname, &c_time, &a_time, &m_time, &size, NULL))) {
-               torture_comment(tctx, "ERROR: qpathinfo failed (%s)\n", smbcli_errstr(cli->tree));
+               torture_result(tctx, TORTURE_FAIL, "ERROR: qpathinfo failed (%s)\n", smbcli_errstr(cli->tree));
                correct = false;
        } else {
+               time_t t = time(NULL);
+
                if (c_time != m_time) {
                        torture_comment(tctx, "create time=%s", ctime(&c_time));
                        torture_comment(tctx, "modify time=%s", ctime(&m_time));
                        torture_comment(tctx, "This system appears to have sticky create times\n");
                }
-               if (a_time % (60*60) == 0) {
+               if ((abs(a_time - t) > 60) && (a_time % (60*60) == 0)) {
                        torture_comment(tctx, "access time=%s", ctime(&a_time));
-                       torture_comment(tctx, "This system appears to set a midnight access time\n");
+                       torture_result(tctx, TORTURE_FAIL, "This system appears to set a midnight access time\n");
                        correct = false;
                }
 
-               if (abs(m_time - time(NULL)) > 60*60*24*7) {
-                       torture_comment(tctx, "ERROR: totally incorrect times - maybe word reversed? mtime=%s", ctime(&m_time));
+               if (abs(m_time - t) > 60*60*24*7) {
+                       torture_result(tctx, TORTURE_FAIL, "ERROR: totally incorrect times - maybe word reversed? mtime=%s", ctime(&m_time));
                        correct = false;
                }
        }
@@ -300,12 +307,12 @@ static bool run_trans2test(struct torture_context *tctx,
                        O_RDWR | O_CREAT | O_TRUNC, DENY_NONE);
        smbcli_close(cli->tree, fnum);
        if (NT_STATUS_IS_ERR(smbcli_qpathinfo2(cli->tree, fname, &c_time, &a_time, &m_time, &w_time, &size, NULL, NULL))) {
-               torture_comment(tctx, "ERROR: qpathinfo2 failed (%s)\n", smbcli_errstr(cli->tree));
+               torture_result(tctx, TORTURE_FAIL, "ERROR: qpathinfo2 failed (%s)\n", smbcli_errstr(cli->tree));
                correct = false;
        } else {
                if (w_time < 60*60*24*2) {
                        torture_comment(tctx, "write time=%s", ctime(&w_time));
-                       torture_comment(tctx, "This system appears to set a initial 0 write time\n");
+                       torture_result(tctx, TORTURE_FAIL, "This system appears to set a initial 0 write time\n");
                        correct = false;
                }
        }
@@ -316,12 +323,12 @@ static bool run_trans2test(struct torture_context *tctx,
        /* check if the server updates the directory modification time
            when creating a new file */
        if (NT_STATUS_IS_ERR(smbcli_mkdir(cli->tree, dname))) {
-               torture_comment(tctx, "ERROR: mkdir failed (%s)\n", smbcli_errstr(cli->tree));
+               torture_result(tctx, TORTURE_FAIL, "ERROR: mkdir failed (%s)\n", smbcli_errstr(cli->tree));
                correct = false;
        }
        sleep(3);
        if (NT_STATUS_IS_ERR(smbcli_qpathinfo2(cli->tree, "\\trans2\\", &c_time, &a_time, &m_time, &w_time, &size, NULL, NULL))) {
-               torture_comment(tctx, "ERROR: qpathinfo2 failed (%s)\n", smbcli_errstr(cli->tree));
+               torture_result(tctx, TORTURE_FAIL, "ERROR: qpathinfo2 failed (%s)\n", smbcli_errstr(cli->tree));
                correct = false;
        }
 
@@ -330,11 +337,11 @@ static bool run_trans2test(struct torture_context *tctx,
        smbcli_write(cli->tree, fnum,  0, &fnum, 0, sizeof(fnum));
        smbcli_close(cli->tree, fnum);
        if (NT_STATUS_IS_ERR(smbcli_qpathinfo2(cli->tree, "\\trans2\\", &c_time, &a_time, &m_time2, &w_time, &size, NULL, NULL))) {
-               torture_comment(tctx, "ERROR: qpathinfo2 failed (%s)\n", smbcli_errstr(cli->tree));
+               torture_result(tctx, TORTURE_FAIL, "ERROR: qpathinfo2 failed (%s)\n", smbcli_errstr(cli->tree));
                correct = false;
        } else {
                if (m_time2 == m_time) {
-                       torture_comment(tctx, "This system does not update directory modification times\n");
+                       torture_result(tctx, TORTURE_FAIL, "This system does not update directory modification times\n");
                        correct = false;
                }
        }
@@ -361,15 +368,24 @@ static bool run_negprot_nowait(struct torture_context *tctx)
        torture_comment(tctx, "Filling send buffer\n");
 
        for (i=0;i<100;i++) {
-               struct smbcli_request *req;
-               req = smb_raw_negotiate_send(cli->transport, lp_unicode(tctx->lp_ctx), PROTOCOL_NT1);
-               event_loop_once(cli->transport->socket->event.ctx);
-               if (req->state == SMBCLI_REQUEST_ERROR) {
+               struct tevent_req *req;
+               req = smb_raw_negotiate_send(cli, tctx->ev,
+                                            cli->transport,
+                                            PROTOCOL_CORE,
+                                            PROTOCOL_NT1);
+               tevent_loop_once(tctx->ev);
+               if (!tevent_req_is_in_progress(req)) {
+                       NTSTATUS status;
+
+                       status = smb_raw_negotiate_recv(req);
+                       TALLOC_FREE(req);
                        if (i > 0) {
-                               torture_comment(tctx, "Failed to fill pipe packet[%d] - %s (ignored)\n", i+1, nt_errstr(req->status));
+                               torture_comment(tctx, "Failed to fill pipe packet[%d] - %s (ignored)\n",
+                                               i+1, nt_errstr(status));
                                break;
                        } else {
-                               torture_comment(tctx, "Failed to fill pipe - %s \n", nt_errstr(req->status));
+                               torture_result(tctx, TORTURE_FAIL, "Failed to fill pipe - %s \n",
+                                               nt_errstr(status));
                                torture_close_connection(cli);
                                return false;
                        }
@@ -378,12 +394,12 @@ static bool run_negprot_nowait(struct torture_context *tctx)
 
        torture_comment(tctx, "Opening secondary connection\n");
        if (!torture_open_connection(&cli2, tctx, 1)) {
-               torture_comment(tctx, "Failed to open secondary connection\n");
+               torture_result(tctx, TORTURE_FAIL, "Failed to open secondary connection\n");
                correct = false;
        }
 
        if (!torture_close_connection(cli2)) {
-               torture_comment(tctx, "Failed to close secondary connection\n");
+               torture_result(tctx, TORTURE_FAIL, "Failed to close secondary connection\n");
                correct = false;
        }
 
@@ -415,7 +431,7 @@ static bool run_tcon_test(struct torture_context *tctx, struct smbcli_state *cli
 
        fnum1 = smbcli_open(cli->tree, fname, O_RDWR|O_CREAT|O_EXCL, DENY_NONE);
        if (fnum1 == -1) {
-               torture_comment(tctx, "open of %s failed (%s)\n", fname, smbcli_errstr(cli->tree));
+               torture_result(tctx, TORTURE_FAIL, "open of %s failed (%s)\n", fname, smbcli_errstr(cli->tree));
                return false;
        }
 
@@ -424,15 +440,14 @@ static bool run_tcon_test(struct torture_context *tctx, struct smbcli_state *cli
 
        memset(buf, 0, 4); /* init buf so valgrind won't complain */
        if (smbcli_write(cli->tree, fnum1, 0, buf, 130, 4) != 4) {
-               torture_comment(tctx, "initial write failed (%s)\n", smbcli_errstr(cli->tree));
+               torture_result(tctx, TORTURE_FAIL, "initial write failed (%s)\n", smbcli_errstr(cli->tree));
                return false;
        }
 
        tree1 = cli->tree;      /* save old tree connection */
        if (NT_STATUS_IS_ERR(smbcli_tconX(cli, share, "?????", password))) {
-               torture_comment(tctx, "%s refused 2nd tree connect (%s)\n", host,
+               torture_result(tctx, TORTURE_FAIL, "%s refused 2nd tree connect (%s)\n", host,
                           smbcli_errstr(cli->tree));
-               talloc_free(cli);
                return false;
        }
 
@@ -444,7 +459,7 @@ static bool run_tcon_test(struct torture_context *tctx, struct smbcli_state *cli
        cli->tree->tid = cnum2;
 
        if (smbcli_write(cli->tree, fnum1, 0, buf, 130, 4) == 4) {
-               torture_comment(tctx, "* server allows write with wrong TID\n");
+               torture_result(tctx, TORTURE_FAIL, "* server allows write with wrong TID\n");
                ret = false;
        } else {
                torture_comment(tctx, "server fails write with wrong TID : %s\n", smbcli_errstr(cli->tree));
@@ -455,7 +470,7 @@ static bool run_tcon_test(struct torture_context *tctx, struct smbcli_state *cli
        cli->tree->tid = cnum3;
 
        if (smbcli_write(cli->tree, fnum1, 0, buf, 130, 4) == 4) {
-               torture_comment(tctx, "* server allows write with invalid TID\n");
+               torture_result(tctx, TORTURE_FAIL, "* server allows write with invalid TID\n");
                ret = false;
        } else {
                torture_comment(tctx, "server fails write with invalid TID : %s\n", smbcli_errstr(cli->tree));
@@ -466,7 +481,7 @@ static bool run_tcon_test(struct torture_context *tctx, struct smbcli_state *cli
        cli->tree->tid = cnum1;
 
        if (smbcli_write(cli->tree, fnum1, 0, buf, 130, 4) == 4) {
-               torture_comment(tctx, "* server allows write with invalid VUID\n");
+               torture_result(tctx, TORTURE_FAIL, "* server allows write with invalid VUID\n");
                ret = false;
        } else {
                torture_comment(tctx, "server fails write with invalid VUID : %s\n", smbcli_errstr(cli->tree));
@@ -476,14 +491,14 @@ static bool run_tcon_test(struct torture_context *tctx, struct smbcli_state *cli
        cli->tree->tid = cnum1;
 
        if (NT_STATUS_IS_ERR(smbcli_close(cli->tree, fnum1))) {
-               torture_comment(tctx, "close failed (%s)\n", smbcli_errstr(cli->tree));
+               torture_result(tctx, TORTURE_FAIL, "close failed (%s)\n", smbcli_errstr(cli->tree));
                return false;
        }
 
        cli->tree->tid = cnum2;
 
        if (NT_STATUS_IS_ERR(smbcli_tdis(cli))) {
-               torture_comment(tctx, "secondary tdis failed (%s)\n", smbcli_errstr(cli->tree));
+               torture_result(tctx, TORTURE_FAIL, "secondary tdis failed (%s)\n", smbcli_errstr(cli->tree));
                return false;
        }
 
@@ -570,7 +585,7 @@ static bool rw_torture2(struct torture_context *tctx,
 
        for (i=0;i<torture_numops;i++)
        {
-               size_t buf_size = ((uint_t)random()%(sizeof(buf)-1))+ 1;
+               size_t buf_size = ((unsigned int)random()%(sizeof(buf)-1))+ 1;
                if (i % 10 == 0) {
                        if (torture_setting_bool(tctx, "progress", true)) {
                                torture_comment(tctx, "%d\r", i); fflush(stdout);
@@ -581,14 +596,14 @@ static bool rw_torture2(struct torture_context *tctx,
 
                if ((bytes_written = smbcli_write(c1->tree, fnum1, 0, buf, 0, buf_size)) != buf_size) {
                        torture_comment(tctx, "write failed (%s)\n", smbcli_errstr(c1->tree));
-                       torture_comment(tctx, "wrote %d, expected %d\n", (int)bytes_written, (int)buf_size); 
+                       torture_result(tctx, TORTURE_FAIL, "wrote %d, expected %d\n", (int)bytes_written, (int)buf_size); 
                        correct = false;
                        break;
                }
 
                if ((bytes_read = smbcli_read(c2->tree, fnum2, buf_rd, 0, buf_size)) != buf_size) {
                        torture_comment(tctx, "read failed (%s)\n", smbcli_errstr(c2->tree));
-                       torture_comment(tctx, "read %d, expected %d\n", (int)bytes_read, (int)buf_size); 
+                       torture_result(tctx, TORTURE_FAIL, "read %d, expected %d\n", (int)bytes_read, (int)buf_size); 
                        correct = false;
                        break;
                }
@@ -634,73 +649,113 @@ test the timing of deferred open requests
 static bool run_deferopen(struct torture_context *tctx, struct smbcli_state *cli, int dummy)
 {
        const char *fname = "\\defer_open_test.dat";
-       int retries=4;
        int i = 0;
        bool correct = true;
        int nsec;
        int msec;
        double sec;
+       NTSTATUS status;
 
        nsec = torture_setting_int(tctx, "sharedelay", 1000000);
        msec = nsec / 1000;
        sec = ((double)nsec) / ((double) 1000000);
 
-       if (retries <= 0) {
-               torture_comment(tctx, "failed to connect\n");
-               return false;
-       }
-
-       torture_comment(tctx, "Testing deferred open requests.\n");
+       torture_comment(tctx, "pid %u: Testing deferred open requests.\n",
+                       (unsigned)getpid());
 
        while (i < 4) {
                int fnum = -1;
+               int j = 1;
 
                do {
                        struct timeval tv;
                        tv = timeval_current();
+
+                       torture_comment(tctx,
+                                       "pid %u: create[%d,%d]...\n",
+                                       (unsigned)getpid(), i, j);
+
                        fnum = smbcli_nt_create_full(cli->tree, fname, 0, 
                                                     SEC_RIGHTS_FILE_ALL,
                                                     FILE_ATTRIBUTE_NORMAL, 
                                                     NTCREATEX_SHARE_ACCESS_NONE,
                                                     NTCREATEX_DISP_OPEN_IF, 0, 0);
+                       status = smbcli_nt_error(cli->tree);
+
+                       torture_comment(tctx,
+                                       "pid %u: create[%d,%d] gave fnum %d, status %s\n",
+                                       (unsigned)getpid(), i, j, fnum,
+                                       nt_errstr(status));
+
                        if (fnum != -1) {
                                break;
                        }
-                       if (NT_STATUS_EQUAL(smbcli_nt_error(cli->tree),NT_STATUS_SHARING_VIOLATION)) {
+
+                       if (NT_STATUS_EQUAL(status, NT_STATUS_SHARING_VIOLATION)) {
                                double e = timeval_elapsed(&tv);
-                               if (e < (0.5 * sec) || e > ((1.5 * sec) + 1)) {
-                                       torture_comment(tctx,"Timing incorrect %.2f violation 1 sec == %.2f\n",
+
+                               torture_comment(tctx, "pid %u: create[%d,%d] "
+                                               "time elapsed: %.2f (1 sec = %.2f)\n",
+                                               (unsigned)getpid(), i, j, e, sec);
+                               if (e < (0.5 * sec) || e > ((1.5 * sec) + 1.5)) {
+                                       torture_comment(tctx, "pid %u: create[%d,%d] "
+                                                       "timing incorrect\n",
+                                                       (unsigned)getpid(), i, j);
+                                       torture_result(tctx, TORTURE_FAIL, "Timing incorrect %.2f violation 1 sec == %.2f\n",
                                                e, sec);
                                        return false;
                                }
                        }
-               } while (NT_STATUS_EQUAL(smbcli_nt_error(cli->tree),NT_STATUS_SHARING_VIOLATION));
 
-               if (fnum == -1) {
-                       torture_comment(tctx,"Failed to open %s, error=%s\n", fname, smbcli_errstr(cli->tree));
-                       return false;
-               }
+                       j++;
+
+               } while (NT_STATUS_EQUAL(status, NT_STATUS_SHARING_VIOLATION));
+
+               torture_comment(tctx,
+                               "pid %u: create loop %d done: fnum %d, status %s\n",
+                               (unsigned)getpid(), i, fnum, nt_errstr(status));
+
+               torture_assert(tctx, fnum != -1,
+                              talloc_asprintf(tctx,
+                                       "pid %u: Failed to open %s, error=%s\n",
+                                       (unsigned)getpid(), fname,
+                                       smbcli_errstr(cli->tree)));
+
+               torture_comment(tctx, "pid %u: open %d\n", (unsigned)getpid(), i);
 
-               torture_comment(tctx, "pid %u open %d\n", (unsigned)getpid(), i);
+               smb_msleep(10 * msec);
+
+               status = smbcli_close(cli->tree, fnum);
+
+               torture_comment(tctx, "pid %u: open %d closed, status %s\n",
+                               (unsigned)getpid(), i, nt_errstr(status));
+
+               torture_assert(tctx, !NT_STATUS_IS_ERR(status),
+                              talloc_asprintf(tctx,
+                                              "pid %u: Failed to close %s, "
+                                              "error=%s\n",
+                                              (unsigned)getpid(), fname,
+                                              smbcli_errstr(cli->tree)));
+
+               smb_msleep(2 * msec);
 
-               msleep(10 * msec);
                i++;
-               if (NT_STATUS_IS_ERR(smbcli_close(cli->tree, fnum))) {
-                       torture_comment(tctx,"Failed to close %s, error=%s\n", fname, smbcli_errstr(cli->tree));
-                       return false;
-               }
-               msleep(2 * msec);
        }
 
        if (NT_STATUS_IS_ERR(smbcli_unlink(cli->tree, fname))) {
-               /* All until the last unlink will fail with sharing violation. */
-               if (!NT_STATUS_EQUAL(smbcli_nt_error(cli->tree),NT_STATUS_SHARING_VIOLATION)) {
-                       torture_comment(tctx, "unlink of %s failed (%s)\n", fname, smbcli_errstr(cli->tree));
+               /* All until the last unlink will fail with sharing violation
+                  but also the last request can fail since the file could have
+                  been successfully deleted by another (test) process */
+               status = smbcli_nt_error(cli->tree);
+               if ((!NT_STATUS_EQUAL(status, NT_STATUS_SHARING_VIOLATION))
+                       && (!NT_STATUS_EQUAL(status, NT_STATUS_OBJECT_NAME_NOT_FOUND))) {
+                       torture_result(tctx, TORTURE_FAIL, "unlink of %s failed (%s)\n", fname, smbcli_errstr(cli->tree));
                        correct = false;
                }
        }
 
-       torture_comment(tctx, "deferred test finished\n");
+       torture_comment(tctx, "pid %u: deferred test finished\n",
+                       (unsigned)getpid());
        return correct;
 }
 
@@ -716,7 +771,6 @@ static bool run_vuidtest(struct torture_context *tctx,
        size_t size;
        time_t c_time, a_time, m_time;
 
-       uint16_t orig_vuid;
        NTSTATUS result;
 
        smbcli_unlink(cli->tree, fname);
@@ -724,8 +778,6 @@ static bool run_vuidtest(struct torture_context *tctx,
        fnum = smbcli_open(cli->tree, fname, 
                        O_RDWR | O_CREAT | O_TRUNC, DENY_NONE);
 
-       orig_vuid = cli->session->vuid;
-
        cli->session->vuid += 1234;
 
        torture_comment(tctx, "Testing qfileinfo with wrong vuid\n");
@@ -780,7 +832,7 @@ static bool run_vuidtest(struct torture_context *tctx,
                
                if (!check_error(__location__, cli1, ERRDOS, ERRinvalidname, 
                                NT_STATUS_OBJECT_NAME_INVALID)) {
-                       torture_comment(tctx, "Error code should be NT_STATUS_OBJECT_NAME_INVALID, was %s for file with %d char\n",
+                       torture_result(tctx, TORTURE_FAIL, "Error code should be NT_STATUS_OBJECT_NAME_INVALID, was %s for file with %d char\n",
                                        smbcli_errstr(cli1->tree), i);
                        failures++;
                }
@@ -801,24 +853,26 @@ static bool run_vuidtest(struct torture_context *tctx,
        
        fnum1 = smbcli_open(cli1->tree, fname, O_RDWR|O_CREAT|O_EXCL, DENY_NONE);
        if (fnum1 == -1) {
-               torture_comment(tctx, "open of %s failed (%s)\n", fname, smbcli_errstr(cli1->tree));
+               torture_result(tctx, TORTURE_FAIL, "open of %s failed (%s)\n", fname, smbcli_errstr(cli1->tree));
                return false;
        }
 
        if (NT_STATUS_IS_ERR(smbcli_close(cli1->tree, fnum1))) {
-               torture_comment(tctx, "close2 failed (%s)\n", smbcli_errstr(cli1->tree));
+               torture_result(tctx, TORTURE_FAIL, "close2 failed (%s)\n", smbcli_errstr(cli1->tree));
                return false;
        }
        
        if (NT_STATUS_IS_ERR(smbcli_setatr(cli1->tree, fname, FILE_ATTRIBUTE_READONLY, 0))) {
-               torture_comment(tctx, "smbcli_setatr failed (%s)\n", smbcli_errstr(cli1->tree));
+               torture_result(tctx, TORTURE_FAIL,
+                       __location__ ": smbcli_setatr failed (%s)\n", smbcli_errstr(cli1->tree));
                CHECK_MAX_FAILURES(error_test1);
                return false;
        }
        
        fnum1 = smbcli_open(cli1->tree, fname, O_RDONLY, DENY_WRITE);
        if (fnum1 == -1) {
-               torture_comment(tctx, "open of %s failed (%s)\n", fname, smbcli_errstr(cli1->tree));
+               torture_result(tctx, TORTURE_FAIL,
+                       __location__ ": open of %s failed (%s)\n", fname, smbcli_errstr(cli1->tree));
                CHECK_MAX_FAILURES(error_test1);
                return false;
        }
@@ -832,6 +886,7 @@ static bool run_vuidtest(struct torture_context *tctx,
        }
        
        torture_comment(tctx, "finished open test 1\n");
+
 error_test1:
        smbcli_close(cli1->tree, fnum1);
        
@@ -841,7 +896,7 @@ error_test1:
        
        fnum1 = smbcli_open(cli1->tree, fname, O_RDONLY, DENY_WRITE);
        if (fnum1 == -1) {
-               torture_comment(tctx, "open of %s failed (%s)\n", fname, smbcli_errstr(cli1->tree));
+               torture_result(tctx, TORTURE_FAIL, "open of %s failed (%s)\n", fname, smbcli_errstr(cli1->tree));
                return false;
        }
        
@@ -854,7 +909,7 @@ error_test1:
        }
        
        if (NT_STATUS_IS_ERR(smbcli_close(cli1->tree, fnum1))) {
-               torture_comment(tctx, "close2 failed (%s)\n", smbcli_errstr(cli1->tree));
+               torture_result(tctx, TORTURE_FAIL, "close2 failed (%s)\n", smbcli_errstr(cli1->tree));
                return false;
        }
        
@@ -866,7 +921,7 @@ error_test1:
        
        fnum1 = smbcli_open(cli1->tree, fname, O_RDWR|O_CREAT|O_EXCL, DENY_NONE);
        if (fnum1 == -1) {
-               torture_comment(tctx, "(3) open (1) of %s failed (%s)\n", fname, smbcli_errstr(cli1->tree));
+               torture_result(tctx, TORTURE_FAIL, "(3) open (1) of %s failed (%s)\n", fname, smbcli_errstr(cli1->tree));
                return false;
        }
        
@@ -875,24 +930,26 @@ error_test1:
        memset(buf, '\0', 20);
 
        if (smbcli_write(cli1->tree, fnum1, 0, buf, 0, 20) != 20) {
-               torture_comment(tctx, "write failed (%s)\n", smbcli_errstr(cli1->tree));
+               torture_result(tctx, TORTURE_FAIL, "write failed (%s)\n", smbcli_errstr(cli1->tree));
                correct = false;
        }
 
        if (NT_STATUS_IS_ERR(smbcli_close(cli1->tree, fnum1))) {
-               torture_comment(tctx, "(3) close1 failed (%s)\n", smbcli_errstr(cli1->tree));
+               torture_result(tctx, TORTURE_FAIL, "(3) close1 failed (%s)\n", smbcli_errstr(cli1->tree));
                return false;
        }
        
        /* Ensure size == 20. */
        if (NT_STATUS_IS_ERR(smbcli_getatr(cli1->tree, fname, NULL, &fsize, NULL))) {
-               torture_comment(tctx, "(3) getatr failed (%s)\n", smbcli_errstr(cli1->tree));
+               torture_result(tctx, TORTURE_FAIL,
+                       __location__ ": (3) getatr failed (%s)\n", smbcli_errstr(cli1->tree));
                CHECK_MAX_FAILURES(error_test3);
                return false;
        }
        
        if (fsize != 20) {
-               torture_comment(tctx, "(3) file size != 20\n");
+               torture_result(tctx, TORTURE_FAIL,
+                       __location__ ": (3) file size != 20\n");
                CHECK_MAX_FAILURES(error_test3);
                return false;
        }
@@ -901,60 +958,70 @@ error_test1:
        
        fnum1 = smbcli_open(cli1->tree, fname, O_RDONLY|O_TRUNC, DENY_NONE);
        if (fnum1 == -1) {
-               torture_comment(tctx, "(3) open (2) of %s failed (%s)\n", fname, smbcli_errstr(cli1->tree));
+               torture_result(tctx, TORTURE_FAIL,
+                       __location__ ": (3) open (2) of %s failed (%s)\n", fname, smbcli_errstr(cli1->tree));
                CHECK_MAX_FAILURES(error_test3);
                return false;
        }
        
        if (NT_STATUS_IS_ERR(smbcli_close(cli1->tree, fnum1))) {
-               torture_comment(tctx, "close2 failed (%s)\n", smbcli_errstr(cli1->tree));
+               torture_result(tctx, TORTURE_FAIL,
+                       __location__ ": close2 failed (%s)\n", smbcli_errstr(cli1->tree));
                return false;
        }
 
        /* Ensure size == 0. */
        if (NT_STATUS_IS_ERR(smbcli_getatr(cli1->tree, fname, NULL, &fsize, NULL))) {
-               torture_comment(tctx, "(3) getatr failed (%s)\n", smbcli_errstr(cli1->tree));
+               torture_result(tctx, TORTURE_FAIL,
+                       __location__ ": (3) getatr failed (%s)\n", smbcli_errstr(cli1->tree));
                CHECK_MAX_FAILURES(error_test3);
                return false;
        }
 
        if (fsize != 0) {
-               torture_comment(tctx, "(3) file size != 0\n");
+               torture_result(tctx, TORTURE_FAIL,
+                       __location__ ": (3) file size != 0\n");
                CHECK_MAX_FAILURES(error_test3);
                return false;
        }
        torture_comment(tctx, "finished open test 3\n");
 error_test3:   
+
+       fnum1 = fnum2 = -1;
        smbcli_unlink(cli1->tree, fname);
 
 
-       torture_comment(tctx, "testing ctemp\n");
+       torture_comment(tctx, "Testing ctemp\n");
        fnum1 = smbcli_ctemp(cli1->tree, "\\", &tmp_path);
        if (fnum1 == -1) {
-               torture_comment(tctx, "ctemp failed (%s)\n", smbcli_errstr(cli1->tree));
+               torture_result(tctx, TORTURE_FAIL,
+                       __location__ ": ctemp failed (%s)\n", smbcli_errstr(cli1->tree));
                CHECK_MAX_FAILURES(error_test4);
                return false;
        }
        torture_comment(tctx, "ctemp gave path %s\n", tmp_path);
+
+error_test4:
        if (NT_STATUS_IS_ERR(smbcli_close(cli1->tree, fnum1))) {
                torture_comment(tctx, "close of temp failed (%s)\n", smbcli_errstr(cli1->tree));
        }
        if (NT_STATUS_IS_ERR(smbcli_unlink(cli1->tree, tmp_path))) {
                torture_comment(tctx, "unlink of temp failed (%s)\n", smbcli_errstr(cli1->tree));
        }
-error_test4:   
+
        /* Test the non-io opens... */
 
+       torture_comment(tctx, "Test #1 testing 2 non-io opens (no delete)\n");
+       fnum1 = fnum2 = -1;
        smbcli_setatr(cli2->tree, fname, 0, 0);
        smbcli_unlink(cli2->tree, fname);
-       
-       torture_comment(tctx, "TEST #1 testing 2 non-io opens (no delete)\n");
-       
+
        fnum1 = smbcli_nt_create_full(cli1->tree, fname, 0, SEC_FILE_READ_ATTRIBUTE, FILE_ATTRIBUTE_NORMAL,
                                   NTCREATEX_SHARE_ACCESS_NONE, NTCREATEX_DISP_OVERWRITE_IF, 0, 0);
 
        if (fnum1 == -1) {
-               torture_comment(tctx, "test 1 open 1 of %s failed (%s)\n", fname, smbcli_errstr(cli1->tree));
+               torture_result(tctx, TORTURE_FAIL,
+                       __location__ ": Test 1 open 1 of %s failed (%s)\n", fname, smbcli_errstr(cli1->tree));
                CHECK_MAX_FAILURES(error_test10);
                return false;
        }
@@ -962,31 +1029,32 @@ error_test4:
        fnum2 = smbcli_nt_create_full(cli2->tree, fname, 0, SEC_FILE_READ_ATTRIBUTE, FILE_ATTRIBUTE_NORMAL,
                                   NTCREATEX_SHARE_ACCESS_NONE, NTCREATEX_DISP_OPEN_IF, 0, 0);
        if (fnum2 == -1) {
-               torture_comment(tctx, "test 1 open 2 of %s failed (%s)\n", fname, smbcli_errstr(cli2->tree));
+               torture_result(tctx, TORTURE_FAIL,
+                       __location__ ": Test 1 open 2 of %s failed (%s)\n", fname, smbcli_errstr(cli2->tree));
                CHECK_MAX_FAILURES(error_test10);
                return false;
        }
 
+       torture_comment(tctx, "non-io open test #1 passed.\n");
+error_test10:
+
        if (NT_STATUS_IS_ERR(smbcli_close(cli1->tree, fnum1))) {
-               torture_comment(tctx, "test 1 close 1 of %s failed (%s)\n", fname, smbcli_errstr(cli1->tree));
-               return false;
+               torture_comment(tctx, "Test 1 close 1 of %s failed (%s)\n", fname, smbcli_errstr(cli1->tree));
        }
        if (NT_STATUS_IS_ERR(smbcli_close(cli2->tree, fnum2))) {
-               torture_comment(tctx, "test 1 close 2 of %s failed (%s)\n", fname, smbcli_errstr(cli2->tree));
-               return false;
+               torture_comment(tctx, "Test 1 close 2 of %s failed (%s)\n", fname, smbcli_errstr(cli2->tree));
        }
 
-       torture_comment(tctx, "non-io open test #1 passed.\n");
-error_test10:
+       torture_comment(tctx, "Test #2 testing 2 non-io opens (first with delete)\n");
+       fnum1 = fnum2 = -1;
        smbcli_unlink(cli1->tree, fname);
 
-       torture_comment(tctx, "TEST #2 testing 2 non-io opens (first with delete)\n");
-       
        fnum1 = smbcli_nt_create_full(cli1->tree, fname, 0, SEC_STD_DELETE|SEC_FILE_READ_ATTRIBUTE, FILE_ATTRIBUTE_NORMAL,
                                   NTCREATEX_SHARE_ACCESS_NONE, NTCREATEX_DISP_OVERWRITE_IF, 0, 0);
 
        if (fnum1 == -1) {
-               torture_comment(tctx, "test 2 open 1 of %s failed (%s)\n", fname, smbcli_errstr(cli1->tree));
+               torture_result(tctx, TORTURE_FAIL,
+                       __location__ ": Test 2 open 1 of %s failed (%s)\n", fname, smbcli_errstr(cli1->tree));
                CHECK_MAX_FAILURES(error_test20);
                return false;
        }
@@ -995,31 +1063,33 @@ error_test10:
                                   NTCREATEX_SHARE_ACCESS_NONE, NTCREATEX_DISP_OPEN_IF, 0, 0);
 
        if (fnum2 == -1) {
-               torture_comment(tctx, "test 2 open 2 of %s failed (%s)\n", fname, smbcli_errstr(cli2->tree));
+               torture_result(tctx, TORTURE_FAIL,
+                       __location__ ": Test 2 open 2 of %s failed (%s)\n", fname, smbcli_errstr(cli2->tree));
                CHECK_MAX_FAILURES(error_test20);
                return false;
        }
 
+       torture_comment(tctx, "non-io open test #2 passed.\n");
+error_test20:
+
        if (NT_STATUS_IS_ERR(smbcli_close(cli1->tree, fnum1))) {
-               torture_comment(tctx, "test 1 close 1 of %s failed (%s)\n", fname, smbcli_errstr(cli1->tree));
-               return false;
+               torture_comment(tctx, "Test 1 close 1 of %s failed (%s)\n", fname, smbcli_errstr(cli1->tree));
        }
        if (NT_STATUS_IS_ERR(smbcli_close(cli2->tree, fnum2))) {
-               torture_comment(tctx, "test 1 close 2 of %s failed (%s)\n", fname, smbcli_errstr(cli1->tree));
-               return false;
+               torture_comment(tctx, "Test 1 close 2 of %s failed (%s)\n", fname, smbcli_errstr(cli1->tree));
        }
 
-       torture_comment(tctx, "non-io open test #2 passed.\n");
-error_test20:
+       fnum1 = fnum2 = -1;
        smbcli_unlink(cli1->tree, fname);
 
-       torture_comment(tctx, "TEST #3 testing 2 non-io opens (second with delete)\n");
-       
+       torture_comment(tctx, "Test #3 testing 2 non-io opens (second with delete)\n");
+
        fnum1 = smbcli_nt_create_full(cli1->tree, fname, 0, SEC_FILE_READ_ATTRIBUTE, FILE_ATTRIBUTE_NORMAL,
                                   NTCREATEX_SHARE_ACCESS_NONE, NTCREATEX_DISP_OVERWRITE_IF, 0, 0);
 
        if (fnum1 == -1) {
-               torture_comment(tctx, "test 3 open 1 of %s failed (%s)\n", fname, smbcli_errstr(cli1->tree));
+               torture_result(tctx, TORTURE_FAIL,
+                       __location__ ": Test 3 open 1 of %s failed (%s)\n", fname, smbcli_errstr(cli1->tree));
                CHECK_MAX_FAILURES(error_test30);
                return false;
        }
@@ -1028,31 +1098,32 @@ error_test20:
                                   NTCREATEX_SHARE_ACCESS_NONE, NTCREATEX_DISP_OPEN_IF, 0, 0);
 
        if (fnum2 == -1) {
-               torture_comment(tctx, "test 3 open 2 of %s failed (%s)\n", fname, smbcli_errstr(cli2->tree));
+               torture_result(tctx, TORTURE_FAIL,
+                       __location__ ": Test 3 open 2 of %s failed (%s)\n", fname, smbcli_errstr(cli2->tree));
                CHECK_MAX_FAILURES(error_test30);
                return false;
        }
 
+       torture_comment(tctx, "non-io open test #3 passed.\n");
+error_test30:
+
        if (NT_STATUS_IS_ERR(smbcli_close(cli1->tree, fnum1))) {
-               torture_comment(tctx, "test 3 close 1 of %s failed (%s)\n", fname, smbcli_errstr(cli1->tree));
-               return false;
+               torture_comment(tctx, "Test 3 close 1 of %s failed (%s)\n", fname, smbcli_errstr(cli1->tree));
        }
        if (NT_STATUS_IS_ERR(smbcli_close(cli2->tree, fnum2))) {
-               torture_comment(tctx, "test 3 close 2 of %s failed (%s)\n", fname, smbcli_errstr(cli2->tree));
-               return false;
+               torture_comment(tctx, "Test 3 close 2 of %s failed (%s)\n", fname, smbcli_errstr(cli2->tree));
        }
 
-       torture_comment(tctx, "non-io open test #3 passed.\n");
-error_test30:
+       torture_comment(tctx, "Test #4 testing 2 non-io opens (both with delete)\n");
+       fnum1 = fnum2 = -1;
        smbcli_unlink(cli1->tree, fname);
 
-       torture_comment(tctx, "TEST #4 testing 2 non-io opens (both with delete)\n");
-       
        fnum1 = smbcli_nt_create_full(cli1->tree, fname, 0, SEC_STD_DELETE|SEC_FILE_READ_ATTRIBUTE, FILE_ATTRIBUTE_NORMAL,
                                   NTCREATEX_SHARE_ACCESS_NONE, NTCREATEX_DISP_OVERWRITE_IF, 0, 0);
 
        if (fnum1 == -1) {
-               torture_comment(tctx, "test 4 open 1 of %s failed (%s)\n", fname, smbcli_errstr(cli1->tree));
+               torture_result(tctx, TORTURE_FAIL,
+                       __location__ ": Test 4 open 1 of %s failed (%s)\n", fname, smbcli_errstr(cli1->tree));
                CHECK_MAX_FAILURES(error_test40);
                return false;
        }
@@ -1061,29 +1132,34 @@ error_test30:
                                   NTCREATEX_SHARE_ACCESS_NONE, NTCREATEX_DISP_OPEN_IF, 0, 0);
 
        if (fnum2 != -1) {
-               torture_comment(tctx, "test 4 open 2 of %s SUCCEEDED - should have failed (%s)\n", fname, smbcli_errstr(cli2->tree));
+               torture_result(tctx, TORTURE_FAIL,
+                       __location__ ": Test 4 open 2 of %s SUCCEEDED - should have failed (%s)\n", fname, smbcli_errstr(cli2->tree));
                CHECK_MAX_FAILURES(error_test40);
                return false;
        }
 
-       torture_comment(tctx, "test 4 open 2 of %s gave %s (correct error should be %s)\n", fname, smbcli_errstr(cli2->tree), "sharing violation");
+       torture_comment(tctx, "Test 4 open 2 of %s gave %s (correct error should be %s)\n", fname, smbcli_errstr(cli2->tree), "sharing violation");
+
+       torture_comment(tctx, "non-io open test #4 passed.\n");
+error_test40:
 
        if (NT_STATUS_IS_ERR(smbcli_close(cli1->tree, fnum1))) {
-               torture_comment(tctx, "test 4 close 1 of %s failed (%s)\n", fname, smbcli_errstr(cli1->tree));
-               return false;
+               torture_comment(tctx, "Test 4 close 1 of %s failed (%s)\n", fname, smbcli_errstr(cli1->tree));
+       }
+       if (fnum2 != -1 && NT_STATUS_IS_ERR(smbcli_close(cli2->tree, fnum2))) {
+               torture_comment(tctx, "Test 4 close 2 of %s failed (%s)\n", fname, smbcli_errstr(cli2->tree));
        }
 
-       torture_comment(tctx, "non-io open test #4 passed.\n");
-error_test40:
+       torture_comment(tctx, "Test #5 testing 2 non-io opens (both with delete - both with file share delete)\n");
+       fnum1 = fnum2 = -1;
        smbcli_unlink(cli1->tree, fname);
 
-       torture_comment(tctx, "TEST #5 testing 2 non-io opens (both with delete - both with file share delete)\n");
-       
        fnum1 = smbcli_nt_create_full(cli1->tree, fname, 0, SEC_STD_DELETE|SEC_FILE_READ_ATTRIBUTE, FILE_ATTRIBUTE_NORMAL,
                                   NTCREATEX_SHARE_ACCESS_DELETE, NTCREATEX_DISP_OVERWRITE_IF, 0, 0);
 
        if (fnum1 == -1) {
-               torture_comment(tctx, "test 5 open 1 of %s failed (%s)\n", fname, smbcli_errstr(cli1->tree));
+               torture_result(tctx, TORTURE_FAIL,
+                       __location__ ": Test 5 open 1 of %s failed (%s)\n", fname, smbcli_errstr(cli1->tree));
                CHECK_MAX_FAILURES(error_test50);
                return false;
        }
@@ -1092,32 +1168,33 @@ error_test40:
                                   NTCREATEX_SHARE_ACCESS_DELETE, NTCREATEX_DISP_OPEN_IF, 0, 0);
 
        if (fnum2 == -1) {
-               torture_comment(tctx, "test 5 open 2 of %s failed (%s)\n", fname, smbcli_errstr(cli2->tree));
+               torture_result(tctx, TORTURE_FAIL,
+                       __location__ ": Test 5 open 2 of %s failed (%s)\n", fname, smbcli_errstr(cli2->tree));
                CHECK_MAX_FAILURES(error_test50);
                return false;
        }
 
+       torture_comment(tctx, "non-io open test #5 passed.\n");
+error_test50:
+
        if (NT_STATUS_IS_ERR(smbcli_close(cli1->tree, fnum1))) {
-               torture_comment(tctx, "test 5 close 1 of %s failed (%s)\n", fname, smbcli_errstr(cli1->tree));
-               return false;
+               torture_comment(tctx, "Test 5 close 1 of %s failed (%s)\n", fname, smbcli_errstr(cli1->tree));
        }
 
        if (NT_STATUS_IS_ERR(smbcli_close(cli2->tree, fnum2))) {
-               torture_comment(tctx, "test 5 close 2 of %s failed (%s)\n", fname, smbcli_errstr(cli2->tree));
-               return false;
+               torture_comment(tctx, "Test 5 close 2 of %s failed (%s)\n", fname, smbcli_errstr(cli2->tree));
        }
 
-       torture_comment(tctx, "non-io open test #5 passed.\n");
-error_test50:
-       torture_comment(tctx, "TEST #6 testing 1 non-io open, one io open\n");
-       
+       torture_comment(tctx, "Test #6 testing 1 non-io open, one io open\n");
+       fnum1 = fnum2 = -1;
        smbcli_unlink(cli1->tree, fname);
 
        fnum1 = smbcli_nt_create_full(cli1->tree, fname, 0, SEC_FILE_READ_DATA, FILE_ATTRIBUTE_NORMAL,
                                   NTCREATEX_SHARE_ACCESS_NONE, NTCREATEX_DISP_OVERWRITE_IF, 0, 0);
 
        if (fnum1 == -1) {
-               torture_comment(tctx, "test 6 open 1 of %s failed (%s)\n", fname, smbcli_errstr(cli1->tree));
+               torture_result(tctx, TORTURE_FAIL,
+                       __location__ ": Test 6 open 1 of %s failed (%s)\n", fname, smbcli_errstr(cli1->tree));
                CHECK_MAX_FAILURES(error_test60);
                return false;
        }
@@ -1126,32 +1203,33 @@ error_test50:
                                   NTCREATEX_SHARE_ACCESS_READ, NTCREATEX_DISP_OPEN_IF, 0, 0);
 
        if (fnum2 == -1) {
-               torture_comment(tctx, "test 6 open 2 of %s failed (%s)\n", fname, smbcli_errstr(cli2->tree));
+               torture_result(tctx, TORTURE_FAIL,
+                       __location__ ": Test 6 open 2 of %s failed (%s)\n", fname, smbcli_errstr(cli2->tree));
                CHECK_MAX_FAILURES(error_test60);
                return false;
        }
 
+       torture_comment(tctx, "non-io open test #6 passed.\n");
+error_test60:
+
        if (NT_STATUS_IS_ERR(smbcli_close(cli1->tree, fnum1))) {
-               torture_comment(tctx, "test 6 close 1 of %s failed (%s)\n", fname, smbcli_errstr(cli1->tree));
-               return false;
+               torture_comment(tctx, "Test 6 close 1 of %s failed (%s)\n", fname, smbcli_errstr(cli1->tree));
        }
 
        if (NT_STATUS_IS_ERR(smbcli_close(cli2->tree, fnum2))) {
-               torture_comment(tctx, "test 6 close 2 of %s failed (%s)\n", fname, smbcli_errstr(cli2->tree));
-               return false;
+               torture_comment(tctx, "Test 6 close 2 of %s failed (%s)\n", fname, smbcli_errstr(cli2->tree));
        }
 
-       torture_comment(tctx, "non-io open test #6 passed.\n");
-error_test60:
-       torture_comment(tctx, "TEST #7 testing 1 non-io open, one io open with delete\n");
-
+       torture_comment(tctx, "Test #7 testing 1 non-io open, one io open with delete\n");
+       fnum1 = fnum2 = -1;
        smbcli_unlink(cli1->tree, fname);
 
        fnum1 = smbcli_nt_create_full(cli1->tree, fname, 0, SEC_FILE_READ_DATA, FILE_ATTRIBUTE_NORMAL,
                                   NTCREATEX_SHARE_ACCESS_NONE, NTCREATEX_DISP_OVERWRITE_IF, 0, 0);
 
        if (fnum1 == -1) {
-               torture_comment(tctx, "test 7 open 1 of %s failed (%s)\n", fname, smbcli_errstr(cli1->tree));
+               torture_result(tctx, TORTURE_FAIL,
+                       __location__ ": Test 7 open 1 of %s failed (%s)\n", fname, smbcli_errstr(cli1->tree));
                CHECK_MAX_FAILURES(error_test70);
                return false;
        }
@@ -1160,29 +1238,31 @@ error_test60:
                                   NTCREATEX_SHARE_ACCESS_READ|NTCREATEX_SHARE_ACCESS_DELETE, NTCREATEX_DISP_OPEN_IF, 0, 0);
 
        if (fnum2 != -1) {
-               torture_comment(tctx, "test 7 open 2 of %s SUCCEEDED - should have failed (%s)\n", fname, smbcli_errstr(cli2->tree));
+               torture_result(tctx, TORTURE_FAIL,
+                       __location__ ": Test 7 open 2 of %s SUCCEEDED - should have failed (%s)\n", fname, smbcli_errstr(cli2->tree));
                CHECK_MAX_FAILURES(error_test70);
                return false;
        }
 
-       torture_comment(tctx, "test 7 open 2 of %s gave %s (correct error should be %s)\n", fname, smbcli_errstr(cli2->tree), "sharing violation");
-
-       if (NT_STATUS_IS_ERR(smbcli_close(cli1->tree, fnum1))) {
-               torture_comment(tctx, "test 7 close 1 of %s failed (%s)\n", fname, smbcli_errstr(cli1->tree));
-               return false;
-       }
+       torture_comment(tctx, "Test 7 open 2 of %s gave %s (correct error should be %s)\n", fname, smbcli_errstr(cli2->tree), "sharing violation");
 
        torture_comment(tctx, "non-io open test #7 passed.\n");
-
 error_test70:
 
-       torture_comment(tctx, "TEST #8 testing one normal open, followed by lock, followed by open with truncate\n");
+       if (NT_STATUS_IS_ERR(smbcli_close(cli1->tree, fnum1))) {
+               torture_comment(tctx, "Test 7 close 1 of %s failed (%s)\n", fname, smbcli_errstr(cli1->tree));
+       }
+       if (fnum2 != -1 && NT_STATUS_IS_ERR(smbcli_close(cli2->tree, fnum2))) {
+               torture_comment(tctx, "Test 7 close 2 of %s failed (%s)\n", fname, smbcli_errstr(cli2->tree));
+       }
 
+       torture_comment(tctx, "Test #8 testing one normal open, followed by lock, followed by open with truncate\n");
+       fnum1 = fnum2 = -1;
        smbcli_unlink(cli1->tree, fname);
 
        fnum1 = smbcli_open(cli1->tree, fname, O_RDWR|O_CREAT, DENY_NONE);
        if (fnum1 == -1) {
-               torture_comment(tctx, "(8) open (1) of %s failed (%s)\n", fname, smbcli_errstr(cli1->tree));
+               torture_result(tctx, TORTURE_FAIL, "(8) open (1) of %s failed (%s)\n", fname, smbcli_errstr(cli1->tree));
                return false;
        }
        
@@ -1191,56 +1271,61 @@ error_test70:
        memset(buf, '\0', 20);
 
        if (smbcli_write(cli1->tree, fnum1, 0, buf, 0, 20) != 20) {
-               torture_comment(tctx, "(8) write failed (%s)\n", smbcli_errstr(cli1->tree));
+               torture_result(tctx, TORTURE_FAIL, "(8) write failed (%s)\n", smbcli_errstr(cli1->tree));
                correct = false;
        }
 
        /* Ensure size == 20. */
        if (NT_STATUS_IS_ERR(smbcli_getatr(cli1->tree, fname, NULL, &fsize, NULL))) {
-               torture_comment(tctx, "(8) getatr (1) failed (%s)\n", smbcli_errstr(cli1->tree));
+               torture_result(tctx, TORTURE_FAIL,
+                       __location__ ": (8) getatr (1) failed (%s)\n", smbcli_errstr(cli1->tree));
                CHECK_MAX_FAILURES(error_test80);
                return false;
        }
        
        if (fsize != 20) {
-               torture_comment(tctx, "(8) file size != 20\n");
+               torture_result(tctx, TORTURE_FAIL,
+                       __location__ ": (8) file size %lu != 20\n", (unsigned long)fsize);
                CHECK_MAX_FAILURES(error_test80);
                return false;
        }
 
        /* Get an exclusive lock on the open file. */
        if (NT_STATUS_IS_ERR(smbcli_lock(cli1->tree, fnum1, 0, 4, 0, WRITE_LOCK))) {
-               torture_comment(tctx, "(8) lock1 failed (%s)\n", smbcli_errstr(cli1->tree));
+               torture_result(tctx, TORTURE_FAIL,
+                       __location__ ": (8) lock1 failed (%s)\n", smbcli_errstr(cli1->tree));
                CHECK_MAX_FAILURES(error_test80);
                return false;
        }
 
        fnum2 = smbcli_open(cli1->tree, fname, O_RDWR|O_TRUNC, DENY_NONE);
        if (fnum1 == -1) {
-               torture_comment(tctx, "(8) open (2) of %s with truncate failed (%s)\n", fname, smbcli_errstr(cli1->tree));
+               torture_result(tctx, TORTURE_FAIL, "(8) open (2) of %s with truncate failed (%s)\n", fname, smbcli_errstr(cli1->tree));
                return false;
        }
 
        /* Ensure size == 0. */
        if (NT_STATUS_IS_ERR(smbcli_getatr(cli1->tree, fname, NULL, &fsize, NULL))) {
-               torture_comment(tctx, "(8) getatr (2) failed (%s)\n", smbcli_errstr(cli1->tree));
+               torture_result(tctx, TORTURE_FAIL,
+                       __location__ ": (8) getatr (2) failed (%s)\n", smbcli_errstr(cli1->tree));
                CHECK_MAX_FAILURES(error_test80);
                return false;
        }
        
        if (fsize != 0) {
-               torture_comment(tctx, "(8) file size != 0\n");
+               torture_result(tctx, TORTURE_FAIL,
+                       __location__ ": (8) file size %lu != 0\n", (unsigned long)fsize);
                CHECK_MAX_FAILURES(error_test80);
                return false;
        }
 
        if (NT_STATUS_IS_ERR(smbcli_close(cli1->tree, fnum1))) {
-               torture_comment(tctx, "(8) close1 failed (%s)\n", smbcli_errstr(cli1->tree));
+               torture_result(tctx, TORTURE_FAIL, "(8) close1 failed (%s)\n", smbcli_errstr(cli1->tree));
                return false;
        }
        
        if (NT_STATUS_IS_ERR(smbcli_close(cli1->tree, fnum2))) {
-               torture_comment(tctx, "(8) close1 failed (%s)\n", smbcli_errstr(cli1->tree));
+               torture_result(tctx, TORTURE_FAIL, "(8) close1 failed (%s)\n", smbcli_errstr(cli1->tree));
                return false;
        }
        
@@ -1250,7 +1335,7 @@ error_test80:
 
        smbcli_unlink(cli1->tree, fname);
 
-       return correct;
+       return failures > 0 ? false : correct;
 }
 
 /* FIRST_DESIRED_ACCESS   0xf019f */
@@ -1359,8 +1444,6 @@ static bool run_iometer(struct torture_context *tctx,
                                       smbcli_errstr(cli->tree)));
                }
        }
-
-       return true;
 }
 
 /**
@@ -1380,29 +1463,29 @@ static bool torture_chkpath_test(struct torture_context *tctx,
        smbcli_rmdir(cli->tree, "\\chkpath.dir");
 
        if (NT_STATUS_IS_ERR(smbcli_mkdir(cli->tree, "\\chkpath.dir"))) {
-               torture_comment(tctx, "mkdir1 failed : %s\n", smbcli_errstr(cli->tree));
+               torture_result(tctx, TORTURE_FAIL, "mkdir1 failed : %s\n", smbcli_errstr(cli->tree));
                return false;
        }
 
        if (NT_STATUS_IS_ERR(smbcli_mkdir(cli->tree, "\\chkpath.dir\\dir2"))) {
-               torture_comment(tctx, "mkdir2 failed : %s\n", smbcli_errstr(cli->tree));
+               torture_result(tctx, TORTURE_FAIL, "mkdir2 failed : %s\n", smbcli_errstr(cli->tree));
                return false;
        }
 
        fnum = smbcli_open(cli->tree, "\\chkpath.dir\\foo.txt", O_RDWR|O_CREAT|O_EXCL, DENY_NONE);
        if (fnum == -1) {
-               torture_comment(tctx, "open1 failed (%s)\n", smbcli_errstr(cli->tree));
+               torture_result(tctx, TORTURE_FAIL, "open1 failed (%s)\n", smbcli_errstr(cli->tree));
                return false;
        }
        smbcli_close(cli->tree, fnum);
 
        if (NT_STATUS_IS_ERR(smbcli_chkpath(cli->tree, "\\chkpath.dir"))) {
-               torture_comment(tctx, "chkpath1 failed: %s\n", smbcli_errstr(cli->tree));
+               torture_result(tctx, TORTURE_FAIL, "chkpath1 failed: %s\n", smbcli_errstr(cli->tree));
                ret = false;
        }
 
        if (NT_STATUS_IS_ERR(smbcli_chkpath(cli->tree, "\\chkpath.dir\\dir2"))) {
-               torture_comment(tctx, "chkpath2 failed: %s\n", smbcli_errstr(cli->tree));
+               torture_result(tctx, TORTURE_FAIL, "chkpath2 failed: %s\n", smbcli_errstr(cli->tree));
                ret = false;
        }
 
@@ -1410,7 +1493,7 @@ static bool torture_chkpath_test(struct torture_context *tctx,
                ret = check_error(__location__, cli, ERRDOS, ERRbadpath, 
                                  NT_STATUS_NOT_A_DIRECTORY);
        } else {
-               torture_comment(tctx, "* chkpath on a file should fail\n");
+               torture_result(tctx, TORTURE_FAIL, "* chkpath on a file should fail\n");
                ret = false;
        }
 
@@ -1418,7 +1501,7 @@ static bool torture_chkpath_test(struct torture_context *tctx,
                ret = check_error(__location__, cli, ERRDOS, ERRbadpath, 
                                  NT_STATUS_OBJECT_NAME_NOT_FOUND);
        } else {
-               torture_comment(tctx, "* chkpath on a non existent file should fail\n");
+               torture_result(tctx, TORTURE_FAIL, "* chkpath on a non existent file should fail\n");
                ret = false;
        }
 
@@ -1426,7 +1509,7 @@ static bool torture_chkpath_test(struct torture_context *tctx,
                ret = check_error(__location__, cli, ERRDOS, ERRbadpath, 
                                  NT_STATUS_OBJECT_PATH_NOT_FOUND);
        } else {
-               torture_comment(tctx, "* chkpath on a non existent component should fail\n");
+               torture_result(tctx, TORTURE_FAIL, "* chkpath on a non existent component should fail\n");
                ret = false;
        }
 
@@ -1444,6 +1527,7 @@ static bool torture_chkpath_test(struct torture_context *tctx,
 static bool torture_samba3_errorpaths(struct torture_context *tctx)
 {
        bool nt_status_support;
+       bool client_ntlmv2_auth;
        struct smbcli_state *cli_nt = NULL, *cli_dos = NULL;
        bool result = false;
        int fnum;
@@ -1452,10 +1536,15 @@ static bool torture_samba3_errorpaths(struct torture_context *tctx)
        union smb_open io;
        NTSTATUS status;
 
-       nt_status_support = lp_nt_status_support(tctx->lp_ctx);
+       nt_status_support = lpcfg_nt_status_support(tctx->lp_ctx);
+       client_ntlmv2_auth = lpcfg_client_ntlmv2_auth(tctx->lp_ctx);
 
-       if (!lp_set_cmdline(tctx->lp_ctx, "nt status support", "yes")) {
-               torture_comment(tctx, "Could not set 'nt status support = yes'\n");
+       if (!lpcfg_set_cmdline(tctx->lp_ctx, "nt status support", "yes")) {
+               torture_result(tctx, TORTURE_FAIL, "Could not set 'nt status support = yes'\n");
+               goto fail;
+       }
+       if (!lpcfg_set_cmdline(tctx->lp_ctx, "client ntlmv2 auth", "yes")) {
+               torture_result(tctx, TORTURE_FAIL, "Could not set 'client ntlmv2 auth = yes'\n");
                goto fail;
        }
 
@@ -1463,8 +1552,12 @@ static bool torture_samba3_errorpaths(struct torture_context *tctx)
                goto fail;
        }
 
-       if (!lp_set_cmdline(tctx->lp_ctx, "nt status support", "no")) {
-               torture_comment(tctx, "Could not set 'nt status support = yes'\n");
+       if (!lpcfg_set_cmdline(tctx->lp_ctx, "nt status support", "no")) {
+               torture_result(tctx, TORTURE_FAIL, "Could not set 'nt status support = no'\n");
+               goto fail;
+       }
+       if (!lpcfg_set_cmdline(tctx->lp_ctx, "client ntlmv2 auth", "no")) {
+               torture_result(tctx, TORTURE_FAIL, "Could not set 'client ntlmv2 auth = no'\n");
                goto fail;
        }
 
@@ -1472,9 +1565,14 @@ static bool torture_samba3_errorpaths(struct torture_context *tctx)
                goto fail;
        }
 
-       if (!lp_set_cmdline(tctx->lp_ctx, "nt status support",
+       if (!lpcfg_set_cmdline(tctx->lp_ctx, "nt status support",
                            nt_status_support ? "yes":"no")) {
-               torture_comment(tctx, "Could not reset 'nt status support = yes'");
+               torture_result(tctx, TORTURE_FAIL, "Could not reset 'nt status support'");
+               goto fail;
+       }
+       if (!lpcfg_set_cmdline(tctx->lp_ctx, "client ntlmv2 auth",
+                              client_ntlmv2_auth ? "yes":"no")) {
+               torture_result(tctx, TORTURE_FAIL, "Could not reset 'client ntlmv2 auth'");
                goto fail;
        }
 
@@ -1482,14 +1580,14 @@ static bool torture_samba3_errorpaths(struct torture_context *tctx)
        smbcli_rmdir(cli_nt->tree, dname);
 
        if (!NT_STATUS_IS_OK(smbcli_mkdir(cli_nt->tree, dname))) {
-               torture_comment(tctx, "smbcli_mkdir(%s) failed: %s\n", dname,
+               torture_result(tctx, TORTURE_FAIL, "smbcli_mkdir(%s) failed: %s\n", dname,
                       smbcli_errstr(cli_nt->tree));
                goto fail;
        }
 
        io.generic.level = RAW_OPEN_NTCREATEX;
        io.ntcreatex.in.flags = NTCREATEX_FLAGS_EXTENDED;
-       io.ntcreatex.in.root_fid = 0;
+       io.ntcreatex.in.root_fid.fnum = 0;
        io.ntcreatex.in.access_mask = SEC_RIGHTS_FILE_ALL;
        io.ntcreatex.in.alloc_size = 1024*1024;
        io.ntcreatex.in.file_attr = FILE_ATTRIBUTE_DIRECTORY;
@@ -1502,14 +1600,14 @@ static bool torture_samba3_errorpaths(struct torture_context *tctx)
 
        status = smb_raw_open(cli_nt->tree, tctx, &io);
        if (!NT_STATUS_EQUAL(status, NT_STATUS_OBJECT_NAME_COLLISION)) {
-               torture_comment(tctx, "(%s) incorrect status %s should be %s\n",
+               torture_result(tctx, TORTURE_FAIL, "(%s) incorrect status %s should be %s\n",
                       __location__, nt_errstr(status),
                       nt_errstr(NT_STATUS_OBJECT_NAME_COLLISION));
                goto fail;
        }
        status = smb_raw_open(cli_dos->tree, tctx, &io);
        if (!NT_STATUS_EQUAL(status, NT_STATUS_DOS(ERRDOS, ERRfilexists))) {
-               torture_comment(tctx, "(%s) incorrect status %s should be %s\n",
+               torture_result(tctx, TORTURE_FAIL, "(%s) incorrect status %s should be %s\n",
                       __location__, nt_errstr(status),
                       nt_errstr(NT_STATUS_DOS(ERRDOS, ERRfilexists)));
                goto fail;
@@ -1517,14 +1615,14 @@ static bool torture_samba3_errorpaths(struct torture_context *tctx)
 
        status = smbcli_mkdir(cli_nt->tree, dname);
        if (!NT_STATUS_EQUAL(status, NT_STATUS_OBJECT_NAME_COLLISION)) {
-               torture_comment(tctx, "(%s) incorrect status %s should be %s\n",
+               torture_result(tctx, TORTURE_FAIL, "(%s) incorrect status %s should be %s\n",
                       __location__, nt_errstr(status),
                       nt_errstr(NT_STATUS_OBJECT_NAME_COLLISION));
                goto fail;
        }
        status = smbcli_mkdir(cli_dos->tree, dname);
        if (!NT_STATUS_EQUAL(status, NT_STATUS_DOS(ERRDOS, ERRnoaccess))) {
-               torture_comment(tctx, "(%s) incorrect status %s should be %s\n",
+               torture_result(tctx, TORTURE_FAIL, "(%s) incorrect status %s should be %s\n",
                       __location__, nt_errstr(status),
                       nt_errstr(NT_STATUS_DOS(ERRDOS, ERRnoaccess)));
                goto fail;
@@ -1549,7 +1647,7 @@ static bool torture_samba3_errorpaths(struct torture_context *tctx)
                status = smb_raw_mkdir(cli_dos->tree, &md);
                if (!NT_STATUS_EQUAL(status,
                                     NT_STATUS_DOS(ERRDOS, ERRrename))) {
-                       torture_comment(tctx, "(%s) incorrect status %s "
+                       torture_result(tctx, TORTURE_FAIL, "(%s) incorrect status %s "
                                        "should be ERRDOS:ERRrename\n",
                                        __location__, nt_errstr(status));
                        goto fail;
@@ -1559,7 +1657,7 @@ static bool torture_samba3_errorpaths(struct torture_context *tctx)
        io.ntcreatex.in.create_options = NTCREATEX_OPTIONS_DIRECTORY;
        status = smb_raw_open(cli_nt->tree, tctx, &io);
        if (!NT_STATUS_EQUAL(status, NT_STATUS_OBJECT_NAME_COLLISION)) {
-               torture_comment(tctx, "(%s) incorrect status %s should be %s\n",
+               torture_result(tctx, TORTURE_FAIL, "(%s) incorrect status %s should be %s\n",
                       __location__, nt_errstr(status),
                       nt_errstr(NT_STATUS_OBJECT_NAME_COLLISION));
                goto fail;
@@ -1567,7 +1665,7 @@ static bool torture_samba3_errorpaths(struct torture_context *tctx)
 
        status = smb_raw_open(cli_dos->tree, tctx, &io);
        if (!NT_STATUS_EQUAL(status, NT_STATUS_DOS(ERRDOS, ERRfilexists))) {
-               torture_comment(tctx, "(%s) incorrect status %s should be %s\n",
+               torture_result(tctx, TORTURE_FAIL, "(%s) incorrect status %s should be %s\n",
                       __location__, nt_errstr(status),
                       nt_errstr(NT_STATUS_DOS(ERRDOS, ERRfilexists)));
                goto fail;
@@ -1579,28 +1677,28 @@ static bool torture_samba3_errorpaths(struct torture_context *tctx)
 
                fnum = smbcli_open(cli_nt->tree, fname, O_RDWR | O_CREAT, 5);
                if (fnum != -1) {
-                       torture_comment(tctx, "Open(%s) with invalid deny mode succeeded -- "
+                       torture_result(tctx, TORTURE_FAIL, "Open(%s) with invalid deny mode succeeded -- "
                               "expected failure\n", fname);
                        smbcli_close(cli_nt->tree, fnum);
                        goto fail;
                }
                if (!NT_STATUS_EQUAL(smbcli_nt_error(cli_nt->tree),
                                     NT_STATUS_DOS(ERRDOS,ERRbadaccess))) {
-                       torture_comment(tctx, "Expected DOS error ERRDOS/ERRbadaccess, "
+                       torture_result(tctx, TORTURE_FAIL, "Expected DOS error ERRDOS/ERRbadaccess, "
                               "got %s\n", smbcli_errstr(cli_nt->tree));
                        goto fail;
                }
 
                fnum = smbcli_open(cli_dos->tree, fname, O_RDWR | O_CREAT, 5);
                if (fnum != -1) {
-                       torture_comment(tctx, "Open(%s) with invalid deny mode succeeded -- "
+                       torture_result(tctx, TORTURE_FAIL, "Open(%s) with invalid deny mode succeeded -- "
                               "expected failure\n", fname);
                        smbcli_close(cli_nt->tree, fnum);
                        goto fail;
                }
                if (!NT_STATUS_EQUAL(smbcli_nt_error(cli_nt->tree),
                                     NT_STATUS_DOS(ERRDOS,ERRbadaccess))) {
-                       torture_comment(tctx, "Expected DOS error ERRDOS:ERRbadaccess, "
+                       torture_result(tctx, TORTURE_FAIL, "Expected DOS error ERRDOS:ERRbadaccess, "
                               "got %s\n", smbcli_errstr(cli_nt->tree));
                        goto fail;
                }
@@ -1623,7 +1721,7 @@ static bool torture_samba3_errorpaths(struct torture_context *tctx)
                smbcli_close(cli_nt->tree, fnum);
 
                io.generic.level = RAW_OPEN_NTCREATEX;
-               io.ntcreatex.in.root_fid = 0;
+               io.ntcreatex.in.root_fid.fnum = 0;
                io.ntcreatex.in.access_mask = SEC_RIGHTS_FILE_ALL;
                io.ntcreatex.in.alloc_size = 0;
                io.ntcreatex.in.file_attr = FILE_ATTRIBUTE_DIRECTORY;
@@ -1640,7 +1738,7 @@ static bool torture_samba3_errorpaths(struct torture_context *tctx)
 
                status = smb_raw_open(cli_nt->tree, tctx, &io);
                if (!NT_STATUS_EQUAL(status, NT_STATUS_NOT_A_DIRECTORY)) {
-                       torture_comment(tctx, "ntcreate as dir gave %s, "
+                       torture_result(tctx, TORTURE_FAIL, "ntcreate as dir gave %s, "
                                        "expected NT_STATUS_NOT_A_DIRECTORY\n",
                                        nt_errstr(status));
                        result = false;
@@ -1653,7 +1751,7 @@ static bool torture_samba3_errorpaths(struct torture_context *tctx)
                status = smb_raw_open(cli_dos->tree, tctx, &io);
                if (!NT_STATUS_EQUAL(status, NT_STATUS_DOS(ERRDOS,
                                                           ERRbaddirectory))) {
-                       torture_comment(tctx, "ntcreate as dir gave %s, "
+                       torture_result(tctx, TORTURE_FAIL, "ntcreate as dir gave %s, "
                                        "expected NT_STATUS_NOT_A_DIRECTORY\n",
                                        nt_errstr(status));
                        result = false;
@@ -1675,7 +1773,7 @@ static bool torture_samba3_errorpaths(struct torture_context *tctx)
                           O_RDWR | O_CREAT | O_TRUNC,
                           DENY_NONE);
        if (fnum != -1) {
-               torture_comment(tctx, "Open(%s) succeeded -- expected failure\n",
+               torture_result(tctx, TORTURE_FAIL, "Open(%s) succeeded -- expected failure\n",
                       os2_fname);
                smbcli_close(cli_dos->tree, fnum);
                goto fail;
@@ -1683,7 +1781,7 @@ static bool torture_samba3_errorpaths(struct torture_context *tctx)
 
        if (!NT_STATUS_EQUAL(smbcli_nt_error(cli_dos->tree),
                             NT_STATUS_DOS(ERRDOS, ERRcannotopen))) {
-               torture_comment(tctx, "Expected DOS error ERRDOS/ERRcannotopen, got %s\n",
+               torture_result(tctx, TORTURE_FAIL, "Expected DOS error ERRDOS/ERRcannotopen, got %s\n",
                       smbcli_errstr(cli_dos->tree));
                goto fail;
        }
@@ -1692,7 +1790,7 @@ static bool torture_samba3_errorpaths(struct torture_context *tctx)
                           O_RDWR | O_CREAT | O_TRUNC,
                           DENY_NONE);
        if (fnum != -1) {
-               torture_comment(tctx, "Open(%s) succeeded -- expected failure\n",
+               torture_result(tctx, TORTURE_FAIL, "Open(%s) succeeded -- expected failure\n",
                       os2_fname);
                smbcli_close(cli_nt->tree, fnum);
                goto fail;
@@ -1700,7 +1798,7 @@ static bool torture_samba3_errorpaths(struct torture_context *tctx)
 
        if (!NT_STATUS_EQUAL(smbcli_nt_error(cli_nt->tree),
                             NT_STATUS_OBJECT_NAME_NOT_FOUND)) {
-               torture_comment(tctx, "Expected error NT_STATUS_OBJECT_NAME_NOT_FOUND, "
+               torture_result(tctx, TORTURE_FAIL, "Expected error NT_STATUS_OBJECT_NAME_NOT_FOUND, "
                       "got %s\n", smbcli_errstr(cli_nt->tree));
                goto fail;
        }
@@ -1719,57 +1817,179 @@ static bool torture_samba3_errorpaths(struct torture_context *tctx)
        return result;
 }
 
+/**
+  This checks file/dir birthtime
+*/
+static void list_fn(struct clilist_file_info *finfo, const char *name,
+                       void *state){
+
+       /* Just to change dir access time*/
+       sleep(5);
+
+}
+
+static bool run_birthtimetest(struct torture_context *tctx,
+                                                  struct smbcli_state *cli)
+{
+       int fnum;
+       size_t size;
+       time_t c_time, a_time, m_time, w_time, c_time1;
+       const char *fname = "\\birthtime.tst";
+       const char *dname = "\\birthtime";
+       const char *fname2 = "\\birthtime\\birthtime.tst";
+       bool correct = true;
+       uint8_t buf[16];
+
+
+       smbcli_unlink(cli->tree, fname);
+
+       torture_comment(tctx, "Testing Birthtime for File\n");
+
+       /* Save File birthtime/creationtime */
+       fnum = smbcli_open(cli->tree, fname, O_RDWR | O_CREAT | O_TRUNC,
+                               DENY_NONE);
+       if (NT_STATUS_IS_ERR(smbcli_qfileinfo(cli->tree, fnum, NULL, &size,
+                               &c_time, &a_time, &m_time, NULL, NULL))) {
+               torture_result(tctx, TORTURE_FAIL, "ERROR: qfileinfo failed (%s)\n",
+                               smbcli_errstr(cli->tree));
+               correct = false;
+       }
+       smbcli_close(cli->tree, fnum);
+
+       sleep(10);
+
+       /* Change in File attribute changes file change time*/
+       smbcli_setatr(cli->tree, fname, FILE_ATTRIBUTE_SYSTEM, 0);
+
+       fnum = smbcli_open(cli->tree, fname, O_RDWR | O_CREAT , DENY_NONE);
+       /* Writing updates modification time*/
+       smbcli_smbwrite(cli->tree, fnum,  &fname, 0, sizeof(fname));
+       /*Reading updates access time */
+       smbcli_read(cli->tree, fnum, buf, 0, 13);
+       smbcli_close(cli->tree, fnum);
+
+       if (NT_STATUS_IS_ERR(smbcli_qpathinfo2(cli->tree, fname, &c_time1,
+                       &a_time, &m_time, &w_time, &size, NULL, NULL))) {
+               torture_result(tctx, TORTURE_FAIL, "ERROR: qpathinfo2 failed (%s)\n",
+                       smbcli_errstr(cli->tree));
+               correct = false;
+       } else {
+               fprintf(stdout, "c_time = %li, c_time1 = %li\n",
+                       (long) c_time, (long) c_time1);
+               if (c_time1 != c_time) {
+                       torture_result(tctx, TORTURE_FAIL, "This system updated file \
+                                       birth times! Not expected!\n");
+                       correct = false;
+               }
+       }
+       smbcli_unlink(cli->tree, fname);
+
+       torture_comment(tctx, "Testing Birthtime for Directory\n");
+
+       /* check if the server does not update the directory birth time
+          when creating a new file */
+       if (NT_STATUS_IS_ERR(smbcli_mkdir(cli->tree, dname))) {
+               torture_result(tctx, TORTURE_FAIL, "ERROR: mkdir failed (%s)\n",
+                               smbcli_errstr(cli->tree));
+               correct = false;
+       }
+       sleep(3);
+       if (NT_STATUS_IS_ERR(smbcli_qpathinfo2(cli->tree, "\\birthtime\\",
+                       &c_time,&a_time,&m_time,&w_time, &size, NULL, NULL))){
+               torture_result(tctx, TORTURE_FAIL, "ERROR: qpathinfo2 failed (%s)\n",
+                               smbcli_errstr(cli->tree));
+               correct = false;
+       }
+
+       /* Creating a new file changes dir modification time and change time*/
+       smbcli_unlink(cli->tree, fname2);
+       fnum = smbcli_open(cli->tree, fname2, O_RDWR | O_CREAT | O_TRUNC,
+                       DENY_NONE);
+       smbcli_smbwrite(cli->tree, fnum,  &fnum, 0, sizeof(fnum));
+       smbcli_read(cli->tree, fnum, buf, 0, 13);
+       smbcli_close(cli->tree, fnum);
+
+       /* dir listing changes dir access time*/
+       smbcli_list(cli->tree, "\\birthtime\\*", 0, list_fn, cli );
+
+       if (NT_STATUS_IS_ERR(smbcli_qpathinfo2(cli->tree, "\\birthtime\\",
+                       &c_time1, &a_time, &m_time,&w_time,&size,NULL,NULL))){
+               torture_result(tctx, TORTURE_FAIL, "ERROR: qpathinfo2 failed (%s)\n",
+                               smbcli_errstr(cli->tree));
+               correct = false;
+       } else {
+               fprintf(stdout, "c_time = %li, c_time1 = %li\n",
+                       (long) c_time, (long) c_time1);
+               if (c_time1 != c_time) {
+                       torture_result(tctx, TORTURE_FAIL, "This system  updated directory \
+                                       birth times! Not Expected!\n");
+                       correct = false;
+               }
+       }
+       smbcli_unlink(cli->tree, fname2);
+       smbcli_rmdir(cli->tree, dname);
+
+       return correct;
+}
+
 
 NTSTATUS torture_base_init(void)
 {
-       struct torture_suite *suite = torture_suite_create(talloc_autofree_context(), "BASE");
+       struct torture_suite *suite = torture_suite_create(talloc_autofree_context(), "base");
 
-       torture_suite_add_2smb_test(suite, "FDPASS", run_fdpasstest);
+       torture_suite_add_2smb_test(suite, "fdpass", run_fdpasstest);
        torture_suite_add_suite(suite, torture_base_locktest(suite));
-       torture_suite_add_1smb_test(suite, "UNLINK", torture_unlinktest);
-       torture_suite_add_1smb_test(suite, "ATTR",   run_attrtest);
-       torture_suite_add_1smb_test(suite, "TRANS2", run_trans2test);
-       torture_suite_add_simple_test(suite, "NEGNOWAIT", run_negprot_nowait);
-       torture_suite_add_1smb_test(suite, "DIR1",  torture_dirtest1);
-       torture_suite_add_1smb_test(suite, "DIR2",  torture_dirtest2);
-       torture_suite_add_1smb_test(suite, "DENY1",  torture_denytest1);
-       torture_suite_add_2smb_test(suite, "DENY2",  torture_denytest2);
-       torture_suite_add_2smb_test(suite, "DENY3",  torture_denytest3);
-       torture_suite_add_1smb_test(suite, "DENYDOS",  torture_denydos_sharing);
-       torture_suite_add_smb_multi_test(suite, "NTDENY1", torture_ntdenytest1);
-       torture_suite_add_2smb_test(suite, "NTDENY2",  torture_ntdenytest2);
-       torture_suite_add_1smb_test(suite, "TCON",  run_tcon_test);
-       torture_suite_add_1smb_test(suite, "TCONDEV",  run_tcon_devtype_test);
-       torture_suite_add_1smb_test(suite, "VUID", run_vuidtest);
-       torture_suite_add_2smb_test(suite, "RW1",  run_readwritetest);
-       torture_suite_add_2smb_test(suite, "OPEN", run_opentest);
-       torture_suite_add_smb_multi_test(suite, "DEFER_OPEN", run_deferopen);
-       torture_suite_add_1smb_test(suite, "XCOPY", run_xcopy);
-       torture_suite_add_1smb_test(suite, "IOMETER", run_iometer);
-       torture_suite_add_1smb_test(suite, "RENAME", torture_test_rename);
+       torture_suite_add_1smb_test(suite, "unlink", torture_unlinktest);
+       torture_suite_add_1smb_test(suite, "attr",   run_attrtest);
+       torture_suite_add_1smb_test(suite, "trans2", run_trans2test);
+       torture_suite_add_1smb_test(suite, "birthtime", run_birthtimetest);
+       torture_suite_add_simple_test(suite, "negnowait", run_negprot_nowait);
+       torture_suite_add_1smb_test(suite, "dir1",  torture_dirtest1);
+       torture_suite_add_1smb_test(suite, "dir2",  torture_dirtest2);
+       torture_suite_add_1smb_test(suite, "deny1",  torture_denytest1);
+       torture_suite_add_2smb_test(suite, "deny2",  torture_denytest2);
+       torture_suite_add_2smb_test(suite, "deny3",  torture_denytest3);
+       torture_suite_add_1smb_test(suite, "denydos",  torture_denydos_sharing);
+       torture_suite_add_smb_multi_test(suite, "ntdeny1", torture_ntdenytest1);
+       torture_suite_add_2smb_test(suite, "ntdeny2",  torture_ntdenytest2);
+       torture_suite_add_1smb_test(suite, "tcon",  run_tcon_test);
+       torture_suite_add_1smb_test(suite, "tcondev",  run_tcon_devtype_test);
+       torture_suite_add_1smb_test(suite, "vuid", run_vuidtest);
+       torture_suite_add_2smb_test(suite, "rw1",  run_readwritetest);
+       torture_suite_add_2smb_test(suite, "open", run_opentest);
+       torture_suite_add_smb_multi_test(suite, "defer_open", run_deferopen);
+       torture_suite_add_1smb_test(suite, "xcopy", run_xcopy);
+       torture_suite_add_1smb_test(suite, "iometer", run_iometer);
+       torture_suite_add_1smb_test(suite, "rename", torture_test_rename);
        torture_suite_add_suite(suite, torture_test_delete());
-       torture_suite_add_1smb_test(suite, "PROPERTIES", torture_test_properties);
-       torture_suite_add_1smb_test(suite, "MANGLE", torture_mangle);
-       torture_suite_add_1smb_test(suite, "OPENATTR", torture_openattrtest);
+       torture_suite_add_1smb_test(suite, "properties", torture_test_properties);
+       torture_suite_add_1smb_test(suite, "mangle", torture_mangle);
+       torture_suite_add_1smb_test(suite, "openattr", torture_openattrtest);
+       torture_suite_add_1smb_test(suite, "winattr", torture_winattrtest);
        torture_suite_add_suite(suite, torture_charset(suite));
-       torture_suite_add_1smb_test(suite, "CHKPATH",  torture_chkpath_test);
-       torture_suite_add_1smb_test(suite, "SECLEAK",  torture_sec_leak);
-       torture_suite_add_simple_test(suite, "DISCONNECT",  torture_disconnect);
+       torture_suite_add_1smb_test(suite, "chkpath",  torture_chkpath_test);
+       torture_suite_add_1smb_test(suite, "secleak",  torture_sec_leak);
+       torture_suite_add_simple_test(suite, "disconnect",  torture_disconnect);
        torture_suite_add_suite(suite, torture_delay_write());
-       torture_suite_add_simple_test(suite, "SAMBA3ERROR", torture_samba3_errorpaths);
-       torture_suite_add_1smb_test(suite, "CASETABLE", torture_casetable);
-       torture_suite_add_1smb_test(suite, "UTABLE", torture_utable);
-       torture_suite_add_simple_test(suite, "SMB", torture_smb_scan);
+       torture_suite_add_simple_test(suite, "samba3error", torture_samba3_errorpaths);
+       torture_suite_add_1smb_test(suite, "casetable", torture_casetable);
+       torture_suite_add_1smb_test(suite, "utable", torture_utable);
+       torture_suite_add_simple_test(suite, "smb", torture_smb_scan);
        torture_suite_add_suite(suite, torture_trans2_aliases(suite));
-       torture_suite_add_1smb_test(suite, "TRANS2-SCAN", torture_trans2_scan);
-       torture_suite_add_1smb_test(suite, "NTTRANS", torture_nttrans_scan);
-
-       torture_suite_add_simple_test(suite, "BENCH-HOLDCON", torture_holdcon);
-       torture_suite_add_simple_test(suite, "BENCH-READWRITE", run_benchrw);
-       torture_suite_add_smb_multi_test(suite, "BENCH-TORTURE", run_torture);
-       torture_suite_add_1smb_test(suite, "SCAN-PIPE_NUMBER", run_pipe_number);
-       torture_suite_add_1smb_test(suite, "SCAN-IOCTL", torture_ioctl_test);
-       torture_suite_add_smb_multi_test(suite, "SCAN-MAXFID", run_maxfidtest);
+       torture_suite_add_1smb_test(suite, "trans2-scan", torture_trans2_scan);
+       torture_suite_add_1smb_test(suite, "nttrans", torture_nttrans_scan);
+       torture_suite_add_1smb_test(suite, "createx_access", torture_createx_access);
+       torture_suite_add_2smb_test(suite, "createx_sharemodes_file", torture_createx_sharemodes_file);
+       torture_suite_add_2smb_test(suite, "createx_sharemodes_dir", torture_createx_sharemodes_dir);
+       torture_suite_add_1smb_test(suite, "maximum_allowed", torture_maximum_allowed);
+
+       torture_suite_add_simple_test(suite, "bench-holdcon", torture_holdcon);
+       torture_suite_add_1smb_test(suite, "bench-holdopen", torture_holdopen);
+       torture_suite_add_simple_test(suite, "bench-readwrite", run_benchrw);
+       torture_suite_add_smb_multi_test(suite, "bench-torture", run_torture);
+       torture_suite_add_1smb_test(suite, "scan-pipe_number", run_pipe_number);
+       torture_suite_add_1smb_test(suite, "scan-ioctl", torture_ioctl_test);
+       torture_suite_add_1smb_test(suite, "scan-maxfid", torture_maxfid_test);
 
        suite->description = talloc_strdup(suite, 
                                        "Basic SMB tests (imported from the original smbtorture)");