r4627: - simplified the dcerpc auth code using a common function
[samba.git] / source4 / librpc / ndr / ndr_basic.c
index 01205d4043b0305bf0f76016744509e6fadcd3fd..13ac087978912acf034bb28afa55c6a8cd8f7ff2 100644 (file)
 #define NDR_BE(ndr) (((ndr)->flags & (LIBNDR_FLAG_BIGENDIAN|LIBNDR_FLAG_LITTLE_ENDIAN)) == LIBNDR_FLAG_BIGENDIAN)
 #define NDR_SVAL(ndr, ofs) (NDR_BE(ndr)?RSVAL(ndr->data,ofs):SVAL(ndr->data,ofs))
 #define NDR_IVAL(ndr, ofs) (NDR_BE(ndr)?RIVAL(ndr->data,ofs):IVAL(ndr->data,ofs))
+#define NDR_IVALS(ndr, ofs) (NDR_BE(ndr)?RIVALS(ndr->data,ofs):IVALS(ndr->data,ofs))
 #define NDR_SSVAL(ndr, ofs, v) do { if (NDR_BE(ndr))  { RSSVAL(ndr->data,ofs,v); } else SSVAL(ndr->data,ofs,v); } while (0)
 #define NDR_SIVAL(ndr, ofs, v) do { if (NDR_BE(ndr))  { RSIVAL(ndr->data,ofs,v); } else SIVAL(ndr->data,ofs,v); } while (0)
+#define NDR_SIVALS(ndr, ofs, v) do { if (NDR_BE(ndr))  { RSIVALS(ndr->data,ofs,v); } else SIVALS(ndr->data,ofs,v); } while (0)
 
 
 /*
@@ -90,6 +92,18 @@ NTSTATUS ndr_pull_uint32(struct ndr_pull *ndr, uint32_t *v)
        return NT_STATUS_OK;
 }
 
+/*
+  parse a int32_t
+*/
+NTSTATUS ndr_pull_int32(struct ndr_pull *ndr, int32_t *v)
+{
+       NDR_PULL_ALIGN(ndr, 4);
+       NDR_PULL_NEED_BYTES(ndr, 4);
+       *v = NDR_IVALS(ndr, ndr->offset);
+       ndr->offset += 4;
+       return NT_STATUS_OK;
+}
+
 /*
   parse a pointer
 */
@@ -176,15 +190,15 @@ NTSTATUS ndr_push_WERROR(struct ndr_push *ndr, WERROR status)
        return ndr_push_uint32(ndr, W_ERROR_V(status));
 }
 
-void ndr_print_WERROR(struct ndr_print *ndr, const char *name, WERROR *r)
+void ndr_print_WERROR(struct ndr_print *ndr, const char *name, WERROR r)
 {
-       ndr->print(ndr, "%-25s: %s", name, win_errstr(*r));
+       ndr->print(ndr, "%-25s: %s", name, win_errstr(r));
 }
 
 /*
   parse a set of bytes
 */
-NTSTATUS ndr_pull_bytes(struct ndr_pull *ndr, char *data, uint32_t n)
+NTSTATUS ndr_pull_bytes(struct ndr_pull *ndr, uint8_t *data, uint32_t n)
 {
        NDR_PULL_NEED_BYTES(ndr, n);
        memcpy(data, ndr->data + ndr->offset, n);
@@ -195,7 +209,7 @@ NTSTATUS ndr_pull_bytes(struct ndr_pull *ndr, char *data, uint32_t n)
 /*
   pull an array of uint8
 */
-NTSTATUS ndr_pull_array_uint8(struct ndr_pull *ndr, int ndr_flags, char *data, uint32_t n)
+NTSTATUS ndr_pull_array_uint8(struct ndr_pull *ndr, int ndr_flags, uint8_t *data, uint32_t n)
 {
        if (!(ndr_flags & NDR_SCALARS)) {
                return NT_STATUS_OK;
@@ -249,6 +263,23 @@ NTSTATUS ndr_pull_array_HYPER_T(struct ndr_pull *ndr, int ndr_flags, HYPER_T *da
        return NT_STATUS_OK;
 }
 
+/*
+  pull a const array of WERROR
+*/
+NTSTATUS ndr_pull_array_WERROR(struct ndr_pull *ndr, int ndr_flags, WERROR *data, uint32_t n)
+{
+       uint32_t i;
+       if (!(ndr_flags & NDR_SCALARS)) {
+               return NT_STATUS_OK;
+       }
+       for (i=0;i<n;i++) {
+               NDR_CHECK(ndr_pull_WERROR(ndr, &data[i]));
+       }
+       return NT_STATUS_OK;
+}
+
+
+
 /*
   push a uint8
 */
@@ -284,6 +315,18 @@ NTSTATUS ndr_push_uint32(struct ndr_push *ndr, uint32_t v)
        return NT_STATUS_OK;
 }
 
+/*
+  push a int32_t
+*/
+NTSTATUS ndr_push_int32(struct ndr_push *ndr, int32_t v)
+{
+       NDR_PUSH_ALIGN(ndr, 4);
+       NDR_PUSH_NEED_BYTES(ndr, 4);
+       NDR_SIVALS(ndr, ndr->offset, v);
+       ndr->offset += 4;
+       return NT_STATUS_OK;
+}
+
 /*
   push a uint64
 */
@@ -329,7 +372,7 @@ NTSTATUS ndr_pull_align(struct ndr_pull *ndr, size_t size)
 /*
   push some bytes
 */
-NTSTATUS ndr_push_bytes(struct ndr_push *ndr, const char *data, uint32_t n)
+NTSTATUS ndr_push_bytes(struct ndr_push *ndr, const uint8_t *data, uint32_t n)
 {
        NDR_PUSH_NEED_BYTES(ndr, n);
        memcpy(ndr->data + ndr->offset, data, n);
@@ -351,7 +394,7 @@ NTSTATUS ndr_push_zero(struct ndr_push *ndr, uint32_t n)
 /*
   push an array of uint8
 */
-NTSTATUS ndr_push_array_uint8(struct ndr_push *ndr, int ndr_flags, const char *data, uint32_t n)
+NTSTATUS ndr_push_array_uint8(struct ndr_push *ndr, int ndr_flags, const uint8_t *data, uint32_t n)
 {
        if (!(ndr_flags & NDR_SCALARS)) {
                return NT_STATUS_OK;
@@ -404,6 +447,21 @@ NTSTATUS ndr_push_array_HYPER_T(struct ndr_push *ndr, int ndr_flags, const HYPER
        return NT_STATUS_OK;
 }
 
+/*
+  push an array of HYPER_T
+*/
+NTSTATUS ndr_push_array_WERROR(struct ndr_push *ndr, int ndr_flags, const WERROR *data, uint32_t n)
+{
+       int i;
+       if (!(ndr_flags & NDR_SCALARS)) {
+               return NT_STATUS_OK;
+       }
+       for (i=0;i<n;i++) {
+               NDR_CHECK(ndr_push_WERROR(ndr, data[i]));
+       }
+       return NT_STATUS_OK;
+}
+
 /*
   save the current position
  */
@@ -447,6 +505,9 @@ NTSTATUS ndr_pull_string(struct ndr_pull *ndr, int ndr_flags, const char **s)
        uint16_t len3;
        int ret;
        int chset = CH_UTF16;
+       unsigned byte_mul = 2;
+       unsigned flags = ndr->flags;
+       unsigned c_len_term = 0;
 
        if (!(ndr_flags & NDR_SCALARS)) {
                return NT_STATUS_OK;
@@ -456,11 +517,33 @@ NTSTATUS ndr_pull_string(struct ndr_pull *ndr, int ndr_flags, const char **s)
                chset = CH_UTF16BE;
        }
 
-       switch (ndr->flags & LIBNDR_STRING_FLAGS) {
+       if (flags & LIBNDR_FLAG_STR_ASCII) {
+               chset = CH_DOS;
+               byte_mul = 1;
+               flags &= ~LIBNDR_FLAG_STR_ASCII;
+       }
+
+       if (flags & LIBNDR_FLAG_STR_UTF8) {
+               chset = CH_UTF8;
+               byte_mul = 1;
+               flags &= ~LIBNDR_FLAG_STR_UTF8;
+       }
+
+       flags &= ~LIBNDR_FLAG_STR_CONFORMANT;
+       if (flags & LIBNDR_FLAG_STR_CHARLEN) {
+               c_len_term = 1;
+               flags &= ~LIBNDR_FLAG_STR_CHARLEN;
+       }
+
+       switch (flags & LIBNDR_STRING_FLAGS) {
        case LIBNDR_FLAG_STR_LEN4|LIBNDR_FLAG_STR_SIZE4:
        case LIBNDR_FLAG_STR_LEN4|LIBNDR_FLAG_STR_SIZE4|LIBNDR_FLAG_STR_NOTERM:
                NDR_CHECK(ndr_pull_uint32(ndr, &len1));
                NDR_CHECK(ndr_pull_uint32(ndr, &ofs));
+               if (ofs != 0) {
+                       return ndr_pull_error(ndr, NDR_ERR_STRING, "non-zero array offset with string flags 0x%x\n",
+                                             ndr->flags & LIBNDR_STRING_FLAGS);
+               }
                NDR_CHECK(ndr_pull_uint32(ndr, &len2));
                if (len2 > len1) {
                        return ndr_pull_error(ndr, NDR_ERR_STRING, 
@@ -471,25 +554,25 @@ NTSTATUS ndr_pull_string(struct ndr_pull *ndr, int ndr_flags, const char **s)
                        *s = talloc_strdup(ndr, "");
                        break;
                }
-               NDR_PULL_NEED_BYTES(ndr, len2*2);
+               NDR_PULL_NEED_BYTES(ndr, (len2 + c_len_term)*byte_mul);
                ret = convert_string_talloc(ndr, chset, CH_UNIX, 
                                            ndr->data+ndr->offset, 
-                                           len2*2,
-                                           (const void **)&as);
+                                           (len2 + c_len_term)*byte_mul,
+                                           (void **)&as);
                if (ret == -1) {
                        return ndr_pull_error(ndr, NDR_ERR_CHARCNV, 
                                              "Bad character conversion");
                }
-               NDR_CHECK(ndr_pull_advance(ndr, len2*2));
+               NDR_CHECK(ndr_pull_advance(ndr, (len2 + c_len_term)*byte_mul));
 
                /* this is a way of detecting if a string is sent with the wrong
                   termination */
                if (ndr->flags & LIBNDR_FLAG_STR_NOTERM) {
-                       if (strlen(as) < len2) {
+                       if (strlen(as) < (len2 + c_len_term)) {
                                DEBUG(6,("short string '%s'\n", as));
                        }
                } else {
-                       if (strlen(as) == len2) {
+                       if (strlen(as) == (len2 + c_len_term)) {
                                DEBUG(6,("long string '%s'\n", as));
                        }
                }
@@ -499,116 +582,158 @@ NTSTATUS ndr_pull_string(struct ndr_pull *ndr, int ndr_flags, const char **s)
        case LIBNDR_FLAG_STR_SIZE4:
        case LIBNDR_FLAG_STR_SIZE4|LIBNDR_FLAG_STR_NOTERM:
                NDR_CHECK(ndr_pull_uint32(ndr, &len1));
-               NDR_PULL_NEED_BYTES(ndr, len1*2);
+               NDR_PULL_NEED_BYTES(ndr, (len1 + c_len_term)*byte_mul);
                if (len1 == 0) {
                        *s = talloc_strdup(ndr, "");
                        break;
                }
                ret = convert_string_talloc(ndr, chset, CH_UNIX, 
                                            ndr->data+ndr->offset, 
-                                           len1*2,
-                                           (const void **)&as);
+                                           (len1 + c_len_term)*byte_mul,
+                                           (void **)&as);
                if (ret == -1) {
                        return ndr_pull_error(ndr, NDR_ERR_CHARCNV, 
                                              "Bad character conversion");
                }
-               NDR_CHECK(ndr_pull_advance(ndr, len1*2));
+               NDR_CHECK(ndr_pull_advance(ndr, (len1 + c_len_term)*byte_mul));
 
                /* this is a way of detecting if a string is sent with the wrong
                   termination */
                if (ndr->flags & LIBNDR_FLAG_STR_NOTERM) {
-                       if (strlen(as) < len1) {
+                       if (strlen(as) < (len1 + c_len_term)) {
                                DEBUG(6,("short string '%s'\n", as));
                        }
                } else {
-                       if (strlen(as) == len1) {
+                       if (strlen(as) == (len1 + c_len_term)) {
                                DEBUG(6,("long string '%s'\n", as));
                        }
                }
                *s = as;
                break;
 
-       case LIBNDR_FLAG_STR_SIZE2|LIBNDR_FLAG_STR_NOTERM|LIBNDR_FLAG_STR_BYTESIZE:
-               NDR_CHECK(ndr_pull_uint16(ndr, &len3));
-               NDR_PULL_NEED_BYTES(ndr, len3);
-               if (len3 == 0) {
+       case LIBNDR_FLAG_STR_LEN4:
+       case LIBNDR_FLAG_STR_LEN4|LIBNDR_FLAG_STR_NOTERM:
+               NDR_CHECK(ndr_pull_uint32(ndr, &ofs));
+               if (ofs != 0) {
+                       return ndr_pull_error(ndr, NDR_ERR_STRING, "non-zero array offset with string flags 0x%x\n",
+                                             ndr->flags & LIBNDR_STRING_FLAGS);
+               }
+               NDR_CHECK(ndr_pull_uint32(ndr, &len1));
+               NDR_PULL_NEED_BYTES(ndr, (len1 + c_len_term)*byte_mul);
+               if (len1 == 0) {
                        *s = talloc_strdup(ndr, "");
                        break;
                }
                ret = convert_string_talloc(ndr, chset, CH_UNIX, 
                                            ndr->data+ndr->offset, 
-                                           len3,
-                                           (const void **)&as);
+                                           (len1 + c_len_term)*byte_mul,
+                                           (void **)&as);
                if (ret == -1) {
                        return ndr_pull_error(ndr, NDR_ERR_CHARCNV, 
                                              "Bad character conversion");
                }
-               NDR_CHECK(ndr_pull_advance(ndr, len3));
+               NDR_CHECK(ndr_pull_advance(ndr, (len1 + c_len_term)*byte_mul));
+
+               /* this is a way of detecting if a string is sent with the wrong
+                  termination */
+               if (ndr->flags & LIBNDR_FLAG_STR_NOTERM) {
+                       if (strlen(as) < (len1 + c_len_term)) {
+                               DEBUG(6,("short string '%s'\n", as));
+                       }
+               } else {
+                       if (strlen(as) == (len1 + c_len_term)) {
+                               DEBUG(6,("long string '%s'\n", as));
+                       }
+               }
                *s = as;
                break;
 
-       case LIBNDR_FLAG_STR_NULLTERM:
-               len1 = strnlen_w((const smb_ucs2_t *)(ndr->data+ndr->offset), 
-                                (ndr->data_size - ndr->offset)/2);
-               if (len1*2+2 <= ndr->data_size - ndr->offset) {
-                       len1++;
+
+       case LIBNDR_FLAG_STR_SIZE2:
+       case LIBNDR_FLAG_STR_SIZE2|LIBNDR_FLAG_STR_NOTERM:
+               NDR_CHECK(ndr_pull_uint16(ndr, &len3));
+               NDR_PULL_NEED_BYTES(ndr, (len3 + c_len_term)*byte_mul);
+               if (len3 == 0) {
+                       *s = talloc_strdup(ndr, "");
+                       break;
                }
                ret = convert_string_talloc(ndr, chset, CH_UNIX, 
                                            ndr->data+ndr->offset, 
-                                           len1*2,
-                                           (const void **)&as);
+                                           (len3 + c_len_term)*byte_mul,
+                                           (void **)&as);
                if (ret == -1) {
                        return ndr_pull_error(ndr, NDR_ERR_CHARCNV, 
                                              "Bad character conversion");
                }
-               NDR_CHECK(ndr_pull_advance(ndr, len1*2));
-               *s = as;
-               break;
+               NDR_CHECK(ndr_pull_advance(ndr, (len3 + c_len_term)*byte_mul));
 
-       case LIBNDR_FLAG_STR_ASCII|LIBNDR_FLAG_STR_LEN4|LIBNDR_FLAG_STR_SIZE4:
-       case LIBNDR_FLAG_STR_ASCII|LIBNDR_FLAG_STR_LEN4|LIBNDR_FLAG_STR_SIZE4|LIBNDR_FLAG_STR_NOTERM:
-               NDR_CHECK(ndr_pull_uint32(ndr, &len1));
-               NDR_CHECK(ndr_pull_uint32(ndr, &ofs));
-               NDR_CHECK(ndr_pull_uint32(ndr, &len2));
-               if (len2 > len1) {
-                       return ndr_pull_error(ndr, NDR_ERR_STRING, 
-                                             "Bad ascii string lengths len1=%u ofs=%u len2=%u\n", 
-                                             len1, ofs, len2);
+               /* this is a way of detecting if a string is sent with the wrong
+                  termination */
+               if (ndr->flags & LIBNDR_FLAG_STR_NOTERM) {
+                       if (strlen(as) < (len3 + c_len_term)) {
+                               DEBUG(6,("short string '%s'\n", as));
+                       }
+               } else {
+                       if (strlen(as) == (len3 + c_len_term)) {
+                               DEBUG(6,("long string '%s'\n", as));
+                       }
                }
-               NDR_ALLOC_N(ndr, as, (len2+1));
-               NDR_CHECK(ndr_pull_bytes(ndr, as, len2));
-               as[len2] = 0;
                *s = as;
                break;
 
-       case LIBNDR_FLAG_STR_ASCII|LIBNDR_FLAG_STR_LEN4:
-               NDR_CHECK(ndr_pull_uint32(ndr, &ofs));
-               NDR_CHECK(ndr_pull_uint32(ndr, &len2));
-               NDR_ALLOC_N(ndr, as, (len2+1));
-               NDR_CHECK(ndr_pull_bytes(ndr, as, len2));
-               as[len2] = 0;
+       case LIBNDR_FLAG_STR_SIZE2|LIBNDR_FLAG_STR_NOTERM|LIBNDR_FLAG_STR_BYTESIZE:
+               NDR_CHECK(ndr_pull_uint16(ndr, &len3));
+               NDR_PULL_NEED_BYTES(ndr, len3);
+               if (len3 == 0) {
+                       *s = talloc_strdup(ndr, "");
+                       break;
+               }
+               ret = convert_string_talloc(ndr, chset, CH_UNIX, 
+                                           ndr->data+ndr->offset, 
+                                           len3,
+                                           (void **)&as);
+               if (ret == -1) {
+                       return ndr_pull_error(ndr, NDR_ERR_CHARCNV, 
+                                             "Bad character conversion");
+               }
+               NDR_CHECK(ndr_pull_advance(ndr, len3));
                *s = as;
                break;
 
-       case LIBNDR_FLAG_STR_ASCII|LIBNDR_FLAG_STR_SIZE2:
-               NDR_CHECK(ndr_pull_uint16(ndr, &len3));
-               NDR_ALLOC_N(ndr, as, (len3+1));
-               NDR_CHECK(ndr_pull_bytes(ndr, as, len3));
-               as[len3] = 0;
+       case LIBNDR_FLAG_STR_NULLTERM:
+               if (byte_mul == 1) {
+                       len1 = ascii_len_n((const char *)(ndr->data+ndr->offset), ndr->data_size - ndr->offset);
+               } else {
+                       len1 = utf16_len_n(ndr->data+ndr->offset, ndr->data_size - ndr->offset);
+               }
+               ret = convert_string_talloc(ndr, chset, CH_UNIX, 
+                                           ndr->data+ndr->offset, 
+                                           len1,
+                                           (void **)&as);
+               if (ret == -1) {
+                       return ndr_pull_error(ndr, NDR_ERR_CHARCNV, 
+                                             "Bad character conversion");
+               }
+               NDR_CHECK(ndr_pull_advance(ndr, len1));
                *s = as;
                break;
 
-       case LIBNDR_FLAG_STR_ASCII|LIBNDR_FLAG_STR_NULLTERM:
-               len1 = strnlen(ndr->data+ndr->offset, (ndr->data_size - ndr->offset));
-               if (len1+1 <= ndr->data_size - ndr->offset) {
-                       len1++;
+       case LIBNDR_FLAG_STR_FIXLEN32:
+               len1 = 32;
+               NDR_PULL_NEED_BYTES(ndr, len1*byte_mul);
+               ret = convert_string_talloc(ndr, chset, CH_UNIX, 
+                                           ndr->data+ndr->offset, 
+                                           len1*byte_mul,
+                                           (void **)&as);
+               if (ret == -1) {
+                       return ndr_pull_error(ndr, NDR_ERR_CHARCNV, 
+                                             "Bad character conversion");
                }
-               NDR_ALLOC_N(ndr, as, (len1+1));
-               NDR_CHECK(ndr_pull_bytes(ndr, as, len1));
-               as[len1] = 0;
+               NDR_CHECK(ndr_pull_advance(ndr, len1*byte_mul));
                *s = as;
                break;
 
+
        default:
                return ndr_pull_error(ndr, NDR_ERR_STRING, "Bad string flags 0x%x\n",
                                      ndr->flags & LIBNDR_STRING_FLAGS);
@@ -626,6 +751,9 @@ NTSTATUS ndr_push_string(struct ndr_push *ndr, int ndr_flags, const char *s)
        ssize_t s_len, c_len;
        int ret;
        int chset = CH_UTF16;
+       unsigned flags = ndr->flags;
+       unsigned byte_mul = 2;
+       unsigned c_len_term = 1;
 
        if (!(ndr_flags & NDR_SCALARS)) {
                return NT_STATUS_OK;
@@ -638,142 +766,132 @@ NTSTATUS ndr_push_string(struct ndr_push *ndr, int ndr_flags, const char *s)
        s_len = s?strlen(s):0;
        c_len = s?strlen_m(s):0;
 
-       switch (ndr->flags & LIBNDR_STRING_FLAGS) {
+       if (flags & LIBNDR_FLAG_STR_ASCII) {
+               chset = CH_DOS;
+               byte_mul = 1;
+               flags &= ~LIBNDR_FLAG_STR_ASCII;
+       }
+
+       if (flags & LIBNDR_FLAG_STR_UTF8) {
+               chset = CH_UTF8;
+               byte_mul = 1;
+               flags &= ~LIBNDR_FLAG_STR_UTF8;
+       }
+
+       flags &= ~LIBNDR_FLAG_STR_CONFORMANT;
+
+       if (flags & LIBNDR_FLAG_STR_CHARLEN) {
+               c_len_term = 0;
+               flags &= ~LIBNDR_FLAG_STR_CHARLEN;
+       }
+
+       switch (flags & LIBNDR_STRING_FLAGS) {
        case LIBNDR_FLAG_STR_LEN4|LIBNDR_FLAG_STR_SIZE4:
-               NDR_CHECK(ndr_push_uint32(ndr, c_len+1));
+               NDR_CHECK(ndr_push_uint32(ndr, c_len+c_len_term));
                NDR_CHECK(ndr_push_uint32(ndr, 0));
-               NDR_CHECK(ndr_push_uint32(ndr, c_len+1));
-               NDR_PUSH_NEED_BYTES(ndr, c_len*2 + 2);
+               NDR_CHECK(ndr_push_uint32(ndr, c_len+c_len_term));
+               NDR_PUSH_NEED_BYTES(ndr, byte_mul*(c_len+1));
                ret = convert_string(CH_UNIX, chset, 
                                     s, s_len+1,
-                                    ndr->data+ndr->offset, c_len*2 + 2);
+                                    ndr->data+ndr->offset, 
+                                    byte_mul*(c_len+1));
                if (ret == -1) {
                        return ndr_push_error(ndr, NDR_ERR_CHARCNV, 
                                              "Bad character conversion");
                }
-               ndr->offset += c_len*2 + 2;
+               ndr->offset += byte_mul*(c_len+1);
                break;
 
        case LIBNDR_FLAG_STR_LEN4|LIBNDR_FLAG_STR_SIZE4|LIBNDR_FLAG_STR_NOTERM:
                NDR_CHECK(ndr_push_uint32(ndr, c_len));
                NDR_CHECK(ndr_push_uint32(ndr, 0));
                NDR_CHECK(ndr_push_uint32(ndr, c_len));
-               NDR_PUSH_NEED_BYTES(ndr, c_len*2);
+               NDR_PUSH_NEED_BYTES(ndr, c_len*byte_mul);
                ret = convert_string(CH_UNIX, chset, 
                                     s, s_len,
-                                    ndr->data+ndr->offset, c_len*2);
+                                    ndr->data+ndr->offset, c_len*byte_mul);
                if (ret == -1) {
                        return ndr_push_error(ndr, NDR_ERR_CHARCNV, 
                                              "Bad character conversion");
                }
-               ndr->offset += c_len*2;
+               ndr->offset += c_len*byte_mul;
                break;
 
-       case LIBNDR_FLAG_STR_SIZE4:
-               NDR_CHECK(ndr_push_uint32(ndr, c_len + 1));
-               NDR_PUSH_NEED_BYTES(ndr, c_len*2 + 2);
+       case LIBNDR_FLAG_STR_LEN4:
+               NDR_CHECK(ndr_push_uint32(ndr, 0));
+               NDR_CHECK(ndr_push_uint32(ndr, c_len + c_len_term));
+               NDR_PUSH_NEED_BYTES(ndr, byte_mul*(c_len+1));
                ret = convert_string(CH_UNIX, chset, 
                                     s, s_len + 1,
-                                    ndr->data+ndr->offset, c_len*2 + 2);
+                                    ndr->data+ndr->offset, byte_mul*(c_len+1));
                if (ret == -1) {
                        return ndr_push_error(ndr, NDR_ERR_CHARCNV, 
                                              "Bad character conversion");
                }
-               ndr->offset += c_len*2 + 2;
+               ndr->offset += byte_mul*(c_len+1);
                break;
 
-       case LIBNDR_FLAG_STR_NULLTERM:
-               NDR_PUSH_NEED_BYTES(ndr, c_len*2 + 2);
+       case LIBNDR_FLAG_STR_SIZE4:
+               NDR_CHECK(ndr_push_uint32(ndr, c_len + c_len_term));
+               NDR_PUSH_NEED_BYTES(ndr, byte_mul*(c_len+1));
                ret = convert_string(CH_UNIX, chset, 
-                                    s, s_len+1,
-                                    ndr->data+ndr->offset, c_len*2 + 2);
+                                    s, s_len + 1,
+                                    ndr->data+ndr->offset, byte_mul*(c_len+1));
                if (ret == -1) {
                        return ndr_push_error(ndr, NDR_ERR_CHARCNV, 
                                              "Bad character conversion");
                }
-               ndr->offset += c_len*2 + 2;
+               ndr->offset += byte_mul*(c_len+1);
                break;
 
-       case LIBNDR_FLAG_STR_SIZE2|LIBNDR_FLAG_STR_NOTERM|LIBNDR_FLAG_STR_BYTESIZE:
-               NDR_CHECK(ndr_push_uint16(ndr, c_len*2));
-               NDR_PUSH_NEED_BYTES(ndr, c_len*2);
+       case LIBNDR_FLAG_STR_SIZE2:
+               NDR_CHECK(ndr_push_uint16(ndr, c_len + c_len_term));
+               NDR_PUSH_NEED_BYTES(ndr, byte_mul*(c_len+1));
                ret = convert_string(CH_UNIX, chset, 
-                                    s, s_len,
-                                    ndr->data+ndr->offset, c_len*2);
-               if (ret == -1) {
-                       return ndr_push_error(ndr, NDR_ERR_CHARCNV, 
-                                             "Bad character conversion");
-               }
-               ndr->offset += c_len*2;
-               break;
-
-       case LIBNDR_FLAG_STR_ASCII|LIBNDR_FLAG_STR_LEN4|LIBNDR_FLAG_STR_SIZE4:
-               NDR_CHECK(ndr_push_uint32(ndr, c_len+1));
-               NDR_CHECK(ndr_push_uint32(ndr, 0));
-               NDR_CHECK(ndr_push_uint32(ndr, c_len+1));
-               NDR_PUSH_NEED_BYTES(ndr, c_len + 1);
-               ret = convert_string(CH_UNIX, CH_DOS, 
                                     s, s_len + 1,
-                                    ndr->data+ndr->offset, c_len + 1);
+                                    ndr->data+ndr->offset, byte_mul*(c_len+1));
                if (ret == -1) {
                        return ndr_push_error(ndr, NDR_ERR_CHARCNV, 
                                              "Bad character conversion");
                }
-               ndr->offset += c_len + 1;
+               ndr->offset += byte_mul*(c_len+1);
                break;
 
-       case LIBNDR_FLAG_STR_ASCII|LIBNDR_FLAG_STR_LEN4|LIBNDR_FLAG_STR_SIZE4|LIBNDR_FLAG_STR_NOTERM:
-               NDR_CHECK(ndr_push_uint32(ndr, c_len));
-               NDR_CHECK(ndr_push_uint32(ndr, 0));
-               NDR_CHECK(ndr_push_uint32(ndr, c_len));
-               NDR_PUSH_NEED_BYTES(ndr, c_len);
-               ret = convert_string(CH_UNIX, CH_DOS, 
-                                    s, s_len,
-                                    ndr->data+ndr->offset, c_len);
+       case LIBNDR_FLAG_STR_NULLTERM:
+               NDR_PUSH_NEED_BYTES(ndr, byte_mul*(c_len+1));
+               ret = convert_string(CH_UNIX, chset, 
+                                    s, s_len+1,
+                                    ndr->data+ndr->offset, byte_mul*(c_len+1));
                if (ret == -1) {
                        return ndr_push_error(ndr, NDR_ERR_CHARCNV, 
                                              "Bad character conversion");
                }
-               ndr->offset += c_len;
+               ndr->offset += byte_mul*(c_len+1);
                break;
 
-       case LIBNDR_FLAG_STR_ASCII|LIBNDR_FLAG_STR_LEN4:
-               NDR_CHECK(ndr_push_uint32(ndr, 0));
-               NDR_CHECK(ndr_push_uint32(ndr, c_len+1));
-               NDR_PUSH_NEED_BYTES(ndr, c_len + 1);
-               ret = convert_string(CH_UNIX, CH_DOS, 
-                                    s, s_len + 1,
-                                    ndr->data+ndr->offset, c_len + 1);
+       case LIBNDR_FLAG_STR_SIZE2|LIBNDR_FLAG_STR_NOTERM|LIBNDR_FLAG_STR_BYTESIZE:
+               NDR_CHECK(ndr_push_uint16(ndr, c_len*byte_mul));
+               NDR_PUSH_NEED_BYTES(ndr, c_len*byte_mul);
+               ret = convert_string(CH_UNIX, chset, 
+                                    s, s_len,
+                                    ndr->data+ndr->offset, c_len*byte_mul);
                if (ret == -1) {
                        return ndr_push_error(ndr, NDR_ERR_CHARCNV, 
                                              "Bad character conversion");
                }
-               ndr->offset += c_len + 1;
+               ndr->offset += c_len*byte_mul;
                break;
 
-       case LIBNDR_FLAG_STR_ASCII|LIBNDR_FLAG_STR_SIZE2:
-               NDR_CHECK(ndr_push_uint16(ndr, c_len+1));
-               NDR_PUSH_NEED_BYTES(ndr, c_len + 1);
-               ret = convert_string(CH_UNIX, CH_DOS, 
+       case LIBNDR_FLAG_STR_FIXLEN32:
+               NDR_PUSH_NEED_BYTES(ndr, byte_mul*32);
+               ret = convert_string(CH_UNIX, chset, 
                                     s, s_len + 1,
-                                    ndr->data+ndr->offset, c_len + 1);
-               if (ret == -1) {
-                       return ndr_push_error(ndr, NDR_ERR_CHARCNV, 
-                                             "Bad character conversion");
-               }
-               ndr->offset += c_len + 1;
-               break;
-
-       case LIBNDR_FLAG_STR_ASCII|LIBNDR_FLAG_STR_NULLTERM:
-               NDR_PUSH_NEED_BYTES(ndr, c_len + 1);
-               ret = convert_string(CH_UNIX, CH_DOS, 
-                                    s, s_len+1,
-                                    ndr->data+ndr->offset, c_len + 1);
+                                    ndr->data+ndr->offset, byte_mul*32);
                if (ret == -1) {
                        return ndr_push_error(ndr, NDR_ERR_CHARCNV, 
                                              "Bad character conversion");
                }
-               ndr->offset += c_len + 1;
+               ndr->offset += byte_mul*32;
                break;
 
        default:
@@ -784,6 +902,40 @@ NTSTATUS ndr_push_string(struct ndr_push *ndr, int ndr_flags, const char *s)
        return NT_STATUS_OK;
 }
 
+/*
+  push a general string onto the wire
+*/
+size_t ndr_string_array_size(struct ndr_push *ndr, const char *s)
+{
+       size_t c_len;
+       unsigned flags = ndr->flags;
+       unsigned byte_mul = 2;
+       unsigned c_len_term = 1;
+
+       if (flags & LIBNDR_FLAG_STR_FIXLEN32) {
+               return 32;
+       }
+       
+       c_len = s?strlen_m(s):0;
+
+       if (flags & (LIBNDR_FLAG_STR_ASCII|LIBNDR_FLAG_STR_UTF8)) {
+               byte_mul = 1;
+       }
+
+       if (flags & LIBNDR_FLAG_STR_NOTERM) {
+               c_len_term = 0;
+       }
+
+       c_len = c_len + c_len_term;
+
+       if (flags & LIBNDR_FLAG_STR_BYTESIZE) {
+               c_len = c_len * byte_mul;
+       }
+
+       return c_len;
+}
+
+
 /*
   push a NTTIME
 */
@@ -802,6 +954,26 @@ NTSTATUS ndr_pull_NTTIME(struct ndr_pull *ndr, NTTIME *t)
        return NT_STATUS_OK;
 }
 
+/*
+  push a NTTIME
+*/
+NTSTATUS ndr_push_NTTIME_1sec(struct ndr_push *ndr, NTTIME t)
+{
+       t /= 10000000;
+       NDR_CHECK(ndr_push_HYPER_T(ndr, t));
+       return NT_STATUS_OK;
+}
+
+/*
+  pull a NTTIME
+*/
+NTSTATUS ndr_pull_NTTIME_1sec(struct ndr_pull *ndr, NTTIME *t)
+{
+       NDR_CHECK(ndr_pull_HYPER_T(ndr, t));
+       (*t) *= 10000000;
+       return NT_STATUS_OK;
+}
+
 /*
   push a time_t
 */
@@ -827,6 +999,25 @@ void ndr_print_struct(struct ndr_print *ndr, const char *name, const char *type)
        ndr->print(ndr, "%s: struct %s", name, type);
 }
 
+void ndr_print_enum(struct ndr_print *ndr, const char *name, const char *type, 
+                   const char *val, uint_t value)
+{
+       if (ndr->flags & LIBNDR_PRINT_ARRAY_HEX) {
+               ndr->print(ndr, "%-25s: %s (0x%X)", name, val?val:"UNKNOWN_ENUM_VALUE", value);
+       } else {
+               ndr->print(ndr, "%-25s: %s (%d)", name, val?val:"UNKNOWN_ENUM_VALUE", value);
+       }
+}
+
+void ndr_print_bitmap_flag(struct ndr_print *ndr, size_t size, const char *flag_name, uint_t flag, uint_t value)
+{
+       /* size can be later used to print something like:
+        * ...1.... .........: FLAG1_NAME
+        * .....0.. .........: FLAG2_NAME
+        */
+       ndr->print(ndr, "%s: %-25s", (flag & value)?"1":"0", flag_name);
+}
+
 void ndr_print_uint8(struct ndr_print *ndr, const char *name, uint8_t v)
 {
        ndr->print(ndr, "%-25s: 0x%02x (%u)", name, v, v);
@@ -842,9 +1033,17 @@ void ndr_print_uint32(struct ndr_print *ndr, const char *name, uint32_t v)
        ndr->print(ndr, "%-25s: 0x%08x (%u)", name, v, v);
 }
 
+void ndr_print_int32(struct ndr_print *ndr, const char *name, int32_t v)
+{
+       ndr->print(ndr, "%-25s: %d", name, v);
+}
+
 void ndr_print_uint64(struct ndr_print *ndr, const char *name, uint64_t v)
 {
-       ndr->print(ndr, "%-25s: 0x%08x%08x", name, (uint32_t)(v >> 32), (uint32_t)(v & 0xFFFFFFFF));
+       ndr->print(ndr, "%-25s: 0x%08x%08x (%llu)", name,
+                  (uint32_t)(v >> 32),
+                  (uint32_t)(v & 0xFFFFFFFF),
+                  v);
 }
 
 void ndr_print_int64(struct ndr_print *ndr, const char *name, int64_t v)
@@ -883,6 +1082,11 @@ void ndr_print_NTTIME(struct ndr_print *ndr, const char *name, NTTIME t)
        ndr->print(ndr, "%-25s: %s", name, nt_time_string(ndr, t));
 }
 
+void ndr_print_NTTIME_1sec(struct ndr_print *ndr, const char *name, NTTIME t)
+{
+       ndr_print_NTTIME(ndr, name, t);
+}
+
 void ndr_print_time_t(struct ndr_print *ndr, const char *name, time_t t)
 {
        if (t == (time_t)-1 || t == 0) {
@@ -892,9 +1096,9 @@ void ndr_print_time_t(struct ndr_print *ndr, const char *name, time_t t)
        }
 }
 
-void ndr_print_union(struct ndr_print *ndr, const char *name, uint16_t level, const char *type)
+void ndr_print_union(struct ndr_print *ndr, const char *name, int level, const char *type)
 {
-       ndr->print(ndr, "%-25s: union %s(case %u)", name, type, level);
+       ndr->print(ndr, "%-25s: union %s(case %d)", name, type, level);
 }
 
 void ndr_print_bad_level(struct ndr_print *ndr, const char *name, uint16_t level)
@@ -902,6 +1106,24 @@ void ndr_print_bad_level(struct ndr_print *ndr, const char *name, uint16_t level
        ndr->print(ndr, "UNKNOWN LEVEL %u", level);
 }
 
+void ndr_print_array_WERROR(struct ndr_print *ndr, const char *name, 
+                           const WERROR *data, uint32_t count)
+{
+       int i;
+
+       ndr->print(ndr, "%s: ARRAY(%d)", name, count);
+       ndr->depth++;
+       for (i=0;i<count;i++) {
+               char *idx=NULL;
+               asprintf(&idx, "[%d]", i);
+               if (idx) {
+                       ndr_print_WERROR(ndr, idx, data[i]);
+                       free(idx);
+               }
+       }
+       ndr->depth--;   
+}
+
 void ndr_print_array_HYPER_T(struct ndr_print *ndr, const char *name, 
                            const HYPER_T *data, uint32_t count)
 {
@@ -984,57 +1206,6 @@ void ndr_print_array_uint8(struct ndr_print *ndr, const char *name,
        ndr->depth--;   
 }
 
-/*
-  build a GUID from a string
-*/
-NTSTATUS GUID_from_string(const char *s, struct GUID *guid)
-{
-        uint32_t time_low;
-        uint32_t time_mid, time_hi_and_version;
-        uint32_t clock_seq[2];
-        uint32_t node[6];
-        int i;
-
-        if (11 != sscanf(s, "%08x-%04x-%04x-%02x%02x-%02x%02x%02x%02x%02x%02x",
-                         &time_low, &time_mid, &time_hi_and_version, 
-                         &clock_seq[0], &clock_seq[1],
-                         &node[0], &node[1], &node[2], &node[3], &node[4], &node[5])) {
-                return NT_STATUS_INVALID_PARAMETER;
-        }
-
-       guid->time_low = time_low;
-       guid->time_mid = time_mid;
-       guid->time_hi_and_version = time_hi_and_version;
-       guid->clock_seq[0] = clock_seq[0];
-       guid->clock_seq[1] = clock_seq[1];
-        for (i=0;i<6;i++) {
-               guid->node[i] = node[i];
-       }
-
-        return NT_STATUS_OK;
-}
-
-/*
-  its useful to be able to display these in debugging messages
-*/
-const char *GUID_string(TALLOC_CTX *mem_ctx, const struct GUID *guid)
-{
-       return talloc_asprintf(mem_ctx, 
-                              "%08x-%04x-%04x-%02x%02x-%02x%02x%02x%02x%02x%02x",
-                              guid->time_low, guid->time_mid,
-                              guid->time_hi_and_version,
-                              guid->clock_seq[0],
-                              guid->clock_seq[1],
-                              guid->node[0], guid->node[1],
-                              guid->node[2], guid->node[3],
-                              guid->node[4], guid->node[5]);
-}
-
-void ndr_print_GUID(struct ndr_print *ndr, const char *name, const struct GUID *guid)
-{
-       ndr->print(ndr, "%-25s: %s", name, GUID_string(ndr, guid));
-}
-
 void ndr_print_DATA_BLOB(struct ndr_print *ndr, const char *name, DATA_BLOB r)
 {
        ndr->print(ndr, "%-25s: DATA_BLOB length=%u", name, r.length);
@@ -1094,3 +1265,15 @@ NTSTATUS ndr_pull_DATA_BLOB(struct ndr_pull *ndr, DATA_BLOB *blob)
        ndr->offset += length;
        return NT_STATUS_OK;
 }
+
+uint32 ndr_size_DATA_BLOB(int ret, const DATA_BLOB *data, int flags)
+{
+       return ret + data->length;
+}
+
+uint32 ndr_size_string(int ret, const char * const* string, int flags) 
+{
+       /* FIXME: Is this correct for all strings ? */
+       if(!(*string)) return ret;
+       return ret+strlen(*string)+1;
+}