r4358: At metze's request, the Christmas elves have removed gensec_end in
[samba.git] / source4 / libcli / auth / spnego.c
index bbf8f86676219469c2799efb356216ad5a72f569..5cce0f9e17909b273d6e74a6d316c16f4e08bc49 100644 (file)
@@ -23,6 +23,7 @@
 */
 
 #include "includes.h"
+#include "auth/auth.h"
 
 #undef DBGC_CLASS
 #define DBGC_CLASS DBGC_AUTH
@@ -37,29 +38,24 @@ enum spnego_state_position {
 };
 
 struct spnego_state {
-       TALLOC_CTX *mem_ctx;
        uint_t ref_count;
        enum spnego_message_type expected_packet;
        enum spnego_state_position state_position;
        struct gensec_security *sub_sec_security;
 };
 
+
 static NTSTATUS gensec_spnego_client_start(struct gensec_security *gensec_security)
 {
        struct spnego_state *spnego_state;
-       TALLOC_CTX *mem_ctx = talloc_init("gensec_spnego_client_start");
-       if (!mem_ctx) {
-               return NT_STATUS_NO_MEMORY;
-       }
-       spnego_state = talloc_p(mem_ctx, struct spnego_state);
-               
+
+       spnego_state = talloc_p(gensec_security, struct spnego_state);          
        if (!spnego_state) {
                return NT_STATUS_NO_MEMORY;
        }
 
        spnego_state->expected_packet = SPNEGO_NEG_TOKEN_INIT;
        spnego_state->state_position = SPNEGO_CLIENT_START;
-       spnego_state->mem_ctx = mem_ctx;
        spnego_state->sub_sec_security = NULL;
 
        gensec_security->private_data = spnego_state;
@@ -69,19 +65,14 @@ static NTSTATUS gensec_spnego_client_start(struct gensec_security *gensec_securi
 static NTSTATUS gensec_spnego_server_start(struct gensec_security *gensec_security)
 {
        struct spnego_state *spnego_state;
-       TALLOC_CTX *mem_ctx = talloc_init("gensec_spnego_server_start");
-       if (!mem_ctx) {
-               return NT_STATUS_NO_MEMORY;
-       }
-       spnego_state = talloc_p(mem_ctx, struct spnego_state);
-               
+
+       spnego_state = talloc_p(gensec_security, struct spnego_state);          
        if (!spnego_state) {
                return NT_STATUS_NO_MEMORY;
        }
 
        spnego_state->expected_packet = SPNEGO_NEG_TOKEN_INIT;
        spnego_state->state_position = SPNEGO_SERVER_START;
-       spnego_state->mem_ctx = mem_ctx;
        spnego_state->sub_sec_security = NULL;
 
        gensec_security->private_data = spnego_state;
@@ -119,7 +110,6 @@ static NTSTATUS gensec_spnego_check_packet(struct gensec_security *gensec_securi
 {
        struct spnego_state *spnego_state = gensec_security->private_data;
 
-       return NT_STATUS_NOT_IMPLEMENTED;
        if (spnego_state->state_position != SPNEGO_DONE 
            && spnego_state->state_position != SPNEGO_FALLBACK) {
                return NT_STATUS_INVALID_PARAMETER;
@@ -140,7 +130,6 @@ static NTSTATUS gensec_spnego_seal_packet(struct gensec_security *gensec_securit
 {
        struct spnego_state *spnego_state = gensec_security->private_data;
 
-       return NT_STATUS_NOT_IMPLEMENTED;
        if (spnego_state->state_position != SPNEGO_DONE 
            && spnego_state->state_position != SPNEGO_FALLBACK) {
                return NT_STATUS_INVALID_PARAMETER;
@@ -229,7 +218,12 @@ static NTSTATUS gensec_spnego_server_try_fallback(struct gensec_security *gensec
                if (!all_ops[i]->oid) {
                        continue;
                }
-               nt_status = gensec_subcontext_start(gensec_security, 
+               if (strcasecmp(GENSEC_OID_SPNEGO,all_ops[i]->oid) == 0) {
+                       continue;
+               }
+
+               nt_status = gensec_subcontext_start(spnego_state, 
+                                                   gensec_security, 
                                                    &spnego_state->sub_sec_security);
                if (!NT_STATUS_IS_OK(nt_status)) {
                        return nt_status;
@@ -238,8 +232,9 @@ static NTSTATUS gensec_spnego_server_try_fallback(struct gensec_security *gensec
                nt_status = gensec_start_mech_by_oid(spnego_state->sub_sec_security,
                                                     all_ops[i]->oid);
                if (!NT_STATUS_IS_OK(nt_status)) {
-                       gensec_end(&spnego_state->sub_sec_security);
-                                       continue;
+                       talloc_free(spnego_state->sub_sec_security);
+                       spnego_state->sub_sec_security = NULL;
+                       continue;
                }
                nt_status = gensec_update(spnego_state->sub_sec_security,
                                                          out_mem_ctx, in, out);
@@ -247,7 +242,8 @@ static NTSTATUS gensec_spnego_server_try_fallback(struct gensec_security *gensec
                        spnego_state->state_position = SPNEGO_FALLBACK;
                        return nt_status;
                }
-               gensec_end(&spnego_state->sub_sec_security);
+               talloc_free(spnego_state->sub_sec_security);
+               spnego_state->sub_sec_security = NULL;
        }
        DEBUG(1, ("Failed to parse SPNEGO request\n"));
        return NT_STATUS_INVALID_PARAMETER;
@@ -265,7 +261,8 @@ static NTSTATUS gensec_spnego_parse_negTokenInit(struct gensec_security *gensec_
        DATA_BLOB null_data_blob = data_blob(NULL,0);
 
        for (i=0; mechType && mechType[i]; i++) {
-               nt_status = gensec_subcontext_start(gensec_security,
+               nt_status = gensec_subcontext_start(spnego_state,
+                                                   gensec_security,
                                                    &spnego_state->sub_sec_security);
                if (!NT_STATUS_IS_OK(nt_status)) {
                        break;
@@ -274,7 +271,8 @@ static NTSTATUS gensec_spnego_parse_negTokenInit(struct gensec_security *gensec_
                nt_status = gensec_start_mech_by_oid(spnego_state->sub_sec_security,
                                                     mechType[i]);
                if (!NT_STATUS_IS_OK(nt_status)) {
-                       gensec_end(&spnego_state->sub_sec_security);
+                       talloc_free(spnego_state->sub_sec_security);
+                       spnego_state->sub_sec_security = NULL;
                        continue;
                }
                
@@ -290,19 +288,18 @@ static NTSTATUS gensec_spnego_parse_negTokenInit(struct gensec_security *gensec_
                                                  null_data_blob, 
                                                  unwrapped_out);
                }
-               if (!NT_STATUS_EQUAL(nt_status, NT_STATUS_MORE_PROCESSING_REQUIRED) 
-                   && (!NT_STATUS_IS_OK(nt_status))) {
+               if (!NT_STATUS_EQUAL(nt_status, NT_STATUS_MORE_PROCESSING_REQUIRED) && !NT_STATUS_IS_OK(nt_status)) {
                        DEBUG(1, ("SPNEGO(%s) NEG_TOKEN_INIT failed: %s\n", 
                                  spnego_state->sub_sec_security->ops->name, nt_errstr(nt_status)));
-                               gensec_end(&spnego_state->sub_sec_security);
-               } else {
-                       break;
+                       talloc_free(spnego_state->sub_sec_security);
+                       spnego_state->sub_sec_security = NULL;
                }
+               return nt_status;
        }
        if (!mechType || !mechType[i]) {
                DEBUG(1, ("SPNEGO: Could not find a suitable mechtype in NEG_TOKEN_INIT\n"));
        }
-       return nt_status;
+       return NT_STATUS_INVALID_PARAMETER;
 }
 
 /** create a client negTokenInit 
@@ -320,14 +317,15 @@ static NTSTATUS gensec_spnego_client_negTokenInit(struct gensec_security *gensec
        const char **mechTypes = NULL;
        DATA_BLOB unwrapped_out = data_blob(NULL,0);
 
-       mechTypes = gensec_security_oids(out_mem_ctx, OID_SPNEGO);
+       mechTypes = gensec_security_oids(out_mem_ctx, GENSEC_OID_SPNEGO);
 
        if (!mechTypes) {
                DEBUG(1, ("no GENSEC OID backends available\n"));
                return NT_STATUS_INVALID_PARAMETER;
        }
 
-       nt_status = gensec_subcontext_start(gensec_security, 
+       nt_status = gensec_subcontext_start(spnego_state, 
+                                           gensec_security, 
                                            &spnego_state->sub_sec_security);
        if (!NT_STATUS_IS_OK(nt_status)) {
                return nt_status;
@@ -336,8 +334,9 @@ static NTSTATUS gensec_spnego_client_negTokenInit(struct gensec_security *gensec
        nt_status = gensec_start_mech_by_oid(spnego_state->sub_sec_security,
                                             mechTypes[0]);
        if (!NT_STATUS_IS_OK(nt_status)) {
-               gensec_end(&spnego_state->sub_sec_security);
-                       return nt_status;
+               talloc_free(spnego_state->sub_sec_security);
+               spnego_state->sub_sec_security = NULL;
+               return nt_status;
        }
        nt_status = gensec_update(spnego_state->sub_sec_security,
                                  out_mem_ctx, in, &unwrapped_out);
@@ -359,7 +358,8 @@ static NTSTATUS gensec_spnego_client_negTokenInit(struct gensec_security *gensec
                spnego_state->state_position = SPNEGO_CLIENT_TARG;
                return nt_status;
        }
-       gensec_end(&spnego_state->sub_sec_security);
+       talloc_free(spnego_state->sub_sec_security);
+       spnego_state->sub_sec_security = NULL;
 
        DEBUG(1, ("Failed to setup SPNEGO netTokenInit request\n"));
        return NT_STATUS_INVALID_PARAMETER;
@@ -382,25 +382,28 @@ static NTSTATUS gensec_spnego_server_negTokenTarg(struct gensec_security *gensec
 
        /* compose reply */
        spnego_out.type = SPNEGO_NEG_TOKEN_TARG;
-       spnego_out.negTokenTarg.supportedMech 
-               = spnego_state->sub_sec_security->ops->oid;
        spnego_out.negTokenTarg.responseToken = unwrapped_out;
        spnego_out.negTokenTarg.mechListMIC = null_data_blob;
-       
+       spnego_out.negTokenTarg.supportedMech = NULL;
+
        if (NT_STATUS_EQUAL(nt_status, NT_STATUS_MORE_PROCESSING_REQUIRED)) {
+               spnego_out.negTokenTarg.supportedMech
+                       = spnego_state->sub_sec_security->ops->oid;
                spnego_out.negTokenTarg.negResult = SPNEGO_ACCEPT_INCOMPLETE;
                spnego_state->state_position = SPNEGO_SERVER_TARG;
        } else if (NT_STATUS_IS_OK(nt_status)) {
+               if (unwrapped_out.data) {
+                       spnego_out.negTokenTarg.supportedMech
+                               = spnego_state->sub_sec_security->ops->oid;
+               }
                spnego_out.negTokenTarg.negResult = SPNEGO_ACCEPT_COMPLETED;
                spnego_state->state_position = SPNEGO_DONE;
        } else {
                spnego_out.negTokenTarg.negResult = SPNEGO_REJECT;
-               DEBUG(1, ("SPNEGO(%s) login failed: %s\n", 
-                         spnego_state->sub_sec_security->ops->name, 
-                         nt_errstr(nt_status)));
+               DEBUG(1, ("SPNEGO login failed: %s\n", nt_errstr(nt_status)));
                spnego_state->state_position = SPNEGO_DONE;
        }
-       
+
        if (spnego_write_data(out_mem_ctx, out, &spnego_out) == -1) {
                DEBUG(1, ("Failed to write SPNEGO reply to NEG_TOKEN_TARG\n"));
                return NT_STATUS_INVALID_PARAMETER;
@@ -426,7 +429,7 @@ static NTSTATUS gensec_spnego_update(struct gensec_security *gensec_security, TA
        *out = data_blob(NULL, 0);
 
        if (!out_mem_ctx) {
-               out_mem_ctx = spnego_state->mem_ctx;
+               out_mem_ctx = spnego_state;
        }
 
        /* and switch into the state machine */
@@ -450,7 +453,7 @@ static NTSTATUS gensec_spnego_update(struct gensec_security *gensec_security, TA
                        if (spnego.type != spnego_state->expected_packet) {
                                DEBUG(1, ("Invalid SPNEGO request: %d, expected %d\n", spnego.type, 
                                          spnego_state->expected_packet));
-                               dump_data(1, (const char *)in.data, in.length);
+                               dump_data(1, in.data, in.length);
                                spnego_free_data(&spnego);
                                return NT_STATUS_INVALID_PARAMETER;
                        }
@@ -473,12 +476,13 @@ static NTSTATUS gensec_spnego_update(struct gensec_security *gensec_security, TA
                        
                        return nt_status;
                } else {
-                       const char **mechlist = gensec_security_oids(out_mem_ctx, OID_SPNEGO);
+                       const char **mechlist = gensec_security_oids(out_mem_ctx, GENSEC_OID_SPNEGO);
 
                        spnego_out.type = SPNEGO_NEG_TOKEN_INIT;
                        spnego_out.negTokenInit.mechTypes = mechlist;
                        spnego_out.negTokenInit.reqFlags = 0;
-                       spnego_out.negTokenInit.mechListMIC = null_data_blob;
+                       spnego_out.negTokenInit.mechListMIC
+                               = data_blob_string_const(gensec_get_target_principal(gensec_security));
                        spnego_out.negTokenInit.mechToken = unwrapped_out;
                        
                        if (spnego_write_data(out_mem_ctx, out, &spnego_out) == -1) {
@@ -498,19 +502,20 @@ static NTSTATUS gensec_spnego_update(struct gensec_security *gensec_security, TA
        {
                /* The server offers a list of mechanisms */
                
-               char *my_mechs[] = {NULL, NULL};
+               const char *my_mechs[] = {NULL, NULL};
                NTSTATUS nt_status = NT_STATUS_INVALID_PARAMETER;
 
                if (!in.length) {
                        /* client to produce negTokenInit */
-                       return gensec_spnego_client_negTokenInit(gensec_security, spnego_state, out_mem_ctx, in, out);
+                       return gensec_spnego_client_negTokenInit(gensec_security, spnego_state, 
+                                                                out_mem_ctx, in, out);
                }
                
                len = spnego_read_data(in, &spnego);
                
                if (len == -1) {
                        DEBUG(1, ("Invalid SPNEGO request:\n"));
-                       dump_data(1, (const char *)in.data, in.length);
+                       dump_data(1, in.data, in.length);
                        return NT_STATUS_INVALID_PARAMETER;
                }
                
@@ -518,7 +523,7 @@ static NTSTATUS gensec_spnego_update(struct gensec_security *gensec_security, TA
                if (spnego.type != spnego_state->expected_packet) {
                        DEBUG(1, ("Invalid SPNEGO request: %d, expected %d\n", spnego.type, 
                                  spnego_state->expected_packet));
-                       dump_data(1, (const char *)in.data, in.length);
+                       dump_data(1, in.data, in.length);
                        spnego_free_data(&spnego);
                        return NT_STATUS_INVALID_PARAMETER;
                }
@@ -576,7 +581,7 @@ static NTSTATUS gensec_spnego_update(struct gensec_security *gensec_security, TA
                
                if (len == -1) {
                        DEBUG(1, ("Invalid SPNEGO request:\n"));
-                       dump_data(1, (const char *)in.data, in.length);
+                       dump_data(1, in.data, in.length);
                        return NT_STATUS_INVALID_PARAMETER;
                }
                
@@ -584,7 +589,7 @@ static NTSTATUS gensec_spnego_update(struct gensec_security *gensec_security, TA
                if (spnego.type != spnego_state->expected_packet) {
                        DEBUG(1, ("Invalid SPNEGO request: %d, expected %d\n", spnego.type, 
                                  spnego_state->expected_packet));
-                       dump_data(1, (const char *)in.data, in.length);
+                       dump_data(1, in.data, in.length);
                        spnego_free_data(&spnego);
                        return NT_STATUS_INVALID_PARAMETER;
                }
@@ -616,7 +621,7 @@ static NTSTATUS gensec_spnego_update(struct gensec_security *gensec_security, TA
                
                if (len == -1) {
                        DEBUG(1, ("Invalid SPNEGO request:\n"));
-                       dump_data(1, (const char *)in.data, in.length);
+                       dump_data(1, in.data, in.length);
                        return NT_STATUS_INVALID_PARAMETER;
                }
                
@@ -624,7 +629,7 @@ static NTSTATUS gensec_spnego_update(struct gensec_security *gensec_security, TA
                if (spnego.type != spnego_state->expected_packet) {
                        DEBUG(1, ("Invalid SPNEGO request: %d, expected %d\n", spnego.type, 
                                  spnego_state->expected_packet));
-                       dump_data(1, (const char *)in.data, in.length);
+                       dump_data(1, in.data, in.length);
                        spnego_free_data(&spnego);
                        return NT_STATUS_INVALID_PARAMETER;
                }
@@ -693,24 +698,11 @@ static NTSTATUS gensec_spnego_update(struct gensec_security *gensec_security, TA
        return NT_STATUS_INVALID_PARAMETER;
 }
 
-static void gensec_spnego_end(struct gensec_security *gensec_security)
-{
-       struct spnego_state *spnego_state = gensec_security->private_data;
-
-       if (spnego_state->sub_sec_security) {
-               gensec_end(&spnego_state->sub_sec_security);
-       }
-
-       talloc_destroy(spnego_state->mem_ctx);
-
-       gensec_security->private_data = NULL;
-}
-
 static const struct gensec_security_ops gensec_spnego_security_ops = {
        .name           = "spnego",
        .sasl_name      = "GSS-SPNEGO",
        .auth_type      = DCERPC_AUTH_TYPE_SPNEGO,
-       .oid            = OID_SPNEGO,
+       .oid            = GENSEC_OID_SPNEGO,
        .client_start   = gensec_spnego_client_start,
        .server_start   = gensec_spnego_server_start,
        .update         = gensec_spnego_update,
@@ -721,13 +713,12 @@ static const struct gensec_security_ops gensec_spnego_security_ops = {
        .unseal_packet  = gensec_spnego_unseal_packet,
        .session_key    = gensec_spnego_session_key,
        .session_info   = gensec_spnego_session_info,
-       .end            = gensec_spnego_end
 };
 
 NTSTATUS gensec_spnego_init(void)
 {
        NTSTATUS ret;
-       ret = register_backend("gensec", &gensec_spnego_security_ops);
+       ret = gensec_register(&gensec_spnego_security_ops);
        if (!NT_STATUS_IS_OK(ret)) {
                DEBUG(0,("Failed to register '%s' gensec backend!\n",
                        gensec_spnego_security_ops.name));