added new function "ldb_msg_add_dn"
[samba.git] / source4 / dsdb / samdb / ldb_modules / extended_dn_out.c
index 058c51bdb88834814d58fe20d86a02d1d0e1b8fe..1249a9cdfa8dae065f120b9ef6f83f019a5814d7 100644 (file)
@@ -2,7 +2,7 @@
    ldb database library
 
    Copyright (C) Simo Sorce 2005-2008
-   Copyright (C) Andrew Bartlett <abartlet@samba.org> 2007-2008
+   Copyright (C) Andrew Bartlett <abartlet@samba.org> 2007-2009
 
    This program is free software; you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
 #include "includes.h"
 #include "ldb/include/ldb.h"
 #include "ldb/include/ldb_errors.h"
-#include "ldb/include/ldb_private.h"
+#include "ldb/include/ldb_module.h"
+#include "libcli/security/dom_sid.h"
 #include "librpc/gen_ndr/ndr_misc.h"
+#include "librpc/gen_ndr/ndr_security.h"
 #include "librpc/ndr/libndr.h"
 #include "dsdb/samdb/samdb.h"
 
@@ -59,42 +61,42 @@ static bool is_attr_in_list(const char * const * attrs, const char *attr)
 
 static char **copy_attrs(void *mem_ctx, const char * const * attrs)
 {
-       char **new;
+       char **nattrs;
        int i, num;
 
        for (num = 0; attrs[num]; num++);
 
-       new = talloc_array(mem_ctx, char *, num + 1);
-       if (!new) return NULL;
+       nattrs = talloc_array(mem_ctx, char *, num + 1);
+       if (!nattrs) return NULL;
 
        for(i = 0; i < num; i++) {
-               new[i] = talloc_strdup(new, attrs[i]);
-               if (!new[i]) {
-                       talloc_free(new);
+               nattrs[i] = talloc_strdup(nattrs, attrs[i]);
+               if (!nattrs[i]) {
+                       talloc_free(nattrs);
                        return NULL;
                }
        }
-       new[i] = NULL;
+       nattrs[i] = NULL;
 
-       return new;
+       return nattrs;
 }
 
 static bool add_attrs(void *mem_ctx, char ***attrs, const char *attr)
 {
-       char **new;
+       char **nattrs;
        int num;
 
        for (num = 0; (*attrs)[num]; num++);
 
-       new = talloc_realloc(mem_ctx, *attrs, char *, num + 2);
-       if (!new) return false;
+       nattrs = talloc_realloc(mem_ctx, *attrs, char *, num + 2);
+       if (!nattrs) return false;
 
-       *attrs = new;
+       *attrs = nattrs;
 
-       new[num] = talloc_strdup(new, attr);
-       if (!new[num]) return false;
+       nattrs[num] = talloc_strdup(nattrs, attr);
+       if (!nattrs[num]) return false;
 
-       new[num + 1] = NULL;
+       nattrs[num + 1] = NULL;
 
        return true;
 }
@@ -172,7 +174,7 @@ static int inject_extended_dn_out(struct ldb_reply *ares,
        return LDB_SUCCESS;
 }
 
-static int handle_dereference(struct ldb_dn *dn,
+static int handle_dereference_openldap(struct ldb_dn *dn,
                              struct dsdb_openldap_dereference_result **dereference_attrs, 
                              const char *attr, const DATA_BLOB *val)
 {
@@ -228,6 +230,81 @@ static int handle_dereference(struct ldb_dn *dn,
        return LDB_SUCCESS;
 }
 
+static int handle_dereference_fds(struct ldb_dn *dn,
+                             struct dsdb_openldap_dereference_result **dereference_attrs, 
+                             const char *attr, const DATA_BLOB *val)
+{
+       const struct ldb_val *nsUniqueIdBlob, *sidBlob;
+       struct ldb_message fake_msg; /* easier to use routines that expect an ldb_message */
+       int j;
+       
+       fake_msg.num_elements = 0;
+                       
+       /* Look for this attribute in the returned control */
+       for (j = 0; dereference_attrs && dereference_attrs[j]; j++) {
+               struct ldb_val source_dn = data_blob_string_const(dereference_attrs[j]->dereferenced_dn);
+               if (ldb_attr_cmp(dereference_attrs[j]->source_attribute, attr) == 0
+                   && data_blob_cmp(&source_dn, val) == 0) {
+                       fake_msg.num_elements = dereference_attrs[j]->num_attributes;
+                       fake_msg.elements = dereference_attrs[j]->attributes;
+                       break;
+               }
+       }
+       if (!fake_msg.num_elements) {
+               return LDB_SUCCESS;
+       }
+
+       /* Look for the nsUniqueId */
+       
+       nsUniqueIdBlob = ldb_msg_find_ldb_val(&fake_msg, "nsUniqueId");
+       if (nsUniqueIdBlob) {
+               NTSTATUS status;
+               enum ndr_err_code ndr_err;
+               
+               struct ldb_val guid_blob;
+               struct GUID guid;
+               
+               status = NS_GUID_from_string((char *)nsUniqueIdBlob->data, &guid);
+               
+               if (!NT_STATUS_IS_OK(status)) {
+                       return LDB_ERR_INVALID_DN_SYNTAX;
+               }
+               ndr_err = ndr_push_struct_blob(&guid_blob, NULL, NULL, &guid,
+                                               (ndr_push_flags_fn_t)ndr_push_GUID);
+               if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
+                       return LDB_ERR_INVALID_DN_SYNTAX;
+               }
+               
+               ldb_dn_set_extended_component(dn, "GUID", &guid_blob);
+       }
+       
+       /* Look for the objectSID */
+
+       sidBlob = ldb_msg_find_ldb_val(&fake_msg, "sambaSID");
+       if (sidBlob) {
+               enum ndr_err_code ndr_err;
+
+               struct ldb_val sid_blob;
+               struct dom_sid *sid;
+
+               sid = dom_sid_parse_length(NULL, sidBlob);
+
+               if (sid == NULL) {
+                       return LDB_ERR_INVALID_DN_SYNTAX;
+               }
+
+               ndr_err = ndr_push_struct_blob(&sid_blob, NULL, NULL, sid,
+                                               (ndr_push_flags_fn_t)ndr_push_dom_sid);
+               talloc_free(sid);
+               if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
+                       return LDB_ERR_INVALID_DN_SYNTAX;
+               }
+
+               ldb_dn_set_extended_component(dn, "SID", &sid_blob);
+       }
+       return LDB_SUCCESS;
+}
+
 /* search */
 struct extended_search_context {
        struct ldb_module *module;
@@ -239,18 +316,21 @@ struct extended_search_context {
        int extended_type;
 };
 
-static int extended_callback(struct ldb_request *req, struct ldb_reply *ares)
+static int extended_callback(struct ldb_request *req, struct ldb_reply *ares,
+               int (*handle_dereference)(struct ldb_dn *dn,
+                               struct dsdb_openldap_dereference_result **dereference_attrs, 
+                               const char *attr, const DATA_BLOB *val))
 {
        struct extended_search_context *ac;
        struct ldb_control *control;
        struct dsdb_openldap_dereference_result_control *dereference_control = NULL;
        int ret, i, j;
        struct ldb_message *msg = ares->message;
-       struct extended_dn_out_private *private;
-
+       struct extended_dn_out_private *p;
+       struct ldb_context *ldb;
        ac = talloc_get_type(req->context, struct extended_search_context);
-       private = talloc_get_type(ac->module->private_data, struct extended_dn_out_private);
-
+       p = talloc_get_type(ldb_module_get_private(ac->module), struct extended_dn_out_private);
+       ldb = ldb_module_get_ctx(ac->module);
        if (!ares) {
                return ldb_module_done(ac->req, NULL, NULL,
                                        LDB_ERR_OPERATIONS_ERROR);
@@ -271,7 +351,7 @@ static int extended_callback(struct ldb_request *req, struct ldb_reply *ares)
                break;
        }
 
-       if (private && private->normalise) {
+       if (p && p->normalise) {
                ret = fix_dn(ares->message->dn);
                if (ret != LDB_SUCCESS) {
                        return ldb_module_done(ac->req, NULL, NULL, ret);
@@ -281,7 +361,7 @@ static int extended_callback(struct ldb_request *req, struct ldb_reply *ares)
        if (ac->inject) {
                /* for each record returned post-process to add any derived
                   attributes that have been asked for */
-               ret = inject_extended_dn_out(ares, ac->module->ldb,
+               ret = inject_extended_dn_out(ares, ldb,
                                             ac->extended_type, ac->remove_guid,
                                             ac->remove_sid);
                if (ret != LDB_SUCCESS) {
@@ -289,7 +369,7 @@ static int extended_callback(struct ldb_request *req, struct ldb_reply *ares)
                }
        }
 
-       if ((private && private->normalise) || ac->inject) {
+       if ((p && p->normalise) || ac->inject) {
                const struct ldb_val *val = ldb_msg_find_ldb_val(ares->message, "distinguishedName");
                if (val) {
                        ldb_msg_remove_attr(ares->message, "distinguishedName");
@@ -297,17 +377,18 @@ static int extended_callback(struct ldb_request *req, struct ldb_reply *ares)
                                ret = ldb_msg_add_steal_string(ares->message, "distinguishedName", 
                                                               ldb_dn_get_extended_linearized(ares->message, ares->message->dn, ac->extended_type));
                        } else {
-                               ret = ldb_msg_add_string(ares->message, "distinguishedName", 
-                                                        ldb_dn_get_linearized(ares->message->dn));
+                               ret = ldb_msg_add_dn(ares->message,
+                                                    "distinguishedName",
+                                                    ares->message->dn);
                        }
                        if (ret != LDB_SUCCESS) {
-                               ldb_oom(ac->module->ldb);
+                               ldb_oom(ldb);
                                return LDB_ERR_OPERATIONS_ERROR;
                        }
                }
        }
 
-       if (private && private->dereference) {
+       if (p && p->dereference) {
                control = ldb_reply_get_control(ares, DSDB_OPENLDAP_DEREFERENCE_CONTROL);
        
                if (control && control->data) {
@@ -323,13 +404,13 @@ static int extended_callback(struct ldb_request *req, struct ldb_reply *ares)
                        continue;
                }
 
-               if (private->normalise) {
+               if (p->normalise) {
                        /* If we are also in 'normalise' mode, then
                         * fix the attribute names to be in the
                         * correct case */
                        msg->elements[i].name = talloc_strdup(msg->elements, attribute->lDAPDisplayName);
                        if (!msg->elements[i].name) {
-                               ldb_oom(ac->module->ldb);
+                               ldb_oom(ldb);
                                return ldb_module_done(ac->req, NULL, NULL, LDB_ERR_OPERATIONS_ERROR);
                        }
                }
@@ -340,20 +421,32 @@ static int extended_callback(struct ldb_request *req, struct ldb_reply *ares)
                }
 
                /* Look to see if this attributeSyntax is a DN */
-               if (strcmp(attribute->attributeSyntax_oid, "2.5.5.1") != 0) {
+               if (dsdb_dn_oid_to_format(attribute->syntax->ldap_oid) == DSDB_INVALID_DN) {
                        continue;
                }
 
                for (j = 0; j < msg->elements[i].num_values; j++) {
                        const char *dn_str;
-                       struct ldb_dn *dn = ldb_dn_from_ldb_val(ac, ac->module->ldb, &msg->elements[i].values[j]);
-                       if (!dn || !ldb_dn_validate(dn)) {
+                       struct ldb_dn *dn;
+                       struct dsdb_dn *dsdb_dn = NULL;
+                       struct ldb_val *plain_dn = &msg->elements[i].values[j];         
+                       dsdb_dn = dsdb_dn_parse(msg, ldb, plain_dn, attribute->syntax->ldap_oid);
+                       
+                       if (!dsdb_dn || !ldb_dn_validate(dsdb_dn->dn)) {
+                               ldb_asprintf_errstring(ldb, 
+                                                      "could not parse %.*s in %s on %s as a %s DN", 
+                                                      (int)plain_dn->length, plain_dn->data,
+                                                      msg->elements[i].name, ldb_dn_get_linearized(msg->dn),
+                                                      attribute->syntax->ldap_oid);
+                               talloc_free(dsdb_dn);
                                return ldb_module_done(ac->req, NULL, NULL, LDB_ERR_INVALID_DN_SYNTAX);
                        }
+                       dn = dsdb_dn->dn;
 
-                       if (private->normalise) {
+                       if (p->normalise) {
                                ret = fix_dn(dn);
                                if (ret != LDB_SUCCESS) {
+                                       talloc_free(dsdb_dn);
                                        return ldb_module_done(ac->req, NULL, NULL, ret);
                                }
                        }
@@ -372,31 +465,48 @@ static int extended_callback(struct ldb_request *req, struct ldb_reply *ares)
                                                         msg->elements[i].name,
                                                         &msg->elements[i].values[j]);
                                if (ret != LDB_SUCCESS) {
+                                       talloc_free(dsdb_dn);
                                        return ldb_module_done(ac->req, NULL, NULL, ret);
                                }
                        }
                        
                        if (!ac->inject) {
-                               dn_str = talloc_steal(msg->elements[i].values, 
-                                                     ldb_dn_get_linearized(dn));
+                               dn_str = dsdb_dn_get_linearized(msg->elements[i].values, 
+                                                               dsdb_dn);
                        } else {
-                               dn_str = talloc_steal(msg->elements[i].values, 
-                                                     ldb_dn_get_extended_linearized(msg->elements[i].values, 
-                                                                                    dn, ac->extended_type));
+                               dn_str = dsdb_dn_get_extended_linearized(msg->elements[i].values, 
+                                                                        dsdb_dn, ac->extended_type);
                        }
+                       
                        if (!dn_str) {
-                               ldb_oom(ac->module->ldb);
+                               ldb_oom(ldb);
+                               talloc_free(dsdb_dn);
                                return ldb_module_done(ac->req, NULL, NULL, LDB_ERR_OPERATIONS_ERROR);
                        }
                        msg->elements[i].values[j] = data_blob_string_const(dn_str);
-                       talloc_free(dn);
+                       talloc_free(dsdb_dn);
                }
        }
        return ldb_module_send_entry(ac->req, msg, ares->controls);
 }
 
+static int extended_callback_ldb(struct ldb_request *req, struct ldb_reply *ares)
+{
+       return extended_callback(req, ares, NULL);
+}
+
+static int extended_callback_openldap(struct ldb_request *req, struct ldb_reply *ares)
+{
+       return extended_callback(req, ares, handle_dereference_openldap);
+}
+
+static int extended_callback_fds(struct ldb_request *req, struct ldb_reply *ares)
+{
+       return extended_callback(req, ares, handle_dereference_fds);
+}
 
-static int extended_dn_out_search(struct ldb_module *module, struct ldb_request *req)
+static int extended_dn_out_search(struct ldb_module *module, struct ldb_request *req,
+               int (*callback)(struct ldb_request *req, struct ldb_reply *ares))
 {
        struct ldb_control *control;
        struct ldb_control *storage_format_control;
@@ -406,9 +516,10 @@ static int extended_dn_out_search(struct ldb_module *module, struct ldb_request
        struct ldb_request *down_req;
        char **new_attrs;
        const char * const *const_attrs;
+       struct ldb_context *ldb = ldb_module_get_ctx(module);
        int ret;
 
-       struct extended_dn_out_private *private = talloc_get_type(module->private_data, struct extended_dn_out_private);
+       struct extended_dn_out_private *p = talloc_get_type(ldb_module_get_private(module), struct extended_dn_out_private);
 
        /* check if there's an extended dn control */
        control = ldb_request_get_control(req, LDB_CONTROL_EXTENDED_DN_OID);
@@ -426,19 +537,19 @@ static int extended_dn_out_search(struct ldb_module *module, struct ldb_request
        if (!control && storage_format_control && storage_format_control->data) {
                extended_ctrl = talloc_get_type(storage_format_control->data, struct ldb_extended_dn_control);
                if (!extended_ctrl) {
-                       ldb_set_errstring(module->ldb, "extended_dn_out: extended_ctrl was of the wrong data type");
+                       ldb_set_errstring(ldb, "extended_dn_out: extended_ctrl was of the wrong data type");
                        return LDB_ERR_PROTOCOL_ERROR;
                }
        }
 
        ac = talloc_zero(req, struct extended_search_context);
        if (ac == NULL) {
-               ldb_oom(module->ldb);
+               ldb_oom(ldb);
                return LDB_ERR_OPERATIONS_ERROR;
        }
 
        ac->module = module;
-       ac->schema = dsdb_get_schema(module->ldb);
+       ac->schema = dsdb_get_schema(ldb);
        ac->req = req;
        ac->inject = false;
        ac->remove_guid = false;
@@ -450,7 +561,7 @@ static int extended_dn_out_search(struct ldb_module *module, struct ldb_request
         * the extended DN, or we are 'store DN+GUID+SID'
         * (!dereference) mode.  (This is the normal mode for LDB on
         * tdb). */
-       if (control || (storage_format_control && private && !private->dereference)) {
+       if (control || (storage_format_control && p && !p->dereference)) {
                ac->inject = true;
                if (extended_ctrl) {
                        ac->extended_type = extended_ctrl->type;
@@ -469,7 +580,7 @@ static int extended_dn_out_search(struct ldb_module *module, struct ldb_request
                        if (ac->remove_guid || ac->remove_sid) {
                                new_attrs = copy_attrs(ac, req->op.search.attrs);
                                if (new_attrs == NULL) {
-                                       ldb_oom(module->ldb);
+                                       ldb_oom(ldb);
                                        return LDB_ERR_OPERATIONS_ERROR;
                                }
 
@@ -487,13 +598,13 @@ static int extended_dn_out_search(struct ldb_module *module, struct ldb_request
        }
 
        ret = ldb_build_search_req_ex(&down_req,
-                                     module->ldb, ac,
+                                     ldb, ac,
                                      req->op.search.base,
                                      req->op.search.scope,
                                      req->op.search.tree,
                                      const_attrs,
                                      req->controls,
-                                     ac, extended_callback,
+                                     ac, callback,
                                      req);
        if (ret != LDB_SUCCESS) {
                return ret;
@@ -522,10 +633,10 @@ static int extended_dn_out_search(struct ldb_module *module, struct ldb_request
        /* Add in dereference control, if we were asked to, we are
         * using the 'dereference' mode (such as with an OpenLDAP
         * backend) and have the control prepared */
-       if (control && private && private->dereference && private->dereference_control) {
+       if (control && p && p->dereference && p->dereference_control) {
                ret = ldb_request_add_control(down_req,
                                              DSDB_OPENLDAP_DEREFERENCE_CONTROL,
-                                             false, private->dereference_control);
+                                             false, p->dereference_control);
                if (ret != LDB_SUCCESS) {
                        return ret;
                }
@@ -535,25 +646,55 @@ static int extended_dn_out_search(struct ldb_module *module, struct ldb_request
        return ldb_next_request(module, down_req);
 }
 
+static int extended_dn_out_ldb_search(struct ldb_module *module, struct ldb_request *req)
+{
+       return extended_dn_out_search(module, req, extended_callback_ldb);
+}
+
+static int extended_dn_out_openldap_search(struct ldb_module *module, struct ldb_request *req)
+{
+       return extended_dn_out_search(module, req, extended_callback_openldap);
+}
+
+static int extended_dn_out_fds_search(struct ldb_module *module, struct ldb_request *req)
+{
+       return extended_dn_out_search(module, req, extended_callback_fds);
+}
+
 static int extended_dn_out_ldb_init(struct ldb_module *module)
 {
        int ret;
 
-       struct extended_dn_out_private *private = talloc(module, struct extended_dn_out_private);
+       struct extended_dn_out_private *p = talloc(module, struct extended_dn_out_private);
+       struct dsdb_extended_dn_store_format *dn_format;
 
-       module->private_data = private;
+       ldb_module_set_private(module, p);
 
-       if (!private) {
-               ldb_oom(module->ldb);
+       if (!p) {
+               ldb_oom(ldb_module_get_ctx(module));
                return LDB_ERR_OPERATIONS_ERROR;
        }
 
-       private->dereference = false;
-       private->normalise = false;
+       dn_format = talloc(p, struct dsdb_extended_dn_store_format);
+       if (!dn_format) {
+               talloc_free(p);
+               ldb_oom(ldb_module_get_ctx(module));
+               return LDB_ERR_OPERATIONS_ERROR;
+       }
+
+       dn_format->store_extended_dn_in_ldb = true;
+       ret = ldb_set_opaque(ldb_module_get_ctx(module), DSDB_EXTENDED_DN_STORE_FORMAT_OPAQUE_NAME, dn_format);
+       if (ret != LDB_SUCCESS) {
+               talloc_free(p);
+               return ret;
+       }
+
+       p->dereference = false;
+       p->normalise = false;
 
        ret = ldb_mod_register_control(module, LDB_CONTROL_EXTENDED_DN_OID);
        if (ret != LDB_SUCCESS) {
-               ldb_debug(module->ldb, LDB_DEBUG_ERROR,
+               ldb_debug(ldb_module_get_ctx(module), LDB_DEBUG_ERROR,
                        "extended_dn_out: Unable to register control with rootdse!\n");
                return LDB_ERR_OPERATIONS_ERROR;
        }
@@ -561,31 +702,47 @@ static int extended_dn_out_ldb_init(struct ldb_module *module)
        return ldb_next_init(module);
 }
 
-static int extended_dn_out_dereference_init(struct ldb_module *module)
+static int extended_dn_out_dereference_init(struct ldb_module *module, const char *attrs[])
 {
        int ret, i = 0;
-       struct extended_dn_out_private *private;
+       struct extended_dn_out_private *p = talloc_zero(module, struct extended_dn_out_private);
+       struct dsdb_extended_dn_store_format *dn_format;
        struct dsdb_openldap_dereference_control *dereference_control;
        struct dsdb_attribute *cur;
-
+       struct ldb_context *ldb = ldb_module_get_ctx(module);
        struct dsdb_schema *schema;
 
-       module->private_data = private = talloc_zero(module, struct extended_dn_out_private);
+       ldb_module_set_private(module, p);
 
-       if (!private) {
-               ldb_oom(module->ldb);
+       if (!p) {
+               ldb_oom(ldb);
                return LDB_ERR_OPERATIONS_ERROR;
        }
 
-       private->dereference = true;
+       dn_format = talloc(p, struct dsdb_extended_dn_store_format);
+       if (!dn_format) {
+               talloc_free(p);
+               ldb_oom(ldb_module_get_ctx(module));
+               return LDB_ERR_OPERATIONS_ERROR;
+       }
+
+       dn_format->store_extended_dn_in_ldb = false;
+
+       ret = ldb_set_opaque(ldb_module_get_ctx(module), DSDB_EXTENDED_DN_STORE_FORMAT_OPAQUE_NAME, dn_format);
+       if (ret != LDB_SUCCESS) {
+               talloc_free(p);
+               return ret;
+       }
+
+       p->dereference = true;
 
        /* At the moment, servers that need dereference also need the
         * DN and attribute names to be normalised */
-       private->normalise = true;
+       p->normalise = true;
 
        ret = ldb_mod_register_control(module, LDB_CONTROL_EXTENDED_DN_OID);
        if (ret != LDB_SUCCESS) {
-               ldb_debug(module->ldb, LDB_DEBUG_ERROR,
+               ldb_debug(ldb, LDB_DEBUG_ERROR,
                        "extended_dn_out: Unable to register control with rootdse!\n");
                return LDB_ERR_OPERATIONS_ERROR;
        }
@@ -596,41 +753,35 @@ static int extended_dn_out_dereference_init(struct ldb_module *module)
                return ret;
        }
 
-       schema = dsdb_get_schema(module->ldb);
+       schema = dsdb_get_schema(ldb);
        if (!schema) {
                /* No schema on this DB (yet) */
                return LDB_SUCCESS;
        }
 
-       private->dereference_control = dereference_control
-               = talloc_zero(private, struct dsdb_openldap_dereference_control);
+       p->dereference_control = dereference_control
+               = talloc_zero(p, struct dsdb_openldap_dereference_control);
 
-       if (!private->dereference_control) {
-               ldb_oom(module->ldb);
+       if (!p->dereference_control) {
+               ldb_oom(ldb);
                return LDB_ERR_OPERATIONS_ERROR;
        }
        
        for (cur = schema->attributes; cur; cur = cur->next) {
-               static const char *attrs[] = {
-                       "entryUUID",
-                       "objectSID",
-                       NULL
-               };
-
-               if (strcmp(cur->syntax->attributeSyntax_oid, "2.5.5.1") != 0) {
+               if (dsdb_dn_oid_to_format(cur->syntax->ldap_oid) == DSDB_INVALID_DN) {
                        continue;
                }
                dereference_control->dereference
-                       = talloc_realloc(private, dereference_control->dereference, 
+                       = talloc_realloc(p, dereference_control->dereference,
                                         struct dsdb_openldap_dereference *, i + 2);
                if (!dereference_control) {
-                       ldb_oom(module->ldb);
+                       ldb_oom(ldb);
                        return LDB_ERR_OPERATIONS_ERROR;
                }
                dereference_control->dereference[i] = talloc(dereference_control->dereference,  
                                         struct dsdb_openldap_dereference);
                if (!dereference_control->dereference[i]) {
-                       ldb_oom(module->ldb);
+                       ldb_oom(ldb);
                        return LDB_ERR_OPERATIONS_ERROR;
                }
                dereference_control->dereference[i]->source_attribute = cur->lDAPDisplayName;
@@ -641,15 +792,42 @@ static int extended_dn_out_dereference_init(struct ldb_module *module)
        return LDB_SUCCESS;
 }
 
+static int extended_dn_out_openldap_init(struct ldb_module *module)
+{
+       static const char *attrs[] = {
+               "entryUUID",
+               "objectSID",
+               NULL
+       };
+
+       return extended_dn_out_dereference_init(module, attrs);
+}
+
+static int extended_dn_out_fds_init(struct ldb_module *module)
+{
+       static const char *attrs[] = {
+               "nsUniqueId",
+               "objectSID",
+               NULL
+       };
+
+       return extended_dn_out_dereference_init(module, attrs);
+}
+
 _PUBLIC_ const struct ldb_module_ops ldb_extended_dn_out_ldb_module_ops = {
        .name              = "extended_dn_out_ldb",
-       .search            = extended_dn_out_search,
+       .search            = extended_dn_out_ldb_search,
        .init_context      = extended_dn_out_ldb_init,
 };
 
+_PUBLIC_ const struct ldb_module_ops ldb_extended_dn_out_openldap_module_ops = {
+       .name              = "extended_dn_out_openldap",
+       .search            = extended_dn_out_openldap_search,
+       .init_context      = extended_dn_out_openldap_init,
+};
 
-_PUBLIC_ const struct ldb_module_ops ldb_extended_dn_out_dereference_module_ops = {
-       .name              = "extended_dn_out_dereference",
-       .search            = extended_dn_out_search,
-       .init_context      = extended_dn_out_dereference_init,
+_PUBLIC_ const struct ldb_module_ops ldb_extended_dn_out_fds_module_ops = {
+       .name              = "extended_dn_out_fds",
+       .search            = extended_dn_out_fds_search,
+       .init_context      = extended_dn_out_fds_init,
 };