s4:samba_dnsupdate: cache the already registered records

[samba.git] / source4 / dsdb / dns / dns_update.c

diff --git a/source4/dsdb/dns/dns_update.c b/source4/dsdb/dns/dns_update.c
index 6650534d131703a65b1d778f1d92d9765bf94b6d..aa617c6aeca3ca0301c4314fb0c677ca911fb68d 100644 (file)
--- a/source4/dsdb/dns/dns_update.c
+++ b/source4/dsdb/dns/dns_update.c
@@ -35,6 +35,7 @@
 #include "lib/messaging/irpc.h"
 #include "param/param.h"
 #include "system/filesys.h"
+#include "dsdb/common/util.h"
 #include "libcli/composite/composite.h"
 #include "libcli/security/dom_sid.h"
 #include "librpc/gen_ndr/ndr_irpc.h"
@@ -99,28 +100,73 @@ static void dnsupdate_rebuild(struct dnsupdate_service *service)
 {
        int ret;
        size_t size;
-       struct ldb_result *res;
+       struct ldb_result *res1, *res2;
        const char *tmp_path, *path, *path_static;
        char *static_policies;
        int fd;
        unsigned int i;
-       const char *attrs[] = { "sAMAccountName", NULL };
+       const char *attrs1[] = { "msDS-HasDomainNCs", NULL };
+       const char *attrs2[] = { "name", NULL };
        const char *realm = lpcfg_realm(service->task->lp_ctx);
        TALLOC_CTX *tmp_ctx = talloc_new(service);
        const char * const *rndc_command = lpcfg_rndc_command(service->task->lp_ctx);
+       const char **dc_list;
+       int dc_count=0;
 
        /* abort any pending script run */
        TALLOC_FREE(service->confupdate.subreq);
 
-       ret = ldb_search(service->samdb, tmp_ctx, &res, NULL, LDB_SCOPE_SUBTREE,
-                        attrs, "(|(samaccountname=administrator)(&(primaryGroupID=%u)(objectClass=computer)))",
-                        DOMAIN_RID_DCS);
+       /* find the DNs for all the non-RODC DCs in the forest */
+       ret = dsdb_search(service->samdb, tmp_ctx, &res1, ldb_get_config_basedn(service->samdb),
+                         LDB_SCOPE_SUBTREE,
+                         attrs1,
+                         0,
+                         "(&(objectclass=NTDSDSA)(!(msDS-isRODC=TRUE)))");
        if (ret != LDB_SUCCESS) {
                DEBUG(0,(__location__ ": Unable to find DCs list - %s", ldb_errstring(service->samdb)));
                talloc_free(tmp_ctx);
                return;
        }
 
+       dc_list = talloc_array(tmp_ctx, const char *, 0);
+       for (i=0; i<res1->count; i++) {
+               struct ldb_dn *server_dn = res1->msgs[i]->dn;
+               struct ldb_dn *domain_dn;
+               const char *acct_name, *full_account, *dns_domain;
+
+               /* this is a nasty hack to form the account name of
+                * this DC. We do it this way as we don't necessarily
+                * have access to the domain NC, so all we have to go
+                * on is what is in the configuration partition
+                */
+
+               domain_dn = ldb_msg_find_attr_as_dn(service->samdb, tmp_ctx, res1->msgs[i], "msDS-HasDomainNCs");
+               if (domain_dn == NULL) continue;
+
+               ldb_dn_remove_child_components(server_dn, 1);
+               ret = dsdb_search_dn(service->samdb, tmp_ctx, &res2, server_dn, attrs2, 0);
+               if (ret != LDB_SUCCESS) {
+                       continue;
+               }
+
+               acct_name = ldb_msg_find_attr_as_string(res2->msgs[0], "name", NULL);
+               if (acct_name == NULL) continue;
+
+               dns_domain = samdb_dn_to_dns_domain(tmp_ctx, domain_dn);
+               if (dns_domain == NULL) {
+                       continue;
+               }
+
+               full_account = talloc_asprintf(tmp_ctx, "%s$@%s", acct_name, dns_domain);
+               if (full_account == NULL) continue;
+
+               dc_list = talloc_realloc(tmp_ctx, dc_list, const char *, dc_count+1);
+               if (dc_list == NULL) {
+                       continue;
+               }
+               dc_list[dc_count++] = full_account;
+       }
+
        path = lpcfg_parm_string(service->task->lp_ctx, NULL, "dnsupdate", "path");
        if (path == NULL) {
                path = lpcfg_private_path(tmp_ctx, service->task->lp_ctx, "named.conf.update");
@@ -156,14 +202,10 @@ static void dnsupdate_rebuild(struct dnsupdate_service *service)
                dprintf(fd, "/* End of static entries */\n");
        }
        dprintf(fd, "\tgrant %s ms-self * A AAAA;\n", realm);
+       dprintf(fd, "\tgrant Administrator@%s wildcard * A AAAA SRV CNAME;\n", realm);
 
-       for (i=0; i<res->count; i++) {
-               const char *acctname;
-               acctname = ldb_msg_find_attr_as_string(res->msgs[i],
-                                                      "sAMAccountName", NULL);
-               if (!acctname) continue;
-               dprintf(fd, "\tgrant %s@%s wildcard * A AAAA SRV CNAME;\n",
-                       acctname, realm);
+       for (i=0; i<dc_count; i++) {
+               dprintf(fd, "\tgrant %s wildcard * A AAAA SRV CNAME;\n", dc_list[i]);
        }
        dprintf(fd, "};\n");
        close(fd);
@@ -355,6 +397,7 @@ struct dnsupdate_RODC_state {
        struct irpc_message *msg;
        struct dnsupdate_RODC *r;
        char *tmp_path;
+       char *tmp_path2;
        int fd;
 };
 
@@ -364,6 +407,9 @@ static int dnsupdate_RODC_destructor(struct dnsupdate_RODC_state *st)
                close(st->fd);
        }
        unlink(st->tmp_path);
+       if (st->tmp_path2 != NULL) {
+               unlink(st->tmp_path2);
+       }
        return 0;
 }
 
@@ -441,6 +487,13 @@ static NTSTATUS dnsupdate_dnsupdate_RODC(struct irpc_message *msg,
 
        talloc_set_destructor(st, dnsupdate_RODC_destructor);
 
+       st->tmp_path2 = talloc_asprintf(st, "%s.cache", st->tmp_path);
+       if (!st->tmp_path2) {
+               talloc_free(st);
+               r->out.result = NT_STATUS_NO_MEMORY;
+               return NT_STATUS_OK;
+       }
+
        sid_dn = ldb_dn_new_fmt(st, s->samdb, "<SID=%s>", dom_sid_string(st, r->in.dom_sid));
        if (!sid_dn) {
                talloc_free(st);
@@ -533,6 +586,8 @@ static NTSTATUS dnsupdate_dnsupdate_RODC(struct irpc_message *msg,
                                dns_update_command,
                                "--update-list",
                                st->tmp_path,
+                               "--update-cache",
+                               st->tmp_path2,
                                NULL);
        NT_STATUS_HAVE_NO_MEMORY(req);
 
@@ -552,7 +607,7 @@ static void dnsupdate_task_init(struct task_server *task)
        NTSTATUS status;
        struct dnsupdate_service *service;
 
-       if (lpcfg_server_role(task->lp_ctx) != ROLE_DOMAIN_CONTROLLER) {
+       if (lpcfg_server_role(task->lp_ctx) != ROLE_ACTIVE_DIRECTORY_DC) {
                /* not useful for non-DC */
                return;
        }