s4-dsdb: added dsdb_search_by_dn_guid()
[samba.git] / source4 / dsdb / common / util.c
index faa96e6219c201b56e63a87642ef7e63057519f2..7e6090124bed2fe222ba728861554e5c82cab2db 100644 (file)
@@ -24,6 +24,7 @@
 #include "includes.h"
 #include "events/events.h"
 #include "ldb.h"
+#include "ldb_module.h"
 #include "ldb_errors.h"
 #include "../lib/util/util_ldb.h"
 #include "../lib/crypto/crypto.h"
@@ -40,6 +41,9 @@
 #include "system/locale.h"
 #include "lib/util/tsort.h"
 #include "dsdb/common/util.h"
+#include "lib/socket/socket.h"
+#include "dsdb/samdb/ldb_modules/util.h"
+#include "librpc/gen_ndr/irpc.h"
 
 /*
   search the sam for the specified attributes in a specific domain, filter on
@@ -383,7 +387,7 @@ struct dom_sid *samdb_result_dom_sid(TALLOC_CTX *mem_ctx, const struct ldb_messa
        if (sid == NULL) {
                return NULL;
        }
-       ndr_err = ndr_pull_struct_blob(v, sid, NULL, sid,
+       ndr_err = ndr_pull_struct_blob(v, sid, sid,
                                       (ndr_pull_flags_fn_t)ndr_pull_dom_sid);
        if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
                talloc_free(sid);
@@ -518,8 +522,10 @@ NTTIME samdb_result_force_password_change(struct ldb_context *sam_ldb,
                                          struct ldb_dn *domain_dn, 
                                          struct ldb_message *msg)
 {
-       uint64_t attr_time = samdb_result_uint64(msg, "pwdLastSet", 0);
-       uint32_t userAccountControl = samdb_result_uint64(msg, "userAccountControl", 0);
+       int64_t attr_time = samdb_result_int64(msg, "pwdLastSet", 0);
+       uint32_t userAccountControl = ldb_msg_find_attr_as_uint(msg,
+                                                               "userAccountControl",
+                                                               0);
        int64_t maxPwdAge;
 
        /* Machine accounts don't expire, and there is a flag for 'no expiry' */
@@ -531,8 +537,12 @@ NTTIME samdb_result_force_password_change(struct ldb_context *sam_ldb,
        if (attr_time == 0) {
                return 0;
        }
+       if (attr_time == -1) {
+               return 0x7FFFFFFFFFFFFFFFULL;
+       }
 
-       maxPwdAge = samdb_search_int64(sam_ldb, mem_ctx, 0, domain_dn, "maxPwdAge", NULL);
+       maxPwdAge = samdb_search_int64(sam_ldb, mem_ctx, 0, domain_dn,
+                                      "maxPwdAge", NULL);
        if (maxPwdAge == 0) {
                return 0x7FFFFFFFFFFFFFFFULL;
        } else {
@@ -557,7 +567,7 @@ struct samr_Password *samdb_result_hash(TALLOC_CTX *mem_ctx, const struct ldb_me
 }
 
 /*
-  pull an array of samr_Password structutres from a result set. 
+  pull an array of samr_Password structures from a result set.
 */
 unsigned int samdb_result_hashes(TALLOC_CTX *mem_ctx, const struct ldb_message *msg,
                           const char *attr, struct samr_Password **hashes)
@@ -586,12 +596,12 @@ unsigned int samdb_result_hashes(TALLOC_CTX *mem_ctx, const struct ldb_message *
        return count;
 }
 
-NTSTATUS samdb_result_passwords(TALLOC_CTX *mem_ctx, struct loadparm_context *lp_ctx, struct ldb_message *msg, 
+NTSTATUS samdb_result_passwords(TALLOC_CTX *mem_ctx, struct loadparm_context *lp_ctx, struct ldb_message *msg,
                                struct samr_Password **lm_pwd, struct samr_Password **nt_pwd) 
 {
        struct samr_Password *lmPwdHash, *ntPwdHash;
        if (nt_pwd) {
-               int num_nt;
+               unsigned int num_nt;
                num_nt = samdb_result_hashes(mem_ctx, msg, "unicodePwd", &ntPwdHash);
                if (num_nt == 0) {
                        *nt_pwd = NULL;
@@ -605,8 +615,8 @@ NTSTATUS samdb_result_passwords(TALLOC_CTX *mem_ctx, struct loadparm_context *lp
                /* Ensure that if we have turned off LM
                 * authentication, that we never use the LM hash, even
                 * if we store it */
-               if (lp_lanman_auth(lp_ctx)) {
-                       int num_lm;
+               if (lpcfg_lanman_auth(lp_ctx)) {
+                       unsigned int num_lm;
                        num_lm = samdb_result_hashes(mem_ctx, msg, "dBCSPwd", &lmPwdHash);
                        if (num_lm == 0) {
                                *lm_pwd = NULL;
@@ -628,18 +638,25 @@ NTSTATUS samdb_result_passwords(TALLOC_CTX *mem_ctx, struct loadparm_context *lp
 struct samr_LogonHours samdb_result_logon_hours(TALLOC_CTX *mem_ctx, struct ldb_message *msg, const char *attr)
 {
        struct samr_LogonHours hours;
-       const int units_per_week = 168;
+       size_t units_per_week = 168;
        const struct ldb_val *val = ldb_msg_find_ldb_val(msg, attr);
+
        ZERO_STRUCT(hours);
-       hours.bits = talloc_array(mem_ctx, uint8_t, units_per_week);
+
+       if (val) {
+               units_per_week = val->length * 8;
+       }
+
+       hours.bits = talloc_array(mem_ctx, uint8_t, units_per_week/8);
        if (!hours.bits) {
                return hours;
        }
        hours.units_per_week = units_per_week;
-       memset(hours.bits, 0xFF, units_per_week);
+       memset(hours.bits, 0xFF, units_per_week/8);
        if (val) {
-               memcpy(hours.bits, val->data, MIN(val->length, units_per_week));
+               memcpy(hours.bits, val->data, val->length);
        }
+
        return hours;
 }
 
@@ -704,7 +721,7 @@ struct ldb_message_element *samdb_find_attribute(struct ldb_context *ldb,
                                                 const struct ldb_message *msg, 
                                                 const char *name, const char *value)
 {
-       int i;
+       unsigned int i;
        struct ldb_message_element *el = ldb_msg_find_element(msg, name);
 
        if (!el) {
@@ -720,6 +737,47 @@ struct ldb_message_element *samdb_find_attribute(struct ldb_context *ldb,
        return NULL;
 }
 
+/*
+ * This is intended for use by the "password hash" module since there
+ * password changes can be specified through one message element with the
+ * new password (to set) and another one with the old password (to unset).
+ *
+ * The first which sets a password (new value) can have flags
+ * (LDB_FLAG_MOD_ADD, LDB_FLAG_MOD_REPLACE) but also none (on "add" operations
+ * for entries). The latter (old value) has always specified
+ * LDB_FLAG_MOD_DELETE.
+ *
+ * Returns LDB_ERR_NO_SUCH_ATTRIBUTE if the attribute which should be deleted
+ * doesn't contain only one value (this is the Windows Server behaviour)
+ * otherwise LDB_SUCCESS.
+ */
+int samdb_msg_find_old_and_new_ldb_val(const struct ldb_message *msg,
+                                      const char *name,
+                                      const struct ldb_val **new_val,
+                                      const struct ldb_val **old_val)
+{
+       unsigned int i;
+
+       *new_val = NULL;
+       *old_val = NULL;
+
+       if (msg == NULL) {
+               return LDB_SUCCESS;
+       }
+
+       for (i = 0; i < msg->num_elements; i++) {
+               if (ldb_attr_cmp(msg->elements[i].name, name) == 0) {
+                       if (LDB_FLAG_MOD_TYPE(msg->elements[i].flags) == LDB_FLAG_MOD_DELETE) {
+                               *old_val = &msg->elements[i].values[0];
+                       } else {
+                               *new_val = &msg->elements[i].values[0];
+                       }
+               }
+       }
+
+       return LDB_SUCCESS;
+}
+
 int samdb_find_or_add_value(struct ldb_context *ldb, struct ldb_message *msg, const char *name, const char *set_value)
 {
        if (samdb_find_attribute(ldb, msg, name, set_value) == NULL) {
@@ -751,7 +809,7 @@ int samdb_msg_add_string(struct ldb_context *sam_ldb, TALLOC_CTX *mem_ctx, struc
        char *s = talloc_strdup(mem_ctx, str);
        char *a = talloc_strdup(mem_ctx, attr_name);
        if (s == NULL || a == NULL) {
-               return LDB_ERR_OPERATIONS_ERROR;
+               return ldb_oom(sam_ldb);
        }
        return ldb_msg_add_string(msg, a, s);
 }
@@ -766,11 +824,10 @@ int samdb_msg_add_dom_sid(struct ldb_context *sam_ldb, TALLOC_CTX *mem_ctx, stru
        enum ndr_err_code ndr_err;
 
        ndr_err = ndr_push_struct_blob(&v, mem_ctx, 
-                                      lp_iconv_convenience(ldb_get_opaque(sam_ldb, "loadparm")),
                                       sid,
                                       (ndr_push_flags_fn_t)ndr_push_dom_sid);
        if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
-               return LDB_ERR_OPERATIONS_ERROR;
+               return ldb_operr(sam_ldb);
        }
        return ldb_msg_add_value(msg, attr_name, &v, NULL);
 }
@@ -788,52 +845,114 @@ int samdb_msg_add_delete(struct ldb_context *sam_ldb, TALLOC_CTX *mem_ctx, struc
 }
 
 /*
-  add a add attribute value to a message
+  add an add attribute value to a message or enhance an existing attribute
+  which has the same name and the add flag set.
 */
-int samdb_msg_add_addval(struct ldb_context *sam_ldb, TALLOC_CTX *mem_ctx, struct ldb_message *msg,
-                        const char *attr_name, const char *value)
+int samdb_msg_add_addval(struct ldb_context *sam_ldb, TALLOC_CTX *mem_ctx,
+                        struct ldb_message *msg, const char *attr_name,
+                        const char *value)
 {
        struct ldb_message_element *el;
-       char *a, *v;
+       struct ldb_val val, *vals;
+       char *v;
+       unsigned int i;
+       bool found = false;
        int ret;
-       a = talloc_strdup(mem_ctx, attr_name);
-       if (a == NULL)
-               return LDB_ERR_OPERATIONS_ERROR;
+
        v = talloc_strdup(mem_ctx, value);
-       if (v == NULL)
-               return LDB_ERR_OPERATIONS_ERROR;
-       ret = ldb_msg_add_string(msg, a, v);
-       if (ret != 0)
-               return ret;
-       el = ldb_msg_find_element(msg, a);
-       if (el == NULL)
-               return LDB_ERR_OPERATIONS_ERROR;
-       el->flags = LDB_FLAG_MOD_ADD;
+       if (v == NULL) {
+               return ldb_oom(sam_ldb);
+       }
+
+       val.data = (uint8_t *) v;
+       val.length = strlen(v);
+
+       if (val.length == 0) {
+               /* allow empty strings as non-existent attributes */
+               return LDB_SUCCESS;
+       }
+
+       for (i = 0; i < msg->num_elements; i++) {
+               el = &msg->elements[i];
+               if ((ldb_attr_cmp(el->name, attr_name) == 0) &&
+                   (LDB_FLAG_MOD_TYPE(el->flags) == LDB_FLAG_MOD_ADD)) {
+                       found = true;
+                       break;
+               }
+       }
+       if (!found) {
+               ret = ldb_msg_add_empty(msg, attr_name, LDB_FLAG_MOD_ADD,
+                                       &el);
+               if (ret != LDB_SUCCESS) {
+                       return ret;
+               }
+       }
+
+       vals = talloc_realloc(msg, el->values, struct ldb_val,
+                             el->num_values + 1);
+       if (vals == NULL) {
+               return ldb_oom(sam_ldb);
+       }
+       el->values = vals;
+       el->values[el->num_values] = val;
+       ++(el->num_values);
+
        return LDB_SUCCESS;
 }
 
 /*
-  add a delete attribute value to a message
+  add a delete attribute value to a message or enhance an existing attribute
+  which has the same name and the delete flag set.
 */
-int samdb_msg_add_delval(struct ldb_context *sam_ldb, TALLOC_CTX *mem_ctx, struct ldb_message *msg,
-                        const char *attr_name, const char *value)
+int samdb_msg_add_delval(struct ldb_context *sam_ldb, TALLOC_CTX *mem_ctx,
+                        struct ldb_message *msg, const char *attr_name,
+                        const char *value)
 {
        struct ldb_message_element *el;
-       char *a, *v;
+       struct ldb_val val, *vals;
+       char *v;
+       unsigned int i;
+       bool found = false;
        int ret;
-       a = talloc_strdup(mem_ctx, attr_name);
-       if (a == NULL)
-               return LDB_ERR_OPERATIONS_ERROR;
+
        v = talloc_strdup(mem_ctx, value);
-       if (v == NULL)
-               return LDB_ERR_OPERATIONS_ERROR;
-       ret = ldb_msg_add_string(msg, a, v);
-       if (ret != 0)
-               return ret;
-       el = ldb_msg_find_element(msg, a);
-       if (el == NULL)
-               return LDB_ERR_OPERATIONS_ERROR;
-       el->flags = LDB_FLAG_MOD_DELETE;
+       if (v == NULL) {
+               return ldb_oom(sam_ldb);
+       }
+
+       val.data = (uint8_t *) v;
+       val.length = strlen(v);
+
+       if (val.length == 0) {
+               /* allow empty strings as non-existent attributes */
+               return LDB_SUCCESS;
+       }
+
+       for (i = 0; i < msg->num_elements; i++) {
+               el = &msg->elements[i];
+               if ((ldb_attr_cmp(el->name, attr_name) == 0) &&
+                   (LDB_FLAG_MOD_TYPE(el->flags) == LDB_FLAG_MOD_DELETE)) {
+                       found = true;
+                       break;
+               }
+       }
+       if (!found) {
+               ret = ldb_msg_add_empty(msg, attr_name, LDB_FLAG_MOD_DELETE,
+                                       &el);
+               if (ret != LDB_SUCCESS) {
+                       return ret;
+               }
+       }
+
+       vals = talloc_realloc(msg, el->values, struct ldb_val,
+                             el->num_values + 1);
+       if (vals == NULL) {
+               return ldb_oom(sam_ldb);
+       }
+       el->values = vals;
+       el->values[el->num_values] = val;
+       ++(el->num_values);
+
        return LDB_SUCCESS;
 }
 
@@ -879,12 +998,12 @@ int samdb_msg_add_uint64(struct ldb_context *sam_ldb, TALLOC_CTX *mem_ctx, struc
   add a samr_Password element to a message
 */
 int samdb_msg_add_hash(struct ldb_context *sam_ldb, TALLOC_CTX *mem_ctx, struct ldb_message *msg,
-                      const char *attr_name, struct samr_Password *hash)
+                      const char *attr_name, const struct samr_Password *hash)
 {
        struct ldb_val val;
        val.data = talloc_memdup(mem_ctx, hash->hash, 16);
        if (!val.data) {
-               return LDB_ERR_OPERATIONS_ERROR;
+               return ldb_oom(sam_ldb);
        }
        val.length = 16;
        return ldb_msg_add_value(msg, attr_name, &val, NULL);
@@ -893,15 +1012,17 @@ int samdb_msg_add_hash(struct ldb_context *sam_ldb, TALLOC_CTX *mem_ctx, struct
 /*
   add a samr_Password array to a message
 */
-int samdb_msg_add_hashes(TALLOC_CTX *mem_ctx, struct ldb_message *msg,
-                        const char *attr_name, struct samr_Password *hashes, unsigned int count)
+int samdb_msg_add_hashes(struct ldb_context *ldb,
+                        TALLOC_CTX *mem_ctx, struct ldb_message *msg,
+                        const char *attr_name, struct samr_Password *hashes,
+                        unsigned int count)
 {
        struct ldb_val val;
-       int i;
+       unsigned int i;
        val.data = talloc_array_size(mem_ctx, 16, count);
        val.length = count*16;
        if (!val.data) {
-               return LDB_ERR_OPERATIONS_ERROR;
+               return ldb_oom(ldb);
        }
        for (i=0;i<count;i++) {
                memcpy(i*16 + (char *)val.data, hashes[i].hash, 16);
@@ -1018,21 +1139,6 @@ struct security_descriptor *samdb_default_security_descriptor(TALLOC_CTX *mem_ct
        return sd;
 }
 
-struct ldb_dn *samdb_base_dn(struct ldb_context *sam_ctx) 
-{
-       return ldb_get_default_basedn(sam_ctx);
-}
-
-struct ldb_dn *samdb_config_dn(struct ldb_context *sam_ctx) 
-{
-       return ldb_get_config_basedn(sam_ctx);
-}
-
-struct ldb_dn *samdb_schema_dn(struct ldb_context *sam_ctx) 
-{
-       return ldb_get_schema_basedn(sam_ctx);
-}
-
 struct ldb_dn *samdb_aggregate_schema_dn(struct ldb_context *sam_ctx, TALLOC_CTX *mem_ctx) 
 {
        struct ldb_dn *schema_dn = ldb_get_schema_basedn(sam_ctx);
@@ -1051,16 +1157,11 @@ struct ldb_dn *samdb_aggregate_schema_dn(struct ldb_context *sam_ctx, TALLOC_CTX
        return aggregate_dn;
 }
 
-struct ldb_dn *samdb_root_dn(struct ldb_context *sam_ctx) 
-{
-       return ldb_get_root_basedn(sam_ctx);
-}
-
 struct ldb_dn *samdb_partitions_dn(struct ldb_context *sam_ctx, TALLOC_CTX *mem_ctx)
 {
        struct ldb_dn *new_dn;
 
-       new_dn = ldb_dn_copy(mem_ctx, samdb_config_dn(sam_ctx));
+       new_dn = ldb_dn_copy(mem_ctx, ldb_get_config_basedn(sam_ctx));
        if ( ! ldb_dn_add_child_fmt(new_dn, "CN=Partitions")) {
                talloc_free(new_dn);
                return NULL;
@@ -1068,11 +1169,23 @@ struct ldb_dn *samdb_partitions_dn(struct ldb_context *sam_ctx, TALLOC_CTX *mem_
        return new_dn;
 }
 
+struct ldb_dn *samdb_infrastructure_dn(struct ldb_context *sam_ctx, TALLOC_CTX *mem_ctx)
+{
+       struct ldb_dn *new_dn;
+
+       new_dn = ldb_dn_copy(mem_ctx, ldb_get_default_basedn(sam_ctx));
+       if ( ! ldb_dn_add_child_fmt(new_dn, "CN=Infrastructure")) {
+               talloc_free(new_dn);
+               return NULL;
+       }
+       return new_dn;
+}
+
 struct ldb_dn *samdb_sites_dn(struct ldb_context *sam_ctx, TALLOC_CTX *mem_ctx)
 {
        struct ldb_dn *new_dn;
 
-       new_dn = ldb_dn_copy(mem_ctx, samdb_config_dn(sam_ctx));
+       new_dn = ldb_dn_copy(mem_ctx, ldb_get_config_basedn(sam_ctx));
        if ( ! ldb_dn_add_child_fmt(new_dn, "CN=Sites")) {
                talloc_free(new_dn);
                return NULL;
@@ -1180,6 +1293,43 @@ failed:
        return false;
 }
 
+bool samdb_set_ntds_settings_dn(struct ldb_context *ldb, struct ldb_dn *ntds_settings_dn_in)
+{
+       TALLOC_CTX *tmp_ctx;
+       struct ldb_dn *ntds_settings_dn_new;
+       struct ldb_dn *ntds_settings_dn_old;
+
+       /* see if we have a cached copy */
+       ntds_settings_dn_old = talloc_get_type(ldb_get_opaque(ldb, 
+                                                             "cache.ntds_settings_dn"), struct ldb_dn);
+
+       tmp_ctx = talloc_new(ldb);
+       if (tmp_ctx == NULL) {
+               goto failed;
+       }
+
+       ntds_settings_dn_new = ldb_dn_copy(tmp_ctx, ntds_settings_dn_in);
+       if (!ntds_settings_dn_new) {
+               goto failed;
+       }
+
+       /* cache the domain_sid in the ldb */
+       if (ldb_set_opaque(ldb, "cache.ntds_settings_dn", ntds_settings_dn_new) != LDB_SUCCESS) {
+               goto failed;
+       }
+
+       talloc_steal(ldb, ntds_settings_dn_new);
+       talloc_free(tmp_ctx);
+       talloc_free(ntds_settings_dn_old);
+
+       return true;
+
+failed:
+       DEBUG(1,("Failed to set our NTDS Settings DN in the ldb!\n"));
+       talloc_free(tmp_ctx);
+       return false;
+}
+
 /* Obtain the short name of the flexible single master operator
  * (FSMO), such as the PDC Emulator */
 const char *samdb_result_fsmo_name(struct ldb_context *ldb, TALLOC_CTX *mem_ctx, const struct ldb_message *msg, 
@@ -1214,7 +1364,7 @@ struct ldb_dn *samdb_ntds_settings_dn(struct ldb_context *ldb)
        struct ldb_dn *settings_dn;
 
        /* see if we have a cached copy */
-       settings_dn = (struct ldb_dn *)ldb_get_opaque(ldb, "cache.settings_dn");
+       settings_dn = (struct ldb_dn *)ldb_get_opaque(ldb, "cache.ntds_settings_dn");
        if (settings_dn) {
                return settings_dn;
        }
@@ -1456,19 +1606,76 @@ struct ldb_dn *samdb_server_site_dn(struct ldb_context *ldb, TALLOC_CTX *mem_ctx
        struct ldb_dn *server_site_dn;
 
        /* TODO: there must be a saner way to do this!! */
-
        server_dn = samdb_server_dn(ldb, mem_ctx);
        if (!server_dn) return NULL;
 
        servers_dn = ldb_dn_get_parent(mem_ctx, server_dn);
+       talloc_free(server_dn);
        if (!servers_dn) return NULL;
 
        server_site_dn = ldb_dn_get_parent(mem_ctx, servers_dn);
+       talloc_free(servers_dn);
 
-       talloc_free(server_dn);
        return server_site_dn;
 }
 
+/*
+  find the site name from a computers DN record
+ */
+int samdb_find_site_for_computer(struct ldb_context *ldb,
+                                TALLOC_CTX *mem_ctx, struct ldb_dn *computer_dn,
+                                const char **site_name)
+{
+       int ret;
+       struct ldb_dn *dn;
+       const struct ldb_val *rdn_val;
+
+       *site_name = NULL;
+
+       ret = samdb_reference_dn(ldb, mem_ctx, computer_dn, "serverReferenceBL", &dn);
+       if (ret != LDB_SUCCESS) {
+               return ret;
+       }
+
+       if (!ldb_dn_remove_child_components(dn, 2)) {
+               talloc_free(dn);
+               return LDB_ERR_INVALID_DN_SYNTAX;
+       }
+       rdn_val = ldb_dn_get_rdn_val(dn);
+       (*site_name) = talloc_strndup(mem_ctx, (const char *)rdn_val->data, rdn_val->length);
+       talloc_free(dn);
+       if (!*site_name) {
+               return LDB_ERR_OPERATIONS_ERROR;
+       }
+       return LDB_SUCCESS;
+}
+
+/*
+  find the NTDS GUID from a computers DN record
+ */
+int samdb_find_ntdsguid_for_computer(struct ldb_context *ldb, struct ldb_dn *computer_dn,
+                                    struct GUID *ntds_guid)
+{
+       int ret;
+       struct ldb_dn *dn;
+
+       *ntds_guid = GUID_zero();
+
+       ret = samdb_reference_dn(ldb, ldb, computer_dn, "serverReferenceBL", &dn);
+       if (ret != LDB_SUCCESS) {
+               return ret;
+       }
+
+       if (!ldb_dn_add_child_fmt(dn, "CN=NTDS Settings")) {
+               talloc_free(dn);
+               return LDB_ERR_OPERATIONS_ERROR;
+       }
+
+       ret = dsdb_find_guid_by_dn(ldb, dn, ntds_guid);
+       talloc_free(dn);
+       return ret;
+}
+
 /*
   find a 'reference' DN that points at another object
   (eg. serverReference, rIDManagerReference etc)
@@ -1483,17 +1690,20 @@ int samdb_reference_dn(struct ldb_context *ldb, TALLOC_CTX *mem_ctx, struct ldb_
        attrs[0] = attribute;
        attrs[1] = NULL;
 
-       ret = ldb_search(ldb, mem_ctx, &res, base, LDB_SCOPE_BASE, attrs, NULL);
+       ret = dsdb_search(ldb, mem_ctx, &res, base, LDB_SCOPE_BASE, attrs, DSDB_SEARCH_ONE_ONLY, NULL);
        if (ret != LDB_SUCCESS) {
                return ret;
        }
-       if (res->count != 1) {
-               talloc_free(res);
-               return LDB_ERR_NO_SUCH_OBJECT;
-       }
 
        *dn = ldb_msg_find_attr_as_dn(ldb, mem_ctx, res->msgs[0], attribute);
        if (!*dn) {
+               if (!ldb_msg_find_element(res->msgs[0], attribute)) {
+                       ldb_asprintf_errstring(ldb, "Cannot find attribute %s of %s to calculate reference dn", attribute,
+                                              ldb_dn_get_linearized(base));
+               } else {
+                       ldb_asprintf_errstring(ldb, "Cannot interpret attribute %s of %s as a dn", attribute,
+                                              ldb_dn_get_linearized(base));
+               }
                talloc_free(res);
                return LDB_ERR_NO_SUCH_ATTRIBUTE;
        }
@@ -1528,7 +1738,8 @@ int samdb_server_reference_dn(struct ldb_context *ldb, TALLOC_CTX *mem_ctx, stru
  */
 int samdb_rid_manager_dn(struct ldb_context *ldb, TALLOC_CTX *mem_ctx, struct ldb_dn **dn)
 {
-       return samdb_reference_dn(ldb, mem_ctx, samdb_base_dn(ldb), "rIDManagerReference", dn);
+       return samdb_reference_dn(ldb, mem_ctx, ldb_get_default_basedn(ldb),
+                                 "rIDManagerReference", dn);
 }
 
 /*
@@ -1551,12 +1762,115 @@ int samdb_rid_set_dn(struct ldb_context *ldb, TALLOC_CTX *mem_ctx, struct ldb_dn
 
 const char *samdb_server_site_name(struct ldb_context *ldb, TALLOC_CTX *mem_ctx)
 {
-       const struct ldb_val *val = ldb_dn_get_rdn_val(samdb_server_site_dn(ldb, mem_ctx));
+       const struct ldb_val *val = ldb_dn_get_rdn_val(samdb_server_site_dn(ldb,
+                                                                           mem_ctx));
+
+       if (val == NULL) {
+               return NULL;
+       }
+
+       return (const char *) val->data;
+}
+
+/*
+ * Finds the client site by using the client's IP address.
+ * The "subnet_name" returns the name of the subnet if parameter != NULL
+ */
+const char *samdb_client_site_name(struct ldb_context *ldb, TALLOC_CTX *mem_ctx,
+                                  const char *ip_address, char **subnet_name)
+{
+       const char *attrs[] = { "cn", "siteObject", NULL };
+       struct ldb_dn *sites_container_dn, *subnets_dn, *sites_dn;
+       struct ldb_result *res;
+       const struct ldb_val *val;
+       const char *site_name = NULL, *l_subnet_name = NULL;
+       const char *allow_list[2] = { NULL, NULL };
+       unsigned int i, count;
+       int cnt, ret;
+
+       /*
+        * if we don't have a client ip e.g. ncalrpc
+        * the server site is the client site
+        */
+       if (ip_address == NULL) {
+               return samdb_server_site_name(ldb, mem_ctx);
+       }
+
+       sites_container_dn = samdb_sites_dn(ldb, mem_ctx);
+       if (sites_container_dn == NULL) {
+               return NULL;
+       }
+
+       subnets_dn = ldb_dn_copy(mem_ctx, sites_container_dn);
+       if ( ! ldb_dn_add_child_fmt(subnets_dn, "CN=Subnets")) {
+               talloc_free(sites_container_dn);
+               talloc_free(subnets_dn);
+               return NULL;
+       }
 
-       if (val != NULL)
-               return (const char *) val->data;
-       else
+       ret = ldb_search(ldb, mem_ctx, &res, subnets_dn, LDB_SCOPE_ONELEVEL,
+                        attrs, NULL);
+       if (ret == LDB_ERR_NO_SUCH_OBJECT) {
+               count = 0;
+       } else if (ret != LDB_SUCCESS) {
+               talloc_free(sites_container_dn);
+               talloc_free(subnets_dn);
                return NULL;
+       } else {
+               count = res->count;
+       }
+
+       for (i = 0; i < count; i++) {
+               l_subnet_name = ldb_msg_find_attr_as_string(res->msgs[i], "cn",
+                                                           NULL);
+
+               allow_list[0] = l_subnet_name;
+
+               if (allow_access(mem_ctx, NULL, allow_list, "", ip_address)) {
+                       sites_dn = ldb_msg_find_attr_as_dn(ldb, mem_ctx,
+                                                          res->msgs[i],
+                                                          "siteObject");
+                       if (sites_dn == NULL) {
+                               /* No reference, maybe another subnet matches */
+                               continue;
+                       }
+
+                       /* "val" cannot be NULL here since "sites_dn" != NULL */
+                       val = ldb_dn_get_rdn_val(sites_dn);
+                       site_name = talloc_strdup(mem_ctx,
+                                                 (const char *) val->data);
+
+                       talloc_free(sites_dn);
+
+                       break;
+               }
+       }
+
+       if (site_name == NULL) {
+               /* This is the Windows Server fallback rule: when no subnet
+                * exists and we have only one site available then use it (it
+                * is for sure the same as our server site). If more sites do
+                * exist then we don't know which one to use and set the site
+                * name to "". */
+               cnt = samdb_search_count(ldb, sites_container_dn,
+                                        "(objectClass=site)");
+               if (cnt == 1) {
+                       site_name = samdb_server_site_name(ldb, mem_ctx);
+               } else {
+                       site_name = talloc_strdup(mem_ctx, "");
+               }
+               l_subnet_name = NULL;
+       }
+
+       if (subnet_name != NULL) {
+               *subnet_name = talloc_strdup(mem_ctx, l_subnet_name);
+       }
+
+       talloc_free(sites_container_dn);
+       talloc_free(subnets_dn);
+       talloc_free(res);
+
+       return site_name;
 }
 
 /*
@@ -1578,7 +1892,7 @@ bool samdb_is_pdc(struct ldb_context *ldb)
        }
 
        ret = ldb_search(ldb, tmp_ctx, &dom_res, ldb_get_default_basedn(ldb), LDB_SCOPE_BASE, dom_attrs, NULL);
-       if (ret) {
+       if (ret != LDB_SUCCESS) {
                DEBUG(1,("Searching for fSMORoleOwner in %s failed: %s\n", 
                         ldb_dn_get_linearized(ldb_get_default_basedn(ldb)), 
                         ldb_errstring(ldb)));
@@ -1624,7 +1938,7 @@ bool samdb_is_gc(struct ldb_context *ldb)
 
        /* Query cn=ntds settings,.... */
        ret = ldb_search(ldb, tmp_ctx, &res, samdb_ntds_settings_dn(ldb), LDB_SCOPE_BASE, attrs, NULL);
-       if (ret) {
+       if (ret != LDB_SUCCESS) {
                talloc_free(tmp_ctx);
                return false;
        }
@@ -1650,11 +1964,11 @@ int samdb_search_for_parent_domain(struct ldb_context *ldb, TALLOC_CTX *mem_ctx,
        TALLOC_CTX *local_ctx;
        struct ldb_dn *sdn = dn;
        struct ldb_result *res = NULL;
-       int ret = 0;
+       int ret = LDB_SUCCESS;
        const char *attrs[] = { NULL };
 
        local_ctx = talloc_new(mem_ctx);
-       if (local_ctx == NULL) return LDB_ERR_OPERATIONS_ERROR;
+       if (local_ctx == NULL) return ldb_oom(ldb);
 
        while ((sdn = ldb_dn_get_parent(local_ctx, sdn))) {
                ret = ldb_search(ldb, local_ctx, &res, sdn, LDB_SCOPE_BASE, attrs,
@@ -1714,282 +2028,224 @@ enum samr_ValidationStatus samdb_check_password(const DATA_BLOB *password,
        return SAMR_VALIDATION_STATUS_SUCCESS;
 }
 
+/*
+ * Callback for "samdb_set_password" password change
+ */
+int samdb_set_password_callback(struct ldb_request *req, struct ldb_reply *ares)
+{
+       int ret;
+
+       if (!ares) {
+               return ldb_request_done(req, LDB_ERR_OPERATIONS_ERROR);
+       }
+
+       if (ares->error != LDB_SUCCESS) {
+               ret = ares->error;
+               req->context = talloc_steal(req,
+                                           ldb_reply_get_control(ares, DSDB_CONTROL_PASSWORD_CHANGE_STATUS_OID));
+               talloc_free(ares);
+               return ldb_request_done(req, ret);
+       }
+
+       if (ares->type != LDB_REPLY_DONE) {
+               talloc_free(ares);
+               return ldb_request_done(req, LDB_ERR_OPERATIONS_ERROR);
+       }
+
+       req->context = talloc_steal(req,
+                                   ldb_reply_get_control(ares, DSDB_CONTROL_PASSWORD_CHANGE_STATUS_OID));
+       talloc_free(ares);
+       return ldb_request_done(req, LDB_SUCCESS);
+}
+
 /*
  * Sets the user password using plaintext UTF16 (attribute "new_password") or
  * LM (attribute "lmNewHash") or NT (attribute "ntNewHash") hash. Also pass
- * as parameter if it's a user change or not ("userChange"). The "rejectReason"
- * gives some more informations if the changed failed.
- *
- * The caller should have a LDB transaction wrapping this.
+ * the old LM and/or NT hash (attributes "lmOldHash"/"ntOldHash") if it is a
+ * user change or not. The "rejectReason" gives some more informations if the
+ * change failed.
  *
- * Results: NT_STATUS_OK, NT_STATUS_INTERNAL_DB_CORRUPTION,
- *   NT_STATUS_INVALID_PARAMETER, NT_STATUS_UNSUCCESSFUL,
- *   NT_STATUS_PASSWORD_RESTRICTION
+ * Results: NT_STATUS_OK, NT_STATUS_INVALID_PARAMETER, NT_STATUS_UNSUCCESSFUL,
+ *   NT_STATUS_WRONG_PASSWORD, NT_STATUS_PASSWORD_RESTRICTION
  */
-NTSTATUS samdb_set_password(struct ldb_context *ctx, TALLOC_CTX *mem_ctx,
+NTSTATUS samdb_set_password(struct ldb_context *ldb, TALLOC_CTX *mem_ctx,
                            struct ldb_dn *user_dn, struct ldb_dn *domain_dn,
-                           struct ldb_message *mod,
                            const DATA_BLOB *new_password,
-                           struct samr_Password *param_lmNewHash,
-                           struct samr_Password *param_ntNewHash,
-                           bool user_change,
+                           const struct samr_Password *lmNewHash,
+                           const struct samr_Password *ntNewHash,
+                           const struct samr_Password *lmOldHash,
+                           const struct samr_Password *ntOldHash,
                            enum samPwdChangeReason *reject_reason,
                            struct samr_DomInfo1 **_dominfo)
 {
-       const char * const user_attrs[] = { "userAccountControl",
-                                           "lmPwdHistory",
-                                           "ntPwdHistory", 
-                                           "dBCSPwd", "unicodePwd", 
-                                           "objectSid", 
-                                           "pwdLastSet", NULL };
-       const char * const domain_attrs[] = { "minPwdLength", "pwdProperties",
-                                             "pwdHistoryLength",
-                                             "maxPwdAge", "minPwdAge", NULL };
-       NTTIME pwdLastSet;
-       uint32_t minPwdLength, pwdProperties, pwdHistoryLength;
-       int64_t maxPwdAge, minPwdAge;
-       uint32_t userAccountControl;
-       struct samr_Password *sambaLMPwdHistory, *sambaNTPwdHistory,
-               *lmPwdHash, *ntPwdHash, *lmNewHash, *ntNewHash;
-       struct samr_Password local_lmNewHash, local_ntNewHash;
-       int sambaLMPwdHistory_len, sambaNTPwdHistory_len;
-       struct dom_sid *domain_sid;
-       struct ldb_message **res;
-       bool restrictions;
-       int count;
-       time_t now = time(NULL);
-       NTTIME now_nt;
-       int i;
+       struct ldb_message *msg;
+       struct ldb_message_element *el;
+       struct ldb_request *req;
+       struct dsdb_control_password_change_status *pwd_stat = NULL;
+       int ret;
+       NTSTATUS status = NT_STATUS_OK;
 
-       /* we need to know the time to compute password age */
-       unix_to_nt_time(&now_nt, now);
+#define CHECK_RET(x) \
+       if (x != LDB_SUCCESS) { \
+               talloc_free(msg); \
+               return NT_STATUS_NO_MEMORY; \
+       }
 
-       /* pull all the user parameters */
-       count = gendb_search_dn(ctx, mem_ctx, user_dn, &res, user_attrs);
-       if (count != 1) {
-               return NT_STATUS_INTERNAL_DB_CORRUPTION;
+       msg = ldb_msg_new(mem_ctx);
+       if (msg == NULL) {
+               return NT_STATUS_NO_MEMORY;
        }
-       userAccountControl = samdb_result_uint(res[0], "userAccountControl", 0);
-       sambaLMPwdHistory_len = samdb_result_hashes(mem_ctx, res[0],
-                                        "lmPwdHistory", &sambaLMPwdHistory);
-       sambaNTPwdHistory_len = samdb_result_hashes(mem_ctx, res[0],
-                                        "ntPwdHistory", &sambaNTPwdHistory);
-       lmPwdHash = samdb_result_hash(mem_ctx, res[0], "dBCSPwd");
-       ntPwdHash = samdb_result_hash(mem_ctx, res[0], "unicodePwd");
-       pwdLastSet = samdb_result_uint64(res[0], "pwdLastSet", 0);
-
-       /* Copy parameters */
-       lmNewHash = param_lmNewHash;
-       ntNewHash = param_ntNewHash;
-
-       /* Only non-trust accounts have restrictions (possibly this
-        * test is the wrong way around, but I like to be restrictive
-        * if possible */
-       restrictions = !(userAccountControl & (UF_INTERDOMAIN_TRUST_ACCOUNT
-                                              |UF_WORKSTATION_TRUST_ACCOUNT
-                                              |UF_SERVER_TRUST_ACCOUNT)); 
-
-       if (domain_dn != NULL) {
-               /* pull the domain parameters */
-               count = gendb_search_dn(ctx, mem_ctx, domain_dn, &res,
-                                                               domain_attrs);
-               if (count != 1) {
-                       DEBUG(2, ("samdb_set_password: Domain DN %s is invalid, for user %s\n", 
-                                 ldb_dn_get_linearized(domain_dn),
-                                 ldb_dn_get_linearized(user_dn)));
-                       return NT_STATUS_NO_SUCH_DOMAIN;
-               }
-       } else {
-               /* work out the domain sid, and pull the domain from there */
-               domain_sid = samdb_result_sid_prefix(mem_ctx, res[0],
-                                                               "objectSid");
-               if (domain_sid == NULL) {
-                       return NT_STATUS_INTERNAL_DB_CORRUPTION;
+       msg->dn = user_dn;
+       if ((new_password != NULL)
+                       && ((lmNewHash == NULL) && (ntNewHash == NULL))) {
+               /* we have the password as plaintext UTF16 */
+               CHECK_RET(samdb_msg_add_value(ldb, mem_ctx, msg,
+                       "clearTextPassword", new_password));
+               el = ldb_msg_find_element(msg, "clearTextPassword");
+               el->flags = LDB_FLAG_MOD_REPLACE;
+       } else if ((new_password == NULL)
+                       && ((lmNewHash != NULL) || (ntNewHash != NULL))) {
+               /* we have a password as LM and/or NT hash */
+               if (lmNewHash != NULL) {
+                       CHECK_RET(samdb_msg_add_hash(ldb, mem_ctx, msg,
+                               "dBCSPwd", lmNewHash));
+                       el = ldb_msg_find_element(msg, "dBCSPwd");
+                       el->flags = LDB_FLAG_MOD_REPLACE;
                }
-
-               count = gendb_search(ctx, mem_ctx, NULL, &res, domain_attrs, 
-                               "(objectSid=%s)",
-                               ldap_encode_ndr_dom_sid(mem_ctx, domain_sid));
-               if (count != 1) {
-                       DEBUG(2, ("samdb_set_password: Could not find domain to match SID: %s, for user %s\n", 
-                                 dom_sid_string(mem_ctx, domain_sid),
-                                 ldb_dn_get_linearized(user_dn)));
-                       return NT_STATUS_NO_SUCH_DOMAIN;
+               if (ntNewHash != NULL) {
+                       CHECK_RET(samdb_msg_add_hash(ldb, mem_ctx, msg,
+                               "unicodePwd", ntNewHash));
+                       el = ldb_msg_find_element(msg, "unicodePwd");
+                       el->flags = LDB_FLAG_MOD_REPLACE;
                }
+       } else {
+               /* the password wasn't specified correctly */
+               talloc_free(msg);
+               return NT_STATUS_INVALID_PARAMETER;
        }
 
-       minPwdLength = samdb_result_uint(res[0], "minPwdLength", 0);
-       pwdProperties = samdb_result_uint(res[0], "pwdProperties", 0);
-       pwdHistoryLength = samdb_result_uint(res[0], "pwdHistoryLength", 0);
-       maxPwdAge = samdb_result_int64(res[0], "maxPwdAge", 0);
-       minPwdAge = samdb_result_int64(res[0], "minPwdAge", 0);
+       /* build modify request */
+       ret = ldb_build_mod_req(&req, ldb, mem_ctx, msg, NULL, NULL,
+                               samdb_set_password_callback, NULL);
+        if (ret != LDB_SUCCESS) {
+               talloc_free(msg);
+               return NT_STATUS_NO_MEMORY;
+        }
 
-       if ((userAccountControl & UF_PASSWD_NOTREQD) != 0) {
-               /* see [MS-ADTS] 2.2.15 */
-               minPwdLength = 0;
-       }
+       /* A password change operation */
+       if ((ntOldHash != NULL) || (lmOldHash != NULL)) {
+               struct dsdb_control_password_change *change;
 
-       if (_dominfo != NULL) {
-               struct samr_DomInfo1 *dominfo;
-               /* on failure we need to fill in the reject reasons */
-               dominfo = talloc(mem_ctx, struct samr_DomInfo1);
-               if (dominfo == NULL) {
+               change = talloc(req, struct dsdb_control_password_change);
+               if (change == NULL) {
+                       talloc_free(req);
+                       talloc_free(msg);
                        return NT_STATUS_NO_MEMORY;
                }
-               dominfo->min_password_length     = minPwdLength;
-               dominfo->password_properties     = pwdProperties;
-               dominfo->password_history_length = pwdHistoryLength;
-               dominfo->max_password_age        = maxPwdAge;
-               dominfo->min_password_age        = minPwdAge;
-               *_dominfo = dominfo;
-       }
 
-       if ((restrictions != 0) && (new_password != 0)) {
-               char *new_pass;
+               change->old_nt_pwd_hash = ntOldHash;
+               change->old_lm_pwd_hash = lmOldHash;
 
-               /* checks if the "minPwdLength" property is satisfied */
-               if ((restrictions != 0)
-                       && (minPwdLength > utf16_len_n(
-                               new_password->data, new_password->length)/2)) {
-                       if (reject_reason) {
-                               *reject_reason = SAM_PWD_CHANGE_PASSWORD_TOO_SHORT;
-                       }
-                       return NT_STATUS_PASSWORD_RESTRICTION;
+               ret = ldb_request_add_control(req,
+                                             DSDB_CONTROL_PASSWORD_CHANGE_OID,
+                                             true, change);
+               if (ret != LDB_SUCCESS) {
+                       talloc_free(req);
+                       talloc_free(msg);
+                       return NT_STATUS_NO_MEMORY;
                }
+       }
+       ret = ldb_request_add_control(req,
+                                     DSDB_CONTROL_PASSWORD_HASH_VALUES_OID,
+                                     true, NULL);
+       if (ret != LDB_SUCCESS) {
+               talloc_free(req);
+               talloc_free(msg);
+               return NT_STATUS_NO_MEMORY;
+       }
+       ret = ldb_request_add_control(req,
+                                     DSDB_CONTROL_PASSWORD_CHANGE_STATUS_OID,
+                                     true, NULL);
+       if (ret != LDB_SUCCESS) {
+               talloc_free(req);
+               talloc_free(msg);
+               return NT_STATUS_NO_MEMORY;
+       }
 
-               /* Create the NT hash */
-               mdfour(local_ntNewHash.hash, new_password->data,
-                                                       new_password->length);
-
-               ntNewHash = &local_ntNewHash;
-
-               /* Only check complexity if we can convert it at all.  Assuming unconvertable passwords are 'strong' */
-               if (convert_string_talloc_convenience(mem_ctx,
-                         lp_iconv_convenience(ldb_get_opaque(ctx, "loadparm")),
-                         CH_UTF16, CH_UNIX,
-                         new_password->data, new_password->length,
-                         (void **)&new_pass, NULL, false)) {
-
-                       /* checks the password complexity */
-                       if ((restrictions != 0)
-                               && ((pwdProperties
-                                       & DOMAIN_PASSWORD_COMPLEX) != 0)
-                               && (!check_password_quality(new_pass))) {
-                               if (reject_reason) {
-                                       *reject_reason = SAM_PWD_CHANGE_NOT_COMPLEX;
-                               }
-                               return NT_STATUS_PASSWORD_RESTRICTION;
-                       }
-
-                       /* compute the new lm hashes (for checking history - case insenitivly!) */
-                       if (E_deshash(new_pass, local_lmNewHash.hash)) {
-                               lmNewHash = &local_lmNewHash;
-                       }
-               }
+       ret = dsdb_autotransaction_request(ldb, req);
+
+       if (req->context != NULL) {
+               pwd_stat = talloc_steal(mem_ctx,
+                                       ((struct ldb_control *)req->context)->data);
        }
 
-       if ((restrictions != 0) && user_change) {
-               /* are all password changes disallowed? */
-               if ((pwdProperties & DOMAIN_REFUSE_PASSWORD_CHANGE) != 0) {
-                       if (reject_reason) {
-                               *reject_reason = SAM_PWD_CHANGE_NO_ERROR;
-                       }
-                       return NT_STATUS_PASSWORD_RESTRICTION;
-               }
+       talloc_free(req);
+       talloc_free(msg);
 
-               /* can this user change the password? */
-               if ((userAccountControl & UF_PASSWD_CANT_CHANGE) != 0) {
-                       if (reject_reason) {
-                               *reject_reason = SAM_PWD_CHANGE_NO_ERROR;
-                       }
-                       return NT_STATUS_PASSWORD_RESTRICTION;
-               }
+       /* Sets the domain info (if requested) */
+       if (_dominfo != NULL) {
+               struct samr_DomInfo1 *dominfo;
 
-               /* Password minimum age: yes, this is a minus. The ages are in negative 100nsec units! */
-               if (pwdLastSet - minPwdAge > now_nt) {
-                       if (reject_reason) {
-                               *reject_reason = SAM_PWD_CHANGE_NO_ERROR;
-                       }
-                       return NT_STATUS_PASSWORD_RESTRICTION;
+               dominfo = talloc_zero(mem_ctx, struct samr_DomInfo1);
+               if (dominfo == NULL) {
+                       return NT_STATUS_NO_MEMORY;
                }
 
-               /* check the immediately past password */
-               if (pwdHistoryLength > 0) {
-                       if (lmNewHash && lmPwdHash && memcmp(lmNewHash->hash,
-                                       lmPwdHash->hash, 16) == 0) {
-                               if (reject_reason) {
-                                       *reject_reason = SAM_PWD_CHANGE_PWD_IN_HISTORY;
-                               }
-                               return NT_STATUS_PASSWORD_RESTRICTION;
-                       }
-                       if (ntNewHash && ntPwdHash && memcmp(ntNewHash->hash,
-                                       ntPwdHash->hash, 16) == 0) {
-                               if (reject_reason) {
-                                       *reject_reason = SAM_PWD_CHANGE_PWD_IN_HISTORY;
-                               }
-                               return NT_STATUS_PASSWORD_RESTRICTION;
-                       }
+               if (pwd_stat != NULL) {
+                       dominfo->min_password_length     = pwd_stat->domain_data.minPwdLength;
+                       dominfo->password_properties     = pwd_stat->domain_data.pwdProperties;
+                       dominfo->password_history_length = pwd_stat->domain_data.pwdHistoryLength;
+                       dominfo->max_password_age        = pwd_stat->domain_data.maxPwdAge;
+                       dominfo->min_password_age        = pwd_stat->domain_data.minPwdAge;
                }
 
-               /* check the password history */
-               sambaLMPwdHistory_len = MIN(sambaLMPwdHistory_len,
-                                                       pwdHistoryLength);
-               sambaNTPwdHistory_len = MIN(sambaNTPwdHistory_len,
-                                                       pwdHistoryLength);
-
-               for (i=0; lmNewHash && i<sambaLMPwdHistory_len;i++) {
-                       if (memcmp(lmNewHash->hash, sambaLMPwdHistory[i].hash,
-                                       16) == 0) {
-                               if (reject_reason) {
-                                       *reject_reason = SAM_PWD_CHANGE_PWD_IN_HISTORY;
-                               }
-                               return NT_STATUS_PASSWORD_RESTRICTION;
-                       }
-               }
-               for (i=0; ntNewHash && i<sambaNTPwdHistory_len;i++) {
-                       if (memcmp(ntNewHash->hash, sambaNTPwdHistory[i].hash,
-                                        16) == 0) {
-                               if (reject_reason) {
-                                       *reject_reason = SAM_PWD_CHANGE_PWD_IN_HISTORY;
-                               }
-                               return NT_STATUS_PASSWORD_RESTRICTION;
-                       }
-               }
+               *_dominfo = dominfo;
        }
 
-#define CHECK_RET(x) do { if (x != 0) return NT_STATUS_NO_MEMORY; } while(0)
+       if (reject_reason != NULL) {
+               if (pwd_stat != NULL) {
+                       *reject_reason = pwd_stat->reject_reason;
+               } else {
+                       *reject_reason = SAM_PWD_CHANGE_NO_ERROR;
+               }
+       }
 
-       /* the password is acceptable. Start forming the new fields */
-       if (new_password != NULL) {
-               /* if we know the cleartext UTF16 password, then set it.
-                * Modules in ldb will set all the appropriate
-                * hashes */
-               CHECK_RET(ldb_msg_add_value(mod, "clearTextPassword", new_password, NULL));
-       } else {
-               /* we don't have the cleartext, so set what we have of the
-                * hashes */
+       if (pwd_stat != NULL) {
+               talloc_free(pwd_stat);
+       }
 
-               if (lmNewHash) {
-                       CHECK_RET(samdb_msg_add_hash(ctx, mem_ctx, mod, "dBCSPwd", lmNewHash));
+       if (ret == LDB_ERR_CONSTRAINT_VIOLATION) {
+               const char *errmsg = ldb_errstring(ldb);
+               char *endptr = NULL;
+               WERROR werr = WERR_GENERAL_FAILURE;
+               status = NT_STATUS_UNSUCCESSFUL;
+               if (errmsg != NULL) {
+                       werr = W_ERROR(strtol(errmsg, &endptr, 16));
                }
-
-               if (ntNewHash) {
-                       CHECK_RET(samdb_msg_add_hash(ctx, mem_ctx, mod, "unicodePwd", ntNewHash));
+               if (endptr != errmsg) {
+                       if (W_ERROR_EQUAL(werr, WERR_INVALID_PASSWORD)) {
+                               status = NT_STATUS_WRONG_PASSWORD;
+                       }
+                       if (W_ERROR_EQUAL(werr, WERR_PASSWORD_RESTRICTION)) {
+                               status = NT_STATUS_PASSWORD_RESTRICTION;
+                       }
                }
+       } else if (ret == LDB_ERR_NO_SUCH_OBJECT) {
+               /* don't let the caller know if an account doesn't exist */
+               status = NT_STATUS_WRONG_PASSWORD;
+       } else if (ret != LDB_SUCCESS) {
+               status = NT_STATUS_UNSUCCESSFUL;
        }
 
-       if (reject_reason) {
-               *reject_reason = SAM_PWD_CHANGE_NO_ERROR;
-       }
-       return NT_STATUS_OK;
+       return status;
 }
 
-
 /*
  * Sets the user password using plaintext UTF16 (attribute "new_password") or
  * LM (attribute "lmNewHash") or NT (attribute "ntNewHash") hash. Also pass
- * as parameter if it's a user change or not ("userChange"). The "rejectReason"
- * gives some more informations if the changed failed.
+ * the old LM and/or NT hash (attributes "lmOldHash"/"ntOldHash") if it is a
+ * user change or not. The "rejectReason" gives some more informations if the
+ * change failed.
  *
  * This wrapper function for "samdb_set_password" takes a SID as input rather
  * than a user DN.
@@ -1999,20 +2255,21 @@ NTSTATUS samdb_set_password(struct ldb_context *ctx, TALLOC_CTX *mem_ctx,
  *
  * Results: NT_STATUS_OK, NT_STATUS_INTERNAL_DB_CORRUPTION,
  *   NT_STATUS_INVALID_PARAMETER, NT_STATUS_UNSUCCESSFUL,
- *   NT_STATUS_PASSWORD_RESTRICTION
+ *   NT_STATUS_WRONG_PASSWORD, NT_STATUS_PASSWORD_RESTRICTION,
+ *   NT_STATUS_TRANSACTION_ABORTED, NT_STATUS_NO_SUCH_USER
  */
 NTSTATUS samdb_set_password_sid(struct ldb_context *ldb, TALLOC_CTX *mem_ctx,
                                const struct dom_sid *user_sid,
                                const DATA_BLOB *new_password,
-                               struct samr_Password *lmNewHash, 
-                               struct samr_Password *ntNewHash,
-                               bool user_change,
+                               const struct samr_Password *lmNewHash,
+                               const struct samr_Password *ntNewHash,
+                               const struct samr_Password *lmOldHash,
+                               const struct samr_Password *ntOldHash,
                                enum samPwdChangeReason *reject_reason,
                                struct samr_DomInfo1 **_dominfo) 
 {
        NTSTATUS nt_status;
        struct ldb_dn *user_dn;
-       struct ldb_message *msg;
        int ret;
 
        ret = ldb_transaction_start(ldb);
@@ -2031,45 +2288,18 @@ NTSTATUS samdb_set_password_sid(struct ldb_context *ldb, TALLOC_CTX *mem_ctx,
                return NT_STATUS_NO_SUCH_USER;
        }
 
-       msg = ldb_msg_new(mem_ctx);
-       if (msg == NULL) {
-               ldb_transaction_cancel(ldb);
-               talloc_free(user_dn);
-               return NT_STATUS_NO_MEMORY;
-       }
-
-       msg->dn = ldb_dn_copy(msg, user_dn);
-       if (!msg->dn) {
-               ldb_transaction_cancel(ldb);
-               talloc_free(user_dn);
-               talloc_free(msg);
-               return NT_STATUS_NO_MEMORY;
-       }
-
        nt_status = samdb_set_password(ldb, mem_ctx,
                                       user_dn, NULL,
-                                      msg, new_password,
+                                      new_password,
                                       lmNewHash, ntNewHash,
-                                      user_change,
+                                      lmOldHash, ntOldHash,
                                       reject_reason, _dominfo);
        if (!NT_STATUS_IS_OK(nt_status)) {
                ldb_transaction_cancel(ldb);
                talloc_free(user_dn);
-               talloc_free(msg);
                return nt_status;
        }
 
-       /* modify the samdb record */
-       ret = dsdb_replace(ldb, msg, 0);
-       if (ret != LDB_SUCCESS) {
-               ldb_transaction_cancel(ldb);
-               talloc_free(user_dn);
-               talloc_free(msg);
-               return NT_STATUS_ACCESS_DENIED;
-       }
-
-       talloc_free(msg);
-
        ret = ldb_transaction_commit(ldb);
        if (ret != LDB_SUCCESS) {
                DEBUG(0,("Failed to commit transaction to change password on %s: %s\n",
@@ -2104,7 +2334,8 @@ NTSTATUS samdb_create_foreign_security_principal(struct ldb_context *sam_ctx, TA
                return NT_STATUS_NO_MEMORY;
        }
 
-       ret = dsdb_wellknown_dn(sam_ctx, sidstr, samdb_base_dn(sam_ctx),
+       ret = dsdb_wellknown_dn(sam_ctx, sidstr,
+                               ldb_get_default_basedn(sam_ctx),
                                DS_GUID_FOREIGNSECURITYPRINCIPALS_CONTAINER,
                                &basedn);
        if (ret != LDB_SUCCESS) {
@@ -2149,7 +2380,7 @@ NTSTATUS samdb_create_foreign_security_principal(struct ldb_context *sam_ctx, TA
 
 struct ldb_dn *samdb_dns_domain_to_dn(struct ldb_context *ldb, TALLOC_CTX *mem_ctx, const char *dns_domain) 
 {
-       int i;
+       unsigned int i;
        TALLOC_CTX *tmp_ctx = talloc_new(mem_ctx);
        const char *binary_encoded;
        const char **split_realm;
@@ -2206,7 +2437,7 @@ struct ldb_dn *samdb_domain_to_dn(struct ldb_context *ldb, TALLOC_CTX *mem_ctx,
                                            domain_ref_attrs,
                                            "(&(nETBIOSName=%s)(objectclass=crossRef))", 
                                            escaped_domain);
-       if (ret_domain != 0) {
+       if (ret_domain != LDB_SUCCESS) {
                return NULL;
        }
 
@@ -2217,7 +2448,7 @@ struct ldb_dn *samdb_domain_to_dn(struct ldb_context *ldb, TALLOC_CTX *mem_ctx,
                                                LDB_SCOPE_BASE,
                                                domain_ref2_attrs,
                                                "(objectclass=domain)");
-               if (ret_domain != 0) {
+               if (ret_domain != LDB_SUCCESS) {
                        return NULL;
                }
 
@@ -2251,7 +2482,7 @@ int dsdb_find_dn_by_guid(struct ldb_context *ldb,
        char *guid_str = GUID_string(mem_ctx, guid);
 
        if (!guid_str) {
-               return LDB_ERR_OPERATIONS_ERROR;
+               return ldb_operr(ldb);
        }
 
        ret = dsdb_search(ldb, mem_ctx, &res, NULL, LDB_SCOPE_SUBTREE, attrs,
@@ -2353,7 +2584,7 @@ int dsdb_find_sid_by_dn(struct ldb_context *ldb,
 {
        int ret;
        struct ldb_result *res;
-       const char *attrs[] = { "objectSID", NULL };
+       const char *attrs[] = { "objectSid", NULL };
        TALLOC_CTX *tmp_ctx = talloc_new(ldb);
        struct dom_sid *s;
 
@@ -2368,7 +2599,7 @@ int dsdb_find_sid_by_dn(struct ldb_context *ldb,
                talloc_free(tmp_ctx);
                return LDB_ERR_NO_SUCH_OBJECT;
        }
-       s = samdb_result_dom_sid(tmp_ctx, res->msgs[0], "objectSID");
+       s = samdb_result_dom_sid(tmp_ctx, res->msgs[0], "objectSid");
        if (s == NULL) {
                talloc_free(tmp_ctx);
                return LDB_ERR_NO_SUCH_OBJECT;
@@ -2378,7 +2609,37 @@ int dsdb_find_sid_by_dn(struct ldb_context *ldb,
        return LDB_SUCCESS;
 }
 
+/*
+  use a SID to find a DN
+ */
+int dsdb_find_dn_by_sid(struct ldb_context *ldb,
+                       TALLOC_CTX *mem_ctx,
+                       struct dom_sid *sid, struct ldb_dn **dn)
+{
+       int ret;
+       struct ldb_result *res;
+       const char *attrs[] = { NULL };
+       char *sid_str = ldap_encode_ndr_dom_sid(mem_ctx, sid);
 
+       if (!sid_str) {
+               return ldb_operr(ldb);
+       }
+
+       ret = dsdb_search(ldb, mem_ctx, &res, NULL, LDB_SCOPE_SUBTREE, attrs,
+                         DSDB_SEARCH_SEARCH_ALL_PARTITIONS |
+                         DSDB_SEARCH_SHOW_EXTENDED_DN |
+                         DSDB_SEARCH_ONE_ONLY,
+                         "objectSid=%s", sid_str);
+       talloc_free(sid_str);
+       if (ret != LDB_SUCCESS) {
+               return ret;
+       }
+
+       *dn = talloc_steal(mem_ctx, res->msgs[0]->dn);
+       talloc_free(res);
+
+       return LDB_SUCCESS;
+}
 
 /*
   load a repsFromTo blob list for a given partition GUID
@@ -2390,7 +2651,7 @@ WERROR dsdb_loadreps(struct ldb_context *sam_ctx, TALLOC_CTX *mem_ctx, struct ld
        const char *attrs[] = { attr, NULL };
        struct ldb_result *res = NULL;
        TALLOC_CTX *tmp_ctx = talloc_new(mem_ctx);
-       int i;
+       unsigned int i;
        struct ldb_message_element *el;
 
        *r = NULL;
@@ -2420,7 +2681,7 @@ WERROR dsdb_loadreps(struct ldb_context *sam_ctx, TALLOC_CTX *mem_ctx, struct ld
        for (i=0; i<(*count); i++) {
                enum ndr_err_code ndr_err;
                ndr_err = ndr_pull_struct_blob(&el->values[i], 
-                                              mem_ctx, lp_iconv_convenience(ldb_get_opaque(sam_ctx, "loadparm")),
+                                              mem_ctx, 
                                               &(*r)[i], 
                                               (ndr_pull_flags_fn_t)ndr_pull_repsFromToBlob);
                if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
@@ -2444,7 +2705,7 @@ WERROR dsdb_savereps(struct ldb_context *sam_ctx, TALLOC_CTX *mem_ctx, struct ld
        TALLOC_CTX *tmp_ctx = talloc_new(mem_ctx);
        struct ldb_message *msg;
        struct ldb_message_element *el;
-       int i;
+       unsigned int i;
 
        msg = ldb_msg_new(tmp_ctx);
        msg->dn = dn;
@@ -2461,7 +2722,7 @@ WERROR dsdb_savereps(struct ldb_context *sam_ctx, TALLOC_CTX *mem_ctx, struct ld
                struct ldb_val v;
                enum ndr_err_code ndr_err;
 
-               ndr_err = ndr_push_struct_blob(&v, tmp_ctx, lp_iconv_convenience(ldb_get_opaque(sam_ctx, "loadparm")),
+               ndr_err = ndr_push_struct_blob(&v, tmp_ctx, 
                                               &r[i], 
                                               (ndr_push_flags_fn_t)ndr_push_repsFromToBlob);
                if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
@@ -2503,7 +2764,7 @@ int dsdb_load_partition_usn(struct ldb_context *ldb, struct ldb_dn *dn,
        res = talloc_zero(tmp_ctx, struct ldb_result);
        if (!res) {
                talloc_free(tmp_ctx);
-               return LDB_ERR_OPERATIONS_ERROR;
+               return ldb_oom(ldb);
        }
 
        ret = ldb_build_search_req(&req, ldb, tmp_ctx,
@@ -2520,13 +2781,12 @@ int dsdb_load_partition_usn(struct ldb_context *ldb, struct ldb_dn *dn,
 
        p_ctrl = talloc(req, struct dsdb_control_current_partition);
        if (p_ctrl == NULL) {
-               talloc_free(res);
-               return LDB_ERR_OPERATIONS_ERROR;
+               talloc_free(tmp_ctx);
+               return ldb_oom(ldb);
        }
        p_ctrl->version = DSDB_CONTROL_CURRENT_PARTITION_VERSION;
        p_ctrl->dn = dn;
        
-
        ret = ldb_request_add_control(req,
                                      DSDB_CONTROL_CURRENT_PARTITION_OID,
                                      false, p_ctrl);
@@ -2572,150 +2832,138 @@ int dsdb_load_partition_usn(struct ldb_context *ldb, struct ldb_dn *dn,
        return LDB_SUCCESS;     
 }
 
+int drsuapi_DsReplicaCursor2_compare(const struct drsuapi_DsReplicaCursor2 *c1,
+                                                  const struct drsuapi_DsReplicaCursor2 *c2)
+{
+       return GUID_compare(&c1->source_dsa_invocation_id, &c2->source_dsa_invocation_id);
+}
+
+int drsuapi_DsReplicaCursor_compare(const struct drsuapi_DsReplicaCursor *c1,
+                                   const struct drsuapi_DsReplicaCursor *c2)
+{
+       return GUID_compare(&c1->source_dsa_invocation_id, &c2->source_dsa_invocation_id);
+}
+
+
 /*
-  save uSNHighest and uSNUrgent attributes in the @REPLCHANGED object for a
-  partition
- */
-int dsdb_save_partition_usn(struct ldb_context *ldb, struct ldb_dn *dn,
-                               uint64_t uSN, uint64_t urgent_uSN)
+  see if a computer identified by its invocationId is a RODC
+*/
+int samdb_is_rodc(struct ldb_context *sam_ctx, const struct GUID *objectGUID, bool *is_rodc)
 {
-       struct ldb_request *req;
-       struct ldb_message *msg;
-       struct dsdb_control_current_partition *p_ctrl;
+       /* 1) find the DN for this servers NTDSDSA object
+          2) search for the msDS-isRODC attribute
+          3) if not present then not a RODC
+          4) if present and TRUE then is a RODC
+       */
+       struct ldb_dn *config_dn;
+       const char *attrs[] = { "msDS-isRODC", NULL };
        int ret;
+       struct ldb_result *res;
+       TALLOC_CTX *tmp_ctx = talloc_new(sam_ctx);
 
-       msg = ldb_msg_new(ldb);
-       if (msg == NULL) {
-               return LDB_ERR_OPERATIONS_ERROR;
+       config_dn = ldb_get_config_basedn(sam_ctx);
+       if (!config_dn) {
+               talloc_free(tmp_ctx);
+               return ldb_operr(sam_ctx);
        }
 
-       msg->dn = ldb_dn_new(msg, ldb, "@REPLCHANGED");
-       if (msg->dn == NULL) {
-               talloc_free(msg);
-               return LDB_ERR_OPERATIONS_ERROR;
+       ret = dsdb_search(sam_ctx, tmp_ctx, &res, config_dn, LDB_SCOPE_SUBTREE, attrs,
+                         DSDB_SEARCH_ONE_ONLY, "objectGUID=%s", GUID_string(tmp_ctx, objectGUID));
+
+       if (ret == LDB_ERR_NO_SUCH_OBJECT) {
+               *is_rodc = false;
+               talloc_free(tmp_ctx);
+               return LDB_SUCCESS;
        }
-       
-       ret = ldb_msg_add_fmt(msg, "uSNHighest", "%llu", (unsigned long long)uSN);
+
        if (ret != LDB_SUCCESS) {
-               talloc_free(msg);
+               DEBUG(1,(("Failed to find our own NTDS Settings object by objectGUID=%s!\n"),
+                        GUID_string(tmp_ctx, objectGUID)));
+               *is_rodc = false;
+               talloc_free(tmp_ctx);
                return ret;
        }
-       msg->elements[0].flags = LDB_FLAG_MOD_REPLACE;
-       
-       /* urgent_uSN is optional so may not be stored */
-       if (urgent_uSN) {
-               ret = ldb_msg_add_fmt(msg, "uSNUrgent", "%llu", (unsigned long long)urgent_uSN);
-               if (ret != LDB_SUCCESS) {
-                       talloc_free(msg);
-                       return ret;
-               }
-               msg->elements[1].flags = LDB_FLAG_MOD_REPLACE;
-       }
 
+       ret = ldb_msg_find_attr_as_bool(res->msgs[0], "msDS-isRODC", 0);
+       *is_rodc = (ret == 1);
 
-       p_ctrl = talloc(msg, struct dsdb_control_current_partition);
-       if (p_ctrl == NULL) {
-               talloc_free(msg);
-               return LDB_ERR_OPERATIONS_ERROR;
+       talloc_free(tmp_ctx);
+       return LDB_SUCCESS;
+}
+
+
+/*
+  see if we are a RODC
+*/
+int samdb_rodc(struct ldb_context *sam_ctx, bool *am_rodc)
+{
+       const struct GUID *objectGUID;
+       int ret;
+       bool *cached;
+
+       /* see if we have a cached copy */
+       cached = (bool *)ldb_get_opaque(sam_ctx, "cache.am_rodc");
+       if (cached) {
+               *am_rodc = *cached;
+               return LDB_SUCCESS;
        }
-       p_ctrl->version = DSDB_CONTROL_CURRENT_PARTITION_VERSION;
-       p_ctrl->dn = dn;
 
-       ret = ldb_build_mod_req(&req, ldb, msg,
-                               msg,
-                               NULL,
-                               NULL, ldb_op_default_callback,
-                               NULL);
-again:
-       if (ret != LDB_SUCCESS) {
-               talloc_free(msg);
-               return ret;
+       objectGUID = samdb_ntds_objectGUID(sam_ctx);
+       if (!objectGUID) {
+               return ldb_operr(sam_ctx);
        }
-       
-       ret = ldb_request_add_control(req,
-                                     DSDB_CONTROL_CURRENT_PARTITION_OID,
-                                     false, p_ctrl);
+
+       ret = samdb_is_rodc(sam_ctx, objectGUID, am_rodc);
        if (ret != LDB_SUCCESS) {
-               talloc_free(msg);
                return ret;
        }
-       
-       /* Run the new request */
-       ret = ldb_request(ldb, req);
-       
-       if (ret == LDB_SUCCESS) {
-               ret = ldb_wait(req->handle, LDB_WAIT_ALL);
-       }
-       if (ret == LDB_ERR_NO_SUCH_OBJECT) {
-               ret = ldb_build_add_req(&req, ldb, msg,
-                                       msg,
-                                       NULL,
-                                       NULL, ldb_op_default_callback,
-                                       NULL);
-               goto again;
+
+       cached = talloc(sam_ctx, bool);
+       if (cached == NULL) {
+               return ldb_oom(sam_ctx);
        }
-       
-       talloc_free(msg);
-       
-       return ret;
-}
+       *cached = *am_rodc;
 
-int drsuapi_DsReplicaCursor2_compare(const struct drsuapi_DsReplicaCursor2 *c1,
-                                                  const struct drsuapi_DsReplicaCursor2 *c2)
-{
-       return GUID_compare(&c1->source_dsa_invocation_id, &c2->source_dsa_invocation_id);
-}
+       ret = ldb_set_opaque(sam_ctx, "cache.am_rodc", cached);
+       if (ret != LDB_SUCCESS) {
+               talloc_free(cached);
+               return ldb_operr(sam_ctx);
+       }
 
-int drsuapi_DsReplicaCursor_compare(const struct drsuapi_DsReplicaCursor *c1,
-                                   const struct drsuapi_DsReplicaCursor *c2)
-{
-       return GUID_compare(&c1->source_dsa_invocation_id, &c2->source_dsa_invocation_id);
+       return LDB_SUCCESS;
 }
 
-/*
-  see if we are a RODC
-*/
-bool samdb_rodc(struct ldb_context *sam_ctx)
+bool samdb_set_am_rodc(struct ldb_context *ldb, bool am_rodc)
 {
        TALLOC_CTX *tmp_ctx;
-       const char *obj_category;
-       struct ldb_dn *obj_category_dn;
-       const struct ldb_val *obj_category_dn_rdn_val;
+       bool *cached;
 
-       tmp_ctx = talloc_new(sam_ctx);
+       tmp_ctx = talloc_new(ldb);
        if (tmp_ctx == NULL) {
-               DEBUG(1,("samdb_rodc: Failed to talloc new context.\n"));
-               goto failed;
-       }
-
-       obj_category = samdb_ntds_object_category(tmp_ctx, sam_ctx);
-       if (!obj_category) {
-               DEBUG(1,("samdb_rodc: Failed to get object category.\n"));
                goto failed;
        }
 
-       obj_category_dn = ldb_dn_new(tmp_ctx, sam_ctx, obj_category);
-       if (!obj_category_dn) {
-               DEBUG(1,("samdb_rodc: Failed to create object category dn.\n"));
+       cached = talloc(tmp_ctx, bool);
+       if (!cached) {
                goto failed;
        }
 
-       obj_category_dn_rdn_val = ldb_dn_get_rdn_val(obj_category_dn);
-       if (!obj_category_dn_rdn_val) {
-               DEBUG(1, ("samdb_rodc: Failed to get object category dn rdn value.\n"));
+       *cached = am_rodc;
+       if (ldb_set_opaque(ldb, "cache.am_rodc", cached) != LDB_SUCCESS) {
                goto failed;
        }
 
-       if (strequal((const char*)obj_category_dn_rdn_val->data, "NTDS-DSA-RO")) {
-               talloc_free(tmp_ctx);
-               return true;
-       }
+       talloc_steal(ldb, cached);
+       talloc_free(tmp_ctx);
+       return true;
 
 failed:
+       DEBUG(1,("Failed to set our own cached am_rodc in the ldb!\n"));
        talloc_free(tmp_ctx);
        return false;
 }
 
+
 /*
   return NTDS options flags. See MS-ADTS 7.1.1.2.2.1.2.1.1 
 
@@ -2734,7 +2982,7 @@ int samdb_ntds_options(struct ldb_context *ldb, uint32_t *options)
        }
 
        ret = ldb_search(ldb, tmp_ctx, &res, samdb_ntds_settings_dn(ldb), LDB_SCOPE_BASE, attrs, NULL);
-       if (ret) {
+       if (ret != LDB_SUCCESS) {
                goto failed;
        }
 
@@ -2761,7 +3009,7 @@ const char* samdb_ntds_object_category(TALLOC_CTX *tmp_ctx, struct ldb_context *
        struct ldb_result *res;
 
        ret = ldb_search(ldb, tmp_ctx, &res, samdb_ntds_settings_dn(ldb), LDB_SCOPE_BASE, attrs, NULL);
-       if (ret) {
+       if (ret != LDB_SUCCESS) {
                goto failed;
        }
 
@@ -2804,20 +3052,34 @@ const char *samdb_cn_to_lDAPDisplayName(TALLOC_CTX *mem_ctx, const char *cn)
 }
 
 /*
-  return domain functional level
-  returns DS_DOMAIN_FUNCTION_*
+ * This detects and returns the domain functional level (DS_DOMAIN_FUNCTION_*)
  */
 int dsdb_functional_level(struct ldb_context *ldb)
 {
        int *domainFunctionality =
                talloc_get_type(ldb_get_opaque(ldb, "domainFunctionality"), int);
        if (!domainFunctionality) {
-               DEBUG(0,(__location__ ": WARNING: domainFunctionality not setup\n"));
+               /* this is expected during initial provision */
+               DEBUG(4,(__location__ ": WARNING: domainFunctionality not setup\n"));
                return DS_DOMAIN_FUNCTION_2000;
        }
        return *domainFunctionality;
 }
 
+/*
+ * This detects and returns the forest functional level (DS_DOMAIN_FUNCTION_*)
+ */
+int dsdb_forest_functional_level(struct ldb_context *ldb)
+{
+       int *forestFunctionality =
+               talloc_get_type(ldb_get_opaque(ldb, "forestFunctionality"), int);
+       if (!forestFunctionality) {
+               DEBUG(0,(__location__ ": WARNING: forestFunctionality not setup\n"));
+               return DS_DOMAIN_FUNCTION_2000;
+       }
+       return *forestFunctionality;
+}
+
 /*
   set a GUID in an extended DN structure
  */
@@ -2903,6 +3165,35 @@ NTSTATUS dsdb_get_extended_dn_uint32(struct ldb_dn *dn, uint32_t *val, const cha
        return NT_STATUS_OK;
 }
 
+/*
+  return a dom_sid from a extended DN structure
+ */
+NTSTATUS dsdb_get_extended_dn_sid(struct ldb_dn *dn, struct dom_sid *sid, const char *component_name)
+{
+       const struct ldb_val *sid_blob;
+       struct TALLOC_CTX *tmp_ctx;
+       enum ndr_err_code ndr_err;
+
+       sid_blob = ldb_dn_get_extended_component(dn, component_name);
+       if (!sid_blob) {
+               return NT_STATUS_OBJECT_NAME_NOT_FOUND;
+       }
+
+       tmp_ctx = talloc_new(NULL);
+
+       ndr_err = ndr_pull_struct_blob_all(sid_blob, tmp_ctx, sid,
+                                          (ndr_pull_flags_fn_t)ndr_pull_dom_sid);
+       if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
+               NTSTATUS status = ndr_map_error2ntstatus(ndr_err);
+               talloc_free(tmp_ctx);
+               return status;
+       }
+
+       talloc_free(tmp_ctx);
+       return NT_STATUS_OK;
+}
+
+
 /*
   return RMD_FLAGS directly from a ldb_dn
   returns 0 if not found
@@ -2922,7 +3213,7 @@ uint32_t dsdb_dn_rmd_flags(struct ldb_dn *dn)
   return RMD_FLAGS directly from a ldb_val for a DN
   returns 0 if RMD_FLAGS is not found
  */
-uint32_t dsdb_dn_val_rmd_flags(struct ldb_val *val)
+uint32_t dsdb_dn_val_rmd_flags(const struct ldb_val *val)
 {
        const char *p;
        uint32_t flags;
@@ -2946,7 +3237,7 @@ uint32_t dsdb_dn_val_rmd_flags(struct ldb_val *val)
 /*
   return true if a ldb_val containing a DN in storage form is deleted
  */
-bool dsdb_dn_is_deleted_val(struct ldb_val *val)
+bool dsdb_dn_is_deleted_val(const struct ldb_val *val)
 {
        return (dsdb_dn_val_rmd_flags(val) & DSDB_RMD_FLAG_DELETED) != 0;
 }
@@ -2978,7 +3269,7 @@ int dsdb_wellknown_dn(struct ldb_context *samdb, TALLOC_CTX *mem_ctx,
                            wk_guid, ldb_dn_get_linearized(nc_root));
        if (!wkguid_dn) {
                talloc_free(tmp_ctx);
-               return LDB_ERR_OPERATIONS_ERROR;
+               return ldb_operr(samdb);
        }
 
        ret = dsdb_search_dn(samdb, tmp_ctx, &res, dn, attrs, DSDB_SEARCH_SHOW_DELETED);
@@ -3009,17 +3300,17 @@ int dsdb_find_nc_root(struct ldb_context *samdb, TALLOC_CTX *mem_ctx, struct ldb
        int ret;
        struct ldb_message_element *el;
        struct ldb_result *root_res;
-       int i;
+       unsigned int i;
        struct ldb_dn **nc_dns;
 
        tmp_ctx = talloc_new(samdb);
        if (tmp_ctx == NULL) {
-               return LDB_ERR_OPERATIONS_ERROR;
+               return ldb_oom(samdb);
        }
 
        ret = ldb_search(samdb, tmp_ctx, &root_res,
                         ldb_dn_new(tmp_ctx, samdb, ""), LDB_SCOPE_BASE, root_attrs, NULL);
-       if (ret) {
+       if (ret != LDB_SUCCESS) {
                DEBUG(1,("Searching for namingContexts in rootDSE failed: %s\n", ldb_errstring(samdb)));
                talloc_free(tmp_ctx);
                return ret;
@@ -3036,14 +3327,14 @@ int dsdb_find_nc_root(struct ldb_context *samdb, TALLOC_CTX *mem_ctx, struct ldb
        nc_dns = talloc_array(tmp_ctx, struct ldb_dn *, el->num_values);
        if (!nc_dns) {
               talloc_free(tmp_ctx);
-              return LDB_ERR_OPERATIONS_ERROR;
+              return ldb_oom(samdb);
        }
 
        for (i=0; i<el->num_values; i++) {
               nc_dns[i] = ldb_dn_from_ldb_val(nc_dns, samdb, &el->values[i]);
               if (nc_dns[i] == NULL) {
                       talloc_free(tmp_ctx);
-                      return LDB_ERR_OPERATIONS_ERROR;
+                      return ldb_operr(samdb);
               }
        }
 
@@ -3089,19 +3380,19 @@ int dsdb_get_deleted_objects_dn(struct ldb_context *ldb,
 int dsdb_tombstone_lifetime(struct ldb_context *ldb, uint32_t *lifetime)
 {
        struct ldb_dn *dn;
-       dn = samdb_config_dn(ldb);
+       dn = ldb_get_config_basedn(ldb);
        if (!dn) {
                return LDB_ERR_NO_SUCH_OBJECT;
        }
        dn = ldb_dn_copy(ldb, dn);
        if (!dn) {
-               return LDB_ERR_OPERATIONS_ERROR;
+               return ldb_operr(ldb);
        }
        /* see MS-ADTS section 7.1.1.2.4.1.1. There doesn't appear to
         be a wellknown GUID for this */
        if (!ldb_dn_add_child_fmt(dn, "CN=Directory Service,CN=Windows NT,CN=Services")) {
                talloc_free(dn);
-               return LDB_ERR_OPERATIONS_ERROR;
+               return ldb_operr(ldb);
        }
 
        *lifetime = samdb_search_uint(ldb, dn, 180, dn, "tombstoneLifetime", "objectClass=nTDSService");
@@ -3136,7 +3427,8 @@ int dsdb_load_udv_v2(struct ldb_context *samdb, struct ldb_dn *dn, TALLOC_CTX *m
        static const char *attrs[] = { "replUpToDateVector", NULL };
        struct ldb_result *r;
        const struct ldb_val *ouv_value;
-       int ret, i;
+       unsigned int i;
+       int ret;
        uint64_t highest_usn;
        const struct GUID *our_invocation_id;
        struct timeval now = timeval_current();
@@ -3151,8 +3443,7 @@ int dsdb_load_udv_v2(struct ldb_context *samdb, struct ldb_dn *dn, TALLOC_CTX *m
                enum ndr_err_code ndr_err;
                struct replUpToDateVectorBlob ouv;
 
-               ndr_err = ndr_pull_struct_blob(ouv_value, r,
-                                              lp_iconv_convenience(ldb_get_opaque(samdb, "loadparm")), &ouv,
+               ndr_err = ndr_pull_struct_blob(ouv_value, r, &ouv,
                                               (ndr_pull_flags_fn_t)ndr_pull_replUpToDateVectorBlob);
                if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
                        talloc_free(r);
@@ -3178,7 +3469,7 @@ int dsdb_load_udv_v2(struct ldb_context *samdb, struct ldb_dn *dn, TALLOC_CTX *m
        if (!our_invocation_id) {
                DEBUG(0,(__location__ ": No invocationID on samdb - %s\n", ldb_errstring(samdb)));
                talloc_free(*cursors);
-               return LDB_ERR_OPERATIONS_ERROR;
+               return ldb_operr(samdb);
        }
 
        ret = dsdb_load_partition_usn(samdb, dn, &highest_usn, NULL);
@@ -3199,7 +3490,7 @@ int dsdb_load_udv_v2(struct ldb_context *samdb, struct ldb_dn *dn, TALLOC_CTX *m
 
        (*cursors) = talloc_realloc(mem_ctx, *cursors, struct drsuapi_DsReplicaCursor2, (*count)+1);
        if (! *cursors) {
-               return LDB_ERR_OPERATIONS_ERROR;
+               return ldb_oom(samdb);
        }
 
        (*cursors)[*count].source_dsa_invocation_id = *our_invocation_id;
@@ -3220,7 +3511,8 @@ int dsdb_load_udv_v1(struct ldb_context *samdb, struct ldb_dn *dn, TALLOC_CTX *m
                     struct drsuapi_DsReplicaCursor **cursors, uint32_t *count)
 {
        struct drsuapi_DsReplicaCursor2 *v2;
-       int ret, i;
+       uint32_t i;
+       int ret;
 
        ret = dsdb_load_udv_v2(samdb, dn, mem_ctx, &v2, count);
        if (ret != LDB_SUCCESS) {
@@ -3236,7 +3528,7 @@ int dsdb_load_udv_v1(struct ldb_context *samdb, struct ldb_dn *dn, TALLOC_CTX *m
        *cursors = talloc_array(mem_ctx, struct drsuapi_DsReplicaCursor, *count);
        if (*cursors == NULL) {
                talloc_free(v2);
-               return LDB_ERR_OPERATIONS_ERROR;
+               return ldb_oom(samdb);
        }
 
        for (i=0; i<*count; i++) {
@@ -3326,9 +3618,46 @@ int dsdb_request_add_controls(struct ldb_request *req, uint32_t dsdb_flags)
                }
        }
 
+       if (dsdb_flags & DSDB_TREE_DELETE) {
+               ret = ldb_request_add_control(req, LDB_CONTROL_TREE_DELETE_OID, false, NULL);
+               if (ret != LDB_SUCCESS) {
+                       return ret;
+               }
+       }
+
        return LDB_SUCCESS;
 }
 
+/*
+  an add with a set of controls
+*/
+int dsdb_add(struct ldb_context *ldb, const struct ldb_message *message,
+            uint32_t dsdb_flags)
+{
+       struct ldb_request *req;
+       int ret;
+
+       ret = ldb_build_add_req(&req, ldb, ldb,
+                               message,
+                               NULL,
+                               NULL,
+                               ldb_op_default_callback,
+                               NULL);
+
+       if (ret != LDB_SUCCESS) return ret;
+
+       ret = dsdb_request_add_controls(req, dsdb_flags);
+       if (ret != LDB_SUCCESS) {
+               talloc_free(req);
+               return ret;
+       }
+
+       ret = dsdb_autotransaction_request(ldb, req);
+
+       talloc_free(req);
+       return ret;
+}
+
 /*
   a modify with a set of controls
 */
@@ -3365,7 +3694,7 @@ int dsdb_modify(struct ldb_context *ldb, const struct ldb_message *message,
  */
 int dsdb_replace(struct ldb_context *ldb, struct ldb_message *msg, uint32_t dsdb_flags)
 {
-       int i;
+       unsigned int i;
 
        /* mark all the message elements as LDB_FLAG_MOD_REPLACE */
        for (i=0;i<msg->num_elements;i++) {
@@ -3392,7 +3721,7 @@ int dsdb_search_dn(struct ldb_context *ldb,
 
        res = talloc_zero(mem_ctx, struct ldb_result);
        if (!res) {
-               return LDB_ERR_OPERATIONS_ERROR;
+               return ldb_oom(ldb);
        }
 
        ret = ldb_build_search_req(&req, ldb, res,
@@ -3430,6 +3759,32 @@ int dsdb_search_dn(struct ldb_context *ldb,
        return LDB_SUCCESS;
 }
 
+/*
+  search for attrs on one DN, by the GUID of the DN, allowing for
+  dsdb_flags controls
+ */
+int dsdb_search_by_dn_guid(struct ldb_context *ldb,
+                          TALLOC_CTX *mem_ctx,
+                          struct ldb_result **_res,
+                          const struct GUID *guid,
+                          const char * const *attrs,
+                          uint32_t dsdb_flags)
+{
+       TALLOC_CTX *tmp_ctx = talloc_new(mem_ctx);
+       struct ldb_dn *dn;
+       int ret;
+
+       dn = ldb_dn_new_fmt(tmp_ctx, ldb, "<GUID=%s>", GUID_string(tmp_ctx, guid));
+       if (!ldb_dn_validate(dn)) {
+               talloc_free(tmp_ctx);
+               return LDB_ERR_INVALID_DN_SYNTAX;
+       }
+
+       ret = dsdb_search_dn(ldb, mem_ctx, _res, dn, attrs, dsdb_flags);
+       talloc_free(tmp_ctx);
+       return ret;
+}
+
 /*
   general search with dsdb_flags for controls
  */
@@ -3452,7 +3807,7 @@ int dsdb_search(struct ldb_context *ldb,
        res = talloc_zero(tmp_ctx, struct ldb_result);
        if (!res) {
                talloc_free(tmp_ctx);
-               return LDB_ERR_OPERATIONS_ERROR;
+               return ldb_oom(ldb);
        }
 
        if (exp_fmt) {
@@ -3462,7 +3817,7 @@ int dsdb_search(struct ldb_context *ldb,
 
                if (!expression) {
                        talloc_free(tmp_ctx);
-                       return LDB_ERR_OPERATIONS_ERROR;
+                       return ldb_oom(ldb);
                }
        }
 
@@ -3483,6 +3838,7 @@ int dsdb_search(struct ldb_context *ldb,
        ret = dsdb_request_add_controls(req, dsdb_flags);
        if (ret != LDB_SUCCESS) {
                talloc_free(tmp_ctx);
+               ldb_reset_err_string(ldb);
                return ret;
        }
 
@@ -3499,10 +3855,12 @@ int dsdb_search(struct ldb_context *ldb,
        if (dsdb_flags & DSDB_SEARCH_ONE_ONLY) {
                if (res->count == 0) {
                        talloc_free(tmp_ctx);
+                       ldb_reset_err_string(ldb);
                        return LDB_ERR_NO_SUCH_OBJECT;
                }
                if (res->count != 1) {
                        talloc_free(tmp_ctx);
+                       ldb_reset_err_string(ldb);
                        return LDB_ERR_CONSTRAINT_VIOLATION;
                }
        }
@@ -3538,7 +3896,7 @@ int dsdb_search_one(struct ldb_context *ldb,
        res = talloc_zero(tmp_ctx, struct ldb_result);
        if (!res) {
                talloc_free(tmp_ctx);
-               return LDB_ERR_OPERATIONS_ERROR;
+               return ldb_oom(ldb);
        }
 
        if (exp_fmt) {
@@ -3548,12 +3906,15 @@ int dsdb_search_one(struct ldb_context *ldb,
 
                if (!expression) {
                        talloc_free(tmp_ctx);
-                       return LDB_ERR_OPERATIONS_ERROR;
+                       return ldb_oom(ldb);
                }
+               ret = dsdb_search(ldb, tmp_ctx, &res, basedn, scope, attrs,
+                                 dsdb_flags, "%s", expression);
+       } else {
+               ret = dsdb_search(ldb, tmp_ctx, &res, basedn, scope, attrs,
+                                 dsdb_flags, NULL);
        }
 
-       ret = dsdb_search(ldb, tmp_ctx, &res, basedn, scope, attrs,
-                         dsdb_flags, "%s", expression);
        if (ret != LDB_SUCCESS) {
                talloc_free(tmp_ctx);
                return ret;
@@ -3564,3 +3925,287 @@ int dsdb_search_one(struct ldb_context *ldb,
 
        return LDB_SUCCESS;
 }
+
+/* returns back the forest DNS name */
+const char *samdb_forest_name(struct ldb_context *ldb, TALLOC_CTX *mem_ctx)
+{
+       const char *forest_name = ldb_dn_canonical_string(mem_ctx,
+                                                         ldb_get_root_basedn(ldb));
+       char *p;
+
+       if (forest_name == NULL) {
+               return NULL;
+       }
+
+       p = strchr(forest_name, '/');
+       if (p) {
+               *p = '\0';
+       }
+
+       return forest_name;
+}
+
+/*
+   validate that an DSA GUID belongs to the specified user sid.
+   The user SID must be a domain controller account (either RODC or
+   RWDC)
+ */
+int dsdb_validate_dsa_guid(struct ldb_context *ldb,
+                          const struct GUID *dsa_guid,
+                          const struct dom_sid *sid)
+{
+       /* strategy:
+           - find DN of record with the DSA GUID in the
+             configuration partition (objectGUID)
+            - remove "NTDS Settings" component from DN
+           - do a base search on that DN for serverReference with
+             extended-dn enabled
+            - extract objectSid from resulting serverReference
+              attribute
+           - check this sid matches the sid argument
+       */
+       struct ldb_dn *config_dn;
+       TALLOC_CTX *tmp_ctx = talloc_new(ldb);
+       struct ldb_message *msg;
+       const char *attrs1[] = { NULL };
+       const char *attrs2[] = { "serverReference", NULL };
+       int ret;
+       struct ldb_dn *dn, *account_dn;
+       struct dom_sid sid2;
+       NTSTATUS status;
+
+       config_dn = ldb_get_config_basedn(ldb);
+
+       ret = dsdb_search_one(ldb, tmp_ctx, &msg, config_dn, LDB_SCOPE_SUBTREE,
+                             attrs1, 0, "(&(objectGUID=%s)(objectClass=nTDSDSA))", GUID_string(tmp_ctx, dsa_guid));
+       if (ret != LDB_SUCCESS) {
+               DEBUG(1,(__location__ ": Failed to find DSA objectGUID %s for sid %s\n",
+                        GUID_string(tmp_ctx, dsa_guid), dom_sid_string(tmp_ctx, sid)));
+               talloc_free(tmp_ctx);
+               return ldb_operr(ldb);
+       }
+       dn = msg->dn;
+
+       if (!ldb_dn_remove_child_components(dn, 1)) {
+               talloc_free(tmp_ctx);
+               return ldb_operr(ldb);
+       }
+
+       ret = dsdb_search_one(ldb, tmp_ctx, &msg, dn, LDB_SCOPE_BASE,
+                             attrs2, DSDB_SEARCH_SHOW_EXTENDED_DN,
+                             "(objectClass=server)");
+       if (ret != LDB_SUCCESS) {
+               DEBUG(1,(__location__ ": Failed to find server record for DSA with objectGUID %s, sid %s\n",
+                        GUID_string(tmp_ctx, dsa_guid), dom_sid_string(tmp_ctx, sid)));
+               talloc_free(tmp_ctx);
+               return ldb_operr(ldb);
+       }
+
+       account_dn = ldb_msg_find_attr_as_dn(ldb, tmp_ctx, msg, "serverReference");
+       if (account_dn == NULL) {
+               DEBUG(1,(__location__ ": Failed to find account_dn for DSA with objectGUID %s, sid %s\n",
+                        GUID_string(tmp_ctx, dsa_guid), dom_sid_string(tmp_ctx, sid)));
+               talloc_free(tmp_ctx);
+               return ldb_operr(ldb);
+       }
+
+       status = dsdb_get_extended_dn_sid(account_dn, &sid2, "SID");
+       if (!NT_STATUS_IS_OK(status)) {
+               DEBUG(1,(__location__ ": Failed to find SID for DSA with objectGUID %s, sid %s\n",
+                        GUID_string(tmp_ctx, dsa_guid), dom_sid_string(tmp_ctx, sid)));
+               talloc_free(tmp_ctx);
+               return ldb_operr(ldb);
+       }
+
+       if (!dom_sid_equal(sid, &sid2)) {
+               /* someone is trying to spoof another account */
+               DEBUG(0,(__location__ ": Bad DSA objectGUID %s for sid %s - expected sid %s\n",
+                        GUID_string(tmp_ctx, dsa_guid),
+                        dom_sid_string(tmp_ctx, sid),
+                        dom_sid_string(tmp_ctx, &sid2)));
+               talloc_free(tmp_ctx);
+               return ldb_operr(ldb);
+       }
+
+       talloc_free(tmp_ctx);
+       return LDB_SUCCESS;
+}
+
+static const char *secret_attributes[] = {
+       "currentValue",
+       "dBCSPwd",
+       "initialAuthIncoming",
+       "initialAuthOutgoing",
+       "lmPwdHistory",
+       "ntPwdHistory",
+       "priorValue",
+       "supplementalCredentials",
+       "trustAuthIncoming",
+       "trustAuthOutgoing",
+       "unicodePwd",
+       NULL
+};
+
+/*
+  check if the attribute belongs to the RODC filtered attribute set
+  Note that attributes that are in the filtered attribute set are the
+  ones that _are_ always sent to a RODC
+*/
+bool dsdb_attr_in_rodc_fas(const struct dsdb_attribute *sa)
+{
+       /* they never get secret attributes */
+       if (is_attr_in_list(secret_attributes, sa->lDAPDisplayName)) {
+               return false;
+       }
+
+       /* they do get non-secret critical attributes */
+       if (sa->schemaFlagsEx & SCHEMA_FLAG_ATTR_IS_CRITICAL) {
+               return true;
+       }
+
+       /* they do get non-secret attributes marked as being in the FAS  */
+       if (sa->searchFlags & SEARCH_FLAG_RODC_ATTRIBUTE) {
+               return true;
+       }
+
+       /* other attributes are denied */
+       return false;
+}
+
+/* return fsmo role dn and role owner dn for a particular role*/
+WERROR dsdb_get_fsmo_role_info(TALLOC_CTX *tmp_ctx,
+                              struct ldb_context *ldb,
+                              uint32_t role,
+                              struct ldb_dn **fsmo_role_dn,
+                              struct ldb_dn **role_owner_dn)
+{
+       int ret;
+       switch (role) {
+       case DREPL_NAMING_MASTER:
+               *fsmo_role_dn = samdb_partitions_dn(ldb, tmp_ctx);
+               ret = samdb_reference_dn(ldb, tmp_ctx, *fsmo_role_dn, "fSMORoleOwner", role_owner_dn);
+               if (ret != LDB_SUCCESS) {
+                       DEBUG(0,(__location__ ": Failed to find fSMORoleOwner in Naming Master object - %s",
+                                ldb_errstring(ldb)));
+                       talloc_free(tmp_ctx);
+                       return WERR_DS_DRA_INTERNAL_ERROR;
+               }
+               break;
+       case DREPL_INFRASTRUCTURE_MASTER:
+               *fsmo_role_dn = samdb_infrastructure_dn(ldb, tmp_ctx);
+               ret = samdb_reference_dn(ldb, tmp_ctx, *fsmo_role_dn, "fSMORoleOwner", role_owner_dn);
+               if (ret != LDB_SUCCESS) {
+                       DEBUG(0,(__location__ ": Failed to find fSMORoleOwner in Schema Master object - %s",
+                                ldb_errstring(ldb)));
+                       talloc_free(tmp_ctx);
+                       return WERR_DS_DRA_INTERNAL_ERROR;
+               }
+               break;
+       case DREPL_RID_MASTER:
+               ret = samdb_rid_manager_dn(ldb, tmp_ctx, fsmo_role_dn);
+               if (ret != LDB_SUCCESS) {
+                       DEBUG(0, (__location__ ": Failed to find RID Manager object - %s", ldb_errstring(ldb)));
+                       talloc_free(tmp_ctx);
+                       return WERR_DS_DRA_INTERNAL_ERROR;
+               }
+
+               ret = samdb_reference_dn(ldb, tmp_ctx, *fsmo_role_dn, "fSMORoleOwner", role_owner_dn);
+               if (ret != LDB_SUCCESS) {
+                       DEBUG(0,(__location__ ": Failed to find fSMORoleOwner in RID Manager object - %s",
+                                ldb_errstring(ldb)));
+                       talloc_free(tmp_ctx);
+                       return WERR_DS_DRA_INTERNAL_ERROR;
+               }
+               break;
+       case DREPL_SCHEMA_MASTER:
+               *fsmo_role_dn = ldb_get_schema_basedn(ldb);
+               ret = samdb_reference_dn(ldb, tmp_ctx, *fsmo_role_dn, "fSMORoleOwner", role_owner_dn);
+               if (ret != LDB_SUCCESS) {
+                       DEBUG(0,(__location__ ": Failed to find fSMORoleOwner in Schema Master object - %s",
+                                ldb_errstring(ldb)));
+                       talloc_free(tmp_ctx);
+                       return WERR_DS_DRA_INTERNAL_ERROR;
+               }
+               break;
+       case DREPL_PDC_MASTER:
+               *fsmo_role_dn = ldb_get_default_basedn(ldb);
+               ret = samdb_reference_dn(ldb, tmp_ctx, *fsmo_role_dn, "fSMORoleOwner", role_owner_dn);
+               if (ret != LDB_SUCCESS) {
+                       DEBUG(0,(__location__ ": Failed to find fSMORoleOwner in Pd Master object - %s",
+                                ldb_errstring(ldb)));
+                       talloc_free(tmp_ctx);
+                       return WERR_DS_DRA_INTERNAL_ERROR;
+               }
+               break;
+       default:
+               return WERR_DS_DRA_INTERNAL_ERROR;
+       }
+       return WERR_OK;
+}
+
+const char *samdb_dn_to_dnshostname(struct ldb_context *ldb,
+                                   TALLOC_CTX *mem_ctx,
+                                   struct ldb_dn *server_dn)
+{
+       int ldb_ret;
+       struct ldb_result *res = NULL;
+       const char * const attrs[] = { "dNSHostName", NULL};
+
+       ldb_ret = ldb_search(ldb, mem_ctx, &res,
+                            server_dn,
+                            LDB_SCOPE_BASE,
+                            attrs, NULL);
+       if (ldb_ret != LDB_SUCCESS) {
+               DEBUG(4, ("Failed to find dNSHostName for dn %s, ldb error: %s",
+                         ldb_dn_get_linearized(server_dn), ldb_errstring(ldb)));
+               return NULL;
+       }
+
+       return samdb_result_string(res->msgs[0], "dNSHostName", NULL);
+}
+
+/*
+  returns true if an attribute is in the filter,
+  false otherwise, provided that attribute value is provided with the expression
+*/
+bool dsdb_attr_in_parse_tree(struct ldb_parse_tree *tree,
+                            const char *attr)
+{
+       unsigned int i;
+       switch (tree->operation) {
+       case LDB_OP_AND:
+       case LDB_OP_OR:
+               for (i=0;i<tree->u.list.num_elements;i++) {
+                       if (dsdb_attr_in_parse_tree(tree->u.list.elements[i],
+                                                       attr))
+                               return true;
+               }
+               return false;
+       case LDB_OP_NOT:
+               return dsdb_attr_in_parse_tree(tree->u.isnot.child, attr);
+       case LDB_OP_EQUALITY:
+       case LDB_OP_GREATER:
+       case LDB_OP_LESS:
+       case LDB_OP_APPROX:
+               if (ldb_attr_cmp(tree->u.equality.attr, attr) == 0) {
+                       return true;
+               }
+               return false;
+       case LDB_OP_SUBSTRING:
+               if (ldb_attr_cmp(tree->u.substring.attr, attr) == 0) {
+                       return true;
+               }
+               return false;
+       case LDB_OP_PRESENT:
+              /* (attrname=*) is not filtered out */
+               return false;
+       case LDB_OP_EXTENDED:
+               if (tree->u.extended.attr &&
+                   ldb_attr_cmp(tree->u.extended.attr, attr) == 0) {
+                      return true;
+               }
+               return false;
+       }
+       return false;
+}
+