s3/profiles: improve copy_registry_tree() errors
[samba.git] / source3 / utils / profiles.c
index 921af566576954634420b2fa66d60e87b1ca8ded..0f274ad604a2aa94cf2cbcc29ee2f138ea58d9ae 100644 (file)
@@ -1,32 +1,36 @@
-/* 
-   Samba Unix/Linux SMB client utility profiles.c 
-   
-   Copyright (C) Richard Sharpe, <rsharpe@richardsharpe.com>   2002 
-   Copyright (C) Jelmer Vernooij (conversion to popt)          2003 
-   Copyright (C) Gerald (Jerry) Carter                         2005 
+/*
+   Samba Unix/Linux SMB client utility profiles.c
+
+   Copyright (C) Richard Sharpe, <rsharpe@richardsharpe.com>   2002
+   Copyright (C) Jelmer Vernooij (conversion to popt)          2003
+   Copyright (C) Gerald (Jerry) Carter                         2005
 
    This program is free software; you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
    the Free Software Foundation; either version 3 of the License, or
    (at your option) any later version.
-   
+
    This program is distributed in the hope that it will be useful,
    but WITHOUT ANY WARRANTY; without even the implied warranty of
    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
    GNU General Public License for more details.
-   
+
    You should have received a copy of the GNU General Public License
-   along with this program.  If not, see <http://www.gnu.org/licenses/>.  
+   along with this program.  If not, see <http://www.gnu.org/licenses/>.
 */
-                                  
+
 #include "includes.h"
-#include "regfio.h"
+#include "system/filesys.h"
+#include "popt_common.h"
+#include "registry/reg_objects.h"
+#include "registry/regfio.h"
+#include "../libcli/security/security.h"
 
 /* GLOBAL VARIABLES */
 
-DOM_SID old_sid, new_sid;
+struct dom_sid old_sid, new_sid;
 int change = 0, new_val = 0;
-BOOL opt_verbose = False;
+int opt_verbose = False;
 
 /********************************************************************
 ********************************************************************/
@@ -47,7 +51,7 @@ static void verbose_output(const char *format, ...)
                return;
        }
 
-       fprintf(stdout, var);
+       fprintf(stdout, "%s", var);
        va_end(args);
        SAFE_FREE(var);
 }
@@ -55,53 +59,53 @@ static void verbose_output(const char *format, ...)
 /********************************************************************
 ********************************************************************/
 
-static BOOL swap_sid_in_acl( SEC_DESC *sd, DOM_SID *s1, DOM_SID *s2 )
+static bool swap_sid_in_acl( struct security_descriptor *sd, struct dom_sid *s1, struct dom_sid *s2 )
 {
-       SEC_ACL *acl;
+       struct security_acl *theacl;
        int i;
-       BOOL update = False;
+       bool update = False;
 
-       verbose_output("  Owner SID: %s\n", sid_string_static(sd->owner_sid));
-       if ( sid_equal( sd->owner_sid, s1 ) ) {
+       verbose_output("  Owner SID: %s\n", sid_string_tos(sd->owner_sid));
+       if ( dom_sid_equal( sd->owner_sid, s1 ) ) {
                sid_copy( sd->owner_sid, s2 );
                update = True;
-               verbose_output("  New Owner SID: %s\n", 
-                       sid_string_static(sd->owner_sid));
+               verbose_output("  New Owner SID: %s\n",
+                       sid_string_tos(sd->owner_sid));
 
        }
 
-       verbose_output("  Group SID: %s\n", sid_string_static(sd->group_sid));
-       if ( sid_equal( sd->group_sid, s1 ) ) {
+       verbose_output("  Group SID: %s\n", sid_string_tos(sd->group_sid));
+       if ( dom_sid_equal( sd->group_sid, s1 ) ) {
                sid_copy( sd->group_sid, s2 );
                update = True;
-               verbose_output("  New Group SID: %s\n", 
-                       sid_string_static(sd->group_sid));
+               verbose_output("  New Group SID: %s\n",
+                       sid_string_tos(sd->group_sid));
        }
 
-       acl = sd->dacl;
-       verbose_output("  DACL: %d entries:\n", acl->num_aces);
-       for ( i=0; i<acl->num_aces; i++ ) {
-               verbose_output("    Trustee SID: %s\n", 
-                       sid_string_static(&acl->aces[i].trustee));
-               if ( sid_equal( &acl->aces[i].trustee, s1 ) ) {
-                       sid_copy( &acl->aces[i].trustee, s2 );
+       theacl = sd->dacl;
+       verbose_output("  DACL: %d entries:\n", theacl->num_aces);
+       for ( i=0; i<theacl->num_aces; i++ ) {
+               verbose_output("    Trustee SID: %s\n",
+                       sid_string_tos(&theacl->aces[i].trustee));
+               if ( dom_sid_equal( &theacl->aces[i].trustee, s1 ) ) {
+                       sid_copy( &theacl->aces[i].trustee, s2 );
                        update = True;
-                       verbose_output("    New Trustee SID: %s\n", 
-                               sid_string_static(&acl->aces[i].trustee));
+                       verbose_output("    New Trustee SID: %s\n",
+                               sid_string_tos(&theacl->aces[i].trustee));
                }
        }
 
 #if 0
-       acl = sd->sacl;
-       verbose_output("  SACL: %d entries: \n", acl->num_aces);
-       for ( i=0; i<acl->num_aces; i++ ) {
-               verbose_output("    Trustee SID: %s\n", 
-                       sid_string_static(&acl->aces[i].trustee));
-               if ( sid_equal( &acl->aces[i].trustee, s1 ) ) {
-                       sid_copy( &acl->aces[i].trustee, s2 );
+       theacl = sd->sacl;
+       verbose_output("  SACL: %d entries: \n", theacl->num_aces);
+       for ( i=0; i<theacl->num_aces; i++ ) {
+               verbose_output("    Trustee SID: %s\n",
+                       sid_string_tos(&theacl->aces[i].trustee));
+               if ( dom_sid_equal( &theacl->aces[i].trustee, s1 ) ) {
+                       sid_copy( &theacl->aces[i].trustee, s2 );
                        update = True;
-                       verbose_output("    New Trustee SID: %s\n", 
-                               sid_string_static(&acl->aces[i].trustee));
+                       verbose_output("    New Trustee SID: %s\n",
+                               sid_string_tos(&theacl->aces[i].trustee));
                }
        }
 #endif
@@ -111,46 +115,56 @@ static BOOL swap_sid_in_acl( SEC_DESC *sd, DOM_SID *s1, DOM_SID *s2 )
 /********************************************************************
 ********************************************************************/
 
-static BOOL copy_registry_tree( REGF_FILE *infile, REGF_NK_REC *nk,
+static bool copy_registry_tree( REGF_FILE *infile, REGF_NK_REC *nk,
                                 REGF_NK_REC *parent, REGF_FILE *outfile,
                                 const char *parentpath  )
 {
        REGF_NK_REC *key, *subkey;
-       SEC_DESC *new_sd;
-       REGVAL_CTR *values;
-       REGSUBKEY_CTR *subkeys;
+       struct security_descriptor *new_sd;
+       struct regval_ctr *values;
+       struct regsubkey_ctr *subkeys;
        int i;
-       pstring path;
+       char *path;
+       WERROR werr;
 
        /* swap out the SIDs in the security descriptor */
 
-       if ( !(new_sd = dup_sec_desc( outfile->mem_ctx, nk->sec_desc->sec_desc )) ) {
-               fprintf( stderr, "Failed to copy security descriptor!\n" );
+       if (nk->sec_desc->sec_desc == NULL) {
+               fprintf(stderr, "Invalid (NULL) security descriptor!\n");
+               return false;
+       }
+
+       new_sd = security_descriptor_copy(outfile->mem_ctx,
+                                         nk->sec_desc->sec_desc);
+       if (new_sd == NULL) {
+               fprintf(stderr, "Failed to copy security descriptor!\n");
                return False;
        }
 
        verbose_output("ACL for %s%s%s\n", parentpath, parent ? "\\" : "", nk->keyname);
        swap_sid_in_acl( new_sd, &old_sid, &new_sid );
 
-       if ( !(subkeys = TALLOC_ZERO_P( NULL, REGSUBKEY_CTR )) ) {
+       werr = regsubkey_ctr_init(NULL, &subkeys);
+       if (!W_ERROR_IS_OK(werr)) {
                DEBUG(0,("copy_registry_tree: talloc() failure!\n"));
                return False;
        }
 
-       if ( !(values = TALLOC_ZERO_P( subkeys, REGVAL_CTR )) ) {
+       werr = regval_ctr_init(subkeys, &values);
+       if (!W_ERROR_IS_OK(werr)) {
                TALLOC_FREE( subkeys );
                DEBUG(0,("copy_registry_tree: talloc() failure!\n"));
                return False;
        }
 
-       /* copy values into the REGVAL_CTR */
+       /* copy values into the struct regval_ctr */
 
        for ( i=0; i<nk->num_values; i++ ) {
                regval_ctr_addvalue( values, nk->values[i].valuename, nk->values[i].type,
-                       (const char *)nk->values[i].data, (nk->values[i].data_size & ~VK_DATA_IN_OFFSET) );
+                       nk->values[i].data, (nk->values[i].data_size & ~VK_DATA_IN_OFFSET) );
        }
 
-       /* copy subkeys into the REGSUBKEY_CTR */
+       /* copy subkeys into the struct regsubkey_ctr */
 
        while ( (subkey = regfio_fetch_subkey( infile, nk )) ) {
                regsubkey_ctr_addkey( subkeys, subkey->keyname );
@@ -160,13 +174,18 @@ static BOOL copy_registry_tree( REGF_FILE *infile, REGF_NK_REC *nk,
 
        /* write each one of the subkeys out */
 
-       pstr_sprintf( path, "%s%s%s", parentpath, parent ? "\\" : "", nk->keyname );
-       
+       path = talloc_asprintf(subkeys, "%s%s%s",
+                       parentpath, parent ? "\\" : "",nk->keyname);
+       if (!path) {
+               TALLOC_FREE( subkeys );
+               return false;
+       }
+
        nk->subkey_index = 0;
-       while ( (subkey = regfio_fetch_subkey( infile, nk )) ) {
-               if ( !copy_registry_tree( infile, subkey, key, outfile, path ) ) {
-                       TALLOC_FREE( subkeys );
-                       return False;
+       while ((subkey = regfio_fetch_subkey(infile, nk))) {
+               if (!copy_registry_tree( infile, subkey, key, outfile, path)) {
+                       TALLOC_FREE(subkeys);
+                       return false;
                }
        }
 
@@ -182,12 +201,13 @@ static BOOL copy_registry_tree( REGF_FILE *infile, REGF_NK_REC *nk,
 /*********************************************************************
 *********************************************************************/
 
-int main( int argc, char *argv[] )
+int main( int argc, const char *argv[] )
 {
+       TALLOC_CTX *frame = talloc_stackframe();
        int opt;
        REGF_FILE *infile, *outfile;
        REGF_NK_REC *nk;
-       pstring orig_filename, new_filename;
+       char *orig_filename, *new_filename;
        struct poptOption long_options[] = {
                POPT_AUTOHELP
                { "change-sid", 'c', POPT_ARG_STRING, NULL, 'c', "Provides SID to change" },
@@ -203,11 +223,9 @@ int main( int argc, char *argv[] )
 
        /* setup logging options */
 
-       setup_logging( "profiles", True );
-       dbf = x_stderr;
-       x_setbuf( x_stderr, NULL );
+       setup_logging( "profiles", DEBUG_STDERR);
 
-       pc = poptGetContext("profiles", argc, (const char **)argv, long_options, 
+       pc = poptGetContext("profiles", argc, argv, long_options,
                POPT_CONTEXT_KEEP_FIRST);
 
        poptSetOtherOptionHelp(pc, "<profilefile>");
@@ -237,7 +255,7 @@ int main( int argc, char *argv[] )
                }
        }
 
-       poptGetArg(pc); 
+       poptGetArg(pc);
 
        if (!poptPeekArg(pc)) {
                poptPrintUsage(pc, stderr, 0);
@@ -250,39 +268,49 @@ int main( int argc, char *argv[] )
                exit(252);
        }
 
-       pstrcpy( orig_filename, poptPeekArg(pc) );
-       pstr_sprintf( new_filename, "%s.new", orig_filename );
-       
-       if ( !(infile = regfio_open( orig_filename, O_RDONLY, 0 )) ) {
+       orig_filename = talloc_strdup(frame, poptPeekArg(pc));
+       if (!orig_filename) {
+               exit(ENOMEM);
+       }
+       new_filename = talloc_asprintf(frame,
+                                       "%s.new",
+                                       orig_filename);
+       if (!new_filename) {
+               exit(ENOMEM);
+       }
+
+       if (!(infile = regfio_open( orig_filename, O_RDONLY, 0))) {
                fprintf( stderr, "Failed to open %s!\n", orig_filename );
                fprintf( stderr, "Error was (%s)\n", strerror(errno) );
                exit (1);
        }
-       
-       if ( !(outfile = regfio_open( new_filename, (O_RDWR|O_CREAT|O_TRUNC), (S_IREAD|S_IWRITE) )) ) {
+
+       if ( !(outfile = regfio_open( new_filename, (O_RDWR|O_CREAT|O_TRUNC),
+                                     (S_IRUSR|S_IWUSR) )) ) {
                fprintf( stderr, "Failed to open new file %s!\n", new_filename );
                fprintf( stderr, "Error was (%s)\n", strerror(errno) );
                exit (1);
        }
-       
+
        /* actually do the update now */
-       
+
        if ((nk = regfio_rootkey( infile )) == NULL) {
                fprintf(stderr, "Could not get rootkey\n");
                exit(3);
        }
-       
-       if ( !copy_registry_tree( infile, nk, NULL, outfile, "" ) ) {
+
+       if (!copy_registry_tree( infile, nk, NULL, outfile, "")) {
                fprintf(stderr, "Failed to write updated registry file!\n");
                exit(2);
        }
-       
+
        /* cleanup */
-       
-       regfio_close( infile );
-       regfio_close( outfile );
+
+       regfio_close(infile);
+       regfio_close(outfile);
 
        poptFreeContext(pc);
 
-       return( 0 );
+       TALLOC_FREE(frame);
+       return 0;
 }