Fix net rpc join (at least newstyle) after it was broken by changing
[samba.git] / source3 / utils / net_rpc_join.c
index c4558ea10b85dfd85406a1ce67b51761d21e1463..eb91a7df61292f45e2a23d8c322b65c5e587606f 100644 (file)
                 goto done; \
         }
 
+
+/**
+ * confirm that a domain join is still valid
+ *
+ * @return A shell status integer (0 for success)
+ *
+ **/
+int net_rpc_join_ok(const char *domain)
+{
+       struct cli_state *cli;
+       uchar stored_md4_trust_password[16];
+       int retval = 1;
+       uint32 channel;
+       NTSTATUS result;
+
+       /* Connect to remote machine */
+       if (!(cli = net_make_ipc_connection(NET_FLAGS_ANONYMOUS | NET_FLAGS_PDC))) {
+               return 1;
+       }
+
+       if (!cli_nt_session_open(cli, PI_NETLOGON)) {
+               DEBUG(0,("Error connecting to NETLOGON pipe\n"));
+               goto done;
+       }
+
+       if (!secrets_fetch_trust_account_password(domain,
+                                                 stored_md4_trust_password, 
+                                                 NULL, &channel)) {
+               DEBUG(0,("Could not retreive domain trust secret"));
+               goto done;
+       }
+       
+       /* ensure that schannel uses the right domain */
+       fstrcpy(cli->domain, domain);
+       if (! NT_STATUS_IS_OK(result = cli_nt_establish_netlogon(cli, channel, stored_md4_trust_password))) {
+               DEBUG(0,("Error in domain join verfication (fresh connection)\n"));
+               goto done;
+       }
+       
+       retval = 0;             /* Success! */
+       
+done:
+       /* Close down pipe - this will clean up open policy handles */
+       if (cli->nt_pipe_fnum)
+               cli_nt_session_close(cli);
+
+       cli_shutdown(cli);
+
+       return retval;
+}
+
 /**
  * Join a domain using the administrator username and password
  *
 int net_rpc_join_newstyle(int argc, const char **argv) 
 {
 
-       extern pstring global_myname;
-
        /* libsmb variables */
 
        struct cli_state *cli;
-       fstring acct_name;
        TALLOC_CTX *mem_ctx;
-        uint32 acb_info;
+        uint32 acb_info = ACB_WSTRUST;
+       uint32 sec_channel_type;
 
        /* rpc variables */
 
        POLICY_HND lsa_pol, sam_pol, domain_pol, user_pol;
-       DOM_SID domain_sid;
+       DOM_SID *domain_sid;
        uint32 user_rid;
 
        /* Password stuff */
@@ -68,35 +117,57 @@ int net_rpc_join_newstyle(int argc, const char **argv)
        char *clear_trust_password = NULL;
        fstring ucs2_trust_password;
        int ucs2_pw_len;
-       uchar stored_md4_trust_password[16];
-       uchar pwbuf[516], sess_key[16];
+       uchar pwbuf[516];
        SAM_USERINFO_CTR ctr;
        SAM_USER_INFO_24 p24;
        SAM_USER_INFO_10 p10;
+       uchar md4_trust_password[16];
 
        /* Misc */
 
        NTSTATUS result;
        int retval = 1;
-       fstring domain;
+       char *domain;
        uint32 num_rids, *name_types, *user_rids;
        uint32 flags = 0x3e8;
-       char *names;
-       
+       char *acct_name;
+       const char *const_acct_name;
+
+       /* check what type of join */
+       if (argc >= 0) {
+               sec_channel_type = get_sec_channel_type(argv[0]);
+       } else {
+               sec_channel_type = get_sec_channel_type(NULL);
+       }
+
+       switch (sec_channel_type) {
+       case SEC_CHAN_WKSTA:
+               acb_info = ACB_WSTRUST;
+               break;
+       case SEC_CHAN_BDC:
+               acb_info = ACB_SVRTRUST;
+               break;
+#if 0
+       case SEC_CHAN_DOMAIN:
+               acb_info = ACB_DOMTRUST;
+               break;
+#endif
+       }
+
        /* Connect to remote machine */
 
        if (!(cli = net_make_ipc_connection(NET_FLAGS_PDC))) 
                return 1;
 
-       if (!(mem_ctx = talloc_init())) {
+       if (!(mem_ctx = talloc_init("net_rpc_join_newstyle"))) {
                DEBUG(0, ("Could not initialise talloc context\n"));
                goto done;
        }
 
        /* Fetch domain sid */
 
-       if (!cli_nt_session_open(cli, PIPE_LSARPC)) {
-               DEBUG(0, ("Error connecting to SAM pipe\n"));
+       if (!cli_nt_session_open(cli, PI_LSARPC)) {
+               DEBUG(0, ("Error connecting to LSA pipe\n"));
                goto done;
        }
 
@@ -107,7 +178,7 @@ int net_rpc_join_newstyle(int argc, const char **argv)
                      "error opening lsa policy handle");
 
        CHECK_RPC_ERR(cli_lsa_query_info_policy(cli, mem_ctx, &lsa_pol,
-                                               5, domain, &domain_sid),
+                                               5, &domain, &domain_sid),
                      "error querying info policy");
 
        cli_lsa_close(cli, mem_ctx, &lsa_pol);
@@ -115,7 +186,7 @@ int net_rpc_join_newstyle(int argc, const char **argv)
        cli_nt_session_close(cli); /* Done with this pipe */
 
        /* Create domain user */
-       if (!cli_nt_session_open(cli, PIPE_SAMR)) {
+       if (!cli_nt_session_open(cli, PI_SAMR)) {
                DEBUG(0, ("Error connecting to SAM pipe\n"));
                goto done;
        }
@@ -128,15 +199,13 @@ int net_rpc_join_newstyle(int argc, const char **argv)
        
        CHECK_RPC_ERR(cli_samr_open_domain(cli, mem_ctx, &sam_pol,
                                           SEC_RIGHTS_MAXIMUM_ALLOWED,
-                                          &domain_sid, &domain_pol),
+                                          domain_sid, &domain_pol),
                      "could not open domain");
 
        /* Create domain user */
-       fstrcpy(acct_name, global_myname);
-       fstrcat(acct_name, "$");
-       strlower(acct_name);
-
-        acb_info = ((lp_server_role() == ROLE_DOMAIN_BDC) || lp_server_role() == ROLE_DOMAIN_PDC) ? ACB_SVRTRUST : ACB_WSTRUST;
+       acct_name = talloc_asprintf(mem_ctx, "%s$", global_myname()); 
+       strlower_m(acct_name);
+       const_acct_name = acct_name;
 
        result = cli_samr_create_dom_user(cli, mem_ctx, &domain_pol,
                                          acct_name, acb_info,
@@ -162,17 +231,16 @@ int net_rpc_join_newstyle(int argc, const char **argv)
        if (NT_STATUS_IS_OK(result))
                cli_samr_close(cli, mem_ctx, &user_pol);
 
-       names = (char *)&acct_name[0];
-
        CHECK_RPC_ERR_DEBUG(cli_samr_lookup_names(cli, mem_ctx,
                                                  &domain_pol, flags,
-                                                 1, &names, &num_rids,
+                                                 1, &const_acct_name, 
+                                                 &num_rids,
                                                  &user_rids, &name_types),
                            ("error looking up rid for user %s: %s\n",
                             acct_name, nt_errstr(result)));
 
        if (name_types[0] != SID_NAME_USER) {
-               DEBUG(0, ("%s is not a user account\n", acct_name));
+               DEBUG(0, ("%s is not a user account (type=%d)\n", acct_name, name_types[0]));
                goto done;
        }
 
@@ -193,6 +261,7 @@ int net_rpc_join_newstyle(int argc, const char **argv)
                char *str;
                str = generate_random_str(DEFAULT_TRUST_ACCOUNT_PASSWORD_LENGTH);
                clear_trust_password = strdup(str);
+               E_md4hash(clear_trust_password, md4_trust_password);
        }
 
        ucs2_pw_len = push_ucs2(NULL, ucs2_trust_password, 
@@ -212,14 +281,8 @@ int net_rpc_join_newstyle(int argc, const char **argv)
        ctr.switch_value = 24;
        ctr.info.id24 = &p24;
 
-       /* I don't think this is quite the right place for this
-          calculation.  It should be moved somewhere where the credentials
-          are calculated. )-: */
-
-       mdfour(sess_key, cli->pwd.smb_nt_pwd, 16);
-
        CHECK_RPC_ERR(cli_samr_set_userinfo(cli, mem_ctx, &user_pol, 24, 
-                                           sess_key, &ctr),
+                                           &cli->user_session_key, &ctr),
                      "error setting trust account password");
 
        /* Why do we have to try to (re-)set the ACB to be the same as what
@@ -241,44 +304,52 @@ int net_rpc_join_newstyle(int argc, const char **argv)
           as a normal user with "Add workstation to domain" privilege. */
 
        result = cli_samr_set_userinfo2(cli, mem_ctx, &user_pol, 0x10, 
-                                       sess_key, &ctr);
+                                       &cli->user_session_key, &ctr);
 
-       /* Now store the secret in the secrets database */
-
-       strupper(domain);
+       /* Now check the whole process from top-to-bottom */
+       cli_samr_close(cli, mem_ctx, &user_pol);
+       cli_nt_session_close(cli); /* Done with this pipe */
 
-       if (!secrets_store_domain_sid(domain, &domain_sid)) {
-               DEBUG(0, ("error storing domain sid for %s\n", domain));
+       if (!cli_nt_session_open(cli, PI_NETLOGON)) {
+               DEBUG(0,("Error connecting to NETLOGON pipe\n"));
                goto done;
        }
 
-       if (!secrets_store_machine_password(clear_trust_password)) {
-               DEBUG(0, ("error storing plaintext domain secrets for %s\n", domain));
-       }
+       /* ensure that schannel uses the right domain */
+       fstrcpy(cli->domain, domain);
 
-       /* Now check the whole process from top-to-bottom */
+       result = cli_nt_establish_netlogon(cli, sec_channel_type, 
+                                          md4_trust_password);
 
-       cli_samr_close(cli, mem_ctx, &user_pol);
+       if (!NT_STATUS_IS_OK(result)) {
+               DEBUG(0, ("Error domain join verification (reused connection): %s\n\n",
+                         nt_errstr(result)));
 
-       cli_nt_session_close(cli); /* Done with this pipe */
+               if ( NT_STATUS_EQUAL(result, NT_STATUS_ACCESS_DENIED) &&
+                    (sec_channel_type == SEC_CHAN_BDC) ) {
+                       d_printf("Please make sure that no computer account\n"
+                                "named like this machine (%s) exists in the domain\n",
+                                global_myname());
+               }
 
-       if (!cli_nt_session_open(cli, PIPE_NETLOGON)) {
-               DEBUG(0, ("Error connecting to NETLOGON pipe\n"));
                goto done;
        }
 
-       if (!secrets_fetch_trust_account_password(domain, 
-                                                 stored_md4_trust_password, NULL)) {
-               DEBUG(0, ("Could not reterive secrets we just stored!"));
+       /* Now store the secret in the secrets database */
+
+       strupper_m(domain);
+
+       if (!secrets_store_domain_sid(domain, domain_sid)) {
+               DEBUG(0, ("error storing domain sid for %s\n", domain));
                goto done;
        }
-       
-       CHECK_RPC_ERR(new_cli_nt_setup_creds(cli, 
-                                            (acb_info & ACB_SVRTRUST) ? SEC_CHAN_BDC : SEC_CHAN_WKSTA, 
-                                            stored_md4_trust_password),
-                         "error in domain join verification");
-       
-       retval = 0;             /* Success! */
+
+       if (!secrets_store_machine_password(clear_trust_password, domain, sec_channel_type)) {
+               DEBUG(0, ("error storing plaintext domain secrets for %s\n", domain));
+       }
+
+       /* double-check, connection from scratch */
+       retval = net_rpc_join_ok(domain);
        
 done:
        /* Close down pipe - this will clean up open policy handles */
@@ -289,7 +360,6 @@ done:
        /* Display success or failure */
 
        if (retval != 0) {
-               trust_password_delete(domain);
                fprintf(stderr,"Unable to join domain %s.\n",domain);
        } else {
                printf("Joined domain %s.\n",domain);
@@ -301,3 +371,26 @@ done:
 
        return retval;
 }
+
+
+/**
+ * check that a join is OK
+ *
+ * @return A shell status integer (0 for success)
+ *
+ **/
+int net_rpc_testjoin(int argc, const char **argv) 
+{
+       char *domain = smb_xstrdup(opt_target_workgroup);
+
+       /* Display success or failure */
+       if (net_rpc_join_ok(domain) != 0) {
+               fprintf(stderr,"Join to domain '%s' is not valid\n",domain);
+               free(domain);
+               return -1;
+       }
+
+       printf("Join to '%s' is OK\n",domain);
+       free(domain);
+       return 0;
+}