s3-smbd: Pass ev_ctx to smbd_setup_sig_chld_handler().
[samba.git] / source3 / smbd / server.c
index 3f656ac541382a8d562d70d73251bf38d4dc9d4e..82459c277eaed8fa7f4513aea14d3894194152fe 100644 (file)
@@ -327,12 +327,12 @@ static void smbd_sig_chld_handler(struct tevent_context *ev,
        }
 }
 
-static void smbd_setup_sig_chld_handler(void)
+static void smbd_setup_sig_chld_handler(struct tevent_context *ev_ctx)
 {
        struct tevent_signal *se;
 
-       se = tevent_add_signal(server_event_context(),
-                              server_event_context(),
+       se = tevent_add_signal(ev_ctx,
+                              ev_ctx, /* mem_ctx */
                               SIGCHLD, 0,
                               smbd_sig_chld_handler,
                               NULL);
@@ -513,6 +513,8 @@ static void smbd_accept_connection(struct tevent_context *ev,
 }
 
 static bool smbd_open_one_socket(struct smbd_parent_context *parent,
+                                struct tevent_context *ev_ctx,
+                                struct messaging_context *msg_ctx,
                                 const struct sockaddr_storage *ifss,
                                 uint16_t port)
 {
@@ -555,7 +557,7 @@ static bool smbd_open_one_socket(struct smbd_parent_context *parent,
                return false;
        }
 
-       s->fde = tevent_add_fd(server_event_context(),
+       s->fde = tevent_add_fd(ev_ctx,
                               s,
                               s->fd, TEVENT_FD_READ,
                               smbd_accept_connection,
@@ -600,6 +602,7 @@ static bool smbd_parent_housekeeping(const struct timeval *now, void *private_da
 ****************************************************************************/
 
 static bool open_sockets_smbd(struct smbd_parent_context *parent,
+                             struct tevent_context *ev_ctx,
                              struct messaging_context *msg_ctx,
                              const char *smb_ports)
 {
@@ -613,7 +616,7 @@ static bool open_sockets_smbd(struct smbd_parent_context *parent,
 #endif
 
        /* Stop zombies */
-       smbd_setup_sig_chld_handler();
+       smbd_setup_sig_chld_handler(ev_ctx);
 
        /* use a reasonable default set of ports - listing on 445 and 139 */
        if (!smb_ports) {
@@ -662,7 +665,11 @@ static bool open_sockets_smbd(struct smbd_parent_context *parent,
                                        dns_port = port;
                                }
 
-                               if (!smbd_open_one_socket(parent, ifss, port)) {
+                               if (!smbd_open_one_socket(parent,
+                                                         ev_ctx,
+                                                         msg_ctx,
+                                                         ifss,
+                                                         port)) {
                                        return false;
                                }
                        }
@@ -709,7 +716,11 @@ static bool open_sockets_smbd(struct smbd_parent_context *parent,
                                        continue;
                                }
 
-                               if (!smbd_open_one_socket(parent, &ss, port)) {
+                               if (!smbd_open_one_socket(parent,
+                                                         ev_ctx,
+                                                         msg_ctx,
+                                                         &ss,
+                                                         port)) {
                                        return false;
                                }
                        }
@@ -736,7 +747,7 @@ static bool open_sockets_smbd(struct smbd_parent_context *parent,
                return false;
        }
 
-       if (!(event_add_idle(server_event_context(), NULL,
+       if (!(event_add_idle(ev_ctx, NULL,
                             timeval_set(SMBD_HOUSEKEEPING_INTERVAL, 0),
                             "parent_housekeeping", smbd_parent_housekeeping,
                             NULL))) {
@@ -750,12 +761,12 @@ static bool open_sockets_smbd(struct smbd_parent_context *parent,
        messaging_register(msg_ctx, NULL, MSG_SHUTDOWN, msg_exit_server);
        messaging_register(msg_ctx, NULL, MSG_SMB_FILE_RENAME,
                           msg_file_was_renamed);
-       messaging_register(msg_ctx, server_event_context(), MSG_SMB_CONF_UPDATED,
+       messaging_register(msg_ctx, ev_ctx, MSG_SMB_CONF_UPDATED,
                           smb_conf_updated);
        messaging_register(msg_ctx, NULL, MSG_SMB_STAT_CACHE_DELETE,
                           smb_stat_cache_delete);
        messaging_register(msg_ctx, NULL, MSG_DEBUG, smbd_msg_debug);
-       messaging_register(msg_ctx, server_event_context(), MSG_PRINTER_PCAP,
+       messaging_register(msg_ctx, ev_ctx, MSG_PRINTER_PCAP,
                           smb_pcap_updated);
        brl_register_msgs(msg_ctx);
 
@@ -774,14 +785,15 @@ static bool open_sockets_smbd(struct smbd_parent_context *parent,
 
        if (lp_multicast_dns_register() && (dns_port != 0)) {
 #ifdef WITH_DNSSD_SUPPORT
-               smbd_setup_mdns_registration(server_event_context(),
+               smbd_setup_mdns_registration(ev_ctx,
                                             parent, dns_port);
 #endif
 #ifdef WITH_AVAHI_SUPPORT
                void *avahi_conn;
 
-               avahi_conn = avahi_start_register(
-                       server_event_context(), server_event_context(), dns_port);
+               avahi_conn = avahi_start_register(ev_ctx,
+                                                 ev_ctx,
+                                                 dns_port);
                if (avahi_conn == NULL) {
                        DEBUG(10, ("avahi_start_register failed\n"));
                }
@@ -791,7 +803,8 @@ static bool open_sockets_smbd(struct smbd_parent_context *parent,
        return true;
 }
 
-static void smbd_parent_loop(struct smbd_parent_context *parent)
+static void smbd_parent_loop(struct tevent_context *ev_ctx,
+                            struct smbd_parent_context *parent)
 {
        /* now accept incoming connections - forking a new process
           for each incoming connection */
@@ -800,7 +813,7 @@ static void smbd_parent_loop(struct smbd_parent_context *parent)
                int ret;
                TALLOC_CTX *frame = talloc_stackframe();
 
-               ret = tevent_loop_once(server_event_context());
+               ret = tevent_loop_once(ev_ctx);
                if (ret != 0) {
                        exit_server_cleanly("tevent_loop_once() error");
                }
@@ -880,6 +893,8 @@ extern void build_options(bool screen);
        TALLOC_CTX *frame;
        NTSTATUS status;
        uint64_t unique_id;
+       struct tevent_context *ev_ctx;
+       struct messaging_context *msg_ctx;
 
        /*
         * Do this before any other talloc operation
@@ -889,9 +904,6 @@ extern void build_options(bool screen);
 
        load_case_tables();
 
-       /* Initialize the event context, it will panic on error */
-       server_event_context();
-
        smbd_init_globals();
 
        TimeInit();
@@ -1029,8 +1041,25 @@ extern void build_options(bool screen);
        /* Init the security context and global current_user */
        init_sec_ctx();
 
-       if (smbd_messaging_context() == NULL)
+       /*
+        * Initialize the event context. The event context needs to be
+        * initialized before the messaging context, cause the messaging
+        * context holds an event context.
+        * FIXME: This should be s3_tevent_context_init()
+        */
+       ev_ctx = server_event_context();
+       if (ev_ctx == NULL) {
                exit(1);
+       }
+
+       /*
+        * Init the messaging context
+        * FIXME: This should only call messaging_init()
+        */
+       msg_ctx = server_messaging_context();
+       if (msg_ctx == NULL) {
+               exit(1);
+       }
 
        /*
         * Reloading of the printers will not work here as we don't have a
@@ -1047,7 +1076,7 @@ extern void build_options(bool screen);
        init_structs();
 
 #ifdef WITH_PROFILE
-       if (!profile_setup(smbd_messaging_context(), False)) {
+       if (!profile_setup(msg_ctx, False)) {
                DEBUG(0,("ERROR: failed to setup profiling\n"));
                return -1;
        }
@@ -1096,19 +1125,19 @@ extern void build_options(bool screen);
        if (is_daemon)
                pidfile_create("smbd");
 
-       status = reinit_after_fork(smbd_messaging_context(),
-                                  server_event_context(),
+       status = reinit_after_fork(msg_ctx,
+                                  ev_ctx,
                                   procid_self(), false);
        if (!NT_STATUS_IS_OK(status)) {
                DEBUG(0,("reinit_after_fork() failed\n"));
                exit(1);
        }
 
-       smbd_server_conn->msg_ctx = smbd_messaging_context();
+       smbd_server_conn->msg_ctx = msg_ctx;
 
        smbd_setup_sig_term_handler();
-       smbd_setup_sig_hup_handler(server_event_context(),
-                                  smbd_server_conn->msg_ctx);
+       smbd_setup_sig_hup_handler(ev_ctx,
+                                  msg_ctx);
 
        /* Setup all the TDB's - including CLEAR_IF_FIRST tdb's. */
 
@@ -1121,7 +1150,7 @@ extern void build_options(bool screen);
        /* Initialise the password backed before the global_sam_sid
           to ensure that we fetch from ldap before we make a domain sid up */
 
-       if(!initialize_password_db(False, server_event_context()))
+       if(!initialize_password_db(false, ev_ctx))
                exit(1);
 
        if (!secrets_init()) {
@@ -1151,15 +1180,15 @@ extern void build_options(bool screen);
        if (!locking_init())
                exit(1);
 
-       if (!messaging_tdb_parent_init(server_event_context())) {
+       if (!messaging_tdb_parent_init(ev_ctx)) {
                exit(1);
        }
 
-       if (!notify_internal_parent_init(server_event_context())) {
+       if (!notify_internal_parent_init(ev_ctx)) {
                exit(1);
        }
 
-       if (!serverid_parent_init(server_event_context())) {
+       if (!serverid_parent_init(ev_ctx)) {
                exit(1);
        }
 
@@ -1170,7 +1199,7 @@ extern void build_options(bool screen);
        if (!W_ERROR_IS_OK(registry_init_full()))
                exit(1);
 
-       if (!print_backend_init(smbd_messaging_context()))
+       if (!print_backend_init(msg_ctx))
                exit(1);
 
        /* Open the share_info.tdb here, so we don't have to open
@@ -1206,18 +1235,16 @@ extern void build_options(bool screen);
                                                   "rpc_server", "epmapper",
                                                   "none");
                if (strcasecmp_m(rpcsrv_type, "daemon") == 0) {
-                       start_epmd(server_event_context(),
-                                  smbd_server_conn->msg_ctx);
+                       start_epmd(ev_ctx, msg_ctx);
                }
        }
 
-       if (!dcesrv_ep_setup(server_event_context(), smbd_server_conn->msg_ctx)) {
+       if (!dcesrv_ep_setup(ev_ctx, msg_ctx)) {
                exit(1);
        }
 
        /* Publish nt printers, this requires a working winreg pipe */
-       pcap_cache_reload(server_event_context(), smbd_messaging_context(),
-                         &reload_printers);
+       pcap_cache_reload(ev_ctx, msg_ctx, &reload_printers);
 
        /* only start the background queue daemon if we are 
           running as a daemon -- bad things will happen if
@@ -1226,8 +1253,7 @@ extern void build_options(bool screen);
 
        if (is_daemon && !interactive
            && lp_parm_bool(-1, "smbd", "backgroundqueue", true)) {
-               start_background_queue(server_event_context(),
-                                      smbd_messaging_context());
+               start_background_queue(ev_ctx, msg_ctx);
        }
 
        if (is_daemon && !_lp_disable_spoolss()) {
@@ -1239,8 +1265,7 @@ extern void build_options(bool screen);
                                                   "rpc_server", "spoolss",
                                                   "embedded");
                if (strcasecmp_m(rpcsrv_type, "daemon") == 0) {
-                       start_spoolssd(server_event_context(),
-                                      smbd_messaging_context());
+                       start_spoolssd(ev_ctx, msg_ctx);
                }
        }
 
@@ -1261,7 +1286,7 @@ extern void build_options(bool screen);
 #endif
 
                /* Stop zombies */
-               smbd_setup_sig_chld_handler();
+               smbd_setup_sig_chld_handler(ev_ctx);
 
                smbd_process(smbd_server_conn);
 
@@ -1269,20 +1294,20 @@ extern void build_options(bool screen);
                return(0);
        }
 
-       parent = talloc_zero(server_event_context(), struct smbd_parent_context);
+       parent = talloc_zero(ev_ctx, struct smbd_parent_context);
        if (!parent) {
                exit_server("talloc(struct smbd_parent_context) failed");
        }
        parent->interactive = interactive;
 
-       if (!open_sockets_smbd(parent, smbd_messaging_context(), ports))
+       if (!open_sockets_smbd(parent, ev_ctx, msg_ctx, ports))
                exit_server("open_sockets_smbd() failed");
 
        TALLOC_FREE(frame);
        /* make sure we always have a valid stackframe */
        frame = talloc_stackframe();
 
-       smbd_parent_loop(parent);
+       smbd_parent_loop(ev_ctx, parent);
 
        exit_server_cleanly(NULL);
        TALLOC_FREE(frame);