s3-talloc Change TALLOC_ARRAY() to talloc_array()
[samba.git] / source3 / smbd / msdfs.c
index 8e83a6c17ec9bf7df58ed65026dfb81286a18d6f..1d296e342df6127cdddec5cccb00ed879a1891d7 100644 (file)
 
 #define DBGC_CLASS DBGC_MSDFS
 #include "includes.h"
-
-extern uint32 global_client_caps;
+#include "system/filesys.h"
+#include "smbd/smbd.h"
+#include "smbd/globals.h"
+#include "msdfs.h"
+#include "auth.h"
 
 /**********************************************************************
  Parse a DFS pathname of the form \hostname\service\reqpath
@@ -51,6 +54,7 @@ static NTSTATUS parse_dfs_path(connection_struct *conn,
                                struct dfs_path *pdp, /* MUST BE TALLOCED */
                                bool *ppath_contains_wcard)
 {
+       struct smbd_server_connection *sconn = smbd_server_conn;
        char *pathname_local;
        char *p,*temp;
        char *servicename;
@@ -78,7 +82,7 @@ static NTSTATUS parse_dfs_path(connection_struct *conn,
 
        sepchar = pdp->posix_path ? '/' : '\\';
 
-       if (*pathname != sepchar) {
+       if (!sconn->using_smb2 && (*pathname != sepchar)) {
                DEBUG(10,("parse_dfs_path: path %s doesn't start with %c\n",
                        pathname, sepchar ));
                /*
@@ -212,18 +216,20 @@ static NTSTATUS parse_dfs_path(connection_struct *conn,
 
 /********************************************************
  Fake up a connection struct for the VFS layer.
- Note this CHANGES CWD !!!! JRA.
+ Note: this performs a vfs connect and CHANGES CWD !!!! JRA.
 *********************************************************/
 
-static NTSTATUS create_conn_struct(TALLOC_CTX *ctx,
+NTSTATUS create_conn_struct(TALLOC_CTX *ctx,
                                connection_struct **pconn,
                                int snum,
                                const char *path,
+                               const struct auth_serversupplied_info *session_info,
                                char **poldcwd)
 {
        connection_struct *conn;
        char *connpath;
        char *oldcwd;
+       const char *vfs_user;
 
        conn = TALLOC_ZERO_P(ctx, connection_struct);
        if (conn == NULL) {
@@ -254,15 +260,40 @@ static NTSTATUS create_conn_struct(TALLOC_CTX *ctx,
 
        conn->params->service = snum;
 
+       conn->sconn = smbd_server_conn;
+       conn->sconn->num_tcons_open++;
+
+       if (session_info != NULL) {
+               conn->session_info = copy_serverinfo(conn, session_info);
+               if (conn->session_info == NULL) {
+                       DEBUG(0, ("copy_serverinfo failed\n"));
+                       TALLOC_FREE(conn);
+                       return NT_STATUS_NO_MEMORY;
+               }
+               vfs_user = conn->session_info->unix_name;
+       } else {
+               /* use current authenticated user in absence of session_info */
+               vfs_user = get_current_username();
+       }
+
        set_conn_connectpath(conn, connpath);
 
        if (!smbd_vfs_init(conn)) {
                NTSTATUS status = map_nt_error_from_unix(errno);
                DEBUG(0,("create_conn_struct: smbd_vfs_init failed.\n"));
-               conn_free_internal(conn);
+               conn_free(conn);
                return status;
        }
 
+       /* this must be the first filesystem operation that we do */
+       if (SMB_VFS_CONNECT(conn, lp_servicename(snum), vfs_user) < 0) {
+               DEBUG(0,("VFS connect failed!\n"));
+               conn_free(conn);
+               return NT_STATUS_UNSUCCESSFUL;
+       }
+
+       conn->fs_capabilities = SMB_VFS_FS_CAPABILITIES(conn, &conn->ts_res);
+
        /*
         * Windows seems to insist on doing trans2getdfsreferral() calls on
         * the IPC$ share as the anonymous user. If we try to chdir as that
@@ -273,7 +304,7 @@ static NTSTATUS create_conn_struct(TALLOC_CTX *ctx,
        if (oldcwd == NULL) {
                NTSTATUS status = map_nt_error_from_unix(errno);
                DEBUG(3, ("vfs_GetWd failed: %s\n", strerror(errno)));
-               conn_free_internal(conn);
+               conn_free(conn);
                return status;
        }
 
@@ -282,7 +313,7 @@ static NTSTATUS create_conn_struct(TALLOC_CTX *ctx,
                DEBUG(3,("create_conn_struct: Can't ChDir to new conn path %s. "
                        "Error was %s\n",
                        conn->connectpath, strerror(errno) ));
-               conn_free_internal(conn);
+               conn_free(conn);
                return status;
        }
 
@@ -333,7 +364,7 @@ static bool parse_msdfs_symlink(TALLOC_CTX *ctx,
                return False;
        }
 
-       alt_path = TALLOC_ARRAY(ctx, char *, MAX_REFERRAL_COUNT);
+       alt_path = talloc_array(ctx, char *, MAX_REFERRAL_COUNT);
        if (!alt_path) {
                return False;
        }
@@ -400,15 +431,19 @@ static bool is_msdfs_link_internal(TALLOC_CTX *ctx,
                        char **pp_link_target,
                        SMB_STRUCT_STAT *sbufp)
 {
-       SMB_STRUCT_STAT st;
        int referral_len = 0;
+#if defined(HAVE_BROKEN_READLINK)
+       char link_target_buf[PATH_MAX];
+#else
        char link_target_buf[7];
+#endif
        size_t bufsize = 0;
        char *link_target = NULL;
+       struct smb_filename smb_fname;
 
        if (pp_link_target) {
                bufsize = 1024;
-               link_target = TALLOC_ARRAY(ctx, char, bufsize);
+               link_target = talloc_array(ctx, char, bufsize);
                if (!link_target) {
                        return False;
                }
@@ -418,21 +453,22 @@ static bool is_msdfs_link_internal(TALLOC_CTX *ctx,
                link_target = link_target_buf;
        }
 
-       if (sbufp == NULL) {
-               sbufp = &st;
-       }
+       ZERO_STRUCT(smb_fname);
+       smb_fname.base_name = discard_const_p(char, path);
 
-       if (SMB_VFS_LSTAT(conn, path, sbufp) != 0) {
+       if (SMB_VFS_LSTAT(conn, &smb_fname) != 0) {
                DEBUG(5,("is_msdfs_link_read_target: %s does not exist.\n",
                        path));
                goto err;
        }
-
-       if (!S_ISLNK(sbufp->st_mode)) {
+       if (!S_ISLNK(smb_fname.st.st_ex_mode)) {
                DEBUG(5,("is_msdfs_link_read_target: %s is not a link.\n",
                                        path));
                goto err;
        }
+       if (sbufp != NULL) {
+               *sbufp = smb_fname.st;
+       }
 
        referral_len = SMB_VFS_READLINK(conn, path, link_target, bufsize - 1);
        if (referral_len == -1) {
@@ -500,9 +536,8 @@ static NTSTATUS dfs_path_lookup(TALLOC_CTX *ctx,
 {
        char *p = NULL;
        char *q = NULL;
-       SMB_STRUCT_STAT sbuf;
        NTSTATUS status;
-       char *localpath = NULL;
+       struct smb_filename *smb_fname = NULL;
        char *canon_dfspath = NULL; /* Canonicalized dfs path. (only '/'
                                  components). */
 
@@ -521,20 +556,32 @@ static NTSTATUS dfs_path_lookup(TALLOC_CTX *ctx,
         * think this is needed. JRA.
         */
 
-       status = unix_convert(ctx, conn, pdp->reqpath, search_flag, &localpath,
-                       NULL, &sbuf);
-       if (!NT_STATUS_IS_OK(status) && !NT_STATUS_EQUAL(status,
-                                       NT_STATUS_OBJECT_PATH_NOT_FOUND)) {
-               return status;
+       status = unix_convert(ctx, conn, pdp->reqpath, &smb_fname,
+                             search_flag ? UCF_ALWAYS_ALLOW_WCARD_LCOMP : 0);
+
+       if (!NT_STATUS_IS_OK(status)) {
+               if (!NT_STATUS_EQUAL(status,
+                                    NT_STATUS_OBJECT_PATH_NOT_FOUND)) {
+                       return status;
+               }
+
+               /* Create an smb_fname to use below. */
+               status = create_synthetic_smb_fname(ctx, pdp->reqpath, NULL,
+                                                   NULL, &smb_fname);
+               if (!NT_STATUS_IS_OK(status)) {
+                       return status;
+               }
        }
 
        /* Optimization - check if we can redirect the whole path. */
 
-       if (is_msdfs_link_internal(ctx, conn, localpath, pp_targetpath, NULL)) {
+       if (is_msdfs_link_internal(ctx, conn, smb_fname->base_name,
+                                  pp_targetpath, NULL)) {
                if (search_flag) {
                        DEBUG(6,("dfs_path_lookup (FindFirst) No redirection "
                                 "for dfs link %s.\n", dfspath));
-                       return NT_STATUS_OK;
+                       status = NT_STATUS_OK;
+                       goto out;
                }
 
                DEBUG(6,("dfs_path_lookup: %s resolves to a "
@@ -544,7 +591,8 @@ static NTSTATUS dfs_path_lookup(TALLOC_CTX *ctx,
                if (consumedcntp) {
                        *consumedcntp = strlen(dfspath);
                }
-               return NT_STATUS_PATH_NOT_COVERED;
+               status = NT_STATUS_PATH_NOT_COVERED;
+               goto out;
        }
 
        /* Prepare to test only for '/' components in the given path,
@@ -553,7 +601,8 @@ static NTSTATUS dfs_path_lookup(TALLOC_CTX *ctx,
 
        canon_dfspath = talloc_strdup(ctx, dfspath);
        if (!canon_dfspath) {
-               return NT_STATUS_NO_MEMORY;
+               status = NT_STATUS_NO_MEMORY;
+               goto out;
        }
        if (!pdp->posix_path) {
                string_replace(canon_dfspath, '\\', '/');
@@ -575,7 +624,7 @@ static NTSTATUS dfs_path_lookup(TALLOC_CTX *ctx,
         * DFS path. If we hit a DFS link then we're done.
         */
 
-       p = strrchr_m(localpath, '/');
+       p = strrchr_m(smb_fname->base_name, '/');
        if (consumedcntp) {
                q = strrchr_m(canon_dfspath, '/');
        }
@@ -587,9 +636,11 @@ static NTSTATUS dfs_path_lookup(TALLOC_CTX *ctx,
                }
 
                if (is_msdfs_link_internal(ctx, conn,
-                                       localpath, pp_targetpath, NULL)) {
+                                          smb_fname->base_name, pp_targetpath,
+                                          NULL)) {
                        DEBUG(4, ("dfs_path_lookup: Redirecting %s because "
-                               "parent %s is dfs link\n", dfspath, localpath));
+                                 "parent %s is dfs link\n", dfspath,
+                                 smb_fname_str_dbg(smb_fname)));
 
                        if (consumedcntp) {
                                *consumedcntp = strlen(canon_dfspath);
@@ -599,11 +650,12 @@ static NTSTATUS dfs_path_lookup(TALLOC_CTX *ctx,
                                        *consumedcntp));
                        }
 
-                       return NT_STATUS_PATH_NOT_COVERED;
+                       status = NT_STATUS_PATH_NOT_COVERED;
+                       goto out;
                }
 
                /* Step back on the filesystem. */
-               p = strrchr_m(localpath, '/');
+               p = strrchr_m(smb_fname->base_name, '/');
 
                if (consumedcntp) {
                        /* And in the canonicalized dfs path. */
@@ -611,7 +663,10 @@ static NTSTATUS dfs_path_lookup(TALLOC_CTX *ctx,
                }
        }
 
-       return NT_STATUS_OK;
+       status = NT_STATUS_OK;
+ out:
+       TALLOC_FREE(smb_fname);
+       return status;
 }
 
 /*****************************************************************
@@ -687,7 +742,7 @@ static NTSTATUS dfs_redirect(TALLOC_CTX *ctx,
        if (!( strequal(pdp->servicename, lp_servicename(SNUM(conn)))
                        || (strequal(pdp->servicename, HOMES_NAME)
                        && strequal(lp_servicename(SNUM(conn)),
-                               conn->server_info->sanitized_username) )) ) {
+                               conn->session_info->sanitized_username) )) ) {
 
                /* The given sharename doesn't match this connection. */
                TALLOC_FREE(pdp);
@@ -794,11 +849,13 @@ NTSTATUS get_referred_path(TALLOC_CTX *ctx,
        /* Verify the share is a dfs root */
        snum = lp_servicenumber(jucn->service_name);
        if(snum < 0) {
-               fstring service_name;
-               fstrcpy(service_name, jucn->service_name);
-               if ((snum = find_service(service_name)) < 0) {
+               char *service_name = NULL;
+               if ((snum = find_service(ctx, jucn->service_name, &service_name)) < 0) {
                        return NT_STATUS_NOT_FOUND;
                }
+               if (!service_name) {
+                       return NT_STATUS_NO_MEMORY;
+               }
                TALLOC_FREE(jucn->service_name);
                jucn->service_name = talloc_strdup(ctx, service_name);
                if (!jucn->service_name) {
@@ -881,7 +938,7 @@ NTSTATUS get_referred_path(TALLOC_CTX *ctx,
        }
 
        status = create_conn_struct(ctx, &conn, snum, lp_pathname(snum),
-                                   &oldpath);
+                                   NULL, &oldpath);
        if (!NT_STATUS_IS_OK(status)) {
                TALLOC_FREE(pdp);
                return status;
@@ -896,10 +953,7 @@ NTSTATUS get_referred_path(TALLOC_CTX *ctx,
        if (!NT_STATUS_EQUAL(status, NT_STATUS_PATH_NOT_COVERED)) {
                DEBUG(3,("get_referred_path: No valid referrals for path %s\n",
                        dfs_path));
-               vfs_ChDir(conn, oldpath);
-               conn_free_internal(conn);
-               TALLOC_FREE(pdp);
-               return status;
+               goto err_exit;
        }
 
        /* We know this is a valid dfs link. Parse the targetpath. */
@@ -908,22 +962,22 @@ NTSTATUS get_referred_path(TALLOC_CTX *ctx,
                                &jucn->referral_count)) {
                DEBUG(3,("get_referred_path: failed to parse symlink "
                        "target %s\n", targetpath ));
-               vfs_ChDir(conn, oldpath);
-               conn_free_internal(conn);
-               TALLOC_FREE(pdp);
-               return NT_STATUS_NOT_FOUND;
+               status = NT_STATUS_NOT_FOUND;
+               goto err_exit;
        }
 
+       status = NT_STATUS_OK;
+ err_exit:
        vfs_ChDir(conn, oldpath);
-       conn_free_internal(conn);
+       SMB_VFS_DISCONNECT(conn);
+       conn_free(conn);
        TALLOC_FREE(pdp);
-       return NT_STATUS_OK;
+       return status;
 }
 
 static int setup_ver2_dfs_referral(const char *pathname,
                                char **ppdata,
                                struct junction_map *junction,
-                               int consumedcnt,
                                bool self_referral)
 {
        char* pdata = *ppdata;
@@ -988,7 +1042,8 @@ static int setup_ver2_dfs_referral(const char *pathname,
        memcpy(pdata+uni_reqpathoffset2,uni_requestedpath,requestedpathlen);
 
        /* create the header */
-       SSVAL(pdata,0,consumedcnt * 2); /* path consumed */
+       SSVAL(pdata,0,requestedpathlen - 2); /* UCS2 of path consumed minus
+                                               2 byte null */
        /* number of referral in this pkt */
        SSVAL(pdata,2,junction->referral_count);
        if(self_referral) {
@@ -1037,7 +1092,6 @@ static int setup_ver2_dfs_referral(const char *pathname,
 static int setup_ver3_dfs_referral(const char *pathname,
                                char **ppdata,
                                struct junction_map *junction,
-                               int consumedcnt,
                                bool self_referral)
 {
        char *pdata = *ppdata;
@@ -1084,7 +1138,8 @@ static int setup_ver3_dfs_referral(const char *pathname,
        *ppdata = pdata;
 
        /* create the header */
-       SSVAL(pdata,0,consumedcnt * 2); /* path consumed */
+       SSVAL(pdata,0,reqpathlen - 2); /* UCS2 of path consumed minus
+                                         2 byte null */
        SSVAL(pdata,2,junction->referral_count); /* number of referral */
        if(self_referral) {
                SIVAL(pdata,4,DFSREF_REFERRAL_SERVER | DFSREF_STORAGE_SERVER);
@@ -1224,11 +1279,11 @@ int setup_dfs_referral(connection_struct *orig_conn,
        case 2:
                reply_size = setup_ver2_dfs_referral(pathnamep,
                                        ppdata, junction,
-                                       consumedcnt, self_referral);
+                                       self_referral);
                break;
        case 3:
                reply_size = setup_ver3_dfs_referral(pathnamep, ppdata,
-                                       junction, consumedcnt, self_referral);
+                                       junction, self_referral);
                break;
        default:
                DEBUG(0,("setup_dfs_referral: Invalid dfs referral "
@@ -1321,7 +1376,7 @@ static bool junction_to_local_path(const struct junction_map *jucn,
                return False;
        }
        status = create_conn_struct(talloc_tos(), conn_out, snum,
-                                   lp_pathname(snum), oldpath);
+                                   lp_pathname(snum), NULL, oldpath);
        if (!NT_STATUS_IS_OK(status)) {
                return False;
        }
@@ -1332,7 +1387,8 @@ static bool junction_to_local_path(const struct junction_map *jucn,
                        jucn->volume_name);
        if (!*pp_path_out) {
                vfs_ChDir(*conn_out, *oldpath);
-               conn_free_internal(*conn_out);
+               SMB_VFS_DISCONNECT(*conn_out);
+               conn_free(*conn_out);
                return False;
        }
        return True;
@@ -1391,9 +1447,22 @@ bool create_msdfs_link(const struct junction_map *jucn)
 
        if(SMB_VFS_SYMLINK(conn, msdfs_link, path) < 0) {
                if (errno == EEXIST) {
-                       if(SMB_VFS_UNLINK(conn,path)!=0) {
+                       struct smb_filename *smb_fname = NULL;
+                       NTSTATUS status;
+
+                       status = create_synthetic_smb_fname(talloc_tos(), path,
+                                                           NULL, NULL,
+                                                           &smb_fname);
+                       if (!NT_STATUS_IS_OK(status)) {
+                               errno = map_errno_from_nt_status(status);
                                goto out;
                        }
+
+                       if(SMB_VFS_UNLINK(conn, smb_fname)!=0) {
+                               TALLOC_FREE(smb_fname);
+                               goto out;
+                       }
+                       TALLOC_FREE(smb_fname);
                }
                if (SMB_VFS_SYMLINK(conn, msdfs_link, path) < 0) {
                        DEBUG(1,("create_msdfs_link: symlink failed "
@@ -1407,7 +1476,8 @@ bool create_msdfs_link(const struct junction_map *jucn)
 
 out:
        vfs_ChDir(conn, cwd);
-       conn_free_internal(conn);
+       SMB_VFS_DISCONNECT(conn);
+       conn_free(conn);
        return ret;
 }
 
@@ -1417,17 +1487,29 @@ bool remove_msdfs_link(const struct junction_map *jucn)
        char *cwd;
        connection_struct *conn;
        bool ret = False;
+       struct smb_filename *smb_fname = NULL;
+       NTSTATUS status;
 
        if (!junction_to_local_path(jucn, &path, &conn, &cwd)) {
                return false;
        }
 
-       if( SMB_VFS_UNLINK(conn, path) == 0 ) {
+       status = create_synthetic_smb_fname(talloc_tos(), path,
+                                           NULL, NULL,
+                                           &smb_fname);
+       if (!NT_STATUS_IS_OK(status)) {
+               errno = map_errno_from_nt_status(status);
+               return false;
+       }
+
+       if( SMB_VFS_UNLINK(conn, smb_fname) == 0 ) {
                ret = True;
        }
 
+       TALLOC_FREE(smb_fname);
        vfs_ChDir(conn, cwd);
-       conn_free_internal(conn);
+       SMB_VFS_DISCONNECT(conn);
+       conn_free(conn);
        return ret;
 }
 
@@ -1439,7 +1521,8 @@ static int count_dfs_links(TALLOC_CTX *ctx, int snum)
 {
        size_t cnt = 0;
        SMB_STRUCT_DIR *dirp = NULL;
-       char *dname = NULL;
+       const char *dname = NULL;
+       char *talloced = NULL;
        const char *connect_path = lp_pathname(snum);
        const char *msdfs_proxy = lp_msdfs_proxy(snum);
        connection_struct *conn;
@@ -1455,7 +1538,7 @@ static int count_dfs_links(TALLOC_CTX *ctx, int snum)
         */
 
        status = create_conn_struct(talloc_tos(), &conn, snum, connect_path,
-                                   &cwd);
+                                   NULL, &cwd);
        if (!NT_STATUS_IS_OK(status)) {
                DEBUG(3, ("create_conn_struct failed: %s\n",
                          nt_errstr(status)));
@@ -1476,19 +1559,22 @@ static int count_dfs_links(TALLOC_CTX *ctx, int snum)
                goto out;
        }
 
-       while ((dname = vfs_readdirname(conn, dirp)) != NULL) {
+       while ((dname = vfs_readdirname(conn, dirp, NULL, &talloced))
+              != NULL) {
                if (is_msdfs_link(conn,
                                dname,
                                NULL)) {
                        cnt++;
                }
+               TALLOC_FREE(talloced);
        }
 
        SMB_VFS_CLOSEDIR(conn,dirp);
 
 out:
        vfs_ChDir(conn, cwd);
-       conn_free_internal(conn);
+       SMB_VFS_DISCONNECT(conn);
+       conn_free(conn);
        return cnt;
 }
 
@@ -1502,7 +1588,8 @@ static int form_junctions(TALLOC_CTX *ctx,
 {
        size_t cnt = 0;
        SMB_STRUCT_DIR *dirp = NULL;
-       char *dname = NULL;
+       const char *dname = NULL;
+       char *talloced = NULL;
        const char *connect_path = lp_pathname(snum);
        char *service_name = lp_servicename(snum);
        const char *msdfs_proxy = lp_msdfs_proxy(snum);
@@ -1523,7 +1610,8 @@ static int form_junctions(TALLOC_CTX *ctx,
         * Fake up a connection struct for the VFS layer.
         */
 
-       status = create_conn_struct(ctx, &conn, snum, connect_path, &cwd);
+       status = create_conn_struct(ctx, &conn, snum, connect_path, NULL,
+                                   &cwd);
        if (!NT_STATUS_IS_OK(status)) {
                DEBUG(3, ("create_conn_struct failed: %s\n",
                          nt_errstr(status)));
@@ -1575,11 +1663,13 @@ static int form_junctions(TALLOC_CTX *ctx,
                goto out;
        }
 
-       while ((dname = vfs_readdirname(conn, dirp)) != NULL) {
+       while ((dname = vfs_readdirname(conn, dirp, NULL, &talloced))
+              != NULL) {
                char *link_target = NULL;
                if (cnt >= jn_remain) {
                        DEBUG(2, ("form_junctions: ran out of MSDFS "
                                "junction slots"));
+                       TALLOC_FREE(talloced);
                        goto out;
                }
                if (is_msdfs_link_internal(ctx,
@@ -1597,6 +1687,7 @@ static int form_junctions(TALLOC_CTX *ctx,
                                                                dname);
                                if (!jucn[cnt].service_name ||
                                                !jucn[cnt].volume_name) {
+                                       TALLOC_FREE(talloced);
                                        goto out;
                                }
                                jucn[cnt].comment = "";
@@ -1604,6 +1695,7 @@ static int form_junctions(TALLOC_CTX *ctx,
                        }
                        TALLOC_FREE(link_target);
                }
+               TALLOC_FREE(talloced);
        }
 
 out:
@@ -1613,11 +1705,12 @@ out:
        }
 
        vfs_ChDir(conn, cwd);
-       conn_free_internal(conn);
+       conn_free(conn);
        return cnt;
 }
 
-struct junction_map *enum_msdfs_links(TALLOC_CTX *ctx, size_t *p_num_jn)
+struct junction_map *enum_msdfs_links(struct smbd_server_connection *sconn,
+                                     TALLOC_CTX *ctx, size_t *p_num_jn)
 {
        struct junction_map *jn = NULL;
        int i=0;
@@ -1632,7 +1725,7 @@ struct junction_map *enum_msdfs_links(TALLOC_CTX *ctx, size_t *p_num_jn)
        /* Ensure all the usershares are loaded. */
        become_root();
        load_registry_shares();
-       sharecount = load_usershare_shares();
+       sharecount = load_usershare_shares(sconn);
        unbecome_root();
 
        for(i=0;i < sharecount;i++) {
@@ -1643,7 +1736,7 @@ struct junction_map *enum_msdfs_links(TALLOC_CTX *ctx, size_t *p_num_jn)
        if (jn_count == 0) {
                return NULL;
        }
-       jn = TALLOC_ARRAY(ctx,  struct junction_map, jn_count);
+       jn = talloc_array(ctx,  struct junction_map, jn_count);
        if (!jn) {
                return NULL;
        }
@@ -1661,64 +1754,40 @@ struct junction_map *enum_msdfs_links(TALLOC_CTX *ctx, size_t *p_num_jn)
 }
 
 /******************************************************************************
- Core function to resolve a dfs pathname.
-******************************************************************************/
-
-NTSTATUS resolve_dfspath(TALLOC_CTX *ctx,
-                       connection_struct *conn,
-                       bool dfs_pathnames,
-                       const char *name_in,
-                       char **pp_name_out)
-{
-       NTSTATUS status = NT_STATUS_OK;
-       bool dummy;
-       if (dfs_pathnames) {
-               status = dfs_redirect(ctx,
-                                       conn,
-                                       name_in,
-                                       False,
-                                       pp_name_out,
-                                       &dummy);
-       } else {
-               /*
-                * Cheat and just return a copy of the in ptr.
-                * Once srvstr_get_path() uses talloc it'll
-                * be a talloced ptr anyway.
-                */
-               *pp_name_out = CONST_DISCARD(char *,name_in);
-       }
-       return status;
-}
-
-/******************************************************************************
- Core function to resolve a dfs pathname possibly containing a wildcard.
- This function is identical to the above except for the bool param to
- dfs_redirect but I need this to be separate so it's really clear when
- we're allowing wildcards and when we're not. JRA.
+ Core function to resolve a dfs pathname possibly containing a wildcard.  If
+ ppath_contains_wcard != NULL, it will be set to true if a wildcard is
+ detected during dfs resolution.
 ******************************************************************************/
 
 NTSTATUS resolve_dfspath_wcard(TALLOC_CTX *ctx,
                                connection_struct *conn,
                                bool dfs_pathnames,
                                const char *name_in,
+                               bool allow_wcards,
                                char **pp_name_out,
                                bool *ppath_contains_wcard)
 {
+       bool path_contains_wcard;
        NTSTATUS status = NT_STATUS_OK;
+
        if (dfs_pathnames) {
                status = dfs_redirect(ctx,
                                        conn,
                                        name_in,
-                                       True,
+                                       allow_wcards,
                                        pp_name_out,
-                                       ppath_contains_wcard);
+                                       &path_contains_wcard);
+
+               if (NT_STATUS_IS_OK(status) && ppath_contains_wcard != NULL) {
+                       *ppath_contains_wcard = path_contains_wcard;
+               }
        } else {
                /*
                 * Cheat and just return a copy of the in ptr.
                 * Once srvstr_get_path() uses talloc it'll
                 * be a talloced ptr anyway.
                 */
-               *pp_name_out = CONST_DISCARD(char *,name_in);
+               *pp_name_out = discard_const_p(char, name_in);
        }
        return status;
 }