-/*
+/*
Unix SMB/Netbios implementation.
Version 1.9.
read/write to a files_struct
Copyright (C) Andrew Tridgell 1992-1998
Copyright (C) Jeremy Allison 2000-2002. - write cache.
-
+
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 3 of the License, or
(at your option) any later version.
-
+
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
-
+
You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>.
*/
#include "includes.h"
+#include "printing.h"
+#include "smbd/smbd.h"
#include "smbd/globals.h"
+#include "smbprofile.h"
+
+struct write_cache {
+ off_t file_size;
+ off_t offset;
+ size_t alloc_size;
+ size_t data_size;
+ char *data;
+};
-static bool setup_write_cache(files_struct *, SMB_OFF_T);
+static bool setup_write_cache(files_struct *, off_t);
/****************************************************************************
Read from write cache if we can.
****************************************************************************/
-static bool read_from_write_cache(files_struct *fsp,char *data,SMB_OFF_T pos,size_t n)
+static bool read_from_write_cache(files_struct *fsp,char *data,off_t pos,size_t n)
{
- write_cache *wcp = fsp->wcp;
+ struct write_cache *wcp = fsp->wcp;
if(!wcp) {
return False;
memcpy(data, wcp->data + (pos - wcp->offset), n);
- DO_PROFILE_INC(writecache_read_hits);
+ DO_PROFILE_INC(writecache_cached_reads);
return True;
}
Read from a file.
****************************************************************************/
-ssize_t read_file(files_struct *fsp,char *data,SMB_OFF_T pos,size_t n)
+ssize_t read_file(files_struct *fsp,char *data,off_t pos,size_t n)
{
- ssize_t ret=0,readret;
+ ssize_t ret = 0;
/* you can't read from print files */
if (fsp->print_file) {
return n;
}
- flush_write_cache(fsp, READ_FLUSH);
+ flush_write_cache(fsp, SAMBA_READ_FLUSH);
fsp->fh->pos = pos;
if (n > 0) {
-#ifdef DMF_FIX
- int numretries = 3;
-tryagain:
- readret = SMB_VFS_PREAD(fsp,data,n,pos);
-
- if (readret == -1) {
- if ((errno == EAGAIN) && numretries) {
- DEBUG(3,("read_file EAGAIN retry in 10 seconds\n"));
- (void)sleep(10);
- --numretries;
- goto tryagain;
- }
- return -1;
- }
-#else /* NO DMF fix. */
- readret = SMB_VFS_PREAD(fsp,data,n,pos);
+ ret = SMB_VFS_PREAD(fsp,data,n,pos);
- if (readret == -1) {
+ if (ret == -1) {
return -1;
}
-#endif
- if (readret > 0) {
- ret += readret;
- }
}
DEBUG(10,("read_file (%s): pos = %.0f, size = %lu, returned %lu\n",
static ssize_t real_write_file(struct smb_request *req,
files_struct *fsp,
const char *data,
- SMB_OFF_T pos,
+ off_t pos,
size_t n)
{
ssize_t ret;
ret = vfs_write_data(req, fsp, data, n);
} else {
fsp->fh->pos = pos;
- if (pos && lp_strict_allocate(SNUM(fsp->conn))) {
+ if (pos && lp_strict_allocate(SNUM(fsp->conn) &&
+ !fsp->is_sparse)) {
if (vfs_fill_sparse(fsp, pos) == -1) {
return -1;
}
static int wcp_file_size_change(files_struct *fsp)
{
int ret;
- write_cache *wcp = fsp->wcp;
+ struct write_cache *wcp = fsp->wcp;
wcp->file_size = wcp->offset + wcp->data_size;
ret = SMB_VFS_FTRUNCATE(fsp, wcp->file_size);
return ret;
}
-void update_write_time_handler(struct event_context *ctx,
- struct timed_event *te,
+void update_write_time_handler(struct tevent_context *ctx,
+ struct tevent_timer *te,
struct timeval now,
void *private_data)
{
{
int delay;
- if (fsp->posix_open) {
+ if (fsp->posix_flags & FSP_POSIX_FLAGS_OPEN) {
/* Don't use delayed writes on POSIX files. */
return;
}
/* trigger the update 2 seconds later */
fsp->update_write_time_event =
- event_add_timed(smbd_event_context(), NULL,
- timeval_current_ofs(0, delay),
- update_write_time_handler, fsp);
+ tevent_add_timer(fsp->conn->sconn->ev_ctx, NULL,
+ timeval_current_ofs_usec(delay),
+ update_write_time_handler, fsp);
}
void trigger_write_time_update_immediate(struct files_struct *fsp)
{
struct smb_file_time ft;
- if (fsp->posix_open) {
+ if (fsp->posix_flags & FSP_POSIX_FLAGS_OPEN) {
/* Don't use delayed writes on POSIX files. */
return;
}
(void)smb_set_file_time(fsp->conn, fsp, fsp->fsp_name, &ft, false);
}
+void mark_file_modified(files_struct *fsp)
+{
+ int dosmode;
+
+ if (fsp->modified) {
+ return;
+ }
+
+ fsp->modified = true;
+
+ if (SMB_VFS_FSTAT(fsp, &fsp->fsp_name->st) != 0) {
+ return;
+ }
+ trigger_write_time_update(fsp);
+
+ if (fsp->posix_flags & FSP_POSIX_FLAGS_OPEN) {
+ return;
+ }
+ if (!(lp_store_dos_attributes(SNUM(fsp->conn)) ||
+ MAP_ARCHIVE(fsp->conn))) {
+ return;
+ }
+
+ dosmode = dos_mode(fsp->conn, fsp->fsp_name);
+ if (IS_DOS_ARCHIVE(dosmode)) {
+ return;
+ }
+ file_set_dosmode(fsp->conn, fsp->fsp_name,
+ dosmode | FILE_ATTRIBUTE_ARCHIVE, NULL, false);
+}
+
/****************************************************************************
Write to a file.
****************************************************************************/
ssize_t write_file(struct smb_request *req,
files_struct *fsp,
const char *data,
- SMB_OFF_T pos,
+ off_t pos,
size_t n)
{
- write_cache *wcp = fsp->wcp;
+ struct write_cache *wcp = fsp->wcp;
ssize_t total_written = 0;
int write_path = -1;
if (fsp->print_file) {
- uint32 jobid;
+ uint32_t t;
+ int ret;
- if (!rap_to_pjobid(fsp->rap_print_jobid, NULL, &jobid)) {
- DEBUG(3,("write_file: Unable to map RAP jobid %u to jobid.\n",
- (unsigned int)fsp->rap_print_jobid ));
- errno = EBADF;
+ ret = print_spool_write(fsp, data, n, pos, &t);
+ if (ret) {
+ errno = ret;
return -1;
}
-
- return print_job_write(SNUM(fsp->conn), jobid, data, pos, n);
+ return t;
}
if (!fsp->can_write) {
return -1;
}
- if (!fsp->modified) {
- fsp->modified = True;
-
- if (SMB_VFS_FSTAT(fsp, &fsp->fsp_name->st) == 0) {
- int dosmode;
- trigger_write_time_update(fsp);
- dosmode = dos_mode(fsp->conn, fsp->fsp_name);
- if ((lp_store_dos_attributes(SNUM(fsp->conn)) ||
- MAP_ARCHIVE(fsp->conn)) &&
- !IS_DOS_ARCHIVE(dosmode)) {
- file_set_dosmode(fsp->conn, fsp->fsp_name,
- dosmode | aARCH, NULL, false);
- }
-
- /*
- * If this is the first write and we have an exclusive oplock then setup
- * the write cache.
- */
+ /*
+ * If this is the first write and we have an exclusive oplock
+ * then setup the write cache.
+ */
- if (EXCLUSIVE_OPLOCK_TYPE(fsp->oplock_type) && !wcp) {
- setup_write_cache(fsp,
- fsp->fsp_name->st.st_ex_size);
- wcp = fsp->wcp;
- }
- }
+ if (!fsp->modified &&
+ EXCLUSIVE_OPLOCK_TYPE(fsp->oplock_type) &&
+ (wcp == NULL)) {
+ /*
+ * Note: no write cache with leases!
+ * as the handles would have to share the write cache
+ * that's possible but an improvement for another day...
+ */
+ setup_write_cache(fsp, fsp->fsp_name->st.st_ex_size);
+ wcp = fsp->wcp;
}
-#ifdef WITH_PROFILE
+ mark_file_modified(fsp);
+
DO_PROFILE_INC(writecache_total_writes);
if (!fsp->oplock_type) {
DO_PROFILE_INC(writecache_non_oplock_writes);
}
-#endif
/*
* If this file is level II oplocked then we need
contend_level2_oplocks_begin(fsp, LEVEL2_CONTEND_WRITE);
contend_level2_oplocks_end(fsp, LEVEL2_CONTEND_WRITE);
-#ifdef WITH_PROFILE
- if (profile_p && profile_p->writecache_total_writes % 500 == 0) {
- DEBUG(3,("WRITECACHE: initwrites=%u abutted=%u total=%u \
-nonop=%u allocated=%u active=%u direct=%u perfect=%u readhits=%u\n",
- profile_p->writecache_init_writes,
- profile_p->writecache_abutted_writes,
- profile_p->writecache_total_writes,
- profile_p->writecache_non_oplock_writes,
- profile_p->writecache_allocated_write_caches,
- profile_p->writecache_num_write_caches,
- profile_p->writecache_direct_writes,
- profile_p->writecache_num_perfect_writes,
- profile_p->writecache_read_hits ));
-
- DEBUG(3,("WRITECACHE: Flushes SEEK=%d, READ=%d, WRITE=%d, READRAW=%d, OPLOCK=%d, CLOSE=%d, SYNC=%d\n",
- profile_p->writecache_flushed_writes[SEEK_FLUSH],
- profile_p->writecache_flushed_writes[READ_FLUSH],
- profile_p->writecache_flushed_writes[WRITE_FLUSH],
- profile_p->writecache_flushed_writes[READRAW_FLUSH],
- profile_p->writecache_flushed_writes[OPLOCK_RELEASE_FLUSH],
- profile_p->writecache_flushed_writes[CLOSE_FLUSH],
- profile_p->writecache_flushed_writes[SYNC_FLUSH] ));
- }
-#endif
-
if (wcp && req->unread_bytes) {
/* If we're using receivefile don't
* deal with a write cache.
*/
- flush_write_cache(fsp, WRITE_FLUSH);
+ flush_write_cache(fsp, SAMBA_WRITE_FLUSH);
delete_write_cache(fsp);
wcp = NULL;
}
fsp->fh->pos = pos + n;
+ if ((n == 1) && (data[0] == '\0') && (pos > wcp->file_size)) {
+ int ret;
+
+ /*
+ * This is a 1-byte write of a 0 beyond the EOF and
+ * thus implicitly also beyond the current active
+ * write cache, the typical file-extending (and
+ * allocating, but we're using the write cache here)
+ * write done by Windows. We just have to ftruncate
+ * the file and rely on posix semantics to return
+ * zeros for non-written file data that is within the
+ * file length.
+ *
+ * We can not use wcp_file_size_change here because we
+ * might have an existing write cache, and
+ * wcp_file_size_change assumes a change to just the
+ * end of the current write cache.
+ */
+
+ wcp->file_size = pos + 1;
+ ret = SMB_VFS_FTRUNCATE(fsp, wcp->file_size);
+ if (ret == -1) {
+ DEBUG(0, ("wcp_file_size_change (%s): ftruncate of "
+ "size %.0f error %s\n", fsp_str_dbg(fsp),
+ (double)wcp->file_size, strerror(errno)));
+ return -1;
+ }
+ return 1;
+ }
+
+
/*
* If we have active cache and it isn't contiguous then we flush.
* NOTE: There is a small problem with running out of disk ....
if (wcp->data_size) {
bool cache_flush_needed = False;
- if ((pos >= wcp->offset) && (pos <= wcp->offset + wcp->data_size)) {
-
+ if ((pos >= wcp->offset) &&
+ (pos <= wcp->offset + wcp->data_size)) {
+
/* ASCII art.... JRA.
+--------------+-----
* Start of write overlaps or abutts the existing data.
*/
- size_t data_used = MIN((wcp->alloc_size - (pos - wcp->offset)), n);
+ size_t data_used;
- memcpy(wcp->data + (pos - wcp->offset), data, data_used);
+ data_used = MIN((wcp->alloc_size - (pos - wcp->offset)),
+ n);
+
+ memcpy(wcp->data + (pos - wcp->offset), data,
+ data_used);
/*
* Update the current buffer size with the new data.
write_path = 1;
- } else if ((pos < wcp->offset) && (pos + n > wcp->offset) &&
- (pos + n <= wcp->offset + wcp->alloc_size)) {
+ } else if ((pos < wcp->offset) &&
+ (pos + n > wcp->offset) &&
+ (pos + n <= wcp->offset + wcp->alloc_size)) {
/* ASCII art.... JRA.
write_path = 2;
- } else if ( (pos >= wcp->file_size) &&
- (wcp->offset + wcp->data_size == wcp->file_size) &&
- (pos > wcp->offset + wcp->data_size) &&
- (pos < wcp->offset + wcp->alloc_size) ) {
+ } else if ((pos >= wcp->file_size) &&
+ (wcp->offset + wcp->data_size == wcp->file_size) &&
+ (pos > wcp->offset + wcp->data_size) &&
+ (pos < wcp->offset + wcp->alloc_size) ) {
/* ASCII art.... JRA.
if(pos + n <= wcp->offset + wcp->alloc_size) {
data_used = n;
} else {
- data_used = wcp->offset + wcp->alloc_size - pos;
+ data_used = wcp->offset+wcp->alloc_size-pos;
}
/*
memset(wcp->data + wcp->data_size, '\0',
pos - (wcp->offset + wcp->data_size) );
- memcpy(wcp->data + (pos - wcp->offset), data, data_used);
+ memcpy(wcp->data + (pos - wcp->offset), data,
+ data_used);
/*
* Update the current buffer size with the new data.
| 1 Byte |
+--------+
- MS-Office seems to do this a lot to determine if there's enough
- space on the filesystem to write a new file.
+ MS-Office seems to do this a lot to determine if
+ there's enough space on the filesystem to write a new
+ file.
Change to :
+-----------------------+--------+
*/
- flush_write_cache(fsp, WRITE_FLUSH);
+ flush_write_cache(fsp, SAMBA_WRITE_FLUSH);
wcp->offset = wcp->file_size;
wcp->data_size = pos - wcp->file_size + 1;
memset(wcp->data, '\0', wcp->data_size);
| Cached data | Cache buffer |
+---------------+---------------+
- +-------------------+
- | Data to write |
- +-------------------+
+ +---------------+
+ | Data to write |
+ +---------------+
Case 2).
*/
/*
- * Write is bigger than buffer, or there is no overlap on the
- * low or high ends.
+ * Write is bigger than buffer, or there is no
+ * overlap on the low or high ends.
*/
- DEBUG(9,("write_file: non cacheable write : fd = %d, pos = %.0f, len = %u, current cache pos = %.0f \
-len = %u\n",fsp->fh->fd, (double)pos, (unsigned int)n, (double)wcp->offset, (unsigned int)wcp->data_size ));
+ DEBUG(9,("write_file: non cacheable write : fd = %d, "
+ "pos = %.0f, len = %u, "
+ "current cache pos = %.0f len = %u\n",
+ fsp->fh->fd, (double)pos, (unsigned int)n,
+ (double)wcp->offset,
+ (unsigned int)wcp->data_size ));
/*
- * If write would fit in the cache, and is larger than
- * the data already in the cache, flush the cache and
- * preferentially copy the data new data into it. Otherwise
- * just write the data directly.
+ * If write would fit in the cache, and is
+ * larger than the data already in the cache,
+ * flush the cache and preferentially copy the
+ * data new data into it. Otherwise just write
+ * the data directly.
*/
if ( n <= wcp->alloc_size && n > wcp->data_size) {
cache_flush_needed = True;
} else {
- ssize_t ret = real_write_file(NULL,fsp, data, pos, n);
+ ssize_t ret = real_write_file(NULL, fsp, data,
+ pos, n);
/*
- * If the write overlaps the entire cache, then
- * discard the current contents of the cache.
- * Fix from Rasmus Borup Hansen rbh@math.ku.dk.
+ * If the write overlaps the entire
+ * cache, then discard the current
+ * contents of the cache. Fix from
+ * Rasmus Borup Hansen rbh@math.ku.dk.
*/
if ((pos <= wcp->offset) &&
- (pos + n >= wcp->offset + wcp->data_size) ) {
- DEBUG(9,("write_file: discarding overwritten write \
-cache: fd = %d, off=%.0f, size=%u\n", fsp->fh->fd, (double)wcp->offset, (unsigned int)wcp->data_size ));
+ (pos + n >= wcp->offset+wcp->data_size)) {
+ DEBUG(9,("write_file: discarding "
+ "overwritten write cache: "
+ "fd = %d, off=%.0f, "
+ "size=%u\n", fsp->fh->fd,
+ (double)wcp->offset,
+ (unsigned)wcp->data_size));
wcp->data_size = 0;
}
}
if (cache_flush_needed) {
- DEBUG(3,("WRITE_FLUSH:%d: due to noncontinuous write: fd = %d, size = %.0f, pos = %.0f, \
-n = %u, wcp->offset=%.0f, wcp->data_size=%u\n",
- write_path, fsp->fh->fd, (double)wcp->file_size, (double)pos, (unsigned int)n,
- (double)wcp->offset, (unsigned int)wcp->data_size ));
-
- flush_write_cache(fsp, WRITE_FLUSH);
+ DEBUG(3, ("SAMBA_WRITE_FLUSH:%d: due to noncontinuous "
+ "write: fd = %d, size = %.0f, pos = %.0f, "
+ "n = %u, wcp->offset=%.0f, "
+ "wcp->data_size=%u\n",
+ write_path, fsp->fh->fd,
+ (double)wcp->file_size, (double)pos,
+ (unsigned int)n, (double)wcp->offset,
+ (unsigned int)wcp->data_size ));
+
+ flush_write_cache(fsp, SAMBA_WRITE_FLUSH);
}
}
*/
if (n) {
-#ifdef WITH_PROFILE
+ DO_PROFILE_INC(writecache_cached_writes);
if (wcp->data_size) {
DO_PROFILE_INC(writecache_abutted_writes);
} else {
DO_PROFILE_INC(writecache_init_writes);
}
-#endif
+
+ if ((wcp->data_size == 0)
+ && (pos > wcp->file_size)
+ && (pos + n <= wcp->file_size + wcp->alloc_size)) {
+ /*
+ * This is a write completely beyond the
+ * current EOF, but within reach of the write
+ * cache. We expect fill-up writes pretty
+ * soon, so it does not make sense to start
+ * the write cache at the current
+ * offset. These fill-up writes would trigger
+ * separate pwrites or even unnecessary cache
+ * flushes because they overlap if this is a
+ * one-byte allocating write.
+ */
+ wcp->offset = wcp->file_size;
+ wcp->data_size = pos - wcp->file_size;
+ memset(wcp->data, 0, wcp->data_size);
+ }
+
memcpy(wcp->data+wcp->data_size, data, n);
if (wcp->data_size == 0) {
wcp->offset = pos;
- DO_PROFILE_INC(writecache_num_write_caches);
}
wcp->data_size += n;
return -1;
}
}
- DEBUG(9,("wcp->offset = %.0f wcp->data_size = %u cache return %u\n",
- (double)wcp->offset, (unsigned int)wcp->data_size, (unsigned int)n));
+ DEBUG(9, ("wcp->offset = %.0f wcp->data_size = %u cache "
+ "return %u\n",
+ (double)wcp->offset, (unsigned int)wcp->data_size,
+ (unsigned int)n));
total_written += n;
return total_written; /* .... that's a write :) */
}
-
+
return total_written;
}
void delete_write_cache(files_struct *fsp)
{
- write_cache *wcp;
+ struct write_cache *wcp;
if(!fsp) {
return;
return;
}
- DO_PROFILE_DEC(writecache_allocated_write_caches);
+ DO_PROFILE_INC(writecache_deallocations);
allocated_write_caches--;
SMB_ASSERT(wcp->data_size == 0);
Setup the write cache structure.
****************************************************************************/
-static bool setup_write_cache(files_struct *fsp, SMB_OFF_T file_size)
+static bool setup_write_cache(files_struct *fsp, off_t file_size)
{
ssize_t alloc_size = lp_write_cache_size(SNUM(fsp->conn));
- write_cache *wcp;
+ struct write_cache *wcp;
if (allocated_write_caches >= MAX_WRITE_CACHES) {
return False;
return False;
}
- if((wcp = SMB_MALLOC_P(write_cache)) == NULL) {
+ if((wcp = SMB_MALLOC_P(struct write_cache)) == NULL) {
DEBUG(0,("setup_write_cache: malloc fail.\n"));
return False;
}
memset(wcp->data, '\0', wcp->alloc_size );
fsp->wcp = wcp;
- DO_PROFILE_INC(writecache_allocated_write_caches);
+ DO_PROFILE_INC(writecache_allocations);
allocated_write_caches++;
DEBUG(10,("setup_write_cache: File %s allocated write cache size %lu\n",
Cope with a size change.
****************************************************************************/
-void set_filelen_write_cache(files_struct *fsp, SMB_OFF_T file_size)
+void set_filelen_write_cache(files_struct *fsp, off_t file_size)
{
if(fsp->wcp) {
/* The cache *must* have been flushed before we do this. */
ssize_t flush_write_cache(files_struct *fsp, enum flush_reason_enum reason)
{
- write_cache *wcp = fsp->wcp;
+ struct write_cache *wcp = fsp->wcp;
size_t data_size;
ssize_t ret;
data_size = wcp->data_size;
wcp->data_size = 0;
- DO_PROFILE_DEC_INC(writecache_num_write_caches,writecache_flushed_writes[reason]);
+ switch (reason) {
+ case SAMBA_SEEK_FLUSH:
+ DO_PROFILE_INC(writecache_flush_reason_seek);
+ break;
+ case SAMBA_READ_FLUSH:
+ DO_PROFILE_INC(writecache_flush_reason_read);
+ break;
+ case SAMBA_WRITE_FLUSH:
+ DO_PROFILE_INC(writecache_flush_reason_write);;
+ break;
+ case SAMBA_READRAW_FLUSH:
+ DO_PROFILE_INC(writecache_flush_reason_readraw);
+ break;
+ case SAMBA_OPLOCK_RELEASE_FLUSH:
+ DO_PROFILE_INC(writecache_flush_reason_oplock);
+ break;
+ case SAMBA_CLOSE_FLUSH:
+ DO_PROFILE_INC(writecache_flush_reason_close);
+ break;
+ case SAMBA_SYNC_FLUSH:
+ DO_PROFILE_INC(writecache_flush_reason_sync);
+ break;
+ case SAMBA_SIZECHANGE_FLUSH:
+ DO_PROFILE_INC(writecache_flush_reason_sizechange);
+ break;
+ default:
+ break;
+ }
DEBUG(9,("flushing write cache: fd = %d, off=%.0f, size=%u\n",
fsp->fh->fd, (double)wcp->offset, (unsigned int)data_size));
-#ifdef WITH_PROFILE
if(data_size == wcp->alloc_size) {
- DO_PROFILE_INC(writecache_num_perfect_writes);
+ DO_PROFILE_INC(writecache_perfect_writes);
}
-#endif
ret = real_write_file(NULL, fsp, wcp->data, wcp->offset, data_size);
return NT_STATUS_INVALID_HANDLE;
if (lp_strict_sync(SNUM(conn)) &&
- (lp_syncalways(SNUM(conn)) || write_through)) {
- int ret = flush_write_cache(fsp, SYNC_FLUSH);
+ (lp_sync_always(SNUM(conn)) || write_through)) {
+ int ret = flush_write_cache(fsp, SAMBA_SYNC_FLUSH);
if (ret == -1) {
return map_nt_error_from_unix(errno);
}
- ret = SMB_VFS_FSYNC(fsp);
+ ret = smb_vfs_fsync_sync(fsp);
if (ret == -1) {
return map_nt_error_from_unix(errno);
}
Perform a stat whether a valid fd or not.
************************************************************/
-int fsp_stat(files_struct *fsp, SMB_STRUCT_STAT *pst)
+int fsp_stat(files_struct *fsp)
{
if (fsp->fh->fd == -1) {
- int ret;
-
- ret = SMB_VFS_STAT(fsp->conn, fsp->fsp_name);
- if (ret != -1) {
- *pst = fsp->fsp_name->st;
+ if (fsp->posix_flags & FSP_POSIX_FLAGS_OPEN) {
+ return SMB_VFS_LSTAT(fsp->conn, fsp->fsp_name);
+ } else {
+ return SMB_VFS_STAT(fsp->conn, fsp->fsp_name);
}
- return ret;
} else {
- return SMB_VFS_FSTAT(fsp, pst);
+ return SMB_VFS_FSTAT(fsp, &fsp->fsp_name->st);
}
}
git.samba.org / samba.git / blobdiff