Pass fsp to dptr_CloseDir(). Cope with setting the fd if we're closing an fd that...
[samba.git] / source3 / smbd / dir.c
index fb246cdf8c5755ce7e320e6142c8a45129f09556..f81206e0ecfeebde899a2d1c0a3c1779570f403d 100644 (file)
@@ -20,6 +20,7 @@
 
 #include "includes.h"
 #include "smbd/globals.h"
+#include "libcli/security/security.h"
 
 /*
    This module implements directory related functions for Samba.
@@ -115,15 +116,20 @@ bool make_dir_struct(TALLOC_CTX *ctx,
  Initialise the dir bitmap.
 ****************************************************************************/
 
-void init_dptrs(void)
+bool init_dptrs(struct smbd_server_connection *sconn)
 {
-       if (dptr_bmap)
-               return;
+       if (sconn->smb1.searches.dptr_bmap) {
+               return true;
+       }
 
-       dptr_bmap = bitmap_allocate(MAX_DIRECTORY_HANDLES);
+       sconn->smb1.searches.dptr_bmap = bitmap_talloc(
+               sconn, MAX_DIRECTORY_HANDLES);
+
+       if (sconn->smb1.searches.dptr_bmap == NULL) {
+               return false;
+       }
 
-       if (!dptr_bmap)
-               exit_server("out of memory in init_dptrs");
+       return true;
 }
 
 /****************************************************************************
@@ -142,15 +148,14 @@ static void dptr_idle(struct dptr_struct *dptr)
  Idle the oldest dptr.
 ****************************************************************************/
 
-static void dptr_idleoldest(void)
+static void dptr_idleoldest(struct smbd_server_connection *sconn)
 {
        struct dptr_struct *dptr;
 
        /*
         * Go to the end of the list.
         */
-       for(dptr = dirptrs; dptr && dptr->next; dptr = dptr->next)
-               ;
+       dptr = DLIST_TAIL(sconn->smb1.searches.dirptrs);
 
        if(!dptr) {
                DEBUG(0,("No dptrs available to idle ?\n"));
@@ -161,7 +166,7 @@ static void dptr_idleoldest(void)
         * Idle the oldest pointer.
         */
 
-       for(; dptr; dptr = dptr->prev) {
+       for(; dptr; dptr = DLIST_PREV(dptr)) {
                if (dptr->dir_hnd) {
                        dptr_idle(dptr);
                        return;
@@ -173,15 +178,16 @@ static void dptr_idleoldest(void)
  Get the struct dptr_struct for a dir index.
 ****************************************************************************/
 
-static struct dptr_struct *dptr_get(int key, bool forclose)
+static struct dptr_struct *dptr_get(struct smbd_server_connection *sconn,
+                                   int key, bool forclose)
 {
        struct dptr_struct *dptr;
 
-       for(dptr = dirptrs; dptr; dptr = dptr->next) {
+       for(dptr = sconn->smb1.searches.dirptrs; dptr; dptr = dptr->next) {
                if(dptr->dnum == key) {
                        if (!forclose && !dptr->dir_hnd) {
-                               if (dirhandles_open >= MAX_OPEN_DIRECTORIES)
-                                       dptr_idleoldest();
+                               if (sconn->smb1.searches.dirhandles_open >= MAX_OPEN_DIRECTORIES)
+                                       dptr_idleoldest(sconn);
                                DEBUG(4,("dptr_get: Reopening dptr key %d\n",key));
                                if (!(dptr->dir_hnd = OpenDir(
                                              NULL, dptr->conn, dptr->path,
@@ -191,7 +197,7 @@ static struct dptr_struct *dptr_get(int key, bool forclose)
                                        return False;
                                }
                        }
-                       DLIST_PROMOTE(dirptrs,dptr);
+                       DLIST_PROMOTE(sconn->smb1.searches.dirptrs,dptr);
                        return dptr;
                }
        }
@@ -202,9 +208,9 @@ static struct dptr_struct *dptr_get(int key, bool forclose)
  Get the dir path for a dir index.
 ****************************************************************************/
 
-char *dptr_path(int key)
+char *dptr_path(struct smbd_server_connection *sconn, int key)
 {
-       struct dptr_struct *dptr = dptr_get(key, False);
+       struct dptr_struct *dptr = dptr_get(sconn, key, false);
        if (dptr)
                return(dptr->path);
        return(NULL);
@@ -214,9 +220,9 @@ char *dptr_path(int key)
  Get the dir wcard for a dir index.
 ****************************************************************************/
 
-char *dptr_wcard(int key)
+char *dptr_wcard(struct smbd_server_connection *sconn, int key)
 {
-       struct dptr_struct *dptr = dptr_get(key, False);
+       struct dptr_struct *dptr = dptr_get(sconn, key, false);
        if (dptr)
                return(dptr->wcard);
        return(NULL);
@@ -226,9 +232,9 @@ char *dptr_wcard(int key)
  Get the dir attrib for a dir index.
 ****************************************************************************/
 
-uint16 dptr_attr(int key)
+uint16 dptr_attr(struct smbd_server_connection *sconn, int key)
 {
-       struct dptr_struct *dptr = dptr_get(key, False);
+       struct dptr_struct *dptr = dptr_get(sconn, key, false);
        if (dptr)
                return(dptr->attr);
        return(0);
@@ -240,22 +246,29 @@ uint16 dptr_attr(int key)
 
 static void dptr_close_internal(struct dptr_struct *dptr)
 {
+       struct smbd_server_connection *sconn = dptr->conn->sconn;
+
        DEBUG(4,("closing dptr key %d\n",dptr->dnum));
 
-       DLIST_REMOVE(dirptrs, dptr);
+       if (sconn == NULL) {
+               goto done;
+       }
+
+       DLIST_REMOVE(sconn->smb1.searches.dirptrs, dptr);
 
        /*
         * Free the dnum in the bitmap. Remember the dnum value is always 
         * biased by one with respect to the bitmap.
         */
 
-       if(bitmap_query( dptr_bmap, dptr->dnum - 1) != True) {
+       if (!bitmap_query(sconn->smb1.searches.dptr_bmap, dptr->dnum - 1)) {
                DEBUG(0,("dptr_close_internal : Error - closing dnum = %d and bitmap not set !\n",
                        dptr->dnum ));
        }
 
-       bitmap_clear(dptr_bmap, dptr->dnum - 1);
+       bitmap_clear(sconn->smb1.searches.dptr_bmap, dptr->dnum - 1);
 
+done:
        TALLOC_FREE(dptr->dir_hnd);
 
        /* Lanman 2 specific code */
@@ -268,7 +281,7 @@ static void dptr_close_internal(struct dptr_struct *dptr)
  Close a dptr given a key.
 ****************************************************************************/
 
-void dptr_close(int *key)
+void dptr_close(struct smbd_server_connection *sconn, int *key)
 {
        struct dptr_struct *dptr;
 
@@ -278,7 +291,7 @@ void dptr_close(int *key)
        /* OS/2 seems to use -1 to indicate "close all directories" */
        if (*key == -1) {
                struct dptr_struct *next;
-               for(dptr = dirptrs; dptr; dptr = next) {
+               for(dptr = sconn->smb1.searches.dirptrs; dptr; dptr = next) {
                        next = dptr->next;
                        dptr_close_internal(dptr);
                }
@@ -286,7 +299,7 @@ void dptr_close(int *key)
                return;
        }
 
-       dptr = dptr_get(*key, True);
+       dptr = dptr_get(sconn, *key, true);
 
        if (!dptr) {
                DEBUG(0,("Invalid key %d given to dptr_close\n", *key));
@@ -305,10 +318,17 @@ void dptr_close(int *key)
 void dptr_closecnum(connection_struct *conn)
 {
        struct dptr_struct *dptr, *next;
-       for(dptr = dirptrs; dptr; dptr = next) {
+       struct smbd_server_connection *sconn = conn->sconn;
+
+       if (sconn == NULL) {
+               return;
+       }
+
+       for(dptr = sconn->smb1.searches.dirptrs; dptr; dptr = next) {
                next = dptr->next;
-               if (dptr->conn == conn)
+               if (dptr->conn == conn) {
                        dptr_close_internal(dptr);
+               }
        }
 }
 
@@ -319,9 +339,16 @@ void dptr_closecnum(connection_struct *conn)
 void dptr_idlecnum(connection_struct *conn)
 {
        struct dptr_struct *dptr;
-       for(dptr = dirptrs; dptr; dptr = dptr->next) {
-               if (dptr->conn == conn && dptr->dir_hnd)
+       struct smbd_server_connection *sconn = conn->sconn;
+
+       if (sconn == NULL) {
+               return;
+       }
+
+       for(dptr = sconn->smb1.searches.dirptrs; dptr; dptr = dptr->next) {
+               if (dptr->conn == conn && dptr->dir_hnd) {
                        dptr_idle(dptr);
+               }
        }
 }
 
@@ -329,10 +356,11 @@ void dptr_idlecnum(connection_struct *conn)
  Close a dptr that matches a given path, only if it matches the spid also.
 ****************************************************************************/
 
-void dptr_closepath(char *path,uint16 spid)
+void dptr_closepath(struct smbd_server_connection *sconn,
+                   char *path,uint16 spid)
 {
        struct dptr_struct *dptr, *next;
-       for(dptr = dirptrs; dptr; dptr = next) {
+       for(dptr = sconn->smb1.searches.dirptrs; dptr; dptr = next) {
                next = dptr->next;
                if (spid == dptr->spid && strequal(dptr->path,path))
                        dptr_close_internal(dptr);
@@ -345,14 +373,15 @@ void dptr_closepath(char *path,uint16 spid)
  finished with that one.
 ****************************************************************************/
 
-static void dptr_close_oldest(bool old)
+static void dptr_close_oldest(struct smbd_server_connection *sconn,
+                             bool old)
 {
        struct dptr_struct *dptr;
 
        /*
         * Go to the end of the list.
         */
-       for(dptr = dirptrs; dptr && dptr->next; dptr = dptr->next)
+       for(dptr = sconn->smb1.searches.dirptrs; dptr && dptr->next; dptr = dptr->next)
                ;
 
        if(!dptr) {
@@ -366,7 +395,7 @@ static void dptr_close_oldest(bool old)
         * one of the new dnum handles.
         */
 
-       for(; dptr; dptr = dptr->prev) {
+       for(; dptr; dptr = DLIST_PREV(dptr)) {
                if ((old && (dptr->dnum < 256) && !dptr->expect_close) ||
                        (!old && (dptr->dnum > 255))) {
                                dptr_close_internal(dptr);
@@ -387,12 +416,18 @@ static void dptr_close_oldest(bool old)
 NTSTATUS dptr_create(connection_struct *conn, const char *path, bool old_handle, bool expect_close,uint16 spid,
                const char *wcard, bool wcard_has_wild, uint32 attr, struct dptr_struct **dptr_ret)
 {
+       struct smbd_server_connection *sconn = conn->sconn;
        struct dptr_struct *dptr = NULL;
        struct smb_Dir *dir_hnd;
        NTSTATUS status;
 
        DEBUG(5,("dptr_create dir=%s\n", path));
 
+       if (sconn == NULL) {
+               DEBUG(0,("dptr_create: called with fake connection_struct\n"));
+               return NT_STATUS_INTERNAL_ERROR;
+       }
+
        if (!wcard) {
                return NT_STATUS_INVALID_PARAMETER;
        }
@@ -407,10 +442,8 @@ NTSTATUS dptr_create(connection_struct *conn, const char *path, bool old_handle,
                return map_nt_error_from_unix(errno);
        }
 
-       string_set(&conn->dirpath,path);
-
-       if (dirhandles_open >= MAX_OPEN_DIRECTORIES) {
-               dptr_idleoldest();
+       if (sconn->smb1.searches.dirhandles_open >= MAX_OPEN_DIRECTORIES) {
+               dptr_idleoldest(sconn);
        }
 
        dptr = SMB_MALLOC_P(struct dptr_struct);
@@ -429,7 +462,7 @@ NTSTATUS dptr_create(connection_struct *conn, const char *path, bool old_handle,
                 * value we return will fit in the range 1-255.
                 */
 
-               dptr->dnum = bitmap_find(dptr_bmap, 0);
+               dptr->dnum = bitmap_find(sconn->smb1.searches.dptr_bmap, 0);
 
                if(dptr->dnum == -1 || dptr->dnum > 254) {
 
@@ -439,10 +472,10 @@ NTSTATUS dptr_create(connection_struct *conn, const char *path, bool old_handle,
                         * finished with that one.
                         */
 
-                       dptr_close_oldest(True);
+                       dptr_close_oldest(sconn, true);
 
                        /* Now try again... */
-                       dptr->dnum = bitmap_find(dptr_bmap, 0);
+                       dptr->dnum = bitmap_find(sconn->smb1.searches.dptr_bmap, 0);
                        if(dptr->dnum == -1 || dptr->dnum > 254) {
                                DEBUG(0,("dptr_create: returned %d: Error - all old dirptrs in use ?\n", dptr->dnum));
                                SAFE_FREE(dptr);
@@ -457,7 +490,7 @@ NTSTATUS dptr_create(connection_struct *conn, const char *path, bool old_handle,
                 * a range that will return 256 - MAX_DIRECTORY_HANDLES.
                 */
 
-               dptr->dnum = bitmap_find(dptr_bmap, 255);
+               dptr->dnum = bitmap_find(sconn->smb1.searches.dptr_bmap, 255);
 
                if(dptr->dnum == -1 || dptr->dnum < 255) {
 
@@ -468,10 +501,10 @@ NTSTATUS dptr_create(connection_struct *conn, const char *path, bool old_handle,
                         * directory handles.
                         */
 
-                       dptr_close_oldest(False);
+                       dptr_close_oldest(sconn, false);
 
                        /* Now try again... */
-                       dptr->dnum = bitmap_find(dptr_bmap, 255);
+                       dptr->dnum = bitmap_find(sconn->smb1.searches.dptr_bmap, 255);
 
                        if(dptr->dnum == -1 || dptr->dnum < 255) {
                                DEBUG(0,("dptr_create: returned %d: Error - all new dirptrs in use ?\n", dptr->dnum));
@@ -482,7 +515,7 @@ NTSTATUS dptr_create(connection_struct *conn, const char *path, bool old_handle,
                }
        }
 
-       bitmap_set(dptr_bmap, dptr->dnum);
+       bitmap_set(sconn->smb1.searches.dptr_bmap, dptr->dnum);
 
        dptr->dnum += 1; /* Always bias the dnum by one - no zero dnums allowed. */
 
@@ -493,7 +526,7 @@ NTSTATUS dptr_create(connection_struct *conn, const char *path, bool old_handle,
        dptr->expect_close = expect_close;
        dptr->wcard = SMB_STRDUP(wcard);
        if (!dptr->wcard) {
-               bitmap_clear(dptr_bmap, dptr->dnum - 1);
+               bitmap_clear(sconn->smb1.searches.dptr_bmap, dptr->dnum - 1);
                SAFE_FREE(dptr);
                TALLOC_FREE(dir_hnd);
                return NT_STATUS_NO_MEMORY;
@@ -506,7 +539,7 @@ NTSTATUS dptr_create(connection_struct *conn, const char *path, bool old_handle,
 
        dptr->attr = attr;
 
-       DLIST_ADD(dirptrs, dptr);
+       DLIST_ADD(sconn->smb1.searches.dirptrs, dptr);
 
        DEBUG(3,("creating new dirptr %d for path %s, expect_close = %d\n",
                dptr->dnum,path,expect_close));  
@@ -521,11 +554,16 @@ NTSTATUS dptr_create(connection_struct *conn, const char *path, bool old_handle,
  Wrapper functions to access the lower level directory handles.
 ****************************************************************************/
 
-int dptr_CloseDir(struct dptr_struct *dptr)
+void dptr_CloseDir(files_struct *fsp)
 {
-       DLIST_REMOVE(dirptrs, dptr);
-       TALLOC_FREE(dptr->dir_hnd);
-       return 0;
+       if (fsp->dptr) {
+               if (fsp->fh->fd == dirfd(fsp->dptr->dir_hnd->dir)) {
+                       /* The call below closes the underlying fd. */
+                       fsp->fh->fd = -1;
+               }
+               dptr_close_internal(fsp->dptr);
+               fsp->dptr = NULL;
+       }
 }
 
 void dptr_SeekDir(struct dptr_struct *dptr, long offset)
@@ -553,14 +591,20 @@ int dptr_dnum(struct dptr_struct *dptr)
 ****************************************************************************/
 
 static const char *dptr_normal_ReadDirName(struct dptr_struct *dptr,
-                                          long *poffset, SMB_STRUCT_STAT *pst)
+                                          long *poffset, SMB_STRUCT_STAT *pst,
+                                          char **ptalloced)
 {
        /* Normal search for the next file. */
        const char *name;
-       while ((name = ReadDirName(dptr->dir_hnd, poffset, pst)) != NULL) {
+       char *talloced = NULL;
+
+       while ((name = ReadDirName(dptr->dir_hnd, poffset, pst, &talloced))
+              != NULL) {
                if (is_visible_file(dptr->conn, dptr->path, name, pst, True)) {
+                       *ptalloced = talloced;
                        return name;
                }
+               TALLOC_FREE(talloced);
        }
        return NULL;
 }
@@ -574,18 +618,26 @@ char *dptr_ReadDirName(TALLOC_CTX *ctx,
                        long *poffset,
                        SMB_STRUCT_STAT *pst)
 {
+       struct smb_filename smb_fname_base;
        char *name = NULL;
+       const char *name_temp = NULL;
+       char *talloced = NULL;
        char *pathreal = NULL;
        char *found_name = NULL;
        int ret;
-       const char *name_temp = NULL;
 
        SET_STAT_INVALID(*pst);
 
        if (dptr->has_wild || dptr->did_stat) {
-               name_temp = dptr_normal_ReadDirName(dptr, poffset, pst);
-               name = talloc_strdup(ctx, name_temp);
-               return name;
+               name_temp = dptr_normal_ReadDirName(dptr, poffset, pst,
+                                                   &talloced);
+               if (name_temp == NULL) {
+                       return NULL;
+               }
+               if (talloced != NULL) {
+                       return talloc_move(ctx, &talloced);
+               }
+               return talloc_strdup(ctx, name_temp);
        }
 
        /* If poffset is -1 then we know we returned this name before and we
@@ -624,7 +676,12 @@ char *dptr_ReadDirName(TALLOC_CTX *ctx,
        if (!pathreal)
                return NULL;
 
-       if (SMB_VFS_STAT(dptr->conn, pathreal, pst) == 0) {
+       /* Create an smb_filename with stream_name == NULL. */
+       ZERO_STRUCT(smb_fname_base);
+       smb_fname_base.base_name = pathreal;
+
+       if (SMB_VFS_STAT(dptr->conn, &smb_fname_base) == 0) {
+               *pst = smb_fname_base.st;
                name = talloc_strdup(ctx, dptr->wcard);
                goto clean;
        } else {
@@ -662,9 +719,14 @@ char *dptr_ReadDirName(TALLOC_CTX *ctx,
 
        TALLOC_FREE(pathreal);
 
-       name_temp = dptr_normal_ReadDirName(dptr, poffset, pst);
-       name = talloc_strdup(ctx, name_temp);
-       return name;
+       name_temp = dptr_normal_ReadDirName(dptr, poffset, pst, &talloced);
+       if (name_temp == NULL) {
+               return NULL;
+       }
+       if (talloced != NULL) {
+               return talloc_move(ctx, &talloced);
+       }
+       return talloc_strdup(ctx, name_temp);
 
 clean:
        TALLOC_FREE(pathreal);
@@ -714,10 +776,11 @@ void dptr_init_search_op(struct dptr_struct *dptr)
  Fill the 5 byte server reserved dptr field.
 ****************************************************************************/
 
-bool dptr_fill(char *buf1,unsigned int key)
+bool dptr_fill(struct smbd_server_connection *sconn,
+              char *buf1,unsigned int key)
 {
        unsigned char *buf = (unsigned char *)buf1;
-       struct dptr_struct *dptr = dptr_get(key, False);
+       struct dptr_struct *dptr = dptr_get(sconn, key, false);
        uint32 offset;
        if (!dptr) {
                DEBUG(1,("filling null dirptr %d\n",key));
@@ -735,10 +798,11 @@ bool dptr_fill(char *buf1,unsigned int key)
  Fetch the dir ptr and seek it given the 5 byte server field.
 ****************************************************************************/
 
-struct dptr_struct *dptr_fetch(char *buf,int *num)
+struct dptr_struct *dptr_fetch(struct smbd_server_connection *sconn,
+                              char *buf, int *num)
 {
        unsigned int key = *(unsigned char *)buf;
-       struct dptr_struct *dptr = dptr_get(key, False);
+       struct dptr_struct *dptr = dptr_get(sconn, key, false);
        uint32 offset;
        long seekoff;
 
@@ -755,7 +819,7 @@ struct dptr_struct *dptr_fetch(char *buf,int *num)
        }
        SeekDir(dptr->dir_hnd,seekoff);
        DEBUG(3,("fetching dirptr %d for path %s at offset %d\n",
-               key,dptr_path(key),(int)seekoff));
+               key, dptr->path, (int)seekoff));
        return(dptr);
 }
 
@@ -763,15 +827,16 @@ struct dptr_struct *dptr_fetch(char *buf,int *num)
  Fetch the dir ptr.
 ****************************************************************************/
 
-struct dptr_struct *dptr_fetch_lanman2(int dptr_num)
+struct dptr_struct *dptr_fetch_lanman2(struct smbd_server_connection *sconn,
+                                      int dptr_num)
 {
-       struct dptr_struct *dptr  = dptr_get(dptr_num, False);
+       struct dptr_struct *dptr  = dptr_get(sconn, dptr_num, false);
 
        if (!dptr) {
                DEBUG(3,("fetched null dirptr %d\n",dptr_num));
                return(NULL);
        }
-       DEBUG(3,("fetching dirptr %d for path %s\n",dptr_num,dptr_path(dptr_num)));
+       DEBUG(3,("fetching dirptr %d for path %s\n",dptr_num,dptr->path));
        return(dptr);
 }
 
@@ -813,138 +878,249 @@ static bool mangle_mask_match(connection_struct *conn,
        return mask_match_search(mname,mask,False);
 }
 
-/****************************************************************************
- Get an 8.3 directory entry.
-****************************************************************************/
-
-bool get_dir_entry(TALLOC_CTX *ctx,
-               connection_struct *conn,
-               const char *mask,
-               uint32 dirtype,
-               char **pp_fname_out,
-               SMB_OFF_T *size,
-               uint32 *mode,
-               struct timespec *date,
-               bool check_descend,
-               bool ask_sharemode)
+bool smbd_dirptr_get_entry(TALLOC_CTX *ctx,
+                          struct dptr_struct *dirptr,
+                          const char *mask,
+                          uint32_t dirtype,
+                          bool dont_descend,
+                          bool ask_sharemode,
+                          bool (*match_fn)(TALLOC_CTX *ctx,
+                                           void *private_data,
+                                           const char *dname,
+                                           const char *mask,
+                                           char **_fname),
+                          bool (*mode_fn)(TALLOC_CTX *ctx,
+                                          void *private_data,
+                                          struct smb_filename *smb_fname,
+                                          uint32_t *_mode),
+                          void *private_data,
+                          char **_fname,
+                          struct smb_filename **_smb_fname,
+                          uint32_t *_mode,
+                          long *_prev_offset)
 {
-       char *dname = NULL;
-       bool found = False;
-       SMB_STRUCT_STAT sbuf;
-       char *pathreal = NULL;
-       char *filename = NULL;
+       connection_struct *conn = dirptr->conn;
        bool needslash;
 
-       *pp_fname_out = NULL;
+       *_smb_fname = NULL;
+       *_mode = 0;
 
-       needslash = ( conn->dirpath[strlen(conn->dirpath) -1] != '/');
+       needslash = ( dirptr->path[strlen(dirptr->path) -1] != '/');
 
-       if (!conn->dirptr) {
-               return(False);
-       }
+       while (true) {
+               long cur_offset;
+               long prev_offset;
+               SMB_STRUCT_STAT sbuf;
+               char *dname = NULL;
+               bool isdots;
+               char *fname = NULL;
+               char *pathreal = NULL;
+               struct smb_filename smb_fname;
+               uint32_t mode = 0;
+               bool ok;
+               NTSTATUS status;
 
-       while (!found) {
-               long curoff = dptr_TellDir(conn->dirptr);
-               dname = dptr_ReadDirName(ctx, conn->dirptr, &curoff, &sbuf);
+               cur_offset = dptr_TellDir(dirptr);
+               prev_offset = cur_offset;
+               dname = dptr_ReadDirName(ctx, dirptr, &cur_offset, &sbuf);
 
-               DEBUG(6,("readdir on dirptr 0x%lx now at offset %ld\n",
-                       (long)conn->dirptr,TellDir(conn->dirptr->dir_hnd)));
+               DEBUG(6,("smbd_dirptr_get_entry: dirptr 0x%lx now at offset %ld\n",
+                       (long)dirptr, cur_offset));
 
                if (dname == NULL) {
-                       return(False);
+                       return false;
                }
 
-               filename = dname;
-
-               /* notice the special *.* handling. This appears to be the only difference
-                       between the wildcard handling in this routine and in the trans2 routines.
-                       see masktest for a demo
-               */
-               if ((strcmp(mask,"*.*") == 0) ||
-                   mask_match_search(filename,mask,False) ||
-                   mangle_mask_match(conn,filename,mask)) {
-                       char mname[13];
-
-                       if (!mangle_is_8_3(filename, False, conn->params)) {
-                               if (!name_to_8_3(filename,mname,False,
-                                          conn->params)) {
-                                       TALLOC_FREE(filename);
-                                       continue;
-                               }
-                               filename = talloc_strdup(ctx, mname);
-                               if (!filename) {
-                                       return False;
-                               }
-                       }
+               isdots = (ISDOT(dname) || ISDOTDOT(dname));
+               if (dont_descend && !isdots) {
+                       TALLOC_FREE(dname);
+                       continue;
+               }
 
-                       if (needslash) {
-                               pathreal = talloc_asprintf(ctx,
-                                               "%s/%s",
-                                               conn->dirpath,
-                                               dname);
-                       } else {
-                               pathreal = talloc_asprintf(ctx,
-                                               "%s%s",
-                                               conn->dirpath,
-                                               dname);
-                       }
-                       if (!pathreal) {
-                               TALLOC_FREE(filename);
-                               return False;
-                       }
+               /*
+                * fname may get mangled, dname is never mangled.
+                * Whenever we're accessing the filesystem we use
+                * pathreal which is composed from dname.
+                */
 
-                       if (!VALID_STAT(sbuf) && (SMB_VFS_STAT(conn, pathreal, &sbuf)) != 0) {
-                               DEBUG(5,("Couldn't stat 1 [%s]. Error = %s\n",
-                                       pathreal, strerror(errno) ));
-                               TALLOC_FREE(pathreal);
-                               TALLOC_FREE(filename);
-                               continue;
-                       }
+               ok = match_fn(ctx, private_data, dname, mask, &fname);
+               if (!ok) {
+                       TALLOC_FREE(dname);
+                       continue;
+               }
 
-                       *mode = dos_mode(conn,pathreal,&sbuf);
+               pathreal = talloc_asprintf(ctx, "%s%s%s",
+                                          dirptr->path,
+                                          needslash?"/":"",
+                                          dname);
+               if (!pathreal) {
+                       TALLOC_FREE(dname);
+                       TALLOC_FREE(fname);
+                       return false;
+               }
 
-                       if (!dir_check_ftype(conn,*mode,dirtype)) {
-                               DEBUG(5,("[%s] attribs 0x%x didn't match 0x%x\n",filename,(unsigned int)*mode,(unsigned int)dirtype));
-                               TALLOC_FREE(pathreal);
-                               TALLOC_FREE(filename);
-                               continue;
+               /* Create smb_fname with NULL stream_name. */
+               ZERO_STRUCT(smb_fname);
+               smb_fname.base_name = pathreal;
+               smb_fname.st = sbuf;
+
+               ok = mode_fn(ctx, private_data, &smb_fname, &mode);
+               if (!ok) {
+                       TALLOC_FREE(dname);
+                       TALLOC_FREE(fname);
+                       TALLOC_FREE(pathreal);
+                       continue;
+               }
+
+               if (!dir_check_ftype(conn, mode, dirtype)) {
+                       DEBUG(5,("[%s] attribs 0x%x didn't match 0x%x\n",
+                               fname, (unsigned int)mode, (unsigned int)dirtype));
+                       TALLOC_FREE(dname);
+                       TALLOC_FREE(fname);
+                       TALLOC_FREE(pathreal);
+                       continue;
+               }
+
+               if (ask_sharemode) {
+                       struct timespec write_time_ts;
+                       struct file_id fileid;
+
+                       fileid = vfs_file_id_from_sbuf(conn,
+                                                      &smb_fname.st);
+                       get_file_infos(fileid, 0, NULL, &write_time_ts);
+                       if (!null_timespec(write_time_ts)) {
+                               update_stat_ex_mtime(&smb_fname.st,
+                                                    write_time_ts);
                        }
+               }
 
-                       *size = sbuf.st_ex_size;
-                       *date = sbuf.st_ex_mtime;
+               DEBUG(3,("smbd_dirptr_get_entry mask=[%s] found %s "
+                       "fname=%s (%s)\n",
+                       mask, smb_fname_str_dbg(&smb_fname),
+                       dname, fname));
 
-                       if (ask_sharemode) {
-                               struct timespec write_time_ts;
-                               struct file_id fileid;
+               DirCacheAdd(dirptr->dir_hnd, dname, cur_offset);
 
-                               fileid = vfs_file_id_from_sbuf(conn, &sbuf);
-                               get_file_infos(fileid, NULL, &write_time_ts);
-                               if (!null_timespec(write_time_ts)) {
-                                       *date = write_time_ts;
-                               }
+               TALLOC_FREE(dname);
+
+               status = copy_smb_filename(ctx, &smb_fname, _smb_fname);
+               TALLOC_FREE(pathreal);
+               if (!NT_STATUS_IS_OK(status)) {
+                       return false;
+               }
+               *_fname = fname;
+               *_mode = mode;
+               *_prev_offset = prev_offset;
+
+               return true;
+       }
+
+       return false;
+}
+
+/****************************************************************************
+ Get an 8.3 directory entry.
+****************************************************************************/
+
+static bool smbd_dirptr_8_3_match_fn(TALLOC_CTX *ctx,
+                                    void *private_data,
+                                    const char *dname,
+                                    const char *mask,
+                                    char **_fname)
+{
+       connection_struct *conn = (connection_struct *)private_data;
+
+       if ((strcmp(mask,"*.*") == 0) ||
+           mask_match_search(dname, mask, false) ||
+           mangle_mask_match(conn, dname, mask)) {
+               char mname[13];
+               const char *fname;
+
+               if (!mangle_is_8_3(dname, false, conn->params)) {
+                       bool ok = name_to_8_3(dname, mname, false,
+                                             conn->params);
+                       if (!ok) {
+                               return false;
                        }
+                       fname = mname;
+               } else {
+                       fname = dname;
+               }
 
-                       DEBUG(3,("get_dir_entry mask=[%s] found %s "
-                               "fname=%s (%s)\n",
-                               mask,
-                               pathreal,
-                               dname,
-                               filename));
+               *_fname = talloc_strdup(ctx, fname);
+               if (*_fname == NULL) {
+                       return false;
+               }
 
-                       found = True;
+               return true;
+       }
 
-                       SMB_ASSERT(filename != NULL);
-                       *pp_fname_out = filename;
+       return false;
+}
 
-                       DirCacheAdd(conn->dirptr->dir_hnd, dname, curoff);
-                       TALLOC_FREE(pathreal);
+static bool smbd_dirptr_8_3_mode_fn(TALLOC_CTX *ctx,
+                                   void *private_data,
+                                   struct smb_filename *smb_fname,
+                                   uint32_t *_mode)
+{
+       connection_struct *conn = (connection_struct *)private_data;
+
+       if (!VALID_STAT(smb_fname->st)) {
+               if ((SMB_VFS_STAT(conn, smb_fname)) != 0) {
+                       DEBUG(5,("smbd_dirptr_8_3_mode_fn: "
+                                "Couldn't stat [%s]. Error "
+                                "= %s\n",
+                                smb_fname_str_dbg(smb_fname),
+                                strerror(errno)));
+                       return false;
                }
+       }
+
+       *_mode = dos_mode(conn, smb_fname);
+       return true;
+}
 
-               if (!found)
-                       TALLOC_FREE(filename);
+bool get_dir_entry(TALLOC_CTX *ctx,
+               struct dptr_struct *dirptr,
+               const char *mask,
+               uint32_t dirtype,
+               char **_fname,
+               SMB_OFF_T *_size,
+               uint32_t *_mode,
+               struct timespec *_date,
+               bool check_descend,
+               bool ask_sharemode)
+{
+       connection_struct *conn = dirptr->conn;
+       char *fname = NULL;
+       struct smb_filename *smb_fname = NULL;
+       uint32_t mode = 0;
+       long prev_offset;
+       bool ok;
+
+       ok = smbd_dirptr_get_entry(ctx,
+                                  dirptr,
+                                  mask,
+                                  dirtype,
+                                  check_descend,
+                                  ask_sharemode,
+                                  smbd_dirptr_8_3_match_fn,
+                                  smbd_dirptr_8_3_mode_fn,
+                                  conn,
+                                  &fname,
+                                  &smb_fname,
+                                  &mode,
+                                  &prev_offset);
+       if (!ok) {
+               return false;
        }
 
-       return(found);
+       *_fname = talloc_move(ctx, &fname);
+       *_size = smb_fname->st.st_ex_size;
+       *_mode = mode;
+       *_date = smb_fname->st.st_ex_mtime;
+       TALLOC_FREE(smb_fname);
+       return true;
 }
 
 /*******************************************************************
@@ -953,18 +1129,20 @@ bool get_dir_entry(TALLOC_CTX *ctx,
  use it for anything security sensitive.
 ********************************************************************/
 
-static bool user_can_read_file(connection_struct *conn, char *name)
+static bool user_can_read_file(connection_struct *conn,
+                              struct smb_filename *smb_fname)
 {
        /*
-        * If user is a member of the Admin group
-        * we never hide files from them.
+        * Never hide files from the root user.
+        * We use (uid_t)0 here not sec_initial_uid()
+        * as make test uses a single user context.
         */
 
-       if (conn->admin_user) {
+       if (get_current_uid(conn) == (uid_t)0) {
                return True;
        }
 
-       return can_access_file_acl(conn, name, FILE_READ_DATA);
+       return can_access_file_acl(conn, smb_fname, FILE_READ_DATA);
 }
 
 /*******************************************************************
@@ -974,45 +1152,52 @@ static bool user_can_read_file(connection_struct *conn, char *name)
  use it for anything security sensitive.
 ********************************************************************/
 
-static bool user_can_write_file(connection_struct *conn, char *name, SMB_STRUCT_STAT *pst)
+static bool user_can_write_file(connection_struct *conn,
+                               const struct smb_filename *smb_fname)
 {
        /*
-        * If user is a member of the Admin group
-        * we never hide files from them.
+        * Never hide files from the root user.
+        * We use (uid_t)0 here not sec_initial_uid()
+        * as make test uses a single user context.
         */
 
-       if (conn->admin_user) {
+       if (get_current_uid(conn) == (uid_t)0) {
                return True;
        }
 
-       SMB_ASSERT(VALID_STAT(*pst));
+       SMB_ASSERT(VALID_STAT(smb_fname->st));
 
        /* Pseudo-open the file */
 
-       if(S_ISDIR(pst->st_ex_mode)) {
+       if(S_ISDIR(smb_fname->st.st_ex_mode)) {
                return True;
        }
 
-       return can_write_to_file(conn, name, pst);
+       return can_write_to_file(conn, smb_fname);
 }
 
 /*******************************************************************
   Is a file a "special" type ?
 ********************************************************************/
 
-static bool file_is_special(connection_struct *conn, char *name, SMB_STRUCT_STAT *pst)
+static bool file_is_special(connection_struct *conn,
+                           const struct smb_filename *smb_fname)
 {
        /*
-        * If user is a member of the Admin group
-        * we never hide files from them.
+        * Never hide files from the root user.
+        * We use (uid_t)0 here not sec_initial_uid()
+        * as make test uses a single user context.
         */
 
-       if (conn->admin_user)
+       if (get_current_uid(conn) == (uid_t)0) {
                return False;
+       }
 
-       SMB_ASSERT(VALID_STAT(*pst));
+       SMB_ASSERT(VALID_STAT(smb_fname->st));
 
-       if (S_ISREG(pst->st_ex_mode) || S_ISDIR(pst->st_ex_mode) || S_ISLNK(pst->st_ex_mode))
+       if (S_ISREG(smb_fname->st.st_ex_mode) ||
+           S_ISDIR(smb_fname->st.st_ex_mode) ||
+           S_ISLNK(smb_fname->st.st_ex_mode))
                return False;
 
        return True;
@@ -1029,6 +1214,10 @@ bool is_visible_file(connection_struct *conn, const char *dir_path,
        bool hide_unreadable = lp_hideunreadable(SNUM(conn));
        bool hide_unwriteable = lp_hideunwriteable_files(SNUM(conn));
        bool hide_special = lp_hide_special_files(SNUM(conn));
+       char *entry = NULL;
+       struct smb_filename *smb_fname_base = NULL;
+       NTSTATUS status;
+       bool ret = false;
 
        if ((strcmp(".",name) == 0) || (strcmp("..",name) == 0)) {
                return True; /* . and .. are always visible. */
@@ -1041,55 +1230,63 @@ bool is_visible_file(connection_struct *conn, const char *dir_path,
        }
 
        if (hide_unreadable || hide_unwriteable || hide_special) {
-               char *entry = NULL;
-
                entry = talloc_asprintf(talloc_tos(), "%s/%s", dir_path, name);
-               if (!entry)
-                       return false;
+               if (!entry) {
+                       ret = false;
+                       goto out;
                }
 
-               /* If it's a dfs symlink, ignore _hide xxxx_ options */
-               if (lp_host_msdfs() &&
-                               lp_msdfs_root(SNUM(conn)) &&
-                               is_msdfs_link(conn, entry, NULL)) {
-                       TALLOC_FREE(entry);
-                       return true;
+               /* Create an smb_filename with stream_name == NULL. */
+               status = create_synthetic_smb_fname(talloc_tos(), entry, NULL,
+                                                   pst, &smb_fname_base);
+               if (!NT_STATUS_IS_OK(status)) {
+                       ret = false;
+                       goto out;
                }
 
                /* If the file name does not exist, there's no point checking
                 * the configuration options. We succeed, on the basis that the
                 * checks *might* have passed if the file was present.
                 */
-               if (!VALID_STAT(*pst) && (SMB_VFS_STAT(conn, entry, pst) != 0))
-               {
-                       TALLOC_FREE(entry);
-                       return true;
+               if (!VALID_STAT(*pst)) {
+                       if (SMB_VFS_STAT(conn, smb_fname_base) != 0) {
+                               ret = true;
+                               goto out;
+                       } else {
+                               *pst = smb_fname_base->st;
+                       }
                }
 
                /* Honour _hide unreadable_ option */
-               if (hide_unreadable && !user_can_read_file(conn, entry)) {
+               if (hide_unreadable &&
+                   !user_can_read_file(conn, smb_fname_base)) {
                        DEBUG(10,("is_visible_file: file %s is unreadable.\n",
                                 entry ));
-                       TALLOC_FREE(entry);
-                       return false;
+                       ret = false;
+                       goto out;
                }
                /* Honour _hide unwriteable_ option */
-               if (hide_unwriteable && !user_can_write_file(conn, entry, pst)) {
+               if (hide_unwriteable && !user_can_write_file(conn,
+                                                            smb_fname_base)) {
                        DEBUG(10,("is_visible_file: file %s is unwritable.\n",
                                 entry ));
-                       TALLOC_FREE(entry);
-                       return false;
+                       ret = false;
+                       goto out;
                }
                /* Honour _hide_special_ option */
-               if (hide_special && file_is_special(conn, entry, pst)) {
+               if (hide_special && file_is_special(conn, smb_fname_base)) {
                        DEBUG(10,("is_visible_file: file %s is special.\n",
                                 entry ));
-                       TALLOC_FREE(entry);
-                       return false;
+                       ret = false;
+                       goto out;
                }
-               TALLOC_FREE(entry);
        }
-       return true;
+
+       ret = true;
+ out:
+       TALLOC_FREE(smb_fname_base);
+       TALLOC_FREE(entry);
+       return ret;
 }
 
 static int smb_Dir_destructor(struct smb_Dir *dirp)
@@ -1097,7 +1294,9 @@ static int smb_Dir_destructor(struct smb_Dir *dirp)
        if (dirp->dir) {
                SMB_VFS_CLOSEDIR(dirp->conn,dirp->dir);
        }
-       dirhandles_open--;
+       if (dirp->conn->sconn) {
+               dirp->conn->sconn->smb1.searches.dirhandles_open--;
+       }
        return 0;
 }
 
@@ -1109,6 +1308,7 @@ struct smb_Dir *OpenDir(TALLOC_CTX *mem_ctx, connection_struct *conn,
                        const char *name, const char *mask, uint32 attr)
 {
        struct smb_Dir *dirp = TALLOC_ZERO_P(mem_ctx, struct smb_Dir);
+       struct smbd_server_connection *sconn = conn->sconn;
 
        if (!dirp) {
                return NULL;
@@ -1123,7 +1323,9 @@ struct smb_Dir *OpenDir(TALLOC_CTX *mem_ctx, connection_struct *conn,
                goto fail;
        }
 
-       dirhandles_open++;
+       if (sconn) {
+               sconn->smb1.searches.dirhandles_open++;
+       }
        talloc_set_destructor(dirp, smb_Dir_destructor);
 
        dirp->dir = SMB_VFS_OPENDIR(conn, dirp->dir_path, mask, attr);
@@ -1147,9 +1349,10 @@ struct smb_Dir *OpenDir(TALLOC_CTX *mem_ctx, connection_struct *conn,
 ********************************************************************/
 
 const char *ReadDirName(struct smb_Dir *dirp, long *poffset,
-                       SMB_STRUCT_STAT *sbuf)
+                       SMB_STRUCT_STAT *sbuf, char **ptalloced)
 {
        const char *n;
+       char *talloced = NULL;
        connection_struct *conn = dirp->conn;
 
        /* Cheat to allow . and .. to be the first entries returned. */
@@ -1160,10 +1363,11 @@ const char *ReadDirName(struct smb_Dir *dirp, long *poffset,
                        n = ".";
                        *poffset = dirp->offset = START_OF_DIRECTORY_OFFSET;
                } else {
-                       *poffset = dirp->offset = DOT_DOT_DIRECTORY_OFFSET;
                        n = "..";
+                       *poffset = dirp->offset = DOT_DOT_DIRECTORY_OFFSET;
                }
                dirp->file_number++;
+               *ptalloced = NULL;
                return n;
        } else if (*poffset == END_OF_DIRECTORY_OFFSET) {
                *poffset = dirp->offset = END_OF_DIRECTORY_OFFSET;
@@ -1173,18 +1377,21 @@ const char *ReadDirName(struct smb_Dir *dirp, long *poffset,
                SeekDir(dirp, *poffset);
        }
 
-       while ((n = vfs_readdirname(conn, dirp->dir, sbuf))) {
+       while ((n = vfs_readdirname(conn, dirp->dir, sbuf, &talloced))) {
                /* Ignore . and .. - we've already returned them. */
                if (*n == '.') {
                        if ((n[1] == '\0') || (n[1] == '.' && n[2] == '\0')) {
+                               TALLOC_FREE(talloced);
                                continue;
                        }
                }
                *poffset = dirp->offset = SMB_VFS_TELLDIR(conn, dirp->dir);
+               *ptalloced = talloced;
                dirp->file_number++;
                return n;
        }
        *poffset = dirp->offset = END_OF_DIRECTORY_OFFSET;
+       *ptalloced = NULL;
        return NULL;
 }
 
@@ -1279,7 +1486,8 @@ void DirCacheAdd(struct smb_Dir *dirp, const char *name, long offset)
 bool SearchDir(struct smb_Dir *dirp, const char *name, long *poffset)
 {
        int i;
-       const char *entry;
+       const char *entry = NULL;
+       char *talloced = NULL;
        connection_struct *conn = dirp->conn;
 
        /* Search back in the name cache. */
@@ -1306,10 +1514,12 @@ bool SearchDir(struct smb_Dir *dirp, const char *name, long *poffset)
        SMB_VFS_REWINDDIR(conn, dirp->dir);
        dirp->file_number = 0;
        *poffset = START_OF_DIRECTORY_OFFSET;
-       while ((entry = ReadDirName(dirp, poffset, NULL))) {
+       while ((entry = ReadDirName(dirp, poffset, NULL, &talloced))) {
                if (conn->case_sensitive ? (strcmp(entry, name) == 0) : strequal(entry, name)) {
+                       TALLOC_FREE(talloced);
                        return True;
                }
+               TALLOC_FREE(talloced);
        }
        return False;
 }
@@ -1323,7 +1533,8 @@ NTSTATUS can_delete_directory(struct connection_struct *conn,
 {
        NTSTATUS status = NT_STATUS_OK;
        long dirpos = 0;
-       const char *dname;
+       const char *dname = NULL;
+       char *talloced = NULL;
        SMB_STRUCT_STAT st;
        struct smb_Dir *dir_hnd = OpenDir(talloc_tos(), conn, dirname,
                                          NULL, 0);
@@ -1332,15 +1543,17 @@ NTSTATUS can_delete_directory(struct connection_struct *conn,
                return map_nt_error_from_unix(errno);
        }
 
-       while ((dname = ReadDirName(dir_hnd, &dirpos, &st))) {
+       while ((dname = ReadDirName(dir_hnd, &dirpos, &st, &talloced))) {
                /* Quick check for "." and ".." */
                if (dname[0] == '.') {
                        if (!dname[1] || (dname[1] == '.' && !dname[2])) {
+                               TALLOC_FREE(talloced);
                                continue;
                        }
                }
 
                if (!is_visible_file(conn, dirname, dname, &st, True)) {
+                       TALLOC_FREE(talloced);
                        continue;
                }
 
@@ -1349,6 +1562,7 @@ NTSTATUS can_delete_directory(struct connection_struct *conn,
                status = NT_STATUS_DIRECTORY_NOT_EMPTY;
                break;
        }
+       TALLOC_FREE(talloced);
        TALLOC_FREE(dir_hnd);
 
        return status;