Removed version number from file header.
[samba.git] / source3 / rpc_parse / parse_spoolss.c
index 24d0fa25383ec840d72dbce22f824d3fbbfd63fd..aa5981f7e9fc4831e9ec4684905ecb2dbb5378f4 100644 (file)
@@ -1,11 +1,11 @@
 /* 
- *  Unix SMB/Netbios implementation.
- *  Version 1.9.
+ *  Unix SMB/CIFS implementation.
  *  RPC Pipe client / server routines
  *  Copyright (C) Andrew Tridgell              1992-2000,
  *  Copyright (C) Luke Kenneth Casson Leighton 1996-2000,
- *  Copyright (C) Jean François Micouleau      1998-2000.
- *  Copyright (C) Gerald Carter                2000
+ *  Copyright (C) Jean François Micouleau      1998-2000,
+ *  Copyright (C) Gerald Carter                2000,
+ *  Copyright (C) Tim Potter                  2001.
  *
  *  This program is free software; you can redistribute it and/or modify
  *  it under the terms of the GNU General Public License as published by
@@ -24,8 +24,6 @@
 
 #include "includes.h"
 
-extern int DEBUGLEVEL;
-
 /*******************************************************************
 return the length of a UNISTR string.
 ********************************************************************/  
@@ -193,6 +191,10 @@ static BOOL smb_io_doc_info_container(char *desc, DOC_INFO_CONTAINER *cont, prs_
 reads or writes an NOTIFY OPTION TYPE structure.
 ********************************************************************/  
 
+/* NOTIFY_OPTION_TYPE and NOTIFY_OPTION_TYPE_DATA are really one
+   structure.  The _TYPE structure is really the deferred referrants (i.e
+   the notify fields array) of the _TYPE structure. -tpot */
+
 static BOOL smb_io_notify_option_type(char *desc, SPOOL_NOTIFY_OPTION_TYPE *type, prs_struct *ps, int depth)
 {
        prs_debug(ps, depth, desc, "smb_io_notify_option_type");
@@ -407,7 +409,7 @@ BOOL smb_io_notify_info_data_strings(char *desc,SPOOL_NOTIFY_INFO_DATA *data,
                                if(!prs_uint8s(True,"string",ps,depth, (uint8 *)&data->notify_data.data.length,x*2)) 
                                        return False;
                        } else {
-                               if(!prs_uint8s(True,"string",ps,depth,(uint8 *)data->notify_data.data.string,x*2))
+                               if(!prs_uint16uni(True,"string",ps,depth,data->notify_data.data.string,x))
                                        return False;
                        }
                } else {
@@ -418,7 +420,7 @@ BOOL smb_io_notify_info_data_strings(char *desc,SPOOL_NOTIFY_INFO_DATA *data,
                        if (!data->notify_data.data.string) 
                                return False;
 
-                       if(!prs_uint16s(True,"string",ps,depth,data->notify_data.data.string,x))
+                       if(!prs_uint16uni(True,"string",ps,depth,data->notify_data.data.string,x))
                                return False;
                }
        }
@@ -539,7 +541,7 @@ static BOOL spool_io_user_level(char *desc, SPOOL_USER_CTR *q_u, prs_struct *ps,
  * on reading allocate memory for the private member
  ********************************************************************/
 
-static BOOL spoolss_io_devmode(char *desc, prs_struct *ps, int depth, DEVICEMODE *devmode)
+BOOL spoolss_io_devmode(char *desc, prs_struct *ps, int depth, DEVICEMODE *devmode)
 {
        prs_debug(ps, depth, desc, "spoolss_io_devmode");
        depth++;
@@ -550,7 +552,7 @@ static BOOL spoolss_io_devmode(char *desc, prs_struct *ps, int depth, DEVICEMODE
                        return False;
        }
 
-       if (!prs_uint16s(True,"devicename", ps, depth, devmode->devicename.buffer, 32))
+       if (!prs_uint16uni(True,"devicename", ps, depth, devmode->devicename.buffer, 32))
                return False;
        if (!prs_uint16("specversion",      ps, depth, &devmode->specversion))
                return False;
@@ -595,7 +597,7 @@ static BOOL spoolss_io_devmode(char *desc, prs_struct *ps, int depth, DEVICEMODE
                        return False;
        }
 
-       if (!prs_uint16s(True, "formname",  ps, depth, devmode->formname.buffer, 32))
+       if (!prs_uint16uni(True, "formname",  ps, depth, devmode->formname.buffer, 32))
                return False;
        if (!prs_uint16("logpixels",        ps, depth, &devmode->logpixels))
                return False;
@@ -635,7 +637,8 @@ static BOOL spoolss_io_devmode(char *desc, prs_struct *ps, int depth, DEVICEMODE
                }
                        
                DEBUG(7,("spoolss_io_devmode: parsing [%d] bytes of private\n",devmode->driverextra));
-               if (!prs_uint8s(True, "private",  ps, depth, devmode->private, devmode->driverextra))
+               if (!prs_uint8s(False, "private",  ps, depth,
+                               devmode->private, devmode->driverextra))
                        return False;
        }
 
@@ -760,7 +763,9 @@ BOOL make_spoolss_q_open_printer_ex(SPOOL_Q_OPEN_PRINTER_EX *q_u,
 /*******************************************************************
  * init a structure.
  ********************************************************************/
+
 BOOL make_spoolss_q_addprinterex(
+       TALLOC_CTX *mem_ctx,
        SPOOL_Q_ADDPRINTEREX *q_u, 
        const char *srv_name,
        const char* clientname, 
@@ -772,6 +777,8 @@ BOOL make_spoolss_q_addprinterex(
        
        if (!ctr) return False;
 
+       ZERO_STRUCTP(q_u);
+
        q_u->server_name_ptr = (srv_name!=NULL)?1:0;
        init_unistr2(&q_u->server_name, srv_name, strlen(srv_name));
 
@@ -779,12 +786,10 @@ BOOL make_spoolss_q_addprinterex(
        
        q_u->info.level = level;
        q_u->info.info_ptr = (ctr->printers_2!=NULL)?1:0;
-       switch (level)
-       {
+       switch (level) {
                case 2:
                        /* init q_u->info.info2 from *info */
-                       if (!make_spool_printer_info_2(&q_u->info.info_2, ctr->printers_2))
-                       {
+                       if (!make_spoolss_printer_info_2(mem_ctx, &q_u->info.info_2, ctr->printers_2)) {
                                DEBUG(0,("make_spoolss_q_addprinterex: Unable to fill SPOOL_Q_ADDPRINTEREX struct!\n"));
                                return False;
                        }
@@ -793,8 +798,6 @@ BOOL make_spoolss_q_addprinterex(
                        break;
        }
 
-       q_u->unk0 = q_u->unk1 = q_u->unk2 = q_u->unk3 = 0;
-
        q_u->user_switch=1;
 
        q_u->user_ctr.level=1;
@@ -817,7 +820,8 @@ BOOL make_spoolss_q_addprinterex(
 create a SPOOL_PRINTER_INFO_2 stuct from a PRINTER_INFO_2 struct
 *******************************************************************/
 
-BOOL make_spool_printer_info_2(
+BOOL make_spoolss_printer_info_2(
+       TALLOC_CTX *mem_ctx,
        SPOOL_PRINTER_INFO_LEVEL_2 **spool_info2, 
        PRINTER_INFO_2 *info
 )
@@ -826,10 +830,8 @@ BOOL make_spool_printer_info_2(
        SPOOL_PRINTER_INFO_LEVEL_2 *inf;
 
        /* allocate the necessary memory */
-       inf = (SPOOL_PRINTER_INFO_LEVEL_2*)malloc(sizeof(SPOOL_PRINTER_INFO_LEVEL_2));
-       if (spool_info2 == NULL)
-       {
-               DEBUG(0,("make_spool_printer_info_2: Unable to allocate SPOOL_PRINTER_INFO_LEVEL_2 sruct!\n"));
+       if (!(inf=(SPOOL_PRINTER_INFO_LEVEL_2*)talloc(mem_ctx, sizeof(SPOOL_PRINTER_INFO_LEVEL_2)))) {
+               DEBUG(0,("make_spoolss_printer_info_2: Unable to allocate SPOOL_PRINTER_INFO_LEVEL_2 sruct!\n"));
                return False;
        }
        
@@ -865,7 +867,6 @@ BOOL make_spool_printer_info_2(
        init_unistr2_from_unistr(&inf->datatype,        &info->datatype);
        init_unistr2_from_unistr(&inf->parameters,      &info->parameters);
        init_unistr2_from_unistr(&inf->datatype,        &info->datatype);
-       inf->secdesc    = NULL;
 
        *spool_info2 = inf;
 
@@ -907,6 +908,31 @@ BOOL spoolss_io_q_open_printer_ex(char *desc, SPOOL_Q_OPEN_PRINTER_EX *q_u, prs_
        return True;
 }
 
+/*******************************************************************
+ * init a structure.
+ ********************************************************************/
+BOOL make_spoolss_q_deleteprinterdriver(
+       TALLOC_CTX *mem_ctx,
+       SPOOL_Q_DELETEPRINTERDRIVER *q_u, 
+       const char *server,
+       const char* arch, 
+       const char* driver 
+)
+{
+       DEBUG(5,("make_spoolss_q_deleteprinterdriver\n"));
+       
+       q_u->server_ptr = (server!=NULL)?1:0;
+
+       /* these must be NULL terminated or else NT4 will
+          complain about invalid parameters --jerry */
+       init_unistr2(&q_u->server, server, strlen(server)+1);
+       init_unistr2(&q_u->arch, arch, strlen(arch)+1);
+       init_unistr2(&q_u->driver, driver, strlen(driver)+1);
+
+       
+       return True;
+}
+
 /*******************************************************************
  * write a structure.
  * called from static spoolss_r_open_printer_ex (srv_spoolss.c)
@@ -926,7 +952,7 @@ BOOL spoolss_io_r_open_printer_ex(char *desc, SPOOL_R_OPEN_PRINTER_EX *r_u, prs_
        if (!smb_io_pol_hnd("printer handle",&(r_u->handle),ps,depth))
                return False;
 
-       if (!prs_uint32("status code", ps, depth, &(r_u->status)))
+       if (!prs_werror("status code", ps, depth, &(r_u->status)))
                return False;
 
        return True;
@@ -1014,7 +1040,7 @@ BOOL spoolss_io_r_deleteprinterdata(char *desc, SPOOL_R_DELETEPRINTERDATA *r_u,
 {
        prs_debug(ps, depth, desc, "spoolss_io_r_deleteprinterdata");
        depth++;
-       if(!prs_uint32("status", ps, depth, &r_u->status))
+       if(!prs_werror("status", ps, depth, &r_u->status))
                return False;
 
        return True;
@@ -1048,7 +1074,7 @@ BOOL spoolss_io_r_getprinterdata(char *desc, SPOOL_R_GETPRINTERDATA *r_u, prs_st
        
        if (!prs_uint32("needed", ps, depth, &r_u->needed))
                return False;
-       if (!prs_uint32("status", ps, depth, &r_u->status))
+       if (!prs_werror("status", ps, depth, &r_u->status))
                return False;
                
        return True;
@@ -1100,7 +1126,7 @@ BOOL spoolss_io_r_abortprinter(char *desc, SPOOL_R_ABORTPRINTER *r_u, prs_struct
 {
        prs_debug(ps, depth, desc, "spoolss_io_r_abortprinter");
        depth++;
-       if(!prs_uint32("status", ps, depth, &r_u->status))
+       if(!prs_werror("status", ps, depth, &r_u->status))
                return False;
 
        return True;
@@ -1144,12 +1170,64 @@ BOOL spoolss_io_r_deleteprinter(char *desc, SPOOL_R_DELETEPRINTER *r_u, prs_stru
 
        if (!smb_io_pol_hnd("printer handle",&r_u->handle,ps,depth))
                return False;
-       if (!prs_uint32("status", ps, depth, &r_u->status))
+       if (!prs_werror("status", ps, depth, &r_u->status))
                return False;
        
        return True;
 }
 
+
+/*******************************************************************
+ * read a structure.
+ * called from api_spoolss_deleteprinterdriver (srv_spoolss.c)
+ * called from spoolss_deleteprinterdriver (cli_spoolss.c)
+ ********************************************************************/
+
+BOOL spoolss_io_q_deleteprinterdriver(char *desc, SPOOL_Q_DELETEPRINTERDRIVER *q_u, prs_struct *ps, int depth)
+{
+       if (q_u == NULL) return False;
+
+       prs_debug(ps, depth, desc, "spoolss_io_q_deleteprinterdriver");
+       depth++;
+
+       if (!prs_align(ps))
+               return False;
+
+       if(!prs_uint32("server_ptr", ps, depth, &q_u->server_ptr))
+               return False;           
+       if(!smb_io_unistr2("server", &q_u->server, q_u->server_ptr, ps, depth))
+               return False;
+       if(!smb_io_unistr2("arch", &q_u->arch, True, ps, depth))
+               return False;
+       if(!smb_io_unistr2("driver", &q_u->driver, True, ps, depth))
+               return False;
+
+
+       return True;
+}
+
+
+/*******************************************************************
+ * write a structure.
+ ********************************************************************/
+BOOL spoolss_io_r_deleteprinterdriver(char *desc, SPOOL_R_DELETEPRINTERDRIVER *r_u, prs_struct *ps, int depth)
+{
+       if (r_u == NULL) return False;
+
+       prs_debug(ps, depth, desc, "spoolss_io_r_deleteprinterdriver");
+       depth++;
+
+       if (!prs_align(ps))
+               return False;
+
+       if (!prs_werror("status", ps, depth, &r_u->status))
+               return False;
+
+       return True;
+}
+
+
+
 /*******************************************************************
  * read a structure.
  * called from static spoolss_q_closeprinter (srv_spoolss.c)
@@ -1188,7 +1266,7 @@ BOOL spoolss_io_r_closeprinter(char *desc, SPOOL_R_CLOSEPRINTER *r_u, prs_struct
 
        if (!smb_io_pol_hnd("printer handle",&r_u->handle,ps,depth))
                return False;
-       if (!prs_uint32("status", ps, depth, &r_u->status))
+       if (!prs_werror("status", ps, depth, &r_u->status))
                return False;
        
        return True;
@@ -1229,7 +1307,7 @@ BOOL spoolss_io_r_startdocprinter(char *desc, SPOOL_R_STARTDOCPRINTER *r_u, prs_
        depth++;
        if(!prs_uint32("jobid", ps, depth, &r_u->jobid))
                return False;
-       if(!prs_uint32("status", ps, depth, &r_u->status))
+       if(!prs_werror("status", ps, depth, &r_u->status))
                return False;
 
        return True;
@@ -1265,7 +1343,7 @@ BOOL spoolss_io_r_enddocprinter(char *desc, SPOOL_R_ENDDOCPRINTER *r_u, prs_stru
 {
        prs_debug(ps, depth, desc, "spoolss_io_r_enddocprinter");
        depth++;
-       if(!prs_uint32("status", ps, depth, &r_u->status))
+       if(!prs_werror("status", ps, depth, &r_u->status))
                return False;
 
        return True;
@@ -1301,7 +1379,7 @@ BOOL spoolss_io_r_startpageprinter(char *desc, SPOOL_R_STARTPAGEPRINTER *r_u, pr
 {
        prs_debug(ps, depth, desc, "spoolss_io_r_startpageprinter");
        depth++;
-       if(!prs_uint32("status", ps, depth, &r_u->status))
+       if(!prs_werror("status", ps, depth, &r_u->status))
                return False;
 
        return True;
@@ -1337,7 +1415,7 @@ BOOL spoolss_io_r_endpageprinter(char *desc, SPOOL_R_ENDPAGEPRINTER *r_u, prs_st
 {
        prs_debug(ps, depth, desc, "spoolss_io_r_endpageprinter");
        depth++;
-       if(!prs_uint32("status", ps, depth, &r_u->status))
+       if(!prs_werror("status", ps, depth, &r_u->status))
                return False;
 
        return True;
@@ -1391,7 +1469,7 @@ BOOL spoolss_io_r_writeprinter(char *desc, SPOOL_R_WRITEPRINTER *r_u, prs_struct
        depth++;
        if(!prs_uint32("buffer_written", ps, depth, &r_u->buffer_written))
                return False;
-       if(!prs_uint32("status", ps, depth, &r_u->status))
+       if(!prs_werror("status", ps, depth, &r_u->status))
                return False;
 
        return True;
@@ -1453,7 +1531,7 @@ BOOL spoolss_io_r_rffpcnex(char *desc, SPOOL_R_RFFPCNEX *r_u, prs_struct *ps, in
        prs_debug(ps, depth, desc, "spoolss_io_r_rffpcnex");
        depth++;
 
-       if(!prs_uint32("status", ps, depth, &r_u->status))
+       if(!prs_werror("status", ps, depth, &r_u->status))
                return False;
 
        return True;
@@ -1515,7 +1593,7 @@ BOOL spoolss_io_r_rfnpcnex(char *desc, SPOOL_R_RFNPCNEX *r_u, prs_struct *ps, in
        
        if(!prs_align(ps))
                return False;
-       if(!prs_uint32("status", ps, depth, &r_u->status))
+       if(!prs_werror("status", ps, depth, &r_u->status))
                return False;
 
        return True;
@@ -1638,7 +1716,7 @@ static BOOL spoolss_smb_io_unistr(char *desc, UNISTR *uni, prs_struct *ps, int d
  *
  ********************************************************************/
 
-static BOOL new_smb_io_relstr(char *desc, NEW_BUFFER *buffer, int depth, UNISTR *string)
+static BOOL smb_io_relstr(char *desc, NEW_BUFFER *buffer, int depth, UNISTR *string)
 {
        prs_struct *ps=&buffer->prs;
        
@@ -1691,7 +1769,7 @@ static BOOL new_smb_io_relstr(char *desc, NEW_BUFFER *buffer, int depth, UNISTR
  * used by 2 RPC structs
  ********************************************************************/
 
-static BOOL new_smb_io_relarraystr(char *desc, NEW_BUFFER *buffer, int depth, uint16 **string)
+static BOOL smb_io_relarraystr(char *desc, NEW_BUFFER *buffer, int depth, uint16 **string)
 {
        UNISTR chaine;
        
@@ -1729,19 +1807,19 @@ static BOOL new_smb_io_relarraystr(char *desc, NEW_BUFFER *buffer, int depth, ui
                        buffer->string_at_end -= (q-p+1)*sizeof(uint16);
 
                        if(!prs_set_offset(ps, buffer->string_at_end)) {
-                               free(chaine.buffer);
+                               SAFE_FREE(chaine.buffer);
                                return False;
                        }
 
                        /* write the string */
                        if (!spoolss_smb_io_unistr(desc, &chaine, ps, depth)) {
-                               free(chaine.buffer);
+                               SAFE_FREE(chaine.buffer);
                                return False;
                        }
                        q++;
                        p=q;
 
-                       free(chaine.buffer);
+                       SAFE_FREE(chaine.buffer);
                }
                
                if(!prs_set_offset(ps, struct_offset))
@@ -1783,12 +1861,17 @@ static BOOL new_smb_io_relarraystr(char *desc, NEW_BUFFER *buffer, int depth, ui
                           an extra NULL for termination */
                        if (l_chaine > 0)
                        {
+                               uint16 *tc2;
+                       
                                realloc_size = (l_chaine2+l_chaine+2)*sizeof(uint16);
 
                                /* Yes this should be realloc - it's freed below. JRA */
 
-                               if((chaine2=(uint16 *)Realloc(chaine2, realloc_size)) == NULL)
+                               if((tc2=(uint16 *)Realloc(chaine2, realloc_size)) == NULL) {
+                                       SAFE_FREE(chaine2);
                                        return False;
+                               }
+                               else chaine2 = tc2;
                                memcpy(chaine2+l_chaine2, chaine.buffer, (l_chaine+1)*sizeof(uint16));
                                l_chaine2+=l_chaine+1;
                        }
@@ -1801,7 +1884,7 @@ static BOOL new_smb_io_relarraystr(char *desc, NEW_BUFFER *buffer, int depth, ui
                {
                        chaine2[l_chaine2] = '\0';
                        *string=(uint16 *)talloc_memdup(prs_get_mem_context(ps),chaine2,realloc_size);
-                       free(chaine2);
+                       SAFE_FREE(chaine2);
                }
 
                if(!prs_set_offset(ps, old_offset))
@@ -1814,11 +1897,11 @@ static BOOL new_smb_io_relarraystr(char *desc, NEW_BUFFER *buffer, int depth, ui
  Parse a DEVMODE structure and its relative pointer.
 ********************************************************************/
 
-static BOOL new_smb_io_relsecdesc(char *desc, NEW_BUFFER *buffer, int depth, SEC_DESC **secdesc)
+static BOOL smb_io_relsecdesc(char *desc, NEW_BUFFER *buffer, int depth, SEC_DESC **secdesc)
 {
        prs_struct *ps= &buffer->prs;
 
-       prs_debug(ps, depth, desc, "new_smb_io_relsecdesc");
+       prs_debug(ps, depth, desc, "smb_io_relsecdesc");
        depth++;
 
        if (MARSHALLING(ps)) {
@@ -1875,11 +1958,11 @@ static BOOL new_smb_io_relsecdesc(char *desc, NEW_BUFFER *buffer, int depth, SEC
  Parse a DEVMODE structure and its relative pointer.
 ********************************************************************/
 
-static BOOL new_smb_io_reldevmode(char *desc, NEW_BUFFER *buffer, int depth, DEVICEMODE **devmode)
+static BOOL smb_io_reldevmode(char *desc, NEW_BUFFER *buffer, int depth, DEVICEMODE **devmode)
 {
        prs_struct *ps=&buffer->prs;
 
-       prs_debug(ps, depth, desc, "new_smb_io_reldevmode");
+       prs_debug(ps, depth, desc, "smb_io_reldevmode");
        depth++;
 
        if (MARSHALLING(ps)) {
@@ -1939,7 +2022,7 @@ static BOOL new_smb_io_reldevmode(char *desc, NEW_BUFFER *buffer, int depth, DEV
  Parse a PRINTER_INFO_0 structure.
 ********************************************************************/  
 
-BOOL new_smb_io_printer_info_0(char *desc, NEW_BUFFER *buffer, PRINTER_INFO_0 *info, int depth)
+BOOL smb_io_printer_info_0(char *desc, NEW_BUFFER *buffer, PRINTER_INFO_0 *info, int depth)
 {
        prs_struct *ps=&buffer->prs;
 
@@ -1948,9 +2031,9 @@ BOOL new_smb_io_printer_info_0(char *desc, NEW_BUFFER *buffer, PRINTER_INFO_0 *i
        
        buffer->struct_start=prs_offset(ps);
 
-       if (!new_smb_io_relstr("printername", buffer, depth, &info->printername))
+       if (!smb_io_relstr("printername", buffer, depth, &info->printername))
                return False;
-       if (!new_smb_io_relstr("servername", buffer, depth, &info->servername))
+       if (!smb_io_relstr("servername", buffer, depth, &info->servername))
                return False;
        
        if(!prs_uint32("cjobs", ps, depth, &info->cjobs))
@@ -2040,22 +2123,22 @@ BOOL new_smb_io_printer_info_0(char *desc, NEW_BUFFER *buffer, PRINTER_INFO_0 *i
  Parse a PRINTER_INFO_1 structure.
 ********************************************************************/  
 
-BOOL new_smb_io_printer_info_1(char *desc, NEW_BUFFER *buffer, PRINTER_INFO_1 *info, int depth)
+BOOL smb_io_printer_info_1(char *desc, NEW_BUFFER *buffer, PRINTER_INFO_1 *info, int depth)
 {
        prs_struct *ps=&buffer->prs;
 
-       prs_debug(ps, depth, desc, "new_smb_io_printer_info_1");
+       prs_debug(ps, depth, desc, "smb_io_printer_info_1");
        depth++;        
        
        buffer->struct_start=prs_offset(ps);
 
        if (!prs_uint32("flags", ps, depth, &info->flags))
                return False;
-       if (!new_smb_io_relstr("description", buffer, depth, &info->description))
+       if (!smb_io_relstr("description", buffer, depth, &info->description))
                return False;
-       if (!new_smb_io_relstr("name", buffer, depth, &info->name))
+       if (!smb_io_relstr("name", buffer, depth, &info->name))
                return False;
-       if (!new_smb_io_relstr("comment", buffer, depth, &info->comment))
+       if (!smb_io_relstr("comment", buffer, depth, &info->comment))
                return False;   
 
        return True;
@@ -2065,44 +2148,44 @@ BOOL new_smb_io_printer_info_1(char *desc, NEW_BUFFER *buffer, PRINTER_INFO_1 *i
  Parse a PRINTER_INFO_2 structure.
 ********************************************************************/  
 
-BOOL new_smb_io_printer_info_2(char *desc, NEW_BUFFER *buffer, PRINTER_INFO_2 *info, int depth)
+BOOL smb_io_printer_info_2(char *desc, NEW_BUFFER *buffer, PRINTER_INFO_2 *info, int depth)
 {
        prs_struct *ps=&buffer->prs;
 
-       prs_debug(ps, depth, desc, "new_smb_io_printer_info_2");
+       prs_debug(ps, depth, desc, "smb_io_printer_info_2");
        depth++;        
        
        buffer->struct_start=prs_offset(ps);
        
-       if (!new_smb_io_relstr("servername", buffer, depth, &info->servername))
+       if (!smb_io_relstr("servername", buffer, depth, &info->servername))
                return False;
-       if (!new_smb_io_relstr("printername", buffer, depth, &info->printername))
+       if (!smb_io_relstr("printername", buffer, depth, &info->printername))
                return False;
-       if (!new_smb_io_relstr("sharename", buffer, depth, &info->sharename))
+       if (!smb_io_relstr("sharename", buffer, depth, &info->sharename))
                return False;
-       if (!new_smb_io_relstr("portname", buffer, depth, &info->portname))
+       if (!smb_io_relstr("portname", buffer, depth, &info->portname))
                return False;
-       if (!new_smb_io_relstr("drivername", buffer, depth, &info->drivername))
+       if (!smb_io_relstr("drivername", buffer, depth, &info->drivername))
                return False;
-       if (!new_smb_io_relstr("comment", buffer, depth, &info->comment))
+       if (!smb_io_relstr("comment", buffer, depth, &info->comment))
                return False;
-       if (!new_smb_io_relstr("location", buffer, depth, &info->location))
+       if (!smb_io_relstr("location", buffer, depth, &info->location))
                return False;
 
        /* NT parses the DEVMODE at the end of the struct */
-       if (!new_smb_io_reldevmode("devmode", buffer, depth, &info->devmode))
+       if (!smb_io_reldevmode("devmode", buffer, depth, &info->devmode))
                return False;
        
-       if (!new_smb_io_relstr("sepfile", buffer, depth, &info->sepfile))
+       if (!smb_io_relstr("sepfile", buffer, depth, &info->sepfile))
                return False;
-       if (!new_smb_io_relstr("printprocessor", buffer, depth, &info->printprocessor))
+       if (!smb_io_relstr("printprocessor", buffer, depth, &info->printprocessor))
                return False;
-       if (!new_smb_io_relstr("datatype", buffer, depth, &info->datatype))
+       if (!smb_io_relstr("datatype", buffer, depth, &info->datatype))
                return False;
-       if (!new_smb_io_relstr("parameters", buffer, depth, &info->parameters))
+       if (!smb_io_relstr("parameters", buffer, depth, &info->parameters))
                return False;
 
-       if (!new_smb_io_relsecdesc("secdesc", buffer, depth, &info->secdesc))
+       if (!smb_io_relsecdesc("secdesc", buffer, depth, &info->secdesc))
                return False;
 
        if (!prs_uint32("attributes", ps, depth, &info->attributes))
@@ -2136,11 +2219,11 @@ BOOL new_smb_io_printer_info_2(char *desc, NEW_BUFFER *buffer, PRINTER_INFO_2 *i
  Parse a PRINTER_INFO_3 structure.
 ********************************************************************/  
 
-BOOL new_smb_io_printer_info_3(char *desc, NEW_BUFFER *buffer, PRINTER_INFO_3 *info, int depth)
+BOOL smb_io_printer_info_3(char *desc, NEW_BUFFER *buffer, PRINTER_INFO_3 *info, int depth)
 {
        prs_struct *ps=&buffer->prs;
 
-       prs_debug(ps, depth, desc, "new_smb_io_printer_info_3");
+       prs_debug(ps, depth, desc, "smb_io_printer_info_3");
        depth++;        
        
        buffer->struct_start=prs_offset(ps);
@@ -2153,20 +2236,68 @@ BOOL new_smb_io_printer_info_3(char *desc, NEW_BUFFER *buffer, PRINTER_INFO_3 *i
        return True;
 }
 
+/*******************************************************************
+ Parse a PRINTER_INFO_4 structure.
+********************************************************************/  
+
+BOOL smb_io_printer_info_4(char *desc, NEW_BUFFER *buffer, PRINTER_INFO_4 *info, int depth)
+{
+       prs_struct *ps=&buffer->prs;
+
+       prs_debug(ps, depth, desc, "smb_io_printer_info_4");
+       depth++;        
+       
+       buffer->struct_start=prs_offset(ps);
+       
+       if (!smb_io_relstr("printername", buffer, depth, &info->printername))
+               return False;
+       if (!smb_io_relstr("servername", buffer, depth, &info->servername))
+               return False;
+       if (!prs_uint32("attributes", ps, depth, &info->attributes))
+               return False;
+       return True;
+}
+
+/*******************************************************************
+ Parse a PRINTER_INFO_5 structure.
+********************************************************************/  
+
+BOOL smb_io_printer_info_5(char *desc, NEW_BUFFER *buffer, PRINTER_INFO_5 *info, int depth)
+{
+       prs_struct *ps=&buffer->prs;
+
+       prs_debug(ps, depth, desc, "smb_io_printer_info_5");
+       depth++;        
+       
+       buffer->struct_start=prs_offset(ps);
+       
+       if (!smb_io_relstr("printername", buffer, depth, &info->printername))
+               return False;
+       if (!smb_io_relstr("portname", buffer, depth, &info->portname))
+               return False;
+       if (!prs_uint32("attributes", ps, depth, &info->attributes))
+               return False;
+       if (!prs_uint32("device_not_selected_timeout", ps, depth, &info->device_not_selected_timeout))
+               return False;
+       if (!prs_uint32("transmission_retry_timeout", ps, depth, &info->transmission_retry_timeout))
+               return False;
+       return True;
+}
+
 /*******************************************************************
  Parse a PORT_INFO_1 structure.
 ********************************************************************/  
 
-BOOL new_smb_io_port_info_1(char *desc, NEW_BUFFER *buffer, PORT_INFO_1 *info, int depth)
+BOOL smb_io_port_info_1(char *desc, NEW_BUFFER *buffer, PORT_INFO_1 *info, int depth)
 {
        prs_struct *ps=&buffer->prs;
 
-       prs_debug(ps, depth, desc, "new_smb_io_port_info_1");
+       prs_debug(ps, depth, desc, "smb_io_port_info_1");
        depth++;        
        
        buffer->struct_start=prs_offset(ps);
        
-       if (!new_smb_io_relstr("port_name", buffer, depth, &info->port_name))
+       if (!smb_io_relstr("port_name", buffer, depth, &info->port_name))
                return False;
 
        return True;
@@ -2176,20 +2307,20 @@ BOOL new_smb_io_port_info_1(char *desc, NEW_BUFFER *buffer, PORT_INFO_1 *info, i
  Parse a PORT_INFO_2 structure.
 ********************************************************************/  
 
-BOOL new_smb_io_port_info_2(char *desc, NEW_BUFFER *buffer, PORT_INFO_2 *info, int depth)
+BOOL smb_io_port_info_2(char *desc, NEW_BUFFER *buffer, PORT_INFO_2 *info, int depth)
 {
        prs_struct *ps=&buffer->prs;
 
-       prs_debug(ps, depth, desc, "new_smb_io_port_info_2");
+       prs_debug(ps, depth, desc, "smb_io_port_info_2");
        depth++;        
        
        buffer->struct_start=prs_offset(ps);
        
-       if (!new_smb_io_relstr("port_name", buffer, depth, &info->port_name))
+       if (!smb_io_relstr("port_name", buffer, depth, &info->port_name))
                return False;
-       if (!new_smb_io_relstr("monitor_name", buffer, depth, &info->monitor_name))
+       if (!smb_io_relstr("monitor_name", buffer, depth, &info->monitor_name))
                return False;
-       if (!new_smb_io_relstr("description", buffer, depth, &info->description))
+       if (!smb_io_relstr("description", buffer, depth, &info->description))
                return False;
        if (!prs_uint32("port_type", ps, depth, &info->port_type))
                return False;
@@ -2203,16 +2334,16 @@ BOOL new_smb_io_port_info_2(char *desc, NEW_BUFFER *buffer, PORT_INFO_2 *info, i
  Parse a DRIVER_INFO_1 structure.
 ********************************************************************/
 
-BOOL new_smb_io_printer_driver_info_1(char *desc, NEW_BUFFER *buffer, DRIVER_INFO_1 *info, int depth) 
+BOOL smb_io_printer_driver_info_1(char *desc, NEW_BUFFER *buffer, DRIVER_INFO_1 *info, int depth) 
 {
        prs_struct *ps=&buffer->prs;
 
-       prs_debug(ps, depth, desc, "new_smb_io_printer_driver_info_1");
+       prs_debug(ps, depth, desc, "smb_io_printer_driver_info_1");
        depth++;        
        
        buffer->struct_start=prs_offset(ps);
 
-       if (!new_smb_io_relstr("name", buffer, depth, &info->name))
+       if (!smb_io_relstr("name", buffer, depth, &info->name))
                return False;
 
        return True;
@@ -2222,26 +2353,26 @@ BOOL new_smb_io_printer_driver_info_1(char *desc, NEW_BUFFER *buffer, DRIVER_INF
  Parse a DRIVER_INFO_2 structure.
 ********************************************************************/
 
-BOOL new_smb_io_printer_driver_info_2(char *desc, NEW_BUFFER *buffer, DRIVER_INFO_2 *info, int depth) 
+BOOL smb_io_printer_driver_info_2(char *desc, NEW_BUFFER *buffer, DRIVER_INFO_2 *info, int depth) 
 {
        prs_struct *ps=&buffer->prs;
 
-       prs_debug(ps, depth, desc, "new_smb_io_printer_driver_info_2");
+       prs_debug(ps, depth, desc, "smb_io_printer_driver_info_2");
        depth++;        
        
        buffer->struct_start=prs_offset(ps);
 
        if (!prs_uint32("version", ps, depth, &info->version))
                return False;
-       if (!new_smb_io_relstr("name", buffer, depth, &info->name))
+       if (!smb_io_relstr("name", buffer, depth, &info->name))
                return False;
-       if (!new_smb_io_relstr("architecture", buffer, depth, &info->architecture))
+       if (!smb_io_relstr("architecture", buffer, depth, &info->architecture))
                return False;
-       if (!new_smb_io_relstr("driverpath", buffer, depth, &info->driverpath))
+       if (!smb_io_relstr("driverpath", buffer, depth, &info->driverpath))
                return False;
-       if (!new_smb_io_relstr("datafile", buffer, depth, &info->datafile))
+       if (!smb_io_relstr("datafile", buffer, depth, &info->datafile))
                return False;
-       if (!new_smb_io_relstr("configfile", buffer, depth, &info->configfile))
+       if (!smb_io_relstr("configfile", buffer, depth, &info->configfile))
                return False;
 
        return True;
@@ -2251,36 +2382,36 @@ BOOL new_smb_io_printer_driver_info_2(char *desc, NEW_BUFFER *buffer, DRIVER_INF
  Parse a DRIVER_INFO_3 structure.
 ********************************************************************/
 
-BOOL new_smb_io_printer_driver_info_3(char *desc, NEW_BUFFER *buffer, DRIVER_INFO_3 *info, int depth)
+BOOL smb_io_printer_driver_info_3(char *desc, NEW_BUFFER *buffer, DRIVER_INFO_3 *info, int depth)
 {
        prs_struct *ps=&buffer->prs;
 
-       prs_debug(ps, depth, desc, "new_smb_io_printer_driver_info_3");
+       prs_debug(ps, depth, desc, "smb_io_printer_driver_info_3");
        depth++;        
        
        buffer->struct_start=prs_offset(ps);
 
        if (!prs_uint32("version", ps, depth, &info->version))
                return False;
-       if (!new_smb_io_relstr("name", buffer, depth, &info->name))
+       if (!smb_io_relstr("name", buffer, depth, &info->name))
                return False;
-       if (!new_smb_io_relstr("architecture", buffer, depth, &info->architecture))
+       if (!smb_io_relstr("architecture", buffer, depth, &info->architecture))
                return False;
-       if (!new_smb_io_relstr("driverpath", buffer, depth, &info->driverpath))
+       if (!smb_io_relstr("driverpath", buffer, depth, &info->driverpath))
                return False;
-       if (!new_smb_io_relstr("datafile", buffer, depth, &info->datafile))
+       if (!smb_io_relstr("datafile", buffer, depth, &info->datafile))
                return False;
-       if (!new_smb_io_relstr("configfile", buffer, depth, &info->configfile))
+       if (!smb_io_relstr("configfile", buffer, depth, &info->configfile))
                return False;
-       if (!new_smb_io_relstr("helpfile", buffer, depth, &info->helpfile))
+       if (!smb_io_relstr("helpfile", buffer, depth, &info->helpfile))
                return False;
 
-       if (!new_smb_io_relarraystr("dependentfiles", buffer, depth, &info->dependentfiles))
+       if (!smb_io_relarraystr("dependentfiles", buffer, depth, &info->dependentfiles))
                return False;
 
-       if (!new_smb_io_relstr("monitorname", buffer, depth, &info->monitorname))
+       if (!smb_io_relstr("monitorname", buffer, depth, &info->monitorname))
                return False;
-       if (!new_smb_io_relstr("defaultdatatype", buffer, depth, &info->defaultdatatype))
+       if (!smb_io_relstr("defaultdatatype", buffer, depth, &info->defaultdatatype))
                return False;
 
        return True;
@@ -2290,39 +2421,39 @@ BOOL new_smb_io_printer_driver_info_3(char *desc, NEW_BUFFER *buffer, DRIVER_INF
  Parse a DRIVER_INFO_6 structure.
 ********************************************************************/
 
-BOOL new_smb_io_printer_driver_info_6(char *desc, NEW_BUFFER *buffer, DRIVER_INFO_6 *info, int depth)
+BOOL smb_io_printer_driver_info_6(char *desc, NEW_BUFFER *buffer, DRIVER_INFO_6 *info, int depth)
 {
        prs_struct *ps=&buffer->prs;
 
-       prs_debug(ps, depth, desc, "new_smb_io_printer_driver_info_6");
+       prs_debug(ps, depth, desc, "smb_io_printer_driver_info_6");
        depth++;        
        
        buffer->struct_start=prs_offset(ps);
 
        if (!prs_uint32("version", ps, depth, &info->version))
                return False;
-       if (!new_smb_io_relstr("name", buffer, depth, &info->name))
+       if (!smb_io_relstr("name", buffer, depth, &info->name))
                return False;
-       if (!new_smb_io_relstr("architecture", buffer, depth, &info->architecture))
+       if (!smb_io_relstr("architecture", buffer, depth, &info->architecture))
                return False;
-       if (!new_smb_io_relstr("driverpath", buffer, depth, &info->driverpath))
+       if (!smb_io_relstr("driverpath", buffer, depth, &info->driverpath))
                return False;
-       if (!new_smb_io_relstr("datafile", buffer, depth, &info->datafile))
+       if (!smb_io_relstr("datafile", buffer, depth, &info->datafile))
                return False;
-       if (!new_smb_io_relstr("configfile", buffer, depth, &info->configfile))
+       if (!smb_io_relstr("configfile", buffer, depth, &info->configfile))
                return False;
-       if (!new_smb_io_relstr("helpfile", buffer, depth, &info->helpfile))
+       if (!smb_io_relstr("helpfile", buffer, depth, &info->helpfile))
                return False;
 
-       if (!new_smb_io_relarraystr("dependentfiles", buffer, depth, &info->dependentfiles))
+       if (!smb_io_relarraystr("dependentfiles", buffer, depth, &info->dependentfiles))
                return False;
 
-       if (!new_smb_io_relstr("monitorname", buffer, depth, &info->monitorname))
+       if (!smb_io_relstr("monitorname", buffer, depth, &info->monitorname))
                return False;
-       if (!new_smb_io_relstr("defaultdatatype", buffer, depth, &info->defaultdatatype))
+       if (!smb_io_relstr("defaultdatatype", buffer, depth, &info->defaultdatatype))
                return False;
 
-       if (!new_smb_io_relarraystr("previousdrivernames", buffer, depth, &info->previousdrivernames))
+       if (!smb_io_relarraystr("previousdrivernames", buffer, depth, &info->previousdrivernames))
                return False;
 
        if (!prs_uint32("date.low", ps, depth, &info->driver_date.low))
@@ -2339,13 +2470,13 @@ BOOL new_smb_io_printer_driver_info_6(char *desc, NEW_BUFFER *buffer, DRIVER_INF
        if (!prs_uint32("driver_version_high", ps, depth, &info->driver_version_high))
                return False;
 
-       if (!new_smb_io_relstr("mfgname", buffer, depth, &info->mfgname))
+       if (!smb_io_relstr("mfgname", buffer, depth, &info->mfgname))
                return False;
-       if (!new_smb_io_relstr("oem_url", buffer, depth, &info->oem_url))
+       if (!smb_io_relstr("oem_url", buffer, depth, &info->oem_url))
                return False;
-       if (!new_smb_io_relstr("hardware_id", buffer, depth, &info->hardware_id))
+       if (!smb_io_relstr("hardware_id", buffer, depth, &info->hardware_id))
                return False;
-       if (!new_smb_io_relstr("provider", buffer, depth, &info->provider))
+       if (!smb_io_relstr("provider", buffer, depth, &info->provider))
                return False;
        
        return True;
@@ -2355,28 +2486,28 @@ BOOL new_smb_io_printer_driver_info_6(char *desc, NEW_BUFFER *buffer, DRIVER_INF
  Parse a JOB_INFO_1 structure.
 ********************************************************************/  
 
-BOOL new_smb_io_job_info_1(char *desc, NEW_BUFFER *buffer, JOB_INFO_1 *info, int depth)
+BOOL smb_io_job_info_1(char *desc, NEW_BUFFER *buffer, JOB_INFO_1 *info, int depth)
 {
        prs_struct *ps=&buffer->prs;
 
-       prs_debug(ps, depth, desc, "new_smb_io_job_info_1");
+       prs_debug(ps, depth, desc, "smb_io_job_info_1");
        depth++;        
        
        buffer->struct_start=prs_offset(ps);
 
        if (!prs_uint32("jobid", ps, depth, &info->jobid))
                return False;
-       if (!new_smb_io_relstr("printername", buffer, depth, &info->printername))
+       if (!smb_io_relstr("printername", buffer, depth, &info->printername))
                return False;
-       if (!new_smb_io_relstr("machinename", buffer, depth, &info->machinename))
+       if (!smb_io_relstr("machinename", buffer, depth, &info->machinename))
                return False;
-       if (!new_smb_io_relstr("username", buffer, depth, &info->username))
+       if (!smb_io_relstr("username", buffer, depth, &info->username))
                return False;
-       if (!new_smb_io_relstr("document", buffer, depth, &info->document))
+       if (!smb_io_relstr("document", buffer, depth, &info->document))
                return False;
-       if (!new_smb_io_relstr("datatype", buffer, depth, &info->datatype))
+       if (!smb_io_relstr("datatype", buffer, depth, &info->datatype))
                return False;
-       if (!new_smb_io_relstr("text_status", buffer, depth, &info->text_status))
+       if (!smb_io_relstr("text_status", buffer, depth, &info->text_status))
                return False;
        if (!prs_uint32("status", ps, depth, &info->status))
                return False;
@@ -2398,40 +2529,40 @@ BOOL new_smb_io_job_info_1(char *desc, NEW_BUFFER *buffer, JOB_INFO_1 *info, int
  Parse a JOB_INFO_2 structure.
 ********************************************************************/  
 
-BOOL new_smb_io_job_info_2(char *desc, NEW_BUFFER *buffer, JOB_INFO_2 *info, int depth)
+BOOL smb_io_job_info_2(char *desc, NEW_BUFFER *buffer, JOB_INFO_2 *info, int depth)
 {      
-       uint pipo=0;
+       uint32 pipo=0;
        prs_struct *ps=&buffer->prs;
        
-       prs_debug(ps, depth, desc, "new_smb_io_job_info_2");
+       prs_debug(ps, depth, desc, "smb_io_job_info_2");
        depth++;        
 
        buffer->struct_start=prs_offset(ps);
        
        if (!prs_uint32("jobid",ps, depth, &info->jobid))
                return False;
-       if (!new_smb_io_relstr("printername", buffer, depth, &info->printername))
+       if (!smb_io_relstr("printername", buffer, depth, &info->printername))
                return False;
-       if (!new_smb_io_relstr("machinename", buffer, depth, &info->machinename))
+       if (!smb_io_relstr("machinename", buffer, depth, &info->machinename))
                return False;
-       if (!new_smb_io_relstr("username", buffer, depth, &info->username))
+       if (!smb_io_relstr("username", buffer, depth, &info->username))
                return False;
-       if (!new_smb_io_relstr("document", buffer, depth, &info->document))
+       if (!smb_io_relstr("document", buffer, depth, &info->document))
                return False;
-       if (!new_smb_io_relstr("notifyname", buffer, depth, &info->notifyname))
+       if (!smb_io_relstr("notifyname", buffer, depth, &info->notifyname))
                return False;
-       if (!new_smb_io_relstr("datatype", buffer, depth, &info->datatype))
+       if (!smb_io_relstr("datatype", buffer, depth, &info->datatype))
                return False;
 
-       if (!new_smb_io_relstr("printprocessor", buffer, depth, &info->printprocessor))
+       if (!smb_io_relstr("printprocessor", buffer, depth, &info->printprocessor))
                return False;
-       if (!new_smb_io_relstr("parameters", buffer, depth, &info->parameters))
+       if (!smb_io_relstr("parameters", buffer, depth, &info->parameters))
                return False;
-       if (!new_smb_io_relstr("drivername", buffer, depth, &info->drivername))
+       if (!smb_io_relstr("drivername", buffer, depth, &info->drivername))
                return False;
-       if (!new_smb_io_reldevmode("devmode", buffer, depth, &info->devmode))
+       if (!smb_io_reldevmode("devmode", buffer, depth, &info->devmode))
                return False;
-       if (!new_smb_io_relstr("text_status", buffer, depth, &info->text_status))
+       if (!smb_io_relstr("text_status", buffer, depth, &info->text_status))
                return False;
 
 /*     SEC_DESC sec_desc;*/
@@ -2465,11 +2596,11 @@ BOOL new_smb_io_job_info_2(char *desc, NEW_BUFFER *buffer, JOB_INFO_2 *info, int
 /*******************************************************************
 ********************************************************************/  
 
-BOOL new_smb_io_form_1(char *desc, NEW_BUFFER *buffer, FORM_1 *info, int depth)
+BOOL smb_io_form_1(char *desc, NEW_BUFFER *buffer, FORM_1 *info, int depth)
 {
        prs_struct *ps=&buffer->prs;
        
-       prs_debug(ps, depth, desc, "new_smb_io_form_1");
+       prs_debug(ps, depth, desc, "smb_io_form_1");
        depth++;
                
        buffer->struct_start=prs_offset(ps);
@@ -2477,7 +2608,7 @@ BOOL new_smb_io_form_1(char *desc, NEW_BUFFER *buffer, FORM_1 *info, int depth)
        if (!prs_uint32("flag", ps, depth, &info->flag))
                return False;
                
-       if (!new_smb_io_relstr("name", buffer, depth, &info->name))
+       if (!smb_io_relstr("name", buffer, depth, &info->name))
                return False;
 
        if (!prs_uint32("width", ps, depth, &info->width))
@@ -2500,11 +2631,11 @@ BOOL new_smb_io_form_1(char *desc, NEW_BUFFER *buffer, FORM_1 *info, int depth)
  Read/write a BUFFER struct.
 ********************************************************************/  
 
-static BOOL new_spoolss_io_buffer(char *desc, prs_struct *ps, int depth, NEW_BUFFER **pp_buffer)
+static BOOL spoolss_io_buffer(char *desc, prs_struct *ps, int depth, NEW_BUFFER **pp_buffer)
 {
        NEW_BUFFER *buffer = *pp_buffer;
 
-       prs_debug(ps, depth, desc, "new_spoolss_io_buffer");
+       prs_debug(ps, depth, desc, "spoolss_io_buffer");
        depth++;
        
        if (UNMARSHALLING(ps))
@@ -2586,15 +2717,16 @@ static BOOL new_spoolss_io_buffer(char *desc, prs_struct *ps, int depth, NEW_BUF
  move a BUFFER from the query to the reply.
  As the data pointers in NEW_BUFFER are malloc'ed, not talloc'ed,
  this is ok. This is an OPTIMIZATION and is not strictly neccessary.
+ Clears the memory to zero also.
 ********************************************************************/  
 
-void new_spoolss_move_buffer(NEW_BUFFER *src, NEW_BUFFER **dest)
+void spoolss_move_buffer(NEW_BUFFER *src, NEW_BUFFER **dest)
 {
        prs_switch_type(&src->prs, MARSHALL);
        if(!prs_set_offset(&src->prs, 0))
                return;
-       prs_force_dynamic(&(src->prs));
-
+       prs_force_dynamic(&src->prs);
+       prs_mem_clear(&src->prs);
        *dest=src;
 }
 
@@ -2611,11 +2743,11 @@ uint32 new_get_buffer_size(NEW_BUFFER *buffer)
  Parse a DRIVER_DIRECTORY_1 structure.
 ********************************************************************/  
 
-BOOL new_smb_io_driverdir_1(char *desc, NEW_BUFFER *buffer, DRIVER_DIRECTORY_1 *info, int depth)
+BOOL smb_io_driverdir_1(char *desc, NEW_BUFFER *buffer, DRIVER_DIRECTORY_1 *info, int depth)
 {
        prs_struct *ps=&buffer->prs;
 
-       prs_debug(ps, depth, desc, "new_smb_io_driverdir_1");
+       prs_debug(ps, depth, desc, "smb_io_driverdir_1");
        depth++;
 
        buffer->struct_start=prs_offset(ps);
@@ -2630,16 +2762,16 @@ BOOL new_smb_io_driverdir_1(char *desc, NEW_BUFFER *buffer, DRIVER_DIRECTORY_1 *
  Parse a PORT_INFO_1 structure.
 ********************************************************************/  
 
-BOOL new_smb_io_port_1(char *desc, NEW_BUFFER *buffer, PORT_INFO_1 *info, int depth)
+BOOL smb_io_port_1(char *desc, NEW_BUFFER *buffer, PORT_INFO_1 *info, int depth)
 {
        prs_struct *ps=&buffer->prs;
 
-       prs_debug(ps, depth, desc, "new_smb_io_port_1");
+       prs_debug(ps, depth, desc, "smb_io_port_1");
        depth++;
 
        buffer->struct_start=prs_offset(ps);
 
-       if(!new_smb_io_relstr("port_name", buffer, depth, &info->port_name))
+       if(!smb_io_relstr("port_name", buffer, depth, &info->port_name))
                return False;
 
        return True;
@@ -2649,20 +2781,20 @@ BOOL new_smb_io_port_1(char *desc, NEW_BUFFER *buffer, PORT_INFO_1 *info, int de
  Parse a PORT_INFO_2 structure.
 ********************************************************************/  
 
-BOOL new_smb_io_port_2(char *desc, NEW_BUFFER *buffer, PORT_INFO_2 *info, int depth)
+BOOL smb_io_port_2(char *desc, NEW_BUFFER *buffer, PORT_INFO_2 *info, int depth)
 {
        prs_struct *ps=&buffer->prs;
 
-       prs_debug(ps, depth, desc, "new_smb_io_port_2");
+       prs_debug(ps, depth, desc, "smb_io_port_2");
        depth++;
 
        buffer->struct_start=prs_offset(ps);
 
-       if(!new_smb_io_relstr("port_name", buffer, depth, &info->port_name))
+       if(!smb_io_relstr("port_name", buffer, depth, &info->port_name))
                return False;
-       if(!new_smb_io_relstr("monitor_name", buffer, depth, &info->monitor_name))
+       if(!smb_io_relstr("monitor_name", buffer, depth, &info->monitor_name))
                return False;
-       if(!new_smb_io_relstr("description", buffer, depth, &info->description))
+       if(!smb_io_relstr("description", buffer, depth, &info->description))
                return False;
        if(!prs_uint32("port_type", ps, depth, &info->port_type))
                return False;
@@ -2684,7 +2816,7 @@ BOOL smb_io_printprocessor_info_1(char *desc, NEW_BUFFER *buffer, PRINTPROCESSOR
 
        buffer->struct_start=prs_offset(ps);
        
-       if (new_smb_io_relstr("name", buffer, depth, &info->name))
+       if (smb_io_relstr("name", buffer, depth, &info->name))
                return False;
 
        return True;
@@ -2702,7 +2834,7 @@ BOOL smb_io_printprocdatatype_info_1(char *desc, NEW_BUFFER *buffer, PRINTPROCDA
 
        buffer->struct_start=prs_offset(ps);
        
-       if (new_smb_io_relstr("name", buffer, depth, &info->name))
+       if (smb_io_relstr("name", buffer, depth, &info->name))
                return False;
 
        return True;
@@ -2720,7 +2852,7 @@ BOOL smb_io_printmonitor_info_1(char *desc, NEW_BUFFER *buffer, PRINTMONITOR_1 *
 
        buffer->struct_start=prs_offset(ps);
 
-       if (!new_smb_io_relstr("name", buffer, depth, &info->name))
+       if (!smb_io_relstr("name", buffer, depth, &info->name))
                return False;
 
        return True;
@@ -2738,11 +2870,11 @@ BOOL smb_io_printmonitor_info_2(char *desc, NEW_BUFFER *buffer, PRINTMONITOR_2 *
 
        buffer->struct_start=prs_offset(ps);
 
-       if (!new_smb_io_relstr("name", buffer, depth, &info->name))
+       if (!smb_io_relstr("name", buffer, depth, &info->name))
                return False;
-       if (!new_smb_io_relstr("environment", buffer, depth, &info->environment))
+       if (!smb_io_relstr("environment", buffer, depth, &info->environment))
                return False;
-       if (!new_smb_io_relstr("dll_name", buffer, depth, &info->dll_name))
+       if (!smb_io_relstr("dll_name", buffer, depth, &info->dll_name))
                return False;
 
        return True;
@@ -2860,6 +2992,39 @@ uint32 spoolss_size_printer_info_2(PRINTER_INFO_2 *info)
        return size;
 }
 
+/*******************************************************************
+return the size required by a struct in the stream
+********************************************************************/
+
+uint32 spoolss_size_printer_info_4(PRINTER_INFO_4 *info)
+{
+       uint32 size=0;
+               
+       size+=size_of_relative_string( &info->printername );
+       size+=size_of_relative_string( &info->servername );
+
+       size+=size_of_uint32( &info->attributes );
+       return size;
+}
+
+/*******************************************************************
+return the size required by a struct in the stream
+********************************************************************/
+
+uint32 spoolss_size_printer_info_5(PRINTER_INFO_5 *info)
+{
+       uint32 size=0;
+               
+       size+=size_of_relative_string( &info->printername );
+       size+=size_of_relative_string( &info->portname );
+
+       size+=size_of_uint32( &info->attributes );
+       size+=size_of_uint32( &info->device_not_selected_timeout );
+       size+=size_of_uint32( &info->transmission_retry_timeout );
+       return size;
+}
+
+
 /*******************************************************************
 return the size required by a struct in the stream
 ********************************************************************/
@@ -3089,6 +3254,21 @@ uint32 spoolss_size_driverdir_info_1(DRIVER_DIRECTORY_1 *info)
 return the size required by a struct in the stream
 ********************************************************************/  
 
+uint32 spoolss_size_printprocessordirectory_info_1(PRINTPROCESSOR_DIRECTORY_1 *info)
+{
+       int size=0;
+
+       size=str_len_uni(&info->name);  /* the string length       */
+       size=size+1;                    /* add the leading zero    */
+       size=size*2;                    /* convert in char         */
+
+       return size;
+}
+
+/*******************************************************************
+return the size required by a struct in the stream
+********************************************************************/  
+
 uint32 spoolss_size_port_info_2(PORT_INFO_2 *info)
 {
        int size=0;
@@ -3127,6 +3307,25 @@ uint32 spoolss_size_printprocdatatype_info_1(PRINTPROCDATATYPE_1 *info)
        return size;
 }
 
+/*******************************************************************
+return the size required by a struct in the stream
+********************************************************************/  
+uint32 spoolss_size_printer_enum_values(PRINTER_ENUM_VALUES *p)
+{
+       uint32  size = 0; 
+       
+       if (!p)
+               return 0;
+       
+       /* uint32(offset) + uint32(length) + length) */
+       size += (size_of_uint32(&p->value_len)*2) + p->value_len;
+       size += (size_of_uint32(&p->data_len)*2) + p->data_len;
+       
+       size += size_of_uint32(&p->type);
+                      
+       return size;
+}
+
 /*******************************************************************
 return the size required by a struct in the stream
 ********************************************************************/  
@@ -3205,7 +3404,7 @@ BOOL spoolss_io_q_getprinterdriver2(char *desc, SPOOL_Q_GETPRINTERDRIVER2 *q_u,
        if(!prs_uint32("level", ps, depth, &q_u->level))
                return False;
                
-       if(!new_spoolss_io_buffer("", ps, depth, &q_u->buffer))
+       if(!spoolss_io_buffer("", ps, depth, &q_u->buffer))
                return False;
 
        if(!prs_align(ps))
@@ -3235,7 +3434,7 @@ BOOL spoolss_io_r_getprinterdriver2(char *desc, SPOOL_R_GETPRINTERDRIVER2 *r_u,
        if (!prs_align(ps))
                return False;
                
-       if (!new_spoolss_io_buffer("", ps, depth, &r_u->buffer))
+       if (!spoolss_io_buffer("", ps, depth, &r_u->buffer))
                return False;
 
        if (!prs_align(ps))
@@ -3246,7 +3445,7 @@ BOOL spoolss_io_r_getprinterdriver2(char *desc, SPOOL_R_GETPRINTERDRIVER2 *r_u,
                return False;
        if (!prs_uint32("serverminorversion", ps, depth, &r_u->serverminorversion))
                return False;           
-       if (!prs_uint32("status", ps, depth, &r_u->status))
+       if (!prs_werror("status", ps, depth, &r_u->status))
                return False;
 
        return True;            
@@ -3256,9 +3455,14 @@ BOOL spoolss_io_r_getprinterdriver2(char *desc, SPOOL_R_GETPRINTERDRIVER2 *r_u,
  * init a structure.
  ********************************************************************/
 
-BOOL make_spoolss_q_enumprinters(SPOOL_Q_ENUMPRINTERS *q_u, uint32 flags, 
-                               fstring servername, uint32 level, 
-                               NEW_BUFFER *buffer, uint32 offered)
+BOOL make_spoolss_q_enumprinters(
+       SPOOL_Q_ENUMPRINTERS *q_u, 
+       uint32 flags, 
+       fstring servername, 
+       uint32 level, 
+       NEW_BUFFER *buffer, 
+       uint32 offered
+)
 {
        q_u->flags=flags;
        
@@ -3316,7 +3520,7 @@ BOOL spoolss_io_q_enumprinters(char *desc, SPOOL_Q_ENUMPRINTERS *q_u, prs_struct
        if (!prs_uint32("level", ps, depth, &q_u->level))
                return False;
 
-       if (!new_spoolss_io_buffer("", ps, depth, &q_u->buffer))
+       if (!spoolss_io_buffer("", ps, depth, &q_u->buffer))
                return False;
 
        if (!prs_align(ps))
@@ -3331,15 +3535,15 @@ BOOL spoolss_io_q_enumprinters(char *desc, SPOOL_Q_ENUMPRINTERS *q_u, prs_struct
  Parse a SPOOL_R_ENUMPRINTERS structure.
  ********************************************************************/
 
-BOOL new_spoolss_io_r_enumprinters(char *desc, SPOOL_R_ENUMPRINTERS *r_u, prs_struct *ps, int depth)
+BOOL spoolss_io_r_enumprinters(char *desc, SPOOL_R_ENUMPRINTERS *r_u, prs_struct *ps, int depth)
 {
-       prs_debug(ps, depth, desc, "new_spoolss_io_r_enumprinters");
+       prs_debug(ps, depth, desc, "spoolss_io_r_enumprinters");
        depth++;
 
        if (!prs_align(ps))
                return False;
                
-       if (!new_spoolss_io_buffer("", ps, depth, &r_u->buffer))
+       if (!spoolss_io_buffer("", ps, depth, &r_u->buffer))
                return False;
 
        if (!prs_align(ps))
@@ -3351,7 +3555,7 @@ BOOL new_spoolss_io_r_enumprinters(char *desc, SPOOL_R_ENUMPRINTERS *r_u, prs_st
        if (!prs_uint32("returned", ps, depth, &r_u->returned))
                return False;
                
-       if (!prs_uint32("status", ps, depth, &r_u->status))
+       if (!prs_werror("status", ps, depth, &r_u->status))
                return False;
 
        return True;            
@@ -3371,7 +3575,7 @@ BOOL spoolss_io_r_getprinter(char *desc, SPOOL_R_GETPRINTER *r_u, prs_struct *ps
        if (!prs_align(ps))
                return False;
                
-       if (!new_spoolss_io_buffer("", ps, depth, &r_u->buffer))
+       if (!spoolss_io_buffer("", ps, depth, &r_u->buffer))
                return False;
 
        if (!prs_align(ps))
@@ -3380,7 +3584,7 @@ BOOL spoolss_io_r_getprinter(char *desc, SPOOL_R_GETPRINTER *r_u, prs_struct *ps
        if (!prs_uint32("needed", ps, depth, &r_u->needed))
                return False;
                
-       if (!prs_uint32("status", ps, depth, &r_u->status))
+       if (!prs_werror("status", ps, depth, &r_u->status))
                return False;
 
        return True;            
@@ -3404,7 +3608,7 @@ BOOL spoolss_io_q_getprinter(char *desc, SPOOL_Q_GETPRINTER *q_u, prs_struct *ps
        if (!prs_uint32("level", ps, depth, &q_u->level))
                return False;
 
-       if (!new_spoolss_io_buffer("", ps, depth, &q_u->buffer))
+       if (!spoolss_io_buffer("", ps, depth, &q_u->buffer))
                return False;
 
        if (!prs_align(ps))
@@ -3419,8 +3623,14 @@ BOOL spoolss_io_q_getprinter(char *desc, SPOOL_Q_GETPRINTER *q_u, prs_struct *ps
  * init a structure.
  ********************************************************************/
 
-BOOL make_spoolss_q_getprinter(SPOOL_Q_GETPRINTER *q_u, const POLICY_HND *hnd, uint32 level, 
-                               NEW_BUFFER *buffer, uint32 offered)
+BOOL make_spoolss_q_getprinter(
+       TALLOC_CTX *mem_ctx,
+       SPOOL_Q_GETPRINTER *q_u, 
+       const POLICY_HND *hnd, 
+       uint32 level, 
+       NEW_BUFFER *buffer, 
+       uint32 offered
+)
 {
        if (q_u == NULL)
        {
@@ -3435,6 +3645,74 @@ BOOL make_spoolss_q_getprinter(SPOOL_Q_GETPRINTER *q_u, const POLICY_HND *hnd, u
        return True;
 }
 
+/*******************************************************************
+ * init a structure.
+ ********************************************************************/
+BOOL make_spoolss_q_setprinter(
+       TALLOC_CTX *mem_ctx,
+       SPOOL_Q_SETPRINTER *q_u, 
+       const POLICY_HND *hnd, 
+       uint32 level, 
+       PRINTER_INFO_CTR *info, 
+       uint32 command
+)
+{
+       SEC_DESC *secdesc;
+       DEVICEMODE *devmode;
+
+       if (q_u == NULL)
+       {
+               return False;
+       }
+       
+       memcpy(&q_u->handle, hnd, sizeof(q_u->handle));
+
+       q_u->level = level;
+       q_u->info.level = level;
+       q_u->info.info_ptr = (info != NULL) ? 1 : 0;
+       switch (level)
+       {
+       case 2:
+               secdesc = info->printers_2->secdesc;
+               devmode = info->printers_2->devmode;
+               
+               /* FIXMEE!!  HACK ALERT!!!  --jerry */
+               info->printers_2->devmode = NULL;
+               info->printers_2->secdesc = NULL;
+               
+               make_spoolss_printer_info_2 (mem_ctx, &q_u->info.info_2, info->printers_2);
+#if 0  /* JERRY TEST */
+               q_u->secdesc_ctr = (SEC_DESC_BUF*)malloc(sizeof(SEC_DESC_BUF));
+               if (!q_u->secdesc_ctr)
+                       return False;
+               q_u->secdesc_ctr->ptr = (secdesc != NULL) ? 1: 0;
+               q_u->secdesc_ctr->max_len = (secdesc) ? sizeof(SEC_DESC) + (2*sizeof(uint32)) : 0;
+               q_u->secdesc_ctr->len = (secdesc) ? sizeof(SEC_DESC) + (2*sizeof(uint32)) : 0;
+               q_u->secdesc_ctr->sec = secdesc;
+
+               q_u->devmode_ctr.devmode_ptr = (devmode != NULL) ? 1 : 0;
+               q_u->devmode_ctr.size = sizeof(DEVICEMODE) + (3*sizeof(uint32));
+               q_u->devmode_ctr.devmode = devmode;
+#else
+               q_u->secdesc_ctr = NULL;
+       
+               q_u->devmode_ctr.devmode_ptr = 0;
+               q_u->devmode_ctr.size = 0;
+               q_u->devmode_ctr.devmode = NULL;
+#endif
+               break;
+       default: 
+               DEBUG(0,("make_spoolss_q_setprinter: Unknown info level [%d]\n", level));
+                       break;
+       }
+
+       
+       q_u->command = command;
+
+       return True;
+}
+
+
 /*******************************************************************
 ********************************************************************/  
 
@@ -3446,7 +3724,7 @@ BOOL spoolss_io_r_setprinter(char *desc, SPOOL_R_SETPRINTER *r_u, prs_struct *ps
        if(!prs_align(ps))
                return False;
        
-       if(!prs_uint32("status", ps, depth, &r_u->status))
+       if(!prs_werror("status", ps, depth, &r_u->status))
                return False;
 
        return True;
@@ -3523,7 +3801,7 @@ BOOL spoolss_io_r_fcpn(char *desc, SPOOL_R_FCPN *r_u, prs_struct *ps, int depth)
        if(!prs_align(ps))
                return False;
        
-       if(!prs_uint32("status", ps, depth, &r_u->status))
+       if(!prs_werror("status", ps, depth, &r_u->status))
                return False;
 
        return True;
@@ -3559,7 +3837,7 @@ BOOL spoolss_io_r_addjob(char *desc, SPOOL_R_ADDJOB *r_u, prs_struct *ps, int de
        if(!prs_align(ps))
                return False;
        
-       if(!new_spoolss_io_buffer("", ps, depth, &r_u->buffer))
+       if(!spoolss_io_buffer("", ps, depth, &r_u->buffer))
                return False;
 
        if(!prs_align(ps))
@@ -3568,7 +3846,7 @@ BOOL spoolss_io_r_addjob(char *desc, SPOOL_R_ADDJOB *r_u, prs_struct *ps, int de
        if(!prs_uint32("needed", ps, depth, &r_u->needed))
                return False;
 
-       if(!prs_uint32("status", ps, depth, &r_u->status))
+       if(!prs_werror("status", ps, depth, &r_u->status))
                return False;
 
        return True;
@@ -3590,7 +3868,7 @@ BOOL spoolss_io_q_addjob(char *desc, SPOOL_Q_ADDJOB *q_u, prs_struct *ps, int de
        if(!prs_uint32("level", ps, depth, &q_u->level))
                return False;
        
-       if(!new_spoolss_io_buffer("", ps, depth, &q_u->buffer))
+       if(!spoolss_io_buffer("", ps, depth, &q_u->buffer))
                return False;
 
        if(!prs_align(ps))
@@ -3613,7 +3891,7 @@ BOOL spoolss_io_r_enumjobs(char *desc, SPOOL_R_ENUMJOBS *r_u, prs_struct *ps, in
        if (!prs_align(ps))
                return False;
                
-       if (!new_spoolss_io_buffer("", ps, depth, &r_u->buffer))
+       if (!spoolss_io_buffer("", ps, depth, &r_u->buffer))
                return False;
 
        if (!prs_align(ps))
@@ -3625,7 +3903,7 @@ BOOL spoolss_io_r_enumjobs(char *desc, SPOOL_R_ENUMJOBS *r_u, prs_struct *ps, in
        if (!prs_uint32("returned", ps, depth, &r_u->returned))
                return False;
                
-       if (!prs_uint32("status", ps, depth, &r_u->status))
+       if (!prs_werror("status", ps, depth, &r_u->status))
                return False;
 
        return True;            
@@ -3675,7 +3953,7 @@ BOOL spoolss_io_q_enumjobs(char *desc, SPOOL_Q_ENUMJOBS *q_u, prs_struct *ps, in
        if (!prs_uint32("level", ps, depth, &q_u->level))
                return False;
 
-       if (!new_spoolss_io_buffer("", ps, depth, &q_u->buffer))
+       if (!spoolss_io_buffer("", ps, depth, &q_u->buffer))
                return False;   
 
        if (!prs_uint32("offered", ps, depth, &q_u->offered))
@@ -3695,7 +3973,7 @@ BOOL spoolss_io_r_schedulejob(char *desc, SPOOL_R_SCHEDULEJOB *r_u, prs_struct *
        if(!prs_align(ps))
                return False;
        
-       if(!prs_uint32("status", ps, depth, &r_u->status))
+       if(!prs_werror("status", ps, depth, &r_u->status))
                return False;
 
        return True;
@@ -3731,7 +4009,7 @@ BOOL spoolss_io_r_setjob(char *desc, SPOOL_R_SETJOB *r_u, prs_struct *ps, int de
        if(!prs_align(ps))
                return False;
        
-       if(!prs_uint32("status", ps, depth, &r_u->status))
+       if(!prs_werror("status", ps, depth, &r_u->status))
                return False;
 
        return True;
@@ -3776,7 +4054,7 @@ BOOL spoolss_io_r_enumprinterdrivers(char *desc, SPOOL_R_ENUMPRINTERDRIVERS *r_u
        if (!prs_align(ps))
                return False;
                
-       if (!new_spoolss_io_buffer("", ps, depth, &r_u->buffer))
+       if (!spoolss_io_buffer("", ps, depth, &r_u->buffer))
                return False;
 
        if (!prs_align(ps))
@@ -3788,7 +4066,7 @@ BOOL spoolss_io_r_enumprinterdrivers(char *desc, SPOOL_R_ENUMPRINTERDRIVERS *r_u
        if (!prs_uint32("returned", ps, depth, &r_u->returned))
                return False;
                
-       if (!prs_uint32("status", ps, depth, &r_u->status))
+       if (!prs_werror("status", ps, depth, &r_u->status))
                return False;
 
        return True;            
@@ -3844,7 +4122,7 @@ BOOL spoolss_io_q_enumprinterdrivers(char *desc, SPOOL_Q_ENUMPRINTERDRIVERS *q_u
        if (!prs_uint32("level", ps, depth, &q_u->level))
                return False;
                
-       if (!new_spoolss_io_buffer("", ps, depth, &q_u->buffer))
+       if (!spoolss_io_buffer("", ps, depth, &q_u->buffer))
                return False;
 
        if (!prs_align(ps))
@@ -3872,7 +4150,7 @@ BOOL spoolss_io_q_enumforms(char *desc, SPOOL_Q_ENUMFORMS *q_u, prs_struct *ps,
        if (!prs_uint32("level", ps, depth, &q_u->level))
                return False;   
        
-       if (!new_spoolss_io_buffer("", ps, depth, &q_u->buffer))
+       if (!spoolss_io_buffer("", ps, depth, &q_u->buffer))
                return False;
 
        if (!prs_align(ps))
@@ -3886,15 +4164,15 @@ BOOL spoolss_io_q_enumforms(char *desc, SPOOL_Q_ENUMFORMS *q_u, prs_struct *ps,
 /*******************************************************************
 ********************************************************************/  
 
-BOOL new_spoolss_io_r_enumforms(char *desc, SPOOL_R_ENUMFORMS *r_u, prs_struct *ps, int depth)
+BOOL spoolss_io_r_enumforms(char *desc, SPOOL_R_ENUMFORMS *r_u, prs_struct *ps, int depth)
 {
-       prs_debug(ps, depth, desc, "new_spoolss_io_r_enumforms");
+       prs_debug(ps, depth, desc, "spoolss_io_r_enumforms");
        depth++;
 
        if (!prs_align(ps))
                return False;
                
-       if (!new_spoolss_io_buffer("", ps, depth, &r_u->buffer))
+       if (!spoolss_io_buffer("", ps, depth, &r_u->buffer))
                return False;
 
        if (!prs_align(ps))
@@ -3906,7 +4184,7 @@ BOOL new_spoolss_io_r_enumforms(char *desc, SPOOL_R_ENUMFORMS *r_u, prs_struct *
        if (!prs_uint32("numofforms", ps, depth, &r_u->numofforms))
                return False;
                
-       if (!prs_uint32("status", ps, depth, &r_u->status))
+       if (!prs_werror("status", ps, depth, &r_u->status))
                return False;
 
        return True;
@@ -3934,7 +4212,7 @@ BOOL spoolss_io_q_getform(char *desc, SPOOL_Q_GETFORM *q_u, prs_struct *ps, int
        if (!prs_uint32("level", ps, depth, &q_u->level))
                return False;   
        
-       if (!new_spoolss_io_buffer("", ps, depth, &q_u->buffer))
+       if (!spoolss_io_buffer("", ps, depth, &q_u->buffer))
                return False;
 
        if (!prs_align(ps))
@@ -3948,15 +4226,15 @@ BOOL spoolss_io_q_getform(char *desc, SPOOL_Q_GETFORM *q_u, prs_struct *ps, int
 /*******************************************************************
 ********************************************************************/  
 
-BOOL new_spoolss_io_r_getform(char *desc, SPOOL_R_GETFORM *r_u, prs_struct *ps, int depth)
+BOOL spoolss_io_r_getform(char *desc, SPOOL_R_GETFORM *r_u, prs_struct *ps, int depth)
 {
-       prs_debug(ps, depth, desc, "new_spoolss_io_r_getform");
+       prs_debug(ps, depth, desc, "spoolss_io_r_getform");
        depth++;
 
        if (!prs_align(ps))
                return False;
                
-       if (!new_spoolss_io_buffer("", ps, depth, &r_u->buffer))
+       if (!spoolss_io_buffer("", ps, depth, &r_u->buffer))
                return False;
 
        if (!prs_align(ps))
@@ -3965,7 +4243,7 @@ BOOL new_spoolss_io_r_getform(char *desc, SPOOL_R_GETFORM *r_u, prs_struct *ps,
        if (!prs_uint32("size of buffer needed", ps, depth, &r_u->needed))
                return False;
                
-       if (!prs_uint32("status", ps, depth, &r_u->status))
+       if (!prs_werror("status", ps, depth, &r_u->status))
                return False;
 
        return True;
@@ -3975,15 +4253,15 @@ BOOL new_spoolss_io_r_getform(char *desc, SPOOL_R_GETFORM *r_u, prs_struct *ps,
  Parse a SPOOL_R_ENUMPORTS structure.
 ********************************************************************/  
 
-BOOL new_spoolss_io_r_enumports(char *desc, SPOOL_R_ENUMPORTS *r_u, prs_struct *ps, int depth)
+BOOL spoolss_io_r_enumports(char *desc, SPOOL_R_ENUMPORTS *r_u, prs_struct *ps, int depth)
 {
-       prs_debug(ps, depth, desc, "new_spoolss_io_r_enumports");
+       prs_debug(ps, depth, desc, "spoolss_io_r_enumports");
        depth++;
 
        if (!prs_align(ps))
                return False;
                
-       if (!new_spoolss_io_buffer("", ps, depth, &r_u->buffer))
+       if (!spoolss_io_buffer("", ps, depth, &r_u->buffer))
                return False;
 
        if (!prs_align(ps))
@@ -3995,7 +4273,7 @@ BOOL new_spoolss_io_r_enumports(char *desc, SPOOL_R_ENUMPORTS *r_u, prs_struct *
        if (!prs_uint32("returned", ps, depth, &r_u->returned))
                return False;
                
-       if (!prs_uint32("status", ps, depth, &r_u->status))
+       if (!prs_werror("status", ps, depth, &r_u->status))
                return False;
 
        return True;            
@@ -4022,7 +4300,7 @@ BOOL spoolss_io_q_enumports(char *desc, SPOOL_Q_ENUMPORTS *q_u, prs_struct *ps,
        if (!prs_uint32("level", ps, depth, &q_u->level))
                return False;
                
-       if (!new_spoolss_io_buffer("", ps, depth, &q_u->buffer))
+       if (!spoolss_io_buffer("", ps, depth, &q_u->buffer))
                return False;
 
        if (!prs_align(ps))
@@ -4240,6 +4518,8 @@ BOOL spool_io_printer_info_level(char *desc, SPOOL_PRINTER_INFO_LEVEL *il, prs_s
 
 BOOL spoolss_io_q_addprinterex(char *desc, SPOOL_Q_ADDPRINTEREX *q_u, prs_struct *ps, int depth)
 {
+       uint32 ptr_sec_desc = 0;
+
        prs_debug(ps, depth, desc, "spoolss_io_q_addprinterex");
        depth++;
 
@@ -4259,26 +4539,33 @@ BOOL spoolss_io_q_addprinterex(char *desc, SPOOL_Q_ADDPRINTEREX *q_u, prs_struct
        if(!spool_io_printer_info_level("", &q_u->info, ps, depth))
                return False;
        
-       /* the 4 unknown are all 0 */
-
-       /* 
-        * en fait ils sont pas inconnu
-        * par recoupement avec rpcSetPrinter
-        * c'est le devicemode 
-        * et le security descriptor.
-        */
-       
-       if(!prs_align(ps))
-               return False;
-       if(!prs_uint32("unk0", ps, depth, &q_u->unk0))
-               return False;
-       if(!prs_uint32("unk1", ps, depth, &q_u->unk1))
-               return False;
-       if(!prs_uint32("unk2", ps, depth, &q_u->unk2))
-               return False;
-       if(!prs_uint32("unk3", ps, depth, &q_u->unk3))
+       if (!spoolss_io_devmode_cont(desc, &q_u->devmode_ctr, ps, depth))
                return False;
 
+       switch (q_u->level) {
+               case 2:
+                       ptr_sec_desc = q_u->info.info_2->secdesc_ptr;
+                       break;
+               case 3:
+                       ptr_sec_desc = q_u->info.info_3->secdesc_ptr;
+                       break;
+       }
+       if (ptr_sec_desc) {
+               if (!sec_io_desc_buf(desc, &q_u->secdesc_ctr, ps, depth))
+                       return False;
+       } else {
+               uint32 dummy;
+
+               /* Parse a NULL security descriptor.  This should really
+                       happen inside the sec_io_desc_buf() function. */
+
+               prs_debug(ps, depth, "", "sec_io_desc_buf");
+               if (!prs_uint32("size", ps, depth + 1, &dummy))
+                       return False;
+               if (!prs_uint32("ptr", ps, depth + 1, &dummy))
+                       return False;
+       }
+
        if(!prs_uint32("user_switch", ps, depth, &q_u->user_switch))
                return False;
        if(!spool_io_user_level("", &q_u->user_ctr, ps, depth))
@@ -4299,7 +4586,7 @@ BOOL spoolss_io_r_addprinterex(char *desc, SPOOL_R_ADDPRINTEREX *r_u,
        if(!smb_io_pol_hnd("printer handle",&r_u->handle,ps,depth))
                return False;
 
-       if(!prs_uint32("status", ps, depth, &r_u->status))
+       if(!prs_werror("status", ps, depth, &r_u->status))
                return False;
 
        return True;
@@ -4546,27 +4833,35 @@ BOOL spool_io_printer_driver_info_level_6(char *desc, SPOOL_PRINTER_DRIVER_INFO_
 ********************************************************************/  
 static BOOL uniarray_2_dosarray(BUFFER5 *buf5, fstring **ar)
 {
-       fstring f;
+       fstring f, *tar;
        int n = 0;
        char *src;
 
-       if (buf5==NULL) return False;
+       if (buf5==NULL)
+               return False;
 
        src = (char *)buf5->buffer;
        *ar = NULL;
 
        while (src < ((char *)buf5->buffer) + buf5->buf_len*2) {
-               unistr_to_dos(f, src, sizeof(f)-1);
+               rpcstr_pull(f, src, sizeof(f)-1, -1, 0);
                src = skip_unibuf(src, 2*buf5->buf_len - PTR_DIFF(src,buf5->buffer));
-               *ar = (fstring *)Realloc(*ar, sizeof(fstring)*(n+2));
+               tar = (fstring *)Realloc(*ar, sizeof(fstring)*(n+2));
+               if (!tar)
+                       return False;
+               else
+                       *ar = tar;
                fstrcpy((*ar)[n], f);
                n++;
        }
        fstrcpy((*ar)[n], "");
-
        return True;
 }
 
+
+
+
 /*******************************************************************
  read a UNICODE array with null terminated strings 
  and null terminated array 
@@ -4628,6 +4923,7 @@ BOOL spool_io_printer_driver_info_level(char *desc, SPOOL_PRINTER_DRIVER_INFO_LE
  ******************************************************************/
 
 BOOL make_spoolss_q_addprinterdriver(
+       TALLOC_CTX *mem_ctx,
        SPOOL_Q_ADDPRINTERDRIVER *q_u, 
        const char* srv_name, 
        uint32 level, 
@@ -4644,31 +4940,27 @@ BOOL make_spoolss_q_addprinterdriver(
        q_u->info.ptr = (info!=NULL)?1:0;
        switch (level)
        {
-               /* info level 3 is supported by Windows 95/98, 
-                  WinNT and Win2k */
-               case 3 :
-                       q_u->info.info_3=(SPOOL_PRINTER_DRIVER_INFO_LEVEL_3*)
-                                         malloc(sizeof(SPOOL_PRINTER_DRIVER_INFO_LEVEL_3));
-                       memset (q_u->info.info_3, 0x0, sizeof(SPOOL_PRINTER_DRIVER_INFO_LEVEL_3));
-                       make_spool_driver_info_3(q_u->info.info_3, info->info3);
-                       break;
+       /* info level 3 is supported by Windows 95/98, WinNT and Win2k */
+       case 3 :
+               make_spoolss_driver_info_3(mem_ctx, &q_u->info.info_3, info->info3);
+               break;
                
-               /* info level 6 is supported by WinME and Win2k */
-               case 6:
-                       /* WRITEME!!  will add later  --jerry */
-                       break;
-               default:
-                       DEBUG(0,("make_spoolss_q_addprinterdriver: Unknown \
-info level [%d]\n", level));
-                       break;
-       
+       /* info level 6 is supported by WinME and Win2k */
+       case 6:
+               /* WRITEME!!  will add later  --jerry */
+               break;
+               
+       default:
+               DEBUG(0,("make_spoolss_q_addprinterdriver: Unknown info level [%d]\n", level));
+               break;
        }
        
        return True;
 }
 
-BOOL make_spool_driver_info_3(
-       SPOOL_PRINTER_DRIVER_INFO_LEVEL_3 *spool_drv_info,
+BOOL make_spoolss_driver_info_3(
+       TALLOC_CTX *mem_ctx,
+       SPOOL_PRINTER_DRIVER_INFO_LEVEL_3 **spool_drv_info,
        DRIVER_INFO_3 *info3
 )
 {
@@ -4676,25 +4968,29 @@ BOOL make_spool_driver_info_3(
        uint16          *ptr = info3->dependentfiles;
        BOOL            done = False;
        BOOL            null_char = False;
-
-       spool_drv_info->cversion        = info3->version;
-       spool_drv_info->name_ptr        = (info3->name.buffer!=NULL)?1:0;
-       spool_drv_info->environment_ptr = (info3->architecture.buffer!=NULL)?1:0;
-       spool_drv_info->driverpath_ptr  = (info3->driverpath.buffer!=NULL)?1:0;
-       spool_drv_info->datafile_ptr    = (info3->datafile.buffer!=NULL)?1:0;
-       spool_drv_info->configfile_ptr  = (info3->configfile.buffer!=NULL)?1:0;
-       spool_drv_info->helpfile_ptr    = (info3->helpfile.buffer!=NULL)?1:0;
-       spool_drv_info->monitorname_ptr = (info3->monitorname.buffer!=NULL)?1:0;
-       spool_drv_info->defaultdatatype_ptr     = (info3->defaultdatatype.buffer!=NULL)?1:0;
-
-       init_unistr2_from_unistr(&spool_drv_info->name, &info3->name);
-       init_unistr2_from_unistr(&spool_drv_info->environment, &info3->architecture);
-       init_unistr2_from_unistr(&spool_drv_info->driverpath, &info3->driverpath);
-       init_unistr2_from_unistr(&spool_drv_info->datafile, &info3->datafile);
-       init_unistr2_from_unistr(&spool_drv_info->configfile, &info3->configfile);
-       init_unistr2_from_unistr(&spool_drv_info->helpfile, &info3->helpfile);
-       init_unistr2_from_unistr(&spool_drv_info->monitorname, &info3->monitorname);
-       init_unistr2_from_unistr(&spool_drv_info->defaultdatatype, &info3->defaultdatatype);
+       SPOOL_PRINTER_DRIVER_INFO_LEVEL_3 *inf;
+
+       if (!(inf=(SPOOL_PRINTER_DRIVER_INFO_LEVEL_3*)talloc_zero(mem_ctx, sizeof(SPOOL_PRINTER_DRIVER_INFO_LEVEL_3))))
+               return False;
+       
+       inf->cversion   = info3->version;
+       inf->name_ptr   = (info3->name.buffer!=NULL)?1:0;
+       inf->environment_ptr    = (info3->architecture.buffer!=NULL)?1:0;
+       inf->driverpath_ptr     = (info3->driverpath.buffer!=NULL)?1:0;
+       inf->datafile_ptr       = (info3->datafile.buffer!=NULL)?1:0;
+       inf->configfile_ptr     = (info3->configfile.buffer!=NULL)?1:0;
+       inf->helpfile_ptr       = (info3->helpfile.buffer!=NULL)?1:0;
+       inf->monitorname_ptr    = (info3->monitorname.buffer!=NULL)?1:0;
+       inf->defaultdatatype_ptr        = (info3->defaultdatatype.buffer!=NULL)?1:0;
+
+       init_unistr2_from_unistr(&inf->name, &info3->name);
+       init_unistr2_from_unistr(&inf->environment, &info3->architecture);
+       init_unistr2_from_unistr(&inf->driverpath, &info3->driverpath);
+       init_unistr2_from_unistr(&inf->datafile, &info3->datafile);
+       init_unistr2_from_unistr(&inf->configfile, &info3->configfile);
+       init_unistr2_from_unistr(&inf->helpfile, &info3->helpfile);
+       init_unistr2_from_unistr(&inf->monitorname, &info3->monitorname);
+       init_unistr2_from_unistr(&inf->defaultdatatype, &info3->defaultdatatype);
 
        while (!done)
        {
@@ -4717,30 +5013,32 @@ BOOL make_spool_driver_info_3(
                len++;
                ptr++;
        }
-       spool_drv_info->dependentfiles_ptr = (info3->dependentfiles!=NULL)?1:0;
-       spool_drv_info->dependentfilessize = len;
-       if(!make_spool_buffer5(&spool_drv_info->dependentfiles, len, info3->dependentfiles))
+       inf->dependentfiles_ptr = (info3->dependentfiles != NULL) ? 1 : 0;
+       inf->dependentfilessize = len;
+       if(!make_spoolss_buffer5(mem_ctx, &inf->dependentfiles, len, info3->dependentfiles))
+       {
+               SAFE_FREE(inf);
                return False;
+       }
+       
+       *spool_drv_info = inf;
        
        return True;
-}           
+}
 
 /*******************************************************************
  make a BUFFER5 struct from a uint16*
  ******************************************************************/
-
-BOOL make_spool_buffer5(BUFFER5 *buf5, uint32 len, uint16 *src)
+BOOL make_spoolss_buffer5(TALLOC_CTX *mem_ctx, BUFFER5 *buf5, uint32 len, uint16 *src)
 {
 
        buf5->buf_len = len;
-       if((buf5->buffer=(uint16*)malloc(sizeof(uint16)*len)) == NULL)
+       if((buf5->buffer=(uint16*)talloc_memdup(mem_ctx, src, sizeof(uint16)*len)) == NULL)
        {
-               DEBUG(0,("make_spool_buffer5: Unable to talloc memory for buffer!\n"));
+               DEBUG(0,("make_spoolss_buffer5: Unable to malloc memory for buffer!\n"));
                return False;
        }
        
-       memcpy(buf5->buffer, src, sizeof(uint16)*len);
-
        return True;
 }
 
@@ -4780,7 +5078,7 @@ BOOL spoolss_io_r_addprinterdriver(char *desc, SPOOL_R_ADDPRINTERDRIVER *q_u, pr
        prs_debug(ps, depth, desc, "spoolss_io_r_addprinterdriver");
        depth++;
 
-       if(!prs_uint32("status", ps, depth, &q_u->status))
+       if(!prs_werror("status", ps, depth, &q_u->status))
                return False;
 
        return True;
@@ -4827,9 +5125,11 @@ BOOL uni_2_asc_printer_driver_3(SPOOL_PRINTER_DRIVER_INFO_LEVEL_3 *uni,
        DEBUGADD(8,( "monitorname:     %s\n", d->monitorname));
        DEBUGADD(8,( "defaultdatatype: %s\n", d->defaultdatatype));
 
-       uniarray_2_dosarray(&uni->dependentfiles, &d->dependentfiles );
-
-       return True;
+       if (uniarray_2_dosarray(&uni->dependentfiles, &d->dependentfiles ))
+               return True;
+       
+       SAFE_FREE(*asc);
+       return False;
 }
 
 /*******************************************************************
@@ -4872,10 +5172,16 @@ BOOL uni_2_asc_printer_driver_6(SPOOL_PRINTER_DRIVER_INFO_LEVEL_6 *uni,
        DEBUGADD(8,( "monitorname:     %s\n", d->monitorname));
        DEBUGADD(8,( "defaultdatatype: %s\n", d->defaultdatatype));
 
-       uniarray_2_dosarray(&uni->dependentfiles, &d->dependentfiles );
-       uniarray_2_dosarray(&uni->previousnames, &d->previousnames );
-
+       if (!uniarray_2_dosarray(&uni->dependentfiles, &d->dependentfiles ))
+               goto error;
+       if (!uniarray_2_dosarray(&uni->previousnames, &d->previousnames ))
+               goto error;
+       
        return True;
+       
+error:
+       SAFE_FREE(*asc);
+       return False;
 }
 
 BOOL uni_2_asc_printer_info_2(const SPOOL_PRINTER_INFO_LEVEL_2 *uni,
@@ -4976,7 +5282,7 @@ BOOL spoolss_io_q_getprinterdriverdir(char *desc, SPOOL_Q_GETPRINTERDRIVERDIR *q
        if(!prs_uint32("level", ps, depth, &q_u->level))
                return False;
                
-       if(!new_spoolss_io_buffer("", ps, depth, &q_u->buffer))
+       if(!spoolss_io_buffer("", ps, depth, &q_u->buffer))
                return False;
                
        if(!prs_align(ps))
@@ -5000,7 +5306,7 @@ BOOL spoolss_io_r_getprinterdriverdir(char *desc, SPOOL_R_GETPRINTERDRIVERDIR *r
        if (!prs_align(ps))
                return False;
                
-       if (!new_spoolss_io_buffer("", ps, depth, &r_u->buffer))
+       if (!spoolss_io_buffer("", ps, depth, &r_u->buffer))
                return False;
 
        if (!prs_align(ps))
@@ -5009,7 +5315,7 @@ BOOL spoolss_io_r_getprinterdriverdir(char *desc, SPOOL_R_GETPRINTERDRIVERDIR *r
        if (!prs_uint32("needed", ps, depth, &r_u->needed))
                return False;
                
-       if (!prs_uint32("status", ps, depth, &r_u->status))
+       if (!prs_werror("status", ps, depth, &r_u->status))
                return False;
 
        return True;            
@@ -5026,7 +5332,7 @@ BOOL spoolss_io_r_enumprintprocessors(char *desc, SPOOL_R_ENUMPRINTPROCESSORS *r
        if (!prs_align(ps))
                return False;
                
-       if (!new_spoolss_io_buffer("", ps, depth, &r_u->buffer))
+       if (!spoolss_io_buffer("", ps, depth, &r_u->buffer))
                return False;
 
        if (!prs_align(ps))
@@ -5038,7 +5344,7 @@ BOOL spoolss_io_r_enumprintprocessors(char *desc, SPOOL_R_ENUMPRINTPROCESSORS *r
        if (!prs_uint32("returned", ps, depth, &r_u->returned))
                return False;
                
-       if (!prs_uint32("status", ps, depth, &r_u->status))
+       if (!prs_werror("status", ps, depth, &r_u->status))
                return False;
 
        return True;            
@@ -5074,7 +5380,7 @@ BOOL spoolss_io_q_enumprintprocessors(char *desc, SPOOL_Q_ENUMPRINTPROCESSORS *q
        if (!prs_uint32("level", ps, depth, &q_u->level))
                return False;
                
-       if(!new_spoolss_io_buffer("", ps, depth, &q_u->buffer))
+       if(!spoolss_io_buffer("", ps, depth, &q_u->buffer))
                return False;
 
        if (!prs_align(ps))
@@ -5089,6 +5395,57 @@ BOOL spoolss_io_q_enumprintprocessors(char *desc, SPOOL_Q_ENUMPRINTPROCESSORS *q
 /*******************************************************************
 ********************************************************************/  
 
+BOOL spoolss_io_q_addprintprocessor(char *desc, SPOOL_Q_ADDPRINTPROCESSOR *q_u, prs_struct *ps, int depth)
+{
+       prs_debug(ps, depth, desc, "spoolss_io_q_addprintprocessor");
+       depth++;
+
+       if (!prs_align(ps))
+               return False;
+               
+       if (!prs_uint32("server_ptr", ps, depth, &q_u->server_ptr))
+               return False;
+       if (!smb_io_unistr2("server", &q_u->server, q_u->server_ptr, ps, depth))
+               return False;
+               
+       if (!prs_align(ps))
+               return False;
+       if (!smb_io_unistr2("environment", &q_u->environment, True, ps, depth))
+               return False;
+               
+       if (!prs_align(ps))
+               return False;
+       if (!smb_io_unistr2("path", &q_u->path, True, ps, depth))
+               return False;
+
+       if (!prs_align(ps))
+               return False;
+       if (!smb_io_unistr2("name", &q_u->name, True, ps, depth))
+               return False;
+
+       return True;
+}
+
+/*******************************************************************
+********************************************************************/  
+
+BOOL spoolss_io_r_addprintprocessor(char *desc, SPOOL_R_ADDPRINTPROCESSOR *r_u, prs_struct *ps, int depth)
+{              
+       prs_debug(ps, depth, desc, "spoolss_io_r_addprintproicessor");
+       depth++;
+
+       if (!prs_align(ps))
+               return False;
+               
+       if (!prs_werror("status", ps, depth, &r_u->status))
+               return False;
+
+       return True;            
+}
+
+/*******************************************************************
+********************************************************************/  
+
 BOOL spoolss_io_r_enumprintprocdatatypes(char *desc, SPOOL_R_ENUMPRINTPROCDATATYPES *r_u, prs_struct *ps, int depth)
 {              
        prs_debug(ps, depth, desc, "spoolss_io_r_enumprintprocdatatypes");
@@ -5097,7 +5454,7 @@ BOOL spoolss_io_r_enumprintprocdatatypes(char *desc, SPOOL_R_ENUMPRINTPROCDATATY
        if (!prs_align(ps))
                return False;
                
-       if (!new_spoolss_io_buffer("", ps, depth, &r_u->buffer))
+       if (!spoolss_io_buffer("", ps, depth, &r_u->buffer))
                return False;
 
        if (!prs_align(ps))
@@ -5109,7 +5466,7 @@ BOOL spoolss_io_r_enumprintprocdatatypes(char *desc, SPOOL_R_ENUMPRINTPROCDATATY
        if (!prs_uint32("returned", ps, depth, &r_u->returned))
                return False;
                
-       if (!prs_uint32("status", ps, depth, &r_u->status))
+       if (!prs_werror("status", ps, depth, &r_u->status))
                return False;
 
        return True;            
@@ -5145,7 +5502,7 @@ BOOL spoolss_io_q_enumprintprocdatatypes(char *desc, SPOOL_Q_ENUMPRINTPROCDATATY
        if (!prs_uint32("level", ps, depth, &q_u->level))
                return False;
                
-       if(!new_spoolss_io_buffer("buffer", ps, depth, &q_u->buffer))
+       if(!spoolss_io_buffer("buffer", ps, depth, &q_u->buffer))
                return False;
 
        if (!prs_align(ps))
@@ -5180,7 +5537,7 @@ BOOL spoolss_io_q_enumprintmonitors(char *desc, SPOOL_Q_ENUMPRINTMONITORS *q_u,
        if (!prs_uint32("level", ps, depth, &q_u->level))
                return False;
                
-       if(!new_spoolss_io_buffer("", ps, depth, &q_u->buffer))
+       if(!spoolss_io_buffer("", ps, depth, &q_u->buffer))
                return False;
 
        if (!prs_align(ps))
@@ -5203,7 +5560,7 @@ BOOL spoolss_io_r_enumprintmonitors(char *desc, SPOOL_R_ENUMPRINTMONITORS *r_u,
        if (!prs_align(ps))
                return False;
                
-       if (!new_spoolss_io_buffer("", ps, depth, &r_u->buffer))
+       if (!spoolss_io_buffer("", ps, depth, &r_u->buffer))
                return False;
 
        if (!prs_align(ps))
@@ -5215,7 +5572,7 @@ BOOL spoolss_io_r_enumprintmonitors(char *desc, SPOOL_R_ENUMPRINTMONITORS *r_u,
        if (!prs_uint32("returned", ps, depth, &r_u->returned))
                return False;
                
-       if (!prs_uint32("status", ps, depth, &r_u->status))
+       if (!prs_werror("status", ps, depth, &r_u->status))
                return False;
 
        return True;            
@@ -5234,14 +5591,8 @@ BOOL spoolss_io_r_enumprinterdata(char *desc, SPOOL_R_ENUMPRINTERDATA *r_u, prs_
        if(!prs_uint32("valuesize", ps, depth, &r_u->valuesize))
                return False;
 
-       if (MARSHALLING(ps)) {
-               /* "Value is actually a UNICODE string. It's already little-endian so don't reverse. */
-               if(!prs_uint8s(False, "value", ps, depth, (uint8 *)r_u->value, r_u->valuesize * 2))
-                       return False;
-       } else {
-               if(!prs_uint16s(False, "value", ps, depth, r_u->value, r_u->valuesize ))
-                       return False;
-       }
+       if(!prs_uint16uni(False, "value", ps, depth, r_u->value, r_u->valuesize ))
+               return False;
 
        if(!prs_align(ps))
                return False;
@@ -5261,7 +5612,7 @@ BOOL spoolss_io_r_enumprinterdata(char *desc, SPOOL_R_ENUMPRINTERDATA *r_u, prs_
 
        if(!prs_uint32("realdatasize", ps, depth, &r_u->realdatasize))
                return False;
-       if(!prs_uint32("status", ps, depth, &r_u->status))
+       if(!prs_werror("status", ps, depth, &r_u->status))
                return False;
 
        return True;
@@ -5330,16 +5681,18 @@ BOOL spoolss_io_q_setprinterdata(char *desc, SPOOL_Q_SETPRINTERDATA *q_u, prs_st
 
        switch (q_u->type)
        {
-               case 0x1:
-               case 0x3:
-               case 0x4:
-               case 0x7:
-                       if (UNMARSHALLING(ps))
-                               q_u->data=(uint8 *)prs_alloc_mem(ps, q_u->max_len * sizeof(uint8));
-                       if(q_u->data == NULL)
-                               return False;
-                       if(!prs_uint8s(False,"data", ps, depth, q_u->data, q_u->max_len))
-                               return False;
+               case REG_SZ:
+               case REG_BINARY:
+               case REG_DWORD:
+               case REG_MULTI_SZ:
+            if (q_u->max_len) {
+                if (UNMARSHALLING(ps))
+                               q_u->data=(uint8 *)prs_alloc_mem(ps, q_u->max_len * sizeof(uint8));
+                       if(q_u->data == NULL)
+                               return False;
+                       if(!prs_uint8s(False,"data", ps, depth, q_u->data, q_u->max_len))
+                               return False;
+            }
                        if(!prs_align(ps))
                                return False;
                        break;
@@ -5361,7 +5714,7 @@ BOOL spoolss_io_r_setprinterdata(char *desc, SPOOL_R_SETPRINTERDATA *r_u, prs_st
 
        if(!prs_align(ps))
                return False;
-       if(!prs_uint32("status",     ps, depth, &r_u->status))
+       if(!prs_werror("status",     ps, depth, &r_u->status))
                return False;
 
        return True;
@@ -5468,7 +5821,7 @@ BOOL spoolss_io_r_deleteform(char *desc, SPOOL_R_DELETEFORM *r_u, prs_struct *ps
 
        if(!prs_align(ps))
                return False;
-       if(!prs_uint32("status",        ps, depth, &r_u->status))
+       if(!prs_werror("status",        ps, depth, &r_u->status))
                return False;
 
        return True;
@@ -5513,7 +5866,7 @@ BOOL spoolss_io_r_addform(char *desc, SPOOL_R_ADDFORM *r_u, prs_struct *ps, int
 
        if(!prs_align(ps))
                return False;
-       if(!prs_uint32("status",        ps, depth, &r_u->status))
+       if(!prs_werror("status",        ps, depth, &r_u->status))
                return False;
 
        return True;
@@ -5564,7 +5917,7 @@ BOOL spoolss_io_r_setform(char *desc, SPOOL_R_SETFORM *r_u, prs_struct *ps, int
 
        if(!prs_align(ps))
                return False;
-       if(!prs_uint32("status",        ps, depth, &r_u->status))
+       if(!prs_werror("status",        ps, depth, &r_u->status))
                return False;
 
        return True;
@@ -5582,7 +5935,7 @@ BOOL spoolss_io_r_getjob(char *desc, SPOOL_R_GETJOB *r_u, prs_struct *ps, int de
        if (!prs_align(ps))
                return False;
                
-       if (!new_spoolss_io_buffer("", ps, depth, &r_u->buffer))
+       if (!spoolss_io_buffer("", ps, depth, &r_u->buffer))
                return False;
 
        if (!prs_align(ps))
@@ -5591,7 +5944,7 @@ BOOL spoolss_io_r_getjob(char *desc, SPOOL_R_GETJOB *r_u, prs_struct *ps, int de
        if (!prs_uint32("needed", ps, depth, &r_u->needed))
                return False;
                
-       if (!prs_uint32("status", ps, depth, &r_u->status))
+       if (!prs_werror("status", ps, depth, &r_u->status))
                return False;
 
        return True;            
@@ -5616,7 +5969,7 @@ BOOL spoolss_io_q_getjob(char *desc, SPOOL_Q_GETJOB *q_u, prs_struct *ps, int de
        if(!prs_uint32("level", ps, depth, &q_u->level))
                return False;
        
-       if(!new_spoolss_io_buffer("", ps, depth, &q_u->buffer))
+       if(!spoolss_io_buffer("", ps, depth, &q_u->buffer))
                return False;
 
        if(!prs_align(ps))
@@ -5631,14 +5984,14 @@ BOOL spoolss_io_q_getjob(char *desc, SPOOL_Q_GETJOB *q_u, prs_struct *ps, int de
 void free_devmode(DEVICEMODE *devmode)
 {
        if (devmode!=NULL) {
-               safe_free(devmode->private);
-               safe_free(devmode);
+               SAFE_FREE(devmode->private);
+               SAFE_FREE(devmode);
        }
 }
 
 void free_printer_info_1(PRINTER_INFO_1 *printer)
 {
-       safe_free(printer);
+       SAFE_FREE(printer);
 }
 
 void free_printer_info_2(PRINTER_INFO_2 *printer)
@@ -5646,15 +5999,23 @@ void free_printer_info_2(PRINTER_INFO_2 *printer)
        if (printer!=NULL) {
                free_devmode(printer->devmode);
                printer->devmode = NULL;
-               safe_free(printer);
+               SAFE_FREE(printer);
        }
 }
 
 void free_printer_info_3(PRINTER_INFO_3 *printer)
 {
-       if (printer!=NULL) {
-               safe_free(printer);
-       }
+       SAFE_FREE(printer);
+}
+
+void free_printer_info_4(PRINTER_INFO_4 *printer)
+{
+       SAFE_FREE(printer);
+}
+
+void free_printer_info_5(PRINTER_INFO_5 *printer)
+{
+       SAFE_FREE(printer);
 }
 
 void free_job_info_2(JOB_INFO_2 *job)
@@ -5730,7 +6091,7 @@ BOOL spoolss_io_r_replyopenprinter(char *desc, SPOOL_R_REPLYOPENPRINTER *r_u, pr
        if(!smb_io_pol_hnd("printer handle",&r_u->handle,ps,depth))
                return False;
 
-       if (!prs_uint32("status", ps, depth, &r_u->status))
+       if (!prs_werror("status", ps, depth, &r_u->status))
                return False;
 
        return True;            
@@ -5783,7 +6144,7 @@ BOOL spoolss_io_r_replycloseprinter(char *desc, SPOOL_R_REPLYCLOSEPRINTER *r_u,
        if(!smb_io_pol_hnd("printer handle",&r_u->handle,ps,depth))
                return False;
 
-       if (!prs_uint32("status", ps, depth, &r_u->status))
+       if (!prs_werror("status", ps, depth, &r_u->status))
                return False;
 
        return True;            
@@ -5868,8 +6229,448 @@ BOOL spoolss_io_r_reply_rrpcn(char *desc, SPOOL_R_REPLY_RRPCN *r_u, prs_struct *
        if (!prs_uint32("unknown0", ps, depth, &r_u->unknown0))
                return False;
 
-       if (!prs_uint32("status", ps, depth, &r_u->status))
+       if (!prs_werror("status", ps, depth, &r_u->status))
                return False;
 
        return True;            
 }
+
+/*******************************************************************
+ * read a structure.
+ * called from spoolss_q_getprinterdataex (srv_spoolss.c)
+ ********************************************************************/
+
+BOOL spoolss_io_q_getprinterdataex(char *desc, SPOOL_Q_GETPRINTERDATAEX *q_u, prs_struct *ps, int depth)
+{
+       if (q_u == NULL)
+               return False;
+
+       prs_debug(ps, depth, desc, "spoolss_io_q_getprinterdataex");
+       depth++;
+
+       if (!prs_align(ps))
+               return False;
+       if (!smb_io_pol_hnd("printer handle",&q_u->handle,ps,depth))
+               return False;
+       if (!prs_align(ps))
+               return False;
+       if (!smb_io_unistr2("keyname", &q_u->keyname,True,ps,depth))
+               return False;
+       if (!prs_align(ps))
+               return False;
+       if (!smb_io_unistr2("valuename", &q_u->valuename,True,ps,depth))
+               return False;
+       if (!prs_align(ps))
+               return False;
+       if (!prs_uint32("size", ps, depth, &q_u->size))
+               return False;
+
+       return True;
+}
+
+/*******************************************************************
+ * write a structure.
+ * called from spoolss_r_getprinterdataex (srv_spoolss.c)
+ ********************************************************************/
+
+BOOL spoolss_io_r_getprinterdataex(char *desc, SPOOL_R_GETPRINTERDATAEX *r_u, prs_struct *ps, int depth)
+{
+       if (r_u == NULL)
+               return False;
+
+       prs_debug(ps, depth, desc, "spoolss_io_r_getprinterdataex");
+       depth++;
+
+       if (!prs_align(ps))
+               return False;
+       if (!prs_uint32("type", ps, depth, &r_u->type))
+               return False;
+       if (!prs_uint32("size", ps, depth, &r_u->size))
+               return False;
+       
+       if (!prs_uint8s(False,"data", ps, depth, r_u->data, r_u->size))
+               return False;
+               
+       if (!prs_align(ps))
+               return False;
+       
+       if (!prs_uint32("needed", ps, depth, &r_u->needed))
+               return False;
+       if (!prs_werror("status", ps, depth, &r_u->status))
+               return False;
+               
+       return True;
+}
+
+/*******************************************************************
+ * read a structure.
+ ********************************************************************/  
+
+BOOL spoolss_io_q_setprinterdataex(char *desc, SPOOL_Q_SETPRINTERDATAEX *q_u, prs_struct *ps, int depth)
+{
+       prs_debug(ps, depth, desc, "spoolss_io_q_setprinterdataex");
+       depth++;
+
+       if(!prs_align(ps))
+               return False;
+       if(!smb_io_pol_hnd("printer handle", &q_u->handle, ps, depth))
+               return False;
+       if(!smb_io_unistr2("", &q_u->key, True, ps, depth))
+               return False;
+
+       if(!prs_align(ps))
+               return False;
+
+       if(!smb_io_unistr2("", &q_u->value, True, ps, depth))
+               return False;
+
+       if(!prs_align(ps))
+               return False;
+
+       if(!prs_uint32("type", ps, depth, &q_u->type))
+               return False;
+
+       if(!prs_uint32("max_len", ps, depth, &q_u->max_len))
+               return False;
+
+       switch (q_u->type)
+       {
+               case 0x1:
+               case 0x3:
+               case 0x4:
+               case 0x7:
+                       if (q_u->max_len) {
+                               if (UNMARSHALLING(ps))
+                                       q_u->data=(uint8 *)prs_alloc_mem(ps, q_u->max_len * sizeof(uint8));
+                               if(q_u->data == NULL)
+                                       return False;
+                               if(!prs_uint8s(False,"data", ps, depth, q_u->data, q_u->max_len))
+                                       return False;
+                       }
+                       if(!prs_align(ps))
+                               return False;
+                       break;
+       }       
+       
+       if(!prs_uint32("real_len", ps, depth, &q_u->real_len))
+               return False;
+
+       return True;
+}
+
+/*******************************************************************
+ * write a structure.
+ ********************************************************************/  
+
+BOOL spoolss_io_r_setprinterdataex(char *desc, SPOOL_R_SETPRINTERDATAEX *r_u, prs_struct *ps, int depth)
+{
+       prs_debug(ps, depth, desc, "spoolss_io_r_setprinterdataex");
+       depth++;
+
+       if(!prs_align(ps))
+               return False;
+       if(!prs_werror("status",     ps, depth, &r_u->status))
+               return False;
+
+       return True;
+}
+
+
+/*******************************************************************
+ * read a structure.
+ ********************************************************************/  
+
+BOOL spoolss_io_q_enumprinterkey(char *desc, SPOOL_Q_ENUMPRINTERKEY *q_u, prs_struct *ps, int depth)
+{
+       prs_debug(ps, depth, desc, "spoolss_io_q_enumprinterkey");
+       depth++;
+
+       if(!prs_align(ps))
+               return False;
+       if(!smb_io_pol_hnd("printer handle", &q_u->handle, ps, depth))
+               return False;
+               
+       if(!smb_io_unistr2("", &q_u->key, True, ps, depth))
+               return False;
+
+       if(!prs_align(ps))
+               return False;
+       
+       if(!prs_uint32("size", ps, depth, &q_u->size))
+               return False;
+
+       return True;
+}
+
+/*******************************************************************
+ * write a structure.
+ ********************************************************************/  
+
+BOOL spoolss_io_r_enumprinterkey(char *desc, SPOOL_R_ENUMPRINTERKEY *r_u, prs_struct *ps, int depth)
+{
+       prs_debug(ps, depth, desc, "spoolss_io_r_enumprinterkey");
+       depth++;
+
+       if(!prs_align(ps))
+               return False;
+
+       if (!smb_io_buffer5("", &r_u->keys, ps, depth))
+               return False;
+       
+       if(!prs_align(ps))
+               return False;
+
+       if(!prs_uint32("needed",     ps, depth, &r_u->needed))
+               return False;
+
+       if(!prs_werror("status",     ps, depth, &r_u->status))
+               return False;
+
+       return True;
+}
+
+
+/*******************************************************************
+ * read a structure.
+ ********************************************************************/  
+
+BOOL spoolss_io_q_enumprinterdataex(char *desc, SPOOL_Q_ENUMPRINTERDATAEX *q_u, prs_struct *ps, int depth)
+{
+       prs_debug(ps, depth, desc, "spoolss_io_q_enumprinterdataex");
+       depth++;
+
+       if(!prs_align(ps))
+               return False;
+       if(!smb_io_pol_hnd("printer handle", &q_u->handle, ps, depth))
+               return False;
+               
+       if(!smb_io_unistr2("", &q_u->key, True, ps, depth))
+               return False;
+
+       if(!prs_align(ps))
+               return False;
+       
+       if(!prs_uint32("size", ps, depth, &q_u->size))
+               return False;
+
+       return True;
+}
+
+/*******************************************************************
+********************************************************************/  
+static BOOL spoolss_io_printer_enum_values_ctr(char *desc, prs_struct *ps, 
+                               PRINTER_ENUM_VALUES_CTR *ctr, int depth)
+{
+       int     i;
+       uint32  valuename_offset,
+               data_offset,
+               current_offset;
+       const uint32 basic_unit = 20; /* size of static portion of enum_values */
+       
+       prs_debug(ps, depth, desc, "spoolss_io_printer_enum_values_ctr");
+       depth++;        
+       
+       if (!prs_uint32("size", ps, depth, &ctr->size))
+               return False;
+       
+       /* offset data begins at 20 bytes per structure * size_of_array. */
+       
+       current_offset = basic_unit * ctr->size_of_array;
+       
+       /* first loop to write basic enum_value information */
+       
+       for (i=0; i<ctr->size_of_array; i++) 
+       {
+               valuename_offset = current_offset;
+               if (!prs_uint32("valuename_offset", ps, depth, &valuename_offset))
+                       return False;
+
+               if (!prs_uint32("value_len", ps, depth, &ctr->values[i].value_len))
+                       return False;
+       
+               if (!prs_uint32("type", ps, depth, &ctr->values[i].type))
+                       return False;
+       
+               data_offset = ctr->values[i].value_len + valuename_offset;
+               if (!prs_uint32("data_offset", ps, depth, &data_offset))
+                       return False;
+
+               if (!prs_uint32("data_len", ps, depth, &ctr->values[i].data_len))
+                       return False;
+                       
+               current_offset = data_offset + ctr->values[i].data_len - basic_unit;
+       
+       }
+
+       /* loop #2 for writing the dynamically size objects
+          while viewing conversations between Win2k -> Win2k,
+          4-byte alignment does not seem to matter here   --jerry */
+       
+       for (i=0; i<ctr->size_of_array; i++) 
+       {
+       
+               if (!prs_unistr("valuename", ps, depth, &ctr->values[i].valuename))
+                       return False;
+               
+               if (!prs_uint8s(False, "data", ps, depth, ctr->values[i].data, ctr->values[i].data_len))
+                       return False;
+       }
+
+               
+
+       return True;    
+}
+
+
+/*******************************************************************
+ * write a structure.
+ ********************************************************************/  
+
+BOOL spoolss_io_r_enumprinterdataex(char *desc, SPOOL_R_ENUMPRINTERDATAEX *r_u, prs_struct *ps, int depth)
+{
+       prs_debug(ps, depth, desc, "spoolss_io_r_enumprinterdataex");
+       depth++;
+
+       if(!prs_align(ps))
+               return False;
+               
+       if (!spoolss_io_printer_enum_values_ctr("", ps, &r_u->ctr, depth ))
+               return False;
+       
+       if(!prs_align(ps))
+               return False;
+
+       if(!prs_uint32("needed",     ps, depth, &r_u->needed))
+               return False;
+               
+       if(!prs_uint32("returned",   ps, depth, &r_u->returned))
+               return False;
+
+       if(!prs_werror("status",     ps, depth, &r_u->status))
+               return False;
+
+       return True;
+}
+
+
+/*******************************************************************
+ * write a structure.
+ ********************************************************************/  
+
+/* 
+   uint32 GetPrintProcessorDirectory(
+       [in] unistr2 *name,
+       [in] unistr2 *environment,
+       [in] uint32 level,
+       [in,out] NEW_BUFFER buffer,
+       [in] uint32 offered,
+       [out] uint32 needed,
+       [out] uint32 returned
+   );
+
+*/
+
+BOOL make_spoolss_q_getprintprocessordirectory(SPOOL_Q_GETPRINTPROCESSORDIRECTORY *q_u, const char *name, char *environment, int level, NEW_BUFFER *buffer, uint32 offered)
+{
+       DEBUG(5,("make_spoolss_q_getprintprocessordirectory\n"));
+
+       init_unistr2(&q_u->name, name, strlen(name)+1);
+       init_unistr2(&q_u->environment, environment, strlen(environment)+1);
+
+       q_u->level = level;
+
+       q_u->buffer = buffer;
+       q_u->offered = offered;
+
+       return True;
+}
+
+BOOL spoolss_io_q_getprintprocessordirectory(char *desc, SPOOL_Q_GETPRINTPROCESSORDIRECTORY *q_u, prs_struct *ps, int depth)
+{
+       uint32 ptr;
+
+       prs_debug(ps, depth, desc, "spoolss_io_q_getprintprocessordirectory");
+       depth++;
+
+       if(!prs_align(ps))
+               return False;   
+
+       if (!prs_uint32("ptr", ps, depth, &ptr)) 
+               return False;
+
+       if (ptr) {
+               if(!smb_io_unistr2("name", &q_u->name, True, ps, depth))
+                       return False;
+       }
+
+       if (!prs_align(ps))
+               return False;
+
+       if (!prs_uint32("ptr", ps, depth, &ptr))
+               return False;
+
+       if (ptr) {
+               if(!smb_io_unistr2("environment", &q_u->environment, True, 
+                                  ps, depth))
+                       return False;
+       }
+
+       if (!prs_align(ps))
+               return False;
+
+       if(!prs_uint32("level",   ps, depth, &q_u->level))
+               return False;
+
+       if(!spoolss_io_buffer("", ps, depth, &q_u->buffer))
+               return False;
+       
+       if(!prs_align(ps))
+               return False;
+
+       if(!prs_uint32("offered", ps, depth, &q_u->offered))
+               return False;
+
+       return True;
+}
+
+/*******************************************************************
+ * write a structure.
+ ********************************************************************/  
+
+BOOL spoolss_io_r_getprintprocessordirectory(char *desc, SPOOL_R_GETPRINTPROCESSORDIRECTORY *r_u, prs_struct *ps, int depth)
+{
+       prs_debug(ps, depth, desc, "spoolss_io_r_getprintprocessordirectory");
+       depth++;
+
+       if(!prs_align(ps))
+               return False;
+
+       if(!spoolss_io_buffer("", ps, depth, &r_u->buffer))
+               return False;
+       
+       if(!prs_align(ps))
+               return False;
+
+       if(!prs_uint32("needed",     ps, depth, &r_u->needed))
+               return False;
+               
+       if(!prs_werror("status",     ps, depth, &r_u->status))
+               return False;
+
+       return True;
+}
+
+BOOL smb_io_printprocessordirectory_1(char *desc, NEW_BUFFER *buffer, PRINTPROCESSOR_DIRECTORY_1 *info, int depth)
+{
+       prs_struct *ps=&buffer->prs;
+
+       prs_debug(ps, depth, desc, "smb_io_printprocessordirectory_1");
+       depth++;
+
+       buffer->struct_start=prs_offset(ps);
+
+       if (!smb_io_unistr(desc, &info->name, ps, depth))
+               return False;
+
+       return True;
+}