added SAMR_USER_INFO_24 info level to samr_set_userinfo. this is used
[samba.git] / source3 / rpc_parse / parse_samr.c
index f85dd418ad77de16b6b6e6eaa1b3457e3ce3082a..09c881a812f7e11630994a350b477ab3bf17ca26 100644 (file)
@@ -87,7 +87,7 @@ void make_samr_q_lookup_domain(SAMR_Q_LOOKUP_DOMAIN *q_u,
 
        memcpy(&(q_u->connect_pol), pol, sizeof(*pol));
 
-       make_uni_hdr(&(q_u->hdr_domain), len_name, len_name, 1);
+       make_uni_hdr(&(q_u->hdr_domain), len_name);
        make_unistr2(&(q_u->uni_domain), dom_name, len_name);
 }
 
@@ -389,8 +389,8 @@ void make_unk_info2(SAM_UNK_INFO_2 *u_2, char *domain, char *server)
        u_2->unknown_2 = 0x00000000;
 
        u_2->ptr_0 = 1;
-       make_uni_hdr(&(u_2->hdr_domain), len_domain, len_domain, 1);
-       make_uni_hdr(&(u_2->hdr_server), len_server, len_server, 1);
+       make_uni_hdr(&(u_2->hdr_domain), len_domain);
+       make_uni_hdr(&(u_2->hdr_server), len_server);
 
        u_2->seq_num = 0x10000000;
        u_2->unknown_3 = 0x00000000;
@@ -449,6 +449,38 @@ void sam_io_unk_info2(char *desc, SAM_UNK_INFO_2 *u_2, prs_struct *ps, int depth
 
 }
 
+/*******************************************************************
+makes a structure.
+********************************************************************/
+void make_unk_info1(SAM_UNK_INFO_1 *u_1)
+{
+       if (u_1 == NULL) return;
+
+       memset(u_1->padding, 0, sizeof(u_1->padding)); /* 12 bytes zeros */
+       u_1->unknown_1 = 0x80000000;
+       u_1->unknown_2 = 0x00000000;
+       u_1->unknown_3 = 0x00000000;
+}
+
+/*******************************************************************
+reads or writes a structure.
+********************************************************************/
+void sam_io_unk_info1(char *desc, SAM_UNK_INFO_1 *u_1, prs_struct *ps, int depth)
+{
+       if (u_1 == NULL) return;
+
+       prs_debug(ps, depth, desc, "sam_io_unk_info1");
+       depth++;
+
+       prs_uint8s(False, "padding", ps, depth, u_1->padding, sizeof(u_1->padding)); /* 12 bytes zeros */
+
+       prs_uint32("unknown_1", ps, depth, &u_1->unknown_1); /* 0x8000 0000 */
+       prs_uint32("unknown_2", ps, depth, &u_1->unknown_2); /* 0x0000 0000 */
+       prs_uint32("unknown_3", ps, depth, &u_1->unknown_3); /* 0x0000 0000 */
+
+       prs_align(ps);
+}
+
 /*******************************************************************
 makes a SAMR_R_QUERY_DOMAIN_INFO structure.
 ********************************************************************/
@@ -507,6 +539,11 @@ void samr_io_r_query_dom_info(char *desc, SAMR_R_QUERY_DOMAIN_INFO *r_u, prs_str
                                sam_io_unk_info2("unk_inf2", &r_u->ctr->info.inf2, ps, depth);
                                break;
                        }
+                       case 0x01:
+                       {
+                               sam_io_unk_info1("unk_inf1", &r_u->ctr->info.inf1, ps, depth);
+                               break;
+                       }
                        default:
                        {
                                DEBUG(3,("samr_io_r_query_dom_info: unknown switch level 0x%x\n",
@@ -758,9 +795,9 @@ static void make_sam_entry1(SAM_ENTRY1 *sam, uint32 user_idx,
        sam->acb_info = acb_info;
        sam->pad      = 0;
 
-       make_uni_hdr(&(sam->hdr_acct_name), len_sam_name, len_sam_name, len_sam_name != 0);
-       make_uni_hdr(&(sam->hdr_user_name), len_sam_full, len_sam_full, len_sam_full != 0);
-       make_uni_hdr(&(sam->hdr_user_desc), len_sam_desc, len_sam_desc, len_sam_desc != 0);
+       make_uni_hdr(&(sam->hdr_acct_name), len_sam_name);
+       make_uni_hdr(&(sam->hdr_user_name), len_sam_full);
+       make_uni_hdr(&(sam->hdr_user_desc), len_sam_desc);
 }
 
 /*******************************************************************
@@ -818,8 +855,8 @@ static void make_sam_entry2(SAM_ENTRY2 *sam, uint32 user_idx,
        sam->acb_info = acb_info;
        sam->pad      = 0;
 
-       make_uni_hdr(&(sam->hdr_srv_name), len_sam_name, len_sam_name, len_sam_name != 0);
-       make_uni_hdr(&(sam->hdr_srv_desc), len_sam_desc, len_sam_desc, len_sam_desc != 0);
+       make_uni_hdr(&(sam->hdr_srv_name), len_sam_name);
+       make_uni_hdr(&(sam->hdr_srv_desc), len_sam_desc);
 }
 
 /*******************************************************************
@@ -874,8 +911,8 @@ static void make_sam_entry3(SAM_ENTRY3 *sam, uint32 grp_idx,
        sam->rid_grp = rid_grp;
        sam->attr    = 0x07; /* group rid attributes - gets ignored by nt 4.0 */
 
-       make_uni_hdr(&(sam->hdr_grp_name), len_grp_name, len_grp_name, len_grp_name != 0);
-       make_uni_hdr(&(sam->hdr_grp_desc), len_grp_desc, len_grp_desc, len_grp_desc != 0);
+       make_uni_hdr(&(sam->hdr_grp_name), len_grp_name);
+       make_uni_hdr(&(sam->hdr_grp_desc), len_grp_desc);
 }
 
 /*******************************************************************
@@ -971,7 +1008,7 @@ static void make_sam_entry(SAM_ENTRY *sam, uint32 len_sam_name, uint32 rid)
        DEBUG(5,("make_sam_entry\n"));
 
        sam->rid = rid;
-       make_uni_hdr(&(sam->hdr_name), len_sam_name, len_sam_name, len_sam_name != 0);
+       make_uni_hdr(&(sam->hdr_name), len_sam_name);
 }
 
 /*******************************************************************
@@ -1047,14 +1084,9 @@ void make_samr_r_enum_dom_users(SAMR_R_ENUM_DOM_USERS *r_u,
 
        DEBUG(5,("make_samr_r_enum_dom_users\n"));
 
-       if (num_sam_entries >= MAX_SAM_ENTRIES)
-       {
-               num_sam_entries = MAX_SAM_ENTRIES;
-               DEBUG(5,("limiting number of entries to %d\n",
-                        num_sam_entries));
-       }
-
        r_u->next_idx = next_idx;
+       r_u->sam = NULL;
+       r_u->uni_acct_name = NULL;
 
        if (num_sam_entries != 0)
        {
@@ -1063,8 +1095,14 @@ void make_samr_r_enum_dom_users(SAMR_R_ENUM_DOM_USERS *r_u,
                r_u->num_entries2 = num_sam_entries;
                r_u->num_entries3 = num_sam_entries;
 
-               SMB_ASSERT_ARRAY(r_u->sam, num_sam_entries);
-               SMB_ASSERT_ARRAY(r_u->uni_acct_name, num_sam_entries);
+               r_u->sam = Realloc(NULL, r_u->num_entries2 * sizeof(r_u->sam[0]));
+               r_u->uni_acct_name = Realloc(NULL, r_u->num_entries2 * sizeof(r_u->uni_acct_name[0]));
+
+               if (r_u->sam == NULL || r_u->uni_acct_name == NULL)
+               {
+                       DEBUG(0,("NULL pointers in SAMR_R_QUERY_DISPINFO\n"));
+                       return;
+               }
 
                for (i = 0; i < num_sam_entries; i++)
                {
@@ -1110,7 +1148,17 @@ void samr_io_r_enum_dom_users(char *desc,  SAMR_R_ENUM_DOM_USERS *r_u, prs_struc
                prs_uint32("ptr_entries2", ps, depth, &(r_u->ptr_entries2));
                prs_uint32("num_entries3", ps, depth, &(r_u->num_entries3));
 
-               SMB_ASSERT_ARRAY(r_u->sam, r_u->num_entries2);
+               if (ps->io)
+               {
+                       r_u->sam = Realloc(NULL, r_u->num_entries2 * sizeof(r_u->sam[0]));
+                       r_u->uni_acct_name = Realloc(NULL, r_u->num_entries2 * sizeof(r_u->uni_acct_name[0]));
+               }
+
+               if ((r_u->sam == NULL || r_u->uni_acct_name == NULL) && r_u->num_entries2 != 0)
+               {
+                       DEBUG(0,("NULL pointers in SAMR_R_QUERY_DISPINFO\n"));
+                       return;
+               }
 
                for (i = 0; i < r_u->num_entries2; i++)
                {
@@ -1118,8 +1166,6 @@ void samr_io_r_enum_dom_users(char *desc,  SAMR_R_ENUM_DOM_USERS *r_u, prs_struc
                        sam_io_sam_entry("", &(r_u->sam[i]), ps, depth);
                }
 
-               SMB_ASSERT_ARRAY(r_u->uni_acct_name, r_u->num_entries2);
-
                for (i = 0; i < r_u->num_entries2; i++)
                {
                        prs_grow(ps);
@@ -1614,6 +1660,7 @@ void samr_io_r_query_dispinfo(char *desc, SAMR_R_QUERY_DISPINFO *r_u, prs_struct
                }
        }
 
+       prs_align(ps);
        prs_align(ps);
        prs_uint32("status", ps, depth, &(r_u->status));
 }
@@ -1683,12 +1730,12 @@ void make_samr_group_info1(GROUP_INFO1 *gr1,
 
        DEBUG(5,("make_samr_group_info1\n"));
 
-       make_uni_hdr(&(gr1->hdr_acct_name), acct_len , acct_len, acct_name ? 1 : 0);
+       make_uni_hdr(&(gr1->hdr_acct_name), acct_len);
 
        gr1->unknown_1 = 0x3;
        gr1->unknown_2 = 0x3;
 
-       make_uni_hdr(&(gr1->hdr_acct_desc), desc_len , desc_len, acct_desc ? 1 : 0);
+       make_uni_hdr(&(gr1->hdr_acct_desc), desc_len);
 
        make_unistr2(&(gr1->uni_acct_name), acct_name, acct_len);
        make_unistr2(&(gr1->uni_acct_desc), acct_desc, desc_len);
@@ -1730,7 +1777,7 @@ void make_samr_group_info4(GROUP_INFO4 *gr4, const char *acct_desc)
 
        DEBUG(5,("make_samr_group_info4\n"));
 
-       make_uni_hdr(&(gr4->hdr_acct_desc), acct_len , acct_len, acct_desc ? 1 : 0);
+       make_uni_hdr(&(gr4->hdr_acct_desc), acct_len);
        make_unistr2(&(gr4->uni_acct_desc), acct_desc, acct_len);
 }
 
@@ -1801,7 +1848,7 @@ void make_samr_q_create_dom_group(SAMR_Q_CREATE_DOM_GROUP *q_e,
 
        memcpy(&(q_e->pol), pol, sizeof(*pol));
 
-       make_uni_hdr(&(q_e->hdr_acct_desc), acct_len , acct_len, acct_desc ? 1 : 0);
+       make_uni_hdr(&(q_e->hdr_acct_desc), acct_len);
        make_unistr2(&(q_e->uni_acct_desc), acct_desc, acct_len);
 
        q_e->unknown_1 = 0x0002;
@@ -2675,7 +2722,7 @@ void make_samr_alias_info3(ALIAS_INFO3 *al3, const char *acct_desc)
 
        DEBUG(5,("make_samr_alias_info3\n"));
 
-       make_uni_hdr(&(al3->hdr_acct_desc), acct_len , acct_len, acct_desc ? 1 : 0);
+       make_uni_hdr(&(al3->hdr_acct_desc), acct_len);
        make_unistr2(&(al3->uni_acct_desc), acct_desc, acct_len);
 }
 
@@ -3116,7 +3163,7 @@ void make_samr_r_lookup_rids(SAMR_R_LOOKUP_RIDS *r_u,
                for (i = 0; i < num_names; i++)
                {
                        int len = name[i] != NULL ? strlen(name[i]) : 0;
-                       make_uni_hdr(&(r_u->hdr_name[i]), len    , len, name[i] ? 1 : 0);
+                       make_uni_hdr(&(r_u->hdr_name[i]), len);
                        make_unistr2(&(r_u->uni_name[i]), name[i], len);
                        r_u->type[i] = type[i];
                }
@@ -3248,7 +3295,7 @@ void make_samr_q_create_dom_alias(SAMR_Q_CREATE_DOM_ALIAS *q_u, POLICY_HND *hnd,
 
        memcpy(&(q_u->dom_pol), hnd, sizeof(q_u->dom_pol));
 
-       make_uni_hdr(&(q_u->hdr_acct_desc), acct_len , acct_len, acct_desc ? 1 : 0);
+       make_uni_hdr(&(q_u->hdr_acct_desc), acct_len);
        make_unistr2(&(q_u->uni_acct_desc), acct_desc, acct_len);
 
        q_u->unknown_1 = 0x001f;
@@ -3583,7 +3630,7 @@ void make_samr_q_lookup_names(SAMR_Q_LOOKUP_NAMES *q_u,
        for (i = 0; i < num_names; i++)
        {
                int len_name = name[i] != NULL ? strlen(name[i]) : 0;
-               make_uni_hdr(&(q_u->hdr_name[i]), len_name, len_name, name[i] != NULL);  /* unicode header for user_name */
+               make_uni_hdr(&(q_u->hdr_name[i]), len_name);  /* unicode header for user_name */
                make_unistr2(&(q_u->uni_name[i]), name[i], len_name);  /* unicode string for machine account */
        }
 }
@@ -3688,10 +3735,17 @@ void samr_io_r_lookup_names(char *desc,  SAMR_R_LOOKUP_NAMES *r_u, prs_struct *p
 
        prs_uint32("num_rids1", ps, depth, &(r_u->num_rids1));
        prs_uint32("ptr_rids ", ps, depth, &(r_u->ptr_rids ));
-       prs_uint32("num_rids2", ps, depth, &(r_u->num_rids2));
 
-       if (r_u->ptr_rids != 0 && r_u->num_rids1 != 0)
+       if (r_u->ptr_rids != 0)
        {
+               prs_uint32("num_rids2", ps, depth, &(r_u->num_rids2));
+
+               if (r_u->num_rids2 != r_u->num_rids1)
+               {
+                       /* RPC fault */
+                       return;
+               }
+
                for (i = 0; i < r_u->num_rids2; i++)
                {
                        prs_grow(ps);
@@ -3702,10 +3756,17 @@ void samr_io_r_lookup_names(char *desc,  SAMR_R_LOOKUP_NAMES *r_u, prs_struct *p
 
        prs_uint32("num_types1", ps, depth, &(r_u->num_types1));
        prs_uint32("ptr_types ", ps, depth, &(r_u->ptr_types ));
-       prs_uint32("num_types2", ps, depth, &(r_u->num_types2));
 
-       if (r_u->ptr_types != 0 && r_u->num_types1 != 0)
+       if (r_u->ptr_types != 0)
        {
+               prs_uint32("num_types2", ps, depth, &(r_u->num_types2));
+
+               if (r_u->num_types2 != r_u->num_types1)
+               {
+                       /* RPC fault */
+                       return;
+               }
+
                for (i = 0; i < r_u->num_types2; i++)
                {
                        prs_grow(ps);
@@ -3790,7 +3851,7 @@ void make_samr_q_create_user(SAMR_Q_CREATE_USER *q_u,
 
        memcpy(&q_u->domain_pol, pol, sizeof(q_u->domain_pol));
        
-       make_uni_hdr(&(q_u->hdr_name), len_name, len_name, 1);  
+       make_uni_hdr(&(q_u->hdr_name), len_name);  
        make_unistr2(&(q_u->uni_name), name, len_name);
 
        q_u->acb_info = acb_info;
@@ -3823,6 +3884,25 @@ void samr_io_q_create_user(char *desc,  SAMR_Q_CREATE_USER *q_u, prs_struct *ps,
        prs_align(ps);
 }
 
+/*******************************************************************
+reads or writes a structure.
+********************************************************************/
+void make_samr_r_create_user(SAMR_R_CREATE_USER *r_u,
+                               POLICY_HND *user_pol,
+                               uint32 unk_0, uint32 user_rid,
+                               uint32 status)
+{
+       if (r_u == NULL) return;
+
+       DEBUG(5,("samr_make_samr_r_create_user\n"));
+
+       memcpy(&r_u->user_pol, user_pol, sizeof(r_u->user_pol));
+       
+       r_u->unknown_0 = unk_0;
+       r_u->user_rid = user_rid;
+       r_u->status = status;
+}
+
 /*******************************************************************
 reads or writes a structure.
 ********************************************************************/
@@ -3950,7 +4030,7 @@ void make_sam_user_info11(SAM_USER_INFO_11 *usr,
        memcpy(&(usr->expiry),expiry, sizeof(usr->expiry)); /* expiry time or something? */
        bzero(usr->padding_1, sizeof(usr->padding_1)); /* 0 - padding 24 bytes */
 
-       make_uni_hdr(&(usr->hdr_mach_acct), len_mach_acct, len_mach_acct, 4);  /* unicode header for machine account */
+       make_uni_hdr(&(usr->hdr_mach_acct), len_mach_acct);  /* unicode header for machine account */
        usr->padding_2 = 0;               /* 0 - padding 4 bytes */
 
        usr->ptr_1        = 1;            /* pointer */
@@ -4025,6 +4105,217 @@ void sam_io_user_info11(char *desc,  SAM_USER_INFO_11 *usr, prs_struct *ps, int
        prs_uint8s (False, "padding_9", ps, depth, usr->padding_9, sizeof(usr->padding_9));
 }
 
+/*************************************************************************
+ make_sam_user_infoa
+
+ unknown_3 = 0x09f8 27fa
+ unknown_5 = 0x0001 0000
+ unknown_6 = 0x0000 04ec 
+
+ *************************************************************************/
+void make_sam_user_info_24(SAM_USER_INFO_24 *usr,
+       char newpass[516])
+{
+       memcpy(usr->pass, newpass, sizeof(usr->pass));
+}
+
+/*******************************************************************
+reads or writes a structure.
+********************************************************************/
+static void sam_io_user_info_24(char *desc,  SAM_USER_INFO_24 *usr, prs_struct *ps, int depth)
+{
+       if (usr == NULL) return;
+
+       prs_debug(ps, depth, desc, "lsa_io_user_info");
+       depth++;
+
+       prs_align(ps);
+       
+       prs_uint8s (False, "password", ps, depth, usr->pass, sizeof(usr->pass));
+       prs_align(ps);
+}
+
+
+/*************************************************************************
+ make_sam_user_info23
+
+ unknown_3 = 0x09f8 27fa
+ unknown_5 = 0x0001 0000
+ unknown_6 = 0x0000 04ec 
+
+ *************************************************************************/
+void make_sam_user_info23(SAM_USER_INFO_23 *usr,
+
+       NTTIME *logon_time, /* all zeros */
+       NTTIME *logoff_time, /* all zeros */
+       NTTIME *kickoff_time, /* all zeros */
+       NTTIME *pass_last_set_time, /* all zeros */
+       NTTIME *pass_can_change_time, /* all zeros */
+       NTTIME *pass_must_change_time, /* all zeros */
+
+       char *user_name, /* NULL */
+       char *full_name,
+       char *home_dir,
+       char *dir_drive,
+       char *logon_script,
+       char *profile_path,
+       char *description,
+       char *workstations,
+       char *unknown_str,
+       char *munged_dial,
+
+       uint32 user_rid, /* 0x0000 0000 */
+       uint32 group_rid,
+       uint16 acb_info, 
+
+       uint32 unknown_3,
+       uint16 logon_divs,
+       LOGON_HRS *hrs,
+       uint32 unknown_5,
+       char newpass[516],
+       uint32 unknown_6)
+{
+       int len_user_name    = user_name    != NULL ? strlen(user_name   ) : 0;
+       int len_full_name    = full_name    != NULL ? strlen(full_name   ) : 0;
+       int len_home_dir     = home_dir     != NULL ? strlen(home_dir    ) : 0;
+       int len_dir_drive    = dir_drive    != NULL ? strlen(dir_drive   ) : 0;
+       int len_logon_script = logon_script != NULL ? strlen(logon_script) : 0;
+       int len_profile_path = profile_path != NULL ? strlen(profile_path) : 0;
+       int len_description  = description  != NULL ? strlen(description ) : 0;
+       int len_workstations = workstations != NULL ? strlen(workstations) : 0;
+       int len_unknown_str  = unknown_str  != NULL ? strlen(unknown_str ) : 0;
+       int len_munged_dial  = munged_dial  != NULL ? strlen(munged_dial ) : 0;
+
+       usr->logon_time            = *logon_time; /* all zeros */
+       usr->logoff_time           = *logoff_time; /* all zeros */
+       usr->kickoff_time          = *kickoff_time; /* all zeros */
+       usr->pass_last_set_time    = *pass_last_set_time; /* all zeros */
+       usr->pass_can_change_time  = *pass_can_change_time; /* all zeros */
+       usr->pass_must_change_time = *pass_must_change_time; /* all zeros */
+
+       make_uni_hdr(&(usr->hdr_user_name   ), len_user_name   ); /* NULL */
+       make_uni_hdr(&(usr->hdr_full_name   ), len_full_name   );
+       make_uni_hdr(&(usr->hdr_home_dir    ), len_home_dir    );
+       make_uni_hdr(&(usr->hdr_dir_drive   ), len_dir_drive   );
+       make_uni_hdr(&(usr->hdr_logon_script), len_logon_script);
+       make_uni_hdr(&(usr->hdr_profile_path), len_profile_path);
+       make_uni_hdr(&(usr->hdr_acct_desc   ), len_description );
+       make_uni_hdr(&(usr->hdr_workstations), len_workstations);
+       make_uni_hdr(&(usr->hdr_unknown_str ), len_unknown_str );
+       make_uni_hdr(&(usr->hdr_munged_dial ), len_munged_dial );
+
+       bzero(usr->nt_pwd, sizeof(usr->nt_pwd));
+       bzero(usr->lm_pwd, sizeof(usr->lm_pwd));
+
+       usr->user_rid  = user_rid; /* 0x0000 0000 */
+       usr->group_rid = group_rid;
+       usr->acb_info = acb_info;
+       usr->unknown_3 = unknown_3; /* 09f8 27fa */
+
+       usr->logon_divs = logon_divs; /* should be 168 (hours/week) */
+       usr->ptr_logon_hrs = hrs ? 1 : 0;
+
+       bzero(usr->padding1, sizeof(usr->padding1));
+
+       usr->unknown_5 = unknown_5; /* 0x0001 0000 */
+
+       memcpy(usr->pass, newpass, sizeof(usr->pass));
+
+       make_unistr2(&(usr->uni_user_name   ), user_name   , len_user_name   ); /* NULL */
+       make_unistr2(&(usr->uni_full_name   ), full_name   , len_full_name   );
+       make_unistr2(&(usr->uni_home_dir    ), home_dir    , len_home_dir    );
+       make_unistr2(&(usr->uni_dir_drive   ), dir_drive   , len_dir_drive   );
+       make_unistr2(&(usr->uni_logon_script), logon_script, len_logon_script);
+       make_unistr2(&(usr->uni_profile_path), profile_path, len_profile_path);
+       make_unistr2(&(usr->uni_acct_desc ), description , len_description );
+       make_unistr2(&(usr->uni_workstations), workstations, len_workstations);
+       make_unistr2(&(usr->uni_unknown_str ), unknown_str , len_unknown_str );
+       make_unistr2(&(usr->uni_munged_dial ), munged_dial , len_munged_dial );
+
+       usr->unknown_6 = unknown_6; /* 0x0000 04ec */
+       usr->padding4 = 0;
+
+       if (hrs)
+       {
+               memcpy(&(usr->logon_hrs), hrs, sizeof(usr->logon_hrs));
+       }
+       else
+       {
+               memset(&(usr->logon_hrs), 0xff, sizeof(usr->logon_hrs));
+       }
+}
+
+/*******************************************************************
+reads or writes a structure.
+********************************************************************/
+static void sam_io_user_info23(char *desc,  SAM_USER_INFO_23 *usr, prs_struct *ps, int depth)
+{
+       if (usr == NULL) return;
+
+       prs_debug(ps, depth, desc, "lsa_io_user_info");
+       depth++;
+
+       prs_align(ps);
+       
+       smb_io_time("logon_time           ", &(usr->logon_time)           , ps, depth);
+       smb_io_time("logoff_time          ", &(usr->logoff_time)          , ps, depth); 
+       smb_io_time("kickoff_time         ", &(usr->kickoff_time)         , ps, depth); 
+       smb_io_time("pass_last_set_time   ", &(usr->pass_last_set_time)   , ps, depth); 
+       smb_io_time("pass_can_change_time ", &(usr->pass_can_change_time) , ps, depth); 
+       smb_io_time("pass_must_change_time", &(usr->pass_must_change_time), ps, depth); 
+
+       smb_io_unihdr("hdr_user_name   ", &(usr->hdr_user_name)   , ps, depth); /* username unicode string header */
+       smb_io_unihdr("hdr_full_name   ", &(usr->hdr_full_name)   , ps, depth); /* user's full name unicode string header */
+       smb_io_unihdr("hdr_home_dir    ", &(usr->hdr_home_dir)    , ps, depth); /* home directory unicode string header */
+       smb_io_unihdr("hdr_dir_drive   ", &(usr->hdr_dir_drive)   , ps, depth); /* home directory drive */
+       smb_io_unihdr("hdr_logon_script", &(usr->hdr_logon_script), ps, depth); /* logon script unicode string header */
+       smb_io_unihdr("hdr_profile_path", &(usr->hdr_profile_path), ps, depth); /* profile path unicode string header */
+       smb_io_unihdr("hdr_acct_desc   ", &(usr->hdr_acct_desc  ) , ps, depth); /* account description */
+       smb_io_unihdr("hdr_workstations", &(usr->hdr_workstations), ps, depth); /* workstations user can log on from */
+       smb_io_unihdr("hdr_unknown_str ", &(usr->hdr_unknown_str ), ps, depth); /* unknown string */
+       smb_io_unihdr("hdr_munged_dial ", &(usr->hdr_munged_dial ), ps, depth); /* workstations user can log on from */
+
+       prs_uint8s (False, "lm_pwd        ", ps, depth, usr->lm_pwd   , sizeof(usr->lm_pwd   ));
+       prs_uint8s (False, "nt_pwd        ", ps, depth, usr->nt_pwd   , sizeof(usr->nt_pwd   ));
+
+       prs_uint32("user_rid      ", ps, depth, &(usr->user_rid     ));       /* User ID */
+       prs_uint32("group_rid     ", ps, depth, &(usr->group_rid    ));      /* Group ID */
+       prs_uint16("acb_info      ", ps, depth, &(usr->acb_info     ));      /* Group ID */
+       prs_align(ps);
+
+       prs_uint32("unknown_3     ", ps, depth, &(usr->unknown_3    ));
+       prs_uint16("logon_divs    ", ps, depth, &(usr->logon_divs   ));     /* logon divisions per week */
+       prs_align(ps);
+       prs_uint32("ptr_logon_hrs ", ps, depth, &(usr->ptr_logon_hrs));
+       prs_uint8s (False, "padding1      ", ps, depth, usr->padding1, sizeof(usr->padding1));
+       prs_uint32("unknown_5     ", ps, depth, &(usr->unknown_5    ));
+
+       prs_uint8s (False, "password      ", ps, depth, usr->pass, sizeof(usr->pass));
+
+       /* here begins pointed-to data */
+
+       smb_io_unistr2("uni_user_name   ", &(usr->uni_user_name)   , usr->hdr_user_name   .buffer, ps, depth); /* username unicode string */
+       smb_io_unistr2("uni_full_name   ", &(usr->uni_full_name)   , usr->hdr_full_name   .buffer, ps, depth); /* user's full name unicode string */
+       smb_io_unistr2("uni_home_dir    ", &(usr->uni_home_dir)    , usr->hdr_home_dir    .buffer, ps, depth); /* home directory unicode string */
+       smb_io_unistr2("uni_dir_drive   ", &(usr->uni_dir_drive)   , usr->hdr_dir_drive   .buffer, ps, depth); /* home directory drive unicode string */
+       smb_io_unistr2("uni_logon_script", &(usr->uni_logon_script), usr->hdr_logon_script.buffer, ps, depth); /* logon script unicode string */
+       smb_io_unistr2("uni_profile_path", &(usr->uni_profile_path), usr->hdr_profile_path.buffer, ps, depth); /* profile path unicode string */
+       smb_io_unistr2("uni_acct_desc   ", &(usr->uni_acct_desc   ), usr->hdr_acct_desc   .buffer, ps, depth); /* user description unicode string */
+       smb_io_unistr2("uni_workstations", &(usr->uni_workstations), usr->hdr_workstations.buffer, ps, depth); /* worksations user can log on from */
+       smb_io_unistr2("uni_unknown_str ", &(usr->uni_unknown_str ), usr->hdr_unknown_str .buffer, ps, depth); /* unknown string */
+       smb_io_unistr2("uni_munged_dial ", &(usr->uni_munged_dial ), usr->hdr_munged_dial .buffer, ps, depth); /* worksations user can log on from */
+
+       prs_uint32("unknown_6     ", ps, depth, &(usr->unknown_6  ));
+       prs_uint32("padding4      ", ps, depth, &(usr->padding4   ));
+
+       if (usr->ptr_logon_hrs)
+       {
+               sam_io_logon_hrs("logon_hrs", &(usr->logon_hrs)   , ps, depth);
+               prs_align(ps);
+       }
+}
+
+
 /*************************************************************************
  make_sam_user_info21
 
@@ -4081,16 +4372,16 @@ void make_sam_user_info21(SAM_USER_INFO_21 *usr,
        usr->pass_can_change_time  = *pass_can_change_time;
        usr->pass_must_change_time = *pass_must_change_time;
 
-       make_uni_hdr(&(usr->hdr_user_name   ), len_user_name   , len_user_name   , 1);
-       make_uni_hdr(&(usr->hdr_full_name   ), len_full_name   , len_full_name   , 1);
-       make_uni_hdr(&(usr->hdr_home_dir    ), len_home_dir    , len_home_dir    , 1);
-       make_uni_hdr(&(usr->hdr_dir_drive   ), len_dir_drive   , len_dir_drive   , 1);
-       make_uni_hdr(&(usr->hdr_logon_script), len_logon_script, len_logon_script, 1);
-       make_uni_hdr(&(usr->hdr_profile_path), len_profile_path, len_profile_path, 1);
-       make_uni_hdr(&(usr->hdr_acct_desc   ), len_description , len_description , 1);
-       make_uni_hdr(&(usr->hdr_workstations), len_workstations, len_workstations, 1);
-       make_uni_hdr(&(usr->hdr_unknown_str ), len_unknown_str , len_unknown_str , 1);
-       make_uni_hdr(&(usr->hdr_munged_dial ), len_munged_dial , len_munged_dial , 1);
+       make_uni_hdr(&(usr->hdr_user_name   ), len_user_name   );
+       make_uni_hdr(&(usr->hdr_full_name   ), len_full_name   );
+       make_uni_hdr(&(usr->hdr_home_dir    ), len_home_dir    );
+       make_uni_hdr(&(usr->hdr_dir_drive   ), len_dir_drive   );
+       make_uni_hdr(&(usr->hdr_logon_script), len_logon_script);
+       make_uni_hdr(&(usr->hdr_profile_path), len_profile_path);
+       make_uni_hdr(&(usr->hdr_acct_desc   ), len_description );
+       make_uni_hdr(&(usr->hdr_workstations), len_workstations);
+       make_uni_hdr(&(usr->hdr_unknown_str ), len_unknown_str );
+       make_uni_hdr(&(usr->hdr_munged_dial ), len_munged_dial );
 
        bzero(usr->nt_pwd, sizeof(usr->nt_pwd));
        bzero(usr->lm_pwd, sizeof(usr->lm_pwd));
@@ -4329,14 +4620,54 @@ void samr_io_r_query_userinfo(char *desc,  SAMR_R_QUERY_USERINFO *r_u, prs_struc
        prs_uint32("status", ps, depth, &(r_u->status));
 }
 
+/*******************************************************************
+makes a SAMR_Q_SET_USERINFO structure.
+********************************************************************/
+void make_samr_q_set_userinfo(SAMR_Q_SET_USERINFO *q_u,
+                               POLICY_HND *hnd,
+                               uint16 switch_value, void *info)
+{
+       if (q_u == NULL || hnd == NULL) return;
+
+       DEBUG(5,("make_samr_q_set_userinfo\n"));
+
+       memcpy(&(q_u->pol), hnd, sizeof(q_u->pol));
+       q_u->switch_value  = switch_value;
+       q_u->switch_value2 = switch_value;
+
+       switch (switch_value)
+       {
+               case 0x18:
+               {
+                       q_u->info.id24 = (SAM_USER_INFO_24*)info;
+
+                       break;
+               }
+
+               case 0x17:
+               {
+                       q_u->info.id23 = (SAM_USER_INFO_23*)info;
+
+                       break;
+               }
+
+               default:
+               {
+                       DEBUG(4,("make_samr_q_set_userinfo: unsupported switch level\n"));
+                       break;
+               }
+       }
+}
+
+
 /*******************************************************************
 reads or writes a structure.
 ********************************************************************/
-void samr_io_q_unknown_32(char *desc,  SAMR_Q_UNKNOWN_32 *q_u, prs_struct *ps, int depth)
+void samr_io_q_set_userinfo(char *desc, SAMR_Q_SET_USERINFO *q_u, prs_struct *ps, int depth)
 {
        if (q_u == NULL) return;
 
-       prs_debug(ps, depth, desc, "samr_io_q_unknown_32");
+       prs_debug(ps, depth, desc, "samr_io_q_set_userinfo");
        depth++;
 
        prs_align(ps);
@@ -4344,35 +4675,77 @@ void samr_io_q_unknown_32(char *desc,  SAMR_Q_UNKNOWN_32 *q_u, prs_struct *ps, i
        smb_io_pol_hnd("pol", &(q_u->pol), ps, depth); 
        prs_align(ps);
 
-       smb_io_unihdr ("", &(q_u->hdr_mach_acct), ps, depth); 
-       smb_io_unistr2("", &(q_u->uni_mach_acct), q_u->hdr_mach_acct.buffer, ps, depth); 
+       prs_uint16("switch_value ", ps, depth, &(q_u->switch_value )); 
+       prs_uint16("switch_value2", ps, depth, &(q_u->switch_value2)); 
 
        prs_align(ps);
 
-       prs_uint32("acct_ctrl", ps, depth, &(q_u->acct_ctrl));
-       prs_uint16("unknown_1", ps, depth, &(q_u->unknown_1));
-       prs_uint16("unknown_2", ps, depth, &(q_u->unknown_2));
+       switch (q_u->switch_value)
+       {
+               case 0:
+               {
+                       break;
+               }
+               case 24:
+               {
+                       q_u->info.id = Realloc(NULL, sizeof(*q_u->info.id24));
+                       if (q_u->info.id == NULL)
+                       {
+                               DEBUG(2,("samr_io_q_query_userinfo: info pointer not initialised\n"));
+                               return;
+                       }
+                       sam_io_user_info_24("", q_u->info.id24, ps, depth);
+                       break;
+               }
+               case 23:
+               {
+                       q_u->info.id = Realloc(NULL, sizeof(*q_u->info.id23));
+                       if (q_u->info.id == NULL)
+                       {
+                               DEBUG(2,("samr_io_q_query_userinfo: info pointer not initialised\n"));
+                               return;
+                       }
+                       sam_io_user_info23("", q_u->info.id23, ps, depth);
+                       break;
+               }
+               default:
+               {
+                       DEBUG(2,("samr_io_q_query_userinfo: unknown switch level\n"));
+                       break;
+               }
+                       
+       }
+       prs_align(ps);
+}
+
+/*******************************************************************
+makes a SAMR_R_SET_USERINFO structure.
+********************************************************************/
+void make_samr_r_set_userinfo(SAMR_R_SET_USERINFO *r_u, uint32 status)
+                               
+{
+       if (r_u == NULL) return;
+
+       DEBUG(5,("make_samr_r_set_userinfo\n"));
+
+       r_u->status = status;         /* return status */
 }
 
 /*******************************************************************
 reads or writes a structure.
 ********************************************************************/
-void samr_io_r_unknown_32(char *desc,  SAMR_R_UNKNOWN_32 *r_u, prs_struct *ps, int depth)
+void samr_io_r_set_userinfo(char *desc,  SAMR_R_SET_USERINFO *r_u, prs_struct *ps, int depth)
 {
        if (r_u == NULL) return;
 
-       prs_debug(ps, depth, desc, "samr_io_r_unknown_32");
+       prs_debug(ps, depth, desc, "samr_io_r_set_userinfo");
        depth++;
 
        prs_align(ps);
 
-       smb_io_pol_hnd("pol", &(r_u->pol), ps, depth); 
-       prs_align(ps);
-
        prs_uint32("status", ps, depth, &(r_u->status));
 }
 
-
 /*******************************************************************
 makes a SAMR_Q_CONNECT structure.
 ********************************************************************/
@@ -4496,7 +4869,7 @@ void make_samr_q_unknown_38(SAMR_Q_UNKNOWN_38 *q_u, char *srv_name)
        DEBUG(5,("make_samr_q_unknown_38\n"));
 
        q_u->ptr = 1;
-       make_uni_hdr(&(q_u->hdr_srv_name), len_srv_name, len_srv_name, len_srv_name != 0);
+       make_uni_hdr(&(q_u->hdr_srv_name), len_srv_name);
        make_unistr2(&(q_u->uni_srv_name), srv_name, len_srv_name);  
 
 }
@@ -4628,9 +5001,9 @@ void make_samr_q_chgpasswd_user(SAMR_Q_CHGPASSWD_USER *q_u,
        DEBUG(5,("make_samr_q_chgpasswd_user\n"));
 
        q_u->ptr_0 = 1;
-       make_uni_hdr(&(q_u->hdr_dest_host), len_dest_host, len_dest_host, len_dest_host != 0);
+       make_uni_hdr(&(q_u->hdr_dest_host), len_dest_host);
        make_unistr2(&(q_u->uni_dest_host), dest_host, len_dest_host);  
-       make_uni_hdr(&(q_u->hdr_user_name), len_user_name, len_user_name, len_user_name != 0);
+       make_uni_hdr(&(q_u->hdr_user_name), len_user_name);
        make_unistr2(&(q_u->uni_user_name), user_name, len_user_name);  
 
        make_enc_passwd(&(q_u->nt_newpass), nt_newpass);