s3-talloc Change TALLOC_ARRAY() to talloc_array()
[samba.git] / source3 / rpc_client / cli_lsarpc.c
index 0b89488a21f47e471b6b478ebba83d2434cce1e8..66192bdf54f9ec8c8c51c121518731fb7e0aea33 100644 (file)
 */
 
 #include "includes.h"
+#include "rpc_client/rpc_client.h"
+#include "../librpc/gen_ndr/ndr_lsa_c.h"
+#include "rpc_client/cli_lsarpc.h"
+#include "rpc_client/init_lsa.h"
+#include "../libcli/security/security.h"
 
 /** @defgroup lsa LSA - Local Security Architecture
  *  @ingroup rpc_client
  * security authority", which is half of a password database.
  **/
 
-/** Open a LSA policy handle
- *
- * @param cli Handle on an initialised SMB connection */
-
-NTSTATUS rpccli_lsa_open_policy(struct rpc_pipe_client *cli,
+NTSTATUS dcerpc_lsa_open_policy(struct dcerpc_binding_handle *h,
                                TALLOC_CTX *mem_ctx,
-                               bool sec_qos, uint32 des_access,
-                               POLICY_HND *pol)
+                               bool sec_qos,
+                               uint32_t des_access,
+                               struct policy_handle *pol,
+                               NTSTATUS *result)
 {
        struct lsa_ObjectAttribute attr;
        struct lsa_QosInfo qos;
        uint16_t system_name = '\\';
 
+       ZERO_STRUCT(attr);
+
+       attr.len        = 0x18;
+
        if (sec_qos) {
-               init_lsa_sec_qos(&qos, 0xc, 2, 1, 0);
-               init_lsa_obj_attr(&attr,
-                                 0x18,
-                                 NULL,
-                                 NULL,
-                                 0,
-                                 NULL,
-                                 &qos);
-       } else {
-               init_lsa_obj_attr(&attr,
-                                 0x18,
-                                 NULL,
-                                 NULL,
-                                 0,
-                                 NULL,
-                                 NULL);
+               qos.len                 = 0xc;
+               qos.impersonation_level = 2;
+               qos.context_mode        = 1;
+               qos.effective_only      = 0;
+
+               attr.sec_qos            = &qos;
        }
 
-       return rpccli_lsa_OpenPolicy(cli, mem_ctx,
+       return dcerpc_lsa_OpenPolicy(h,
+                                    mem_ctx,
                                     &system_name,
                                     &attr,
                                     des_access,
-                                    pol);
+                                    pol,
+                                    result);
 }
 
 /** Open a LSA policy handle
-  *
-  * @param cli Handle on an initialised SMB connection
-  */
+ *
+ * @param cli Handle on an initialised SMB connection */
 
-NTSTATUS rpccli_lsa_open_policy2(struct rpc_pipe_client *cli,
-                                TALLOC_CTX *mem_ctx, bool sec_qos,
-                                uint32 des_access, POLICY_HND *pol)
+NTSTATUS rpccli_lsa_open_policy(struct rpc_pipe_client *cli,
+                               TALLOC_CTX *mem_ctx,
+                               bool sec_qos, uint32 des_access,
+                               struct policy_handle *pol)
+{
+       NTSTATUS status;
+       NTSTATUS result = NT_STATUS_UNSUCCESSFUL;
+
+       status = dcerpc_lsa_open_policy(cli->binding_handle,
+                                       mem_ctx,
+                                       sec_qos,
+                                       des_access,
+                                       pol,
+                                       &result);
+       if (!NT_STATUS_IS_OK(status)) {
+               return status;
+       }
+
+       return result;
+}
+
+NTSTATUS dcerpc_lsa_open_policy2(struct dcerpc_binding_handle *h,
+                                TALLOC_CTX *mem_ctx,
+                                const char *srv_name_slash,
+                                bool sec_qos,
+                                uint32_t des_access,
+                                struct policy_handle *pol,
+                                NTSTATUS *result)
 {
        struct lsa_ObjectAttribute attr;
        struct lsa_QosInfo qos;
-       char *srv_name_slash = talloc_asprintf(mem_ctx, "\\\\%s", cli->cli->desthost);
+
+       ZERO_STRUCT(attr);
+
+       attr.len        = 0x18;
 
        if (sec_qos) {
-               init_lsa_sec_qos(&qos, 0xc, 2, 1, 0);
-               init_lsa_obj_attr(&attr,
-                                 0x18,
-                                 NULL,
-                                 NULL,
-                                 0,
-                                 NULL,
-                                 &qos);
-       } else {
-               init_lsa_obj_attr(&attr,
-                                 0x18,
-                                 NULL,
-                                 NULL,
-                                 0,
-                                 NULL,
-                                 NULL);
+               qos.len                 = 0xc;
+               qos.impersonation_level = 2;
+               qos.context_mode        = 1;
+               qos.effective_only      = 0;
+
+               attr.sec_qos            = &qos;
        }
 
-       return rpccli_lsa_OpenPolicy2(cli, mem_ctx,
+       return dcerpc_lsa_OpenPolicy2(h,
+                                     mem_ctx,
                                      srv_name_slash,
                                      &attr,
                                      des_access,
-                                     pol);
+                                     pol,
+                                     result);
+}
+
+/** Open a LSA policy handle
+  *
+  * @param cli Handle on an initialised SMB connection
+  */
+
+NTSTATUS rpccli_lsa_open_policy2(struct rpc_pipe_client *cli,
+                                TALLOC_CTX *mem_ctx, bool sec_qos,
+                                uint32 des_access, struct policy_handle *pol)
+{
+       NTSTATUS status;
+       NTSTATUS result = NT_STATUS_UNSUCCESSFUL;
+
+       status = dcerpc_lsa_open_policy2(cli->binding_handle,
+                                        mem_ctx,
+                                        cli->srv_name_slash,
+                                        sec_qos,
+                                        des_access,
+                                        pol,
+                                        &result);
+       if (!NT_STATUS_IS_OK(status)) {
+               return status;
+       }
+
+       return result;
 }
 
 /* Lookup a list of sids
  *
  * internal version withOUT memory allocation of the target arrays.
- * this assumes suffciently sized arrays to store domains, names and types. */
+ * this assumes sufficiently sized arrays to store domains, names and types. */
 
-static NTSTATUS rpccli_lsa_lookup_sids_noalloc(struct rpc_pipe_client *cli,
+static NTSTATUS dcerpc_lsa_lookup_sids_noalloc(struct dcerpc_binding_handle *h,
                                               TALLOC_CTX *mem_ctx,
-                                              POLICY_HND *pol,
+                                              struct policy_handle *pol,
                                               int num_sids,
-                                              const DOM_SID *sids,
+                                              const struct dom_sid *sids,
                                               char **domains,
                                               char **names,
-                                              enum lsa_SidType *types)
+                                              enum lsa_SidType *types,
+                                              bool use_lookupsids3,
+                                              NTSTATUS *presult)
 {
-       NTSTATUS result = NT_STATUS_OK;
-       TALLOC_CTX *tmp_ctx = NULL;
-       int i;
+       NTSTATUS status = NT_STATUS_OK;
+       NTSTATUS result = NT_STATUS_UNSUCCESSFUL;
        struct lsa_SidArray sid_array;
        struct lsa_RefDomainList *ref_domains = NULL;
        struct lsa_TransNameArray lsa_names;
+       enum lsa_LookupNamesLevel level = LSA_LOOKUP_NAMES_ALL;
        uint32_t count = 0;
-       uint16_t level = 1;
+       int i;
 
        ZERO_STRUCT(lsa_names);
 
-       tmp_ctx = talloc_new(mem_ctx);
-       if (!tmp_ctx) {
-               DEBUG(0, ("rpccli_lsa_lookup_sids_noalloc: out of memory!\n"));
-               result = NT_STATUS_UNSUCCESSFUL;
-               goto done;
-       }
-
        sid_array.num_sids = num_sids;
-       sid_array.sids = TALLOC_ARRAY(mem_ctx, struct lsa_SidPtr, num_sids);
-       if (!sid_array.sids) {
+       sid_array.sids = talloc_array(mem_ctx, struct lsa_SidPtr, num_sids);
+       if (sid_array.sids == NULL) {
                return NT_STATUS_NO_MEMORY;
        }
 
        for (i = 0; i<num_sids; i++) {
-               sid_array.sids[i].sid = sid_dup_talloc(mem_ctx, &sids[i]);
+               sid_array.sids[i].sid = dom_sid_dup(mem_ctx, &sids[i]);
                if (!sid_array.sids[i].sid) {
                        return NT_STATUS_NO_MEMORY;
                }
        }
 
-       result = rpccli_lsa_LookupSids(cli, mem_ctx,
-                                      pol,
-                                      &sid_array,
-                                      &ref_domains,
-                                      &lsa_names,
-                                      level,
-                                      &count);
+       if (use_lookupsids3) {
+               struct lsa_TransNameArray2 lsa_names2;
+               uint32_t n;
+
+               ZERO_STRUCT(lsa_names2);
+
+               status = dcerpc_lsa_LookupSids3(h,
+                                               mem_ctx,
+                                               &sid_array,
+                                               &ref_domains,
+                                               &lsa_names2,
+                                               level,
+                                               &count,
+                                               LSA_LOOKUP_OPTION_SEARCH_ISOLATED_NAMES,
+                                               LSA_CLIENT_REVISION_2,
+                                               &result);
+               if (!NT_STATUS_IS_OK(status)) {
+                       return status;
+               }
 
-       DEBUG(10, ("LSA_LOOKUPSIDS returned '%s', mapped count = %d'\n",
-                  nt_errstr(result), count));
+               if(!NT_STATUS_IS_ERR(result)) {
+                       lsa_names.count = lsa_names2.count;
+                       lsa_names.names = talloc_array(mem_ctx,
+                                                      struct lsa_TranslatedName,
+                                                      lsa_names.count);
+                       if (lsa_names.names == NULL) {
+                               return NT_STATUS_NO_MEMORY;
+                       }
+                       for (n=0; n < lsa_names.count; n++) {
+                               lsa_names.names[n].sid_type     = lsa_names2.names[n].sid_type;
+                               lsa_names.names[n].name         = lsa_names2.names[n].name;
+                               lsa_names.names[n].sid_index    = lsa_names2.names[n].sid_index;
+                       }
+               }
+
+       } else {
+               status = dcerpc_lsa_LookupSids(h,
+                                              mem_ctx,
+                                              pol,
+                                              &sid_array,
+                                              &ref_domains,
+                                              &lsa_names,
+                                              level,
+                                              &count,
+                                              &result);
+       }
+
+       DEBUG(10, ("LSA_LOOKUPSIDS returned status: '%s', result: '%s', "
+                  "mapped count = %d'\n",
+                  nt_errstr(status), nt_errstr(result), count));
+
+       if (!NT_STATUS_IS_OK(status)) {
+               return status;
+       }
 
        if (!NT_STATUS_IS_OK(result) &&
            !NT_STATUS_EQUAL(result, NT_STATUS_NONE_MAPPED) &&
            !NT_STATUS_EQUAL(result, STATUS_SOME_UNMAPPED))
        {
-               /* An actual error occured */
-               goto done;
+               *presult = result;
+               return status;
        }
 
        /* Return output parameters */
-
        if (NT_STATUS_EQUAL(result, NT_STATUS_NONE_MAPPED) ||
            (count == 0))
        {
@@ -189,8 +271,8 @@ static NTSTATUS rpccli_lsa_lookup_sids_noalloc(struct rpc_pipe_client *cli,
                        (domains)[i] = NULL;
                        (types)[i] = SID_NAME_UNKNOWN;
                }
-               result = NT_STATUS_NONE_MAPPED;
-               goto done;
+               *presult = NT_STATUS_NONE_MAPPED;
+               return status;
        }
 
        for (i = 0; i < num_sids; i++) {
@@ -204,14 +286,23 @@ static NTSTATUS rpccli_lsa_lookup_sids_noalloc(struct rpc_pipe_client *cli,
                        dom_name = ref_domains->domains[dom_idx].name.string;
                        name = lsa_names.names[i].name.string;
 
-                       (names)[i] = talloc_strdup(mem_ctx, name);
-                       (domains)[i] = talloc_strdup(mem_ctx, dom_name);
+                       if (name) {
+                               (names)[i] = talloc_strdup(names, name);
+                               if ((names)[i] == NULL) {
+                                       DEBUG(0, ("cli_lsa_lookup_sids_noalloc(): out of memory\n"));
+                                       *presult = NT_STATUS_UNSUCCESSFUL;
+                                       return status;
+                               }
+                       } else {
+                               (names)[i] = NULL;
+                       }
+                       domains[i] = talloc_strdup(domains,
+                                                  dom_name ? dom_name : "");
                        (types)[i] = lsa_names.names[i].sid_type;
-
-                       if (((names)[i] == NULL) || ((domains)[i] == NULL)) {
+                       if (((domains)[i] == NULL)) {
                                DEBUG(0, ("cli_lsa_lookup_sids_noalloc(): out of memory\n"));
-                               result = NT_STATUS_UNSUCCESSFUL;
-                               goto done;
+                               *presult = NT_STATUS_UNSUCCESSFUL;
+                               return status;
                        }
 
                } else {
@@ -221,9 +312,8 @@ static NTSTATUS rpccli_lsa_lookup_sids_noalloc(struct rpc_pipe_client *cli,
                }
        }
 
-done:
-       TALLOC_FREE(tmp_ctx);
-       return result;
+       *presult = NT_STATUS_OK;
+       return status;
 }
 
 /* Lookup a list of sids
@@ -238,42 +328,47 @@ done:
  * at 20480 for win2k3, but we keep it at a save 1000 for now. */
 #define LOOKUP_SIDS_HUNK_SIZE 1000
 
-NTSTATUS rpccli_lsa_lookup_sids(struct rpc_pipe_client *cli,
-                               TALLOC_CTX *mem_ctx,
-                               POLICY_HND *pol,
-                               int num_sids,
-                               const DOM_SID *sids,
-                               char ***pdomains,
-                               char ***pnames,
-                               enum lsa_SidType **ptypes)
+static NTSTATUS dcerpc_lsa_lookup_sids_generic(struct dcerpc_binding_handle *h,
+                                              TALLOC_CTX *mem_ctx,
+                                              struct policy_handle *pol,
+                                              int num_sids,
+                                              const struct dom_sid *sids,
+                                              char ***pdomains,
+                                              char ***pnames,
+                                              enum lsa_SidType **ptypes,
+                                              bool use_lookupsids3,
+                                              NTSTATUS *presult)
 {
+       NTSTATUS status = NT_STATUS_OK;
        NTSTATUS result = NT_STATUS_OK;
        int sids_left = 0;
        int sids_processed = 0;
-       const DOM_SID *hunk_sids = sids;
+       const struct dom_sid *hunk_sids = sids;
        char **hunk_domains;
        char **hunk_names;
        enum lsa_SidType *hunk_types;
        char **domains = NULL;
        char **names = NULL;
        enum lsa_SidType *types = NULL;
+       bool have_mapped = false;
+       bool have_unmapped = false;
 
        if (num_sids) {
-               if (!(domains = TALLOC_ARRAY(mem_ctx, char *, num_sids))) {
+               if (!(domains = talloc_array(mem_ctx, char *, num_sids))) {
                        DEBUG(0, ("rpccli_lsa_lookup_sids(): out of memory\n"));
-                       result = NT_STATUS_NO_MEMORY;
+                       status = NT_STATUS_NO_MEMORY;
                        goto fail;
                }
 
-               if (!(names = TALLOC_ARRAY(mem_ctx, char *, num_sids))) {
+               if (!(names = talloc_array(mem_ctx, char *, num_sids))) {
                        DEBUG(0, ("rpccli_lsa_lookup_sids(): out of memory\n"));
-                       result = NT_STATUS_NO_MEMORY;
+                       status = NT_STATUS_NO_MEMORY;
                        goto fail;
                }
 
-               if (!(types = TALLOC_ARRAY(mem_ctx, enum lsa_SidType, num_sids))) {
+               if (!(types = talloc_array(mem_ctx, enum lsa_SidType, num_sids))) {
                        DEBUG(0, ("rpccli_lsa_lookup_sids(): out of memory\n"));
-                       result = NT_STATUS_NO_MEMORY;
+                       status = NT_STATUS_NO_MEMORY;
                        goto fail;
                }
        }
@@ -285,7 +380,7 @@ NTSTATUS rpccli_lsa_lookup_sids(struct rpc_pipe_client *cli,
 
        while (sids_left > 0) {
                int hunk_num_sids;
-               NTSTATUS hunk_result = NT_STATUS_OK;
+               NTSTATUS hunk_result = NT_STATUS_UNSUCCESSFUL;
 
                hunk_num_sids = ((sids_left > LOOKUP_SIDS_HUNK_SIZE)
                                ? LOOKUP_SIDS_HUNK_SIZE
@@ -297,32 +392,44 @@ NTSTATUS rpccli_lsa_lookup_sids(struct rpc_pipe_client *cli,
                           sids_processed + hunk_num_sids - 1,
                           num_sids));
 
-               hunk_result = rpccli_lsa_lookup_sids_noalloc(cli,
-                                                            mem_ctx,
-                                                            pol,
-                                                            hunk_num_sids,
-                                                            hunk_sids,
-                                                            hunk_domains,
-                                                            hunk_names,
-                                                            hunk_types);
+               status = dcerpc_lsa_lookup_sids_noalloc(h,
+                                                       mem_ctx,
+                                                       pol,
+                                                       hunk_num_sids,
+                                                       hunk_sids,
+                                                       hunk_domains,
+                                                       hunk_names,
+                                                       hunk_types,
+                                                       use_lookupsids3,
+                                                       &hunk_result);
+               if (!NT_STATUS_IS_OK(status)) {
+                       goto fail;
+               }
 
                if (!NT_STATUS_IS_OK(hunk_result) &&
                    !NT_STATUS_EQUAL(hunk_result, STATUS_SOME_UNMAPPED) &&
                    !NT_STATUS_EQUAL(hunk_result, NT_STATUS_NONE_MAPPED))
                {
                        /* An actual error occured */
-                       result = hunk_result;
+                       *presult = hunk_result;
                        goto fail;
                }
 
-               /* adapt overall result */
-               if (( NT_STATUS_IS_OK(result) &&
-                    !NT_STATUS_IS_OK(hunk_result))
-                   ||
-                   ( NT_STATUS_EQUAL(result, NT_STATUS_NONE_MAPPED) &&
-                    !NT_STATUS_EQUAL(hunk_result, NT_STATUS_NONE_MAPPED)))
-               {
-                       result = STATUS_SOME_UNMAPPED;
+               if (NT_STATUS_IS_OK(hunk_result)) {
+                       have_mapped = true;
+               }
+               if (NT_STATUS_EQUAL(hunk_result, NT_STATUS_NONE_MAPPED)) {
+                       have_unmapped = true;
+               }
+               if (NT_STATUS_EQUAL(hunk_result, STATUS_SOME_UNMAPPED)) {
+                       int i;
+                       for (i=0; i<hunk_num_sids; i++) {
+                               if (hunk_types[i] == SID_NAME_UNKNOWN) {
+                                       have_unmapped = true;
+                               } else {
+                                       have_mapped = true;
+                               }
+                       }
                }
 
                sids_left -= hunk_num_sids;
@@ -336,86 +443,219 @@ NTSTATUS rpccli_lsa_lookup_sids(struct rpc_pipe_client *cli,
        *pdomains = domains;
        *pnames = names;
        *ptypes = types;
-       return result;
+
+       if (!have_mapped) {
+               result = NT_STATUS_NONE_MAPPED;
+       }
+       if (have_unmapped) {
+               result = STATUS_SOME_UNMAPPED;
+       }
+       *presult = result;
+
+       return status;
 
 fail:
        TALLOC_FREE(domains);
        TALLOC_FREE(names);
        TALLOC_FREE(types);
+
+       return status;
+}
+
+NTSTATUS dcerpc_lsa_lookup_sids(struct dcerpc_binding_handle *h,
+                               TALLOC_CTX *mem_ctx,
+                               struct policy_handle *pol,
+                               int num_sids,
+                               const struct dom_sid *sids,
+                               char ***pdomains,
+                               char ***pnames,
+                               enum lsa_SidType **ptypes,
+                               NTSTATUS *result)
+{
+       return dcerpc_lsa_lookup_sids_generic(h,
+                                             mem_ctx,
+                                             pol,
+                                             num_sids,
+                                             sids,
+                                             pdomains,
+                                             pnames,
+                                             ptypes,
+                                             false,
+                                             result);
+}
+
+NTSTATUS rpccli_lsa_lookup_sids(struct rpc_pipe_client *cli,
+                               TALLOC_CTX *mem_ctx,
+                               struct policy_handle *pol,
+                               int num_sids,
+                               const struct dom_sid *sids,
+                               char ***pdomains,
+                               char ***pnames,
+                               enum lsa_SidType **ptypes)
+{
+       NTSTATUS status;
+       NTSTATUS result = NT_STATUS_UNSUCCESSFUL;
+
+       status = dcerpc_lsa_lookup_sids_generic(cli->binding_handle,
+                                               mem_ctx,
+                                               pol,
+                                               num_sids,
+                                               sids,
+                                               pdomains,
+                                               pnames,
+                                               ptypes,
+                                               false,
+                                               &result);
+       if (!NT_STATUS_IS_OK(status)) {
+               return status;
+       }
+
        return result;
 }
 
-/** Lookup a list of names */
+NTSTATUS dcerpc_lsa_lookup_sids3(struct dcerpc_binding_handle *h,
+                                TALLOC_CTX *mem_ctx,
+                                struct policy_handle *pol,
+                                int num_sids,
+                                const struct dom_sid *sids,
+                                char ***pdomains,
+                                char ***pnames,
+                                enum lsa_SidType **ptypes,
+                                NTSTATUS *result)
+{
+       return dcerpc_lsa_lookup_sids_generic(h,
+                                             mem_ctx,
+                                             pol,
+                                             num_sids,
+                                             sids,
+                                             pdomains,
+                                             pnames,
+                                             ptypes,
+                                             true,
+                                             result);
+}
 
-NTSTATUS rpccli_lsa_lookup_names(struct rpc_pipe_client *cli,
+NTSTATUS rpccli_lsa_lookup_sids3(struct rpc_pipe_client *cli,
                                 TALLOC_CTX *mem_ctx,
-                                POLICY_HND *pol, int num_names,
-                                const char **names,
-                                const char ***dom_names,
-                                int level,
-                                DOM_SID **sids,
-                                enum lsa_SidType **types)
+                                struct policy_handle *pol,
+                                int num_sids,
+                                const struct dom_sid *sids,
+                                char ***pdomains,
+                                char ***pnames,
+                                enum lsa_SidType **ptypes)
 {
-       NTSTATUS result;
-       int i;
+       NTSTATUS status;
+       NTSTATUS result = NT_STATUS_UNSUCCESSFUL;
+
+       status = dcerpc_lsa_lookup_sids_generic(cli->binding_handle,
+                                               mem_ctx,
+                                               pol,
+                                               num_sids,
+                                               sids,
+                                               pdomains,
+                                               pnames,
+                                               ptypes,
+                                               true,
+                                               &result);
+       if (!NT_STATUS_IS_OK(status)) {
+               return status;
+       }
+
+       return result;
+}
+
+/** Lookup a list of names */
+
+static NTSTATUS dcerpc_lsa_lookup_names_generic(struct dcerpc_binding_handle *h,
+                                               TALLOC_CTX *mem_ctx,
+                                               struct policy_handle *pol,
+                                               uint32_t num_names,
+                                               const char **names,
+                                               const char ***dom_names,
+                                               enum lsa_LookupNamesLevel level,
+                                               struct dom_sid **sids,
+                                               enum lsa_SidType **types,
+                                               bool use_lookupnames4,
+                                               NTSTATUS *presult)
+{
+       NTSTATUS status;
        struct lsa_String *lsa_names = NULL;
        struct lsa_RefDomainList *domains = NULL;
        struct lsa_TransSidArray sid_array;
+       struct lsa_TransSidArray3 sid_array3;
        uint32_t count = 0;
+       uint32_t i;
 
        ZERO_STRUCT(sid_array);
+       ZERO_STRUCT(sid_array3);
 
-       lsa_names = TALLOC_ARRAY(mem_ctx, struct lsa_String, num_names);
-       if (!lsa_names) {
+       lsa_names = talloc_array(mem_ctx, struct lsa_String, num_names);
+       if (lsa_names == NULL) {
                return NT_STATUS_NO_MEMORY;
        }
 
-       for (i=0; i<num_names; i++) {
+       for (i = 0; i < num_names; i++) {
                init_lsa_String(&lsa_names[i], names[i]);
        }
 
-       result = rpccli_lsa_LookupNames(cli, mem_ctx,
-                                       pol,
-                                       num_names,
-                                       lsa_names,
-                                       &domains,
-                                       &sid_array,
-                                       level,
-                                       &count);
-
-       if (!NT_STATUS_IS_OK(result) && NT_STATUS_V(result) !=
-           NT_STATUS_V(STATUS_SOME_UNMAPPED)) {
+       if (use_lookupnames4) {
+               status = dcerpc_lsa_LookupNames4(h,
+                                                mem_ctx,
+                                                num_names,
+                                                lsa_names,
+                                                &domains,
+                                                &sid_array3,
+                                                level,
+                                                &count,
+                                                LSA_LOOKUP_OPTION_SEARCH_ISOLATED_NAMES,
+                                                LSA_CLIENT_REVISION_2,
+                                                presult);
+       } else {
+               status = dcerpc_lsa_LookupNames(h,
+                                               mem_ctx,
+                                               pol,
+                                               num_names,
+                                               lsa_names,
+                                               &domains,
+                                               &sid_array,
+                                               level,
+                                               &count,
+                                               presult);
+       }
+       if (!NT_STATUS_IS_OK(status)) {
+               goto done;
+       }
 
+       if (!NT_STATUS_IS_OK(*presult) &&
+           !NT_STATUS_EQUAL(*presult, STATUS_SOME_UNMAPPED)) {
                /* An actual error occured */
-
                goto done;
        }
 
        /* Return output parameters */
-
        if (count == 0) {
-               result = NT_STATUS_NONE_MAPPED;
+               *presult = NT_STATUS_NONE_MAPPED;
                goto done;
        }
 
        if (num_names) {
-               if (!((*sids = TALLOC_ARRAY(mem_ctx, DOM_SID, num_names)))) {
+               if (!((*sids = talloc_array(mem_ctx, struct dom_sid, num_names)))) {
                        DEBUG(0, ("cli_lsa_lookup_sids(): out of memory\n"));
-                       result = NT_STATUS_NO_MEMORY;
+                       *presult = NT_STATUS_NO_MEMORY;
                        goto done;
                }
 
-               if (!((*types = TALLOC_ARRAY(mem_ctx, enum lsa_SidType, num_names)))) {
+               if (!((*types = talloc_array(mem_ctx, enum lsa_SidType, num_names)))) {
                        DEBUG(0, ("cli_lsa_lookup_sids(): out of memory\n"));
-                       result = NT_STATUS_NO_MEMORY;
+                       *presult = NT_STATUS_NO_MEMORY;
                        goto done;
                }
 
                if (dom_names != NULL) {
-                       *dom_names = TALLOC_ARRAY(mem_ctx, const char *, num_names);
+                       *dom_names = talloc_array(mem_ctx, const char *, num_names);
                        if (*dom_names == NULL) {
                                DEBUG(0, ("cli_lsa_lookup_sids(): out of memory\n"));
-                               result = NT_STATUS_NO_MEMORY;
+                               *presult = NT_STATUS_NO_MEMORY;
                                goto done;
                        }
                }
@@ -428,9 +668,16 @@ NTSTATUS rpccli_lsa_lookup_names(struct rpc_pipe_client *cli,
        }
 
        for (i = 0; i < num_names; i++) {
-               uint32_t dom_idx = sid_array.sids[i].sid_index;
-               uint32_t dom_rid = sid_array.sids[i].rid;
-               DOM_SID *sid = &(*sids)[i];
+               uint32_t dom_idx;
+               struct dom_sid *sid = &(*sids)[i];
+
+               if (use_lookupnames4) {
+                       dom_idx         = sid_array3.sids[i].sid_index;
+                       (*types)[i]     = sid_array3.sids[i].sid_type;
+               } else {
+                       dom_idx         = sid_array.sids[i].sid_index;
+                       (*types)[i]     = sid_array.sids[i].sid_type;
+               }
 
                /* Translate optimised sid through domain index array */
 
@@ -441,14 +688,16 @@ NTSTATUS rpccli_lsa_lookup_names(struct rpc_pipe_client *cli,
                        continue;
                }
 
-               sid_copy(sid, domains->domains[dom_idx].sid);
+               if (use_lookupnames4) {
+                       sid_copy(sid, sid_array3.sids[i].sid);
+               } else {
+                       sid_copy(sid, domains->domains[dom_idx].sid);
 
-               if (dom_rid != 0xffffffff) {
-                       sid_append_rid(sid, dom_rid);
+                       if (sid_array.sids[i].rid != 0xffffffff) {
+                               sid_append_rid(sid, sid_array.sids[i].rid);
+                       }
                }
 
-               (*types)[i] = sid_array.sids[i].sid_type;
-
                if (dom_names == NULL) {
                        continue;
                }
@@ -457,108 +706,113 @@ NTSTATUS rpccli_lsa_lookup_names(struct rpc_pipe_client *cli,
        }
 
  done:
-
-       return result;
+       return status;
 }
 
-#if 0
-
-/** An example of how to use the routines in this file.  Fetch a DOMAIN
-    sid. Does complete cli setup / teardown anonymously. */
-
-bool fetch_domain_sid( char *domain, char *remote_machine, DOM_SID *psid)
+NTSTATUS dcerpc_lsa_lookup_names(struct dcerpc_binding_handle *h,
+                                TALLOC_CTX *mem_ctx,
+                                struct policy_handle *pol,
+                                uint32_t num_names,
+                                const char **names,
+                                const char ***dom_names,
+                                enum lsa_LookupNamesLevel level,
+                                struct dom_sid **sids,
+                                enum lsa_SidType **types,
+                                NTSTATUS *result)
 {
-       struct cli_state cli;
-       NTSTATUS result;
-       POLICY_HND lsa_pol;
-       bool ret = False;
-
-       ZERO_STRUCT(cli);
-       if(cli_initialise(&cli) == False) {
-               DEBUG(0,("fetch_domain_sid: unable to initialize client connection.\n"));
-               return False;
-       }
-
-       if(!resolve_name( remote_machine, &cli.dest_ip, 0x20)) {
-               DEBUG(0,("fetch_domain_sid: Can't resolve address for %s\n", remote_machine));
-               goto done;
-       }
-
-       if (!cli_connect(&cli, remote_machine, &cli.dest_ip)) {
-               DEBUG(0,("fetch_domain_sid: unable to connect to SMB server on \
-machine %s. Error was : %s.\n", remote_machine, cli_errstr(&cli) ));
-               goto done;
-       }
-
-       if (!attempt_netbios_session_request(&cli, global_myname(), remote_machine, &cli.dest_ip)) {
-               DEBUG(0,("fetch_domain_sid: machine %s rejected the NetBIOS session request.\n",
-                       remote_machine));
-               goto done;
-       }
-
-       cli.protocol = PROTOCOL_NT1;
-
-       if (!cli_negprot(&cli)) {
-               DEBUG(0,("fetch_domain_sid: machine %s rejected the negotiate protocol. \
-Error was : %s.\n", remote_machine, cli_errstr(&cli) ));
-               goto done;
-       }
-
-       if (cli.protocol != PROTOCOL_NT1) {
-               DEBUG(0,("fetch_domain_sid: machine %s didn't negotiate NT protocol.\n",
-                       remote_machine));
-               goto done;
-       }
-
-       /*
-        * Do an anonymous session setup.
-        */
-
-       if (!cli_session_setup(&cli, "", "", 0, "", 0, "")) {
-               DEBUG(0,("fetch_domain_sid: machine %s rejected the session setup. \
-Error was : %s.\n", remote_machine, cli_errstr(&cli) ));
-               goto done;
-       }
-
-       if (!(cli.sec_mode & NEGOTIATE_SECURITY_USER_LEVEL)) {
-               DEBUG(0,("fetch_domain_sid: machine %s isn't in user level security mode\n",
-                       remote_machine));
-               goto done;
-       }
+       return dcerpc_lsa_lookup_names_generic(h,
+                                              mem_ctx,
+                                              pol,
+                                              num_names,
+                                              names,
+                                              dom_names,
+                                              level,
+                                              sids,
+                                              types,
+                                              false,
+                                              result);
+}
 
-       if (!cli_send_tconX(&cli, "IPC$", "IPC", "", 1)) {
-               DEBUG(0,("fetch_domain_sid: machine %s rejected the tconX on the IPC$ share. \
-Error was : %s.\n", remote_machine, cli_errstr(&cli) ));
-               goto done;
+NTSTATUS rpccli_lsa_lookup_names(struct rpc_pipe_client *cli,
+                                TALLOC_CTX *mem_ctx,
+                                struct policy_handle *pol,
+                                int num_names,
+                                const char **names,
+                                const char ***dom_names,
+                                int level,
+                                struct dom_sid **sids,
+                                enum lsa_SidType **types)
+{
+       NTSTATUS status;
+       NTSTATUS result = NT_STATUS_UNSUCCESSFUL;
+
+       status = dcerpc_lsa_lookup_names(cli->binding_handle,
+                                        mem_ctx,
+                                        pol,
+                                        num_names,
+                                        names,
+                                        dom_names,
+                                        level,
+                                        sids,
+                                        types,
+                                        &result);
+       if (!NT_STATUS_IS_OK(status)) {
+               return status;
        }
 
-       /* Fetch domain sid */
-
-       if (!cli_nt_session_open(&cli, PI_LSARPC)) {
-               DEBUG(0, ("fetch_domain_sid: Error connecting to SAM pipe\n"));
-               goto done;
-       }
+       return result;
+}
 
-       result = cli_lsa_open_policy(&cli, cli.mem_ctx, True, SEC_RIGHTS_QUERY_VALUE, &lsa_pol);
-       if (!NT_STATUS_IS_OK(result)) {
-               DEBUG(0, ("fetch_domain_sid: Error opening lsa policy handle. %s\n",
-                       nt_errstr(result) ));
-               goto done;
-       }
+NTSTATUS dcerpc_lsa_lookup_names4(struct dcerpc_binding_handle *h,
+                                 TALLOC_CTX *mem_ctx,
+                                 struct policy_handle *pol,
+                                 uint32_t num_names,
+                                 const char **names,
+                                 const char ***dom_names,
+                                 enum lsa_LookupNamesLevel level,
+                                 struct dom_sid **sids,
+                                 enum lsa_SidType **types,
+                                 NTSTATUS *result)
+{
+       return dcerpc_lsa_lookup_names_generic(h,
+                                              mem_ctx,
+                                              pol,
+                                              num_names,
+                                              names,
+                                              dom_names,
+                                              level,
+                                              sids,
+                                              types,
+                                              true,
+                                              result);
+}
 
-       result = cli_lsa_query_info_policy(&cli, cli.mem_ctx, &lsa_pol, 5, domain, psid);
-       if (!NT_STATUS_IS_OK(result)) {
-               DEBUG(0, ("fetch_domain_sid: Error querying lsa policy handle. %s\n",
-                       nt_errstr(result) ));
-               goto done;
+NTSTATUS rpccli_lsa_lookup_names4(struct rpc_pipe_client *cli,
+                                 TALLOC_CTX *mem_ctx,
+                                 struct policy_handle *pol,
+                                 int num_names,
+                                 const char **names,
+                                 const char ***dom_names,
+                                 int level,
+                                 struct dom_sid **sids,
+                                 enum lsa_SidType **types)
+{
+       NTSTATUS status;
+       NTSTATUS result = NT_STATUS_UNSUCCESSFUL;
+
+       status = dcerpc_lsa_lookup_names4(cli->binding_handle,
+                                         mem_ctx,
+                                         pol,
+                                         num_names,
+                                         names,
+                                         dom_names,
+                                         level,
+                                         sids,
+                                         types,
+                                         &result);
+       if (!NT_STATUS_IS_OK(status)) {
+               return status;
        }
 
-       ret = True;
-
-  done:
-
-       cli_shutdown(&cli);
-       return ret;
+       return result;
 }
-
-#endif