Change order of parameters to smb_register_passdb()
[samba.git] / source3 / passdb / pdb_smbpasswd.c
index 3d81c0c45767da49eb8bc9dbe77aa9cc4ea8f211..c1421bcd53e4e0db29b02b032e7417d37b70a52e 100644 (file)
@@ -1,9 +1,10 @@
 /*
- * Unix SMB/Netbios implementation. 
- * Version 1.9. SMB parameters and setup
+ * Unix SMB/CIFS implementation. 
+ * SMB parameters and setup
  * Copyright (C) Andrew Tridgell 1992-1998 
  * Modified by Jeremy Allison 1995.
  * Modified by Gerald (Jerry) Carter 2000-2001
+ * Modified by Andrew Bartlett 2002.
  * 
  * This program is free software; you can redistribute it and/or modify it under
  * the terms of the GNU General Public License as published by the Free
@@ -22,8 +23,8 @@
 
 #include "includes.h"
 
-#ifdef WITH_SMBPASSWD_SAM
-
+#undef DBGC_CLASS
+#define DBGC_CLASS DBGC_PASSDB
 
 /* 
    smb_passwd is analogous to sam_passwd used everywhere
@@ -33,8 +34,9 @@
  
 struct smb_passwd
 {
-        uid_t smb_userid;     /* this is actually the unix uid_t */
-        char *smb_name;     /* username string */
+        BOOL smb_userid_set;     /* this is actually the unix uid_t */
+        uint32 smb_userid;     /* this is actually the unix uid_t */
+        const char *smb_name;     /* username string */
 
         const unsigned char *smb_passwd; /* Null if no password */
         const unsigned char *smb_nt_passwd; /* Null if no password */
@@ -43,13 +45,29 @@ struct smb_passwd
         time_t pass_last_set_time;    /* password last set time */
 };
 
+struct smbpasswd_privates
+{
+       /* used for maintain locks on the smbpasswd file */
+       int     pw_file_lock_depth;
+       
+       /* Global File pointer */
+       FILE    *pw_file;
+       
+       /* formerly static variables */
+       struct smb_passwd pw_buf;
+       pstring  user_name;
+       unsigned char smbpwd[16];
+       unsigned char smbntpwd[16];
+
+       /* retrive-once info */
+       const char *smbpasswd_file;
 
-extern struct passdb_ops pdb_ops;
+       BOOL permit_non_unix_accounts;
 
-/* used for maintain locks on the smbpasswd file */
-static int     pw_file_lock_depth;
-static void    *global_vp;
+       uint32 low_nua_userid; 
+       uint32 high_nua_userid; 
 
+};
 
 enum pwf_access_type { PWF_READ, PWF_UPDATE, PWF_CREATE };
 
@@ -83,6 +101,10 @@ static BOOL pw_file_unlock(int fd, int *plock_depth)
 {
   BOOL ret=True;
 
+  if (fd == 0 || *plock_depth == 0) {
+         return True;
+  }
+
   if(*plock_depth == 1)
     ret = do_file_lock(fd, 5, F_UNLCK);
 
@@ -116,7 +138,7 @@ static void pdb_init_smb(struct smb_passwd *user)
  been granted to prevent race conditions. JRA.
 ****************************************************************/
 
-static void *startsmbfilepwent(const char *pfile, enum pwf_access_type type, int *lock_depth)
+static FILE *startsmbfilepwent(const char *pfile, enum pwf_access_type type, int *lock_depth)
 {
   FILE *fp = NULL;
   const char *open_mode = NULL;
@@ -164,7 +186,7 @@ static void *startsmbfilepwent(const char *pfile, enum pwf_access_type type, int
     DEBUG(10, ("startsmbfilepwent_internal: opening file %s\n", pfile));
 
     if((fp = sys_fopen(pfile, open_mode)) == NULL) {
-      DEBUG(2, ("startsmbfilepwent_internal: unable to open file %s. Error was %s\n", pfile, strerror(errno) ));
+      DEBUG(0, ("startsmbfilepwent_internal: unable to open file %s. Error was %s\n", pfile, strerror(errno) ));
       return NULL;
     }
 
@@ -238,33 +260,34 @@ Error was %s\n.", pfile, strerror(errno) ));
   }
 
   /* We have a lock on the file. */
-  return (void *)fp;
+  return fp;
 }
 
 /***************************************************************
  End enumeration of the smbpasswd list.
 ****************************************************************/
-static void endsmbfilepwent(void *vp, int *lock_depth)
+static void endsmbfilepwent(FILE *fp, int *lock_depth)
 {
-  FILE *fp = (FILE *)vp;
+       if (!fp) {
+               return;
+       }
 
-  pw_file_unlock(fileno(fp), lock_depth);
-  fclose(fp);
-  DEBUG(7, ("endsmbfilepwent_internal: closed password file.\n"));
+       pw_file_unlock(fileno(fp), lock_depth);
+       fclose(fp);
+       DEBUG(7, ("endsmbfilepwent_internal: closed password file.\n"));
 }
 
 /*************************************************************************
  Routine to return the next entry in the smbpasswd list.
  *************************************************************************/
 
-static struct smb_passwd *getsmbfilepwent(void *vp)
+static struct smb_passwd *getsmbfilepwent(struct smbpasswd_privates *smbpasswd_state, FILE *fp)
 {
   /* Static buffers we will return. */
-  static struct smb_passwd pw_buf;
-  static pstring  user_name;
-  static unsigned char smbpwd[16];
-  static unsigned char smbntpwd[16];
-  FILE *fp = (FILE *)vp;
+  struct smb_passwd *pw_buf = &smbpasswd_state->pw_buf;
+  char  *user_name = smbpasswd_state->user_name;
+  unsigned char *smbpwd = smbpasswd_state->smbpwd;
+  unsigned char *smbntpwd = smbpasswd_state->smbntpwd;
   char            linebuf[256];
   unsigned char   c;
   unsigned char  *p;
@@ -276,9 +299,9 @@ static struct smb_passwd *getsmbfilepwent(void *vp)
     return NULL;
   }
 
-  pdb_init_smb(&pw_buf);
+  pdb_init_smb(pw_buf);
 
-  pw_buf.acct_ctrl = ACB_NORMAL;  
+  pw_buf->acct_ctrl = ACB_NORMAL;  
 
   /*
    * Scan the file, a line at a time and check if the name matches.
@@ -343,6 +366,8 @@ static struct smb_passwd *getsmbfilepwent(void *vp)
      * As 256 is shorter than a pstring we don't need to check
      * length here - if this ever changes....
      */
+    SMB_ASSERT(sizeof(pstring) > sizeof(linebuf));
+
     strncpy(user_name, linebuf, PTR_DIFF(p, linebuf));
     user_name[PTR_DIFF(p, linebuf)] = '\0';
 
@@ -370,8 +395,8 @@ static struct smb_passwd *getsmbfilepwent(void *vp)
       continue;
     }
 
-    pw_buf.smb_name = user_name;
-    pw_buf.smb_userid = uidval;
+    pw_buf->smb_name = user_name;
+    pw_buf->smb_userid = uidval;
 
     /*
      * Now get the password value - this should be 32 hex digits
@@ -382,15 +407,6 @@ static struct smb_passwd *getsmbfilepwent(void *vp)
     /* Skip the ':' */
     p++;
 
-    if (*p == '*' || *p == 'X') {
-      /* Password deliberately invalid - end here. */
-      DEBUG(10, ("getsmbfilepwent: entry invalidated for user %s\n", user_name));
-      pw_buf.smb_nt_passwd = NULL;
-      pw_buf.smb_passwd = NULL;
-      pw_buf.acct_ctrl |= ACB_DISABLED;
-      return &pw_buf;
-    }
-
     if (linebuf_len < (PTR_DIFF(p, linebuf) + 33)) {
       DEBUG(0, ("getsmbfilepwent: malformed password entry (passwd too short)\n"));
       continue;
@@ -402,28 +418,33 @@ static struct smb_passwd *getsmbfilepwent(void *vp)
     }
 
     if (!strncasecmp((char *) p, "NO PASSWORD", 11)) {
-      pw_buf.smb_passwd = NULL;
-      pw_buf.acct_ctrl |= ACB_PWNOTREQ;
+      pw_buf->smb_passwd = NULL;
+      pw_buf->acct_ctrl |= ACB_PWNOTREQ;
     } else {
-      if (!pdb_gethexpwd((char *)p, smbpwd)) {
-        DEBUG(0, ("getsmbfilepwent: Malformed Lanman password entry (non hex chars)\n"));
-        continue;
-      }
-      pw_buf.smb_passwd = smbpwd;
+           if (*p == '*' || *p == 'X') {
+                   /* NULL LM password */
+                   pw_buf->smb_passwd = NULL;
+                   DEBUG(10, ("getsmbfilepwent: LM password for user %s invalidated\n", user_name));
+           } else if (pdb_gethexpwd((char *)p, smbpwd)) {
+                   pw_buf->smb_passwd = smbpwd;
+           } else {
+                   pw_buf->smb_passwd = NULL;
+                   DEBUG(0, ("getsmbfilepwent: Malformed Lanman password entry (non hex chars)\n"));
+           }
     }
 
     /* 
      * Now check if the NT compatible password is
      * available.
      */
-    pw_buf.smb_nt_passwd = NULL;
+    pw_buf->smb_nt_passwd = NULL;
 
     p += 33; /* Move to the first character of the line after
                 the lanman password. */
     if ((linebuf_len >= (PTR_DIFF(p, linebuf) + 33)) && (p[32] == ':')) {
       if (*p != '*' && *p != 'X') {
         if(pdb_gethexpwd((char *)p,smbntpwd))
-          pw_buf.smb_nt_passwd = smbntpwd;
+          pw_buf->smb_nt_passwd = smbntpwd;
       }
       p += 33; /* Move to the first character of the line after
                   the NT password. */
@@ -435,11 +456,11 @@ static struct smb_passwd *getsmbfilepwent(void *vp)
     if (*p == '[')
        {
       unsigned char *end_p = (unsigned char *)strchr_m((char *)p, ']');
-      pw_buf.acct_ctrl = pdb_decode_acct_ctrl((char*)p);
+      pw_buf->acct_ctrl = pdb_decode_acct_ctrl((char*)p);
 
       /* Must have some account type set. */
-      if(pw_buf.acct_ctrl == 0)
-        pw_buf.acct_ctrl = ACB_NORMAL;
+      if(pw_buf->acct_ctrl == 0)
+        pw_buf->acct_ctrl = ACB_NORMAL;
 
       /* Now try and get the last change time. */
       if(end_p)
@@ -459,7 +480,7 @@ static struct smb_passwd *getsmbfilepwent(void *vp)
              * read into a time_t as the seconds since
              * 1970 that the password was last changed.
              */
-            pw_buf.pass_last_set_time = (time_t)strtol((char *)p, NULL, 16);
+            pw_buf->pass_last_set_time = (time_t)strtol((char *)p, NULL, 16);
           }
         }
       }
@@ -470,13 +491,13 @@ static struct smb_passwd *getsmbfilepwent(void *vp)
        * password file as 'normal accounts'. If this changes
        * we will have to fix this code. JRA.
        */
-      if(pw_buf.smb_name[strlen(pw_buf.smb_name) - 1] == '$') {
-        pw_buf.acct_ctrl &= ~ACB_NORMAL;
-        pw_buf.acct_ctrl |= ACB_WSTRUST;
+      if(pw_buf->smb_name[strlen(pw_buf->smb_name) - 1] == '$') {
+        pw_buf->acct_ctrl &= ~ACB_NORMAL;
+        pw_buf->acct_ctrl |= ACB_WSTRUST;
       }
     }
 
-    return &pw_buf;
+    return pw_buf;
   }
 
   DEBUG(5,("getsmbfilepwent: end of file reached.\n"));
@@ -492,7 +513,6 @@ static char *format_new_smbpasswd_entry(const struct smb_passwd *newpwd)
   int new_entry_length;
   char *new_entry;
   char *p;
-  int i;
 
   new_entry_length = strlen(newpwd->smb_name) + 1 + 15 + 1 + 32 + 1 + 32 + 1 + NEW_PW_FORMAT_SPACE_PADDED_LEN + 1 + 13 + 2;
 
@@ -502,38 +522,16 @@ static char *format_new_smbpasswd_entry(const struct smb_passwd *newpwd)
   }
 
   slprintf(new_entry, new_entry_length - 1, "%s:%u:", newpwd->smb_name, (unsigned)newpwd->smb_userid);
-  p = &new_entry[strlen(new_entry)];
 
-  if(newpwd->smb_passwd != NULL) {
-    for( i = 0; i < 16; i++) {
-      slprintf((char *)&p[i*2], new_entry_length - (p - new_entry) - 1, "%02X", newpwd->smb_passwd[i]);
-    }
-  } else {
-    i=0;
-    if(newpwd->acct_ctrl & ACB_PWNOTREQ)
-      safe_strcpy((char *)p, "NO PASSWORDXXXXXXXXXXXXXXXXXXXXX", new_entry_length - 1 - (p - new_entry));
-    else
-      safe_strcpy((char *)p, "XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX", new_entry_length - 1 - (p - new_entry));
-  }
+  p = new_entry+strlen(new_entry);
   
-  p += 32;
-
-  *p++ = ':';
+  pdb_sethexpwd(p, newpwd->smb_passwd, newpwd->acct_ctrl);
 
-  if(newpwd->smb_nt_passwd != NULL) {
-    for( i = 0; i < 16; i++) {
-      slprintf((char *)&p[i*2], new_entry_length - 1 - (p - new_entry), "%02X", newpwd->smb_nt_passwd[i]);
-    }
-  } else {
-    if(newpwd->acct_ctrl & ACB_PWNOTREQ)
-      safe_strcpy((char *)p, "NO PASSWORDXXXXXXXXXXXXXXXXXXXXX", new_entry_length - 1 - (p - new_entry));
-    else
-      safe_strcpy((char *)p, "XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX", new_entry_length - 1 - (p - new_entry));
-  }
+  p+=strlen(p); *p = ':'; p++;
 
-  p += 32;
+  pdb_sethexpwd(p, newpwd->smb_nt_passwd, newpwd->acct_ctrl);
 
-  *p++ = ':';
+  p+=strlen(p); *p = ':'; p++;
 
   /* Add the account encoding and the last change time. */
   slprintf((char *)p, new_entry_length - 1 - (p - new_entry),  "%s:LCT-%08X:\n",
@@ -547,9 +545,9 @@ static char *format_new_smbpasswd_entry(const struct smb_passwd *newpwd)
  Routine to add an entry to the smbpasswd file.
 *************************************************************************/
 
-static BOOL add_smbfilepwd_entry(const struct smb_passwd *newpwd)
+static BOOL add_smbfilepwd_entry(struct smbpasswd_privates *smbpasswd_state, struct smb_passwd *newpwd)
 {
-  char *pfile = lp_smb_passwd_file();
+  const char *pfile = smbpasswd_state->smbpasswd_file;
   struct smb_passwd *pwd = NULL;
   FILE *fp = NULL;
   int wr_len;
@@ -557,13 +555,14 @@ static BOOL add_smbfilepwd_entry(const struct smb_passwd *newpwd)
   size_t new_entry_length;
   char *new_entry;
   SMB_OFF_T offpos;
-
+  uint32 max_found_uid = 0;
   /* Open the smbpassword file - for update. */
-  fp = startsmbfilepwent(pfile, PWF_UPDATE, &pw_file_lock_depth);
+  fp = startsmbfilepwent(pfile, PWF_UPDATE, &(smbpasswd_state->pw_file_lock_depth));
 
   if (fp == NULL && errno == ENOENT) {
        /* Try again - create. */
-       fp = startsmbfilepwent(pfile, PWF_CREATE, &pw_file_lock_depth);
+       fp = startsmbfilepwent(pfile, PWF_CREATE, &(smbpasswd_state->pw_file_lock_depth));
   }
 
   if (fp == NULL) {
@@ -575,18 +574,45 @@ static BOOL add_smbfilepwd_entry(const struct smb_passwd *newpwd)
    * Scan the file, a line at a time and check if the name matches.
    */
 
-  while ((pwd = getsmbfilepwent(fp)) != NULL) 
+  while ((pwd = getsmbfilepwent(smbpasswd_state, fp)) != NULL) 
   {
     if (strequal(newpwd->smb_name, pwd->smb_name)) 
     {
        DEBUG(0, ("add_smbfilepwd_entry: entry with name %s already exists\n", pwd->smb_name));
-       endsmbfilepwent(fp, &pw_file_lock_depth);
+       endsmbfilepwent(fp, &(smbpasswd_state->pw_file_lock_depth));
        return False;
     }
-  }
+    
+    /* Look for a free uid for use in non-unix accounts */
+    if (pwd->smb_userid > max_found_uid) {
+           max_found_uid = pwd->smb_userid;
+    }
+   }
 
   /* Ok - entry doesn't exist. We can add it */
 
+  /* Account not in /etc/passwd hack!!! */
+  if (!newpwd->smb_userid_set) {
+         if (!smbpasswd_state->permit_non_unix_accounts) {
+                 DEBUG(0, ("add_smbfilepwd_entry: cannot add account %s without unix identity\n", newpwd->smb_name));
+                 endsmbfilepwent(fp, &(smbpasswd_state->pw_file_lock_depth));
+                 return False;
+         }
+
+         if (max_found_uid < smbpasswd_state->low_nua_userid) {
+                 newpwd->smb_userid = smbpasswd_state->low_nua_userid;
+                 newpwd->smb_userid_set = True;
+         } else if (max_found_uid >= smbpasswd_state->high_nua_userid) {
+                 DEBUG(0, ("add_smbfilepwd_entry: cannot add machine %s, no uids are free! \n", newpwd->smb_name));
+                 endsmbfilepwent(fp, &(smbpasswd_state->pw_file_lock_depth));
+                 return False;           
+         } else {
+                 newpwd->smb_userid = max_found_uid + 1;
+                 newpwd->smb_userid_set = True;
+         }
+  }
+
+
   /* Create a new smb passwd entry and set it to the given password. */
   /* 
    * The add user write needs to be atomic - so get the fd from 
@@ -598,7 +624,7 @@ static BOOL add_smbfilepwd_entry(const struct smb_passwd *newpwd)
   {
        DEBUG(0, ("add_smbfilepwd_entry(sys_lseek): Failed to add entry for user %s to file %s. \
 Error was %s\n", newpwd->smb_name, pfile, strerror(errno)));
-       endsmbfilepwent(fp, &pw_file_lock_depth);
+       endsmbfilepwent(fp, &(smbpasswd_state->pw_file_lock_depth));
        return False;
   }
 
@@ -606,7 +632,7 @@ Error was %s\n", newpwd->smb_name, pfile, strerror(errno)));
   {
        DEBUG(0, ("add_smbfilepwd_entry(malloc): Failed to add entry for user %s to file %s. \
 Error was %s\n", newpwd->smb_name, pfile, strerror(errno)));
-       endsmbfilepwent(fp, &pw_file_lock_depth);
+       endsmbfilepwent(fp, &(smbpasswd_state->pw_file_lock_depth));
        return False;
   }
 
@@ -630,13 +656,13 @@ Error was %s. Password file may be corrupt ! Please examine by hand !\n",
                newpwd->smb_name, strerror(errno)));
        }
 
-       endsmbfilepwent(fp, &pw_file_lock_depth);
+       endsmbfilepwent(fp, &(smbpasswd_state->pw_file_lock_depth));
        free(new_entry);
        return False;
   }
 
   free(new_entry);
-  endsmbfilepwent(fp, &pw_file_lock_depth);
+  endsmbfilepwent(fp, &(smbpasswd_state->pw_file_lock_depth));
   return True;
 }
 
@@ -649,10 +675,10 @@ Error was %s. Password file may be corrupt ! Please examine by hand !\n",
  override = True, override XXXXXXXX'd out password or NO PASS
 ************************************************************************/
 
-static BOOL mod_smbfilepwd_entry(const struct smb_passwd* pwd, BOOL override)
+static BOOL mod_smbfilepwd_entry(struct smbpasswd_privates *smbpasswd_state, const struct smb_passwd* pwd)
 {
   /* Static buffers we will return. */
-  static pstring  user_name;
+       pstring user_name;
 
   char            linebuf[256];
   char            readbuf[1024];
@@ -663,7 +689,7 @@ static BOOL mod_smbfilepwd_entry(const struct smb_passwd* pwd, BOOL override)
   size_t            linebuf_len = 0;
   FILE           *fp;
   int             lockfd;
-  char           *pfile = lp_smb_passwd_file();
+  const char     *pfile = smbpasswd_state->smbpasswd_file;
   BOOL found_entry = False;
   BOOL got_pass_last_set_time = False;
 
@@ -690,7 +716,7 @@ static BOOL mod_smbfilepwd_entry(const struct smb_passwd* pwd, BOOL override)
 
   lockfd = fileno(fp);
 
-  if (!pw_file_lock(lockfd, F_WRLCK, 5, &pw_file_lock_depth)) {
+  if (!pw_file_lock(lockfd, F_WRLCK, 5, &(smbpasswd_state->pw_file_lock_depth))) {
     DEBUG(0, ("mod_smbfilepwd_entry: unable to lock file %s\n", pfile));
     fclose(fp);
     return False;
@@ -710,7 +736,7 @@ static BOOL mod_smbfilepwd_entry(const struct smb_passwd* pwd, BOOL override)
 
     fgets(linebuf, sizeof(linebuf), fp);
     if (ferror(fp)) {
-      pw_file_unlock(lockfd, &pw_file_lock_depth);
+      pw_file_unlock(lockfd, &(smbpasswd_state->pw_file_lock_depth));
       fclose(fp);
       return False;
     }
@@ -770,6 +796,9 @@ static BOOL mod_smbfilepwd_entry(const struct smb_passwd* pwd, BOOL override)
      * As 256 is shorter than a pstring we don't need to check
      * length here - if this ever changes....
      */
+
+    SMB_ASSERT(sizeof(user_name) > sizeof(linebuf));
+
     strncpy(user_name, linebuf, PTR_DIFF(p, linebuf));
     user_name[PTR_DIFF(p, linebuf)] = '\0';
     if (strequal(user_name, pwd->smb_name)) {
@@ -779,8 +808,11 @@ static BOOL mod_smbfilepwd_entry(const struct smb_passwd* pwd, BOOL override)
   }
 
   if (!found_entry) {
-    pw_file_unlock(lockfd, &pw_file_lock_depth);
+    pw_file_unlock(lockfd, &(smbpasswd_state->pw_file_lock_depth));
     fclose(fp);
+
+    DEBUG(2, ("Cannot update entry for user %s, as they don't exist in the smbpasswd file!\n",
+             pwd->smb_name));
     return False;
   }
 
@@ -791,7 +823,7 @@ static BOOL mod_smbfilepwd_entry(const struct smb_passwd* pwd, BOOL override)
 
   if (!isdigit(*p)) {
     DEBUG(0, ("mod_smbfilepwd_entry: malformed password entry (uid not number)\n"));
-    pw_file_unlock(lockfd, &pw_file_lock_depth);
+    pw_file_unlock(lockfd, &(smbpasswd_state->pw_file_lock_depth));
     fclose(fp);
     return False;
   }
@@ -800,7 +832,7 @@ static BOOL mod_smbfilepwd_entry(const struct smb_passwd* pwd, BOOL override)
     p++;
   if (*p != ':') {
     DEBUG(0, ("mod_smbfilepwd_entry: malformed password entry (no : after uid)\n"));
-    pw_file_unlock(lockfd, &pw_file_lock_depth);
+    pw_file_unlock(lockfd, &(smbpasswd_state->pw_file_lock_depth));
     fclose(fp);
     return False;
   }
@@ -815,30 +847,16 @@ static BOOL mod_smbfilepwd_entry(const struct smb_passwd* pwd, BOOL override)
   /* Record exact password position */
   pwd_seekpos += PTR_DIFF(p, linebuf);
 
-  if (!override && (*p == '*' || *p == 'X')) {
-    /* Password deliberately invalid - end here. */
-    DEBUG(10, ("mod_smbfilepwd_entry: entry invalidated for user %s\n", user_name));
-    pw_file_unlock(lockfd, &pw_file_lock_depth);
-    fclose(fp);
-    return False;
-  }
-
   if (linebuf_len < (PTR_DIFF(p, linebuf) + 33)) {
     DEBUG(0, ("mod_smbfilepwd_entry: malformed password entry (passwd too short)\n"));
-    pw_file_unlock(lockfd,&pw_file_lock_depth);
+    pw_file_unlock(lockfd,&(smbpasswd_state->pw_file_lock_depth));
     fclose(fp);
     return (False);
   }
 
   if (p[32] != ':') {
     DEBUG(0, ("mod_smbfilepwd_entry: malformed password entry (no terminating :)\n"));
-    pw_file_unlock(lockfd,&pw_file_lock_depth);
-    fclose(fp);
-    return False;
-  }
-
-  if (!override && (*p == '*' || *p == 'X')) {
-    pw_file_unlock(lockfd,&pw_file_lock_depth);
+    pw_file_unlock(lockfd,&(smbpasswd_state->pw_file_lock_depth));
     fclose(fp);
     return False;
   }
@@ -849,14 +867,14 @@ static BOOL mod_smbfilepwd_entry(const struct smb_passwd* pwd, BOOL override)
               the lanman password. */
   if (linebuf_len < (PTR_DIFF(p, linebuf) + 33)) {
     DEBUG(0, ("mod_smbfilepwd_entry: malformed password entry (passwd too short)\n"));
-    pw_file_unlock(lockfd,&pw_file_lock_depth);
+    pw_file_unlock(lockfd,&(smbpasswd_state->pw_file_lock_depth));
     fclose(fp);
     return (False);
   }
 
   if (p[32] != ':') {
     DEBUG(0, ("mod_smbfilepwd_entry: malformed password entry (no terminating :)\n"));
-    pw_file_unlock(lockfd,&pw_file_lock_depth);
+    pw_file_unlock(lockfd,&(smbpasswd_state->pw_file_lock_depth));
     fclose(fp);
     return False;
   }
@@ -921,30 +939,12 @@ static BOOL mod_smbfilepwd_entry(const struct smb_passwd* pwd, BOOL override)
   /* Entry is correctly formed. */
 
   /* Create the 32 byte representation of the new p16 */
-  if(pwd->smb_passwd != NULL) {
-    for (i = 0; i < 16; i++) {
-      slprintf(&ascii_p16[i*2], sizeof(fstring) - 1, "%02X", (uchar) pwd->smb_passwd[i]);
-    }
-  } else {
-    if(pwd->acct_ctrl & ACB_PWNOTREQ)
-      fstrcpy(ascii_p16, "NO PASSWORDXXXXXXXXXXXXXXXXXXXXX");
-    else
-      fstrcpy(ascii_p16, "XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX");
-  }
+  pdb_sethexpwd(ascii_p16, pwd->smb_passwd, pwd->acct_ctrl);
 
   /* Add on the NT md4 hash */
   ascii_p16[32] = ':';
   wr_len = 66;
-  if (pwd->smb_nt_passwd != NULL) {
-    for (i = 0; i < 16; i++) {
-      slprintf(&ascii_p16[(i*2)+33], sizeof(fstring) - 1, "%02X", (uchar) pwd->smb_nt_passwd[i]);
-    }
-  } else {
-    if(pwd->acct_ctrl & ACB_PWNOTREQ)
-      fstrcpy(&ascii_p16[33], "NO PASSWORDXXXXXXXXXXXXXXXXXXXXX");
-    else
-      fstrcpy(&ascii_p16[33], "XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX");
-  }
+  pdb_sethexpwd(ascii_p16+33, pwd->smb_nt_passwd, pwd->acct_ctrl);
   ascii_p16[65] = ':';
   ascii_p16[66] = '\0'; /* null-terminate the string so that strlen works */
 
@@ -966,7 +966,7 @@ static BOOL mod_smbfilepwd_entry(const struct smb_passwd* pwd, BOOL override)
 
   if(wr_len > sizeof(linebuf)) {
     DEBUG(0, ("mod_smbfilepwd_entry: line to write (%d) is too long.\n", wr_len+1));
-    pw_file_unlock(lockfd,&pw_file_lock_depth);
+    pw_file_unlock(lockfd,&(smbpasswd_state->pw_file_lock_depth));
     fclose(fp);
     return (False);
   }
@@ -984,7 +984,7 @@ static BOOL mod_smbfilepwd_entry(const struct smb_passwd* pwd, BOOL override)
 
   if (sys_lseek(fd, pwd_seekpos - 1, SEEK_SET) != pwd_seekpos - 1) {
     DEBUG(0, ("mod_smbfilepwd_entry: seek fail on file %s.\n", pfile));
-    pw_file_unlock(lockfd,&pw_file_lock_depth);
+    pw_file_unlock(lockfd,&(smbpasswd_state->pw_file_lock_depth));
     fclose(fp);
     return False;
   }
@@ -992,33 +992,33 @@ static BOOL mod_smbfilepwd_entry(const struct smb_passwd* pwd, BOOL override)
   /* Sanity check - ensure the areas we are writing are framed by ':' */
   if (read(fd, linebuf, wr_len+1) != wr_len+1) {
     DEBUG(0, ("mod_smbfilepwd_entry: read fail on file %s.\n", pfile));
-    pw_file_unlock(lockfd,&pw_file_lock_depth);
+    pw_file_unlock(lockfd,&(smbpasswd_state->pw_file_lock_depth));
     fclose(fp);
     return False;
   }
 
   if ((linebuf[0] != ':') || (linebuf[wr_len] != ':')) {
     DEBUG(0, ("mod_smbfilepwd_entry: check on passwd file %s failed.\n", pfile));
-    pw_file_unlock(lockfd,&pw_file_lock_depth);
+    pw_file_unlock(lockfd,&(smbpasswd_state->pw_file_lock_depth));
     fclose(fp);
     return False;
   }
  
   if (sys_lseek(fd, pwd_seekpos, SEEK_SET) != pwd_seekpos) {
     DEBUG(0, ("mod_smbfilepwd_entry: seek fail on file %s.\n", pfile));
-    pw_file_unlock(lockfd,&pw_file_lock_depth);
+    pw_file_unlock(lockfd,&(smbpasswd_state->pw_file_lock_depth));
     fclose(fp);
     return False;
   }
 
   if (write(fd, ascii_p16, wr_len) != wr_len) {
     DEBUG(0, ("mod_smbfilepwd_entry: write failed in passwd file %s\n", pfile));
-    pw_file_unlock(lockfd,&pw_file_lock_depth);
+    pw_file_unlock(lockfd,&(smbpasswd_state->pw_file_lock_depth));
     fclose(fp);
     return False;
   }
 
-  pw_file_unlock(lockfd,&pw_file_lock_depth);
+  pw_file_unlock(lockfd,&(smbpasswd_state->pw_file_lock_depth));
   fclose(fp);
   return True;
 }
@@ -1027,9 +1027,9 @@ static BOOL mod_smbfilepwd_entry(const struct smb_passwd* pwd, BOOL override)
  Routine to delete an entry in the smbpasswd file by name.
 *************************************************************************/
 
-static BOOL del_smbfilepwd_entry(const char *name)
+static BOOL del_smbfilepwd_entry(struct smbpasswd_privates *smbpasswd_state, const char *name)
 {
-  char *pfile = lp_smb_passwd_file();
+       const char *pfile = smbpasswd_state->smbpasswd_file;
   pstring pfile2;
   struct smb_passwd *pwd = NULL;
   FILE *fp = NULL;
@@ -1044,7 +1044,7 @@ static BOOL del_smbfilepwd_entry(const char *name)
    * it.
    */
 
-  if((fp = startsmbfilepwent(pfile, PWF_UPDATE, &pw_file_lock_depth)) == NULL) {
+  if((fp = startsmbfilepwent(pfile, PWF_UPDATE, &(smbpasswd_state->pw_file_lock_depth))) == NULL) {
     DEBUG(0, ("del_smbfilepwd_entry: unable to open file %s.\n", pfile));
     return False;
   }
@@ -1054,7 +1054,7 @@ static BOOL del_smbfilepwd_entry(const char *name)
    */
   if((fp_write = startsmbfilepwent(pfile2, PWF_CREATE, &pfile2_lockdepth)) == NULL) {
     DEBUG(0, ("del_smbfilepwd_entry: unable to open file %s.\n", pfile));
-    endsmbfilepwent(fp, &pw_file_lock_depth);
+    endsmbfilepwent(fp, &(smbpasswd_state->pw_file_lock_depth));
     return False;
   }
 
@@ -1062,7 +1062,7 @@ static BOOL del_smbfilepwd_entry(const char *name)
    * Scan the file, a line at a time and check if the name matches.
    */
 
-  while ((pwd = getsmbfilepwent(fp)) != NULL) {
+  while ((pwd = getsmbfilepwent(smbpasswd_state, fp)) != NULL) {
     char *new_entry;
     size_t new_entry_length;
 
@@ -1080,7 +1080,7 @@ static BOOL del_smbfilepwd_entry(const char *name)
        DEBUG(0, ("del_smbfilepwd_entry(malloc): Failed to copy entry for user %s to file %s. \
 Error was %s\n", pwd->smb_name, pfile2, strerror(errno)));
        unlink(pfile2);
-       endsmbfilepwent(fp, &pw_file_lock_depth);
+       endsmbfilepwent(fp, &(smbpasswd_state->pw_file_lock_depth));
        endsmbfilepwent(fp_write, &pfile2_lockdepth);
        return False;
     }
@@ -1092,7 +1092,7 @@ Error was %s\n", pwd->smb_name, pfile2, strerror(errno)));
        DEBUG(0, ("del_smbfilepwd_entry(write): Failed to copy entry for user %s to file %s. \
 Error was %s\n", pwd->smb_name, pfile2, strerror(errno)));
        unlink(pfile2);
-       endsmbfilepwent(fp, &pw_file_lock_depth);
+       endsmbfilepwent(fp, &(smbpasswd_state->pw_file_lock_depth));
        endsmbfilepwent(fp_write, &pfile2_lockdepth);
        free(new_entry);
        return False;
@@ -1108,7 +1108,7 @@ Error was %s\n", pwd->smb_name, pfile2, strerror(errno)));
   if(fflush(fp_write) != 0) 
   {
        DEBUG(0, ("del_smbfilepwd_entry: Failed to flush file %s. Error was %s\n", pfile2, strerror(errno)));
-       endsmbfilepwent(fp, &pw_file_lock_depth);
+       endsmbfilepwent(fp, &(smbpasswd_state->pw_file_lock_depth));
        endsmbfilepwent(fp_write,&pfile2_lockdepth);
        return False;
   }
@@ -1121,7 +1121,7 @@ Error was %s\n", pwd->smb_name, pfile2, strerror(errno)));
     unlink(pfile2);
   }
   
-  endsmbfilepwent(fp, &pw_file_lock_depth);
+  endsmbfilepwent(fp, &(smbpasswd_state->pw_file_lock_depth));
   endsmbfilepwent(fp_write,&pfile2_lockdepth);
   return True;
 }
@@ -1134,22 +1134,30 @@ Error was %s\n", pwd->smb_name, pfile2, strerror(errno)));
 static BOOL build_smb_pass (struct smb_passwd *smb_pw, const SAM_ACCOUNT *sampass)
 {
        uid_t uid;
-       gid_t gid;
 
        if (sampass == NULL) 
                return False;
-       uid = pdb_get_uid(sampass);
-       gid = pdb_get_gid(sampass);
-
-       if (!IS_SAM_UNIX_USER(sampass)) {
-               DEBUG(0,("build_sam_pass: Failing attempt to store user without a UNIX uid or gid. \n"));
-               return False;
-       }
 
        ZERO_STRUCTP(smb_pw);
+        if (!IS_SAM_UNIX_USER(sampass)) {
+               smb_pw->smb_userid_set = False;
+               DEBUG(5,("build_smb_pass: storing user without a UNIX uid or gid. \n"));
+       } else {
+               uint32 rid = pdb_get_user_rid(sampass);
+               smb_pw->smb_userid_set = True;
+               uid = pdb_get_uid(sampass);
 
-       smb_pw->smb_userid=uid;
-       smb_pw->smb_name=(char*)pdb_get_username(sampass);
+               /* If the user specified a RID, make sure its able to be both stored and retreived */
+               if (rid && rid != DOMAIN_USER_RID_GUEST && uid != fallback_pdb_user_rid_to_uid(rid)) {
+                       DEBUG(0,("build_sam_pass: Failing attempt to store user with non-uid based user RID. \n"));
+                       return False;
+               }
+
+               smb_pw->smb_userid=uid;
+        }
+
+       smb_pw->smb_name=(const char*)pdb_get_username(sampass);
 
        smb_pw->smb_passwd=pdb_get_lanman_passwd(sampass);
        smb_pw->smb_nt_passwd=pdb_get_nt_passwd(sampass);
@@ -1157,11 +1165,6 @@ static BOOL build_smb_pass (struct smb_passwd *smb_pw, const SAM_ACCOUNT *sampas
        smb_pw->acct_ctrl=pdb_get_acct_ctrl(sampass);
        smb_pw->pass_last_set_time=pdb_get_pass_last_set_time(sampass);
 
-       if (uid != pdb_user_rid_to_uid(pdb_get_user_rid(sampass))) {
-               DEBUG(0,("build_sam_pass: Failing attempt to store user with non-uid based user RID. \n"));
-               return False;
-       }
-
 #if 0
        /*
         * ifdef'out by JFM on 11/29/2001.
@@ -1187,7 +1190,8 @@ static BOOL build_smb_pass (struct smb_passwd *smb_pw, const SAM_ACCOUNT *sampas
 /*********************************************************************
  Create a SAM_ACCOUNT from a smb_passwd struct
  ********************************************************************/
-static BOOL build_sam_account(SAM_ACCOUNT *sam_pass, const struct smb_passwd *pw_buf)
+static BOOL build_sam_account(struct smbpasswd_privates *smbpasswd_state, 
+                             SAM_ACCOUNT *sam_pass, const struct smb_passwd *pw_buf)
 {
        struct passwd *pwfile;
        
@@ -1196,151 +1200,129 @@ static BOOL build_sam_account(SAM_ACCOUNT *sam_pass, const struct smb_passwd *pw
                return False;
        }
                
-       /* Verify in system password file...
-          FIXME!!!  This is where we should look up an internal
-          mapping of allocated uid for machine accounts as well 
-          --jerry */ 
-       pwfile = sys_getpwnam(pw_buf->smb_name);
+       pwfile = getpwnam_alloc(pw_buf->smb_name);
        if (pwfile == NULL) {
-               DEBUG(0,("build_sam_account: smbpasswd database is corrupt!  username %s not in unix passwd database!\n", pw_buf->smb_name));
-               return False;
-       }
-
-       pdb_set_uid (sam_pass, pwfile->pw_uid);
-       pdb_set_gid (sam_pass, pwfile->pw_gid);
-               
-       pdb_set_fullname(sam_pass, pwfile->pw_gecos);           
-       
-       pdb_set_user_rid(sam_pass, pdb_uid_to_user_rid (pwfile->pw_uid));
-
-       {
-               uint32 rid;
-               GROUP_MAP map;
-       
-               if (get_group_map_from_gid(pwfile->pw_gid, &map, MAPPING_WITHOUT_PRIV)) {
-                       sid_peek_rid(&map.sid, &rid);
+               if ((smbpasswd_state->permit_non_unix_accounts) 
+                   && (pw_buf->smb_userid >= smbpasswd_state->low_nua_userid) 
+                   && (pw_buf->smb_userid <= smbpasswd_state->high_nua_userid)) {
+
+                       pdb_set_user_sid_from_rid(sam_pass, fallback_pdb_uid_to_user_rid (pw_buf->smb_userid), PDB_SET);
+                       
+                       /* lkclXXXX this is OBSERVED behaviour by NT PDCs, enforced here. 
+                          
+                       This was down the bottom for machines, but it looks pretty good as
+                       a general default for non-unix users. --abartlet 2002-01-08
+                       */
+                       pdb_set_group_sid_from_rid (sam_pass, DOMAIN_GROUP_RID_USERS, PDB_SET); 
+                       pdb_set_username (sam_pass, pw_buf->smb_name, PDB_SET);
+                       pdb_set_domain (sam_pass, lp_workgroup(), PDB_DEFAULT);
+                       
+               } else {
+                       DEBUG(0,("build_sam_account: smbpasswd database is corrupt!  username %s with uid %u is not in unix passwd database!\n", pw_buf->smb_name, pw_buf->smb_userid));
+                       return False;
                }
-               else 
-                       rid=pdb_gid_to_group_rid(pwfile->pw_gid);
-
-               pdb_set_group_rid(sam_pass, rid); 
+       } else {
+               if (!NT_STATUS_IS_OK(pdb_fill_sam_pw(sam_pass, pwfile))) {
+                       return False;
+               }
+               
+               passwd_free(&pwfile);
        }
        
-       pdb_set_username (sam_pass, pw_buf->smb_name);
-       pdb_set_nt_passwd (sam_pass, pw_buf->smb_nt_passwd);
-       pdb_set_lanman_passwd (sam_pass, pw_buf->smb_passwd);                   
-       pdb_set_acct_ctrl (sam_pass, pw_buf->acct_ctrl);
-       pdb_set_pass_last_set_time (sam_pass, pw_buf->pass_last_set_time);
-       pdb_set_pass_can_change_time (sam_pass, pw_buf->pass_last_set_time);
-       pdb_set_domain (sam_pass, lp_workgroup());
+       pdb_set_nt_passwd (sam_pass, pw_buf->smb_nt_passwd, PDB_SET);
+       pdb_set_lanman_passwd (sam_pass, pw_buf->smb_passwd, PDB_SET);                  
+       pdb_set_acct_ctrl (sam_pass, pw_buf->acct_ctrl, PDB_SET);
+       pdb_set_pass_last_set_time (sam_pass, pw_buf->pass_last_set_time, PDB_SET);
+       pdb_set_pass_can_change_time (sam_pass, pw_buf->pass_last_set_time, PDB_SET);
        
-       pdb_set_dir_drive     (sam_pass, lp_logon_drive(), False);
-
 #if 0  /* JERRY */
        /* the smbpasswd format doesn't have a must change time field, so
           we can't get this right. The best we can do is to set this to 
           some time in the future. 21 days seems as reasonable as any other value :) 
        */
-       pdb_set_pass_must_change_time (sam_pass, pw_buf->pass_last_set_time + MAX_PASSWORD_AGE);
+       pdb_set_pass_must_change_time (sam_pass, pw_buf->pass_last_set_time + MAX_PASSWORD_AGE, PDB_DEFAULT);
 #endif
-       /* check if this is a user account or a machine account */
-       if (pw_buf->smb_name[strlen(pw_buf->smb_name)-1] != '$')
-       {
-               pstring         str;
-               
-               pstrcpy(str, lp_logon_path());
-               standard_sub_advanced(-1, pwfile->pw_name, "", pwfile->pw_gid, pw_buf->smb_name, str);
-               pdb_set_profile_path(sam_pass, str, False);
-               
-               pstrcpy(str, lp_logon_home());
-               standard_sub_advanced(-1, pwfile->pw_name, "", pwfile->pw_gid, pw_buf->smb_name, str);
-               pdb_set_homedir(sam_pass, str, False);
-               
-               pstrcpy(str, lp_logon_drive());
-               standard_sub_advanced(-1, pwfile->pw_name, "", pwfile->pw_gid, pw_buf->smb_name, str);
-               pdb_set_dir_drive(sam_pass, str, False);
-               
-               pstrcpy(str, lp_logon_script());
-               standard_sub_advanced(-1, pwfile->pw_name, "", pwfile->pw_gid, pw_buf->smb_name, str);
-               pdb_set_logon_script(sam_pass, str, False);
-               
-       } else {
-               /* lkclXXXX this is OBSERVED behaviour by NT PDCs, enforced here. */
-               /*pdb_set_group_rid (sam_pass, DOMAIN_GROUP_RID_USERS); */
-       }
-       
        return True;
 }
+
 /*****************************************************************
  Functions to be implemented by the new passdb API 
  ****************************************************************/
-BOOL pdb_setsampwent (BOOL update)
+static NTSTATUS smbpasswd_setsampwent (struct pdb_methods *my_methods, BOOL update)
 {
-       global_vp = startsmbfilepwent(lp_smb_passwd_file(), 
-                               update ? PWF_UPDATE : PWF_READ, 
-                               &pw_file_lock_depth);
+       struct smbpasswd_privates *smbpasswd_state = (struct smbpasswd_privates*)my_methods->private_data;
+       
+       smbpasswd_state->pw_file = startsmbfilepwent(smbpasswd_state->smbpasswd_file, 
+                                                      update ? PWF_UPDATE : PWF_READ, 
+                                                      &(smbpasswd_state->pw_file_lock_depth));
                                   
        /* did we fail?  Should we try to create it? */
-       if (!global_vp && update && errno == ENOENT) 
+       if (!smbpasswd_state->pw_file && update && errno == ENOENT) 
        {
                FILE *fp;
                /* slprintf(msg_str,msg_str_len-1,
-                       "smbpasswd file did not exist - attempting to create it.\n"); */
+                  "smbpasswd file did not exist - attempting to create it.\n"); */
                DEBUG(0,("smbpasswd file did not exist - attempting to create it.\n"));
-               fp = sys_fopen(lp_smb_passwd_file(), "w");
+               fp = sys_fopen(smbpasswd_state->smbpasswd_file, "w");
                if (fp) 
                {
                        fprintf(fp, "# Samba SMB password file\n");
                        fclose(fp);
                }
                
-               global_vp = startsmbfilepwent(lp_smb_passwd_file()
-                                       update ? PWF_UPDATE : PWF_READ, 
-                                       &pw_file_lock_depth);
+               smbpasswd_state->pw_file = startsmbfilepwent(smbpasswd_state->smbpasswd_file
+                                                            update ? PWF_UPDATE : PWF_READ, 
+                                                            &(smbpasswd_state->pw_file_lock_depth));
        }
        
-       return (global_vp != NULL);                
+       if (smbpasswd_state->pw_file != NULL)
+               return NT_STATUS_OK;
+       else
+               return NT_STATUS_UNSUCCESSFUL;  
 }
 
-void pdb_endsampwent (void)
+static void smbpasswd_endsampwent (struct pdb_methods *my_methods)
 {
-       endsmbfilepwent(global_vp, &pw_file_lock_depth);
+       struct smbpasswd_privates *smbpasswd_state = (struct smbpasswd_privates*)my_methods->private_data;
+       endsmbfilepwent(smbpasswd_state->pw_file, &(smbpasswd_state->pw_file_lock_depth));
 }
  
 /*****************************************************************
  ****************************************************************/
-BOOL pdb_getsampwent(SAM_ACCOUNT *user)
+static NTSTATUS smbpasswd_getsampwent(struct pdb_methods *my_methods, SAM_ACCOUNT *user)
 {
+       NTSTATUS nt_status = NT_STATUS_UNSUCCESSFUL;
+       struct smbpasswd_privates *smbpasswd_state = (struct smbpasswd_privates*)my_methods->private_data;
        struct smb_passwd *pw_buf=NULL;
        BOOL done = False;
        DEBUG(5,("pdb_getsampwent\n"));
 
        if (user==NULL) {
-               DEBUG(5,("pdb_getsampwent: user is NULL\n"));
+               DEBUG(5,("pdb_getsampwent (smbpasswd): user is NULL\n"));
 #if 0
-               smb_panic("NULL pointer passed to pdb_getsampwent\n");
+               smb_panic("NULL pointer passed to getsampwent (smbpasswd)\n");
 #endif
-               return False;
+               return nt_status;
        }
 
        while (!done)
        {
                /* do we have an entry? */
-               pw_buf = getsmbfilepwent(global_vp);
+               pw_buf = getsmbfilepwent(smbpasswd_state, smbpasswd_state->pw_file);
                if (pw_buf == NULL) 
-                       return False;
+                       return nt_status;
 
                /* build the SAM_ACCOUNT entry from the smb_passwd struct. 
                   We loop in case the user in the pdb does not exist in 
                   the local system password file */
-               if (build_sam_account(user, pw_buf))
+               if (build_sam_account(smbpasswd_state, user, pw_buf))
                        done = True;
        }
 
-       DEBUG(5,("pdb_getsampwent:done\n"));
+       DEBUG(5,("getsampwent (smbpasswd): done\n"));
 
        /* success */
-       return True;
+       return NT_STATUS_OK;
 }
 
 
@@ -1349,157 +1331,238 @@ BOOL pdb_getsampwent(SAM_ACCOUNT *user)
  call getpwnam() for unix account information until we have found
  the correct entry
  ***************************************************************/
-BOOL pdb_getsampwnam(SAM_ACCOUNT *sam_acct, const char *username)
+static NTSTATUS smbpasswd_getsampwnam(struct pdb_methods *my_methods, 
+                                 SAM_ACCOUNT *sam_acct, const char *username)
 {
+       NTSTATUS nt_status = NT_STATUS_UNSUCCESSFUL;
+       struct smbpasswd_privates *smbpasswd_state = (struct smbpasswd_privates*)my_methods->private_data;
        struct smb_passwd *smb_pw;
        void *fp = NULL;
-       char *domain = NULL;
-       char *user = NULL;
-       fstring name;
 
-       DEBUG(10, ("pdb_getsampwnam: search by name: %s\n", username));
-
-       
-       /* break the username from the domain if we have 
-          been given a string in the form 'DOMAIN\user' */
-       fstrcpy (name, username);
-       if ((user=strchr_m(name, '\\')) != NULL) {
-               domain = name;
-               *user = '\0';
-               user++;
-       }
-       
-       /* if a domain was specified and it wasn't ours
-          then there is no chance of matching */
-       if ( domain && !StrCaseCmp(domain, lp_workgroup()) )
-               return False;
+       DEBUG(10, ("getsampwnam (smbpasswd): search by name: %s\n", username));
 
        /* startsmbfilepwent() is used here as we don't want to lookup
           the UNIX account in the local system password file until
           we have a match.  */
-       fp = startsmbfilepwent(lp_smb_passwd_file(), PWF_READ, &pw_file_lock_depth);
+       fp = startsmbfilepwent(smbpasswd_state->smbpasswd_file, PWF_READ, &(smbpasswd_state->pw_file_lock_depth));
 
        if (fp == NULL) {
                DEBUG(0, ("unable to open passdb database.\n"));
-               return False;
+               return nt_status;
        }
 
-       /* if we have a domain name, then we should map it to a UNIX 
-          username first */
-       if ( domain )
-               map_username(user);
-
-       while ( ((smb_pw=getsmbfilepwent(fp)) != NULL)&& (!strequal(smb_pw->smb_name, username)) )
+       while ( ((smb_pw=getsmbfilepwent(smbpasswd_state, fp)) != NULL)&& (!strequal(smb_pw->smb_name, username)) )
                /* do nothing....another loop */ ;
        
-       endsmbfilepwent(fp, &pw_file_lock_depth);
+       endsmbfilepwent(fp, &(smbpasswd_state->pw_file_lock_depth));
 
 
        /* did we locate the username in smbpasswd  */
        if (smb_pw == NULL)
-               return False;
+               return nt_status;
        
-       DEBUG(10, ("pdb_getsampwnam: found by name: %s\n", smb_pw->smb_name));
+       DEBUG(10, ("getsampwnam (smbpasswd): found by name: %s\n", smb_pw->smb_name));
 
        if (!sam_acct) {
-               DEBUG(10,("pdb_getsampwnam:SAM_ACCOUNT is NULL\n"));
+               DEBUG(10,("getsampwnam (smbpasswd): SAM_ACCOUNT is NULL\n"));
 #if 0
                smb_panic("NULL pointer passed to pdb_getsampwnam\n");
 #endif
-               return False;
+               return nt_status;
        }
                
        /* now build the SAM_ACCOUNT */
-       if (!build_sam_account(sam_acct, smb_pw))
-               return False;
+       if (!build_sam_account(smbpasswd_state, sam_acct, smb_pw))
+               return nt_status;
 
        /* success */
-       return True;
+       return NT_STATUS_OK;
 }
 
-
-BOOL pdb_getsampwrid(SAM_ACCOUNT *sam_acct,uint32 rid)
+static NTSTATUS smbpasswd_getsampwsid(struct pdb_methods *my_methods, SAM_ACCOUNT *sam_acct, const DOM_SID *sid)
 {
+       NTSTATUS nt_status = NT_STATUS_UNSUCCESSFUL;
+       struct smbpasswd_privates *smbpasswd_state = (struct smbpasswd_privates*)my_methods->private_data;
        struct smb_passwd *smb_pw;
        void *fp = NULL;
+       fstring sid_str;
+       uint32 rid;
+       
+       DEBUG(10, ("smbpasswd_getsampwrid: search by sid: %s\n", sid_to_string(sid_str, sid)));
 
-       DEBUG(10, ("pdb_getsampwrid: search by rid: %d\n", rid));
+       if (!sid_peek_check_rid(get_global_sam_sid(), sid, &rid))
+               return NT_STATUS_UNSUCCESSFUL;
+
+       /* More special case 'guest account' hacks... */
+       if (rid == DOMAIN_USER_RID_GUEST) {
+               const char *guest_account = lp_guestaccount();
+               if (!(guest_account && *guest_account)) {
+                       DEBUG(1, ("Guest account not specfied!\n"));
+                       return nt_status;
+               }
+               return smbpasswd_getsampwnam(my_methods, sam_acct, guest_account);
+       }
 
        /* Open the sam password file - not for update. */
-       fp = startsmbfilepwent(lp_smb_passwd_file(), PWF_READ, &pw_file_lock_depth);
+       fp = startsmbfilepwent(smbpasswd_state->smbpasswd_file, PWF_READ, &(smbpasswd_state->pw_file_lock_depth));
 
        if (fp == NULL) {
                DEBUG(0, ("unable to open passdb database.\n"));
-               return False;
+               return nt_status;
        }
 
-       while ( ((smb_pw=getsmbfilepwent(fp)) != NULL) && (pdb_uid_to_user_rid(smb_pw->smb_userid) != rid) )
+       while ( ((smb_pw=getsmbfilepwent(smbpasswd_state, fp)) != NULL) && (fallback_pdb_uid_to_user_rid(smb_pw->smb_userid) != rid) )
                /* do nothing */ ;
 
-       endsmbfilepwent(fp, &pw_file_lock_depth);
+       endsmbfilepwent(fp, &(smbpasswd_state->pw_file_lock_depth));
 
 
        /* did we locate the username in smbpasswd  */
        if (smb_pw == NULL)
-               return False;
+               return nt_status;
        
-       DEBUG(10, ("pdb_getsampwrid: found by name: %s\n", smb_pw->smb_name));
+       DEBUG(10, ("getsampwrid (smbpasswd): found by name: %s\n", smb_pw->smb_name));
                
        if (!sam_acct) {
-               DEBUG(10,("pdb_getsampwrid:SAM_ACCOUNT is NULL\n"));
+               DEBUG(10,("getsampwrid: (smbpasswd) SAM_ACCOUNT is NULL\n"));
 #if 0
                smb_panic("NULL pointer passed to pdb_getsampwrid\n");
 #endif
-               return False;
+               return nt_status;
        }
 
        /* now build the SAM_ACCOUNT */
-       if (!build_sam_account (sam_acct, smb_pw))
-               return False;
+       if (!build_sam_account (smbpasswd_state, sam_acct, smb_pw))
+               return nt_status;
+
+       /* build_sam_account might change the SID on us, if the name was for the guest account */
+       if (NT_STATUS_IS_OK(nt_status) && !sid_equal(pdb_get_user_sid(sam_acct), sid)) {
+               fstring sid_string1, sid_string2;
+               DEBUG(1, ("looking for user with sid %s instead returned %s for account %s!?!\n",
+                         sid_to_string(sid_string1, sid), sid_to_string(sid_string2, pdb_get_user_sid(sam_acct)), pdb_get_username(sam_acct)));
+               return NT_STATUS_NO_SUCH_USER;
+       }
 
        /* success */
-       return True;
+       return NT_STATUS_OK;
 }
 
-BOOL pdb_add_sam_account(const SAM_ACCOUNT *sampass)
+static NTSTATUS smbpasswd_add_sam_account(struct pdb_methods *my_methods, SAM_ACCOUNT *sampass)
 {
+       struct smbpasswd_privates *smbpasswd_state = (struct smbpasswd_privates*)my_methods->private_data;
        struct smb_passwd smb_pw;
        
        /* convert the SAM_ACCOUNT */
        if (!build_smb_pass(&smb_pw, sampass)) {
-               return False;
+               return NT_STATUS_UNSUCCESSFUL;
        }
        
        /* add the entry */
-       if(!add_smbfilepwd_entry(&smb_pw)) {
-               return False;
+       if(!add_smbfilepwd_entry(smbpasswd_state, &smb_pw)) {
+               return NT_STATUS_UNSUCCESSFUL;
        }
-
-       return True;
+       
+       return NT_STATUS_OK;
 }
 
-BOOL pdb_update_sam_account(const SAM_ACCOUNT *sampass, BOOL override)
+static NTSTATUS smbpasswd_update_sam_account(struct pdb_methods *my_methods, SAM_ACCOUNT *sampass)
 {
+       struct smbpasswd_privates *smbpasswd_state = (struct smbpasswd_privates*)my_methods->private_data;
        struct smb_passwd smb_pw;
        
        /* convert the SAM_ACCOUNT */
-       if (!build_smb_pass(&smb_pw, sampass))
-               return False;
+       if (!build_smb_pass(&smb_pw, sampass)) {
+               DEBUG(0, ("smbpasswd_update_sam_account: build_smb_pass failed!\n"));
+               return NT_STATUS_UNSUCCESSFUL;
+       }
        
        /* update the entry */
-       if(!mod_smbfilepwd_entry(&smb_pw, override))
-               return False;
-               
-       return True;
+       if(!mod_smbfilepwd_entry(smbpasswd_state, &smb_pw)) {
+               DEBUG(0, ("smbpasswd_update_sam_account: mod_smbfilepwd_entry failed!\n"));
+               return NT_STATUS_UNSUCCESSFUL;
+       }
+       
+       return NT_STATUS_OK;
 }
 
-BOOL pdb_delete_sam_account (const char* username)
+static NTSTATUS smbpasswd_delete_sam_account (struct pdb_methods *my_methods, SAM_ACCOUNT *sampass)
 {
-       return del_smbfilepwd_entry(username);
+       struct smbpasswd_privates *smbpasswd_state = (struct smbpasswd_privates*)my_methods->private_data;
+
+       const char *username = pdb_get_username(sampass);
+
+       if (del_smbfilepwd_entry(smbpasswd_state, username))
+               return NT_STATUS_OK;
+
+       return NT_STATUS_UNSUCCESSFUL;
 }
 
-#else
- /* Do *NOT* make this function static. It breaks the compile on gcc. JRA */
- void smbpass_dummy_function(void) { } /* stop some compilers complaining */
-#endif /* WTH_SMBPASSWD_SAM*/
+static void free_private_data(void **vp) 
+{
+       struct smbpasswd_privates **privates = (struct smbpasswd_privates**)vp;
+       
+       endsmbfilepwent((*privates)->pw_file, &((*privates)->pw_file_lock_depth));
+       
+       *privates = NULL;
+       /* No need to free any further, as it is talloc()ed */
+}
+
+NTSTATUS pdb_init_smbpasswd(PDB_CONTEXT *pdb_context, PDB_METHODS **pdb_method, const char *location)
+{
+       NTSTATUS nt_status;
+       struct smbpasswd_privates *privates;
+
+       if (!NT_STATUS_IS_OK(nt_status = make_pdb_methods(pdb_context->mem_ctx, pdb_method))) {
+               return nt_status;
+       }
+
+       (*pdb_method)->name = "smbpasswd";
+
+       (*pdb_method)->setsampwent = smbpasswd_setsampwent;
+       (*pdb_method)->endsampwent = smbpasswd_endsampwent;
+       (*pdb_method)->getsampwent = smbpasswd_getsampwent;
+       (*pdb_method)->getsampwnam = smbpasswd_getsampwnam;
+       (*pdb_method)->getsampwsid = smbpasswd_getsampwsid;
+       (*pdb_method)->add_sam_account = smbpasswd_add_sam_account;
+       (*pdb_method)->update_sam_account = smbpasswd_update_sam_account;
+       (*pdb_method)->delete_sam_account = smbpasswd_delete_sam_account;
 
+       /* Setup private data and free function */
+
+       privates = talloc_zero(pdb_context->mem_ctx, sizeof(struct smbpasswd_privates));
+
+       if (!privates) {
+               DEBUG(0, ("talloc() failed for smbpasswd private_data!\n"));
+               return NT_STATUS_NO_MEMORY;
+       }
+
+       /* Store some config details */
+
+       if (location) {
+               privates->smbpasswd_file = talloc_strdup(pdb_context->mem_ctx, location);
+       } else {
+               privates->smbpasswd_file = talloc_strdup(pdb_context->mem_ctx, lp_smb_passwd_file());
+       }
+       
+       if (!privates->smbpasswd_file) {
+               DEBUG(0, ("talloc_strdp() failed for storing smbpasswd location!\n"));
+               return NT_STATUS_NO_MEMORY;
+       }
+
+       (*pdb_method)->private_data = privates;
+
+       (*pdb_method)->free_private_data = free_private_data;
+
+       if (lp_idmap_uid(&privates->low_nua_userid, &privates->high_nua_userid)) {
+               DEBUG(0, ("idmap uid range defined, non unix accounts enabled\n"));
+               privates->permit_non_unix_accounts = True;
+       }
+
+       return NT_STATUS_OK;
+}
+
+int pdb_smbpasswd_init(void) 
+{
+       smb_register_passdb(PASSDB_INTERFACE_VERSION, "smbpasswd", pdb_init_smbpasswd);
+       return True;
+}